comaniac commented on pull request #7564:
URL: https://github.com/apache/tvm/pull/7564#issuecomment-804670541
> We did explore using the same fix as for Ethos-N (giving a 'null'
ConstantUpdater), but this doesn't work for ACL as ACL does load the constants
from MetadataModule. Ethos-N
comaniac commented on pull request #7564:
URL: https://github.com/apache/tvm/pull/7564#issuecomment-789155976
> I doubt that what was implemented in Ethos-N is applicable to ACL (ACL
relies on JSON codegen and Ethos-N uses C). Could you elaborate you proposal?
I think this is not
comaniac commented on pull request #7564:
URL: https://github.com/apache/tvm/pull/7564#issuecomment-789145492
> I noticed that there is a check implemented for demanding codegen_name to
be placed first
comaniac commented on pull request #7564:
URL: https://github.com/apache/tvm/pull/7564#issuecomment-789120609
> Agree, However it still looks to me as the agreement to put `codegen_name`
as prefix for const naming. Bth, would it help if for filtering out external
consts regexp `^p[0-9]+$`
comaniac commented on pull request #7564:
URL: https://github.com/apache/tvm/pull/7564#issuecomment-789105015
`ConstantUpdater` can be customized as introduced in this #6697, so the
parameter naming convention is not guaranteed.
comaniac commented on pull request #7564:
URL: https://github.com/apache/tvm/pull/7564#issuecomment-789085923
It seems to me that the parameter name prefix doesn't indicate if it is in
the external module or metadata module? Could you show some use cases?
cc @zhiics
