[GitHub] [tvm] slyubomirsky commented on pull request #7318: [BYOC][WIP][potential bug?] Figuring out annotations for let expressions

2021-01-28 Thread GitBox
slyubomirsky commented on pull request #7318: URL: https://github.com/apache/tvm/pull/7318#issuecomment-769545493 @comaniac @zhiics I'm not sure I quite understand how let nodes are being handled in the code. I think the reason for the weird behavior in the given test case is that when

[GitHub] [tvm] slyubomirsky commented on pull request #7318: [BYOC][WIP][potential bug?] Figuring out annotations for let expressions

2021-01-28 Thread GitBox
slyubomirsky commented on pull request #7318: URL: https://github.com/apache/tvm/pull/7318#issuecomment-769519345 Based on the discussion in the thread, it seems the final output of the let note should have a compiler_end annotation on it (the intended tagging behavior is described