[GitHub] [incubator-tvm] abergeron commented on a change in pull request #4303: [TOPI][Relay][OP] Add a strided_set operation.

abergeron commented on a change in pull request #4303: [TOPI][Relay][OP] Add a strided_set operation. URL: https://github.com/apache/incubator-tvm/pull/4303#discussion_r346912399 ## File path: topi/python/topi/transform.py ## @@ -155,6 +157,78 @@ def strided_slice(a,

[GitHub] [incubator-tvm] abergeron commented on issue #4303: [TOPI][Relay][OP] Add a strided_set operation.

abergeron commented on issue #4303: [TOPI][Relay][OP] Add a strided_set operation. URL: https://github.com/apache/incubator-tvm/pull/4303#issuecomment-554435076 @yzhliu It can be used for the gradient of strided_slice in Relay, but is also an operation we need for myia

[GitHub] [incubator-tvm] vinx13 commented on a change in pull request #4344: [ThreadPool] Solve thread transitions issue

vinx13 commented on a change in pull request #4344: [ThreadPool] Solve thread transitions issue URL: https://github.com/apache/incubator-tvm/pull/4344#discussion_r346911411 ## File path: src/runtime/thread_pool.cc ## @@ -370,11 +374,7 @@ class ThreadPool { // number of

[GitHub] [incubator-tvm] FrozenGene commented on a change in pull request #4344: [ThreadPool] Solve thread transitions issue

FrozenGene commented on a change in pull request #4344: [ThreadPool] Solve thread transitions issue URL: https://github.com/apache/incubator-tvm/pull/4344#discussion_r346910933 ## File path: src/runtime/thread_pool.cc ## @@ -370,11 +374,7 @@ class ThreadPool { //

[GitHub] [incubator-tvm] abergeron commented on a change in pull request #4303: [TOPI][Relay][OP] Add a strided_set operation.

abergeron commented on a change in pull request #4303: [TOPI][Relay][OP] Add a strided_set operation. URL: https://github.com/apache/incubator-tvm/pull/4303#discussion_r346910496 ## File path: topi/python/topi/transform.py ## @@ -155,6 +157,78 @@ def strided_slice(a,

[GitHub] [incubator-tvm] petrex commented on issue #4342: Add workgroup size attribute to AMDGPU functions in codegen

petrex commented on issue #4342: Add workgroup size attribute to AMDGPU functions in codegen URL: https://github.com/apache/incubator-tvm/pull/4342#issuecomment-554433825 Thanks, @t-vi Can you sort out the CI issues? I saw tests fail, jut not sure if it is valid.

[GitHub] [incubator-tvm] vinx13 commented on a change in pull request #4344: [ThreadPool] Solve thread transitions issue

vinx13 commented on a change in pull request #4344: [ThreadPool] Solve thread transitions issue URL: https://github.com/apache/incubator-tvm/pull/4344#discussion_r346909944 ## File path: src/runtime/thread_pool.cc ## @@ -370,11 +374,7 @@ class ThreadPool { // number of

[GitHub] [incubator-tvm] vinx13 commented on a change in pull request #4344: [ThreadPool] Solve thread transitions issue

vinx13 commented on a change in pull request #4344: [ThreadPool] Solve thread transitions issue URL: https://github.com/apache/incubator-tvm/pull/4344#discussion_r346909944 ## File path: src/runtime/thread_pool.cc ## @@ -370,11 +374,7 @@ class ThreadPool { // number of

[GitHub] [incubator-tvm] abergeron commented on a change in pull request #4303: [TOPI][Relay][OP] Add a strided_set operation.

abergeron commented on a change in pull request #4303: [TOPI][Relay][OP] Add a strided_set operation. URL: https://github.com/apache/incubator-tvm/pull/4303#discussion_r346909974 ## File path: python/tvm/relay/op/_transform.py ## @@ -304,6 +305,31 @@ def

[GitHub] [incubator-tvm] petrex commented on a change in pull request #4342: Add workgroup size attribute to AMDGPU functions in codegen

petrex commented on a change in pull request #4342: Add workgroup size attribute to AMDGPU functions in codegen URL: https://github.com/apache/incubator-tvm/pull/4342#discussion_r346909319 ## File path: src/codegen/llvm/codegen_amdgpu.cc ## @@ -36,13 +36,39 @@ namespace

[GitHub] [incubator-tvm] abergeron commented on a change in pull request #4303: [TOPI][Relay][OP] Add a strided_set operation.

abergeron commented on a change in pull request #4303: [TOPI][Relay][OP] Add a strided_set operation. URL: https://github.com/apache/incubator-tvm/pull/4303#discussion_r346909365 ## File path: python/tvm/relay/op/_transform.py ## @@ -304,6 +305,31 @@ def

[GitHub] [incubator-tvm] abergeron commented on issue #4318: [Relay][TOPI]Fix meaning of conv2d_transpose output_padding parameter

abergeron commented on issue #4318: [Relay][TOPI]Fix meaning of conv2d_transpose output_padding parameter URL: https://github.com/apache/incubator-tvm/pull/4318#issuecomment-554430766 This is not super time critical, so you can take time to make sure it works properly. But I would

[GitHub] [incubator-tvm] alexgl-github opened a new pull request #4347: Bump up CUDA log version in tophub.py

alexgl-github opened a new pull request #4347: Bump up CUDA log version in tophub.py URL: https://github.com/apache/incubator-tvm/pull/4347 Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request

[GitHub] [incubator-tvm] iotamudelta commented on a change in pull request #4342: Add workgroup size attribute to AMDGPU functions in codegen

iotamudelta commented on a change in pull request #4342: Add workgroup size attribute to AMDGPU functions in codegen URL: https://github.com/apache/incubator-tvm/pull/4342#discussion_r346894323 ## File path: src/codegen/llvm/codegen_amdgpu.cc ## @@ -36,13 +36,39 @@

[GitHub] [incubator-tvm] cchung100m commented on issue #4271: [Relay][Frontend][ONNX] operator support: DepthToSpace, SpaceToDepth

cchung100m commented on issue #4271: [Relay][Frontend][ONNX] operator support: DepthToSpace, SpaceToDepth URL: https://github.com/apache/incubator-tvm/pull/4271#issuecomment-554387021 Hi @jroesch @soiferj @zhiics I would appreciate that if you can review/manage this PR, thank you.

[GitHub] [incubator-tvm] cchung100m commented on issue #4271: [Relay][Frontend][ONNX] operator support: DepthToSpace, SpaceToDepth

cchung100m commented on issue #4271: [Relay][Frontend][ONNX] operator support: DepthToSpace, SpaceToDepth URL: https://github.com/apache/incubator-tvm/pull/4271#issuecomment-554385357 @jwfromm It is my pleasure to work with you on this PR and I do learn a lot, thanks.

[GitHub] [incubator-tvm] jackwish commented on a change in pull request #4338: AutoTVM: selecting tuning templates when extracting task

jackwish commented on a change in pull request #4338: AutoTVM: selecting tuning templates when extracting task URL: https://github.com/apache/incubator-tvm/pull/4338#discussion_r346720164 ## File path: python/tvm/autotvm/task/relay_integration.py ## @@ -153,15 +154,25 @@

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #4338: AutoTVM: selecting tuning templates when extracting task

comaniac commented on a change in pull request #4338: AutoTVM: selecting tuning templates when extracting task URL: https://github.com/apache/incubator-tvm/pull/4338#discussion_r346710057 ## File path: python/tvm/autotvm/task/relay_integration.py ## @@ -153,15 +154,25 @@

[GitHub] [incubator-tvm] jackwish commented on issue #3859: [WIP] [AutoTVM][TOPI] NHWC conv2d templates for ARM

jackwish commented on issue #3859: [WIP] [AutoTVM][TOPI] NHWC conv2d templates for ARM URL: https://github.com/apache/incubator-tvm/pull/3859#issuecomment-554268629 Thank you for the review @snowolfhawk ! I will update later (I have been working on some other thing on parallel).

[GitHub] [incubator-tvm] jackwish edited a comment on issue #4338: AutoTVM: selecting tuning templates when extracting task

jackwish edited a comment on issue #4338: AutoTVM: selecting tuning templates when extracting task URL: https://github.com/apache/incubator-tvm/pull/4338#issuecomment-554266385 Comments addressed, please have a look into this when you are available :) @comaniac @tmoreau89 @vinx13

[GitHub] [incubator-tvm] jackwish commented on issue #4338: AutoTVM: selecting tuning templates when extracting task

jackwish commented on issue #4338: AutoTVM: selecting tuning templates when extracting task URL: https://github.com/apache/incubator-tvm/pull/4338#issuecomment-554266385 Comments addressed, please have a look into this when you are available. For the template key dict part, now have

[GitHub] [incubator-tvm] liangfu edited a comment on issue #4293: [VTA] Bug fix for padded load with large inputs

liangfu edited a comment on issue #4293: [VTA] Bug fix for padded load with large inputs URL: https://github.com/apache/incubator-tvm/pull/4293#issuecomment-554261281 > one known issue is that the padded load test fails on Pynq (but not in fsim); so I was wondering if some changes to the

[GitHub] [incubator-tvm] liangfu edited a comment on issue #4293: [VTA] Bug fix for padded load with large inputs

liangfu edited a comment on issue #4293: [VTA] Bug fix for padded load with large inputs URL: https://github.com/apache/incubator-tvm/pull/4293#issuecomment-554261281 > one known issue is that the padded load test fails on Pynq (but not in fsim); so I was wondering if some changes to the

[GitHub] [incubator-tvm] liangfu commented on issue #4293: [VTA] Bug fix for padded load with large inputs

liangfu commented on issue #4293: [VTA] Bug fix for padded load with large inputs URL: https://github.com/apache/incubator-tvm/pull/4293#issuecomment-554261281 > one known issue is that the padded load test fails on Pynq (but not in fsim); so I was wondering if some changes to the test

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #4275: imp module is deprecated

junrushao1994 commented on a change in pull request #4275: imp module is deprecated URL: https://github.com/apache/incubator-tvm/pull/4275#discussion_r346701189 ## File path: topi/python/topi/cpp/vision/__init__.py ## @@ -0,0 +1,7 @@ +"""FFI for vision TOPI ops and

[GitHub] [incubator-tvm] were commented on a change in pull request #4275: imp module is deprecated

were commented on a change in pull request #4275: imp module is deprecated URL: https://github.com/apache/incubator-tvm/pull/4275#discussion_r346700641 ## File path: topi/python/topi/cpp/vision/__init__.py ## @@ -0,0 +1,7 @@ +"""FFI for vision TOPI ops and schedules"""

[GitHub] [incubator-tvm] were commented on a change in pull request #4275: imp module is deprecated

were commented on a change in pull request #4275: imp module is deprecated URL: https://github.com/apache/incubator-tvm/pull/4275#discussion_r346700234 ## File path: topi/python/topi/cpp/vision/__init__.py ## @@ -0,0 +1,7 @@ +"""FFI for vision TOPI ops and schedules"""

<    1   2