[incubator-tvm] branch master updated: [Relay, Topi][OP] affine_grid and grid_sample (#5657)

2020-05-22 Thread masahi
This is an automated email from the ASF dual-hosted git repository. masahi pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git The following commit(s) were added to refs/heads/master by this push: new e369c5a [Relay,Topi][OP] affine_grid

[GitHub] [incubator-tvm] masahi commented on pull request #5657: [Relay,Topi][OP] affine_grid and grid_sample

2020-05-22 Thread GitBox
masahi commented on pull request #5657: URL: https://github.com/apache/incubator-tvm/pull/5657#issuecomment-632985707 Thanks @vinx13 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-tvm] masahi merged pull request #5657: [Relay,Topi][OP] affine_grid and grid_sample

2020-05-22 Thread GitBox
masahi merged pull request #5657: URL: https://github.com/apache/incubator-tvm/pull/5657 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-tvm] mei-ye commented on pull request #5659: [TARGET] enable amd_apu device on vulkan target

2020-05-22 Thread GitBox
mei-ye commented on pull request #5659: URL: https://github.com/apache/incubator-tvm/pull/5659#issuecomment-632981824 yes, I will check in log to tophub after this. This also fixes two bugs in vulkan runtime: maxComputeWorkGroupInvocations: the maximum total number of compute shader

[GitHub] [incubator-tvm] masahi merged pull request #5653: [PatternLang] Convert PatternGrouper to do pre-order, non-recursive analysis

2020-05-22 Thread GitBox
masahi merged pull request #5653: URL: https://github.com/apache/incubator-tvm/pull/5653 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-tvm] masahi commented on pull request #5653: [PatternLang] Convert PatternGrouper to do pre-order, non-recursive analysis

2020-05-22 Thread GitBox
masahi commented on pull request #5653: URL: https://github.com/apache/incubator-tvm/pull/5653#issuecomment-632977181 Thanks @mbrookhart @comaniac This is an automated message from the Apache Git Service. To respond to the

[incubator-tvm] branch master updated: [PatternLang] Convert PatternGrouper to do pre-order, non-recursive analysis (#5653)

2020-05-22 Thread masahi
This is an automated email from the ASF dual-hosted git repository. masahi pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git The following commit(s) were added to refs/heads/master by this push: new 53251c8 [PatternLang] Convert

[GitHub] [incubator-tvm] tqchen merged pull request #5658: Upgrade XGBoost to latest

2020-05-22 Thread GitBox
tqchen merged pull request #5658: URL: https://github.com/apache/incubator-tvm/pull/5658 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-tvm] tqchen merged pull request #5660: [uTVM] Increase bss section size.

2020-05-22 Thread GitBox
tqchen merged pull request #5660: URL: https://github.com/apache/incubator-tvm/pull/5660 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[incubator-tvm] branch master updated: Increase bss section size. (#5660)

2020-05-22 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git The following commit(s) were added to refs/heads/master by this push: new e2d66e1 Increase bss section size.

[incubator-tvm] branch master updated: Upgrade XGBoost to latest (#5658)

2020-05-22 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git The following commit(s) were added to refs/heads/master by this push: new 3827cd0 Upgrade XGBoost to latest

[GitHub] [incubator-tvm] tmoreau89 commented on pull request #5659: [TARGET] enable amd_apu device on vulkan target

2020-05-22 Thread GitBox
tmoreau89 commented on pull request #5659: URL: https://github.com/apache/incubator-tvm/pull/5659#issuecomment-632969624 Could you also add in the comments that there are a couple fixes applied to the Vulkan runtime? Because this PR could be technically split into two (bug fixes to Vulkan

[GitHub] [incubator-tvm] tmoreau89 commented on pull request #5659: [TARGET] enable amd_apu device on vulkan target

2020-05-22 Thread GitBox
tmoreau89 commented on pull request #5659: URL: https://github.com/apache/incubator-tvm/pull/5659#issuecomment-632969425 Never mind the other PR was already closed. This is an automated message from the Apache Git Service.

[GitHub] [incubator-tvm] tmoreau89 commented on pull request #5659: [TARGET] enable amd_apu device on vulkan target

2020-05-22 Thread GitBox
tmoreau89 commented on pull request #5659: URL: https://github.com/apache/incubator-tvm/pull/5659#issuecomment-632969349 Thanks you @mei-ye I'll close your other PR since it's a duplicate of this one. One question: do you also intend on uploading logs into TopHub for the v1000?

[GitHub] [incubator-tvm] comaniac opened a new issue #5662: [PatternLang] Lift constant nodes to partitioned function arguments

2020-05-22 Thread GitBox
comaniac opened a new issue #5662: URL: https://github.com/apache/incubator-tvm/issues/5662 In #5656, we found that `pattern.partition` will not lift the bind constant nodes to the partitioned function arguments. This results in argument mismatch and could be a potential problem when

[GitHub] [incubator-tvm] areusch opened a new pull request #5661: add tvm.micro pydoc to sphinx

2020-05-22 Thread GitBox
areusch opened a new pull request #5661: URL: https://github.com/apache/incubator-tvm/pull/5661 Just adding API docs for now This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-tvm] tom-gall commented on pull request #5660: [uTVM] Increase bss section size.

2020-05-22 Thread GitBox
tom-gall commented on pull request #5660: URL: https://github.com/apache/incubator-tvm/pull/5660#issuecomment-632953040 Tested on my stm32F746. Back to working. Thanks @areusch This is an automated message from the Apache

[GitHub] [incubator-tvm] comaniac commented on pull request #5656: [BYOC] Pattern Language MergeComposite

2020-05-22 Thread GitBox
comaniac commented on pull request #5656: URL: https://github.com/apache/incubator-tvm/pull/5656#issuecomment-632944262 > @comaniac I just ran this test. The two fused layer test at https://github.com/apache/incubator-tvm/blob/master/tests/python/relay/test_pass_partition_graph.py#L932

[GitHub] [incubator-tvm] masahi edited a comment on pull request #5656: [BYOC] Pattern Language MergeComposite

2020-05-22 Thread GitBox
masahi edited a comment on pull request #5656: URL: https://github.com/apache/incubator-tvm/pull/5656#issuecomment-632940481 @comaniac I just ran this test. The two fused layer test at https://github.com/apache/incubator-tvm/blob/master/tests/python/relay/test_pass_partition_graph.py#L932

[GitHub] [incubator-tvm] masahi commented on pull request #5656: [BYOC] Pattern Language MergeComposite

2020-05-22 Thread GitBox
masahi commented on pull request #5656: URL: https://github.com/apache/incubator-tvm/pull/5656#issuecomment-632940481 @comaniac I just ran this test. The two fused layer test at https://github.com/apache/incubator-tvm/blob/master/tests/python/relay/test_pass_partition_graph.py#L932 works,

[GitHub] [incubator-tvm] comaniac edited a comment on pull request #5656: [BYOC] Pattern Language MergeComposite

2020-05-22 Thread GitBox
comaniac edited a comment on pull request #5656: URL: https://github.com/apache/incubator-tvm/pull/5656#issuecomment-632938583 @masahi I found that `test_dnnl_fuse` in `test_pass_partition_graph` is actually failed at the DNNL code compilation, but it won't fail the CI because we don't

[GitHub] [incubator-tvm] comaniac edited a comment on pull request #5656: [BYOC] Pattern Language MergeComposite

2020-05-22 Thread GitBox
comaniac edited a comment on pull request #5656: URL: https://github.com/apache/incubator-tvm/pull/5656#issuecomment-632938583 @masahi I found that `test_dnnl_fuse` in `test_pass_partition_graph` is actually failed at the DNNL code compilation, but it won't fail the CI because we don't

[GitHub] [incubator-tvm] comaniac commented on pull request #5656: [BYOC] Pattern Language MergeComposite

2020-05-22 Thread GitBox
comaniac commented on pull request #5656: URL: https://github.com/apache/incubator-tvm/pull/5656#issuecomment-632938583 @masahi I found that `test_dnnl_fuse` in `test_pass_partition_graph` is actually failed at the DNNL code compilation, but it won't fail the CI because we don't have DNNL

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #5656: [BYOC] Pattern Language MergeComposite

2020-05-22 Thread GitBox
comaniac commented on a change in pull request #5656: URL: https://github.com/apache/incubator-tvm/pull/5656#discussion_r429484128 ## File path: tests/python/relay/test_pass_merge_composite.py ## @@ -64,55 +65,53 @@ def make_add_sub_mul_pattern(): -"""Create a pattern

[GitHub] [incubator-tvm] mbrookhart commented on a change in pull request #5656: [BYOC] Pattern Language MergeComposite

2020-05-22 Thread GitBox
mbrookhart commented on a change in pull request #5656: URL: https://github.com/apache/incubator-tvm/pull/5656#discussion_r429476254 ## File path: tests/python/relay/test_pass_merge_composite.py ## @@ -64,55 +65,53 @@ def make_add_sub_mul_pattern(): -"""Create a

[GitHub] [incubator-tvm] masahi commented on a change in pull request #5653: [PatternLang] Convert PatternGrouper to do pre-order, non-recursive analysis

2020-05-22 Thread GitBox
masahi commented on a change in pull request #5653: URL: https://github.com/apache/incubator-tvm/pull/5653#discussion_r429478715 ## File path: src/relay/ir/dataflow_matcher.cc ## @@ -432,26 +432,39 @@ class PatternGrouper : protected MixedModeVisitor { const std::vector&

[GitHub] [incubator-tvm] masahi commented on a change in pull request #5653: [PatternLang] Convert PatternGrouper to do pre-order, non-recursive analysis

2020-05-22 Thread GitBox
masahi commented on a change in pull request #5653: URL: https://github.com/apache/incubator-tvm/pull/5653#discussion_r429478715 ## File path: src/relay/ir/dataflow_matcher.cc ## @@ -432,26 +432,39 @@ class PatternGrouper : protected MixedModeVisitor { const std::vector&

[GitHub] [incubator-tvm] mbrookhart commented on a change in pull request #5653: [PatternLang] Convert PatternGrouper to do pre-order, non-recursive analysis

2020-05-22 Thread GitBox
mbrookhart commented on a change in pull request #5653: URL: https://github.com/apache/incubator-tvm/pull/5653#discussion_r429477690 ## File path: src/relay/ir/dataflow_matcher.cc ## @@ -432,26 +432,39 @@ class PatternGrouper : protected MixedModeVisitor { const

[GitHub] [incubator-tvm] masahi commented on a change in pull request #5653: [PatternLang] Convert PatternGrouper to do pre-order, non-recursive analysis

2020-05-22 Thread GitBox
masahi commented on a change in pull request #5653: URL: https://github.com/apache/incubator-tvm/pull/5653#discussion_r429477179 ## File path: src/relay/ir/dataflow_matcher.cc ## @@ -432,26 +432,39 @@ class PatternGrouper : protected MixedModeVisitor { const std::vector&

[GitHub] [incubator-tvm] masahi commented on a change in pull request #5653: [PatternLang] Convert PatternGrouper to do pre-order, non-recursive analysis

2020-05-22 Thread GitBox
masahi commented on a change in pull request #5653: URL: https://github.com/apache/incubator-tvm/pull/5653#discussion_r429477179 ## File path: src/relay/ir/dataflow_matcher.cc ## @@ -432,26 +432,39 @@ class PatternGrouper : protected MixedModeVisitor { const std::vector&

[GitHub] [incubator-tvm] areusch commented on pull request #5660: Increase bss section size.

2020-05-22 Thread GitBox
areusch commented on pull request #5660: URL: https://github.com/apache/incubator-tvm/pull/5660#issuecomment-632930007 @tqchen @tmoreau89 @liangfu @weberlo @u99127 @tom-gall This is an automated message from the Apache Git

[GitHub] [incubator-tvm] tqchen commented on pull request #5659: enable amd_apu device on vulkan target

2020-05-22 Thread GitBox
tqchen commented on pull request #5659: URL: https://github.com/apache/incubator-tvm/pull/5659#issuecomment-632929975 Thanks @mei-ye , assigning @tmoreau89 BTW, you do not have to reopen another PR for the updates, you can just force push to your original branch and the PR will be

[GitHub] [incubator-tvm] areusch opened a new pull request #5660: Increase bss section size.

2020-05-22 Thread GitBox
areusch opened a new pull request #5660: URL: https://github.com/apache/incubator-tvm/pull/5660 * Likely broken in PR 5590. This fix unbreaks `tests/micro/test_runtime_micro_on_arm.py` for me. Let's bump the global default, since this is a minimal test case.

[GitHub] [incubator-tvm] mei-ye opened a new pull request #5659: enable amd_apu device on vulkan target

2020-05-22 Thread GitBox
mei-ye opened a new pull request #5659: URL: https://github.com/apache/incubator-tvm/pull/5659 Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code

[GitHub] [incubator-tvm] mbrookhart commented on a change in pull request #5653: [PatternLang] Convert PatternGrouper to do pre-order, non-recursive analysis

2020-05-22 Thread GitBox
mbrookhart commented on a change in pull request #5653: URL: https://github.com/apache/incubator-tvm/pull/5653#discussion_r429468918 ## File path: src/relay/ir/dataflow_matcher.cc ## @@ -432,26 +432,39 @@ class PatternGrouper : protected MixedModeVisitor { const

[GitHub] [incubator-tvm] mbrookhart commented on a change in pull request #5653: [PatternLang] Convert PatternGrouper to do pre-order, non-recursive analysis

2020-05-22 Thread GitBox
mbrookhart commented on a change in pull request #5653: URL: https://github.com/apache/incubator-tvm/pull/5653#discussion_r429471161 ## File path: src/relay/ir/dataflow_matcher.cc ## @@ -432,26 +432,39 @@ class PatternGrouper : protected MixedModeVisitor { const

[GitHub] [incubator-tvm] mbrookhart commented on a change in pull request #5653: [PatternLang] Convert PatternGrouper to do pre-order, non-recursive analysis

2020-05-22 Thread GitBox
mbrookhart commented on a change in pull request #5653: URL: https://github.com/apache/incubator-tvm/pull/5653#discussion_r429468918 ## File path: src/relay/ir/dataflow_matcher.cc ## @@ -432,26 +432,39 @@ class PatternGrouper : protected MixedModeVisitor { const

[GitHub] [incubator-tvm] hcho3 opened a new pull request #5658: Upgrade XGBoost to latest

2020-05-22 Thread GitBox
hcho3 opened a new pull request #5658: URL: https://github.com/apache/incubator-tvm/pull/5658 Now that #4953 is fixed in latest XGBoost release (1.1.0), upgrade XGBoost. This is an automated message from the Apache Git

[GitHub] [incubator-tvm] tom-gall edited a comment on pull request #5655: Add MicroTVM tutorial using the STM32F746 discovery board

2020-05-22 Thread GitBox
tom-gall edited a comment on pull request #5655: URL: https://github.com/apache/incubator-tvm/pull/5655#issuecomment-632915897 @areusch @u99127 This is an automated message from the Apache Git Service. To respond to the

[incubator-tvm] branch master updated (3e074c5 -> 9fa8341)

2020-05-22 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 3e074c5 µtvm debug improvements (#5648) add 9fa8341 [REFACTOR][IR] Migrate IRModule ObjectRef to

[GitHub] [incubator-tvm] tqchen commented on pull request #5654: [REFACTOR][IR] Migrate IRModule ObjectRef to not-null

2020-05-22 Thread GitBox
tqchen commented on pull request #5654: URL: https://github.com/apache/incubator-tvm/pull/5654#issuecomment-632916889 Thanks @ANSHUMAN87 @jroesch ! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-tvm] tqchen merged pull request #5654: [REFACTOR][IR] Migrate IRModule ObjectRef to not-null

2020-05-22 Thread GitBox
tqchen merged pull request #5654: URL: https://github.com/apache/incubator-tvm/pull/5654 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-tvm] tom-gall commented on pull request #5655: Add MicroTVM tutorial using the STM32F746 discovery board

2020-05-22 Thread GitBox
tom-gall commented on pull request #5655: URL: https://github.com/apache/incubator-tvm/pull/5655#issuecomment-632915897 @areusch This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-tvm] comaniac closed issue #5647: [PatternLang] pattern.partition doesn't include the last optional op.

2020-05-22 Thread GitBox
comaniac closed issue #5647: URL: https://github.com/apache/incubator-tvm/issues/5647 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [incubator-tvm] comaniac commented on issue #5647: [PatternLang] pattern.partition doesn't include the last optional op.

2020-05-22 Thread GitBox
comaniac commented on issue #5647: URL: https://github.com/apache/incubator-tvm/issues/5647#issuecomment-632907849 Thanks @mbrookhart for the quick fix :) This is an automated message from the Apache Git Service. To respond

[incubator-tvm] branch master updated (896557d -> 3e074c5)

2020-05-22 Thread moreau
This is an automated email from the ASF dual-hosted git repository. moreau pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 896557d [RUNTIME] Resolve constexpr issue in debug mode. (#5651) add 3e074c5 µtvm debug improvements

[GitHub] [incubator-tvm] tmoreau89 merged pull request #5648: µtvm debug improvements

2020-05-22 Thread GitBox
tmoreau89 merged pull request #5648: URL: https://github.com/apache/incubator-tvm/pull/5648 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-tvm] masahi commented on a change in pull request #5653: [PatternLang] Convert PatternGrouper to do pre-order, non-recursive analysis

2020-05-22 Thread GitBox
masahi commented on a change in pull request #5653: URL: https://github.com/apache/incubator-tvm/pull/5653#discussion_r429449194 ## File path: src/relay/ir/dataflow_matcher.cc ## @@ -432,26 +432,39 @@ class PatternGrouper : protected MixedModeVisitor { const std::vector&

[GitHub] [incubator-tvm] vinx13 opened a new pull request #5657: [Relay,Topi][OP] affine_grid and grid_sample

2020-05-22 Thread GitBox
vinx13 opened a new pull request #5657: URL: https://github.com/apache/incubator-tvm/pull/5657 This PR added the `affine_grid` and `grid_sample` operator introduced in [Spatial Transformer Networks](https://arxiv.org/abs/1506.02025). API reference: MXNet:

[GitHub] [incubator-tvm] masahi commented on a change in pull request #5653: [PatternLang] Convert PatternGrouper to do pre-order, non-recursive analysis

2020-05-22 Thread GitBox
masahi commented on a change in pull request #5653: URL: https://github.com/apache/incubator-tvm/pull/5653#discussion_r429449194 ## File path: src/relay/ir/dataflow_matcher.cc ## @@ -432,26 +432,39 @@ class PatternGrouper : protected MixedModeVisitor { const std::vector&

[GitHub] [incubator-tvm] areusch commented on a change in pull request #5648: µtvm debug improvements

2020-05-22 Thread GitBox
areusch commented on a change in pull request #5648: URL: https://github.com/apache/incubator-tvm/pull/5648#discussion_r429446488 ## File path: src/runtime/micro/host_driven/utvm_runtime.c ## @@ -101,7 +101,7 @@ void UTVMMain() { // We use a dummy function to signal

[GitHub] [incubator-tvm] comaniac opened a new pull request #5656: [BYOC] Pattern Language MergeComposite

2020-05-22 Thread GitBox
comaniac opened a new pull request #5656: URL: https://github.com/apache/incubator-tvm/pull/5656 This PR uses the new Relay pattern language to simplify the `MergeComposite` pass implementation. Here are some highlights and discussions: - **After this PR, the patterns for composite

[GitHub] [incubator-tvm] jroesch merged pull request #5651: [RUNTIME] Resolve constexpr issue in debug mode.

2020-05-22 Thread GitBox
jroesch merged pull request #5651: URL: https://github.com/apache/incubator-tvm/pull/5651 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[incubator-tvm] branch master updated: [RUNTIME] Resolve constexpr issue in debug mode. (#5651)

2020-05-22 Thread jroesch
This is an automated email from the ASF dual-hosted git repository. jroesch pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git The following commit(s) were added to refs/heads/master by this push: new 896557d [RUNTIME] Resolve constexpr

[GitHub] [incubator-tvm] tom-gall opened a new pull request #5655: Add MicroTVM tutorial using the STM32F746 discovery board

2020-05-22 Thread GitBox
tom-gall opened a new pull request #5655: URL: https://github.com/apache/incubator-tvm/pull/5655 Add MicroTVM tutorial using the STM32F746 discovery board with a sample tflite model Signed-off-by: Tom Gall Thanks for contributing to TVM! Please refer to guideline

[GitHub] [incubator-tvm] mei-ye closed pull request #5645: [TARGET] add amd_gpu target

2020-05-22 Thread GitBox
mei-ye closed pull request #5645: URL: https://github.com/apache/incubator-tvm/pull/5645 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[incubator-tvm] branch master updated (dbb8be7 -> b26f988)

2020-05-22 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from dbb8be7 HG: Commit message of changeset 6281661. (#5622) add b26f988 [AutoTVM] Update XGBoost

[GitHub] [incubator-tvm] tqchen merged pull request #5649: [AutoTVM] Update XGBoost verbosity option

2020-05-22 Thread GitBox
tqchen merged pull request #5649: URL: https://github.com/apache/incubator-tvm/pull/5649 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-tvm] ANSHUMAN87 commented on pull request #5654: [REFACTOR][IR] Migrate IRModule ObjectRef to not-null

2020-05-22 Thread GitBox
ANSHUMAN87 commented on pull request #5654: URL: https://github.com/apache/incubator-tvm/pull/5654#issuecomment-632830825 There are 2 approaches followed here to solve Optional issue in exposed APIs. A0: Using Optional way as mentioned in the reference link. (Ref

[GitHub] [incubator-tvm] ANSHUMAN87 commented on pull request #5625: [Arith] ExtendedEuclidean merge impl to int_operator

2020-05-22 Thread GitBox
ANSHUMAN87 commented on pull request #5625: URL: https://github.com/apache/incubator-tvm/pull/5625#issuecomment-632827740 @yzhliu : Gentle ping! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-tvm] ANSHUMAN87 opened a new pull request #5654: [REFACTOR][IR] Migrate IRModule ObjectRef to not-null

2020-05-22 Thread GitBox
ANSHUMAN87 opened a new pull request #5654: URL: https://github.com/apache/incubator-tvm/pull/5654 Refer #5318 @tqchen : Please help review, Thanks! This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-tvm] tom-gall commented on pull request #5648: µtvm debug improvements

2020-05-22 Thread GitBox
tom-gall commented on pull request #5648: URL: https://github.com/apache/incubator-tvm/pull/5648#issuecomment-632824516 LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-tvm] u99127 commented on a change in pull request #5648: µtvm debug improvements

2020-05-22 Thread GitBox
u99127 commented on a change in pull request #5648: URL: https://github.com/apache/incubator-tvm/pull/5648#discussion_r429357376 ## File path: src/runtime/micro/host_driven/utvm_runtime.c ## @@ -101,7 +101,7 @@ void UTVMMain() { // We use a dummy function to signal

[GitHub] [incubator-tvm] srkreddy1238 commented on a change in pull request #5617: [TENSORFLOW]StatefulPartitionedCall/PartitionedCall Ops support added

2020-05-22 Thread GitBox
srkreddy1238 commented on a change in pull request #5617: URL: https://github.com/apache/incubator-tvm/pull/5617#discussion_r429331590 ## File path: python/tvm/relay/frontend/tensorflow.py ## @@ -2896,15 +2903,29 @@ def _parse_import_prerequisites(self, graph): """

[GitHub] [incubator-tvm] mbrookhart opened a new pull request #5653: Convert PatternGrouper to do pre-order, non-recursive analysis

2020-05-22 Thread GitBox
mbrookhart opened a new pull request #5653: URL: https://github.com/apache/incubator-tvm/pull/5653 Fixes https://github.com/apache/incubator-tvm/issues/5647 @comaniac @masahi Thanks! This is an automated message from

[GitHub] [incubator-tvm] zhiics commented on pull request #5622: [Relay] Move compiler_begin/end_op to local static objects

2020-05-22 Thread GitBox
zhiics commented on pull request #5622: URL: https://github.com/apache/incubator-tvm/pull/5622#issuecomment-632791073 Thanks @hlu1 @tqchen This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-tvm] tqchen commented on pull request #5652: [TIR][BUILD] Remove buffer params from pass config.

2020-05-22 Thread GitBox
tqchen commented on pull request #5652: URL: https://github.com/apache/incubator-tvm/pull/5652#issuecomment-632791420 cc @ZihengJiang @zhiics This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-tvm] tqchen opened a new pull request #5652: [TIR][BUILD] Remove buffer params from pass config.

2020-05-22 Thread GitBox
tqchen opened a new pull request #5652: URL: https://github.com/apache/incubator-tvm/pull/5652 Buffer configurations can be passed during construction and does not need to be part of the build config. This is a refactor step to simplify the buildconfig for the PassContext

[GitHub] [incubator-tvm] zhiics merged pull request #5622: [Relay] Move compiler_begin/end_op to local static objects

2020-05-22 Thread GitBox
zhiics merged pull request #5622: URL: https://github.com/apache/incubator-tvm/pull/5622 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[incubator-tvm] branch master updated: HG: Commit message of changeset 6281661. (#5622)

2020-05-22 Thread zhic
This is an automated email from the ASF dual-hosted git repository. zhic pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git The following commit(s) were added to refs/heads/master by this push: new dbb8be7 HG: Commit message of changeset

[GitHub] [incubator-tvm] junrushao1994 commented on pull request #5651: [RUNTIME] Resolve constexpr issue in debug mode.

2020-05-22 Thread GitBox
junrushao1994 commented on pull request #5651: URL: https://github.com/apache/incubator-tvm/pull/5651#issuecomment-632786346 Interesting. I think I met this before but didn’t know the root cause. Thank you for the explanation!!

[GitHub] [incubator-tvm] tqchen commented on pull request #5651: [RUNTIME] Resolve constexpr issue in debug mode.

2020-05-22 Thread GitBox
tqchen commented on pull request #5651: URL: https://github.com/apache/incubator-tvm/pull/5651#issuecomment-632776222 cc @junrushao1994 @ZihengJiang @jroesch This is an automated message from the Apache Git Service. To

[GitHub] [incubator-tvm] tqchen opened a new pull request #5651: [RUNTIME] Resolve constexpr issue in debug mode.

2020-05-22 Thread GitBox
tqchen opened a new pull request #5651: URL: https://github.com/apache/incubator-tvm/pull/5651 static constexpr is a bit weird before c++17. They are not inlined by default and does not have symbols after compilation. It usually isn't a problem when they are inlined(in c++17 they are

[GitHub] [incubator-tvm] areusch commented on pull request #5648: µtvm debug improvements

2020-05-22 Thread GitBox
areusch commented on pull request #5648: URL: https://github.com/apache/incubator-tvm/pull/5648#issuecomment-632754557 @tqchen @tmoreau89 @liangfu @weberlo @u99127 @tom-gall This is an automated message from the Apache Git

[GitHub] [incubator-tvm] zhiics commented on issue #5650: [REFACTOR] PassContext.fallback_device -> PassConfig.config

2020-05-22 Thread GitBox
zhiics commented on issue #5650: URL: https://github.com/apache/incubator-tvm/issues/5650#issuecomment-632751624 @tqchen Thanks for reminding. I will take a stab next week. This is an automated message from the Apache Git

[GitHub] [incubator-tvm] tqchen commented on issue #5373: [REFACTOR][TIR] Migrate HoistIfThenElse to the unified pass manager

2020-05-22 Thread GitBox
tqchen commented on issue #5373: URL: https://github.com/apache/incubator-tvm/issues/5373#issuecomment-632750012 ping @kevinthesun This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-tvm] tqchen edited a comment on issue #5650: [REFACTOR] PassContext.fallback_device -> PassConfig.config

2020-05-22 Thread GitBox
tqchen edited a comment on issue #5650: URL: https://github.com/apache/incubator-tvm/issues/5650#issuecomment-632740723 cc @zhiics @comaniac This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-tvm] tqchen commented on issue #5650: [REFACTOR] PassContext.fallback_device -> PassConfig.config

2020-05-22 Thread GitBox
tqchen commented on issue #5650: URL: https://github.com/apache/incubator-tvm/issues/5650#issuecomment-632740723 cc @zhiics This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-tvm] tqchen opened a new issue #5650: [REFACTOR] PassContext.fallback_device -> PassConfig.config

2020-05-22 Thread GitBox
tqchen opened a new issue #5650: URL: https://github.com/apache/incubator-tvm/issues/5650 https://github.com/apache/incubator-tvm/pull/5631 Introduces a generic config mechanism to store the pass configuration options. Given that fallback_device is a pas related config, We should probably

[GitHub] [incubator-tvm] srkreddy1238 commented on a change in pull request #5052: [TARGET] ONNX codegen

2020-05-22 Thread GitBox
srkreddy1238 commented on a change in pull request #5052: URL: https://github.com/apache/incubator-tvm/pull/5052#discussion_r429299616 ## File path: tests/python/contrib/test_onnx.py ## @@ -0,0 +1,393 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [incubator-tvm] tqchen opened a new pull request #5649: [AutoTVM] Update XGBoost verbosity option

2020-05-22 Thread GitBox
tqchen opened a new pull request #5649: URL: https://github.com/apache/incubator-tvm/pull/5649 cc @liangfu @hcho3 @merrymercy This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-tvm] tqchen commented on pull request #5645: [TARGET] add amd_gpu target

2020-05-22 Thread GitBox
tqchen commented on pull request #5645: URL: https://github.com/apache/incubator-tvm/pull/5645#issuecomment-632731324 See the example case above(the link to mali log) which uses the opencl, but have a separate log by itself

[GitHub] [incubator-tvm] maheshambule commented on a change in pull request #5052: [TARGET] ONNX codegen

2020-05-22 Thread GitBox
maheshambule commented on a change in pull request #5052: URL: https://github.com/apache/incubator-tvm/pull/5052#discussion_r429260948 ## File path: python/tvm/contrib/codegen_onnx.py ## @@ -0,0 +1,752 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [incubator-tvm] maheshambule commented on a change in pull request #5052: [TARGET] ONNX codegen

2020-05-22 Thread GitBox
maheshambule commented on a change in pull request #5052: URL: https://github.com/apache/incubator-tvm/pull/5052#discussion_r429260135 ## File path: tests/python/contrib/test_onnx.py ## @@ -0,0 +1,406 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [incubator-tvm] maheshambule commented on a change in pull request #5052: [TARGET] ONNX codegen

2020-05-22 Thread GitBox
maheshambule commented on a change in pull request #5052: URL: https://github.com/apache/incubator-tvm/pull/5052#discussion_r429260012 ## File path: src/runtime/contrib/onnx/onnx_module.cc ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [incubator-tvm] maheshambule commented on a change in pull request #5052: [TARGET] ONNX codegen

2020-05-22 Thread GitBox
maheshambule commented on a change in pull request #5052: URL: https://github.com/apache/incubator-tvm/pull/5052#discussion_r429256951 ## File path: python/tvm/contrib/target/onnx.py ## @@ -0,0 +1,752 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [incubator-tvm] maheshambule commented on a change in pull request #5052: [TARGET] ONNX codegen

2020-05-22 Thread GitBox
maheshambule commented on a change in pull request #5052: URL: https://github.com/apache/incubator-tvm/pull/5052#discussion_r429256748 ## File path: python/tvm/contrib/target/onnx.py ## @@ -0,0 +1,752 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [incubator-tvm] kazum commented on a change in pull request #5052: [TARGET] ONNX codegen

2020-05-22 Thread GitBox
kazum commented on a change in pull request #5052: URL: https://github.com/apache/incubator-tvm/pull/5052#discussion_r429168772 ## File path: src/runtime/contrib/onnx/onnx_module.cc ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

[GitHub] [incubator-tvm] masahi commented on pull request #5628: [Relay, Topi][OP] Correlation

2020-05-22 Thread GitBox
masahi commented on pull request #5628: URL: https://github.com/apache/incubator-tvm/pull/5628#issuecomment-632501657 thanks @vinx13 @tqchen This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-tvm] masahi merged pull request #5628: [Relay, Topi][OP] Correlation

2020-05-22 Thread GitBox
masahi merged pull request #5628: URL: https://github.com/apache/incubator-tvm/pull/5628 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[incubator-tvm] branch master updated: [Relay, Topi][OP] Correlation (#5628)

2020-05-22 Thread masahi
This is an automated email from the ASF dual-hosted git repository. masahi pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git The following commit(s) were added to refs/heads/master by this push: new e55f9ff [Relay, Topi][OP] Correlation