[GitHub] [tvm] manupa-arm commented on pull request #8806: [3/6] Arm(R) Ethos(TM)-U NPU TIR compiler with conv2d support

2021-09-15 Thread GitBox
manupa-arm commented on pull request #8806: URL: https://github.com/apache/tvm/pull/8806#issuecomment-919814669 Hi All, In order to unblock reviews for the rest of the PRs (4/6 --> 6/6), we are committing to address the comments in P3a as mentioned here : https://github.com/apache/t

[GitHub] [tvm] Mousius commented on a change in pull request #8423: Implementation of relay_to_tir target hook

2021-09-15 Thread GitBox
Mousius commented on a change in pull request #8423: URL: https://github.com/apache/tvm/pull/8423#discussion_r708977951 ## File path: src/relay/backend/te_compiler.cc ## @@ -383,10 +384,9 @@ class LowerTensorExprMutator : public ExprMutator { * \brief Returns the primitive

[GitHub] [tvm] mikepapadim commented on pull request #8757: [CI] Modify Jenkinfile to always display junit report, fix for #8674

2021-09-15 Thread GitBox
mikepapadim commented on pull request #8757: URL: https://github.com/apache/tvm/pull/8757#issuecomment-919864662 > @mikepapadim any update here? Need to give it a go through CI. I ll update accordingly. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [tvm] mikepapadim commented on pull request #8757: [CI] Modify Jenkinfile to always display junit report, fix for #8674

2021-09-15 Thread GitBox
mikepapadim commented on pull request #8757: URL: https://github.com/apache/tvm/pull/8757#issuecomment-919911520 Let's wait for the CI, but now with the post-action per stage, test results should always be registerd. -- This is an automated message from the Apache Git Service. To respon

[GitHub] [tvm] leandron merged pull request #8806: [3/6] Arm(R) Ethos(TM)-U NPU TIR compiler with conv2d support

2021-09-15 Thread GitBox
leandron merged pull request #8806: URL: https://github.com/apache/tvm/pull/8806 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr.

[GitHub] [tvm] leandron commented on pull request #8806: [3/6] Arm(R) Ethos(TM)-U NPU TIR compiler with conv2d support

2021-09-15 Thread GitBox
leandron commented on pull request #8806: URL: https://github.com/apache/tvm/pull/8806#issuecomment-919925689 Thanks @manupa-arm @mbaret @areusch @jroesch @mbs-octoml, this is merged now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[tvm] branch main updated (34570f2 -> 354019d)

2021-09-15 Thread leandron
This is an automated email from the ASF dual-hosted git repository. leandron pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from 34570f2 [Onnx] Add Adam (#9002) add 354019d [3/6] Arm(R) Ethos(TM)-U NPU TIR compiler with conv2d support (#8806

[GitHub] [tvm] mikepapadim commented on a change in pull request #8775: Remove compile_engine.h for real this time.

2021-09-15 Thread GitBox
mikepapadim commented on a change in pull request #8775: URL: https://github.com/apache/tvm/pull/8775#discussion_r691167727 ## File path: src/relay/backend/compile_engine.cc ## @@ -1,338 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one - * or more cont

[tvm] branch main updated (354019d -> f350ea6)

2021-09-15 Thread masahi
This is an automated email from the ASF dual-hosted git repository. masahi pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from 354019d [3/6] Arm(R) Ethos(TM)-U NPU TIR compiler with conv2d support (#8806) add f350ea6 [Torch] Add an option to

[GitHub] [tvm] masahi merged pull request #9015: [Torch] Add an option to make imported models compatible with the Relay text parser

2021-09-15 Thread GitBox
masahi merged pull request #9015: URL: https://github.com/apache/tvm/pull/9015 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

[GitHub] [tvm] masahi closed issue #8994: [Bug] relay.transform.AnnotateSpans does not work on modules imported from Pytorch

2021-09-15 Thread GitBox
masahi closed issue #8994: URL: https://github.com/apache/tvm/issues/8994 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@tvm.

[GitHub] [tvm] masahi merged pull request #9014: [Strategy] Disable cuda int8 schedule for non-cuda gpu target

2021-09-15 Thread GitBox
masahi merged pull request #9014: URL: https://github.com/apache/tvm/pull/9014 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

[GitHub] [tvm] masahi merged pull request #9011: [Hexagon] `llvm-options` attribute is an array of strings

2021-09-15 Thread GitBox
masahi merged pull request #9011: URL: https://github.com/apache/tvm/pull/9011 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

[tvm] branch main updated (f350ea6 -> 39abead)

2021-09-15 Thread masahi
This is an automated email from the ASF dual-hosted git repository. masahi pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from f350ea6 [Torch] Add an option to make imported models compatible with the Relay text parser (#9015) add 39abead di

[tvm] branch main updated (39abead -> dd7d830)

2021-09-15 Thread masahi
This is an automated email from the ASF dual-hosted git repository. masahi pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from 39abead disable cuda int8 schedule for non-cuda gpu target (#9014) add dd7d830 [Hexagon] `llvm-options` attribute i

[GitHub] [tvm] masahi commented on a change in pull request #8985: [ONNX] Add Einsum converter

2021-09-15 Thread GitBox
masahi commented on a change in pull request #8985: URL: https://github.com/apache/tvm/pull/8985#discussion_r709112076 ## File path: python/tvm/relay/op/strategy/cuda.py ## @@ -1210,3 +1210,16 @@ def invert_permutation_strategy_cuda(attrs, inputs, out_type, target): n

[GitHub] [tvm] masahi merged pull request #8702: [Runtime] Pipeline Executor Initial patch.

2021-09-15 Thread GitBox
masahi merged pull request #8702: URL: https://github.com/apache/tvm/pull/8702 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

[tvm] branch main updated (dd7d830 -> 9bc4dc0)

2021-09-15 Thread masahi
This is an automated email from the ASF dual-hosted git repository. masahi pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from dd7d830 [Hexagon] `llvm-options` attribute is an array of strings (#9011) add 9bc4dc0 [Runtime] Pipeline Executor

[GitHub] [tvm] masahi commented on pull request #8702: [Runtime] Pipeline Executor Initial patch.

2021-09-15 Thread GitBox
masahi commented on pull request #8702: URL: https://github.com/apache/tvm/pull/8702#issuecomment-919956408 thanks @huajsj @comaniac -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [tvm] masahi commented on a change in pull request #8985: [ONNX] Add Einsum converter

2021-09-15 Thread GitBox
masahi commented on a change in pull request #8985: URL: https://github.com/apache/tvm/pull/8985#discussion_r709112076 ## File path: python/tvm/relay/op/strategy/cuda.py ## @@ -1210,3 +1210,16 @@ def invert_permutation_strategy_cuda(attrs, inputs, out_type, target): n

[GitHub] [tvm] t-vi commented on pull request #7401: WIP/RFC: initial stab at TorchScript fallback

2021-09-15 Thread GitBox
t-vi commented on pull request #7401: URL: https://github.com/apache/tvm/pull/7401#issuecomment-919961143 So I have been mulling over the best granularity / approach. Currently I'm taking TorchScript functions / graphs as the unit I'm working with. An alternative could be to move to the Py

[GitHub] [tvm] wrongtest opened a new pull request #9016: Support match pvar with dtype constraint

2021-09-15 Thread GitBox
wrongtest opened a new pull request #9016: URL: https://github.com/apache/tvm/pull/9016 This PR add two helper class for tir expression pattern match. - `PVarWithType` works same as `PVar` with dtype match - `PVecType` represent a wildcard vec type placeholder same as `PVar`, but

[GitHub] [tvm] masahi commented on pull request #7401: WIP/RFC: initial stab at TorchScript fallback

2021-09-15 Thread GitBox
masahi commented on pull request #7401: URL: https://github.com/apache/tvm/pull/7401#issuecomment-919993664 I was going to suggest using `MergeCompilerRegions`, but I saw you already using it. So I like your current approach. Sending many small functions to torch sounds like a non-trivial

[GitHub] [tvm] mikepapadim removed a comment on pull request #8775: Remove compile_engine.h for real this time.

2021-09-15 Thread GitBox
mikepapadim removed a comment on pull request #8775: URL: https://github.com/apache/tvm/pull/8775#issuecomment-918100600 What needs to be done for this one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [tvm] leandron commented on a change in pull request #8992: Prevent non-docs stages when a PR only modifies docs/

2021-09-15 Thread GitBox
leandron commented on a change in pull request #8992: URL: https://github.com/apache/tvm/pull/8992#discussion_r709184555 ## File path: docker/install/ubuntu_install_vitis_ai_packages_ci.sh ## @@ -6,9 +6,9 @@ # to you under the Apache License, Version 2.0 (the # "License"); yo

[GitHub] [tvm-rfcs] xiebaiyuan commented on pull request #32: [RFC][WEB][AUTO TVM]add web assembly autotvm support

2021-09-15 Thread GitBox
xiebaiyuan commented on pull request #32: URL: https://github.com/apache/tvm-rfcs/pull/32#issuecomment-920027826 @tqchen We've thought it over in recent days, and will use websocket to transfer intermediate products. The rfc will be updated in a few days. -- This is an automated mess

[GitHub] [tvm] Mousius commented on a change in pull request #8423: Implementation of relay_to_tir target hook

2021-09-15 Thread GitBox
Mousius commented on a change in pull request #8423: URL: https://github.com/apache/tvm/pull/8423#discussion_r709203128 ## File path: src/relay/backend/contrib/example_target_hooks/relay_to_tir.cc ## @@ -0,0 +1,131 @@ + +/* + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [tvm-rfcs] gromero commented on pull request #33: [RFC][Project API] Extend metadata in ProjectOption

2021-09-15 Thread GitBox
gromero commented on pull request #33: URL: https://github.com/apache/tvm-rfcs/pull/33#issuecomment-920051153 Thanks a lot for the review @leandron -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [tvm] areusch commented on a change in pull request #9005: Add standalone_crt/ to be part of the wheel package, when available.

2021-09-15 Thread GitBox
areusch commented on a change in pull request #9005: URL: https://github.com/apache/tvm/pull/9005#discussion_r709246155 ## File path: python/setup.py ## @@ -206,4 +222,10 @@ def get_package_data_files(): os.remove("MANIFEST.in") for path in LIB_LIST: _, libna

[GitHub] [tvm] quic-sanirudh opened a new pull request #9017: [ONNX] QLinearAveragePool and QLinearGlobalAveragePool contrib op

2021-09-15 Thread GitBox
quic-sanirudh opened a new pull request #9017: URL: https://github.com/apache/tvm/pull/9017 This PR implements com.microsoft.QLinearAveragePool and com.microsoft.QLinearGlobalAveragePool. QLinearAveragePool is implemented as (dequantize -> float op -> quantize) according to its defi

[GitHub] [tvm] leandron commented on a change in pull request #9005: Add standalone_crt/ to be part of the wheel package, when available.

2021-09-15 Thread GitBox
leandron commented on a change in pull request #9005: URL: https://github.com/apache/tvm/pull/9005#discussion_r709248414 ## File path: python/setup.py ## @@ -206,4 +222,10 @@ def get_package_data_files(): os.remove("MANIFEST.in") for path in LIB_LIST: _, libn

[GitHub] [tvm-rfcs] Mousius commented on a change in pull request #33: [RFC][Project API] Extend metadata in ProjectOption

2021-09-15 Thread GitBox
Mousius commented on a change in pull request #33: URL: https://github.com/apache/tvm-rfcs/pull/33#discussion_r709242480 ## File path: rfcs/0020-project_api_extend_metadata.md ## @@ -0,0 +1,252 @@ +- Feature Name: project_api_extend_metadata +- Start Date: 2021-09-09 +- RFC PR:

[GitHub] [tvm] mehrdadh opened a new pull request #9018: [microTVM][autoTVM] Follow up fixes to #9003

2021-09-15 Thread GitBox
mehrdadh opened a new pull request #9018: URL: https://github.com/apache/tvm/pull/9018 This PR: - fixes timeout value for zephyr test for physical hardware - follow up cleanup to address comments on #9003 - fix a doc issue on microtvm autotune tutorial -- This is an automated mes

[GitHub] [tvm] mbs-octoml commented on a change in pull request #8423: Implementation of relay_to_tir target hook

2021-09-15 Thread GitBox
mbs-octoml commented on a change in pull request #8423: URL: https://github.com/apache/tvm/pull/8423#discussion_r709299078 ## File path: src/relay/backend/contrib/example_target_hooks/relay_to_tir.cc ## @@ -0,0 +1,131 @@ + +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [tvm] tmoreau89 merged pull request #9010: [Hexagon] Treat floats as float32 when passing args to offloaded kernels

2021-09-15 Thread GitBox
tmoreau89 merged pull request #9010: URL: https://github.com/apache/tvm/pull/9010 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[GitHub] [tvm] tmoreau89 commented on pull request #9010: [Hexagon] Treat floats as float32 when passing args to offloaded kernels

2021-09-15 Thread GitBox
tmoreau89 commented on pull request #9010: URL: https://github.com/apache/tvm/pull/9010#issuecomment-920128985 Thank you @kparzysz-quic - the PR has been merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[tvm] branch main updated (9bc4dc0 -> 57386a2)

2021-09-15 Thread moreau
This is an automated email from the ASF dual-hosted git repository. moreau pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from 9bc4dc0 [Runtime] Pipeline Executor Initial patch. (#8702) add 57386a2 [Hexagon] Treat floats as float32 when passi

[GitHub] [tvm] mbs-octoml commented on issue #9013: [Bug] tutorials do not build from a clean source tree

2021-09-15 Thread GitBox
mbs-octoml commented on issue #9013: URL: https://github.com/apache/tvm/issues/9013#issuecomment-920129733 @electriclilies Lily, in your spelunking through build did you see any obvious global compile engine caching? -- This is an automated message from the Apache Git Service. To respond

[GitHub] [tvm] mikepapadim commented on pull request #8974: [Relay] Remove memory planing from LowerTEPass

2021-09-15 Thread GitBox
mikepapadim commented on pull request #8974: URL: https://github.com/apache/tvm/pull/8974#issuecomment-920153719 Thanks for the feedback. I think now is good to go. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [tvm] tmoreau89 commented on pull request #9017: [ONNX] QLinearAveragePool and QLinearGlobalAveragePool contrib op

2021-09-15 Thread GitBox
tmoreau89 commented on pull request #9017: URL: https://github.com/apache/tvm/pull/9017#issuecomment-920161820 CC @anwang2009 @mbrookhart @AndrewZhaoLuo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [tvm] kparzysz-quic commented on a change in pull request #8986: [Hexagon] Implement model launcher

2021-09-15 Thread GitBox
kparzysz-quic commented on a change in pull request #8986: URL: https://github.com/apache/tvm/pull/8986#discussion_r709342341 ## File path: src/runtime/hexagon/launcher/README.md ## @@ -0,0 +1,142 @@ + + + + + + + + + + + + + + + + +# Hexagon Graph Launcher + +## Compilation +

[GitHub] [tvm] tmoreau89 commented on issue #8838: [Tracking Issue][ONNX] Quantized operator support in ONNX importer

2021-09-15 Thread GitBox
tmoreau89 commented on issue #8838: URL: https://github.com/apache/tvm/issues/8838#issuecomment-920163025 Linking: https://github.com/apache/tvm/pull/9017 - thanks @quic-sanirudh ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [tvm] kparzysz-quic commented on a change in pull request #8986: [Hexagon] Implement model launcher

2021-09-15 Thread GitBox
kparzysz-quic commented on a change in pull request #8986: URL: https://github.com/apache/tvm/pull/8986#discussion_r709343747 ## File path: src/runtime/hexagon/launcher/README.md ## @@ -0,0 +1,142 @@ + + + + + + + + + + + + + + + + +# Hexagon Graph Launcher Review comment:

[GitHub] [tvm] kparzysz-quic commented on a change in pull request #8986: [Hexagon] Implement model launcher

2021-09-15 Thread GitBox
kparzysz-quic commented on a change in pull request #8986: URL: https://github.com/apache/tvm/pull/8986#discussion_r70936 ## File path: src/runtime/hexagon/launcher/README.md ## @@ -0,0 +1,142 @@ + + + + + + + + + + + + + + + + +# Hexagon Graph Launcher + +## Compilation +

[GitHub] [tvm] kparzysz-quic commented on a change in pull request #8986: [Hexagon] Implement model launcher

2021-09-15 Thread GitBox
kparzysz-quic commented on a change in pull request #8986: URL: https://github.com/apache/tvm/pull/8986#discussion_r709350537 ## File path: src/runtime/hexagon/launcher/README.md ## @@ -0,0 +1,142 @@ + + + + + + + + + + + + + + + + +# Hexagon Graph Launcher + +## Compilation +

[GitHub] [tvm] gilles-reservoir commented on issue #8994: [Bug] relay.transform.AnnotateSpans does not work on modules imported from Pytorch

2021-09-15 Thread GitBox
gilles-reservoir commented on issue #8994: URL: https://github.com/apache/tvm/issues/8994#issuecomment-920177473 Thanks so much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [tvm] Mousius commented on a change in pull request #8974: [Relay] Remove memory planing from LowerTEPass

2021-09-15 Thread GitBox
Mousius commented on a change in pull request #8974: URL: https://github.com/apache/tvm/pull/8974#discussion_r709368833 ## File path: src/relay/backend/aot_executor_codegen.cc ## @@ -583,8 +583,16 @@ class AOTExecutorCodegen : public MixedModeVisitor { // performing the pr

[GitHub] [tvm] mbrookhart commented on pull request #8274: [TIR][VM] Revert a change to lower_tvm_builtin.cc from #6126

2021-09-15 Thread GitBox
mbrookhart commented on pull request #8274: URL: https://github.com/apache/tvm/pull/8274#issuecomment-920192241 Hi @manupa-arm I think we have some conflict between what the VM needs to run on CPU and what microprocessors need. Can we talk about this on the issues @zhanghaohit created #897

[GitHub] [tvm] anwang2009 commented on a change in pull request #8985: [ONNX] Add Einsum converter

2021-09-15 Thread GitBox
anwang2009 commented on a change in pull request #8985: URL: https://github.com/apache/tvm/pull/8985#discussion_r709375343 ## File path: python/tvm/relay/op/strategy/cuda.py ## @@ -1210,3 +1210,16 @@ def invert_permutation_strategy_cuda(attrs, inputs, out_type, target):

[GitHub] [tvm] comaniac commented on issue #8596: [RFC][Tracking Issue] Pipeline Executor For Compute graph pipeline

2021-09-15 Thread GitBox
comaniac commented on issue #8596: URL: https://github.com/apache/tvm/issues/8596#issuecomment-920216448 @huajsj please update this issue with a PR checklist. Please link all future PRs to this issue for better progress tracking. You can refer to other RFC issues like #8473 -- This is

[GitHub] [tvm] manupa-arm commented on issue #8978: [Bug][VTA][OpenCL] If allowed to allocate in stack, VTA multiple target test will fail

2021-09-15 Thread GitBox
manupa-arm commented on issue #8978: URL: https://github.com/apache/tvm/issues/8978#issuecomment-920219633 Thanks for flagging this! IIUC, This is problematic for micro because now the constant sized allocates are forced to be placed on stack (bypassing TVMPlatformAllocate abs

[GitHub] [tvm] manupa-arm edited a comment on issue #8978: [Bug][VTA][OpenCL] If allowed to allocate in stack, VTA multiple target test will fail

2021-09-15 Thread GitBox
manupa-arm edited a comment on issue #8978: URL: https://github.com/apache/tvm/issues/8978#issuecomment-920219633 Thanks for flagging this! IIUC, This is problematic for micro because now the constant sized allocates are forced to be placed on stack (bypassing TVMPlatformAlloc

[GitHub] [tvm] manupa-arm edited a comment on issue #8978: [Bug][VTA][OpenCL] If allowed to allocate in stack, VTA multiple target test will fail

2021-09-15 Thread GitBox
manupa-arm edited a comment on issue #8978: URL: https://github.com/apache/tvm/issues/8978#issuecomment-920219633 Thanks for flagging this! IIUC, This is problematic for micro because now the constant sized allocates are forced to be placed on stack (bypassing TVMPlatformAlloc

[GitHub] [tvm] manupa-arm edited a comment on issue #8978: [Bug][VTA][OpenCL] If allowed to allocate in stack, VTA multiple target test will fail

2021-09-15 Thread GitBox
manupa-arm edited a comment on issue #8978: URL: https://github.com/apache/tvm/issues/8978#issuecomment-920219633 Thanks for flagging this! and following up from #8274 IIUC, This is problematic for micro because now the constant sized allocates are forced to be placed on stac

[GitHub] [tvm] manupa-arm edited a comment on issue #8978: [Bug][VTA][OpenCL] If allowed to allocate in stack, VTA multiple target test will fail

2021-09-15 Thread GitBox
manupa-arm edited a comment on issue #8978: URL: https://github.com/apache/tvm/issues/8978#issuecomment-920219633 Thanks for flagging this! and following up from #8274 IIUC, This is problematic for micro because now the constant sized allocates are forced to be placed on stac

[GitHub] [tvm] areusch commented on a change in pull request #8990: [microTVM] Update support for ARMv7m intrinsic

2021-09-15 Thread GitBox
areusch commented on a change in pull request #8990: URL: https://github.com/apache/tvm/pull/8990#discussion_r709406621 ## File path: tests/micro/zephyr/test_zephyr_armv7m.py ## @@ -0,0 +1,293 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contribut

[GitHub] [tvm] jroesch commented on pull request #8974: [Relay] Remove memory planing from LowerTEPass

2021-09-15 Thread GitBox
jroesch commented on pull request #8974: URL: https://github.com/apache/tvm/pull/8974#issuecomment-920225987 @mikepapadim can you follow up on @Mousius's request in a follow up PR, going to land so we can keep the queue clean and should be easy to send small followup. -- This is an aut

[GitHub] [tvm] jroesch merged pull request #8974: [Relay] Remove memory planing from LowerTEPass

2021-09-15 Thread GitBox
jroesch merged pull request #8974: URL: https://github.com/apache/tvm/pull/8974 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

[tvm] branch main updated (57386a2 -> 98ecefb)

2021-09-15 Thread jroesch
This is an automated email from the ASF dual-hosted git repository. jroesch pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from 57386a2 [Hexagon] Treat floats as float32 when passing args to offloaded kernels (#9010) add 98ecefb [Relay] Remo

[GitHub] [tvm] manupa-arm commented on pull request #9005: Add standalone_crt/ to be part of the wheel package, when available.

2021-09-15 Thread GitBox
manupa-arm commented on pull request #9005: URL: https://github.com/apache/tvm/pull/9005#issuecomment-920228506 @areusch Shall we merge this ? I think we agree that this step is required eitherway. -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [tvm] AndrewZhaoLuo commented on a change in pull request #9017: [ONNX] QLinearAveragePool and QLinearGlobalAveragePool contrib op

2021-09-15 Thread GitBox
AndrewZhaoLuo commented on a change in pull request #9017: URL: https://github.com/apache/tvm/pull/9017#discussion_r709416154 ## File path: python/tvm/relay/frontend/onnx.py ## @@ -654,6 +676,40 @@ def _impl_v1(cls, inputs, attr, params): ) +class QLinearGlobalAver

[GitHub] [tvm] vinx13 commented on pull request #8983: [Bugfix] Fix other div zero errors also in rewrite_simplify

2021-09-15 Thread GitBox
vinx13 commented on pull request #8983: URL: https://github.com/apache/tvm/pull/8983#issuecomment-920236818 There are some flaky tests on CI, could you push again to retrigger CI? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [tvm] areusch commented on a change in pull request #8990: [microTVM] Update support for ARMv7m intrinsic

2021-09-15 Thread GitBox
areusch commented on a change in pull request #8990: URL: https://github.com/apache/tvm/pull/8990#discussion_r709432323 ## File path: apps/microtvm/reference-vm/zephyr/base-box/base_box_test.sh ## @@ -37,3 +37,5 @@ if [ $board == "stm32f746xx" ]; then else pytest tests/mi

[GitHub] [tvm] jroesch commented on pull request #9005: Add standalone_crt/ to be part of the wheel package, when available.

2021-09-15 Thread GitBox
jroesch commented on pull request #9005: URL: https://github.com/apache/tvm/pull/9005#issuecomment-920244206 @manupa-arm I agree we can land but might be worth revisiting, from my perspective library should only point to `.so`, `.dylib`, and so on. I think it would be good to at minimum to

[GitHub] [tvm] areusch commented on a change in pull request #8990: [microTVM] Update support for ARMv7m intrinsic

2021-09-15 Thread GitBox
areusch commented on a change in pull request #8990: URL: https://github.com/apache/tvm/pull/8990#discussion_r709435990 ## File path: tests/micro/zephyr/test_zephyr_armv7m.py ## @@ -0,0 +1,293 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contribut

[GitHub] [tvm] jroesch merged pull request #9005: Add standalone_crt/ to be part of the wheel package, when available.

2021-09-15 Thread GitBox
jroesch merged pull request #9005: URL: https://github.com/apache/tvm/pull/9005 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

[tvm] branch main updated (98ecefb -> 2aebd33)

2021-09-15 Thread jroesch
This is an automated email from the ASF dual-hosted git repository. jroesch pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from 98ecefb [Relay] Remove memory planing from LowerTEPass (#8974) add 2aebd33 Add standalone_crt/ to be part of the

[GitHub] [tvm] jroesch commented on a change in pull request #8849: [5/6] Arm(R) Ethos(TM)-U NPU codegen integration

2021-09-15 Thread GitBox
jroesch commented on a change in pull request #8849: URL: https://github.com/apache/tvm/pull/8849#discussion_r709441749 ## File path: src/tir/transforms/lower_tvm_builtin.cc ## @@ -113,16 +113,6 @@ class BuiltinLower : public StmtExprMutator { op = stmt.as(); // Get c

[GitHub] [tvm] csullivan commented on a change in pull request #8986: [Hexagon] Implement model launcher

2021-09-15 Thread GitBox
csullivan commented on a change in pull request #8986: URL: https://github.com/apache/tvm/pull/8986#discussion_r709380322 ## File path: src/runtime/hexagon/launcher/README.md ## @@ -0,0 +1,173 @@ + + + + + + + + + + + + + + + + +# Hexagon Graph Launcher + +## Compilation + +The

[GitHub] [tvm] manupa-arm commented on a change in pull request #8849: [5/6] Arm(R) Ethos(TM)-U NPU codegen integration

2021-09-15 Thread GitBox
manupa-arm commented on a change in pull request #8849: URL: https://github.com/apache/tvm/pull/8849#discussion_r709445247 ## File path: src/tir/transforms/lower_tvm_builtin.cc ## @@ -113,16 +113,6 @@ class BuiltinLower : public StmtExprMutator { op = stmt.as(); // Ge

[GitHub] [tvm] kparzysz-quic commented on a change in pull request #8986: [Hexagon] Implement model launcher

2021-09-15 Thread GitBox
kparzysz-quic commented on a change in pull request #8986: URL: https://github.com/apache/tvm/pull/8986#discussion_r709450729 ## File path: src/runtime/hexagon/launcher/README.md ## @@ -0,0 +1,173 @@ + + + + + + + + + + + + + + + + +# Hexagon Graph Launcher + +## Compilation +

[GitHub] [tvm] kparzysz-quic commented on a change in pull request #8986: [Hexagon] Implement model launcher

2021-09-15 Thread GitBox
kparzysz-quic commented on a change in pull request #8986: URL: https://github.com/apache/tvm/pull/8986#discussion_r709457724 ## File path: src/runtime/hexagon/launcher/README.md ## @@ -0,0 +1,173 @@ + + + + + + + + + + + + + + + + +# Hexagon Graph Launcher + +## Compilation +

[GitHub] [tvm] mehrdadh commented on a change in pull request #8990: [microTVM] Update support for ARMv7m intrinsic

2021-09-15 Thread GitBox
mehrdadh commented on a change in pull request #8990: URL: https://github.com/apache/tvm/pull/8990#discussion_r709458696 ## File path: tests/micro/zephyr/test_zephyr_armv7m.py ## @@ -0,0 +1,293 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contribu

[GitHub] [tvm] kparzysz-quic commented on a change in pull request #8986: [Hexagon] Implement model launcher

2021-09-15 Thread GitBox
kparzysz-quic commented on a change in pull request #8986: URL: https://github.com/apache/tvm/pull/8986#discussion_r709459893 ## File path: src/runtime/hexagon/launcher/README.md ## @@ -0,0 +1,173 @@ + + + + + + + + + + + + + + + + +# Hexagon Graph Launcher + +## Compilation +

[GitHub] [tvm] manupa-arm commented on issue #8978: [Bug][VTA][OpenCL] If allowed to allocate in stack, VTA multiple target test will fail

2021-09-15 Thread GitBox
manupa-arm commented on issue #8978: URL: https://github.com/apache/tvm/issues/8978#issuecomment-920268526 Also for some reason, if we really need the tir.allocate to be translated down to as a stack placement, we should probably make the tir.allocate with storage_scope = "local" to PrimFu

[GitHub] [tvm] manupa-arm commented on a change in pull request #8849: [5/6] Arm(R) Ethos(TM)-U NPU codegen integration

2021-09-15 Thread GitBox
manupa-arm commented on a change in pull request #8849: URL: https://github.com/apache/tvm/pull/8849#discussion_r709445247 ## File path: src/tir/transforms/lower_tvm_builtin.cc ## @@ -113,16 +113,6 @@ class BuiltinLower : public StmtExprMutator { op = stmt.as(); // Ge

[GitHub] [tvm] manupa-arm commented on a change in pull request #8849: [5/6] Arm(R) Ethos(TM)-U NPU codegen integration

2021-09-15 Thread GitBox
manupa-arm commented on a change in pull request #8849: URL: https://github.com/apache/tvm/pull/8849#discussion_r709445247 ## File path: src/tir/transforms/lower_tvm_builtin.cc ## @@ -113,16 +113,6 @@ class BuiltinLower : public StmtExprMutator { op = stmt.as(); // Ge

[GitHub] [tvm] manupa-arm commented on a change in pull request #8849: [5/6] Arm(R) Ethos(TM)-U NPU codegen integration

2021-09-15 Thread GitBox
manupa-arm commented on a change in pull request #8849: URL: https://github.com/apache/tvm/pull/8849#discussion_r709445247 ## File path: src/tir/transforms/lower_tvm_builtin.cc ## @@ -113,16 +113,6 @@ class BuiltinLower : public StmtExprMutator { op = stmt.as(); // Ge

[tvm] branch comaniac-patch-1 created (now afb3c28)

2021-09-15 Thread comaniac
This is an automated email from the ASF dual-hosted git repository. comaniac pushed a change to branch comaniac-patch-1 in repository https://gitbox.apache.org/repos/asf/tvm.git. at afb3c28 [Community] @AndrewZhaoLuo -> Reviewer This branch includes the following new commits: new a

[tvm] 01/01: [Community] @AndrewZhaoLuo -> Reviewer

2021-09-15 Thread comaniac
This is an automated email from the ASF dual-hosted git repository. comaniac pushed a commit to branch comaniac-patch-1 in repository https://gitbox.apache.org/repos/asf/tvm.git commit afb3c289a6ee1c74d6d850248e168bc6c04c051b Author: Cody Yu AuthorDate: Wed Sep 15 11:42:57 2021 -0700 [Commu

[GitHub] [tvm] comaniac opened a new pull request #9020: [Community] @AndrewZhaoLuo -> Reviewer

2021-09-15 Thread GitBox
comaniac opened a new pull request #9020: URL: https://github.com/apache/tvm/pull/9020 Please join us to welcome @AndrewZhaoLuo as a new reviewer to TVM. Andrew has mainly contributed to automatic mixed precision (AMP) support and ONNX frontend improvements. - [Commits History](htt

[GitHub] [tvm] icemelon opened a new pull request #9021: [TOPI] Fix more pooling schedule

2021-09-15 Thread GitBox
icemelon opened a new pull request #9021: URL: https://github.com/apache/tvm/pull/9021 It's a follow-up update for #8957. In previous PR, I forgot to other pooling schedule in cuda and x86. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [tvm] icemelon commented on pull request #9021: [TOPI] Fix more pooling schedule

2021-09-15 Thread GitBox
icemelon commented on pull request #9021: URL: https://github.com/apache/tvm/pull/9021#issuecomment-920295600 cc @comaniac @junrushao1994 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [tvm] huajsj commented on a change in pull request #9012: [Relay] VLOG for finer grained control of hyper-detailed logging

2021-09-15 Thread GitBox
huajsj commented on a change in pull request #9012: URL: https://github.com/apache/tvm/pull/9012#discussion_r709444137 ## File path: include/tvm/runtime/logging.h ## @@ -395,10 +399,13 @@ class LogMessageVoidify { inline bool DebugLoggingEnabled() { static int state = 0;

[GitHub] [tvm] AndrewZhaoLuo commented on pull request #8971: [Onnx] Fix NLL Loss tests

2021-09-15 Thread GitBox
AndrewZhaoLuo commented on pull request #8971: URL: https://github.com/apache/tvm/pull/8971#issuecomment-920304017 Ok folks, I've removed the controversial changes and did an alternate work around. PTAL when you have time. -- This is an automated message from the Apache Git Service. To r

[GitHub] [tvm] areusch commented on a change in pull request #8423: Implementation of relay_to_tir target hook

2021-09-15 Thread GitBox
areusch commented on a change in pull request #8423: URL: https://github.com/apache/tvm/pull/8423#discussion_r709518464 ## File path: cmake/modules/contrib/ExampleTargetHooks.cmake ## @@ -0,0 +1,19 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more cont

[GitHub] [tvm] areusch commented on a change in pull request #8423: Implementation of relay_to_tir target hook

2021-09-15 Thread GitBox
areusch commented on a change in pull request #8423: URL: https://github.com/apache/tvm/pull/8423#discussion_r709518575 ## File path: cmake/modules/contrib/ExampleTargetHooks.cmake ## @@ -0,0 +1,19 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more cont

[GitHub] [tvm] sergey-grovety commented on a change in pull request #8990: [microTVM] Update support for ARMv7m intrinsic

2021-09-15 Thread GitBox
sergey-grovety commented on a change in pull request #8990: URL: https://github.com/apache/tvm/pull/8990#discussion_r709527891 ## File path: apps/microtvm/reference-vm/zephyr/base-box/base_box_test.sh ## @@ -37,3 +37,5 @@ if [ $board == "stm32f746xx" ]; then else pytest t

[GitHub] [tvm] mbs-octoml opened a new issue #9022: [Bug] BuiltinLower does not use alloca for storage on kDLCPU target devices

2021-09-15 Thread GitBox
mbs-octoml opened a new issue #9022: URL: https://github.com/apache/tvm/issues/9022 https://github.com/apache/tvm/blob/2aebd3335d89bb32d330b0f851ddaf2d551fc56e/src/tir/transforms/lower_tvm_builtin.cc#L115 This particular code has a complex history but the upshot is we need finer gra

[GitHub] [tvm] sergey-grovety commented on a change in pull request #8990: [microTVM] Update support for ARMv7m intrinsic

2021-09-15 Thread GitBox
sergey-grovety commented on a change in pull request #8990: URL: https://github.com/apache/tvm/pull/8990#discussion_r709531309 ## File path: tests/micro/zephyr/test_zephyr_armv7m.py ## @@ -0,0 +1,293 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more co

[GitHub] [tvm] mbs-octoml commented on a change in pull request #8849: [5/6] Arm(R) Ethos(TM)-U NPU codegen integration

2021-09-15 Thread GitBox
mbs-octoml commented on a change in pull request #8849: URL: https://github.com/apache/tvm/pull/8849#discussion_r709531817 ## File path: src/tir/transforms/lower_tvm_builtin.cc ## @@ -113,16 +113,6 @@ class BuiltinLower : public StmtExprMutator { op = stmt.as(); // Ge

[GitHub] [tvm] sergey-grovety commented on pull request #8990: [microTVM] Update support for ARMv7m intrinsic

2021-09-15 Thread GitBox
sergey-grovety commented on pull request #8990: URL: https://github.com/apache/tvm/pull/8990#issuecomment-920335684 > for the test image maybe you could reuse this image: https://github.com/apache/tvm/blob/main/tests/micro/testdata/mnist/digit-2.jpg Yes, sure. -- This is an automa

[GitHub] [tvm] mbs-octoml commented on a change in pull request #8849: [5/6] Arm(R) Ethos(TM)-U NPU codegen integration

2021-09-15 Thread GitBox
mbs-octoml commented on a change in pull request #8849: URL: https://github.com/apache/tvm/pull/8849#discussion_r709531817 ## File path: src/tir/transforms/lower_tvm_builtin.cc ## @@ -113,16 +113,6 @@ class BuiltinLower : public StmtExprMutator { op = stmt.as(); // Ge

[GitHub] [tvm] masahi commented on a change in pull request #8985: [ONNX] Add Einsum converter

2021-09-15 Thread GitBox
masahi commented on a change in pull request #8985: URL: https://github.com/apache/tvm/pull/8985#discussion_r709533999 ## File path: python/tvm/relay/op/strategy/cuda.py ## @@ -1210,3 +1210,16 @@ def invert_permutation_strategy_cuda(attrs, inputs, out_type, target): n

[GitHub] [tvm] masahi merged pull request #8985: [ONNX] Add Einsum converter

2021-09-15 Thread GitBox
masahi merged pull request #8985: URL: https://github.com/apache/tvm/pull/8985 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

[tvm] branch main updated (2aebd33 -> e44f6c0)

2021-09-15 Thread masahi
This is an automated email from the ASF dual-hosted git repository. masahi pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from 2aebd33 Add standalone_crt/ to be part of the wheel package, when available. (#9005) add e44f6c0 [ONNX] Add Einsum

[GitHub] [tvm] masahi commented on pull request #8985: [ONNX] Add Einsum converter

2021-09-15 Thread GitBox
masahi commented on pull request #8985: URL: https://github.com/apache/tvm/pull/8985#issuecomment-920338681 Thanks @anwang2009 @AndrewZhaoLuo @mbrookhart @junrushao1994 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [tvm] mbs-octoml commented on a change in pull request #9012: [Relay] VLOG for finer grained control of hyper-detailed logging

2021-09-15 Thread GitBox
mbs-octoml commented on a change in pull request #9012: URL: https://github.com/apache/tvm/pull/9012#discussion_r709537186 ## File path: CMakeLists.txt ## @@ -575,7 +575,7 @@ endif() # Create the `cpptest` target if we can find GTest. If not, we create dummy # targets that g

[GitHub] [tvm] mbs-octoml commented on a change in pull request #9012: [Relay] VLOG for finer grained control of hyper-detailed logging

2021-09-15 Thread GitBox
mbs-octoml commented on a change in pull request #9012: URL: https://github.com/apache/tvm/pull/9012#discussion_r709537682 ## File path: include/tvm/runtime/logging.h ## @@ -129,8 +132,9 @@ * a = ... * b = ... * // if quit_on_assertion is true, if a==b, continue, ot

[GitHub] [tvm] areusch commented on a change in pull request #8960: [Hexagon] Add contrib tests for blocked conv2d and maxpool2d

2021-09-15 Thread GitBox
areusch commented on a change in pull request #8960: URL: https://github.com/apache/tvm/pull/8960#discussion_r709528557 ## File path: tests/python/contrib/test_hexagon/test_conv2d_blocked.py ## @@ -0,0 +1,473 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# o

  1   2   >