junrushao1994 edited a comment on pull request #5585:
URL: https://github.com/apache/incubator-tvm/pull/5585#issuecomment-631147088
As `CHECK` causes significant regression in stack utilization, we dived
deeper into this case, and then figured out that `dmlc::LogMessageFatal` is the
cause
junrushao1994 edited a comment on pull request #5585:
URL: https://github.com/apache/incubator-tvm/pull/5585#issuecomment-631147088
As `CHECK` causes significant regression in stack utilization, we dived
deeper into this case, and then figured out that `dmlc::LogMessageFatal` is the
cause
dhruvaray commented on pull request #5329:
URL: https://github.com/apache/incubator-tvm/pull/5329#issuecomment-631867834
@siju-samuel - Let me know if all is good
This is an automated message from the Apache Git Service.
To
dhruvaray commented on pull request #5447:
URL: https://github.com/apache/incubator-tvm/pull/5447#issuecomment-631866290
@siju-samuel, @u99127 - Incorporated all the comments
@FrozenGene, @kazum - Please merge if good
Menooker commented on a change in pull request #5601:
URL: https://github.com/apache/incubator-tvm/pull/5601#discussion_r428427929
##
File path: include/tvm/runtime/data_type.h
##
@@ -81,6 +82,10 @@ class DataType {
bool is_float() const { return code() == DataType::kFloat;
Menooker commented on a change in pull request #5601:
URL: https://github.com/apache/incubator-tvm/pull/5601#discussion_r428427975
##
File path: include/tvm/runtime/data_type.h
##
@@ -297,6 +302,8 @@ inline const char* TypeCode2Str(int type_code) {
return "Object";
Menooker commented on a change in pull request #5601:
URL: https://github.com/apache/incubator-tvm/pull/5601#discussion_r428427694
##
File path: include/tvm/runtime/c_runtime_api.h
##
@@ -114,6 +114,7 @@ typedef enum {
kTVMNNVMLast = 20U,
// The following section of code
Menooker commented on a change in pull request #5601:
URL: https://github.com/apache/incubator-tvm/pull/5601#discussion_r428424469
##
File path: src/target/llvm/codegen_llvm.cc
##
@@ -555,12 +558,48 @@ void CodeGenLLVM::CreateSerialFor(llvm::Value* begin,
llvm::Value* end,
masahi merged pull request #5637:
URL: https://github.com/apache/incubator-tvm/pull/5637
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
This is an automated email from the ASF dual-hosted git repository.
masahi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git
The following commit(s) were added to refs/heads/master by this push:
new cafb498 Extend AttrPattern to support
masahi commented on pull request #5637:
URL: https://github.com/apache/incubator-tvm/pull/5637#issuecomment-631854288
Thanks @mbrookhart @comaniac
This is an automated message from the Apache Git Service.
To respond to the
FrozenGene commented on a change in pull request #5394:
URL: https://github.com/apache/incubator-tvm/pull/5394#discussion_r428406145
##
File path: tests/python/frontend/tflite/test_forward.py
##
@@ -1552,6 +1552,48 @@ def test_forward_squeeze():
masahi commented on a change in pull request #5628:
URL: https://github.com/apache/incubator-tvm/pull/5628#discussion_r428396485
##
File path: topi/python/topi/cuda/correlation.py
##
@@ -0,0 +1,176 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
masahi commented on a change in pull request #5628:
URL: https://github.com/apache/incubator-tvm/pull/5628#discussion_r428395419
##
File path: topi/python/topi/cuda/correlation.py
##
@@ -0,0 +1,176 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
masahi commented on a change in pull request #5628:
URL: https://github.com/apache/incubator-tvm/pull/5628#discussion_r428395349
##
File path: topi/python/topi/cuda/correlation.py
##
@@ -0,0 +1,176 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
masahi commented on a change in pull request #5628:
URL: https://github.com/apache/incubator-tvm/pull/5628#discussion_r428395061
##
File path: topi/python/topi/cuda/correlation.py
##
@@ -0,0 +1,176 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
This is an automated email from the ASF dual-hosted git repository.
masahi pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git.
from e10ea86 [RELAY][PYTORCH]Resize3d, Upsample3d op support (#5633)
add 019da5d [TUTORIAL]TFLite QNN
masahi commented on pull request #5595:
URL: https://github.com/apache/incubator-tvm/pull/5595#issuecomment-631810837
Thanks @siju-samuel @anijain2305
This is an automated message from the Apache Git Service.
To respond to
masahi merged pull request #5595:
URL: https://github.com/apache/incubator-tvm/pull/5595
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
masahi merged pull request #5633:
URL: https://github.com/apache/incubator-tvm/pull/5633
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
This is an automated email from the ASF dual-hosted git repository.
masahi pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git.
from c94e6ba Label Pattern Partitions (#5627)
add e10ea86 [RELAY][PYTORCH]Resize3d, Upsample3d op support
masahi commented on pull request #5627:
URL: https://github.com/apache/incubator-tvm/pull/5627#issuecomment-631807935
Thanks @mbrookhart @comaniac
This is an automated message from the Apache Git Service.
To respond to the
masahi merged pull request #5627:
URL: https://github.com/apache/incubator-tvm/pull/5627
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
This is an automated email from the ASF dual-hosted git repository.
masahi pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git.
from 15f3ce3 Fix typo in test script (#5635)
add c94e6ba Label Pattern Partitions (#5627)
No new revisions
tqchen commented on pull request #5628:
URL: https://github.com/apache/incubator-tvm/pull/5628#issuecomment-631764205
@vinx13 can you also list the reference APIs in pytorch, tf, mx for the API
design
This is an automated
tqchen commented on a change in pull request #5628:
URL: https://github.com/apache/incubator-tvm/pull/5628#discussion_r428345304
##
File path: include/tvm/relay/attrs/nn.h
##
@@ -1203,6 +1203,36 @@ struct SubPixelAttrs : public
tvm::AttrsNode {
}
}; // struct
tqchen merged pull request #5635:
URL: https://github.com/apache/incubator-tvm/pull/5635
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
This is an automated email from the ASF dual-hosted git repository.
tqchen pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git.
from e180b66 [NODE][PASS] Introduce config to PassContext. (#5631)
add 9d78ad8 another cmake fix (#5630)
tqchen merged pull request #5630:
URL: https://github.com/apache/incubator-tvm/pull/5630
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
This is an automated email from the ASF dual-hosted git repository.
tqchen pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git.
from 9d78ad8 another cmake fix (#5630)
add 15f3ce3 Fix typo in test script (#5635)
No new revisions were
comaniac commented on pull request #5637:
URL: https://github.com/apache/incubator-tvm/pull/5637#issuecomment-631751569
cc @masahi
This is an automated message from the Apache Git Service.
To respond to the message, please
zhiics commented on pull request #5631:
URL: https://github.com/apache/incubator-tvm/pull/5631#issuecomment-631747873
Thanks @tqchen
This is an automated message from the Apache Git Service.
To respond to the message,
This is an automated email from the ASF dual-hosted git repository.
zhic pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git.
from c286b2d [RELAY][BYOC] Fix the creation of tuple of tuples in
PartitionGraph (#5616)
add e180b66
zhiics merged pull request #5631:
URL: https://github.com/apache/incubator-tvm/pull/5631
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
masahi commented on pull request #5627:
URL: https://github.com/apache/incubator-tvm/pull/5627#issuecomment-631746686
Ah I see what you mean. I don't think constant names such as `kComposite`
defined in cpp are available in python.
comaniac commented on a change in pull request #5637:
URL: https://github.com/apache/incubator-tvm/pull/5637#discussion_r428325039
##
File path: src/relay/ir/dataflow_matcher.cc
##
@@ -101,39 +101,69 @@ bool DFPatternMatcher::VisitDFPattern_(const
AltPatternNode* op, const
mbrookhart edited a comment on pull request #5627:
URL: https://github.com/apache/incubator-tvm/pull/5627#issuecomment-631741232
I can get the value with that PR once it's in the function, but I can't seem
to replace the string in this call with the constant?:
```
mbrookhart commented on pull request #5627:
URL: https://github.com/apache/incubator-tvm/pull/5627#issuecomment-631741232
I can get the value with that PR once it's in the function, but I can't seem
to replace the string in this call with the constant?:
```
masahi commented on pull request #5627:
URL: https://github.com/apache/incubator-tvm/pull/5627#issuecomment-631739239
See this PR https://github.com/apache/incubator-tvm/pull/4905
This is an automated message from the Apache
mbrookhart commented on pull request #5627:
URL: https://github.com/apache/incubator-tvm/pull/5627#issuecomment-631737061
@masahi Made that change. It doesn't seem to be possible to access the
constant name from python?
mbrookhart opened a new pull request #5637:
URL: https://github.com/apache/incubator-tvm/pull/5637
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
samwyi commented on pull request #5636:
URL: https://github.com/apache/incubator-tvm/pull/5636#issuecomment-631709324
@tqchen, please review, thank you!
This is an automated message from the Apache Git Service.
To respond to
samwyi opened a new pull request #5636:
URL: https://github.com/apache/incubator-tvm/pull/5636
* fixed this issue by changing WorkspacePool's destruction order
https://github.com/apache/incubator-tvm/issues/5632
This
mbrookhart commented on pull request #5627:
URL: https://github.com/apache/incubator-tvm/pull/5627#issuecomment-631703600
@masahi Sure! That makes sense, I wasn't aware of the centralized location.
Give me a bit, maybe request changes until I can get back to it?
masahi edited a comment on pull request #5627:
URL: https://github.com/apache/incubator-tvm/pull/5627#issuecomment-631693138
@mbrookhart Can you define this attribute in a public header? Since it will
be looked up by backends like this
masahi edited a comment on pull request #5627:
URL: https://github.com/apache/incubator-tvm/pull/5627#issuecomment-631693138
@mbrookhart Can you define this attribute on C++ side? Since it will be
looked up by backends like this
masahi commented on pull request #5627:
URL: https://github.com/apache/incubator-tvm/pull/5627#issuecomment-631693138
@mbrookhart Can you define this attribute on C++ side? Since it will be
looked up by backends like this
mbrookhart commented on pull request #5627:
URL: https://github.com/apache/incubator-tvm/pull/5627#issuecomment-631678103
Changed the name of the tag :+1:
This is an automated message from the Apache Git Service.
To respond
mbrookhart commented on a change in pull request #5627:
URL: https://github.com/apache/incubator-tvm/pull/5627#discussion_r428256923
##
File path: python/tvm/relay/dataflow_pattern/__init__.py
##
@@ -112,21 +112,23 @@ def match(self, expr: Expr) -> bool:
"""
mbrookhart commented on a change in pull request #5627:
URL: https://github.com/apache/incubator-tvm/pull/5627#discussion_r428257024
##
File path: python/tvm/relay/dataflow_pattern/__init__.py
##
@@ -572,10 +574,12 @@ def partition(pattern: DFPattern, expr: Expr) -> Expr:
mbrookhart commented on a change in pull request #5627:
URL: https://github.com/apache/incubator-tvm/pull/5627#discussion_r428252217
##
File path: src/relay/ir/dataflow_matcher.cc
##
@@ -625,7 +674,13 @@ class PatternPartitioner : protected MixedModeMutator {
for (size_t
comaniac commented on a change in pull request #5627:
URL: https://github.com/apache/incubator-tvm/pull/5627#discussion_r428246339
##
File path: python/tvm/relay/dataflow_pattern/__init__.py
##
@@ -112,21 +112,23 @@ def match(self, expr: Expr) -> bool:
"""
masahi edited a comment on pull request #5627:
URL: https://github.com/apache/incubator-tvm/pull/5627#issuecomment-631665530
Given that there is also graph partitioning pass in BYOC workflow, where
"partitioning" means different thing, could it be confusing if we add
"Partitioned"
masahi commented on pull request #5627:
URL: https://github.com/apache/incubator-tvm/pull/5627#issuecomment-631665530
Given that there is also graph partitioning pass in BYOC workflow, where
"partitioning" means different thing, could it be confusing if we add
"Partitioned" attribute
masahi commented on a change in pull request #5627:
URL: https://github.com/apache/incubator-tvm/pull/5627#discussion_r428238586
##
File path: src/relay/ir/dataflow_matcher.cc
##
@@ -625,7 +674,13 @@ class PatternPartitioner : protected MixedModeMutator {
for (size_t i =
anijain2305 commented on pull request #5394:
URL: https://github.com/apache/incubator-tvm/pull/5394#issuecomment-631650814
LGTM. I will leave the PR to FrozenGene to resolve his comment.
This is an automated message from the
vinx13 opened a new pull request #5635:
URL: https://github.com/apache/incubator-tvm/pull/5635
@tqchen
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
tqchen commented on a change in pull request #5601:
URL: https://github.com/apache/incubator-tvm/pull/5601#discussion_r428114225
##
File path: src/target/llvm/codegen_llvm.cc
##
@@ -555,12 +558,48 @@ void CodeGenLLVM::CreateSerialFor(llvm::Value* begin,
llvm::Value* end,
tqchen commented on a change in pull request #5601:
URL: https://github.com/apache/incubator-tvm/pull/5601#discussion_r428113769
##
File path: include/tvm/runtime/c_runtime_api.h
##
@@ -114,6 +114,7 @@ typedef enum {
kTVMNNVMLast = 20U,
// The following section of code
zhiics commented on pull request #5616:
URL: https://github.com/apache/incubator-tvm/pull/5616#issuecomment-631547984
Thanks @manupa-arm @masahi @comaniac @mbaret
This is an automated message from the Apache Git Service.
To
This is an automated email from the ASF dual-hosted git repository.
zhic pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git.
from d8b185c [DOCS] Move the api docs to the api subfolder (#5626)
add c286b2d [RELAY][BYOC] Fix the creation
zhiics merged pull request #5616:
URL: https://github.com/apache/incubator-tvm/pull/5616
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
tqchen commented on issue #5632:
URL: https://github.com/apache/incubator-tvm/issues/5632#issuecomment-631528758
The proposal sounds good, feel free to send a PR.
This is an automated message from the Apache Git Service.
To
tqchen edited a comment on pull request #5236:
URL: https://github.com/apache/incubator-tvm/pull/5236#issuecomment-631521753
Please be patient. Careful code reveiws takes time and they are as
valuable, if not more valuable than the contribution itself. We certainly need
more eyes for a
tqchen edited a comment on pull request #5236:
URL: https://github.com/apache/incubator-tvm/pull/5236#issuecomment-631521753
Please be patient. Careful code reveiws takes time and in many time sthey
are as valuable, if not more valuable than the contribution itself. We
certainly need
tqchen commented on pull request #5236:
URL: https://github.com/apache/incubator-tvm/pull/5236#issuecomment-631521753
Please be patient. Careful code reveiws takes time and in many time sthey
are as valuable, if not more valuable than the contribution itself. One way to
help review
ANSHUMAN87 commented on pull request #5236:
URL: https://github.com/apache/incubator-tvm/pull/5236#issuecomment-631500869
@tqchen : I think i have reworked on all your comments now. With the new
string marshaling approach, i believe now it is more modular. Can you please
take a look, and
kazum opened a new pull request #5634:
URL: https://github.com/apache/incubator-tvm/pull/5634
This PR implements CoreML codegen using the BYOC feature and enables us to
offload subgraphs to Apple’s Neural Engine on iOS devices.
- The CoreML codegen is implemented with Python
manupa-arm commented on a change in pull request #5616:
URL: https://github.com/apache/incubator-tvm/pull/5616#discussion_r427938614
##
File path: src/relay/transforms/partition_graph.cc
##
@@ -404,21 +404,88 @@ IRModule RemoveDefaultAnnotations(IRModule module) {
return
siju-samuel commented on pull request #5595:
URL: https://github.com/apache/incubator-tvm/pull/5595#issuecomment-631406248
@anijain2305 @masahi Please help to review and merge this PR. TIA
This is an automated message from
siju-samuel commented on pull request #5394:
URL: https://github.com/apache/incubator-tvm/pull/5394#issuecomment-631405877
@FrozenGene @masahi @anijain2305 Please help to review and merge this PR.
TIA.
This is an automated
siju-samuel opened a new pull request #5633:
URL: https://github.com/apache/incubator-tvm/pull/5633
- Resize3d implementation in relay
- aten::upsample_trilinear3d
- aten::upsample_nearest3d
@masahi please help me to review this PR. TIA.
Shawn-Inspur commented on a change in pull request #5600:
URL: https://github.com/apache/incubator-tvm/pull/5600#discussion_r427832441
##
File path: topi/python/topi/cuda/softmax.py
##
@@ -53,13 +54,62 @@ def schedule_softmax(outs):
raise ValueError('Tag is expected
samwyi opened a new issue #5632:
URL: https://github.com/apache/incubator-tvm/issues/5632
**Problem:** When VulkanThreadEntry is destructed, its member "streams_" is
destructed before "pool" (members are destructed in reverse order of their
appearance in class definition). pool's
Menooker commented on a change in pull request #5601:
URL: https://github.com/apache/incubator-tvm/pull/5601#discussion_r427761508
##
File path: include/tvm/runtime/c_runtime_api.h
##
@@ -114,6 +114,7 @@ typedef enum {
kTVMNNVMLast = 20U,
// The following section of code
75 matches
Mail list logo
