[incubator-tvm] branch master updated (bfe83eb -> 27f00ef)

2020-07-13 Thread masahi
This is an automated email from the ASF dual-hosted git repository. masahi pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from bfe83eb Refactor to expose MakeOp functions to C++ (#6047) add 27f00ef Fix pytorch frontend prim::Const

[GitHub] [incubator-tvm] jcf94 commented on a change in pull request #5962: [Ansor][AutoTVM v2.0] Part 0: Ansor minimum system for auto schedule generating

2020-07-13 Thread GitBox
jcf94 commented on a change in pull request #5962: URL: https://github.com/apache/incubator-tvm/pull/5962#discussion_r454140951 ## File path: src/auto_schedule/utils.cc ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributo

[incubator-tvm] branch master updated (bfe83eb -> 27f00ef)

2020-07-13 Thread masahi
This is an automated email from the ASF dual-hosted git repository. masahi pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from bfe83eb Refactor to expose MakeOp functions to C++ (#6047) add 27f00ef Fix pytorch frontend prim::Const

[incubator-tvm] branch master updated (bfe83eb -> 27f00ef)

2020-07-13 Thread masahi
This is an automated email from the ASF dual-hosted git repository. masahi pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from bfe83eb Refactor to expose MakeOp functions to C++ (#6047) add 27f00ef Fix pytorch frontend prim::Const

[incubator-tvm] branch master updated (bfe83eb -> 27f00ef)

2020-07-13 Thread masahi
This is an automated email from the ASF dual-hosted git repository. masahi pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from bfe83eb Refactor to expose MakeOp functions to C++ (#6047) add 27f00ef Fix pytorch frontend prim::Const

[incubator-tvm] branch master updated (bfe83eb -> 27f00ef)

2020-07-13 Thread masahi
This is an automated email from the ASF dual-hosted git repository. masahi pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from bfe83eb Refactor to expose MakeOp functions to C++ (#6047) add 27f00ef Fix pytorch frontend prim::Const

[GitHub] [incubator-tvm] masahi commented on pull request #6051: Fix pytorch frontend prim::Constant issue

2020-07-13 Thread GitBox
masahi commented on pull request #6051: URL: https://github.com/apache/incubator-tvm/pull/6051#issuecomment-658004243 Thanks @jxx123 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-tvm] masahi closed issue #6050: [BUG] Pytorch frontend error when the value of prim::Constant is a tensor in cuda

2020-07-13 Thread GitBox
masahi closed issue #6050: URL: https://github.com/apache/incubator-tvm/issues/6050 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [incubator-tvm] masahi merged pull request #6051: Fix pytorch frontend prim::Constant issue

2020-07-13 Thread GitBox
masahi merged pull request #6051: URL: https://github.com/apache/incubator-tvm/pull/6051 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [incubator-tvm] jcf94 commented on a change in pull request #5962: [Ansor][AutoTVM v2.0] Part 0: Ansor minimum system for auto schedule generating

2020-07-13 Thread GitBox
jcf94 commented on a change in pull request #5962: URL: https://github.com/apache/incubator-tvm/pull/5962#discussion_r454140951 ## File path: src/auto_schedule/utils.cc ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributo

[GitHub] [incubator-tvm] merrymercy commented on a change in pull request #5962: [Ansor][AutoTVM v2.0] Part 0: Ansor minimum system for auto schedule generating

2020-07-13 Thread GitBox
merrymercy commented on a change in pull request #5962: URL: https://github.com/apache/incubator-tvm/pull/5962#discussion_r454140148 ## File path: src/auto_schedule/utils.cc ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contr

[GitHub] [incubator-tvm] merrymercy commented on a change in pull request #5962: [Ansor][AutoTVM v2.0] Part 0: Ansor minimum system for auto schedule generating

2020-07-13 Thread GitBox
merrymercy commented on a change in pull request #5962: URL: https://github.com/apache/incubator-tvm/pull/5962#discussion_r454140148 ## File path: src/auto_schedule/utils.cc ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contr

[GitHub] [incubator-tvm] merrymercy commented on a change in pull request #5962: [Ansor][AutoTVM v2.0] Part 0: Ansor minimum system for auto schedule generating

2020-07-13 Thread GitBox
merrymercy commented on a change in pull request #5962: URL: https://github.com/apache/incubator-tvm/pull/5962#discussion_r454137351 ## File path: src/auto_schedule/utils.cc ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contr

[GitHub] [incubator-tvm] icemelon9 commented on pull request #6052: [Relay][Pass] Merge two consecutive reshape ops

2020-07-13 Thread GitBox
icemelon9 commented on pull request #6052: URL: https://github.com/apache/incubator-tvm/pull/6052#issuecomment-657994257 cc @zhiics @comaniac @jroesch This is an automated message from the Apache Git Service. To respond to t

[GitHub] [incubator-tvm] FrozenGene commented on pull request #5914: [clflush] Enable x86 cpu cache flush

2020-07-13 Thread GitBox
FrozenGene commented on pull request #5914: URL: https://github.com/apache/incubator-tvm/pull/5914#issuecomment-657994138 > > @comaniac I have updated the doc and change the name from `f_prepare` to `f_preproc`. Could you help to review it again? > > Didn't see the update on my side.

[GitHub] [incubator-tvm] icemelon9 opened a new pull request #6052: [Relay][Pass] Merge two consecutive reshape ops

2020-07-13 Thread GitBox
icemelon9 opened a new pull request #6052: URL: https://github.com/apache/incubator-tvm/pull/6052 Use pattern matching rewriter to merge two consecutive reshape ops. @mbrookhart I also added an InferType pass after rewriting each pattern. I think this change can make the pattern rewr

[GitHub] [incubator-tvm] zchuang11 commented on issue #5393: Tensorflow OP: 'DenseToDenseSetOperation', 'NonMaxSuppressionV3', 'SparseToDense', 'Unique'

2020-07-13 Thread GitBox
zchuang11 commented on issue #5393: URL: https://github.com/apache/incubator-tvm/issues/5393#issuecomment-657992191 > 'NonMaxSuppressionV3' has been added the tensorflow frontend. Thanks, DenseToDenseSetOperation', 'SparseToDense' and 'Unique' had been supported? -

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #5915: [BYOC][Contrib] Arm Compute Library integration

2020-07-13 Thread GitBox
comaniac commented on a change in pull request #5915: URL: https://github.com/apache/incubator-tvm/pull/5915#discussion_r454123642 ## File path: src/runtime/contrib/arm_compute_lib/acl_runtime.cc ## @@ -0,0 +1,399 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [incubator-tvm] comaniac commented on pull request #5914: [clflush] Enable x86 cpu cache flush

2020-07-13 Thread GitBox
comaniac commented on pull request #5914: URL: https://github.com/apache/incubator-tvm/pull/5914#issuecomment-657985296 > @comaniac I have updated the doc and change the name from `f_prepare` to `f_preproc`. Could you help to review it again? Didn't see the update on my side. Will ch

[GitHub] [incubator-tvm] FrozenGene commented on pull request #5914: [clflush] Enable x86 cpu cache flush

2020-07-13 Thread GitBox
FrozenGene commented on pull request #5914: URL: https://github.com/apache/incubator-tvm/pull/5914#issuecomment-657976125 @comaniac I have updated the doc and change the name from `f_prepare` to `f_preproc`. Could you help to review it again? --

[GitHub] [incubator-tvm] maheshambule commented on a change in pull request #5052: [TARGET] ONNX codegen

2020-07-13 Thread GitBox
maheshambule commented on a change in pull request #5052: URL: https://github.com/apache/incubator-tvm/pull/5052#discussion_r454097165 ## File path: python/tvm/contrib/target/__init__.py ## @@ -14,5 +14,3 @@ # KIND, either express or implied. See the License for the # specif

[GitHub] [incubator-tvm] masahi edited a comment on pull request #6049: [Pytorch] add operator copy_ support

2020-07-13 Thread GitBox
masahi edited a comment on pull request #6049: URL: https://github.com/apache/incubator-tvm/pull/6049#issuecomment-657950702 @huajsj please add a test. Also, `_` suffix in `copy_` likely means it is an in-place op, so it's better to add support for non in-place version `aten::copy` as well

[GitHub] [incubator-tvm] masahi commented on pull request #6049: [Pytorch] add operator copy_ support

2020-07-13 Thread GitBox
masahi commented on pull request #6049: URL: https://github.com/apache/incubator-tvm/pull/6049#issuecomment-657950702 @huajsj please add a test. Also, `_` suffix in `copy_` likely means it is an in-place op, so it's better to add support for `aten::copy` as well (the same conversion as `co

[GitHub] [incubator-tvm] jcf94 commented on a change in pull request #5962: [Ansor][AutoTVM v2.0] Part 0: Ansor minimum system for auto schedule generating

2020-07-13 Thread GitBox
jcf94 commented on a change in pull request #5962: URL: https://github.com/apache/incubator-tvm/pull/5962#discussion_r454078975 ## File path: src/auto_schedule/utils.cc ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributo

[GitHub] [incubator-tvm] jcf94 commented on a change in pull request #5962: [Ansor][AutoTVM v2.0] Part 0: Ansor minimum system for auto schedule generating

2020-07-13 Thread GitBox
jcf94 commented on a change in pull request #5962: URL: https://github.com/apache/incubator-tvm/pull/5962#discussion_r454078975 ## File path: src/auto_schedule/utils.cc ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributo

[GitHub] [incubator-tvm] jcf94 commented on a change in pull request #5962: [Ansor][AutoTVM v2.0] Part 0: Ansor minimum system for auto schedule generating

2020-07-13 Thread GitBox
jcf94 commented on a change in pull request #5962: URL: https://github.com/apache/incubator-tvm/pull/5962#discussion_r454078975 ## File path: src/auto_schedule/utils.cc ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributo

[GitHub] [incubator-tvm] zhiics commented on pull request #6007: [RELAY][DYN] Dynamic broadcast_to, zeros, ones

2020-07-13 Thread GitBox
zhiics commented on pull request #6007: URL: https://github.com/apache/incubator-tvm/pull/6007#issuecomment-657949021 @electriclilies Could you modify the code according to the changes in #6047 This is an automated message fr

[GitHub] [incubator-tvm] zhiics merged pull request #6047: Refactor to expose MakeOp functions to C++

2020-07-13 Thread GitBox
zhiics merged pull request #6047: URL: https://github.com/apache/incubator-tvm/pull/6047 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [incubator-tvm] zhiics commented on pull request #6047: Refactor to expose MakeOp functions to C++

2020-07-13 Thread GitBox
zhiics commented on pull request #6047: URL: https://github.com/apache/incubator-tvm/pull/6047#issuecomment-657948710 Thanks @mbrookhart This is an automated message from the Apache Git Service. To respond to the message, pl

[incubator-tvm] branch master updated (e4a0aa5 -> bfe83eb)

2020-07-13 Thread zhic
This is an automated email from the ASF dual-hosted git repository. zhic pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from e4a0aa5 [IR] Fix a primitive check error (#5991) add bfe83eb Refactor to expose MakeOp functions to C++ (

[GitHub] [incubator-tvm] jcf94 commented on a change in pull request #5962: [Ansor][AutoTVM v2.0] Part 0: Ansor minimum system for auto schedule generating

2020-07-13 Thread GitBox
jcf94 commented on a change in pull request #5962: URL: https://github.com/apache/incubator-tvm/pull/5962#discussion_r454078975 ## File path: src/auto_schedule/utils.cc ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributo

[GitHub] [incubator-tvm] tqchen commented on pull request #5892: Add TVM application extension with WASM runtime

2020-07-13 Thread GitBox
tqchen commented on pull request #5892: URL: https://github.com/apache/incubator-tvm/pull/5892#issuecomment-657946685 cc @kazum This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-tvm] tqchen commented on pull request #5892: Add TVM application extension with WASM runtime

2020-07-13 Thread GitBox
tqchen commented on pull request #5892: URL: https://github.com/apache/incubator-tvm/pull/5892#issuecomment-657946635 @leonwanghui it seems that we might want to include .cargo/config, can you modify `https://github.com/apache/incubator-tvm/blob/master/tests/lint/check_file_type.py#L110`

[GitHub] [incubator-tvm] lsy643 commented on a change in pull request #5955: Register Shape Func for Some Operators to Handle Dynamic Shapes

2020-07-13 Thread GitBox
lsy643 commented on a change in pull request #5955: URL: https://github.com/apache/incubator-tvm/pull/5955#discussion_r454077558 ## File path: python/tvm/relay/op/image/_image.py ## @@ -64,6 +67,22 @@ def compute_crop_and_resize(attrs, inputs, out_type): reg.register_injecti

[GitHub] [incubator-tvm] lsy643 commented on a change in pull request #5955: Register Shape Func for Some Operators to Handle Dynamic Shapes

2020-07-13 Thread GitBox
lsy643 commented on a change in pull request #5955: URL: https://github.com/apache/incubator-tvm/pull/5955#discussion_r454077558 ## File path: python/tvm/relay/op/image/_image.py ## @@ -64,6 +67,22 @@ def compute_crop_and_resize(attrs, inputs, out_type): reg.register_injecti

[GitHub] [incubator-tvm] tqchen commented on pull request #5753: Support module based interface runtime

2020-07-13 Thread GitBox
tqchen commented on pull request #5753: URL: https://github.com/apache/incubator-tvm/pull/5753#issuecomment-657945828 cc @zhiics please https://tvm.apache.org/docs/contribute/code_review.html#approve-and-request-changes-explicitly @jwfromm can you also take a look? ---

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5962: [Ansor][AutoTVM v2.0] Part 0: Ansor minimum system for auto schedule generating

2020-07-13 Thread GitBox
tqchen commented on a change in pull request #5962: URL: https://github.com/apache/incubator-tvm/pull/5962#discussion_r454077315 ## File path: src/auto_schedule/utils.cc ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contribut

[GitHub] [incubator-tvm] FrozenGene commented on a change in pull request #5753: Support module based interface runtime

2020-07-13 Thread GitBox
FrozenGene commented on a change in pull request #5753: URL: https://github.com/apache/incubator-tvm/pull/5753#discussion_r454076532 ## File path: src/runtime/module.cc ## @@ -66,9 +66,19 @@ PackedFunc ModuleNode::GetFunction(const std::string& name, bool query_imports) Pac

[GitHub] [incubator-tvm] tqchen commented on pull request #5235: [RELAY][Fix] i64 indices

2020-07-13 Thread GitBox
tqchen commented on pull request #5235: URL: https://github.com/apache/incubator-tvm/pull/5235#issuecomment-657944392 cc @mbrookhart @jroesch @junrushao1994 @ZihengJiang @antinucleon This is an automated message from the Apa

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5753: Support module based interface runtime

2020-07-13 Thread GitBox
tqchen commented on a change in pull request #5753: URL: https://github.com/apache/incubator-tvm/pull/5753#discussion_r454075454 ## File path: src/runtime/module.cc ## @@ -66,9 +66,19 @@ PackedFunc ModuleNode::GetFunction(const std::string& name, bool query_imports) PackedF

[GitHub] [incubator-tvm] tqchen commented on pull request #5052: [TARGET] ONNX codegen

2020-07-13 Thread GitBox
tqchen commented on pull request #5052: URL: https://github.com/apache/incubator-tvm/pull/5052#issuecomment-657942495 @srkreddy1238 please also update, @kazum feel free to make a call to dismiss outstanding reviews This is a

[GitHub] [incubator-tvm] tqchen merged pull request #5991: [IR] Fix a primitive check error

2020-07-13 Thread GitBox
tqchen merged pull request #5991: URL: https://github.com/apache/incubator-tvm/pull/5991 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [incubator-tvm] tqchen commented on pull request #5991: [IR] Fix a primitive check error

2020-07-13 Thread GitBox
tqchen commented on pull request #5991: URL: https://github.com/apache/incubator-tvm/pull/5991#issuecomment-657942237 Thanks @liangfu , @junrushao1994 @zhiics This is an automated message from the Apache Git Service. To resp

[incubator-tvm] branch master updated (67ed6d0 -> e4a0aa5)

2020-07-13 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 67ed6d0 Fix conv2_gemm after target structure update (#6037) add e4a0aa5 [IR] Fix a primitive check err

[GitHub] [incubator-tvm] tqchen merged pull request #6037: Fix conv2_gemm after target structure update

2020-07-13 Thread GitBox
tqchen merged pull request #6037: URL: https://github.com/apache/incubator-tvm/pull/6037 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [incubator-tvm] tqchen commented on pull request #6037: Fix conv2_gemm after target structure update

2020-07-13 Thread GitBox
tqchen commented on pull request #6037: URL: https://github.com/apache/incubator-tvm/pull/6037#issuecomment-657941954 Thanks @giuseros ! CC @junrushao1994 This is an automated message from the Apache Git Service. To respond

[incubator-tvm] branch master updated (99c52f3 -> 67ed6d0)

2020-07-13 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 99c52f3 [Frontend][TFLite] Fix fully_connected converter when batch size is not 1 (#6038) add 67ed6d0

[GitHub] [incubator-tvm] jxx123 commented on issue #6050: [BUG] Pytorch frontend error when the value of prim::Constant is a tensor in cuda

2020-07-13 Thread GitBox
jxx123 commented on issue #6050: URL: https://github.com/apache/incubator-tvm/issues/6050#issuecomment-657940204 PR link: https://github.com/apache/incubator-tvm/pull/6051 This is an automated message from the Apache Git Serv

[GitHub] [incubator-tvm] FrozenGene commented on a change in pull request #5753: Support module based interface runtime

2020-07-13 Thread GitBox
FrozenGene commented on a change in pull request #5753: URL: https://github.com/apache/incubator-tvm/pull/5753#discussion_r454071520 ## File path: python/tvm/relay/backend/graph_runtime_factory.py ## @@ -0,0 +1,113 @@ +# Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [incubator-tvm] jcf94 commented on a change in pull request #5962: [Ansor][AutoTVM v2.0] Part 0: Ansor minimum system for auto schedule generating

2020-07-13 Thread GitBox
jcf94 commented on a change in pull request #5962: URL: https://github.com/apache/incubator-tvm/pull/5962#discussion_r454071250 ## File path: src/auto_schedule/utils.cc ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributo

[GitHub] [incubator-tvm] liangfu commented on a change in pull request #6044: [RUNTIME][CRT] init TVMPackedFunc's name

2020-07-13 Thread GitBox
liangfu commented on a change in pull request #6044: URL: https://github.com/apache/incubator-tvm/pull/6044#discussion_r454063901 ## File path: src/runtime/crt/common/packed_func.c ## @@ -85,6 +86,7 @@ int TVMPackedFunc_InitGlobalFunc(TVMPackedFunc* pf, const char* name, const

[GitHub] [incubator-tvm] liangfu commented on a change in pull request #6044: [RUNTIME][CRT] init TVMPackedFunc's name

2020-07-13 Thread GitBox
liangfu commented on a change in pull request #6044: URL: https://github.com/apache/incubator-tvm/pull/6044#discussion_r454063901 ## File path: src/runtime/crt/common/packed_func.c ## @@ -85,6 +86,7 @@ int TVMPackedFunc_InitGlobalFunc(TVMPackedFunc* pf, const char* name, const

[GitHub] [incubator-tvm] FrozenGene commented on a change in pull request #5753: Support module based interface runtime

2020-07-13 Thread GitBox
FrozenGene commented on a change in pull request #5753: URL: https://github.com/apache/incubator-tvm/pull/5753#discussion_r454061696 ## File path: python/tvm/relay/backend/graph_runtime_factory.py ## @@ -0,0 +1,113 @@ +# Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [incubator-tvm] jcf94 commented on a change in pull request #5962: [Ansor][AutoTVM v2.0] Part 0: Ansor minimum system for auto schedule generating

2020-07-13 Thread GitBox
jcf94 commented on a change in pull request #5962: URL: https://github.com/apache/incubator-tvm/pull/5962#discussion_r454060475 ## File path: src/auto_schedule/utils.h ## @@ -184,22 +184,36 @@ inline void PrintTitle(const std::string& title, int verbose) { } /*! - * \brief

[GitHub] [incubator-tvm] FrozenGene commented on a change in pull request #5753: Support module based interface runtime

2020-07-13 Thread GitBox
FrozenGene commented on a change in pull request #5753: URL: https://github.com/apache/incubator-tvm/pull/5753#discussion_r454059023 ## File path: src/runtime/module.cc ## @@ -66,9 +66,19 @@ PackedFunc ModuleNode::GetFunction(const std::string& name, bool query_imports) Pac

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5962: [Ansor][AutoTVM v2.0] Part 0: Ansor minimum system for auto schedule generating

2020-07-13 Thread GitBox
tqchen commented on a change in pull request #5962: URL: https://github.com/apache/incubator-tvm/pull/5962#discussion_r454058968 ## File path: src/auto_schedule/utils.h ## @@ -184,22 +184,36 @@ inline void PrintTitle(const std::string& title, int verbose) { } /*! - * \brie

[GitHub] [incubator-tvm] FrozenGene commented on a change in pull request #5753: Support module based interface runtime

2020-07-13 Thread GitBox
FrozenGene commented on a change in pull request #5753: URL: https://github.com/apache/incubator-tvm/pull/5753#discussion_r454059023 ## File path: src/runtime/module.cc ## @@ -66,9 +66,19 @@ PackedFunc ModuleNode::GetFunction(const std::string& name, bool query_imports) Pac

[GitHub] [incubator-tvm] windclarion commented on a change in pull request #6044: [RUNTIME][CRT] init TVMPackedFunc's name

2020-07-13 Thread GitBox
windclarion commented on a change in pull request #6044: URL: https://github.com/apache/incubator-tvm/pull/6044#discussion_r454058824 ## File path: src/runtime/crt/common/packed_func.c ## @@ -85,6 +85,7 @@ int TVMPackedFunc_InitGlobalFunc(TVMPackedFunc* pf, const char* name, c

[GitHub] [incubator-tvm] jcf94 commented on pull request #5962: [Ansor][AutoTVM v2.0] Part 0: Ansor minimum system for auto schedule generating

2020-07-13 Thread GitBox
jcf94 commented on pull request #5962: URL: https://github.com/apache/incubator-tvm/pull/5962#issuecomment-657924465 > Does not have to change now, but let us change the use of ThreadPool to parallel_for abstraction. Does that means to just modify ThreadPool to ParallelFor now? Class

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5753: Support module based interface runtime

2020-07-13 Thread GitBox
tqchen commented on a change in pull request #5753: URL: https://github.com/apache/incubator-tvm/pull/5753#discussion_r454054106 ## File path: python/tvm/relay/backend/graph_runtime_factory.py ## @@ -0,0 +1,113 @@ +# Licensed to the Apache Software Foundation (ASF) under one +#

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #5915: [BYOC][Contrib] Arm Compute Library integration

2020-07-13 Thread GitBox
zhiics commented on a change in pull request #5915: URL: https://github.com/apache/incubator-tvm/pull/5915#discussion_r454043140 ## File path: src/relay/backend/contrib/arm_compute_lib/codegen_acl.h ## @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [incubator-tvm] tqchen commented on a change in pull request #5753: Support module based interface runtime

2020-07-13 Thread GitBox
tqchen commented on a change in pull request #5753: URL: https://github.com/apache/incubator-tvm/pull/5753#discussion_r454053862 ## File path: src/runtime/module.cc ## @@ -66,9 +66,19 @@ PackedFunc ModuleNode::GetFunction(const std::string& name, bool query_imports) PackedF

[GitHub] [incubator-tvm] liangfu commented on a change in pull request #6044: [RUNTIME][CRT] init TVMPackedFunc's name

2020-07-13 Thread GitBox
liangfu commented on a change in pull request #6044: URL: https://github.com/apache/incubator-tvm/pull/6044#discussion_r454051962 ## File path: src/runtime/crt/common/packed_func.c ## @@ -85,6 +85,7 @@ int TVMPackedFunc_InitGlobalFunc(TVMPackedFunc* pf, const char* name, const

[GitHub] [incubator-tvm] jxx123 opened a new pull request #6051: Fix pytorch frontend prim::Constant issue

2020-07-13 Thread GitBox
jxx123 opened a new pull request #6051: URL: https://github.com/apache/incubator-tvm/pull/6051 This PR is to fix the issue described here: https://github.com/apache/incubator-tvm/issues/6050 This is an automated message from

[GitHub] [incubator-tvm] liangfu commented on pull request #6049: [Pytorch] add operator copy_ support

2020-07-13 Thread GitBox
liangfu commented on pull request #6049: URL: https://github.com/apache/incubator-tvm/pull/6049#issuecomment-657919266 @masahi would you please take a look? This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-tvm] jxx123 opened a new issue #6050: [BUG] Pytorch frontend error when the value of prim::Constant is a tensor in cuda

2020-07-13 Thread GitBox
jxx123 opened a new issue #6050: URL: https://github.com/apache/incubator-tvm/issues/6050 Script to reproduce the issue: ```python import torch from tvm import relay class Foo(torch.nn.Module): def __init__(self, bar): super(Foo, self).__init__()

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #5753: Support module based interface runtime

2020-07-13 Thread GitBox
zhiics commented on a change in pull request #5753: URL: https://github.com/apache/incubator-tvm/pull/5753#discussion_r454046393 ## File path: src/runtime/graph/graph_runtime_factory.cc ## @@ -0,0 +1,175 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] [incubator-tvm] leonwanghui commented on pull request #5892: Add TVM application extension with WASM runtime

2020-07-13 Thread GitBox
leonwanghui commented on pull request #5892: URL: https://github.com/apache/incubator-tvm/pull/5892#issuecomment-657915075 @tqchen It seems that the `./cargo/config` file is not allowed to be included into the repo, the ci error is as follows: ```shell + docker/bash.sh tvmai/ci-lint:v

[GitHub] [incubator-tvm] FrozenGene commented on a change in pull request #5753: Support module based interface runtime

2020-07-13 Thread GitBox
FrozenGene commented on a change in pull request #5753: URL: https://github.com/apache/incubator-tvm/pull/5753#discussion_r454044403 ## File path: src/runtime/graph/graph_runtime_factory.cc ## @@ -0,0 +1,175 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #5914: [clflush] Enable x86 cpu cache flush

2020-07-13 Thread GitBox
comaniac commented on a change in pull request #5914: URL: https://github.com/apache/incubator-tvm/pull/5914#discussion_r454043821 ## File path: python/tvm/autotvm/measure/measure_methods.py ## @@ -473,8 +482,10 @@ def run_through_rpc(measure_input, build_result, remot

[GitHub] [incubator-tvm] FrozenGene commented on a change in pull request #5753: Support module based interface runtime

2020-07-13 Thread GitBox
FrozenGene commented on a change in pull request #5753: URL: https://github.com/apache/incubator-tvm/pull/5753#discussion_r454043676 ## File path: python/tvm/relay/backend/graph_runtime_factory.py ## @@ -0,0 +1,113 @@ +# Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #5915: [BYOC][Contrib] Arm Compute Library integration

2020-07-13 Thread GitBox
comaniac commented on a change in pull request #5915: URL: https://github.com/apache/incubator-tvm/pull/5915#discussion_r454026302 ## File path: src/relay/backend/contrib/arm_compute_lib/codegen.cc ## @@ -0,0 +1,188 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[GitHub] [incubator-tvm] FrozenGene commented on a change in pull request #5914: [clflush] Enable x86 cpu cache flush

2020-07-13 Thread GitBox
FrozenGene commented on a change in pull request #5914: URL: https://github.com/apache/incubator-tvm/pull/5914#discussion_r454039357 ## File path: python/tvm/autotvm/measure/measure_methods.py ## @@ -473,8 +482,10 @@ def run_through_rpc(measure_input, build_result, rem

[GitHub] [incubator-tvm] FrozenGene commented on pull request #6038: [Frontend][TFLite] Fix fully_connected converter when batch size is not 1

2020-07-13 Thread GitBox
FrozenGene commented on pull request #6038: URL: https://github.com/apache/incubator-tvm/pull/6038#issuecomment-657909009 @trevor-m @anijain2305 Thank you. This pr is merged now. This is an automated message from the Apache G

[GitHub] [incubator-tvm] FrozenGene merged pull request #6038: [Frontend][TFLite] Fix fully_connected converter when batch size is not 1

2020-07-13 Thread GitBox
FrozenGene merged pull request #6038: URL: https://github.com/apache/incubator-tvm/pull/6038 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[incubator-tvm] branch master updated (712c82f -> 99c52f3)

2020-07-13 Thread zhaowu
This is an automated email from the ASF dual-hosted git repository. zhaowu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 712c82f Add support for tflite arg_min and arg_max (#5992) add 99c52f3 [Frontend][TFLite] Fix fully_con

[GitHub] [incubator-tvm] leonwanghui commented on a change in pull request #5052: [TARGET] ONNX codegen

2020-07-13 Thread GitBox
leonwanghui commented on a change in pull request #5052: URL: https://github.com/apache/incubator-tvm/pull/5052#discussion_r454034918 ## File path: python/tvm/contrib/target/__init__.py ## @@ -14,5 +14,3 @@ # KIND, either express or implied. See the License for the # specifi

[GitHub] [incubator-tvm] lsy643 commented on pull request #6033: Create an Invert permutation Operator

2020-07-13 Thread GitBox
lsy643 commented on pull request #6033: URL: https://github.com/apache/incubator-tvm/pull/6033#issuecomment-657904946 @anijain2305 This is the link of [invert_permutation](https://www.tensorflow.org/api_docs/python/tf/math/invert_permutation) from Tensorflow -

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #5914: [clflush] Enable x86 cpu cache flush

2020-07-13 Thread GitBox
comaniac commented on a change in pull request #5914: URL: https://github.com/apache/incubator-tvm/pull/5914#discussion_r454034185 ## File path: python/tvm/autotvm/measure/measure_methods.py ## @@ -473,8 +482,10 @@ def run_through_rpc(measure_input, build_result, remot

[GitHub] [incubator-tvm] leonwanghui commented on pull request #5892: Add TVM application extension with WASM runtime

2020-07-13 Thread GitBox
leonwanghui commented on pull request #5892: URL: https://github.com/apache/incubator-tvm/pull/5892#issuecomment-657903409 cc @tqchen Please review it again, thanks! This is an automated message from the Apache Git Service. T

[GitHub] [incubator-tvm] huajsj opened a new pull request #6049: [Pytorch] add operator copy_ support

2020-07-13 Thread GitBox
huajsj opened a new pull request #6049: URL: https://github.com/apache/incubator-tvm/pull/6049 Issue: Using tvm compile a pytorch network, tvm failed due to copy_ operator not support. solution: add pytorch copy_ operator support to tvm. --

[GitHub] [incubator-tvm] FrozenGene commented on a change in pull request #5914: [clflush] Enable x86 cpu cache flush

2020-07-13 Thread GitBox
FrozenGene commented on a change in pull request #5914: URL: https://github.com/apache/incubator-tvm/pull/5914#discussion_r454024307 ## File path: tutorials/autotvm/tune_relay_x86.py ## @@ -122,8 +122,9 @@ def get_network(name, batch_size): 'measure_option': autotvm.meas

[GitHub] [incubator-tvm] FrozenGene commented on a change in pull request #5914: [clflush] Enable x86 cpu cache flush

2020-07-13 Thread GitBox
FrozenGene commented on a change in pull request #5914: URL: https://github.com/apache/incubator-tvm/pull/5914#discussion_r454024398 ## File path: python/tvm/runtime/module.py ## @@ -163,7 +163,7 @@ def save(self, file_name, fmt=""): """ _ffi_api.ModuleSaveToF

[GitHub] [incubator-tvm] FrozenGene commented on a change in pull request #5914: [clflush] Enable x86 cpu cache flush

2020-07-13 Thread GitBox
FrozenGene commented on a change in pull request #5914: URL: https://github.com/apache/incubator-tvm/pull/5914#discussion_r454023755 ## File path: python/tvm/autotvm/measure/measure_methods.py ## @@ -309,7 +313,8 @@ class LocalRunner(RPCRunner): Whether check correctne

[GitHub] [incubator-tvm] FrozenGene commented on a change in pull request #5914: [clflush] Enable x86 cpu cache flush

2020-07-13 Thread GitBox
FrozenGene commented on a change in pull request #5914: URL: https://github.com/apache/incubator-tvm/pull/5914#discussion_r454023177 ## File path: python/tvm/autotvm/measure/measure_methods.py ## @@ -473,8 +482,10 @@ def run_through_rpc(measure_input, build_result, rem

[GitHub] [incubator-tvm] anijain2305 edited a comment on pull request #6033: Create an Invert permutation Operator

2020-07-13 Thread GitBox
anijain2305 edited a comment on pull request #6033: URL: https://github.com/apache/incubator-tvm/pull/6033#issuecomment-657888723 Thanks for the contribution. Wondering if it is possible to add some context or links here? Th

[GitHub] [incubator-tvm] anijain2305 commented on pull request #6033: Create an Invert permutation Operator

2020-07-13 Thread GitBox
anijain2305 commented on pull request #6033: URL: https://github.com/apache/incubator-tvm/pull/6033#issuecomment-657888723 Wondering if it is possible to add some context or links here? This is an automated message from the A

[GitHub] [incubator-tvm] anijain2305 commented on a change in pull request #5980: Fixed point multiplication improvements for AArch64

2020-07-13 Thread GitBox
anijain2305 commented on a change in pull request #5980: URL: https://github.com/apache/incubator-tvm/pull/5980#discussion_r454000570 ## File path: include/tvm/tir/builtin.h ## @@ -92,6 +92,14 @@ TVM_DLL const Op& shift_right(); */ TVM_DLL const Op& large_uint_imm(); +/*!

[GitHub] [incubator-tvm] FrozenGene commented on pull request #6042: [TIR] Add an option to limit the maximum extent of explicitly unrolled loops

2020-07-13 Thread GitBox
FrozenGene commented on pull request #6042: URL: https://github.com/apache/incubator-tvm/pull/6042#issuecomment-657886398 I understand this pr ‘s purpose. I met 32 hangs for a bit long time on arm v7 cpu (Worse thing is single convolution op compile time is ok, but it is not well when to c

[GitHub] [incubator-tvm] jroesch commented on pull request #5962: [Ansor][AutoTVM v2.0] Part 0: Ansor minimum system for auto schedule generating

2020-07-13 Thread GitBox
jroesch commented on pull request #5962: URL: https://github.com/apache/incubator-tvm/pull/5962#issuecomment-657883231 @jcf94 and @merrymercy thanks for all the hard work! Can I request that we put another unresolved issue? In my opinion the written English parts i.e comments, explanations

[GitHub] [incubator-tvm] anijain2305 commented on a change in pull request #5980: Fixed point multiplication improvements for AArch64

2020-07-13 Thread GitBox
anijain2305 commented on a change in pull request #5980: URL: https://github.com/apache/incubator-tvm/pull/5980#discussion_r454011323 ## File path: topi/python/topi/arm_cpu/tensor_intrin.py ## @@ -451,3 +451,55 @@ def _instr(index): return te.decl_tensor_intrin( C

[GitHub] [incubator-tvm] anijain2305 commented on a change in pull request #5980: Fixed point multiplication improvements for AArch64

2020-07-13 Thread GitBox
anijain2305 commented on a change in pull request #5980: URL: https://github.com/apache/incubator-tvm/pull/5980#discussion_r454011323 ## File path: topi/python/topi/arm_cpu/tensor_intrin.py ## @@ -451,3 +451,55 @@ def _instr(index): return te.decl_tensor_intrin( C

[GitHub] [incubator-tvm] anijain2305 commented on a change in pull request #5980: Fixed point multiplication improvements for AArch64

2020-07-13 Thread GitBox
anijain2305 commented on a change in pull request #5980: URL: https://github.com/apache/incubator-tvm/pull/5980#discussion_r453998267 ## File path: include/tvm/relay/attrs/transform.h ## @@ -298,6 +298,17 @@ struct ClipAttrs : public tvm::AttrsNode { } }; +/*! \brief Attr

[GitHub] [incubator-tvm] anijain2305 commented on pull request #5992: Add support for tflite arg_min and arg_max

2020-07-13 Thread GitBox
anijain2305 commented on pull request #5992: URL: https://github.com/apache/incubator-tvm/pull/5992#issuecomment-657857651 Thanks @d-smirnov @siju-samuel @MarisaKirisame This is merged! This is an automated message from the A

[GitHub] [incubator-tvm] anijain2305 merged pull request #5992: Add support for tflite arg_min and arg_max

2020-07-13 Thread GitBox
anijain2305 merged pull request #5992: URL: https://github.com/apache/incubator-tvm/pull/5992 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[incubator-tvm] branch master updated: Add support for tflite arg_min and arg_max (#5992)

2020-07-13 Thread anijain2305
This is an automated email from the ASF dual-hosted git repository. anijain2305 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git The following commit(s) were added to refs/heads/master by this push: new 712c82f Add support for tflite arg_

[GitHub] [incubator-tvm] ymwangg opened a new pull request #6048: [AutoTVM][BugFix] Fix variable name conflict with OpenCL keyword

2020-07-13 Thread GitBox
ymwangg opened a new pull request #6048: URL: https://github.com/apache/incubator-tvm/pull/6048 Currently AutoTVM cannot tune the operator `conv2d_nchw_spatial_pack.mali` due to a variable name conflict with OpenCL, this PR fixes this. -

[incubator-tvm] branch master updated: [Relay] Add pass for getting calibration data from a relay module (#5997)

2020-07-13 Thread zhic
This is an automated email from the ASF dual-hosted git repository. zhic pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git The following commit(s) were added to refs/heads/master by this push: new 96fe315 [Relay] Add pass for getting calib

[GitHub] [incubator-tvm] zhiics merged pull request #5997: [Relay] Add pass for getting calibration data from a relay module

2020-07-13 Thread GitBox
zhiics merged pull request #5997: URL: https://github.com/apache/incubator-tvm/pull/5997 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [incubator-tvm] zhiics commented on pull request #5997: [Relay] Add pass for getting calibration data from a relay module

2020-07-13 Thread GitBox
zhiics commented on pull request #5997: URL: https://github.com/apache/incubator-tvm/pull/5997#issuecomment-657830023 Thanks @seanlatias @comaniac This is an automated message from the Apache Git Service. To respond to the m

  1   2   >