[GitHub] [incubator-tvm] merrymercy commented on a change in pull request #6310: [Ansor][AutoTVM v2.0] Phase 2: Evolutionary Search

2020-08-26 Thread GitBox
merrymercy commented on a change in pull request #6310: URL: https://github.com/apache/incubator-tvm/pull/6310#discussion_r478134161 ## File path: src/auto_scheduler/search_policy/sketch_policy_rules.cc ## @@ -908,7 +795,362 @@ InitPopulationRule::ResultKind

[GitHub] [incubator-tvm] merrymercy commented on a change in pull request #6310: [Ansor][AutoTVM v2.0] Phase 2: Evolutionary Search

2020-08-26 Thread GitBox
merrymercy commented on a change in pull request #6310: URL: https://github.com/apache/incubator-tvm/pull/6310#discussion_r478134161 ## File path: src/auto_scheduler/search_policy/sketch_policy_rules.cc ## @@ -908,7 +795,362 @@ InitPopulationRule::ResultKind

[GitHub] [incubator-tvm] merrymercy commented on pull request #6310: [Ansor][AutoTVM v2.0] Phase 2: Evolutionary Search

2020-08-26 Thread GitBox
merrymercy commented on pull request #6310: URL: https://github.com/apache/incubator-tvm/pull/6310#issuecomment-681532459 The test case looks good to me. The two remaining items: 1. Resolve my last comment (https://github.com/apache/incubator-tvm/pull/6310#discussion_r478134161) 2.

[GitHub] [incubator-tvm] merrymercy commented on a change in pull request #6310: [Ansor][AutoTVM v2.0] Phase 2: Evolutionary Search

2020-08-26 Thread GitBox
merrymercy commented on a change in pull request #6310: URL: https://github.com/apache/incubator-tvm/pull/6310#discussion_r478134161 ## File path: src/auto_scheduler/search_policy/sketch_policy_rules.cc ## @@ -908,7 +795,362 @@ InitPopulationRule::ResultKind

[GitHub] [incubator-tvm] ZihengJiang commented on pull request #6125: [VTA][OpenCL] add device_annot support in graphpack

2020-08-26 Thread GitBox
ZihengJiang commented on pull request #6125: URL: https://github.com/apache/incubator-tvm/pull/6125#issuecomment-681502427 I am wondering whether VTA's graph annotation can be unified into the relay's heterogeneous execution feature

[GitHub] [incubator-tvm] ZihengJiang edited a comment on pull request #6125: [VTA][OpenCL] add device_annot support in graphpack

2020-08-26 Thread GitBox
ZihengJiang edited a comment on pull request #6125: URL: https://github.com/apache/incubator-tvm/pull/6125#issuecomment-681502427 I am wondering whether VTA's graph annotation can be unified into the relay's heterogeneous execution feature:

[GitHub] [incubator-tvm] anilmartha commented on a change in pull request #6342: [CI][Contrib] Add Vitis-AI docker installation

2020-08-26 Thread GitBox
anilmartha commented on a change in pull request #6342: URL: https://github.com/apache/incubator-tvm/pull/6342#discussion_r478112852 ## File path: docker/Dockerfile.ci_cpu ## @@ -83,3 +83,7 @@ RUN bash /install/ubuntu_install_caffe.sh # Github Arm(R) Ethos(TM)-N NPU driver

[GitHub] [incubator-tvm] zhanghaohit commented on a change in pull request #6126: [VTA][OpenCL] intelfocl

2020-08-26 Thread GitBox
zhanghaohit commented on a change in pull request #6126: URL: https://github.com/apache/incubator-tvm/pull/6126#discussion_r478102076 ## File path: vta/runtime/runtime.cc ## @@ -329,7 +442,7 @@ class BaseQueue { // End location of current SRAM write in FIFO mode uint32_t

[incubator-tvm] branch master updated: [BYOC][ACL] Improved pooling support (#6248)

2020-08-26 Thread zhic
This is an automated email from the ASF dual-hosted git repository. zhic pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git The following commit(s) were added to refs/heads/master by this push: new c958bc1 [BYOC][ACL] Improved pooling

[GitHub] [incubator-tvm] zhiics commented on pull request #6248: [BYOC][ACL] Improved pooling support

2020-08-26 Thread GitBox
zhiics commented on pull request #6248: URL: https://github.com/apache/incubator-tvm/pull/6248#issuecomment-681340134 Thanks @lhutton1 @comaniac This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-tvm] zhiics merged pull request #6248: [BYOC][ACL] Improved pooling support

2020-08-26 Thread GitBox
zhiics merged pull request #6248: URL: https://github.com/apache/incubator-tvm/pull/6248 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-tvm] zhanghaohit commented on a change in pull request #6125: [VTA][OpenCL] add device_annot support in graphpack

2020-08-26 Thread GitBox
zhanghaohit commented on a change in pull request #6125: URL: https://github.com/apache/incubator-tvm/pull/6125#discussion_r478050263 ## File path: python/tvm/relay/op/_tensor.py ## @@ -87,6 +87,10 @@ register_broadcast_schedule("fast_exp")

[GitHub] [incubator-tvm] FrozenGene commented on pull request #6206: [Caffe Frontend] introduce caffe frontend for tvm

2020-08-26 Thread GitBox
FrozenGene commented on pull request #6206: URL: https://github.com/apache/incubator-tvm/pull/6206#issuecomment-681321757 Thanks @fernchen It is merged now. This is an automated message from the Apache Git Service. To

[GitHub] [incubator-tvm] FrozenGene merged pull request #6206: [Caffe Frontend] introduce caffe frontend for tvm

2020-08-26 Thread GitBox
FrozenGene merged pull request #6206: URL: https://github.com/apache/incubator-tvm/pull/6206 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[incubator-tvm] branch master updated: [Caffe Frontend] introduce caffe frontend for tvm (#6206)

2020-08-26 Thread zhaowu
This is an automated email from the ASF dual-hosted git repository. zhaowu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git The following commit(s) were added to refs/heads/master by this push: new 44d97ad [Caffe Frontend] introduce

[GitHub] [incubator-tvm] FrozenGene commented on pull request #6303: [Relay/TOPI][TFLite] Implemented MATRIX_SET_DIAG Operator for Relay/TOPI and TFLite Frontend.

2020-08-26 Thread GitBox
FrozenGene commented on pull request #6303: URL: https://github.com/apache/incubator-tvm/pull/6303#issuecomment-681320486 Thanks @jainris @siju-samuel @mbaret it is merged. For the alignment, wish @jainris could follow up, thanks!

[incubator-tvm] branch master updated: [Relay/TOPI][TFLite] Implemented MATRIX_SET_DIAG Operator for Relay/TOPI and TFLite Frontend. (#6303)

2020-08-26 Thread zhaowu
This is an automated email from the ASF dual-hosted git repository. zhaowu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git The following commit(s) were added to refs/heads/master by this push: new 082f27e [Relay/TOPI][TFLite]

[GitHub] [incubator-tvm] FrozenGene merged pull request #6303: [Relay/TOPI][TFLite] Implemented MATRIX_SET_DIAG Operator for Relay/TOPI and TFLite Frontend.

2020-08-26 Thread GitBox
FrozenGene merged pull request #6303: URL: https://github.com/apache/incubator-tvm/pull/6303 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-tvm] tqchen merged pull request #6346: [TESTS] add gpuonly tests for python unittests and integration

2020-08-26 Thread GitBox
tqchen merged pull request #6346: URL: https://github.com/apache/incubator-tvm/pull/6346 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[incubator-tvm] branch master updated (c6dd26b -> f6d3cee)

2020-08-26 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from c6dd26b Add `init` member to ReduceNode (#6138) add f6d3cee [TESTS] add gpuonly tests for python

[incubator-tvm] branch master updated: Add `init` member to ReduceNode (#6138)

2020-08-26 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git The following commit(s) were added to refs/heads/master by this push: new c6dd26b Add `init` member to ReduceNode

[GitHub] [incubator-tvm] tqchen commented on pull request #6138: Add `init` member to ReduceNode

2020-08-26 Thread GitBox
tqchen commented on pull request #6138: URL: https://github.com/apache/incubator-tvm/pull/6138#issuecomment-681300404 Thanks @quic-sanirudh ! this is now merged This is an automated message from the Apache Git Service. To

[GitHub] [incubator-tvm] tqchen merged pull request #6138: Add `init` member to ReduceNode

2020-08-26 Thread GitBox
tqchen merged pull request #6138: URL: https://github.com/apache/incubator-tvm/pull/6138 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[incubator-tvm] branch master updated (4910c8c -> 415c088)

2020-08-26 Thread masahi
This is an automated email from the ASF dual-hosted git repository. masahi pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 4910c8c [MSVC] Make able to compile with MSVC (#6341) add 415c088 ROCm changed name of library and

[GitHub] [incubator-tvm] masahi merged pull request #6345: ROCm changed name of library and removed the old one in ROCm 3.7 release.

2020-08-26 Thread GitBox
masahi merged pull request #6345: URL: https://github.com/apache/incubator-tvm/pull/6345 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-tvm] quic-sanirudh commented on pull request #6138: Add `init` member to ReduceNode

2020-08-26 Thread GitBox
quic-sanirudh commented on pull request #6138: URL: https://github.com/apache/incubator-tvm/pull/6138#issuecomment-681232652 I added the support for initializing with rfactor, but doesn't work with crossthread_allreduce. I also added a few unit and compiled tests.

[GitHub] [incubator-tvm] t-vi commented on pull request #6345: ROCm changed name of library and removed the old one in ROCm 3.7 release.

2020-08-26 Thread GitBox
t-vi commented on pull request #6345: URL: https://github.com/apache/incubator-tvm/pull/6345#issuecomment-681203248 Seems good to me. If we are giving up on pre-3.3 compat, I should also remove the code object v3 workaround I introduced in the spring in favour of 3.5+. (I'll send a PR.)

[GitHub] [incubator-tvm] hypercubestart commented on a change in pull request #5812: Bring Your Own Datatypes

2020-08-26 Thread GitBox
hypercubestart commented on a change in pull request #5812: URL: https://github.com/apache/incubator-tvm/pull/5812#discussion_r477713045 ## File path: 3rdparty/posit/posit-wrapper.cc ## @@ -0,0 +1,211 @@ +#include + +#include + +#include "universal/posit/posit.hpp" +// must

[GitHub] [incubator-tvm] hypercubestart commented on a change in pull request #5812: Bring Your Own Datatypes

2020-08-26 Thread GitBox
hypercubestart commented on a change in pull request #5812: URL: https://github.com/apache/incubator-tvm/pull/5812#discussion_r477713045 ## File path: 3rdparty/posit/posit-wrapper.cc ## @@ -0,0 +1,211 @@ +#include + +#include + +#include "universal/posit/posit.hpp" +// must

[GitHub] [incubator-tvm] tkonolige opened a new pull request #6346: [TESTS] add gpuonly tests for python unittests and integration

2020-08-26 Thread GitBox
tkonolige opened a new pull request #6346: URL: https://github.com/apache/incubator-tvm/pull/6346 In preparation for #6331 @tqchen This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-tvm] gussmith23 commented on a change in pull request #5812: Bring Your Own Datatypes

2020-08-26 Thread GitBox
gussmith23 commented on a change in pull request #5812: URL: https://github.com/apache/incubator-tvm/pull/5812#discussion_r477650626 ## File path: tests/python/unittest/test_custom_datatypes.py ## @@ -0,0 +1,396 @@ +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [incubator-tvm] gussmith23 commented on a change in pull request #5812: Bring Your Own Datatypes

2020-08-26 Thread GitBox
gussmith23 commented on a change in pull request #5812: URL: https://github.com/apache/incubator-tvm/pull/5812#discussion_r477648461 ## File path: python/tvm/target/datatype.py ## @@ -135,8 +166,40 @@ def lower(op): dtype = "uint" + str(t.bits) if

[GitHub] [incubator-tvm] gussmith23 commented on a change in pull request #5812: Bring Your Own Datatypes

2020-08-26 Thread GitBox
gussmith23 commented on a change in pull request #5812: URL: https://github.com/apache/incubator-tvm/pull/5812#discussion_r477647304 ## File path: python/tvm/relay/frontend/change_datatype.py ## @@ -0,0 +1,88 @@ +# Licensed to the Apache Software Foundation (ASF) under one +#

[GitHub] [incubator-tvm] gussmith23 commented on a change in pull request #5812: Bring Your Own Datatypes

2020-08-26 Thread GitBox
gussmith23 commented on a change in pull request #5812: URL: https://github.com/apache/incubator-tvm/pull/5812#discussion_r477643995 ## File path: 3rdparty/posit/posit-wrapper.cc ## @@ -0,0 +1,211 @@ +#include + +#include + +#include "universal/posit/posit.hpp" +// must go

[GitHub] [incubator-tvm] gussmith23 commented on a change in pull request #5812: Bring Your Own Datatypes

2020-08-26 Thread GitBox
gussmith23 commented on a change in pull request #5812: URL: https://github.com/apache/incubator-tvm/pull/5812#discussion_r477642914 ## File path: 3rdparty/posit/posit-wrapper.cc ## @@ -0,0 +1,211 @@ +#include + +#include + +#include "universal/posit/posit.hpp" +// must go

[GitHub] [incubator-tvm] gussmith23 commented on pull request #5812: Bring Your Own Datatypes

2020-08-26 Thread GitBox
gussmith23 commented on pull request #5812: URL: https://github.com/apache/incubator-tvm/pull/5812#issuecomment-681159395 Thanks all, will do! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-tvm] tkonolige commented on a change in pull request #6333: Add docker/lint.sh, for running dockerized lint scripts locally

2020-08-26 Thread GitBox
tkonolige commented on a change in pull request #6333: URL: https://github.com/apache/incubator-tvm/pull/6333#discussion_r477618082 ## File path: tests/lint/clang_format.sh ## @@ -0,0 +1,23 @@ +#!/bin/bash -e +# Licensed to the Apache Software Foundation (ASF) under one +# or

[GitHub] [incubator-tvm] tqchen commented on pull request #6331: [TESTS] Refactor tests to run on either the GPU or CPU

2020-08-26 Thread GitBox
tqchen commented on pull request #6331: URL: https://github.com/apache/incubator-tvm/pull/6331#issuecomment-681146053 @tkonolige because uses the old Jenkinsfile (before it get merged). Please try to send another PR to add `gpuonly_test` that redirects to the normal integration test

[GitHub] [incubator-tvm] mvermeulen commented on pull request #6345: ROCm changed name of library and removed the old one in ROCm 3.7 release.

2020-08-26 Thread GitBox
mvermeulen commented on pull request #6345: URL: https://github.com/apache/incubator-tvm/pull/6345#issuecomment-681141322 The new library name was introduced in ROCm 3.5. The old library name was deleted in ROCm 3.7. So this change makes ROCm 3.5 or later a requirement for mainline

[GitHub] [incubator-tvm] tkonolige commented on pull request #6331: [TESTS] Refactor tests to run on either the GPU or CPU

2020-08-26 Thread GitBox
tkonolige commented on pull request #6331: URL: https://github.com/apache/incubator-tvm/pull/6331#issuecomment-681138755 @tqchen I think I've addressed all issues. Do I need to do something to have Jenkins use the new Jenkinsfile?

[GitHub] [incubator-tvm] masahi commented on pull request #6345: ROCm changed name of library and removed the old one in ROCm 3.7 release.

2020-08-26 Thread GitBox
masahi commented on pull request #6345: URL: https://github.com/apache/incubator-tvm/pull/6345#issuecomment-681123947 Does this change make rocm 3.7 requirement for TVM? This is only for confirmation, I'm +1 for tracking the latest release. cc @t-vi

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #6342: [CI][Contrib] Add Vitis-AI docker installation

2020-08-26 Thread GitBox
comaniac commented on a change in pull request #6342: URL: https://github.com/apache/incubator-tvm/pull/6342#discussion_r477585350 ## File path: docker/Dockerfile.ci_cpu ## @@ -83,3 +83,7 @@ RUN bash /install/ubuntu_install_caffe.sh # Github Arm(R) Ethos(TM)-N NPU driver

[GitHub] [incubator-tvm] mvermeulen opened a new pull request #6345: ROCm changed name of library and removed the old one in ROCm 3.7 release.

2020-08-26 Thread GitBox
mvermeulen opened a new pull request #6345: URL: https://github.com/apache/incubator-tvm/pull/6345 Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #6337: [RELAY][VM] Enable heterogeneous execution for Relay VM

2020-08-26 Thread GitBox
zhiics commented on a change in pull request #6337: URL: https://github.com/apache/incubator-tvm/pull/6337#discussion_r477576510 ## File path: include/tvm/runtime/vm/bytecode.h ## @@ -204,6 +207,13 @@ struct Instruction { RegName tensor; RegName newshape; }

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #6337: [RELAY][VM] Enable heterogeneous execution for Relay VM

2020-08-26 Thread GitBox
zhiics commented on a change in pull request #6337: URL: https://github.com/apache/incubator-tvm/pull/6337#discussion_r477576510 ## File path: include/tvm/runtime/vm/bytecode.h ## @@ -204,6 +207,13 @@ struct Instruction { RegName tensor; RegName newshape; }

[GitHub] [incubator-tvm] jtuyls commented on a change in pull request #6342: [CI][Contrib] Add Vitis-AI docker installation

2020-08-26 Thread GitBox
jtuyls commented on a change in pull request #6342: URL: https://github.com/apache/incubator-tvm/pull/6342#discussion_r477572385 ## File path: docker/Dockerfile.ci_cpu ## @@ -83,3 +83,7 @@ RUN bash /install/ubuntu_install_caffe.sh # Github Arm(R) Ethos(TM)-N NPU driver COPY

[GitHub] [incubator-tvm] hogepodge commented on pull request #5812: Bring Your Own Datatypes

2020-08-26 Thread GitBox
hogepodge commented on pull request #5812: URL: https://github.com/apache/incubator-tvm/pull/5812#issuecomment-681074598 At a high level, the docs organization is described in this discussion thread. https://discuss.tvm.ai/t/rfc-tvm-documentation-refactor/7456 It sounds like

[GitHub] [incubator-tvm] comaniac commented on a change in pull request #6335: [BYOC][ETHOSN] Add support for quantized convolution

2020-08-26 Thread GitBox
comaniac commented on a change in pull request #6335: URL: https://github.com/apache/incubator-tvm/pull/6335#discussion_r477513822 ## File path: src/relay/backend/contrib/ethosn/codegen.cc ## @@ -50,6 +50,16 @@ bool IsEthosnOp(const Call& call, const std::string& op_name) {

[GitHub] [incubator-tvm] slyubomirsky commented on pull request #5812: Bring Your Own Datatypes

2020-08-26 Thread GitBox
slyubomirsky commented on pull request #5812: URL: https://github.com/apache/incubator-tvm/pull/5812#issuecomment-681066725 > @slyubomirsky I heard from Zach that you have been looking into how documentation is done in modern TVM. I need to document the datatypes framework, which is

[GitHub] [incubator-tvm] icemelon9 commented on a change in pull request #6337: [RELAY][VM] Enable heterogeneous execution for Relay VM

2020-08-26 Thread GitBox
icemelon9 commented on a change in pull request #6337: URL: https://github.com/apache/incubator-tvm/pull/6337#discussion_r477516283 ## File path: include/tvm/runtime/vm/bytecode.h ## @@ -204,6 +207,13 @@ struct Instruction { RegName tensor; RegName newshape;

[GitHub] [incubator-tvm] comaniac commented on pull request #6343: [BYOC][CONTRIB] Vitis-AI codegen integration

2020-08-26 Thread GitBox
comaniac commented on pull request #6343: URL: https://github.com/apache/incubator-tvm/pull/6343#issuecomment-681050745 cc @tmoreau89 @zhiics @masahi @tqchen @liangfu This is an automated message from the Apache Git

[GitHub] [incubator-tvm] areusch commented on a change in pull request #6319: Remove comparison of unsigned expression < 0 warning

2020-08-26 Thread GitBox
areusch commented on a change in pull request #6319: URL: https://github.com/apache/incubator-tvm/pull/6319#discussion_r477498454 ## File path: src/runtime/crt/common/ndarray.c ## @@ -76,7 +76,7 @@ int TVMNDArray_Load(TVMNDArray* ret, const char** strm) { *strm +=

[GitHub] [incubator-tvm] areusch opened a new pull request #6344: Improve interactive docker/bash.sh

2020-08-26 Thread GitBox
areusch opened a new pull request #6344: URL: https://github.com/apache/incubator-tvm/pull/6344 Some fixes to hopefully improve docker/bash.sh for use in local development: * properly quote command-line arguments * mount repo at $(pwd) by default; fixes problems when using

[GitHub] [incubator-tvm] areusch commented on pull request #6333: Add docker/lint.sh, for running dockerized lint scripts locally

2020-08-26 Thread GitBox
areusch commented on pull request #6333: URL: https://github.com/apache/incubator-tvm/pull/6333#issuecomment-681015505 I updated `pull_request.rst`, I don't know that the docker instructions mention linting at all This is

[GitHub] [incubator-tvm] areusch commented on a change in pull request #6333: Add docker/lint.sh, for running dockerized lint scripts locally

2020-08-26 Thread GitBox
areusch commented on a change in pull request #6333: URL: https://github.com/apache/incubator-tvm/pull/6333#discussion_r477463878 ## File path: tests/python/unittest/test_filter_untracked.py ## @@ -0,0 +1,178 @@ +# Licensed to the Apache Software Foundation (ASF) under one +#

[GitHub] [incubator-tvm] jroesch merged pull request #6341: [MSVC] Make able to compile with MSVC

2020-08-26 Thread GitBox
jroesch merged pull request #6341: URL: https://github.com/apache/incubator-tvm/pull/6341 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[incubator-tvm] branch master updated (942c90b -> 4910c8c)

2020-08-26 Thread jroesch
This is an automated email from the ASF dual-hosted git repository. jroesch pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 942c90b [DYN][RELAY] Resize support for NCHW-convertible layouts (#6293) add 4910c8c [MSVC] Make

[GitHub] [incubator-tvm] jroesch commented on pull request #5812: Bring Your Own Datatypes

2020-08-26 Thread GitBox
jroesch commented on pull request #5812: URL: https://github.com/apache/incubator-tvm/pull/5812#issuecomment-680991774 > @slyubomirsky I heard from Zach that you have been looking into how documentation is done in modern TVM. I need to document the datatypes framework, which is

[GitHub] [incubator-tvm] zhiics edited a comment on pull request #6337: [RELAY][VM] Enable heterogeneous execution for Relay VM

2020-08-26 Thread GitBox
zhiics edited a comment on pull request #6337: URL: https://github.com/apache/incubator-tvm/pull/6337#issuecomment-680989095 @mbrookhart Thanks for reminding, I just enabled all the dynamic op tests except for level6 because topk has a problem for GPU which I have already had a TODO in

[GitHub] [incubator-tvm] zhiics commented on pull request #6337: [RELAY][VM] Enable heterogeneous execution for Relay VM

2020-08-26 Thread GitBox
zhiics commented on pull request #6337: URL: https://github.com/apache/incubator-tvm/pull/6337#issuecomment-680989095 @mbrookhart Thanks for reminding, I just enabled all they dynamic op tests except for level6 because topk has a problem for GPU which I have already had a TODO in the

[GitHub] [incubator-tvm] zhiics commented on a change in pull request #6337: [RELAY][VM] Enable heterogeneous execution for Relay VM

2020-08-26 Thread GitBox
zhiics commented on a change in pull request #6337: URL: https://github.com/apache/incubator-tvm/pull/6337#discussion_r477431597 ## File path: python/tvm/relay/transform/memory_alloc.py ## @@ -19,26 +19,45 @@ A pass for manifesting explicit memory allocations. """ import

[GitHub] [incubator-tvm] zhiics commented on pull request #6342: [CI][Contrib] Add Vitis-AI docker installation

2020-08-26 Thread GitBox
zhiics commented on pull request #6342: URL: https://github.com/apache/incubator-tvm/pull/6342#issuecomment-680977561 cc @tqchen @tmoreau89 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-tvm] mbrookhart commented on pull request #6316: Dynamic Strided Slice

2020-08-26 Thread GitBox
mbrookhart commented on pull request #6316: URL: https://github.com/apache/incubator-tvm/pull/6316#issuecomment-680967384 @yongwww @electriclilies Can you take another look? This is an automated message from the Apache Git

[GitHub] [incubator-tvm] mbaret commented on pull request #6335: [BYOC][ETHOSN] Add support for quantized convolution

2020-08-26 Thread GitBox
mbaret commented on pull request #6335: URL: https://github.com/apache/incubator-tvm/pull/6335#issuecomment-680959658 cc @masahi @comaniac @zhiics @Leo-arm This is an automated message from the Apache Git Service. To

[GitHub] [incubator-tvm] mbrookhart commented on pull request #6337: [RELAY][VM] Enable heterogeneous execution for Relay VM

2020-08-26 Thread GitBox
mbrookhart commented on pull request #6337: URL: https://github.com/apache/incubator-tvm/pull/6337#issuecomment-680957809 Yay! I'm so excited for this! I'll do a deep dive today There are a number tests in tests/python/relay/dyn that skip running on GPU while waiting for this

[GitHub] [incubator-tvm] leandron commented on a change in pull request #6342: [CI][Contrib] Add Vitis-AI docker installation

2020-08-26 Thread GitBox
leandron commented on a change in pull request #6342: URL: https://github.com/apache/incubator-tvm/pull/6342#discussion_r477270729 ## File path: docker/install/ubuntu_install_vai_packages.sh ## @@ -0,0 +1,29 @@ +#!/bin/bash +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [incubator-tvm] MarisaKirisame commented on a change in pull request #6336: [Relay][Training] Make AutoDiff thread through global function.

2020-08-26 Thread GitBox
MarisaKirisame commented on a change in pull request #6336: URL: https://github.com/apache/incubator-tvm/pull/6336#discussion_r477230512 ## File path: src/relay/transforms/gradient.cc ## @@ -438,12 +449,17 @@ Expr BPEmpty() { struct ReverseAD : ExprMutator { using

[GitHub] [incubator-tvm] anilmartha opened a new pull request #6343: [BYOC][CONTRIB] Vitis-AI codegen integration

2020-08-26 Thread GitBox
anilmartha opened a new pull request #6343: URL: https://github.com/apache/incubator-tvm/pull/6343 This PR implements the Vitis-AI codegen using the BYOC flow and enables us to offload subgraphs to FPGA DPU accelerators (cloud/edge). Below are the features added as part of this PR

[GitHub] [incubator-tvm] anilmartha opened a new pull request #6342: [CI][Contrib] Add Vitis-AI docker installation

2020-08-26 Thread GitBox
anilmartha opened a new pull request #6342: URL: https://github.com/apache/incubator-tvm/pull/6342 This PR adds the Vitis-AI PyXIR dependency for testing Vitis-AI codegen to the ci_cpu dockerfile. This is an automated

[GitHub] [incubator-tvm] leandron commented on a change in pull request #6337: [RELAY][VM] Enable heterogeneous execution for Relay VM

2020-08-26 Thread GitBox
leandron commented on a change in pull request #6337: URL: https://github.com/apache/incubator-tvm/pull/6337#discussion_r477165445 ## File path: python/tvm/relay/transform/memory_alloc.py ## @@ -19,26 +19,45 @@ A pass for manifesting explicit memory allocations. """ import

[GitHub] [incubator-tvm] jainris commented on a change in pull request #6303: [Relay/TOPI][TFLite] Implemented MATRIX_SET_DIAG Operator for Relay/TOPI and TFLite Frontend.

2020-08-26 Thread GitBox
jainris commented on a change in pull request #6303: URL: https://github.com/apache/incubator-tvm/pull/6303#discussion_r477160005 ## File path: include/tvm/topi/transform.h ## @@ -1511,6 +1511,35 @@ inline Tensor sparse_to_dense(const Tensor& sparse_indices, const Array

[GitHub] [incubator-tvm] jainris commented on a change in pull request #6303: [Relay/TOPI][TFLite] Implemented MATRIX_SET_DIAG Operator for Relay/TOPI and TFLite Frontend.

2020-08-26 Thread GitBox
jainris commented on a change in pull request #6303: URL: https://github.com/apache/incubator-tvm/pull/6303#discussion_r477157597 ## File path: tests/python/frontend/tflite/test_forward.py ## @@ -2652,6 +2652,77 @@ def test_forward_reverse_v2(): _test_reverse_v2((5,

[GitHub] [incubator-tvm] kamaci commented on issue #6332: [VOTE] Apache TVM Graduation

2020-08-26 Thread GitBox
kamaci commented on issue #6332: URL: https://github.com/apache/incubator-tvm/issues/6332#issuecomment-680756086 Apart from being a great project, TVM has an active and growing community. It has a good understanding of the Apache Way [1] which is most important. I think that TVM is ready

[GitHub] [incubator-tvm] leandron commented on a change in pull request #6302: [tvmc] command line driver 'compile' (part 2/4)

2020-08-26 Thread GitBox
leandron commented on a change in pull request #6302: URL: https://github.com/apache/incubator-tvm/pull/6302#discussion_r477133826 ## File path: python/tvm/driver/tvmc/compiler.py ## @@ -0,0 +1,407 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [incubator-tvm] leandron commented on a change in pull request #6302: [tvmc] command line driver 'compile' (part 2/4)

2020-08-26 Thread GitBox
leandron commented on a change in pull request #6302: URL: https://github.com/apache/incubator-tvm/pull/6302#discussion_r477131644 ## File path: python/tvm/driver/tvmc/compiler.py ## @@ -0,0 +1,407 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [incubator-tvm] leonwanghui commented on a change in pull request #6339: Improve Rust bindings: Map, Array, String, various IR nodes

2020-08-26 Thread GitBox
leonwanghui commented on a change in pull request #6339: URL: https://github.com/apache/incubator-tvm/pull/6339#discussion_r477130406 ## File path: rust/tvm-rt/src/array.rs ## @@ -63,7 +66,7 @@ impl Array { array_data.count() ); -Ok(Array { +

[GitHub] [incubator-tvm] leandron commented on a change in pull request #6302: [tvmc] command line driver 'compile' (part 2/4)

2020-08-26 Thread GitBox
leandron commented on a change in pull request #6302: URL: https://github.com/apache/incubator-tvm/pull/6302#discussion_r477130487 ## File path: python/tvm/driver/tvmc/compiler.py ## @@ -0,0 +1,407 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [incubator-tvm] jroesch commented on a change in pull request #6336: [Relay][Training] Make AutoDiff thread through global function.

2020-08-26 Thread GitBox
jroesch commented on a change in pull request #6336: URL: https://github.com/apache/incubator-tvm/pull/6336#discussion_r477122547 ## File path: src/relay/transforms/gradient.cc ## @@ -438,12 +449,17 @@ Expr BPEmpty() { struct ReverseAD : ExprMutator { using ADVarMap =

[GitHub] [incubator-tvm] jroesch merged pull request #6293: [DYN][RELAY] Resize support for NCHW-convertible layouts

2020-08-26 Thread GitBox
jroesch merged pull request #6293: URL: https://github.com/apache/incubator-tvm/pull/6293 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[incubator-tvm] branch master updated (617949d -> 942c90b)

2020-08-26 Thread jroesch
This is an automated email from the ASF dual-hosted git repository. jroesch pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 617949d Use auto-tuner to improve conv2d_gemm performance (#6117) add 942c90b [DYN][RELAY] Resize

[GitHub] [incubator-tvm] jroesch commented on pull request #6339: Improve Rust bindings: Map, Array, String, various IR nodes

2020-08-26 Thread GitBox
jroesch commented on pull request #6339: URL: https://github.com/apache/incubator-tvm/pull/6339#issuecomment-680733737 cc @robo-corg This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-tvm] jroesch commented on a change in pull request #6274: [Diagnostics][Relay][InferType] Refactor InferType to work on whole module, and use new diagnostics.

2020-08-26 Thread GitBox
jroesch commented on a change in pull request #6274: URL: https://github.com/apache/incubator-tvm/pull/6274#discussion_r477119237 ## File path: src/ir/module.cc ## @@ -174,46 +174,28 @@ tvm::Array IRModuleNode::GetGlobalTypeVars() const { return

[GitHub] [incubator-tvm] minminsun commented on a change in pull request #6297: [Ansor][AutoTVM v2.0] Phase 2: Layout Rewrite in AutoScheduler

2020-08-26 Thread GitBox
minminsun commented on a change in pull request #6297: URL: https://github.com/apache/incubator-tvm/pull/6297#discussion_r477112491 ## File path: src/auto_scheduler/compute_dag.cc ## @@ -665,9 +666,349 @@ ComputeDAG::ComputeDAG(Array tensors) { data_ = std::move(node); }

[GitHub] [incubator-tvm] minminsun commented on a change in pull request #6297: [Ansor][AutoTVM v2.0] Phase 2: Layout Rewrite in AutoScheduler

2020-08-26 Thread GitBox
minminsun commented on a change in pull request #6297: URL: https://github.com/apache/incubator-tvm/pull/6297#discussion_r477112406 ## File path: src/auto_scheduler/compute_dag.cc ## @@ -665,9 +666,349 @@ ComputeDAG::ComputeDAG(Array tensors) { data_ = std::move(node); }

[GitHub] [incubator-tvm] minminsun commented on a change in pull request #6297: [Ansor][AutoTVM v2.0] Phase 2: Layout Rewrite in AutoScheduler

2020-08-26 Thread GitBox
minminsun commented on a change in pull request #6297: URL: https://github.com/apache/incubator-tvm/pull/6297#discussion_r477112240 ## File path: src/auto_scheduler/compute_dag.cc ## @@ -665,9 +666,349 @@ ComputeDAG::ComputeDAG(Array tensors) { data_ = std::move(node); }

[GitHub] [incubator-tvm] minminsun commented on a change in pull request #6297: [Ansor][AutoTVM v2.0] Phase 2: Layout Rewrite in AutoScheduler

2020-08-26 Thread GitBox
minminsun commented on a change in pull request #6297: URL: https://github.com/apache/incubator-tvm/pull/6297#discussion_r477111962 ## File path: src/auto_scheduler/compute_dag.cc ## @@ -40,6 +40,7 @@ #include #include "../arith/pattern_match.h" +#include

[GitHub] [incubator-tvm] minminsun commented on a change in pull request #6297: [Ansor][AutoTVM v2.0] Phase 2: Layout Rewrite in AutoScheduler

2020-08-26 Thread GitBox
minminsun commented on a change in pull request #6297: URL: https://github.com/apache/incubator-tvm/pull/6297#discussion_r477107266 ## File path: python/tvm/auto_scheduler/measure.py ## @@ -419,7 +419,7 @@ def timed_func(): try: sch, args =

[GitHub] [incubator-tvm] minminsun commented on a change in pull request #6297: [Ansor][AutoTVM v2.0] Phase 2: Layout Rewrite in AutoScheduler

2020-08-26 Thread GitBox
minminsun commented on a change in pull request #6297: URL: https://github.com/apache/incubator-tvm/pull/6297#discussion_r477105200 ## File path: python/tvm/auto_scheduler/compute_dag.py ## @@ -72,7 +72,7 @@ def get_init_state(self): """ return

[GitHub] [incubator-tvm] fernchen commented on pull request #6206: [Caffe Frontend] introduce caffe frontend for tvm

2020-08-26 Thread GitBox
fernchen commented on pull request #6206: URL: https://github.com/apache/incubator-tvm/pull/6206#issuecomment-680717983 > > ```python > > from tvm.relay.frontend import caffe_pb2 as pb > > ``` > > where is from `tvm.relay.frontend import caffe_pb2 as pb`, i don't see it in

[GitHub] [incubator-tvm] fernchen commented on a change in pull request #6206: [Caffe Frontend] introduce caffe frontend for tvm

2020-08-26 Thread GitBox
fernchen commented on a change in pull request #6206: URL: https://github.com/apache/incubator-tvm/pull/6206#discussion_r477085792 ## File path: tests/python/frontend/caffe/test_forward.py ## @@ -0,0 +1,1003 @@ +# Licensed to the Apache Software Foundation (ASF) under one +#

[GitHub] [incubator-tvm] yukatayu commented on a change in pull request #6341: [Easy fix] Make able to compile with msvc, clang

2020-08-26 Thread GitBox
yukatayu commented on a change in pull request #6341: URL: https://github.com/apache/incubator-tvm/pull/6341#discussion_r477079101 ## File path: src/target/llvm/codegen_hexagon.cc ## @@ -636,7 +636,10 @@ bool UsesExportABI(const PrimFunc& f) { return false; }

[GitHub] [incubator-tvm] fernchen commented on a change in pull request #6206: [Caffe Frontend] introduce caffe frontend for tvm

2020-08-26 Thread GitBox
fernchen commented on a change in pull request #6206: URL: https://github.com/apache/incubator-tvm/pull/6206#discussion_r477078398 ## File path: tests/python/frontend/caffe/test_forward.py ## @@ -0,0 +1,1003 @@ +# Licensed to the Apache Software Foundation (ASF) under one +#

[GitHub] [incubator-tvm] FrozenGene commented on pull request #6117: Use auto-tuner to improve conv2d_gemm performance

2020-08-26 Thread GitBox
FrozenGene commented on pull request #6117: URL: https://github.com/apache/incubator-tvm/pull/6117#issuecomment-680688614 Thanks @giuseros @anijain2305 It is merged now. This is an automated message from the Apache Git

[GitHub] [incubator-tvm] FrozenGene merged pull request #6117: Use auto-tuner to improve conv2d_gemm performance

2020-08-26 Thread GitBox
FrozenGene merged pull request #6117: URL: https://github.com/apache/incubator-tvm/pull/6117 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[incubator-tvm] branch master updated (883a28d -> 617949d)

2020-08-26 Thread zhaowu
This is an automated email from the ASF dual-hosted git repository. zhaowu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-tvm.git. from 883a28d save (#6338) add 617949d Use auto-tuner to improve conv2d_gemm performance (#6117) No new

[GitHub] [incubator-tvm] FrozenGene commented on a change in pull request #6117: Use auto-tuner to improve conv2d_gemm performance

2020-08-26 Thread GitBox
FrozenGene commented on a change in pull request #6117: URL: https://github.com/apache/incubator-tvm/pull/6117#discussion_r477065824 ## File path: python/tvm/topi/arm_cpu/tensor_intrin.py ## @@ -21,7 +21,186 @@ from tvm import te from tvm.contrib import util, clang -def

[GitHub] [incubator-tvm] MarisaKirisame commented on a change in pull request #6336: [Relay][Training] Make AutoDiff thread through global function.

2020-08-26 Thread GitBox
MarisaKirisame commented on a change in pull request #6336: URL: https://github.com/apache/incubator-tvm/pull/6336#discussion_r477064941 ## File path: src/relay/transforms/gradient.cc ## @@ -438,12 +449,17 @@ Expr BPEmpty() { struct ReverseAD : ExprMutator { using

[GitHub] [incubator-tvm] MarisaKirisame commented on a change in pull request #6336: [Relay][Training] Make AutoDiff thread through global function.

2020-08-26 Thread GitBox
MarisaKirisame commented on a change in pull request #6336: URL: https://github.com/apache/incubator-tvm/pull/6336#discussion_r477065065 ## File path: src/relay/transforms/gradient.cc ## @@ -518,22 +533,29 @@ struct ReverseAD : ExprMutator { orig_var->checked_type_ =

[GitHub] [incubator-tvm] FrozenGene commented on a change in pull request #6117: Use auto-tuner to improve conv2d_gemm performance

2020-08-26 Thread GitBox
FrozenGene commented on a change in pull request #6117: URL: https://github.com/apache/incubator-tvm/pull/6117#discussion_r477064579 ## File path: python/tvm/topi/arm_cpu/tensor_intrin.py ## @@ -21,7 +21,186 @@ from tvm import te from tvm.contrib import util, clang -def

[GitHub] [incubator-tvm] FrozenGene commented on a change in pull request #6137: Better grouped convolution for CPU targets

2020-08-26 Thread GitBox
FrozenGene commented on a change in pull request #6137: URL: https://github.com/apache/incubator-tvm/pull/6137#discussion_r477060409 ## File path: topi/python/topi/arm_cpu/group_conv2d.py ## @@ -0,0 +1,310 @@ +import tvm +from tvm import autotvm +from tvm import te +from

  1   2   >