[GitHub] [tvm] zxybazh commented on pull request #9132: [Meta Schedule][M3a] SearchStrategy

2021-09-27 Thread GitBox
zxybazh commented on pull request #9132: URL: https://github.com/apache/tvm/pull/9132#issuecomment-928873427 Fixed docs and added some interesting figure. Ready for another round of review. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [tvm] spectrometerHBH edited a comment on pull request #9041: [TensorIR][M2a] Decompose-Reduction

2021-09-27 Thread GitBox
spectrometerHBH edited a comment on pull request #9041: URL: https://github.com/apache/tvm/pull/9041#issuecomment-928829921 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [tvm] spectrometerHBH commented on pull request #9041: [TensorIR][M2a] Decompose-Reduction

2021-09-27 Thread GitBox
spectrometerHBH commented on pull request #9041: URL: https://github.com/apache/tvm/pull/9041#issuecomment-928829921 > @spectrometerHBH Sorry for the delay! I think I finally did a complete with the code review. Let me know if it makes sense to you Thanks!I might be slow to response

[GitHub] [tvm] junrushao1994 commented on pull request #9041: [TensorIR][M2a] Decompose-Reduction

2021-09-27 Thread GitBox
junrushao1994 commented on pull request #9041: URL: https://github.com/apache/tvm/pull/9041#issuecomment-928828584 @spectrometerHBH Sorry for the delay! I think I finally did a complete with the code review. Let me know if it makes sense to you -- This is an automated message from the

[GitHub] [tvm] junrushao1994 commented on a change in pull request #9041: [TensorIR][M2a] Decompose-Reduction

2021-09-27 Thread GitBox
junrushao1994 commented on a change in pull request #9041: URL: https://github.com/apache/tvm/pull/9041#discussion_r717228066 ## File path: src/tir/schedule/primitive/reduction.cc ## @@ -21,6 +21,283 @@ namespace tvm { namespace tir { +/*! + * \brief A helper class to

[GitHub] [tvm] junrushao1994 commented on a change in pull request #9041: [TensorIR][M2a] Decompose-Reduction

2021-09-27 Thread GitBox
junrushao1994 commented on a change in pull request #9041: URL: https://github.com/apache/tvm/pull/9041#discussion_r717227641 ## File path: src/tir/schedule/primitive/reduction.cc ## @@ -21,6 +21,283 @@ namespace tvm { namespace tir { +/*! + * \brief A helper class to

[GitHub] [tvm] masahi commented on issue #6689: [TEST][FLAKY] frontend/pytorch/test_forward.py::test_forward_nms

2021-09-27 Thread GitBox
masahi commented on issue #6689: URL: https://github.com/apache/tvm/issues/6689#issuecomment-928822958 I was able to reproduce the error after 30 runs, it is fixed in https://github.com/apache/tvm/pull/9140 -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [tvm] masahi opened a new pull request #9140: [TEST] Fix flaky NMS test by making sure scores are unique

2021-09-27 Thread GitBox
masahi opened a new pull request #9140: URL: https://github.com/apache/tvm/pull/9140 Closes https://github.com/apache/tvm/issues/6689 The cause of flaky ness was the tie in scores. The solution is simply to make sure scores are unique, following the same approach in

[GitHub] [tvm] junrushao1994 commented on a change in pull request #9041: [TensorIR][M2a] Decompose-Reduction

2021-09-27 Thread GitBox
junrushao1994 commented on a change in pull request #9041: URL: https://github.com/apache/tvm/pull/9041#discussion_r717225041 ## File path: src/tir/schedule/primitive/reduction.cc ## @@ -21,6 +21,283 @@ namespace tvm { namespace tir { +/*! + * \brief A helper class to

[GitHub] [tvm] junrushao1994 commented on a change in pull request #9041: [TensorIR][M2a] Decompose-Reduction

2021-09-27 Thread GitBox
junrushao1994 commented on a change in pull request #9041: URL: https://github.com/apache/tvm/pull/9041#discussion_r717224898 ## File path: src/tir/schedule/primitive/reduction.cc ## @@ -21,6 +21,283 @@ namespace tvm { namespace tir { +/*! + * \brief A helper class to

[GitHub] [tvm] junrushao1994 commented on a change in pull request #9041: [TensorIR][M2a] Decompose-Reduction

2021-09-27 Thread GitBox
junrushao1994 commented on a change in pull request #9041: URL: https://github.com/apache/tvm/pull/9041#discussion_r717223253 ## File path: src/tir/schedule/primitive/reduction.cc ## @@ -21,6 +21,283 @@ namespace tvm { namespace tir { +/*! + * \brief A helper class to

[GitHub] [tvm] abraham-arun opened a new pull request #9139: [Relay][ConvertLayout] Support for qnn.conv2d_transpose

2021-09-27 Thread GitBox
abraham-arun opened a new pull request #9139: URL: https://github.com/apache/tvm/pull/9139 Added the registration and test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [tvm] wrongtest commented on a change in pull request #9121: [TIR] add loop partition hint pragma

2021-09-27 Thread GitBox
wrongtest commented on a change in pull request #9121: URL: https://github.com/apache/tvm/pull/9121#discussion_r717195678 ## File path: include/tvm/tir/stmt.h ## @@ -1339,6 +1339,12 @@ constexpr const char* hand_threaded = "hand_threaded"; * if (mask & 2) the write

[GitHub] [tvm] masahi commented on issue #7139: [TEST][FLAKY] test_topi_math.py:test_ewise

2021-09-27 Thread GitBox
masahi commented on issue #7139: URL: https://github.com/apache/tvm/issues/7139#issuecomment-928707715 I haven't seen this failure in CI jobs after this one. We can reopen when it appears again. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [tvm] masahi closed issue #7139: [TEST][FLAKY] test_topi_math.py:test_ewise

2021-09-27 Thread GitBox
masahi closed issue #7139: URL: https://github.com/apache/tvm/issues/7139 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tvm] masahi commented on issue #7470: [TEST][FLAKY] tests/python/relay/test_op_level5.py::test_crop_and_resize

2021-09-27 Thread GitBox
masahi commented on issue #7470: URL: https://github.com/apache/tvm/issues/7470#issuecomment-928706536 This is not reproducible on my end and I haven't seen it in CI jobs. I think we can close this. @K1504296 Feel free to reopen if the error persists on aarch64. -- This is an

[GitHub] [tvm] masahi closed issue #7470: [TEST][FLAKY] tests/python/relay/test_op_level5.py::test_crop_and_resize

2021-09-27 Thread GitBox
masahi closed issue #7470: URL: https://github.com/apache/tvm/issues/7470 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tvm] jiangjiajun edited a comment on pull request #9126: [Frontend][PaddlePaddle][Part1] Add 100+ operators for PaddlePaddle

2021-09-27 Thread GitBox
jiangjiajun edited a comment on pull request #9126: URL: https://github.com/apache/tvm/pull/9126#issuecomment-928658093 Hi, @AndrewZhaoLuo @mbrookhart Thanks for reviewing this PR. 1. PaddlePaddle now provides [English

[GitHub] [tvm] jiangjiajun commented on a change in pull request #9126: [Frontend][PaddlePaddle][Part1] Add 100+ operators for PaddlePaddle

2021-09-27 Thread GitBox
jiangjiajun commented on a change in pull request #9126: URL: https://github.com/apache/tvm/pull/9126#discussion_r717180731 ## File path: python/tvm/relay/frontend/paddlepaddle.py ## @@ -40,28 +41,108 @@ __all__ = ["from_paddle"] +def _get_pad_size(in_size,

[GitHub] [tvm] jiangjiajun commented on pull request #9126: [Frontend][PaddlePaddle][Part1] Add 100+ operators for PaddlePaddle

2021-09-27 Thread GitBox
jiangjiajun commented on pull request #9126: URL: https://github.com/apache/tvm/pull/9126#issuecomment-928658093 Hi, @AndrewZhaoLuo @mbrookhart Thanks for reviewing this PR. 1. PaddlePaddle now provides [English

[GitHub] [tvm] junrushao1994 commented on a change in pull request #9041: [TensorIR][M2a] Decompose-Reduction

2021-09-27 Thread GitBox
junrushao1994 commented on a change in pull request #9041: URL: https://github.com/apache/tvm/pull/9041#discussion_r717173337 ## File path: src/tir/schedule/primitive/reduction.cc ## @@ -21,6 +21,283 @@ namespace tvm { namespace tir { +/*! + * \brief A helper class to

[GitHub] [tvm-rfcs] Hzfengsy commented on pull request #36: [RFC][TVMScript] New namespace for tvmscript

2021-09-27 Thread GitBox
Hzfengsy commented on pull request #36: URL: https://github.com/apache/tvm-rfcs/pull/36#issuecomment-928637897 Thanks, @altanh. Your suggestion makes sense to me. To be specific, here are two cases: parse from a python script and string. 1. When we parse from a python script, we detect

[GitHub] [tvm] tqchen commented on pull request #9128: [CI] Split Integration tests out of first phase of pipeline

2021-09-27 Thread GitBox
tqchen commented on pull request #9128: URL: https://github.com/apache/tvm/pull/9128#issuecomment-928541306 i agree we can do that, the main thing is to be able to test on staging before merge -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [tvm] Hzfengsy commented on a change in pull request #9121: [TIR] add loop partition hint pragma

2021-09-27 Thread GitBox
Hzfengsy commented on a change in pull request #9121: URL: https://github.com/apache/tvm/pull/9121#discussion_r717139926 ## File path: tests/python/unittest/test_tir_transform_loop_partition.py ## @@ -538,6 +538,27 @@ def test_simple_rfactor(): assert not

[tvm] branch main updated (49c99ed -> 9df2ae8)

2021-09-27 Thread tqchen
This is an automated email from the ASF dual-hosted git repository. tqchen pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from 49c99ed [CI] bash.sh, build.sh: add option to set the container name and hostname (#9110) add 9df2ae8 [Codegen]

[GitHub] [tvm] tqchen merged pull request #9117: [Codegen] Swap out analyzer when outlining

2021-09-27 Thread GitBox
tqchen merged pull request #9117: URL: https://github.com/apache/tvm/pull/9117 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tvm] zxybazh commented on a change in pull request #9132: [Meta Schedule][M3a] SearchStrategy

2021-09-27 Thread GitBox
zxybazh commented on a change in pull request #9132: URL: https://github.com/apache/tvm/pull/9132#discussion_r717132306 ## File path: include/tvm/meta_schedule/search_strategy.h ## @@ -0,0 +1,199 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [tvm] junrushao1994 commented on pull request #9132: [Meta Schedule][M3a] SearchStrategy

2021-09-27 Thread GitBox
junrushao1994 commented on pull request #9132: URL: https://github.com/apache/tvm/pull/9132#issuecomment-928496025 Yeah I agree with @tkonolige that we need a high-level description of how the SearchStrategy object is expected to work, like, when each method is called and what are the

[GitHub] [tvm] junrushao1994 commented on a change in pull request #9132: [Meta Schedule][M3a] SearchStrategy

2021-09-27 Thread GitBox
junrushao1994 commented on a change in pull request #9132: URL: https://github.com/apache/tvm/pull/9132#discussion_r717131521 ## File path: include/tvm/meta_schedule/search_strategy.h ## @@ -0,0 +1,199 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] [tvm] junrushao1994 commented on a change in pull request #9132: [Meta Schedule][M3a] SearchStrategy

2021-09-27 Thread GitBox
junrushao1994 commented on a change in pull request #9132: URL: https://github.com/apache/tvm/pull/9132#discussion_r717131213 ## File path: include/tvm/meta_schedule/search_strategy.h ## @@ -0,0 +1,199 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] [tvm] zxybazh commented on a change in pull request #9132: [Meta Schedule][M3a] SearchStrategy

2021-09-27 Thread GitBox
zxybazh commented on a change in pull request #9132: URL: https://github.com/apache/tvm/pull/9132#discussion_r717123883 ## File path: include/tvm/meta_schedule/runner.h ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [tvm] zxybazh commented on a change in pull request #9132: [Meta Schedule][M3a] SearchStrategy

2021-09-27 Thread GitBox
zxybazh commented on a change in pull request #9132: URL: https://github.com/apache/tvm/pull/9132#discussion_r717119625 ## File path: include/tvm/meta_schedule/search_strategy.h ## @@ -0,0 +1,199 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [tvm] zxybazh commented on a change in pull request #9132: [Meta Schedule][M3a] SearchStrategy

2021-09-27 Thread GitBox
zxybazh commented on a change in pull request #9132: URL: https://github.com/apache/tvm/pull/9132#discussion_r717119535 ## File path: include/tvm/meta_schedule/search_strategy.h ## @@ -0,0 +1,199 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [tvm] zxybazh commented on a change in pull request #9132: [Meta Schedule][M3a] SearchStrategy

2021-09-27 Thread GitBox
zxybazh commented on a change in pull request #9132: URL: https://github.com/apache/tvm/pull/9132#discussion_r717119330 ## File path: include/tvm/meta_schedule/search_strategy.h ## @@ -0,0 +1,199 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [tvm] zxybazh commented on a change in pull request #9132: [Meta Schedule][M3a] SearchStrategy

2021-09-27 Thread GitBox
zxybazh commented on a change in pull request #9132: URL: https://github.com/apache/tvm/pull/9132#discussion_r717119187 ## File path: include/tvm/meta_schedule/runner.h ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [tvm] zxybazh commented on a change in pull request #9132: [Meta Schedule][M3a] SearchStrategy

2021-09-27 Thread GitBox
zxybazh commented on a change in pull request #9132: URL: https://github.com/apache/tvm/pull/9132#discussion_r717118740 ## File path: include/tvm/meta_schedule/runner.h ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [tvm] zxybazh commented on a change in pull request #9132: [Meta Schedule][M3a] SearchStrategy

2021-09-27 Thread GitBox
zxybazh commented on a change in pull request #9132: URL: https://github.com/apache/tvm/pull/9132#discussion_r717118740 ## File path: include/tvm/meta_schedule/runner.h ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [tvm] zxybazh commented on a change in pull request #9132: [Meta Schedule][M3a] SearchStrategy

2021-09-27 Thread GitBox
zxybazh commented on a change in pull request #9132: URL: https://github.com/apache/tvm/pull/9132#discussion_r717117830 ## File path: include/tvm/meta_schedule/search_strategy.h ## @@ -0,0 +1,199 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [tvm] zxybazh commented on a change in pull request #9132: [Meta Schedule][M3a] SearchStrategy

2021-09-27 Thread GitBox
zxybazh commented on a change in pull request #9132: URL: https://github.com/apache/tvm/pull/9132#discussion_r717117645 ## File path: src/meta_schedule/utils.h ## @@ -21,13 +21,91 @@ #include #include +#include +#include #include #include +#include +#include +

[GitHub] [tvm] zxybazh commented on a change in pull request #9132: [Meta Schedule][M3a] SearchStrategy

2021-09-27 Thread GitBox
zxybazh commented on a change in pull request #9132: URL: https://github.com/apache/tvm/pull/9132#discussion_r717117490 ## File path: src/meta_schedule/search_strategy/replay_trace.cc ## @@ -0,0 +1,149 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] [tvm] zxybazh commented on a change in pull request #9132: [Meta Schedule][M3a] SearchStrategy

2021-09-27 Thread GitBox
zxybazh commented on a change in pull request #9132: URL: https://github.com/apache/tvm/pull/9132#discussion_r717117379 ## File path: src/meta_schedule/search_strategy/replay_trace.cc ## @@ -0,0 +1,149 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] [tvm] tkonolige commented on a change in pull request #9132: [Meta Schedule][M3a] SearchStrategy

2021-09-27 Thread GitBox
tkonolige commented on a change in pull request #9132: URL: https://github.com/apache/tvm/pull/9132#discussion_r717093945 ## File path: src/meta_schedule/utils.h ## @@ -21,13 +21,91 @@ #include #include +#include +#include #include #include +#include +#include

[GitHub] [tvm] mbs-octoml commented on a change in pull request #9038: [Relay] Merge analysis/context_analysis.cc and transforms/device_annotation.cc

2021-09-27 Thread GitBox
mbs-octoml commented on a change in pull request #9038: URL: https://github.com/apache/tvm/pull/9038#discussion_r717102835 ## File path: tests/python/relay/test_pass_plan_devices.py ## @@ -0,0 +1,1405 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [tvm] mbs-octoml commented on a change in pull request #9038: [Relay] Merge analysis/context_analysis.cc and transforms/device_annotation.cc

2021-09-27 Thread GitBox
mbs-octoml commented on a change in pull request #9038: URL: https://github.com/apache/tvm/pull/9038#discussion_r717102651 ## File path: src/relay/transforms/device_planner.cc ## @@ -0,0 +1,1986 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [tvm] mbs-octoml commented on a change in pull request #9038: [Relay] Merge analysis/context_analysis.cc and transforms/device_annotation.cc

2021-09-27 Thread GitBox
mbs-octoml commented on a change in pull request #9038: URL: https://github.com/apache/tvm/pull/9038#discussion_r717101958 ## File path: src/relay/transforms/device_planner.cc ## @@ -0,0 +1,1986 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [tvm] mbs-octoml commented on a change in pull request #9038: [Relay] Merge analysis/context_analysis.cc and transforms/device_annotation.cc

2021-09-27 Thread GitBox
mbs-octoml commented on a change in pull request #9038: URL: https://github.com/apache/tvm/pull/9038#discussion_r717100785 ## File path: src/relay/transforms/device_planner.cc ## @@ -0,0 +1,1986 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [tvm] mbs-octoml commented on a change in pull request #9038: [Relay] Merge analysis/context_analysis.cc and transforms/device_annotation.cc

2021-09-27 Thread GitBox
mbs-octoml commented on a change in pull request #9038: URL: https://github.com/apache/tvm/pull/9038#discussion_r717099534 ## File path: src/relay/transforms/device_planner.cc ## @@ -0,0 +1,1986 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [tvm] mbs-octoml commented on a change in pull request #9038: [Relay] Merge analysis/context_analysis.cc and transforms/device_annotation.cc

2021-09-27 Thread GitBox
mbs-octoml commented on a change in pull request #9038: URL: https://github.com/apache/tvm/pull/9038#discussion_r717099318 ## File path: src/relay/transforms/device_planner.cc ## @@ -0,0 +1,1986 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [tvm] mbs-octoml commented on a change in pull request #9038: [Relay] Merge analysis/context_analysis.cc and transforms/device_annotation.cc

2021-09-27 Thread GitBox
mbs-octoml commented on a change in pull request #9038: URL: https://github.com/apache/tvm/pull/9038#discussion_r717097996 ## File path: src/relay/transforms/device_planner.cc ## @@ -0,0 +1,1986 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [tvm] mbs-octoml commented on a change in pull request #9038: [Relay] Merge analysis/context_analysis.cc and transforms/device_annotation.cc

2021-09-27 Thread GitBox
mbs-octoml commented on a change in pull request #9038: URL: https://github.com/apache/tvm/pull/9038#discussion_r717096310 ## File path: src/relay/transforms/device_planner.cc ## @@ -0,0 +1,1986 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [tvm] SWu commented on issue #9109: Incorrect implementation of cross_entropy_with_logits

2021-09-27 Thread GitBox
SWu commented on issue #9109: URL: https://github.com/apache/tvm/issues/9109#issuecomment-928387900 FWIW, it appears that the current `cross_entropy_with_logits` is actually what pytorch calls `NLLLoss` (negative log-likelihood loss), so a workaround to actually get

[GitHub] [tvm] mbs-octoml commented on a change in pull request #9038: [Relay] Merge analysis/context_analysis.cc and transforms/device_annotation.cc

2021-09-27 Thread GitBox
mbs-octoml commented on a change in pull request #9038: URL: https://github.com/apache/tvm/pull/9038#discussion_r717095106 ## File path: src/relay/transforms/device_planner.cc ## @@ -0,0 +1,1986 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [tvm] mbs-octoml commented on a change in pull request #9038: [Relay] Merge analysis/context_analysis.cc and transforms/device_annotation.cc

2021-09-27 Thread GitBox
mbs-octoml commented on a change in pull request #9038: URL: https://github.com/apache/tvm/pull/9038#discussion_r717094674 ## File path: src/relay/op/memory/device_copy.cc ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [tvm] mbs-octoml commented on a change in pull request #9038: [Relay] Merge analysis/context_analysis.cc and transforms/device_annotation.cc

2021-09-27 Thread GitBox
mbs-octoml commented on a change in pull request #9038: URL: https://github.com/apache/tvm/pull/9038#discussion_r717093968 ## File path: src/relay/op/annotation/annotation.h ## @@ -0,0 +1,116 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [tvm] mbs-octoml commented on a change in pull request #9038: [Relay] Merge analysis/context_analysis.cc and transforms/device_annotation.cc

2021-09-27 Thread GitBox
mbs-octoml commented on a change in pull request #9038: URL: https://github.com/apache/tvm/pull/9038#discussion_r717093154 ## File path: src/relay/op/annotation/annotation.cc ## @@ -56,12 +83,98 @@ RELAY_REGISTER_OP("on_device") .set_attr("TOpPattern", kOpaque)

[GitHub] [tvm] mbs-octoml commented on a change in pull request #9038: [Relay] Merge analysis/context_analysis.cc and transforms/device_annotation.cc

2021-09-27 Thread GitBox
mbs-octoml commented on a change in pull request #9038: URL: https://github.com/apache/tvm/pull/9038#discussion_r717083640 ## File path: src/relay/op/annotation/annotation.cc ## @@ -128,24 +128,31 @@ OnDeviceProps GetOnDeviceProps(const Expr& expr) { return {}; }

[GitHub] [tvm] mbs-octoml commented on a change in pull request #9038: [Relay] Merge analysis/context_analysis.cc and transforms/device_annotation.cc

2021-09-27 Thread GitBox
mbs-octoml commented on a change in pull request #9038: URL: https://github.com/apache/tvm/pull/9038#discussion_r717080417 ## File path: src/parser/parser.cc ## @@ -1088,7 +1088,7 @@ class Parser { VLOG(0) << "Parser::ParseFunctionDef"; return WithSpan([&]() {

[GitHub] [tvm] mbs-octoml commented on a change in pull request #9038: [Relay] Merge analysis/context_analysis.cc and transforms/device_annotation.cc

2021-09-27 Thread GitBox
mbs-octoml commented on a change in pull request #9038: URL: https://github.com/apache/tvm/pull/9038#discussion_r717073955 ## File path: src/relay/op/annotation/annotation.cc ## @@ -36,15 +38,40 @@ namespace tvm { namespace relay { -// relay.annotation.on_device

[GitHub] [tvm] mbs-octoml commented on a change in pull request #9130: [Relay] Prepare for new plan_devices.cc (part II)

2021-09-27 Thread GitBox
mbs-octoml commented on a change in pull request #9130: URL: https://github.com/apache/tvm/pull/9130#discussion_r717073519 ## File path: python/tvm/parser/__init__.py ## @@ -26,8 +26,10 @@ def add(self, name, content): return _ffi.get_global_func("SourceMapAdd")(self,

[GitHub] [tvm] mbs-octoml commented on a change in pull request #9038: [Relay] Merge analysis/context_analysis.cc and transforms/device_annotation.cc

2021-09-27 Thread GitBox
mbs-octoml commented on a change in pull request #9038: URL: https://github.com/apache/tvm/pull/9038#discussion_r717072043 ## File path: python/tvm/relay/op/annotation/annotation.py ## @@ -33,21 +43,26 @@ def on_device(data, device): device : Union[:py:class:`Device`,

[GitHub] [tvm] mbs-octoml commented on a change in pull request #9038: [Relay] Merge analysis/context_analysis.cc and transforms/device_annotation.cc

2021-09-27 Thread GitBox
mbs-octoml commented on a change in pull request #9038: URL: https://github.com/apache/tvm/pull/9038#discussion_r717071790 ## File path: include/tvm/relay/attrs/annotation.h ## @@ -32,14 +32,55 @@ namespace tvm { namespace relay { /*! - * \brief Options for the device

[GitHub] [tvm] jroesch commented on a change in pull request #9130: [Relay] Prepare for new plan_devices.cc (part II)

2021-09-27 Thread GitBox
jroesch commented on a change in pull request #9130: URL: https://github.com/apache/tvm/pull/9130#discussion_r717066921 ## File path: python/tvm/parser/__init__.py ## @@ -26,8 +26,10 @@ def add(self, name, content): return _ffi.get_global_func("SourceMapAdd")(self,

[GitHub] [tvm-rfcs] gromero commented on a change in pull request #33: [RFC][Project API] Extend metadata in ProjectOption

2021-09-27 Thread GitBox
gromero commented on a change in pull request #33: URL: https://github.com/apache/tvm-rfcs/pull/33#discussion_r717062734 ## File path: rfcs/0020-project_api_extend_metadata.md ## @@ -0,0 +1,252 @@ +- Feature Name: extend_metadata_in_projectoption +- Start Date: 2021-09-09 +-

[GitHub] [tvm] denise-k commented on issue #7183: [TEST][FLAKY] test_arith_solve_linear_inequality.py fails due to non-deterministic test

2021-09-27 Thread GitBox
denise-k commented on issue #7183: URL: https://github.com/apache/tvm/issues/7183#issuecomment-928281760 Hi, is this still active? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [tvm] denise-k commented on issue #7470: [TEST][FLAKY] tests/python/relay/test_op_level5.py::test_crop_and_resize

2021-09-27 Thread GitBox
denise-k commented on issue #7470: URL: https://github.com/apache/tvm/issues/7470#issuecomment-928281435 Hi folks, is this still active? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tvm] denise-k commented on issue #7139: [TEST][FLAKY] test_topi_math.py:test_ewise

2021-09-27 Thread GitBox
denise-k commented on issue #7139: URL: https://github.com/apache/tvm/issues/7139#issuecomment-928280971 Hi, is this still active? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [tvm] denise-k commented on issue #6689: [TEST][FLAKY] frontend/pytorch/test_forward.py::test_forward_nms

2021-09-27 Thread GitBox
denise-k commented on issue #6689: URL: https://github.com/apache/tvm/issues/6689#issuecomment-928280608 Hi folks, is this still active? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tvm] denise-k edited a comment on issue #6417: [FLAKY] relay/test_op_level1.py::test_binary_op failing intermittently

2021-09-27 Thread GitBox
denise-k edited a comment on issue #6417: URL: https://github.com/apache/tvm/issues/6417#issuecomment-928280238 Hi folks, is this still active? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [tvm] denise-k commented on issue #6417: [FLAKY] relay/test_op_level1.py::test_binary_op failing intermittently

2021-09-27 Thread GitBox
denise-k commented on issue #6417: URL: https://github.com/apache/tvm/issues/6417#issuecomment-928280238 Hi folks, Is this still active? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [tvm] junrushao1994 commented on a change in pull request #9041: [TensorIR][M2a] Decompose-Reduction

2021-09-27 Thread GitBox
junrushao1994 commented on a change in pull request #9041: URL: https://github.com/apache/tvm/pull/9041#discussion_r717024869 ## File path: src/tir/schedule/primitive/reduction.cc ## @@ -21,6 +21,283 @@ namespace tvm { namespace tir { +/*! + * \brief A helper class to

[GitHub] [tvm] junrushao1994 commented on a change in pull request #9041: [TensorIR][M2a] Decompose-Reduction

2021-09-27 Thread GitBox
junrushao1994 commented on a change in pull request #9041: URL: https://github.com/apache/tvm/pull/9041#discussion_r717022936 ## File path: src/tir/schedule/primitive/reduction.cc ## @@ -21,6 +21,283 @@ namespace tvm { namespace tir { +/*! + * \brief A helper class to

[GitHub] [tvm] junrushao1994 commented on a change in pull request #9041: [TensorIR][M2a] Decompose-Reduction

2021-09-27 Thread GitBox
junrushao1994 commented on a change in pull request #9041: URL: https://github.com/apache/tvm/pull/9041#discussion_r717022936 ## File path: src/tir/schedule/primitive/reduction.cc ## @@ -21,6 +21,283 @@ namespace tvm { namespace tir { +/*! + * \brief A helper class to

[GitHub] [tvm] junrushao1994 commented on a change in pull request #9041: [TensorIR][M2a] Decompose-Reduction

2021-09-27 Thread GitBox
junrushao1994 commented on a change in pull request #9041: URL: https://github.com/apache/tvm/pull/9041#discussion_r717022306 ## File path: src/tir/schedule/primitive/reduction.cc ## @@ -21,6 +21,283 @@ namespace tvm { namespace tir { +/*! + * \brief A helper class to

[GitHub] [tvm] junrushao1994 commented on pull request #9121: [TIR] add loop partition hint pragma

2021-09-27 Thread GitBox
junrushao1994 commented on pull request #9121: URL: https://github.com/apache/tvm/pull/9121#issuecomment-928244294 CC @areusch @Hzfengsy @vinx13 @zxybazh @ZihengJiang would you guys review this PR? looks like it's relevant to some of our previous discussion -- This is an automated

[GitHub] [tvm-rfcs] areusch commented on pull request #10: Additional Target Hooks RFC

2021-09-27 Thread GitBox
areusch commented on pull request #10: URL: https://github.com/apache/tvm-rfcs/pull/10#issuecomment-928239768 thanks for working through this with us @Mousius ! excited to see this land in TVM! -- This is an automated message from the Apache Git Service. To respond to the message,

[tvm-rfcs] branch main updated: Additional Target Hooks RFC (#10)

2021-09-27 Thread areusch
This is an automated email from the ASF dual-hosted git repository. areusch pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tvm-rfcs.git The following commit(s) were added to refs/heads/main by this push: new a6f9a25 Additional Target Hooks RFC (#10)

[GitHub] [tvm-rfcs] areusch merged pull request #10: Additional Target Hooks RFC

2021-09-27 Thread GitBox
areusch merged pull request #10: URL: https://github.com/apache/tvm-rfcs/pull/10 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tvm] mbs-octoml commented on a change in pull request #9130: [Relay] Prepare for new plan_devices.cc (part II)

2021-09-27 Thread GitBox
mbs-octoml commented on a change in pull request #9130: URL: https://github.com/apache/tvm/pull/9130#discussion_r717014746 ## File path: python/tvm/parser/__init__.py ## @@ -26,8 +26,10 @@ def add(self, name, content): return _ffi.get_global_func("SourceMapAdd")(self,

[GitHub] [tvm] mbs-octoml commented on a change in pull request #9130: [Relay] Prepare for new plan_devices.cc (part II)

2021-09-27 Thread GitBox
mbs-octoml commented on a change in pull request #9130: URL: https://github.com/apache/tvm/pull/9130#discussion_r717011728 ## File path: include/tvm/relay/attrs/function.h ## @@ -1,66 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one - * or more

[GitHub] [tvm] areusch commented on pull request #9129: [CI] Pass failFast flag to Jenkins parallel

2021-09-27 Thread GitBox
areusch commented on pull request #9129: URL: https://github.com/apache/tvm/pull/9129#issuecomment-928234757 people have actually sometimes asked for the opposite here--"if i submit something to Jenkins, i want it to run through everything so i don't just get the first error." perhaps we

[GitHub] [tvm] areusch commented on pull request #9128: [CI] Split Integration tests out of first phase of pipeline

2021-09-27 Thread GitBox
areusch commented on pull request #9128: URL: https://github.com/apache/tvm/pull/9128#issuecomment-928234011 @tqchen can you comment on why we have integration tests in the first part? IIRC it was originally due to scarcity of GPU nodes but now perhaps we don't need to worry so much.

[GitHub] [tvm] areusch commented on a change in pull request #9031: [CI] Prevent the complete Jenkins pipeline to run when files commited only to `/docs`

2021-09-27 Thread GitBox
areusch commented on a change in pull request #9031: URL: https://github.com/apache/tvm/pull/9031#discussion_r717009636 ## File path: Jenkinsfile ## @@ -148,11 +149,15 @@ stage('Prepare') { } } -stage("Sanity Check") { +stage('Sanity Check') { timeout(time: max_time,

[GitHub] [tvm] mbs-octoml commented on a change in pull request #9130: [Relay] Prepare for new plan_devices.cc (part II)

2021-09-27 Thread GitBox
mbs-octoml commented on a change in pull request #9130: URL: https://github.com/apache/tvm/pull/9130#discussion_r717007789 ## File path: src/parser/parser.cc ## @@ -1886,43 +1890,58 @@ Parser InitParser(const std::string& file_name, const std::string& file_content, auto

[GitHub] [tvm] areusch commented on pull request #9110: [CI] bash.sh, build.sh: add option to set the container name and hostname

2021-09-27 Thread GitBox
areusch commented on pull request #9110: URL: https://github.com/apache/tvm/pull/9110#issuecomment-928229096 thanks @idoudali the PR is now merged! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[tvm] branch main updated (507400e -> 49c99ed)

2021-09-27 Thread areusch
This is an automated email from the ASF dual-hosted git repository. areusch pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from 507400e Ensure google-mock is installed and setup (#9107) add 49c99ed [CI] bash.sh, build.sh: add option to set

[GitHub] [tvm] areusch merged pull request #9110: [CI] bash.sh, build.sh: add option to set the container name and hostname

2021-09-27 Thread GitBox
areusch merged pull request #9110: URL: https://github.com/apache/tvm/pull/9110 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tvm] junrushao1994 commented on a change in pull request #9041: [TensorIR][M2a] Decompose-Reduction

2021-09-27 Thread GitBox
junrushao1994 commented on a change in pull request #9041: URL: https://github.com/apache/tvm/pull/9041#discussion_r717006103 ## File path: src/tir/schedule/primitive/reduction.cc ## @@ -21,6 +21,283 @@ namespace tvm { namespace tir { +/*! + * \brief A helper class to

[GitHub] [tvm] junrushao1994 commented on a change in pull request #9041: [TensorIR][M2a] Decompose-Reduction

2021-09-27 Thread GitBox
junrushao1994 commented on a change in pull request #9041: URL: https://github.com/apache/tvm/pull/9041#discussion_r717004462 ## File path: src/tir/schedule/primitive/reduction.cc ## @@ -21,6 +21,283 @@ namespace tvm { namespace tir { +/*! + * \brief A helper class to

[GitHub] [tvm] kparzysz-quic opened a new pull request #9138: [LLVM] Make changes needed for opaque pointers

2021-09-27 Thread GitBox
kparzysz-quic opened a new pull request #9138: URL: https://github.com/apache/tvm/pull/9138 - Pass value type to all `Create.*Load` and `Create.*GEP` functions. - Create type `TypedPointer` to keep both the address and the pointee's type when buffer pointers etc. are created. -

[tvm] branch main updated (2c6fb65 -> 507400e)

2021-09-27 Thread areusch
This is an automated email from the ASF dual-hosted git repository. areusch pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from 2c6fb65 Arm(R) Ethos(TM)-U NPU TIR to CS for Conv2D (#8811) add 507400e Ensure google-mock is installed and setup

[GitHub] [tvm] areusch commented on pull request #9107: Ensure google-mock is installed and setup

2021-09-27 Thread GitBox
areusch commented on pull request #9107: URL: https://github.com/apache/tvm/pull/9107#issuecomment-928220608 @Mousius can you open a GH issue to update the containers pls? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [tvm] areusch merged pull request #9107: Ensure google-mock is installed and setup

2021-09-27 Thread GitBox
areusch merged pull request #9107: URL: https://github.com/apache/tvm/pull/9107 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tvm-rfcs] areusch commented on a change in pull request #30: Command Line Configuration Files

2021-09-27 Thread GitBox
areusch commented on a change in pull request #30: URL: https://github.com/apache/tvm-rfcs/pull/30#discussion_r716989670 ## File path: rfcs/0030-tvmc-comand-line-configuration-files.md ## @@ -0,0 +1,165 @@ +- Feature Name: Command Line Configuration Files +- Start Date:

[GitHub] [tvm] mbs-octoml commented on a change in pull request #9130: [Relay] Prepare for new plan_devices.cc (part II)

2021-09-27 Thread GitBox
mbs-octoml commented on a change in pull request #9130: URL: https://github.com/apache/tvm/pull/9130#discussion_r716994770 ## File path: src/relay/op/annotation/annotation.cc ## @@ -92,6 +91,7 @@ RELAY_REGISTER_OP("on_device") .add_argument("data", "Tensor", "The input

[GitHub] [tvm] mbs-octoml commented on a change in pull request #9130: [Relay] Prepare for new plan_devices.cc (part II)

2021-09-27 Thread GitBox
mbs-octoml commented on a change in pull request #9130: URL: https://github.com/apache/tvm/pull/9130#discussion_r716993659 ## File path: python/tvm/parser/__init__.py ## @@ -26,8 +26,10 @@ def add(self, name, content): return _ffi.get_global_func("SourceMapAdd")(self,

[GitHub] [tvm] areusch commented on a change in pull request #8990: [microTVM] Update support for ARMv7m intrinsic

2021-09-27 Thread GitBox
areusch commented on a change in pull request #8990: URL: https://github.com/apache/tvm/pull/8990#discussion_r716987495 ## File path: apps/microtvm/reference-vm/zephyr/base-box/base_box_test.sh ## @@ -37,3 +37,5 @@ if [ $board == "stm32f746g_disco" ] || [ $board ==

[tvm] branch main updated (d0c6ca5 -> 2c6fb65)

2021-09-27 Thread jroesch
This is an automated email from the ASF dual-hosted git repository. jroesch pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tvm.git. from d0c6ca5 Frontend: add onnx GlobalLpPool op (#8845) add 2c6fb65 Arm(R) Ethos(TM)-U NPU TIR to CS for Conv2D

[GitHub] [tvm] jroesch merged pull request #8811: [4/6] Arm(R) Ethos(TM)-U NPU TIR to CS for Conv2D

2021-09-27 Thread GitBox
jroesch merged pull request #8811: URL: https://github.com/apache/tvm/pull/8811 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [tvm] Lunderberg commented on a change in pull request #9091: [TIR] tir.transform.StorageFlatten refactor

2021-09-27 Thread GitBox
Lunderberg commented on a change in pull request #9091: URL: https://github.com/apache/tvm/pull/9091#discussion_r716978069 ## File path: src/tir/transforms/storage_flatten.cc ## @@ -50,6 +50,933 @@ using runtime::StorageRank; using runtime::StorageScope; using

[GitHub] [tvm] Lunderberg commented on a change in pull request #9091: [TIR] tir.transform.StorageFlatten refactor

2021-09-27 Thread GitBox
Lunderberg commented on a change in pull request #9091: URL: https://github.com/apache/tvm/pull/9091#discussion_r716977857 ## File path: src/tir/transforms/storage_flatten.cc ## @@ -50,6 +50,933 @@ using runtime::StorageRank; using runtime::StorageScope; using

  1   2   >