[GitHub] [incubator-tvm] u99127 commented on issue #4280: [TVM][RUNTIME] A minimum example to generate external library wrappers for DSOModule

2019-11-22 Thread GitBox
u99127 commented on issue #4280: [TVM][RUNTIME] A minimum example to generate external library wrappers for DSOModule URL: https://github.com/apache/incubator-tvm/pull/4280#issuecomment-557635801 LGTM - I don't see an actual "Approve" button if clicking that's expected from a workflow

[GitHub] [incubator-tvm] u99127 commented on issue #4280: [TVM][RUNTIME] A minimum example to generate external library wrappers for DSOModule

2019-11-22 Thread GitBox
u99127 commented on issue #4280: [TVM][RUNTIME] A minimum example to generate external library wrappers for DSOModule URL: https://github.com/apache/incubator-tvm/pull/4280#issuecomment-557607347 > > > @u99127 please

[GitHub] [incubator-tvm] u99127 commented on issue #4280: [TVM][RUNTIME] A minimum example to generate external library wrappers for DSOModule

2019-11-22 Thread GitBox
u99127 commented on issue #4280: [TVM][RUNTIME] A minimum example to generate external library wrappers for DSOModule URL: https://github.com/apache/incubator-tvm/pull/4280#issuecomment-557454651 There are still a couple of changes requested in the review that need to be addressed. It

[GitHub] [incubator-tvm] u99127 commented on issue #4280: [TVM][RUNTIME] A minimum example to generate external library wrappers for DSOModule

2019-11-21 Thread GitBox
u99127 commented on issue #4280: [TVM][RUNTIME] A minimum example to generate external library wrappers for DSOModule URL: https://github.com/apache/incubator-tvm/pull/4280#issuecomment-557271412 > @u99127 Thanks for your comment. Thanks @zhiics and @tqchen.

[GitHub] [incubator-tvm] u99127 commented on issue #4280: [TVM][RUNTIME] A minimum example to generate external library wrappers for DSOModule

2019-11-21 Thread GitBox
u99127 commented on issue #4280: [TVM][RUNTIME] A minimum example to generate external library wrappers for DSOModule URL: https://github.com/apache/incubator-tvm/pull/4280#issuecomment-557221217 > The directory convention should be something we document in the documents. Currently a

[GitHub] [incubator-tvm] u99127 commented on issue #4280: [TVM][RUNTIME] A minimum example to generate external library wrappers for DSOModule

2019-11-21 Thread GitBox
u99127 commented on issue #4280: [TVM][RUNTIME] A minimum example to generate external library wrappers for DSOModule URL: https://github.com/apache/incubator-tvm/pull/4280#issuecomment-557047170 > Comments about json runtime. I would consider move the json runtime to >