tmoreau89 commented on pull request #9:
URL: https://github.com/apache/incubator-tvm-vta/pull/9#issuecomment-695346293
Hi @zhanghaohit, please let me know if you can address the following changes
so we can get this PR merged!
(1) Adding a README file (ideally with instructions on how to
tmoreau89 commented on pull request #9:
URL: https://github.com/apache/incubator-tvm-vta/pull/9#issuecomment-687523850
Thanks again @remotego for addressing the comments. If we could address:
(1) Adding a README file (ideally with instructions on how to compile / run
on the FPGA) before
tmoreau89 commented on pull request #9:
URL: https://github.com/apache/incubator-tvm-vta/pull/9#issuecomment-680545019
I've made other minor request, but overall the PR is shaping up well. We can
stick to `intelfocl` as a target name. For documentation's stake, can you add a
README file
tmoreau89 commented on pull request #9:
URL: https://github.com/apache/incubator-tvm-vta/pull/9#issuecomment-663779312
@pasqoc I do 100% agree with you about needing better documentation about
what boards are supported, and how the designs get generated (HLS, Chisel,
OpenCL etc.), and a
tmoreau89 commented on pull request #9:
URL: https://github.com/apache/incubator-tvm-vta/pull/9#issuecomment-663776880
thanks @remotego @liangfu @pasqoc for the insightful comments. I think that
all opinions expressed are very valid!
So far our approach to naming VTA target has been
tmoreau89 commented on pull request #9:
URL: https://github.com/apache/incubator-tvm-vta/pull/9#issuecomment-660364642
Thanks for the changes. Please apply the 0.0.2 and rename the vta target to
something more specific, e.g. "arria10". Also there are some CI errors related
to linting that
tmoreau89 commented on pull request #9:
URL: https://github.com/apache/incubator-tvm-vta/pull/9#issuecomment-648436019
That is correct, we'll need to bump the versioning of the bitstream
This is an automated message from the
tmoreau89 commented on pull request #9:
URL: https://github.com/apache/incubator-tvm-vta/pull/9#issuecomment-646916505
Thanks @zhanghaohit for the PR! I left a couple questions, but will need to
review in more depth. One question: have you tested it on the Pynq board to see
if some
tmoreau89 commented on pull request #9:
URL: https://github.com/apache/incubator-tvm-vta/pull/9#issuecomment-646427173
CC-ing @vegaluisjose @huajsj @pasqoc
This is an automated message from the Apache Git Service.
To
tmoreau89 commented on pull request #9:
URL: https://github.com/apache/incubator-tvm-vta/pull/9#issuecomment-646427144
CC-ing @vegaluisjose @huajsj @pasqoc
This is an automated message from the Apache Git Service.
To
10 matches
Mail list logo
