[GitHub] incubator-weex issue #913: [WEEX-109][iOS] bugfix with scrollstart and scrol...

2017-11-30 Thread cxfeng1
Github user cxfeng1 commented on the issue: https://github.com/apache/incubator-weex/pull/913 commit log should confirm to https://github.com/apache/incubator-weex-site/blob/master/source/development-process.md#commit-guidelines ---

[GitHub] incubator-weex issue #869: [WEEX-101][iOS] specify voice-over navigation ord...

2017-11-15 Thread cxfeng1
Github user cxfeng1 commented on the issue: https://github.com/apache/incubator-weex/pull/869 Is there any discussion result for the feature on Android? ---

[GitHub] incubator-weex issue #856: [WEEX-109][iOS] add scrollstart and scrollend eve...

2017-11-15 Thread cxfeng1
Github user cxfeng1 commented on the issue: https://github.com/apache/incubator-weex/pull/856 @doumafang Can you provide some examples of the pull request and please make sure the behavior on iOS is consistent with Android. ---

[GitHub] incubator-weex issue #864: [iOS] Make sure gesture recognizers won't be lost...

2017-11-15 Thread cxfeng1
Github user cxfeng1 commented on the issue: https://github.com/apache/incubator-weex/pull/864 @AntiMoron Can you provide the demo? http://dotwe.org/vue/ ---

[GitHub] incubator-weex pull request #856: [WEEX-109][iOS] add scrollstart and scroll...

2017-11-13 Thread cxfeng1
Github user cxfeng1 commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/856#discussion_r150474976 --- Diff: ios/sdk/WeexSDK/Sources/Component/WXScrollerComponent.m --- @@ -569,6 +573,8 @@ - (void)scrollViewDidEndScrollingAnimation:(UIScrollView

[GitHub] incubator-weex issue #844: [WEEX-99][Android] fix setViewport: sometimes doe...

2017-11-08 Thread cxfeng1
Github user cxfeng1 commented on the issue: https://github.com/apache/incubator-weex/pull/844 @gubaojian please have a review. ---

[GitHub] incubator-weex issue #838: [WEEX-94][iOS] fix iOS 8 scrollview assign delega...

2017-11-08 Thread cxfeng1
Github user cxfeng1 commented on the issue: https://github.com/apache/incubator-weex/pull/838 LGTM ---

[GitHub] incubator-weex issue #837: [WEEX-98][iOS]bug-fix addEvent lead to generate a...

2017-11-08 Thread cxfeng1
Github user cxfeng1 commented on the issue: https://github.com/apache/incubator-weex/pull/837 LGTM ---

[GitHub] incubator-weex issue #836: [WEEX-94][iOS] fix iOS 8 scrollview assign delega...

2017-11-07 Thread cxfeng1
Github user cxfeng1 commented on the issue: https://github.com/apache/incubator-weex/pull/836 @acton393 one PR for one issue, please ---

[GitHub] incubator-weex issue #834: * [ios] support max-width when drawing text

2017-11-05 Thread cxfeng1
Github user cxfeng1 commented on the issue: https://github.com/apache/incubator-weex/pull/834 It looks good to me, @gurisxie please accept the pull request. ---

[GitHub] incubator-weex issue #832: How to use playground

2017-11-03 Thread cxfeng1
Github user cxfeng1 commented on the issue: https://github.com/apache/incubator-weex/pull/832 @wei63w Please use JIRA issue or mailing list to report issues , see https://github.com/cxfeng1/incubator-weex-site/blob/6a04e077e896709c5797ad30d9a31632a8e0a193/source/contributing.md ---

[GitHub] incubator-weex issue #790: fix clipPath not works on android N 7.0

2017-10-17 Thread cxfeng1
Github user cxfeng1 commented on the issue: https://github.com/apache/incubator-weex/pull/790 The APK link can't be opened. ---

[GitHub] incubator-weex issue #756: Add Telegram Russian Community Group link

2017-09-28 Thread cxfeng1
Github user cxfeng1 commented on the issue: https://github.com/apache/incubator-weex/pull/756 @iboldurev awesome, glad to see Russians joining the Weex Community! ---

[GitHub] incubator-weex pull request #725: * [ios] add recyle list component

2017-09-21 Thread cxfeng1
GitHub user cxfeng1 opened a pull request: https://github.com/apache/incubator-weex/pull/725 * [ios] add recyle list component https://github.com/Hanks10100/weex-native-directive You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] incubator-weex pull request #581: + [ios] LayoutAnimation

2017-08-09 Thread cxfeng1
Github user cxfeng1 commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/581#discussion_r132130861 --- Diff: ios/sdk/WeexSDK/Sources/Layout/WXComponent+Layout.m --- @@ -112,6 +115,211 @@ - (NSUInteger)_childrenCountForLayout return (int

[GitHub] incubator-weex pull request #581: + [ios] LayoutAnimation

2017-08-09 Thread cxfeng1
Github user cxfeng1 commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/581#discussion_r132132975 --- Diff: ios/sdk/WeexSDK/Sources/Module/WXAnimationLayout.h --- @@ -1,49 +1,49 @@ -/* - * Licensed to the Apache Software Foundation (ASF

[GitHub] incubator-weex pull request #581: + [ios] LayoutAnimation

2017-08-09 Thread cxfeng1
Github user cxfeng1 commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/581#discussion_r132132579 --- Diff: ios/sdk/WeexSDK/Sources/Layout/WXComponent+Layout.m --- @@ -409,4 +617,77 @@ static css_dim_t cssNodeMeasure(void *context, float width

[GitHub] incubator-weex pull request #581: + [ios] LayoutAnimation

2017-08-09 Thread cxfeng1
Github user cxfeng1 commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/581#discussion_r132130697 --- Diff: ios/sdk/WeexSDK/Sources/Layout/WXComponent+Layout.m --- @@ -112,6 +115,211 @@ - (NSUInteger)_childrenCountForLayout return (int

[GitHub] incubator-weex pull request #581: + [ios] LayoutAnimation

2017-08-09 Thread cxfeng1
Github user cxfeng1 commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/581#discussion_r132131367 --- Diff: ios/sdk/WeexSDK/Sources/Model/WXComponent.m --- @@ -436,16 +436,35 @@ - (void)_moveToSupercomponent:(WXComponent *)newSupercomponent

[GitHub] incubator-weex pull request #581: + [ios] LayoutAnimation

2017-08-09 Thread cxfeng1
Github user cxfeng1 commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/581#discussion_r132132531 --- Diff: ios/sdk/WeexSDK/Sources/Layout/WXComponent+Layout.m --- @@ -112,6 +115,211 @@ - (NSUInteger)_childrenCountForLayout return (int

[GitHub] incubator-weex pull request #581: + [ios] LayoutAnimation

2017-08-09 Thread cxfeng1
Github user cxfeng1 commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/581#discussion_r132132151 --- Diff: ios/sdk/WeexSDK/Sources/Layout/WXComponent+Layout.m --- @@ -112,6 +115,211 @@ - (NSUInteger)_childrenCountForLayout return (int

[GitHub] incubator-weex pull request #539: +[ios] recyclerComponent add drag method

2017-08-08 Thread cxfeng1
Github user cxfeng1 commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/539#discussion_r129747806 --- Diff: ios/sdk/WeexSDK/Sources/Component/Recycler/WXRecyclerComponent.m --- @@ -89,6 +96,15 @@ @interface WXRecyclerComponent

[GitHub] incubator-weex pull request #539: +[ios] recyclerComponent add drag method

2017-08-08 Thread cxfeng1
Github user cxfeng1 commented on a diff in the pull request: https://github.com/apache/incubator-weex/pull/539#discussion_r129747478 --- Diff: ios/sdk/WeexSDK/Sources/Component/Recycler/WXRecyclerComponent.m --- @@ -655,6 +707,166 @@ - (void)fixFlicker

[GitHub] incubator-weex pull request #565: * [ios] public resource loader

2017-08-03 Thread cxfeng1
GitHub user cxfeng1 opened a pull request: https://github.com/apache/incubator-weex/pull/565 * [ios] public resource loader You can merge this pull request into a Git repository by running: $ git pull https://github.com/cxfeng1/incubator-weex 0.16-dev Alternatively you can

[GitHub] incubator-weex pull request #564: * [ios] make WXResourceResponse Inheriting...

2017-08-03 Thread cxfeng1
GitHub user cxfeng1 opened a pull request: https://github.com/apache/incubator-weex/pull/564 * [ios] make WXResourceResponse Inheriting from NSHTTPURLResponse You can merge this pull request into a Git repository by running: $ git pull https://github.com/cxfeng1/incubator

[GitHub] incubator-weex pull request #540: * [ios] fix keep-scroll-position crash

2017-07-26 Thread cxfeng1
GitHub user cxfeng1 opened a pull request: https://github.com/apache/incubator-weex/pull/540 * [ios] fix keep-scroll-position crash demo: http://dotwe.org/vue/62c15f7750d600aa5a184a3ca77c1e13 You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] incubator-weex pull request #534: * [ios] fix keep-scroll-position crash

2017-07-26 Thread cxfeng1
Github user cxfeng1 closed the pull request at: https://github.com/apache/incubator-weex/pull/534 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-weex pull request #534: * [ios] fix keep-scroll-position crash

2017-07-25 Thread cxfeng1
GitHub user cxfeng1 opened a pull request: https://github.com/apache/incubator-weex/pull/534 * [ios] fix keep-scroll-position crash demo: http://dotwe.org/vue/62c15f7750d600aa5a184a3ca77c1e13 You can merge this pull request into a Git repository by running: $ git pull

[GitHub] incubator-weex pull request #490: * [doc] remove unsupported scroll-directio...

2017-07-04 Thread cxfeng1
GitHub user cxfeng1 opened a pull request: https://github.com/apache/incubator-weex/pull/490 * [doc] remove unsupported scroll-direction attribute in list documentation You can merge this pull request into a Git repository by running: $ git pull https://github.com/cxfeng1

[GitHub] incubator-weex pull request #485: * [doc] Add scroll event demo.

2017-06-30 Thread cxfeng1
GitHub user cxfeng1 opened a pull request: https://github.com/apache/incubator-weex/pull/485 * [doc] Add scroll event demo. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cxfeng1/incubator-weex dev Alternatively you can review

[GitHub] incubator-weex pull request #465: * [ios] fix: crash while deleting header i...

2017-06-22 Thread cxfeng1
GitHub user cxfeng1 opened a pull request: https://github.com/apache/incubator-weex/pull/465 * [ios] fix: crash while deleting header in section 0 You can merge this pull request into a Git repository by running: $ git pull https://github.com/cxfeng1/incubator-weex 0.15-dev

[GitHub] incubator-weex pull request #429: * [test] add blames undefined check

2017-06-06 Thread cxfeng1
GitHub user cxfeng1 opened a pull request: https://github.com/apache/incubator-weex/pull/429 * [test] add blames undefined check You can merge this pull request into a Git repository by running: $ git pull https://github.com/cxfeng1/incubator-weex 0.14-dev Alternatively you

[GitHub] incubator-weex pull request #426: * [test] add blames undefined check

2017-06-06 Thread cxfeng1
GitHub user cxfeng1 opened a pull request: https://github.com/apache/incubator-weex/pull/426 * [test] add blames undefined check You can merge this pull request into a Git repository by running: $ git pull https://github.com/cxfeng1/incubator-weex 0.14-dev Alternatively you

[GitHub] incubator-weex pull request #410: * [ios] fix issues for apache release

2017-06-01 Thread cxfeng1
GitHub user cxfeng1 opened a pull request: https://github.com/apache/incubator-weex/pull/410 * [ios] fix issues for apache release - [ios] remove redundant alibaba headers * [ios] move SRWebSocket's header back to BSD license - [ios

[GitHub] incubator-weex pull request #407: * [ios] fix issue that wrong transform val...

2017-05-31 Thread cxfeng1
GitHub user cxfeng1 opened a pull request: https://github.com/apache/incubator-weex/pull/407 * [ios] fix issue that wrong transform value is read by animation module. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cxfeng1

[GitHub] incubator-weex pull request #400: * [ios] add updateTransform interface to W...

2017-05-26 Thread cxfeng1
GitHub user cxfeng1 opened a pull request: https://github.com/apache/incubator-weex/pull/400 * [ios] add updateTransform interface to WXComponent * [ios] add updateTransform interface to WXComponent to enable setting native transform directly, instead of updating css styles

[GitHub] incubator-weex issue #394: 0.14 dev

2017-05-25 Thread cxfeng1
Github user cxfeng1 commented on the issue: https://github.com/apache/incubator-weex/pull/394 please rebase first, and show more details --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] incubator-weex pull request #393: * [ios] add pagingEnabled attribute for sc...

2017-05-25 Thread cxfeng1
GitHub user cxfeng1 opened a pull request: https://github.com/apache/incubator-weex/pull/393 * [ios] add pagingEnabled attribute for scroller component iOS UIScrollView's built-in pagingEnabled feature is more natural than using pan gesture. You can merge this pull request

[GitHub] incubator-weex pull request #382: * [test] try to find the appropriate revie...

2017-05-23 Thread cxfeng1
GitHub user cxfeng1 opened a pull request: https://github.com/apache/incubator-weex/pull/382 * [test] try to find the appropriate reviewer according to the blame info You can merge this pull request into a Git repository by running: $ git pull https://github.com/cxfeng1

[GitHub] incubator-weex pull request #375: * [ios] bugfix for 0.13 features

2017-05-21 Thread cxfeng1
GitHub user cxfeng1 opened a pull request: https://github.com/apache/incubator-weex/pull/375 * [ios] bugfix for 0.13 features * [ios] Fix wrong borderRadius in resetting - [ios] remove unused methods * [ios] reset absolute position if layout is changed

[GitHub] incubator-weex issue #364: Update WXWebComponent.m

2017-05-18 Thread cxfeng1
Github user cxfeng1 commented on the issue: https://github.com/apache/incubator-weex/pull/364 @boboning please have a review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-weex pull request #363: * [ios] isNeedJoinLayoutSystem state chang...

2017-05-18 Thread cxfeng1
GitHub user cxfeng1 opened a pull request: https://github.com/apache/incubator-weex/pull/363 * [ios] isNeedJoinLayoutSystem state change should be performed on co… You can merge this pull request into a Git repository by running: $ git pull https://github.com/cxfeng1

[GitHub] incubator-weex pull request #355: * [doc] update water fall doc format

2017-05-17 Thread cxfeng1
GitHub user cxfeng1 opened a pull request: https://github.com/apache/incubator-weex/pull/355 * [doc] update water fall doc format You can merge this pull request into a Git repository by running: $ git pull https://github.com/cxfeng1/incubator-weex dev Alternatively you can

[GitHub] incubator-weex pull request #341: * [ios] support scroller delegates

2017-05-12 Thread cxfeng1
GitHub user cxfeng1 opened a pull request: https://github.com/apache/incubator-weex/pull/341 * [ios] support scroller delegates You can merge this pull request into a Git repository by running: $ git pull https://github.com/cxfeng1/incubator-weex 0.13-dev Alternatively you

[GitHub] incubator-weex issue #319: * [test] change border test case to fit android

2017-05-04 Thread cxfeng1
Github user cxfeng1 commented on the issue: https://github.com/apache/incubator-weex/pull/319 @YorkShen Please have a review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] incubator-weex pull request #319: * [test] change border test case to fit an...

2017-05-04 Thread cxfeng1
GitHub user cxfeng1 opened a pull request: https://github.com/apache/incubator-weex/pull/319 * [test] change border test case to fit android You can merge this pull request into a Git repository by running: $ git pull https://github.com/cxfeng1/incubator-weex 0.13-dev