[jira] [Commented] (WICKET-5283) Problem with uploading files via automatic ajax form submit in IE8
[ https://issues.apache.org/jira/browse/WICKET-5283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13718081#comment-13718081 ] Martin Grigorov commented on WICKET-5283: - I cannot reproduce the problem with my IE8 8.0.6001.18702. The application works fine. Problem with uploading files via automatic ajax form submit in IE8 -- Key: WICKET-5283 URL: https://issues.apache.org/jira/browse/WICKET-5283 Project: Wicket Issue Type: Bug Affects Versions: 6.9.1 Reporter: Thomas Heigl Attachments: ie8_onchange_upload_crash.zip When uploading a file via AjaxFormSubmitBehavior(onchange) IE8 hangs with very high CPU usage and does not respond anymore This always happens under Windows XP, sometimes on the first, sometimes on the second upload. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (WICKET-5273) Tabindex overwritten in modal window for IE - Works in FF, Chrome
[
https://issues.apache.org/jira/browse/WICKET-5273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Grigorov reassigned WICKET-5273:
---
Assignee: Martin Grigorov
Tabindex overwritten in modal window for IE - Works in FF, Chrome
-
Key: WICKET-5273
URL: https://issues.apache.org/jira/browse/WICKET-5273
Project: Wicket
Issue Type: Bug
Affects Versions: 6.9.1
Reporter: J
Assignee: Martin Grigorov
Priority: Minor
Attachments: tabindexinieoverwritten.zip
Attribute tabindex gets overwritten in ModalDialog, when using IE 8,9,10.. It
works fine in FF, Chrome.
This breaks chances of creating accessability by using tab.
See attachment for testproject, which works in ff,chrome, fails in ie 8,9,10.
1) Open modallink (lightbox)
2) use tabbutton - in ff, chrome you'll tab between closebutton and content,
in ie this fails cause tabindex gets overwritten by -1.
I suspect it's this codepart in modal.js that does it.
if (Wicket.Browser.isIE()) {
this.disabledTabsRevertList = [];
for (var j = 0; j this.tabbableTags.length;
j++) {
var tagElements =
doc.getElementsByTagName(this.tabbableTags[j]);
for (var k = 0 ; k
tagElements.length; k++) {
// if this is not an iframe
window and the element is child of window content,
// don't disable tab on it
if (win.isIframe() === true ||
this.isParent(tagElements[k], win.content) === false) {
var element =
tagElements[k];
element.hiddenTabIndex
= element.tabIndex;
element.tabIndex=-1;
this.disabledTabsRevertList.push(element);
}
}
}
}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
git commit: WICKET-5273 Tabindex overwritten in modal window for IE - Works in FF, Chrome
Updated Branches:
refs/heads/master b02409742 - bcee5140a
WICKET-5273 Tabindex overwritten in modal window for IE - Works in FF, Chrome
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/bcee5140
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/bcee5140
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/bcee5140
Branch: refs/heads/master
Commit: bcee5140a20c8c0921d8efdc48e21d048151d968
Parents: b024097
Author: Martin Tzvetanov Grigorov mgrigo...@apache.org
Authored: Wed Jul 24 13:07:57 2013 +0300
Committer: Martin Tzvetanov Grigorov mgrigo...@apache.org
Committed: Wed Jul 24 13:08:27 2013 +0300
--
.../wicket/extensions/ajax/markup/html/modal/res/modal.js | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/bcee5140/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
--
diff --git
a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
index bf039a9..13fb6d0 100644
---
a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
+++
b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
@@ -1553,9 +1553,9 @@
for (var j = 0; j this.tabbableTags.length;
j++) {
var tagElements =
doc.getElementsByTagName(this.tabbableTags[j]);
for (var k = 0 ; k
tagElements.length; k++) {
- // if this is not an iframe
window and the element is child of window content,
+ // if this is not an iframe
window and the element is child of modal window,
// don't disable tab on it
- if (win.isIframe() === true ||
this.isParent(tagElements[k], win.content) === false) {
+ if (win.isIframe() === true ||
this.isParent(tagElements[k], win.window) === false) {
var element =
tagElements[k];
element.hiddenTabIndex
= element.tabIndex;
element.tabIndex=-1;
@@ -1679,4 +1679,4 @@
}
};
-})();
\ No newline at end of file
+})();
[jira] [Resolved] (WICKET-5273) Tabindex overwritten in modal window for IE - Works in FF, Chrome
[
https://issues.apache.org/jira/browse/WICKET-5273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Grigorov resolved WICKET-5273.
-
Resolution: Fixed
Fix Version/s: 6.10.0
7.0.0
Modified the check which tabbableTags to disable by allowing tabIndex in all
elements in the Modal Window, not just in the 'content' part. That means now
all tabbable elements in the 'caption' won't be disabled.
Tabindex overwritten in modal window for IE - Works in FF, Chrome
-
Key: WICKET-5273
URL: https://issues.apache.org/jira/browse/WICKET-5273
Project: Wicket
Issue Type: Bug
Affects Versions: 6.9.1
Reporter: J
Assignee: Martin Grigorov
Priority: Minor
Fix For: 7.0.0, 6.10.0
Attachments: tabindexinieoverwritten.zip
Attribute tabindex gets overwritten in ModalDialog, when using IE 8,9,10.. It
works fine in FF, Chrome.
This breaks chances of creating accessability by using tab.
See attachment for testproject, which works in ff,chrome, fails in ie 8,9,10.
1) Open modallink (lightbox)
2) use tabbutton - in ff, chrome you'll tab between closebutton and content,
in ie this fails cause tabindex gets overwritten by -1.
I suspect it's this codepart in modal.js that does it.
if (Wicket.Browser.isIE()) {
this.disabledTabsRevertList = [];
for (var j = 0; j this.tabbableTags.length;
j++) {
var tagElements =
doc.getElementsByTagName(this.tabbableTags[j]);
for (var k = 0 ; k
tagElements.length; k++) {
// if this is not an iframe
window and the element is child of window content,
// don't disable tab on it
if (win.isIframe() === true ||
this.isParent(tagElements[k], win.content) === false) {
var element =
tagElements[k];
element.hiddenTabIndex
= element.tabIndex;
element.tabIndex=-1;
this.disabledTabsRevertList.push(element);
}
}
}
}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
git commit: WICKET-5273 Tabindex overwritten in modal window for IE - Works in FF, Chrome
Updated Branches:
refs/heads/wicket-6.x 0b61b074b - 1929f7b1d
WICKET-5273 Tabindex overwritten in modal window for IE - Works in FF, Chrome
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/1929f7b1
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/1929f7b1
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/1929f7b1
Branch: refs/heads/wicket-6.x
Commit: 1929f7b1db6f6b7d24fb1ec842be22a63506bcd1
Parents: 0b61b07
Author: Martin Tzvetanov Grigorov mgrigo...@apache.org
Authored: Wed Jul 24 13:07:57 2013 +0300
Committer: Martin Tzvetanov Grigorov mgrigo...@apache.org
Committed: Wed Jul 24 13:07:57 2013 +0300
--
.../wicket/extensions/ajax/markup/html/modal/res/modal.js | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/1929f7b1/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
--
diff --git
a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
index 9e3e85a..52279d7 100644
---
a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
+++
b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/modal/res/modal.js
@@ -1559,9 +1559,9 @@
for (var j = 0; j this.tabbableTags.length;
j++) {
var tagElements =
doc.getElementsByTagName(this.tabbableTags[j]);
for (var k = 0 ; k
tagElements.length; k++) {
- // if this is not an iframe
window and the element is child of window content,
+ // if this is not an iframe
window and the element is child of modal window,
// don't disable tab on it
- if (win.isIframe() === true ||
this.isParent(tagElements[k], win.content) === false) {
+ if (win.isIframe() === true ||
this.isParent(tagElements[k], win.window) === false) {
var element =
tagElements[k];
element.hiddenTabIndex
= element.tabIndex;
element.tabIndex=-1;
@@ -1685,4 +1685,4 @@
}
};
-})();
\ No newline at end of file
+})();
[jira] [Commented] (WICKET-4764) Ajax links on second page of datatable not working if client side filtering is active
[
https://issues.apache.org/jira/browse/WICKET-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13718202#comment-13718202
]
Carsten Behring commented on WICKET-4764:
-
I make sure that the init code of datatable gets written at the latest possible
moment.
So NOT as part of the headers, but just before the table html with the table
data is is written.
This can be done by overwriting onComponentTag
So
public class JQueryDatatable extends WebMarkupContainer
overwrites onComponentTag like this:
@Override
protected void onComponentTag(ComponentTag tag) {
super.onComponentTag(tag);
JavaScriptUtils.writeJavaScript(getResponse(),datatableJs(),getId()+
_datatables);
}
private StringBuilder datatableJs() {
StringBuilder js = new StringBuilder();
js.append($(document).ready( function() {\n);
js.append( $('# + getMarkupId() + ').dataTable( {\n);
js.append( \bJQueryUI\: true,\n);
js.append( \sPaginationType\: \full_numbers\,\n);
js.append( \sDom\:'lR\H\Cfrt\F\ip'\n);
js.append( } ).columnFilter();\n);
js.append(} ););
return js;
}
Ajax links on second page of datatable not working if client side filtering
is active
--
Key: WICKET-4764
URL: https://issues.apache.org/jira/browse/WICKET-4764
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 6.0.0
Reporter: Carsten Behring
I am using jquery datatable with wicket 6.0.0.
One of my columns contains an ajax link, which opens a ModalDialog.
From wicket 6.0.0 onwards, the links do only work on the first page of the
paginated list.
(The list is client side paginated by jquery datatable)
There is the same problem, if the list gets filtered (client side).
It seems to me that there is a problem with the Ajax links, as soon as some
of the rows are invisible (because filtered or on other page)
It seems that the ajax events are either not fired at all, or do not manage
to call the server side onClick method.
With wicket 1.5.8 everything was working.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-5274) AutoComplete javascript improvement
[ https://issues.apache.org/jira/browse/WICKET-5274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13718205#comment-13718205 ] Martin Grigorov commented on WICKET-5274: - It is not clear which methods exactly you mean. Please provide a patch. Thanks! AutoComplete javascript improvement --- Key: WICKET-5274 URL: https://issues.apache.org/jira/browse/WICKET-5274 Project: Wicket Issue Type: Improvement Components: wicket-extensions Affects Versions: 6.9.1 Reporter: Andrey Bezrukov I'm working on customization of AutoCompleteTextField, but I cant customize Wicket.AutoComplete, because all methods is private. It would be useful to make most of the methods of Wicket.AutoComplete privileged or even public to allow customization. See similar issue: https://issues.apache.org/jira/browse/WICKET-1651 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-5275) AutoComplete KEY_UP behavior
[ https://issues.apache.org/jira/browse/WICKET-5275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13718210#comment-13718210 ] Martin Grigorov commented on WICKET-5275: - Your patch needs improvement in the case there is no searchTerm in the text field. In this case a small empty div is being shown. To see it: - apply your patch and start wicket-examples - Ajax - Autocomplete - focus the text field - press KEY_UP without entering any text before that. AutoComplete KEY_UP behavior Key: WICKET-5275 URL: https://issues.apache.org/jira/browse/WICKET-5275 Project: Wicket Issue Type: Improvement Components: wicket-extensions Affects Versions: 6.9.1 Reporter: Andrey Bezrukov Priority: Minor Attachments: wicket-autocomplete.js.patch Probably it's good idea to change autocomplete KEY_UP behavior to increase UI usability. Suggested behavior: user focus autocomplete field - press KEY_UP - last autocomplete element selected. This behavior simplifies navigation through the list using the keyboard. See attached patch. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (WICKET-5283) Problem with uploading files via automatic ajax form submit in IE8
[
https://issues.apache.org/jira/browse/WICKET-5283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13718215#comment-13718215
]
Thomas Heigl edited comment on WICKET-5283 at 7/24/13 10:47 AM:
I'm sorry, I missed one important piece that needs to be in place for this to
fail. A response header filter that forces IE Edge mode like this:
{code}
filter
filter-nameX-UA-Compatible Filter/filter-name
filter-classcom.mycompany.ResponseHeaderFilter/filter-class
init-param
param-nameheaderName/param-name
param-valueX-UA-Compatible/param-value
/init-param
init-param
param-nameheaderValue/param-name
param-valueIE=edge/param-value
/init-param
/filter
filter-mapping
filter-nameX-UA-Compatible Filter/filter-name
url-pattern/*/url-pattern
/filter-mapping
{code}
I'm attaching a new quickstart with that filter in place.
I have absolutely no idea how upgrading Wicket could cause this to break. We
have this logic in place for years and it works until Wicket 6.8.0.
Could you please try once again with the new quickstart?
was (Author: thomas.heigl):
I'm sorry, I missed one important piece that needs to be in place for this
to fail. A response header filter that forces IE Edge mode like this:
{quote}
filter
filter-nameX-UA-Compatible Filter/filter-name
filter-classcom.mycompany.ResponseHeaderFilter/filter-class
init-param
param-nameheaderName/param-name
param-valueX-UA-Compatible/param-value
/init-param
init-param
param-nameheaderValue/param-name
param-valueIE=edge/param-value
/init-param
/filter
filter-mapping
filter-nameX-UA-Compatible Filter/filter-name
url-pattern/*/url-pattern
/filter-mapping
{quote}
I'm attaching a new quickstart with that filter in place.
I have absolutely no idea how upgrading Wicket could cause this to break. We
have this logic in place for years and it works until Wicket 6.8.0.
Could you please try once again with the new quickstart?
Problem with uploading files via automatic ajax form submit in IE8
--
Key: WICKET-5283
URL: https://issues.apache.org/jira/browse/WICKET-5283
Project: Wicket
Issue Type: Bug
Affects Versions: 6.9.1
Reporter: Thomas Heigl
Attachments: ie8_onchange_upload_crash.zip
When uploading a file via AjaxFormSubmitBehavior(onchange) IE8 hangs with
very high CPU usage and does not respond anymore
This always happens under Windows XP, sometimes on the first, sometimes on
the second upload.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-5283) Problem with uploading files via automatic ajax form submit in IE8
[
https://issues.apache.org/jira/browse/WICKET-5283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13718215#comment-13718215
]
Thomas Heigl commented on WICKET-5283:
--
I'm sorry, I missed one important piece that needs to be in place for this to
fail. A response header filter that forces IE Edge mode like this:
{quote}
filter
filter-nameX-UA-Compatible Filter/filter-name
filter-classcom.mycompany.ResponseHeaderFilter/filter-class
init-param
param-nameheaderName/param-name
param-valueX-UA-Compatible/param-value
/init-param
init-param
param-nameheaderValue/param-name
param-valueIE=edge/param-value
/init-param
/filter
filter-mapping
filter-nameX-UA-Compatible Filter/filter-name
url-pattern/*/url-pattern
/filter-mapping
{quote}
I'm attaching a new quickstart with that filter in place.
I have absolutely no idea how upgrading Wicket could cause this to break. We
have this logic in place for years and it works until Wicket 6.8.0.
Could you please try once again with the new quickstart?
Problem with uploading files via automatic ajax form submit in IE8
--
Key: WICKET-5283
URL: https://issues.apache.org/jira/browse/WICKET-5283
Project: Wicket
Issue Type: Bug
Affects Versions: 6.9.1
Reporter: Thomas Heigl
Attachments: ie8_onchange_upload_crash.zip
When uploading a file via AjaxFormSubmitBehavior(onchange) IE8 hangs with
very high CPU usage and does not respond anymore
This always happens under Windows XP, sometimes on the first, sometimes on
the second upload.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-5283) Problem with uploading files via automatic ajax form submit in IE8
[ https://issues.apache.org/jira/browse/WICKET-5283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Heigl updated WICKET-5283: - Attachment: ie8_onchange_upload_crash_with_edge_filter.zip Added new quickstart with header filter. Problem with uploading files via automatic ajax form submit in IE8 -- Key: WICKET-5283 URL: https://issues.apache.org/jira/browse/WICKET-5283 Project: Wicket Issue Type: Bug Affects Versions: 6.9.1 Reporter: Thomas Heigl Attachments: ie8_onchange_upload_crash_with_edge_filter.zip, ie8_onchange_upload_crash.zip When uploading a file via AjaxFormSubmitBehavior(onchange) IE8 hangs with very high CPU usage and does not respond anymore This always happens under Windows XP, sometimes on the first, sometimes on the second upload. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (WICKET-5275) AutoComplete KEY_UP behavior
[ https://issues.apache.org/jira/browse/WICKET-5275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Grigorov reassigned WICKET-5275: --- Assignee: Martin Grigorov AutoComplete KEY_UP behavior Key: WICKET-5275 URL: https://issues.apache.org/jira/browse/WICKET-5275 Project: Wicket Issue Type: Improvement Components: wicket-extensions Affects Versions: 6.9.1 Reporter: Andrey Bezrukov Assignee: Martin Grigorov Priority: Minor Attachments: wicket-autocomplete.js.patch Probably it's good idea to change autocomplete KEY_UP behavior to increase UI usability. Suggested behavior: user focus autocomplete field - press KEY_UP - last autocomplete element selected. This behavior simplifies navigation through the list using the keyboard. See attached patch. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
git commit: WICKET-5275 Loop thru the elements when using KEY_UP/KEY_DOWN in AutoComplete
Updated Branches:
refs/heads/master bcee5140a - a07fe6c4c
WICKET-5275 Loop thru the elements when using KEY_UP/KEY_DOWN in AutoComplete
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/a07fe6c4
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/a07fe6c4
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/a07fe6c4
Branch: refs/heads/master
Commit: a07fe6c4cbb2c6da8ebd9c4cbf8200db266950ac
Parents: bcee514
Author: Martin Tzvetanov Grigorov mgrigo...@apache.org
Authored: Wed Jul 24 14:08:30 2013 +0300
Committer: Martin Tzvetanov Grigorov mgrigo...@apache.org
Committed: Wed Jul 24 14:08:30 2013 +0300
--
.../html/autocomplete/wicket-autocomplete.js | 17 -
1 file changed, 12 insertions(+), 5 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/a07fe6c4/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js
--
diff --git
a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js
b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js
index ac0f01a..6de3de2 100644
---
a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js
+++
b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js
@@ -120,11 +120,15 @@
if (selected-1) {
setSelected(selected-1);
}
- if(selected === -1) {
- hideAutoComplete();
- } else {
- render(true, false);
+
+ var searchTerm =
Wicket.$(elementId).value;
+ if(selected === -1
searchTerm) {
+ // select the last
element
+
setSelected(elementCount-1);
+ showAutoComplete();
}
+ render(true, false);
+
if (Wicket.Browser.isSafari()) {
return
jqEvent.stopPropagation();
}
@@ -132,6 +136,9 @@
case KEY_DOWN:
if (selected elementCount-1) {
setSelected(selected+1);
+ } else if (selected ===
elementCount-1) {
+ // select the first
element
+ setSelected(0);
}
if (visible===0) {
updateChoices();
@@ -810,4 +817,4 @@
initialize();
};
-})();
\ No newline at end of file
+})();
[jira] [Updated] (WICKET-5275) Loop thru the elements when using KEY_UP/KEY_DOWN in AutoComplete
[ https://issues.apache.org/jira/browse/WICKET-5275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Grigorov updated WICKET-5275: Summary: Loop thru the elements when using KEY_UP/KEY_DOWN in AutoComplete (was: AutoComplete KEY_UP behavior) Loop thru the elements when using KEY_UP/KEY_DOWN in AutoComplete - Key: WICKET-5275 URL: https://issues.apache.org/jira/browse/WICKET-5275 Project: Wicket Issue Type: Improvement Components: wicket-extensions Affects Versions: 6.9.1 Reporter: Andrey Bezrukov Assignee: Martin Grigorov Priority: Minor Attachments: wicket-autocomplete.js.patch Probably it's good idea to change autocomplete KEY_UP behavior to increase UI usability. Suggested behavior: user focus autocomplete field - press KEY_UP - last autocomplete element selected. This behavior simplifies navigation through the list using the keyboard. See attached patch. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-5275) Loop thru the elements when using KEY_UP/KEY_DOWN in AutoComplete
[ https://issues.apache.org/jira/browse/WICKET-5275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Grigorov resolved WICKET-5275. - Resolution: Fixed Fix Version/s: 7.0.0 Improved your patch and added the same for KEY_DOWN. The change is applied only in master branch (Wicket 7.x) because it introduces a behavior change. You may start a discussion in dev@ mailing list if your think it should be applied in 6.x too. Loop thru the elements when using KEY_UP/KEY_DOWN in AutoComplete - Key: WICKET-5275 URL: https://issues.apache.org/jira/browse/WICKET-5275 Project: Wicket Issue Type: Improvement Components: wicket-extensions Affects Versions: 6.9.1 Reporter: Andrey Bezrukov Assignee: Martin Grigorov Priority: Minor Fix For: 7.0.0 Attachments: wicket-autocomplete.js.patch Probably it's good idea to change autocomplete KEY_UP behavior to increase UI usability. Suggested behavior: user focus autocomplete field - press KEY_UP - last autocomplete element selected. This behavior simplifies navigation through the list using the keyboard. See attached patch. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[CONF] Apache Wicket Migration to Wicket 7.0
Migration to Wicket 7.0 Page edited by Martin Grigorov Changes (1) ... In Wicket 6 a new setting has been added to ModalWindow - org.apache.wicket.extensions.ajax.markup.html.modal.ModalWindow#showUnloadConfirmation(). In Wicket 7 the new Java API should be used instead of dealing with the _javascript_ property _Wicket.Window.unloadConfirmation_. h5. Using keyboard UP and DOWN keys will loop thru the options [WICKET-5275|https://issues.apache.org/jira/browse/WICKET-5275] If the currently selected item is the first one and the user uses KEY_UP then the selection will move to the last option. Similarly for KEY_DOWN - if the selected option is the last one then using DOWN key will move the selection to the first one. h3. Dependency updates ... Full Content Migrating to Wicket 7.0 Environment Wicket 7.0 requires at least Java 7 Wicket 7.0 requires Servlet 3.0 The HTTP response is not flushed automatically when the request is started in asynchronous mode. WICKET-5152 API changes org/apache/wicket/core/util/io/SerializableChecker is replaced with org.apache.wicket.core.util.objects.checker.CheckingObjectOutputStream WICKET-4817 org/apache/wicket/markup/html/border/BoxBorder is removed with no replacement WICKET-4966. org.apache.wicket.Component#renderHead(HtmlHeaderContainer) is renamed to Component#internalRenderHead(HtmlHeaderContainer) WICKET-4964 org.apache.wicket.request.resource.ResourceReference#getDependencies() now returns a mutable ListHeaderItem WICKET-5124 org.apache.wicket.model.StringResourceModel constructor accepts IModelString for its default value WICKET-4972 org.apache.wicket.extensions.validation.validator.+Xyz+Validator#decorate() now works with IValidationError WICKET-5174 org.apache.wicket.ajax.attributes.AjaxRequestAttributes#setAllowDefault is renamed to #setPreventDefault WICKET-5197 org.apache.wicket.ajax.attributes.AjaxRequestAttributes#eventPropagation is now BUBBLE by default WICKET-5198 org.apache.wicket.ajax.form.AjaxFormValidatingBehavior doesn't use static methods anymore WICKET-5196 org.apache.wicket.ajax.AjaxRequestTarget.IListener#updateAjaxAttributes() is introduced WICKET-5212 org.apache.wicket.ISessionListener#onUnbound(String) is added WICKET-5213 (Base)WicketTester uses org.junit.Assert instead of junit.framework.Assert org.apache.wicket.Component#setMetaData() value could be only a Serializable WICKET-5227 org.apache.wicket.Application#getHeaderContributorListenerCollection() is renamed to #getHeaderContributorListeners() org.apache.wicket.authorization.IAuthorizationStrategy#isResourceAuthorized(IResource, PageParameters) is introduced WICKET-5012 org.apache.wicket.Component#setResponsePage() now accepts org.apache.wicket.request.component.IRequestablePage instead of org.apache.wicket.Page AutoCompleteTextField doesn't support useHideShowCoveredIEFix setting WICKET-5130 Behavior changes org.apache.wicket.request.Url#getQueryString WICKET-4664 org.apache.wicket.request.http.WebResponse encodes the value of the "filename" in Content-Disposition header WICKET-4934 org.apache.wicket.markup.html.form.FormComponentLabel outputs "required", "disabled" and "error" classes when its form component is either required, disabled or invalid. WICKET-5177 org.apache.wicket.markup.html.panel.FeedbackPanel Do not set CSS class on the li span element for a feedback message WICKET-4831 AjaxEventBehavior doesn't prevent the default behavior of the _javascript_ event WICKET-5197 Ajax behaviors let _javascript_ events bubble by default WICKET-5198 PackageTextTemplate loads its content lazily WICKET-4579 AbstractLink no longer alters its markup to render itself as disabled WICKET-4904 Button no longer silently ignores exceptions WICKET-5235 Deprecated classes/methods/fields are removed WICKET-5201 AbstractDefaultAjaxBehavior's #getSuccessHandler(), #getFailureHandler(), #getChannel() and #getPrecondition() are removed. The old Tree component in wicket-extensions is removed. Wicket.Window.unloadConfirmation has been removed WICKET-5246 Using keyboard UP and DOWN keys will loop thru the options WICKET-5275 Dependency updates Environment Wicket 7.0 requires at least Java 7 Wicket 7.0 requires Servlet 3.0 The HTTP response is not flushed automatically when the request is started in asynchronous mode. WICKET-5152 This is an improvement in Wicket 7.0 which should not affect any application migrating from Wicket 6.x. But if you use Servlet 3.0's AsyncContext in IResource in Wicket 7 then make sure that your code flushes the http response after
[jira] [Commented] (WICKET-5283) Problem with uploading files via automatic ajax form submit in IE8
[ https://issues.apache.org/jira/browse/WICKET-5283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13718263#comment-13718263 ] Martin Grigorov commented on WICKET-5283: - I can confirm that now I can reproduce the problem. Problem with uploading files via automatic ajax form submit in IE8 -- Key: WICKET-5283 URL: https://issues.apache.org/jira/browse/WICKET-5283 Project: Wicket Issue Type: Bug Affects Versions: 6.9.1 Reporter: Thomas Heigl Attachments: ie8_onchange_upload_crash_with_edge_filter.zip, ie8_onchange_upload_crash.zip When uploading a file via AjaxFormSubmitBehavior(onchange) IE8 hangs with very high CPU usage and does not respond anymore This always happens under Windows XP, sometimes on the first, sometimes on the second upload. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-5283) Problem with uploading files via automatic ajax form submit in IE8
[ https://issues.apache.org/jira/browse/WICKET-5283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13718265#comment-13718265 ] Martin Grigorov commented on WICKET-5283: - But I see the problem with 6.8.0, 6.6.0 and 6.0.0 (random versions), so it seems it is not something new ... Problem with uploading files via automatic ajax form submit in IE8 -- Key: WICKET-5283 URL: https://issues.apache.org/jira/browse/WICKET-5283 Project: Wicket Issue Type: Bug Affects Versions: 6.9.1 Reporter: Thomas Heigl Attachments: ie8_onchange_upload_crash_with_edge_filter.zip, ie8_onchange_upload_crash.zip When uploading a file via AjaxFormSubmitBehavior(onchange) IE8 hangs with very high CPU usage and does not respond anymore This always happens under Windows XP, sometimes on the first, sometimes on the second upload. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-5283) Problem with uploading files via automatic ajax form submit in IE8
[ https://issues.apache.org/jira/browse/WICKET-5283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13718286#comment-13718286 ] Thomas Heigl commented on WICKET-5283: -- You are absolutely right. There must be some side effect in my project that circumvented this problem until 6.8.0. Sigh Do you think that is something that can be fixed in Wicket or some kind of IE8 madness that i should look to solve on my side? Problem with uploading files via automatic ajax form submit in IE8 -- Key: WICKET-5283 URL: https://issues.apache.org/jira/browse/WICKET-5283 Project: Wicket Issue Type: Bug Affects Versions: 6.9.1 Reporter: Thomas Heigl Attachments: ie8_onchange_upload_crash_with_edge_filter.zip, ie8_onchange_upload_crash.zip When uploading a file via AjaxFormSubmitBehavior(onchange) IE8 hangs with very high CPU usage and does not respond anymore This always happens under Windows XP, sometimes on the first, sometimes on the second upload. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-5283) Problem with uploading files via automatic ajax form submit in IE8
[ https://issues.apache.org/jira/browse/WICKET-5283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13718297#comment-13718297 ] Martin Grigorov commented on WICKET-5283: - I added debug statements in Wicket JS code and I can confirm that it all executes without any errors. The Ajax response is processed successfully. I can see the process going wild _after_ detaching the debugger. There is no high CPU during the debug session. Problem with uploading files via automatic ajax form submit in IE8 -- Key: WICKET-5283 URL: https://issues.apache.org/jira/browse/WICKET-5283 Project: Wicket Issue Type: Bug Affects Versions: 6.9.1 Reporter: Thomas Heigl Attachments: ie8_onchange_upload_crash_with_edge_filter.zip, ie8_onchange_upload_crash.zip When uploading a file via AjaxFormSubmitBehavior(onchange) IE8 hangs with very high CPU usage and does not respond anymore This always happens under Windows XP, sometimes on the first, sometimes on the second upload. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-5283) Problem with uploading files via automatic ajax form submit in IE8
[
https://issues.apache.org/jira/browse/WICKET-5283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13718300#comment-13718300
]
Martin Grigorov commented on WICKET-5283:
-
Try with meta tag.
Add:
getHeaderContributorListenerCollection().add(new IHeaderContributor()
{
@Override
public void renderHead(IHeaderResponse response)
{
response.render(StringHeaderItem.forString(meta
http-equiv=\x-ua-compatible\ content=\ie=edge\ /));
}
});
to YourApp#init() and remove the mapping for the special filter.
This works OK for me but I'm not sure whether it is OK for your real app.
Problem with uploading files via automatic ajax form submit in IE8
--
Key: WICKET-5283
URL: https://issues.apache.org/jira/browse/WICKET-5283
Project: Wicket
Issue Type: Bug
Affects Versions: 6.9.1
Reporter: Thomas Heigl
Attachments: ie8_onchange_upload_crash_with_edge_filter.zip,
ie8_onchange_upload_crash.zip
When uploading a file via AjaxFormSubmitBehavior(onchange) IE8 hangs with
very high CPU usage and does not respond anymore
This always happens under Windows XP, sometimes on the first, sometimes on
the second upload.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-5283) Problem with uploading files via automatic ajax form submit in IE8
[ https://issues.apache.org/jira/browse/WICKET-5283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13718303#comment-13718303 ] Thomas Heigl commented on WICKET-5283: -- Thanks Martin! I just did exactly that and it works. Let's close this issue and hope nobody else ever encounters it ;) Problem with uploading files via automatic ajax form submit in IE8 -- Key: WICKET-5283 URL: https://issues.apache.org/jira/browse/WICKET-5283 Project: Wicket Issue Type: Bug Affects Versions: 6.9.1 Reporter: Thomas Heigl Attachments: ie8_onchange_upload_crash_with_edge_filter.zip, ie8_onchange_upload_crash.zip When uploading a file via AjaxFormSubmitBehavior(onchange) IE8 hangs with very high CPU usage and does not respond anymore This always happens under Windows XP, sometimes on the first, sometimes on the second upload. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-5283) Problem with uploading files via automatic ajax form submit in IE8
[ https://issues.apache.org/jira/browse/WICKET-5283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Grigorov resolved WICKET-5283. - Resolution: Not A Problem Problem with uploading files via automatic ajax form submit in IE8 -- Key: WICKET-5283 URL: https://issues.apache.org/jira/browse/WICKET-5283 Project: Wicket Issue Type: Bug Affects Versions: 6.9.1 Reporter: Thomas Heigl Attachments: ie8_onchange_upload_crash_with_edge_filter.zip, ie8_onchange_upload_crash.zip When uploading a file via AjaxFormSubmitBehavior(onchange) IE8 hangs with very high CPU usage and does not respond anymore This always happens under Windows XP, sometimes on the first, sometimes on the second upload. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-5280) HttpsMapper Could not resolve protocol for request WebSocket
[
https://issues.apache.org/jira/browse/WICKET-5280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13718311#comment-13718311
]
Martin Grigorov commented on WICKET-5280:
-
Please attach quickstart application.
Thanks!
HttpsMapper Could not resolve protocol for request WebSocket
--
Key: WICKET-5280
URL: https://issues.apache.org/jira/browse/WICKET-5280
Project: Wicket
Issue Type: Bug
Components: wicket, wicket-atmosphere
Affects Versions: 6.9.1
Environment: wicket-atmosphere 0.11, Tomcat 7.0
Reporter: Hendy Irawan
Assignee: Emond Papegaaij
HttpsMapper, with or without XForwardedRequestWrapper, seems to be
problematic when combined with Atmosphere via WebSocket :
{code}
java.lang.IllegalStateException
Could not resolve protocol for request:
org.apache.wicket.protocol.http.servlet.XForwardedRequestWrapper@cbb5077
{code}
Or without XForwardedRequestWrapper:
{code}
java.lang.IllegalStateException
Could not resolve protocol for request: c244911c-d8aa-4d66-a645-2ef935199b78
at
org.apache.wicket.protocol.https.HttpsMapper.getSchemeOf(HttpsMapper.java:215)
~[wicket-core-6.9.1.jar:6.9.1]
at
org.apache.wicket.protocol.https.HttpsMapper.mapHandler(HttpsMapper.java:167)
~[wicket-core-6.9.1.jar:6.9.1]
at
org.apache.wicket.protocol.https.HttpsMapper.mapHandler(HttpsMapper.java:112)
~[wicket-core-6.9.1.jar:6.9.1]
{code}
although page seems operating normally, but it gives ERROR logs.
I think this is due to Atmosphere HttpsMapper not detecting the scheme
correctly? (ws/wss? actually WebSocket)
{code}
protected Scheme getSchemeOf(Request request)
{
HttpServletRequest req = (HttpServletRequest)
request.getContainerRequest();
if (https.equalsIgnoreCase(req.getScheme()))
{
return Scheme.HTTPS;
}
else if (http.equalsIgnoreCase(req.getScheme()))
{
return Scheme.HTTP;
}
else
{
throw new IllegalStateException(Could not resolve
protocol for request: + req);
}
}
{code}
I workaround it using:
{code}
setRootRequestMapper(new HttpsMapper(getRootRequestMapper(), new
HttpsConfig(8980, 8943)) {
@Override
protected Scheme getSchemeOf(Request request) {
HttpServletRequest req = (HttpServletRequest)
request.getContainerRequest();
log.info(Scheme for {} is {}, req, req.getScheme());
if (https.equalsIgnoreCase(req.getScheme()))
{
return Scheme.HTTPS;
}
else if (http.equalsIgnoreCase(req.getScheme()))
{
return Scheme.HTTP;
}
else if (WebSocket.equalsIgnoreCase(req.getScheme()))
{
return Scheme.ANY;
}
else
{
throw new IllegalStateException(Could not resolve
protocol for request: + req
+ , unrecognized scheme: +
req.getScheme());
}
}
});
{code}
If the above is proper way to do it, please update the {{HttpsMapper}}
implementation, also with more detailed exception message above
(unrecognized scheme).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
git commit: WICKET-5279 o.a.w.a.AtmosphereBehavior onBroadcast should log DEBUG, not INFO
Updated Branches:
refs/heads/wicket-6.x 1929f7b1d - 8a42a36a1
WICKET-5279 o.a.w.a.AtmosphereBehavior onBroadcast should log DEBUG, not INFO
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/8a42a36a
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/8a42a36a
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/8a42a36a
Branch: refs/heads/wicket-6.x
Commit: 8a42a36a1f0bd4e667454d7cd83b099806dbbc63
Parents: 1929f7b
Author: Martin Tzvetanov Grigorov mgrigo...@apache.org
Authored: Wed Jul 24 15:36:21 2013 +0300
Committer: Martin Tzvetanov Grigorov mgrigo...@apache.org
Committed: Wed Jul 24 15:36:21 2013 +0300
--
.../java/org/apache/wicket/atmosphere/AtmosphereBehavior.java | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/8a42a36a/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/AtmosphereBehavior.java
--
diff --git
a/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/AtmosphereBehavior.java
b/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/AtmosphereBehavior.java
index 83e3de7..894d58d 100644
---
a/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/AtmosphereBehavior.java
+++
b/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/AtmosphereBehavior.java
@@ -126,7 +126,10 @@ public class AtmosphereBehavior extends Behavior
@Override
public void onBroadcast(AtmosphereResourceEvent event)
{
- log.info(onBroadcast: {}, event.getMessage());
+ if (log.isDebugEnabled())
+ {
+ log.debug(onBroadcast: {}, event.getMessage());
+ }
// If we are using long-polling, resume the connection as soon
as we get
// an event.
@@ -234,4 +237,4 @@ public class AtmosphereBehavior extends Behavior
{
return resource.uuid();
}
-}
\ No newline at end of file
+}
git commit: WICKET-5279 o.a.w.a.AtmosphereBehavior onBroadcast should log DEBUG, not INFO
Updated Branches:
refs/heads/master a07fe6c4c - 977f1e246
WICKET-5279 o.a.w.a.AtmosphereBehavior onBroadcast should log DEBUG, not INFO
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/977f1e24
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/977f1e24
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/977f1e24
Branch: refs/heads/master
Commit: 977f1e24676e050ea759b415602aed88deba5d76
Parents: a07fe6c
Author: Martin Tzvetanov Grigorov mgrigo...@apache.org
Authored: Wed Jul 24 15:36:21 2013 +0300
Committer: Martin Tzvetanov Grigorov mgrigo...@apache.org
Committed: Wed Jul 24 15:37:51 2013 +0300
--
.../java/org/apache/wicket/atmosphere/AtmosphereBehavior.java | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/wicket/blob/977f1e24/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/AtmosphereBehavior.java
--
diff --git
a/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/AtmosphereBehavior.java
b/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/AtmosphereBehavior.java
index 83e3de7..894d58d 100644
---
a/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/AtmosphereBehavior.java
+++
b/wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/AtmosphereBehavior.java
@@ -126,7 +126,10 @@ public class AtmosphereBehavior extends Behavior
@Override
public void onBroadcast(AtmosphereResourceEvent event)
{
- log.info(onBroadcast: {}, event.getMessage());
+ if (log.isDebugEnabled())
+ {
+ log.debug(onBroadcast: {}, event.getMessage());
+ }
// If we are using long-polling, resume the connection as soon
as we get
// an event.
@@ -234,4 +237,4 @@ public class AtmosphereBehavior extends Behavior
{
return resource.uuid();
}
-}
\ No newline at end of file
+}
[jira] [Resolved] (WICKET-5279) o.a.w.a.AtmosphereBehavior onBroadcast should log DEBUG, not INFO
[
https://issues.apache.org/jira/browse/WICKET-5279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Grigorov resolved WICKET-5279.
-
Resolution: Fixed
Fix Version/s: 6.10.0
7.0.0
Assignee: Martin Grigorov (was: Emond Papegaaij)
o.a.w.a.AtmosphereBehavior onBroadcast should log DEBUG, not INFO
-
Key: WICKET-5279
URL: https://issues.apache.org/jira/browse/WICKET-5279
Project: Wicket
Issue Type: Bug
Components: wicket-atmosphere
Affects Versions: 6.9.1
Reporter: Hendy Irawan
Assignee: Martin Grigorov
Fix For: 7.0.0, 6.10.0
Original Estimate: 1h
Remaining Estimate: 1h
Logging of onBroadcast is too verbose to be on INFO level :
{code}
14:48:54.812 | INFO | oryBean_Worker-4 | o.a.w.a.EventBus |
pache.wicket.atmosphere.EventBus 203 | registering component for page 1 for
session A3D08FEE5445F872C8A69289C00F79E3: crumbHolder:jobListPanel
14:48:54.831 | INFO | Shared-AsyncOp-0 | o.a.w.a.AtmosphereBehavior |
et.atmosphere.AtmosphereBehavior 129 | onBroadcast: 32501|msg|?xml
version=1.0 encoding=UTF-8?ajax-responsecomponent
id=jobListPanel1ea9 ![CDATA[div id=jobListPanel1ea9
h3Device Presences/h3
div class=btn-toolbar
a href=# class=btn btn-danger id=deleteAllBtn1f27i
class=icon-trash/i Delete all/aspan style=display:none;
class=wicket-ajax-indicator id=deleteAllBtn1f27--ajax-indicatorimg
src=./wicket/resource/org.apache.wicket.ajax.AbstractDefaultAjaxBehavior/indicator-ver-1373820815000.gif
alt=//span
/div
table id=devicePresenceTable1f33 class=table-striped table-bordered
table
thead
tr class=navigation
td colspan=5
...
{code}
It should be DEBUG level only
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (WICKET-5284) Too deep recursion in AbstractHierarchyIterator
Martin Petricek created WICKET-5284:
---
Summary: Too deep recursion in AbstractHierarchyIterator
Key: WICKET-5284
URL: https://issues.apache.org/jira/browse/WICKET-5284
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 6.9.1
Reporter: Martin Petricek
In application we have code as follows:
MarkupContainer mc = ...;
ComponentHierarchyIterator iter = mc.visitChildren(FormComponent.class);
for (Component c : iter) {
...
}
However, when run, on many pages this causes java.lang.StackOverflowError, with
lots of the stacktrace filled with lines like this:
...
org.apache.wicket.util.iterator.AbstractHierarchyIterator.moveUp(AbstractHierarchyIterator.java:302)
org.apache.wicket.util.iterator.AbstractHierarchyIterator.moveUp(AbstractHierarchyIterator.java:302)
org.apache.wicket.util.iterator.AbstractHierarchyIterator.nextNode(AbstractHierarchyIterator.java:259)
org.apache.wicket.util.iterator.AbstractHierarchyIterator.moveDown(AbstractHierarchyIterator.java:170)
org.apache.wicket.util.iterator.AbstractHierarchyIterator.nextNode(AbstractHierarchyIterator.java:236)
org.apache.wicket.util.iterator.AbstractHierarchyIterator.moveUp(AbstractHierarchyIterator.java:297)
org.apache.wicket.util.iterator.AbstractHierarchyIterator.nextNode(AbstractHierarchyIterator.java:259)
org.apache.wicket.util.iterator.AbstractHierarchyIterator.moveDown(AbstractHierarchyIterator.java:170)
org.apache.wicket.util.iterator.AbstractHierarchyIterator.nextNode(AbstractHierarchyIterator.java:236)
org.apache.wicket.util.iterator.AbstractHierarchyIterator.moveDown(AbstractHierarchyIterator.java:170)
org.apache.wicket.util.iterator.AbstractHierarchyIterator.nextNode(AbstractHierarchyIterator.java:236)
org.apache.wicket.util.iterator.AbstractHierarchyIterator.moveDown(AbstractHierarchyIterator.java:170)
org.apache.wicket.util.iterator.AbstractHierarchyIterator.nextNode(AbstractHierarchyIterator.java:236)
org.apache.wicket.util.iterator.AbstractHierarchyIterator.moveDown(AbstractHierarchyIterator.java:170)
org.apache.wicket.util.iterator.AbstractHierarchyIterator.nextNode(AbstractHierarchyIterator.java:236)
org.apache.wicket.util.iterator.AbstractHierarchyIterator.moveUp(AbstractHierarchyIterator.java:297)
org.apache.wicket.util.iterator.AbstractHierarchyIterator.moveUp(AbstractHierarchyIterator.java:302)
org.apache.wicket.util.iterator.AbstractHierarchyIterator.nextNode(AbstractHierarchyIterator.java:259)
...
It seems that the search for next component in the iteration produces too deep
recursion here (not infinite, but too deep for processing a typical page with
relatively lots of components) and I suspect that the length of the stack used
by the iterator is proportional to the total number of components in the page.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-5281) TomcatWebSocket error: WebSocket Redirect not supported on a @RequireHttps page
[
https://issues.apache.org/jira/browse/WICKET-5281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13718320#comment-13718320
]
Martin Grigorov commented on WICKET-5281:
-
Please attach a quickstart app.
Thanks!
TomcatWebSocket error: WebSocket Redirect not supported on a @RequireHttps
page
---
Key: WICKET-5281
URL: https://issues.apache.org/jira/browse/WICKET-5281
Project: Wicket
Issue Type: Bug
Components: wicket-atmosphere
Affects Versions: 6.9.1
Environment: wicket-atmosphere 0.11, Tomcat 7.0
Reporter: Hendy Irawan
Assignee: Emond Papegaaij
Happens when using WebSocket together with Tomcat SSL/HTTPS connector on a
@RequireHttps page. I don't know why. But it seems wss is used properly
anyway.
Note that HttpsMapper was tweaked to return Scheme=ANY on WebSocket.
{code}
Message: WebSocket Redirect not supported
Level: ERROR
Logger: org.atmosphere.container.version.TomcatWebSocket
Thread: http-nio-8943-exec-6 (id=71)
Timestamp: 2013-07-22 15:31:00.228+0700
Call Location:
at
org.atmosphere.container.version.TomcatWebSocket.redirect(TomcatWebSocket.java:51)
{code}
Chrome Network info as proof that WSS seems to be working:
{code}
GET
wss://localhost:8943/com.quikdo.freq.job/app/?35-IResourceListener.2-X-Atmosphere-tracking-id=0X-Atmosphere-Framework=1.0.13X-Atmosphere-Transport=websocketX-Atmosphere-TrackMessageSize=trueX-Cache-Date=0
HTTP/1.1
Pragma: no-cache
Origin: https://localhost:8943
Host: localhost:8943
Sec-WebSocket-Key: rHM8FjlVP024Q4XTLQ00wA==
Upgrade: websocket
Sec-WebSocket-Extensions: x-webkit-deflate-frame
Cache-Control: no-cache
Cookie: splashShown1.6=1
Connection: Upgrade
Sec-WebSocket-Version: 13
{code}
{code}
Request URL:
wss://localhost:8943/com.quikdo.freq.job/app/?35-IResourceListener.2-X-Atmosphere-tracking-id=0X-Atmosphere-Framework=1.0.13X-Atmosphere-Transport=websocketX-Atmosphere-TrackMessageSize=trueX-Cache-Date=0
1. Request Method:
GET
2. Status Code:
101 Switching Protocols
3. Request Headersview source
1. Cache-Control:
no-cache
2. Connection:
Upgrade
3. Cookie:
splashShown1.6=1
4. Host:
localhost:8943
5. Origin:
https://localhost:8943
6. Pragma:
no-cache
7. Sec-WebSocket-Extensions:
x-webkit-deflate-frame
8. Sec-WebSocket-Key:
rHM8FjlVP024Q4XTLQ00wA==
9. Sec-WebSocket-Version:
13
10. Upgrade:
websocket
4. Query String Parametersview sourceview URL encoded
1. 35-IResourceListener.2-:
2. X-Atmosphere-tracking-id:
0
3. X-Atmosphere-Framework:
1.0.13
4. X-Atmosphere-Transport:
websocket
5. X-Atmosphere-TrackMessageSize:
true
6. X-Cache-Date:
0
{code}
{code}Response Headers
1. Connection:
upgrade
2. Date:
Mon, 22 Jul 2013 08:38:38 GMT
3. Sec-WebSocket-Accept:
qNtBvFivxQIvVL6GfN9jSkaai48=
4. Server:
Apache-Coyote/1.1
5. Upgrade:
websocket
6. X-Atmosphere-tracking-id:
210c5e6b-9a1d-4f8e-8564-d26499a940fd
{code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-5284) Too deep recursion in AbstractHierarchyIterator
[
https://issues.apache.org/jira/browse/WICKET-5284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13718325#comment-13718325
]
Martin Grigorov commented on WICKET-5284:
-
HierarchyIterator classes are kind of experimental.
They were supposed to replace the visitor based component tree traversal but
haven't been tested well enough.
Please provide a quickstart app that shows the problem and we will investigate
the problem.
In the meantime you can use
org.apache.wicket.MarkupContainer#visitChildren(IVisitorComponent, R visitor)
method.
Too deep recursion in AbstractHierarchyIterator
---
Key: WICKET-5284
URL: https://issues.apache.org/jira/browse/WICKET-5284
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 6.9.1
Reporter: Martin Petricek
In application we have code as follows:
MarkupContainer mc = ...;
ComponentHierarchyIterator iter =
mc.visitChildren(FormComponent.class);
for (Component c : iter) {
...
}
However, when run, on many pages this causes java.lang.StackOverflowError,
with lots of the stacktrace filled with lines like this:
...
org.apache.wicket.util.iterator.AbstractHierarchyIterator.moveUp(AbstractHierarchyIterator.java:302)
org.apache.wicket.util.iterator.AbstractHierarchyIterator.moveUp(AbstractHierarchyIterator.java:302)
org.apache.wicket.util.iterator.AbstractHierarchyIterator.nextNode(AbstractHierarchyIterator.java:259)
org.apache.wicket.util.iterator.AbstractHierarchyIterator.moveDown(AbstractHierarchyIterator.java:170)
org.apache.wicket.util.iterator.AbstractHierarchyIterator.nextNode(AbstractHierarchyIterator.java:236)
org.apache.wicket.util.iterator.AbstractHierarchyIterator.moveUp(AbstractHierarchyIterator.java:297)
org.apache.wicket.util.iterator.AbstractHierarchyIterator.nextNode(AbstractHierarchyIterator.java:259)
org.apache.wicket.util.iterator.AbstractHierarchyIterator.moveDown(AbstractHierarchyIterator.java:170)
org.apache.wicket.util.iterator.AbstractHierarchyIterator.nextNode(AbstractHierarchyIterator.java:236)
org.apache.wicket.util.iterator.AbstractHierarchyIterator.moveDown(AbstractHierarchyIterator.java:170)
org.apache.wicket.util.iterator.AbstractHierarchyIterator.nextNode(AbstractHierarchyIterator.java:236)
org.apache.wicket.util.iterator.AbstractHierarchyIterator.moveDown(AbstractHierarchyIterator.java:170)
org.apache.wicket.util.iterator.AbstractHierarchyIterator.nextNode(AbstractHierarchyIterator.java:236)
org.apache.wicket.util.iterator.AbstractHierarchyIterator.moveDown(AbstractHierarchyIterator.java:170)
org.apache.wicket.util.iterator.AbstractHierarchyIterator.nextNode(AbstractHierarchyIterator.java:236)
org.apache.wicket.util.iterator.AbstractHierarchyIterator.moveUp(AbstractHierarchyIterator.java:297)
org.apache.wicket.util.iterator.AbstractHierarchyIterator.moveUp(AbstractHierarchyIterator.java:302)
org.apache.wicket.util.iterator.AbstractHierarchyIterator.nextNode(AbstractHierarchyIterator.java:259)
...
It seems that the search for next component in the iteration produces too
deep recursion here (not infinite, but too deep for processing a typical page
with relatively lots of components) and I suspect that the length of the
stack used by the iterator is proportional to the total number of components
in the page.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-5224) ModalWindow is not visible in Safari when opened from a link at the bottom of a large page
[ https://issues.apache.org/jira/browse/WICKET-5224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13718440#comment-13718440 ] Jered Myers commented on WICKET-5224: - Has anybody been able to look into this yet? It is holding back a release for me as my application depends on the ModalWindow being available for Safari users. I can do a custom Wicket build and patch by removing the fix for WICKET-4948, but I would rather not do that if this is going to be addressed soon. ModalWindow is not visible in Safari when opened from a link at the bottom of a large page -- Key: WICKET-5224 URL: https://issues.apache.org/jira/browse/WICKET-5224 Project: Wicket Issue Type: Bug Components: wicket-extensions Affects Versions: 6.8.0 Environment: Safari 5.1.7 (7534.57.2) Windows, Safari (iOS 6.1.3) Reporter: Jered Myers Assignee: Igor Vaynberg Attachments: safariscroll.zip Original Estimate: 1h Remaining Estimate: 1h I am not able to see a ModalWindow in Safari and I expect to see it centered on my view port. Steps: 1. Start with a large web page with a link to open the ModalWindow at the bottom of the page. You need a large page where you have to scroll down to find the link. 2. Click the link 3. Observe that the mask for the ModalWindow displays, but the ModalWindow does not. Scrolling back up, re-sizing, and maximizing will still not display the ModalWindow. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (WICKET-5285) Encoding broken on message when reaching jquery.atmosphere
Felipe Taboada created WICKET-5285:
--
Summary: Encoding broken on message when reaching jquery.atmosphere
Key: WICKET-5285
URL: https://issues.apache.org/jira/browse/WICKET-5285
Project: Wicket
Issue Type: Bug
Components: wicket-atmosphere
Affects Versions: 6.9.0
Environment: wicket-atmosphere 0.11, JBoss EAP 6.1
Reporter: Felipe Taboada
Assignee: Emond Papegaaij
The problem is that the html updated by the wicket-atmosphere response arrives
with broken enconding.
Everything is fine until the respose reaches the jquery.atmosphere javascript.
Already tried to do this on the javascript resources, but without success:
@Override
public JavaScriptPackageResource getResource()
{
JavaScriptPackageResource resource = super.getResource();
resource.setTextEncoding(UTF-8);
return resource;
}
Reproducible at http://www.wicket-library.com/wicket-examples-6.0.x/atmosphere/
Just try to send a message with á .
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (WICKET-5286) o.a.w.extensions.markup.html.form.DateTextField should be applicable to HTML5 date input types
Hendy Irawan created WICKET-5286:
Summary: o.a.w.extensions.markup.html.form.DateTextField should be
applicable to HTML5 date input types
Key: WICKET-5286
URL: https://issues.apache.org/jira/browse/WICKET-5286
Project: Wicket
Issue Type: Bug
Components: wicket-extensions
Affects Versions: 6.9.1
Reporter: Hendy Irawan
Markup:
{code}
input type=date wicket:id=startDateFld/
{code}
Java:
{code}
add(new DateTextField(startDateFld, new ModelDate()));
{code}
It should accept the following HTML5 input types:
1. date
2. datetime
3. datetime-local
4. month
5. time
6. week
Error:
{code}
Component [startDateFld] (path = [24:compId:startDateFld]) must be applied to a
tag with [type] attribute matching [text], not [date]
MarkupStream: [markup =
file:/home/ceefour/git/quikdo-hub/freq.web/target/classes/com/quikdo/freq/web/DateRangePanel.html
input type=date wicket:id=startDateFld/, index = 0, current = 'input
type=date wicket:id=startDateFld/' (line 0, column 0)]
at
org.apache.wicket.markup.MarkupStream.throwMarkupException(MarkupStream.java:526)
at
org.apache.wicket.Component.checkComponentTagAttribute(Component.java:3578)
at
org.apache.wicket.markup.html.form.TextField.onComponentTag(TextField.java:104)
at org.apache.wicket.Component.internalRenderComponent(Component.java:2520)
at org.apache.wicket.MarkupContainer.onRender(MarkupContainer.java:1493)
at org.apache.wicket.Component.internalRender(Component.java:2379)
at org.apache.wicket.Component.render(Component.java:2307)
at org.apache.wicket.MarkupContainer.renderNext(MarkupContainer.java:1390)
at org.apache.wicket.MarkupContainer.renderAll(MarkupContainer.java:1554)
at
org.apache.wicket.MarkupContainer.renderComponentTagBody(MarkupContainer.java:1529)
at
org.apache.wicket.MarkupContainer.renderAssociatedMarkup(MarkupContainer.java:689)
at
org.apache.wicket.markup.html.panel.AssociatedMarkupSourcingStrategy.renderAssociatedMarkup(AssociatedMarkupSourcingStrategy.java:76)
at
org.apache.wicket.markup.html.panel.PanelMarkupSourcingStrategy.onComponentTagBody(PanelMarkupSourcingStrategy.java:112)
at org.apache.wicket.Component.internalRenderComponent(Component.java:2549)
at org.apache.wicket.MarkupContainer.onRender(MarkupContainer.java:1493)
at org.apache.wicket.Component.internalRender(Component.java:2379)
at org.apache.wicket.Component.render(Component.java:2307)
at
org.apache.wicket.core.util.string.ComponentRenderer.renderComponent(ComponentRenderer.java:107)
at
com.quikdo.freq.web.FrequencyPage$FrequencyForm$1.load(FrequencyPage.java:91)
at
com.quikdo.freq.web.FrequencyPage$FrequencyForm$1.load(FrequencyPage.java:1)
at
org.apache.wicket.model.LoadableDetachableModel.getObject(LoadableDetachableModel.java:121)
at
de.agilecoders.wicket.core.markup.html.bootstrap.components.PopoverBehavior.newContent(PopoverBehavior.java:68)
at
de.agilecoders.wicket.core.markup.html.bootstrap.components.PopoverBehavior.onComponentTag(PopoverBehavior.java:47)
at org.apache.wicket.Component.renderComponentTag(Component.java:3970)
at org.apache.wicket.Component.internalRenderComponent(Component.java:2540)
at org.apache.wicket.MarkupContainer.onRender(MarkupContainer.java:1493)
at org.apache.wicket.Component.internalRender(Component.java:2379)
at org.apache.wicket.Component.render(Component.java:2307)
at org.apache.wicket.MarkupContainer.renderNext(MarkupContainer.java:1390)
at org.apache.wicket.MarkupContainer.renderAll(MarkupContainer.java:1554)
at
org.apache.wicket.MarkupContainer.renderComponentTagBody(MarkupContainer.java:1529)
at
org.apache.wicket.MarkupContainer.onComponentTagBody(MarkupContainer.java:1484)
at
org.apache.wicket.markup.html.form.Form.onComponentTagBody(Form.java:1683)
at
org.apache.wicket.markup.html.panel.DefaultMarkupSourcingStrategy.onComponentTagBody(DefaultMarkupSourcingStrategy.java:71)
at org.apache.wicket.Component.internalRenderComponent(Component.java:2549)
at org.apache.wicket.MarkupContainer.onRender(MarkupContainer.java:1493)
at org.apache.wicket.Component.internalRender(Component.java:2379)
at org.apache.wicket.Component.render(Component.java:2307)
at org.apache.wicket.MarkupContainer.renderNext(MarkupContainer.java:1390)
at org.apache.wicket.MarkupContainer.renderAll(MarkupContainer.java:1554)
at
org.apache.wicket.MarkupContainer.renderComponentTagBody(MarkupContainer.java:1529)
at
org.apache.wicket.MarkupContainer.onComponentTagBody(MarkupContainer.java:1484)
at
org.apache.wicket.markup.html.panel.DefaultMarkupSourcingStrategy.onComponentTagBody(DefaultMarkupSourcingStrategy.java:71)
at org.apache.wicket.Component.internalRenderComponent(Component.java:2549)
at
