[jira] [Updated] (WICKET-7045) Avoid allocations in PageParameters.getNamedKeys

2023-04-16 Thread Thomas Heigl (Jira)
[ https://issues.apache.org/jira/browse/WICKET-7045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Heigl updated WICKET-7045: - Priority: Minor (was: Major) > Avoid allocations in PageParameters.getNamedKeys >

[jira] [Updated] (WICKET-7047) Improve initial buffer capacity for Strings.toMultilineMarkup

2023-04-16 Thread Thomas Heigl (Jira)
[ https://issues.apache.org/jira/browse/WICKET-7047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Heigl updated WICKET-7047: - Priority: Minor (was: Major) > Improve initial buffer capacity for Strings.toMultilineMarkup >

[jira] [Commented] (WICKET-7049) Avoid allocation for empty buckets in FilteringHeaderResponse

2023-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WICKET-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712898#comment-17712898 ] ASF GitHub Bot commented on WICKET-7049: theigl opened a new pull request, #581: URL:

[GitHub] [wicket] theigl opened a new pull request, #581: WICKET-7049 Avoid allocating a string buffer for empty header buckets

2023-04-16 Thread via GitHub
theigl opened a new pull request, #581: URL: https://github.com/apache/wicket/pull/581 This PR avoids allocating `AppendingStringBuffer` for empty header buckets in `FilteringHeaderResponse`. It targets 9.x because in 10, all string responses will be lazy by default (#574). --

[jira] [Commented] (WICKET-7047) Improve initial buffer capacity for Strings.toMultilineMarkup

2023-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WICKET-7047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712896#comment-17712896 ] ASF GitHub Bot commented on WICKET-7047: reiern70 commented on code in PR #579: URL:

[jira] [Created] (WICKET-7049) Avoid allocation for empty buckets in FilteringHeaderResponse

2023-04-16 Thread Thomas Heigl (Jira)
Thomas Heigl created WICKET-7049: Summary: Avoid allocation for empty buckets in FilteringHeaderResponse Key: WICKET-7049 URL: https://issues.apache.org/jira/browse/WICKET-7049 Project: Wicket

[GitHub] [wicket] reiern70 commented on a diff in pull request #579: WICKET-7047 Improve initial buffer capacity for multiline-markup

2023-04-16 Thread via GitHub
reiern70 commented on code in PR #579: URL: https://github.com/apache/wicket/pull/579#discussion_r1168202846 ## wicket-util/src/main/java/org/apache/wicket/util/string/Strings.java: ## @@ -1089,7 +1089,7 @@ public static CharSequence toMultilineMarkup(final CharSequence s)

[jira] [Commented] (WICKET-7047) Improve initial buffer capacity for Strings.toMultilineMarkup

2023-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WICKET-7047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712893#comment-17712893 ] ASF GitHub Bot commented on WICKET-7047: theigl commented on code in PR #579: URL:

[GitHub] [wicket] theigl commented on a diff in pull request #579: WICKET-7047 Improve initial buffer capacity for multiline-markup

2023-04-16 Thread via GitHub
theigl commented on code in PR #579: URL: https://github.com/apache/wicket/pull/579#discussion_r1168193350 ## wicket-util/src/main/java/org/apache/wicket/util/string/Strings.java: ## @@ -1089,7 +1089,7 @@ public static CharSequence toMultilineMarkup(final CharSequence s)

[jira] [Commented] (WICKET-7047) Improve initial buffer capacity for Strings.toMultilineMarkup

2023-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WICKET-7047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712891#comment-17712891 ] ASF GitHub Bot commented on WICKET-7047: reiern70 commented on code in PR #579: URL:

[GitHub] [wicket] reiern70 commented on a diff in pull request #579: WICKET-7047 Improve initial buffer capacity for multiline-markup

2023-04-16 Thread via GitHub
reiern70 commented on code in PR #579: URL: https://github.com/apache/wicket/pull/579#discussion_r1168186263 ## wicket-util/src/main/java/org/apache/wicket/util/string/Strings.java: ## @@ -1089,7 +1089,7 @@ public static CharSequence toMultilineMarkup(final CharSequence s)

[jira] [Commented] (WICKET-7047) Improve initial buffer capacity for Strings.toMultilineMarkup

2023-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WICKET-7047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712890#comment-17712890 ] ASF GitHub Bot commented on WICKET-7047: theigl commented on code in PR #579: URL:

[GitHub] [wicket] theigl commented on a diff in pull request #579: WICKET-7047 Improve initial buffer capacity for multiline-markup

2023-04-16 Thread via GitHub
theigl commented on code in PR #579: URL: https://github.com/apache/wicket/pull/579#discussion_r1168181660 ## wicket-util/src/main/java/org/apache/wicket/util/string/Strings.java: ## @@ -1089,7 +1089,7 @@ public static CharSequence toMultilineMarkup(final CharSequence s)

[jira] [Commented] (WICKET-7048) add an AjaxExtendedClientInfoBehavior that makes use of OnDomReady

2023-04-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/WICKET-7048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712888#comment-17712888 ] ASF subversion and git services commented on WICKET-7048: - Commit

[wicket] branch improvement/reiern70/WICKET-7048 updated (894a513b17 -> 2ae2a5fb90)

2023-04-16 Thread reiern70
This is an automated email from the ASF dual-hosted git repository. reiern70 pushed a change to branch improvement/reiern70/WICKET-7048 in repository https://gitbox.apache.org/repos/asf/wicket.git discard 894a513b17 [WICKET-7048] AjaxClientInfoBehavior is AJAX timer based. This seems not work

[jira] [Commented] (WICKET-7048) add an AjaxExtendedClientInfoBehavior that makes use of OnDomReady

2023-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WICKET-7048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712887#comment-17712887 ] ASF GitHub Bot commented on WICKET-7048: reiern70 opened a new pull request, #580: URL:

[GitHub] [wicket] reiern70 opened a new pull request, #580: [WICKET-7048] add AjaxOnDomReadyClientInfoBehavior

2023-04-16 Thread via GitHub
reiern70 opened a new pull request, #580: URL: https://github.com/apache/wicket/pull/580 AjaxClientInfoBehavior is AJAX timer based. This seems not to work reliable in all situations. We add a AjaxOnDomReadyClientInfoBehavior that uses DOMREADY and seems to work more reliable. -- This

[jira] [Commented] (WICKET-7048) add an AjaxExtendedClientInfoBehavior that makes use of OnDomReady

2023-04-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/WICKET-7048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712886#comment-17712886 ] ASF subversion and git services commented on WICKET-7048: - Commit

[wicket] 01/01: [WICKET-7048] AjaxClientInfoBehavior is AJAX timer based. This seems not work reliable in all situations. We add a AjaxOnDomReadyClientInfoBehavior that uses DOMREADY and seems to work

2023-04-16 Thread reiern70
This is an automated email from the ASF dual-hosted git repository. reiern70 pushed a commit to branch improvement/reiern70/WICKET-7048 in repository https://gitbox.apache.org/repos/asf/wicket.git commit 894a513b17e284d570bf9f2f6a7e3a0078337adf Author: reiern70 AuthorDate: Mon Apr 17 07:53:49

[wicket] branch improvement/reiern70/WICKET-7048 created (now 894a513b17)

2023-04-16 Thread reiern70
This is an automated email from the ASF dual-hosted git repository. reiern70 pushed a change to branch improvement/reiern70/WICKET-7048 in repository https://gitbox.apache.org/repos/asf/wicket.git at 894a513b17 [WICKET-7048] AjaxClientInfoBehavior is AJAX timer based. This seems not work

[jira] [Commented] (WICKET-7048) add an AjaxExtendedClientInfoBehavior that makes use of OnDomReady

2023-04-16 Thread Ernesto Reinaldo Barreiro (Jira)
[ https://issues.apache.org/jira/browse/WICKET-7048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712885#comment-17712885 ] Ernesto Reinaldo Barreiro commented on WICKET-7048: --- _It seems timer approach is

[jira] [Updated] (WICKET-7048) add an AjaxExtendedClientInfoBehavior that makes use of OnDomReady

2023-04-16 Thread Ernesto Reinaldo Barreiro (Jira)
[ https://issues.apache.org/jira/browse/WICKET-7048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ernesto Reinaldo Barreiro updated WICKET-7048: -- Summary: add an AjaxExtendedClientInfoBehavior that makes use of

[jira] [Commented] (WICKET-7048) add an AjaxExtendedClientInfoBehavior that makes RequestCycleSettings#getGatherExtendedBrowserInfo() obsolete

2023-04-16 Thread Ernesto Reinaldo Barreiro (Jira)
[ https://issues.apache.org/jira/browse/WICKET-7048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712882#comment-17712882 ] Ernesto Reinaldo Barreiro commented on WICKET-7048: --- Hum...  

[jira] [Updated] (WICKET-7048) add an AjaxExtendedClientInfoBehavior that makes RequestCycleSettings#getGatherExtendedBrowserInfo() obsolete

2023-04-16 Thread Ernesto Reinaldo Barreiro (Jira)
[ https://issues.apache.org/jira/browse/WICKET-7048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ernesto Reinaldo Barreiro updated WICKET-7048: -- Attachment: image-2023-04-17-07-18-56-191.png > add an

[jira] [Created] (WICKET-7048) add an AjaxExtendedClientInfoBehavior that makes RequestCycleSettings#getGatherExtendedBrowserInfo() obsolete

2023-04-16 Thread Ernesto Reinaldo Barreiro (Jira)
Ernesto Reinaldo Barreiro created WICKET-7048: - Summary: add an AjaxExtendedClientInfoBehavior that makes RequestCycleSettings#getGatherExtendedBrowserInfo() obsolete Key: WICKET-7048 URL:

[jira] [Commented] (WICKET-7033) add support to uploading to a resource

2023-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WICKET-7033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712873#comment-17712873 ] ASF GitHub Bot commented on WICKET-7033: reiern70 commented on code in PR #571: URL:

[GitHub] [wicket] reiern70 commented on a diff in pull request #571: [WICKET-7033] upload to a mounted resource

2023-04-16 Thread via GitHub
reiern70 commented on code in PR #571: URL: https://github.com/apache/wicket/pull/571#discussion_r1168125179 ## wicket-core/src/main/java/org/apache/wicket/markup/html/form/upload/resource/AbstractFileUploadResource.java: ## @@ -0,0 +1,223 @@ +/* + * Licensed to the Apache

[jira] [Commented] (WICKET-7033) add support to uploading to a resource

2023-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WICKET-7033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712871#comment-17712871 ] ASF GitHub Bot commented on WICKET-7033: solomax commented on code in PR #571: URL:

[GitHub] [wicket] solomax commented on a diff in pull request #571: [WICKET-7033] upload to a mounted resource

2023-04-16 Thread via GitHub
solomax commented on code in PR #571: URL: https://github.com/apache/wicket/pull/571#discussion_r1168122329 ## wicket-core/src/main/java/org/apache/wicket/markup/html/form/upload/resource/AbstractFileUploadResource.java: ## @@ -0,0 +1,223 @@ +/* + * Licensed to the Apache

[jira] [Commented] (WICKET-7047) Improve initial buffer capacity for Strings.toMultilineMarkup

2023-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WICKET-7047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712847#comment-17712847 ] ASF GitHub Bot commented on WICKET-7047: solomax commented on code in PR #579: URL:

[GitHub] [wicket] solomax commented on a diff in pull request #579: WICKET-7047 Improve initial buffer capacity for multiline-markup

2023-04-16 Thread via GitHub
solomax commented on code in PR #579: URL: https://github.com/apache/wicket/pull/579#discussion_r1168071368 ## wicket-util/src/main/java/org/apache/wicket/util/string/Strings.java: ## @@ -1089,7 +1089,7 @@ public static CharSequence toMultilineMarkup(final CharSequence s)

[wicket] branch 8x created (now a0f54d59ba)

2023-04-16 Thread adelbene
This is an automated email from the ASF dual-hosted git repository. adelbene pushed a change to branch 8x in repository https://gitbox.apache.org/repos/asf/wicket.git at a0f54d59ba [WICKET-7044] guide images are fixed (#575) No new revisions were added by this update.

[jira] [Commented] (WICKET-7047) Improve initial buffer capacity for Strings.toMultilineMarkup

2023-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WICKET-7047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712788#comment-17712788 ] ASF GitHub Bot commented on WICKET-7047: theigl opened a new pull request, #579: URL:

[GitHub] [wicket] theigl opened a new pull request, #579: WICKET-7047 Improve initial buffer capacity for multiline-markup

2023-04-16 Thread via GitHub
theigl opened a new pull request, #579: URL: https://github.com/apache/wicket/pull/579 This PR initializes the string buffer for Strings#toMultilineMarkup to a capacity that should avoid resizing the buffer in most cases. https://issues.apache.org/jira/browse/WICKET-7047 -- This

[jira] [Created] (WICKET-7047) Improve initial buffer capacity for Strings.toMultilineMarkup

2023-04-16 Thread Thomas Heigl (Jira)
Thomas Heigl created WICKET-7047: Summary: Improve initial buffer capacity for Strings.toMultilineMarkup Key: WICKET-7047 URL: https://issues.apache.org/jira/browse/WICKET-7047 Project: Wicket

[jira] [Commented] (WICKET-7046) Avoid allocating StringResponse when no response filters are active

2023-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WICKET-7046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712785#comment-17712785 ] ASF GitHub Bot commented on WICKET-7046: theigl opened a new pull request, #578: URL:

[jira] [Created] (WICKET-7046) Avoid allocating StringResponse when no response filters are active

2023-04-16 Thread Thomas Heigl (Jira)
Thomas Heigl created WICKET-7046: Summary: Avoid allocating StringResponse when no response filters are active Key: WICKET-7046 URL: https://issues.apache.org/jira/browse/WICKET-7046 Project: Wicket

[jira] [Commented] (WICKET-7045) Avoid allocations in PageParameters.getNamedKeys

2023-04-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/WICKET-7045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17712765#comment-17712765 ] ASF GitHub Bot commented on WICKET-7045: theigl opened a new pull request, #577: URL:

[GitHub] [wicket] theigl opened a new pull request, #577: WICKET-7045 PageParameter optimizations

2023-04-16 Thread via GitHub
theigl opened a new pull request, #577: URL: https://github.com/apache/wicket/pull/577 This PR avoids creating a `TreeSet` in `PageParameters.getNamedKeys()` when we do not actually need the contents of the set. The empty check is 50x faster. The contains check is 5-10x faster for

[jira] [Created] (WICKET-7045) Avoid allocations in PageParameters.getNamedKeys

2023-04-16 Thread Thomas Heigl (Jira)
Thomas Heigl created WICKET-7045: Summary: Avoid allocations in PageParameters.getNamedKeys Key: WICKET-7045 URL: https://issues.apache.org/jira/browse/WICKET-7045 Project: Wicket Issue