[GitHub] [airflow] jaketf commented on issue #6210: [AIRFLOW-5567] BaseAsyncOperator

2019-10-17 Thread GitBox
jaketf commented on issue #6210: [AIRFLOW-5567] BaseAsyncOperator URL: https://github.com/apache/airflow/pull/6210#issuecomment-543467902 @JonnyIncognito I'm a gcp-er don't have aws access. This is an automated message from

[GitHub] [airflow] seelmann commented on a change in pull request #6210: [AIRFLOW-5567] BaseAsyncOperator

2019-10-17 Thread GitBox
seelmann commented on a change in pull request #6210: [AIRFLOW-5567] BaseAsyncOperator URL: https://github.com/apache/airflow/pull/6210#discussion_r336318983 ## File path: airflow/models/base_async_operator.py ## @@ -0,0 +1,161 @@ +# -*- coding: utf-8 -*- +# +# Licensed

[GitHub] [airflow] frankcash commented on issue #6360: [AIRFLOW-XXXX] Include code tags for sample file names

2019-10-17 Thread GitBox
frankcash commented on issue #6360: [AIRFLOW-] Include code tags for sample file names URL: https://github.com/apache/airflow/pull/6360#issuecomment-543465011 Thank you  This is an automated message from the Apache Git

[GitHub] [airflow] OmerJog commented on issue #5813: [AIRFLOW-4526] KubernetesPodOperator gets stuck in Running state when get_logs is set to True and there is a long gap without logs from pod

2019-10-17 Thread GitBox
OmerJog commented on issue #5813: [AIRFLOW-4526] KubernetesPodOperator gets stuck in Running state when get_logs is set to True and there is a long gap without logs from pod URL: https://github.com/apache/airflow/pull/5813#issuecomment-543019794 @thealmightygrant The tests are failing

[GitHub] [airflow] potiuk commented on issue #6285: [AIRFLOW-XXX] Updates to Breeze documentation from GSOD

2019-10-17 Thread GitBox
potiuk commented on issue #6285: [AIRFLOW-XXX] Updates to Breeze documentation from GSOD URL: https://github.com/apache/airflow/pull/6285#issuecomment-543028818 But @mik-laj is not joking @feluelle. He indeed has a twin brother who looks exactly like him. We have not met him yet (we think

[GitHub] [airflow] OmerJog commented on issue #6355: [AIRFLOW-5685] Loading AVRO file from GCS to BQ throwing ValueError

2019-10-17 Thread GitBox
OmerJog commented on issue #6355: [AIRFLOW-5685] Loading AVRO file from GCS to BQ throwing ValueError URL: https://github.com/apache/airflow/pull/6355#issuecomment-543019119 If there is an error and test passed when support for AVRO was added then something is missing in the test isn't

[GitHub] [airflow] potiuk commented on issue #6285: [AIRFLOW-XXX] Updates to Breeze documentation from GSOD

2019-10-17 Thread GitBox
potiuk commented on issue #6285: [AIRFLOW-XXX] Updates to Breeze documentation from GSOD URL: https://github.com/apache/airflow/pull/6285#issuecomment-543027111 No mistery herr. It's my other GitHub account I use for testing what other users can see in GitHub, if they have not the same

[GitHub] [airflow] shaikshakeel commented on a change in pull request #5694: [AIRFLOW-5082] add subject in aws sns hook

2019-10-17 Thread GitBox
shaikshakeel commented on a change in pull request #5694: [AIRFLOW-5082] add subject in aws sns hook URL: https://github.com/apache/airflow/pull/5694#discussion_r335828794 ## File path: tests/contrib/hooks/test_aws_sns_hook.py ## @@ -42,9 +42,10 @@ def

[GitHub] [airflow] OmerJog commented on issue #6007: Improved and Fixed Apache Glue hook/operator/sensor from [AIRFLOW-2310]

2019-10-17 Thread GitBox
OmerJog commented on issue #6007: Improved and Fixed Apache Glue hook/operator/sensor from [AIRFLOW-2310] URL: https://github.com/apache/airflow/pull/6007#issuecomment-543020804 @mik-laj @ashb can review? You started review on the previous stale PR

[GitHub] [airflow] jaketf commented on a change in pull request #6210: [AIRFLOW-5567] BaseAsyncOperator

2019-10-17 Thread GitBox
jaketf commented on a change in pull request #6210: [AIRFLOW-5567] BaseAsyncOperator URL: https://github.com/apache/airflow/pull/6210#discussion_r336285752 ## File path: airflow/models/base_async_operator.py ## @@ -0,0 +1,161 @@ +# -*- coding: utf-8 -*- +# +# Licensed to

[GitHub] [airflow] jaketf commented on a change in pull request #6210: [AIRFLOW-5567] BaseAsyncOperator

2019-10-17 Thread GitBox
jaketf commented on a change in pull request #6210: [AIRFLOW-5567] BaseAsyncOperator URL: https://github.com/apache/airflow/pull/6210#discussion_r336285919 ## File path: airflow/models/base_async_operator.py ## @@ -0,0 +1,161 @@ +# -*- coding: utf-8 -*- +# +# Licensed to

[GitHub] [airflow] jaketf commented on a change in pull request #6210: [AIRFLOW-5567] BaseAsyncOperator

2019-10-17 Thread GitBox
jaketf commented on a change in pull request #6210: [AIRFLOW-5567] BaseAsyncOperator URL: https://github.com/apache/airflow/pull/6210#discussion_r336286276 ## File path: tests/models/test_base_async_operator.py ## @@ -0,0 +1,288 @@ +# -*- coding: utf-8 -*- +# +# Licensed

[GitHub] [airflow] dstandish commented on issue #6163: [AIRFLOW-4574] SSHHook private_key may only be supplied in extras

2019-10-17 Thread GitBox
dstandish commented on issue #6163: [AIRFLOW-4574] SSHHook private_key may only be supplied in extras URL: https://github.com/apache/airflow/pull/6163#issuecomment-543435917 > I am sorry that I missed this PR earlier. no worries > In the next PR I would like to divide the

[GitHub] [airflow] dstandish commented on a change in pull request #6210: [AIRFLOW-5567] BaseAsyncOperator

2019-10-17 Thread GitBox
dstandish commented on a change in pull request #6210: [AIRFLOW-5567] BaseAsyncOperator URL: https://github.com/apache/airflow/pull/6210#discussion_r336287664 ## File path: airflow/models/base_async_operator.py ## @@ -0,0 +1,161 @@ +# -*- coding: utf-8 -*- +# +# Licensed

[jira] [Assigned] (AIRFLOW-5648) Add ClearTaskOperator to allow clearing/re-running tasks from within a DAG

2019-10-17 Thread Qian Yu (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qian Yu reassigned AIRFLOW-5648: Assignee: Qian Yu > Add ClearTaskOperator to allow clearing/re-running tasks from within a DAG

[GitHub] [airflow] JonnyIncognito commented on a change in pull request #6210: [AIRFLOW-5567] BaseAsyncOperator

2019-10-17 Thread GitBox
JonnyIncognito commented on a change in pull request #6210: [AIRFLOW-5567] BaseAsyncOperator URL: https://github.com/apache/airflow/pull/6210#discussion_r336291080 ## File path: airflow/models/base_async_operator.py ## @@ -0,0 +1,161 @@ +# -*- coding: utf-8 -*- +# +#

[GitHub] [airflow] ToxaZ commented on issue #6336: [AIRFLOW-5073] Change SQLSensor to optionally treat NULL as keep poking

2019-10-17 Thread GitBox
ToxaZ commented on issue #6336: [AIRFLOW-5073] Change SQLSensor to optionally treat NULL as keep poking URL: https://github.com/apache/airflow/pull/6336#issuecomment-543188183 bump Looks like CI issues does not belong to my PR

[GitHub] [airflow] ashb merged pull request #6357: Revert "AIRFLOW-5608: Fix bug in SchedulerJob when calling executor.end"

2019-10-17 Thread GitBox
ashb merged pull request #6357: Revert "AIRFLOW-5608: Fix bug in SchedulerJob when calling executor.end" URL: https://github.com/apache/airflow/pull/6357 This is an automated message from the Apache Git Service. To respond

[jira] [Commented] (AIRFLOW-5608) Scheduler not shutting down executor(s) gracefully

2019-10-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16953821#comment-16953821 ] ASF GitHub Bot commented on AIRFLOW-5608: - ashb commented on pull request #6357: Revert

[jira] [Created] (AIRFLOW-5687) Upgrade pip to 19.0.2

2019-10-17 Thread Kaxil Naik (Jira)
Kaxil Naik created AIRFLOW-5687: --- Summary: Upgrade pip to 19.0.2 Key: AIRFLOW-5687 URL: https://issues.apache.org/jira/browse/AIRFLOW-5687 Project: Apache Airflow Issue Type: Improvement

[jira] [Comment Edited] (AIRFLOW-4431) Gantt chart tab do not showing

2019-10-17 Thread Diederik Perdok (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-4431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16948337#comment-16948337 ] Diederik Perdok edited comment on AIRFLOW-4431 at 10/17/19 3:39 PM:

[jira] [Commented] (AIRFLOW-5687) Upgrade pip to 19.0.2

2019-10-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16953827#comment-16953827 ] ASF GitHub Bot commented on AIRFLOW-5687: - kaxil commented on pull request #6358:

[jira] [Commented] (AIRFLOW-5608) Scheduler not shutting down executor(s) gracefully

2019-10-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16953822#comment-16953822 ] ASF subversion and git services commented on AIRFLOW-5608: -- Commit

[GitHub] [airflow] codecov-io commented on issue #6321: [AIRFLOW-5649] Skips some tests for non relevant changes

2019-10-17 Thread GitBox
codecov-io commented on issue #6321: [AIRFLOW-5649] Skips some tests for non relevant changes URL: https://github.com/apache/airflow/pull/6321#issuecomment-543213812 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6321?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #6321: [AIRFLOW-5649] Skips some tests for non relevant changes

2019-10-17 Thread GitBox
codecov-io edited a comment on issue #6321: [AIRFLOW-5649] Skips some tests for non relevant changes URL: https://github.com/apache/airflow/pull/6321#issuecomment-543213812 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6321?src=pr=h1) Report > Merging

[GitHub] [airflow] codecov-io edited a comment on issue #6321: [AIRFLOW-5649] Skips some tests for non relevant changes

2019-10-17 Thread GitBox
codecov-io edited a comment on issue #6321: [AIRFLOW-5649] Skips some tests for non relevant changes URL: https://github.com/apache/airflow/pull/6321#issuecomment-543213812 # [Codecov](https://codecov.io/gh/apache/airflow/pull/6321?src=pr=h1) Report > Merging

[jira] [Commented] (AIRFLOW-5687) Upgrade pip to 19.0.2

2019-10-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16953826#comment-16953826 ] ASF subversion and git services commented on AIRFLOW-5687: -- Commit

[GitHub] [airflow] kaxil opened a new pull request #6358: [AIRFLOW-5687] Upgrade pip to 19.0.2

2019-10-17 Thread GitBox
kaxil opened a new pull request #6358: [AIRFLOW-5687] Upgrade pip to 19.0.2 URL: https://github.com/apache/airflow/pull/6358 Make sure you have checked _all_ steps below. ### Jira - [ ] My PR addresses the following [Airflow

[GitHub] [airflow] dgorelik opened a new pull request #6359: [AIRFLOW-XXX] Change instances "Google cloud storage" to "Google Cloud Storage".

2019-10-17 Thread GitBox
dgorelik opened a new pull request #6359: [AIRFLOW-XXX] Change instances "Google cloud storage" to "Google Cloud Storage". URL: https://github.com/apache/airflow/pull/6359 GCS should be formatted as "Google Cloud Storage", so change instances "Google cloud storage" to "Google Cloud

[GitHub] [airflow] ashb commented on issue #6358: [AIRFLOW-5687] Upgrade pip to 19.0.2

2019-10-17 Thread GitBox
ashb commented on issue #6358: [AIRFLOW-5687] Upgrade pip to 19.0.2 URL: https://github.com/apache/airflow/pull/6358#issuecomment-543229473 Do we need to remove the pep517 flag too? This is an automated message from the

[GitHub] [airflow] potiuk commented on a change in pull request #6321: [AIRFLOW-5649] Skips some tests for non relevant changes

2019-10-17 Thread GitBox
potiuk commented on a change in pull request #6321: [AIRFLOW-5649] Skips some tests for non relevant changes URL: https://github.com/apache/airflow/pull/6321#discussion_r335939221 ## File path: scripts/ci/_utils.sh ## @@ -910,15 +927,39 @@ function build_image_on_ci() {

[GitHub] [airflow] ashb commented on a change in pull request #6182: [AIRFLOW-3877] -Changing full file path in scheduler

2019-10-17 Thread GitBox
ashb commented on a change in pull request #6182: [AIRFLOW-3877] -Changing full file path in scheduler URL: https://github.com/apache/airflow/pull/6182#discussion_r335942699 ## File path: airflow/jobs/scheduler_job.py ## @@ -1092,7 +1099,7 @@ def

[GitHub] [airflow] feluelle commented on a change in pull request #5755: [AIRFLOW-4568] Add unallowed_states to ExternalTaskSensor

2019-10-17 Thread GitBox
feluelle commented on a change in pull request #5755: [AIRFLOW-4568] Add unallowed_states to ExternalTaskSensor URL: https://github.com/apache/airflow/pull/5755#discussion_r335899984 ## File path: airflow/sensors/external_task_sensor.py ## @@ -40,6 +40,10 @@ class

[GitHub] [airflow] kaxil commented on a change in pull request #6327: [AIRFLOW-4675] Make airflow/lineage Pylint compatible

2019-10-17 Thread GitBox
kaxil commented on a change in pull request #6327: [AIRFLOW-4675] Make airflow/lineage Pylint compatible URL: https://github.com/apache/airflow/pull/6327#discussion_r335961433 ## File path: airflow/lineage/backend/atlas/__init__.py ## @@ -35,8 +36,8 @@ class

[GitHub] [airflow] kaxil commented on a change in pull request #6327: [AIRFLOW-4675] Make airflow/lineage Pylint compatible

2019-10-17 Thread GitBox
kaxil commented on a change in pull request #6327: [AIRFLOW-4675] Make airflow/lineage Pylint compatible URL: https://github.com/apache/airflow/pull/6327#discussion_r335961117 ## File path: airflow/lineage/backend/__init__.py ## @@ -16,13 +16,12 @@ # specific language

[GitHub] [airflow] ashb commented on a change in pull request #6327: [AIRFLOW-4675] Make airflow/lineage Pylint compatible

2019-10-17 Thread GitBox
ashb commented on a change in pull request #6327: [AIRFLOW-4675] Make airflow/lineage Pylint compatible URL: https://github.com/apache/airflow/pull/6327#discussion_r335964889 ## File path: airflow/lineage/datasets.py ## @@ -104,13 +118,15 @@ def map_type(name): class

[GitHub] [airflow] feluelle commented on a change in pull request #6327: [AIRFLOW-4675] Make airflow/lineage Pylint compatible

2019-10-17 Thread GitBox
feluelle commented on a change in pull request #6327: [AIRFLOW-4675] Make airflow/lineage Pylint compatible URL: https://github.com/apache/airflow/pull/6327#discussion_r335976709 ## File path: airflow/lineage/backend/__init__.py ## @@ -16,13 +16,12 @@ # specific language

[GitHub] [airflow] kaxil commented on a change in pull request #6356: [AIRFLOW-XXX] Changelog for 1.10.6 (rc1)

2019-10-17 Thread GitBox
kaxil commented on a change in pull request #6356: [AIRFLOW-XXX] Changelog for 1.10.6 (rc1) URL: https://github.com/apache/airflow/pull/6356#discussion_r335982190 ## File path: CHANGELOG.txt ## @@ -1,3 +1,134 @@ +Airflow 1.10.6, 2019-10-21 +-- +

[GitHub] [airflow] kaxil commented on a change in pull request #6356: [AIRFLOW-XXX] Changelog for 1.10.6 (rc1)

2019-10-17 Thread GitBox
kaxil commented on a change in pull request #6356: [AIRFLOW-XXX] Changelog for 1.10.6 (rc1) URL: https://github.com/apache/airflow/pull/6356#discussion_r335982474 ## File path: CHANGELOG.txt ## @@ -1,3 +1,134 @@ +Airflow 1.10.6, 2019-10-21 +-- +

[jira] [Commented] (AIRFLOW-5649) Skipping tests for non relevant changes

2019-10-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16953707#comment-16953707 ] ASF GitHub Bot commented on AIRFLOW-5649: - potiuk commented on pull request #6322: [DO NOT

[GitHub] [airflow] ashb commented on a change in pull request #6356: [AIRFLOW-XXX] Changelog for 1.10.6 (rc1)

2019-10-17 Thread GitBox
ashb commented on a change in pull request #6356: [AIRFLOW-XXX] Changelog for 1.10.6 (rc1) URL: https://github.com/apache/airflow/pull/6356#discussion_r335984007 ## File path: CHANGELOG.txt ## @@ -1,3 +1,134 @@ +Airflow 1.10.6, 2019-10-21 +-- +

[GitHub] [airflow] ashb commented on a change in pull request #5755: [AIRFLOW-4568] Add unallowed_states to ExternalTaskSensor

2019-10-17 Thread GitBox
ashb commented on a change in pull request #5755: [AIRFLOW-4568] Add unallowed_states to ExternalTaskSensor URL: https://github.com/apache/airflow/pull/5755#discussion_r335957713 ## File path: airflow/sensors/external_task_sensor.py ## @@ -40,6 +40,10 @@ class

[GitHub] [airflow] ashb commented on a change in pull request #6327: [AIRFLOW-4675] Make airflow/lineage Pylint compatible

2019-10-17 Thread GitBox
ashb commented on a change in pull request #6327: [AIRFLOW-4675] Make airflow/lineage Pylint compatible URL: https://github.com/apache/airflow/pull/6327#discussion_r335963837 ## File path: airflow/lineage/__init__.py ## @@ -108,9 +115,9 @@ def wrapper(self, context,

[GitHub] [airflow] kaxil commented on a change in pull request #6356: [AIRFLOW-XXX] Changelog for 1.10.6 (rc1)

2019-10-17 Thread GitBox
kaxil commented on a change in pull request #6356: [AIRFLOW-XXX] Changelog for 1.10.6 (rc1) URL: https://github.com/apache/airflow/pull/6356#discussion_r335969129 ## File path: CHANGELOG.txt ## @@ -1,3 +1,134 @@ +Airflow 1.10.6, 2019-10-21 +-- +

[GitHub] [airflow] potiuk commented on issue #6321: [AIRFLOW-5649] Skips some tests for non relevant changes

2019-10-17 Thread GitBox
potiuk commented on issue #6321: [AIRFLOW-5649] Skips some tests for non relevant changes URL: https://github.com/apache/airflow/pull/6321#issuecomment-543160176 One drawback of this change is that it will not run tests + pylint in branch pushes (it only run tests when there is a PR).

[GitHub] [airflow] ashb commented on a change in pull request #6182: [AIRFLOW-3877] -Changing full file path in scheduler

2019-10-17 Thread GitBox
ashb commented on a change in pull request #6182: [AIRFLOW-3877] -Changing full file path in scheduler URL: https://github.com/apache/airflow/pull/6182#discussion_r335943262 ## File path: airflow/jobs/scheduler_job.py ## @@ -1092,7 +1099,7 @@ def

[GitHub] [airflow] ashb commented on a change in pull request #6261: [AIRFLOW-5141] Added optional resource usage logging to KubernetesPod…

2019-10-17 Thread GitBox
ashb commented on a change in pull request #6261: [AIRFLOW-5141] Added optional resource usage logging to KubernetesPod… URL: https://github.com/apache/airflow/pull/6261#discussion_r335945777 ## File path: airflow/kubernetes/pod_usage_metrics_logger.py ## @@ -0,0 +1,223

[GitHub] [airflow] ashb commented on a change in pull request #6321: [AIRFLOW-5649] Skips some tests for non relevant changes

2019-10-17 Thread GitBox
ashb commented on a change in pull request #6321: [AIRFLOW-5649] Skips some tests for non relevant changes URL: https://github.com/apache/airflow/pull/6321#discussion_r335955081 ## File path: scripts/ci/_utils.sh ## @@ -910,15 +927,39 @@ function build_image_on_ci() {

[jira] [Commented] (AIRFLOW-5497) dag_processing::list_py_file_paths method pydoc needs param added

2019-10-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16953660#comment-16953660 ] ASF subversion and git services commented on AIRFLOW-5497: -- Commit

[jira] [Commented] (AIRFLOW-4797) Zombie detection and killing is not deterministic

2019-10-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-4797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16953657#comment-16953657 ] ASF subversion and git services commented on AIRFLOW-4797: -- Commit

[jira] [Commented] (AIRFLOW-5130) Use GOOGLE_APPLICATION_CREDENTIALS constant from library

2019-10-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16953663#comment-16953663 ] ASF subversion and git services commented on AIRFLOW-5130: -- Commit

[GitHub] [airflow] feluelle commented on issue #6327: [AIRFLOW-4675] Make airflow/lineage Pylint compatible

2019-10-17 Thread GitBox
feluelle commented on issue #6327: [AIRFLOW-4675] Make airflow/lineage Pylint compatible URL: https://github.com/apache/airflow/pull/6327#issuecomment-543139494 The issue: ``` == 64) FAIL: test_clear

[GitHub] [airflow] kaxil commented on a change in pull request #6356: [AIRFLOW-XXX] Changelog for 1.10.6 (rc1)

2019-10-17 Thread GitBox
kaxil commented on a change in pull request #6356: [AIRFLOW-XXX] Changelog for 1.10.6 (rc1) URL: https://github.com/apache/airflow/pull/6356#discussion_r335967145 ## File path: CHANGELOG.txt ## @@ -1,3 +1,134 @@ +Airflow 1.10.6, 2019-10-21 +-- +

[GitHub] [airflow] kaxil commented on a change in pull request #6356: [AIRFLOW-XXX] Changelog for 1.10.6 (rc1)

2019-10-17 Thread GitBox
kaxil commented on a change in pull request #6356: [AIRFLOW-XXX] Changelog for 1.10.6 (rc1) URL: https://github.com/apache/airflow/pull/6356#discussion_r335982762 ## File path: CHANGELOG.txt ## @@ -1,3 +1,134 @@ +Airflow 1.10.6, 2019-10-21 +-- +

[GitHub] [airflow] kaxil commented on a change in pull request #6356: [AIRFLOW-XXX] Changelog for 1.10.6 (rc1)

2019-10-17 Thread GitBox
kaxil commented on a change in pull request #6356: [AIRFLOW-XXX] Changelog for 1.10.6 (rc1) URL: https://github.com/apache/airflow/pull/6356#discussion_r335982966 ## File path: CHANGELOG.txt ## @@ -1,3 +1,134 @@ +Airflow 1.10.6, 2019-10-21 +-- +

[GitHub] [airflow] kaxil commented on a change in pull request #6182: [AIRFLOW-3877] -Changing full file path in scheduler

2019-10-17 Thread GitBox
kaxil commented on a change in pull request #6182: [AIRFLOW-3877] -Changing full file path in scheduler URL: https://github.com/apache/airflow/pull/6182#discussion_r335985847 ## File path: airflow/jobs/scheduler_job.py ## @@ -1092,7 +1099,7 @@ def

[jira] [Updated] (AIRFLOW-5684) Docker-compose-kubernetes still used by breeze

2019-10-17 Thread Daniel Imberman (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Imberman updated AIRFLOW-5684: - Description: After transitioning to KinD for kubernetes testing, we no longer need the

[GitHub] [airflow] potiuk edited a comment on issue #6321: [AIRFLOW-5649] Skips some tests for non relevant changes

2019-10-17 Thread GitBox
potiuk edited a comment on issue #6321: [AIRFLOW-5649] Skips some tests for non relevant changes URL: https://github.com/apache/airflow/pull/6321#issuecomment-543160176 One side-effect of this change is that it will not run tests + pylint in branch pushes (it only runs tests when there is

[GitHub] [airflow] feluelle commented on a change in pull request #6356: [AIRFLOW-XXX] Changelog for 1.10.6 (rc1)

2019-10-17 Thread GitBox
feluelle commented on a change in pull request #6356: [AIRFLOW-XXX] Changelog for 1.10.6 (rc1) URL: https://github.com/apache/airflow/pull/6356#discussion_r335985718 ## File path: CHANGELOG.txt ## @@ -1,3 +1,134 @@ +Airflow 1.10.6, 2019-10-21 +-- +

[GitHub] [airflow] potiuk edited a comment on issue #6321: [AIRFLOW-5649] Skips some tests for non relevant changes

2019-10-17 Thread GitBox
potiuk edited a comment on issue #6321: [AIRFLOW-5649] Skips some tests for non relevant changes URL: https://github.com/apache/airflow/pull/6321#issuecomment-543160176 One side-effect of this change is that it will not run tests + pylint in branch pushes (it only runs tests when there is

[GitHub] [airflow] potiuk edited a comment on issue #6321: [AIRFLOW-5649] Skips some tests for non relevant changes

2019-10-17 Thread GitBox
potiuk edited a comment on issue #6321: [AIRFLOW-5649] Skips some tests for non relevant changes URL: https://github.com/apache/airflow/pull/6321#issuecomment-543160176 One side-effect of this change is that it will not run tests + pylint in branch pushes (it only run tests when there is

[GitHub] [airflow] potiuk edited a comment on issue #6321: [AIRFLOW-5649] Skips some tests for non relevant changes

2019-10-17 Thread GitBox
potiuk edited a comment on issue #6321: [AIRFLOW-5649] Skips some tests for non relevant changes URL: https://github.com/apache/airflow/pull/6321#issuecomment-543160176 One side-effect of this change is that it will not run tests + pylint in branch pushes (it only runs tests when there is

[jira] [Commented] (AIRFLOW-5608) Scheduler not shutting down executor(s) gracefully

2019-10-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16953740#comment-16953740 ] ASF subversion and git services commented on AIRFLOW-5608: -- Commit

[GitHub] [airflow] ashb opened a new pull request #6357: Revert "AIRFLOW-5608: Fix bug in SchedulerJob when calling executor.end"

2019-10-17 Thread GitBox
ashb opened a new pull request #6357: Revert "AIRFLOW-5608: Fix bug in SchedulerJob when calling executor.end" URL: https://github.com/apache/airflow/pull/6357 Reverts apache/airflow#6274 It caused the LocalExecutor to not shutdown when given a SIGINT with this stack trace.

[jira] [Commented] (AIRFLOW-4908) Implement BigQuery Hooks/Operators for update_dataset, patch_dataset and get_dataset

2019-10-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-4908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16953654#comment-16953654 ] ASF subversion and git services commented on AIRFLOW-4908: -- Commit

[jira] [Commented] (AIRFLOW-5126) Read aws_session_token in extra_config of the aws hook

2019-10-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16953656#comment-16953656 ] ASF subversion and git services commented on AIRFLOW-5126: -- Commit

[jira] [Commented] (AIRFLOW-5459) use a dynamic tmp location in dataflow operator

2019-10-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16953655#comment-16953655 ] ASF subversion and git services commented on AIRFLOW-5459: -- Commit

[jira] [Commented] (AIRFLOW-5459) use a dynamic tmp location in dataflow operator

2019-10-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16953666#comment-16953666 ] ASF subversion and git services commented on AIRFLOW-5459: -- Commit

[jira] [Commented] (AIRFLOW-5126) Read aws_session_token in extra_config of the aws hook

2019-10-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16953667#comment-16953667 ] ASF subversion and git services commented on AIRFLOW-5126: -- Commit

[jira] [Commented] (AIRFLOW-5653) Log caught AirflowSkipException in task instance log

2019-10-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16953659#comment-16953659 ] ASF subversion and git services commented on AIRFLOW-5653: -- Commit

[jira] [Commented] (AIRFLOW-5657) Upgrade dill dependency

2019-10-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16953662#comment-16953662 ] ASF subversion and git services commented on AIRFLOW-5657: -- Commit

[jira] [Commented] (AIRFLOW-5133) Keep original env state in provide_gcp_credential_file

2019-10-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16953664#comment-16953664 ] ASF subversion and git services commented on AIRFLOW-5133: -- Commit

[jira] [Commented] (AIRFLOW-5653) Log caught AirflowSkipException in task instance log

2019-10-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16953658#comment-16953658 ] ASF subversion and git services commented on AIRFLOW-5653: -- Commit

[jira] [Commented] (AIRFLOW-4908) Implement BigQuery Hooks/Operators for update_dataset, patch_dataset and get_dataset

2019-10-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-4908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16953665#comment-16953665 ] ASF subversion and git services commented on AIRFLOW-4908: -- Commit

[GitHub] [airflow] ashb commented on a change in pull request #6327: [AIRFLOW-4675] Make airflow/lineage Pylint compatible

2019-10-17 Thread GitBox
ashb commented on a change in pull request #6327: [AIRFLOW-4675] Make airflow/lineage Pylint compatible URL: https://github.com/apache/airflow/pull/6327#discussion_r335964325 ## File path: airflow/lineage/backend/__init__.py ## @@ -16,13 +16,12 @@ # specific language

[GitHub] [airflow] kaxil commented on a change in pull request #6356: [AIRFLOW-XXX] Changelog for 1.10.6 (rc1)

2019-10-17 Thread GitBox
kaxil commented on a change in pull request #6356: [AIRFLOW-XXX] Changelog for 1.10.6 (rc1) URL: https://github.com/apache/airflow/pull/6356#discussion_r335984477 ## File path: CHANGELOG.txt ## @@ -1,3 +1,134 @@ +Airflow 1.10.6, 2019-10-21 +-- +

[GitHub] [airflow] feluelle commented on a change in pull request #6356: [AIRFLOW-XXX] Changelog for 1.10.6 (rc1)

2019-10-17 Thread GitBox
feluelle commented on a change in pull request #6356: [AIRFLOW-XXX] Changelog for 1.10.6 (rc1) URL: https://github.com/apache/airflow/pull/6356#discussion_r335984291 ## File path: CHANGELOG.txt ## @@ -1,3 +1,134 @@ +Airflow 1.10.6, 2019-10-21 +-- +

[GitHub] [airflow] feluelle commented on a change in pull request #6356: [AIRFLOW-XXX] Changelog for 1.10.6 (rc1)

2019-10-17 Thread GitBox
feluelle commented on a change in pull request #6356: [AIRFLOW-XXX] Changelog for 1.10.6 (rc1) URL: https://github.com/apache/airflow/pull/6356#discussion_r335983637 ## File path: CHANGELOG.txt ## @@ -1,3 +1,134 @@ +Airflow 1.10.6, 2019-10-21 +-- +

[GitHub] [airflow] feluelle commented on a change in pull request #6356: [AIRFLOW-XXX] Changelog for 1.10.6 (rc1)

2019-10-17 Thread GitBox
feluelle commented on a change in pull request #6356: [AIRFLOW-XXX] Changelog for 1.10.6 (rc1) URL: https://github.com/apache/airflow/pull/6356#discussion_r335984077 ## File path: CHANGELOG.txt ## @@ -1,3 +1,134 @@ +Airflow 1.10.6, 2019-10-21 +-- +

[GitHub] [airflow] feluelle commented on a change in pull request #6356: [AIRFLOW-XXX] Changelog for 1.10.6 (rc1)

2019-10-17 Thread GitBox
feluelle commented on a change in pull request #6356: [AIRFLOW-XXX] Changelog for 1.10.6 (rc1) URL: https://github.com/apache/airflow/pull/6356#discussion_r335982970 ## File path: CHANGELOG.txt ## @@ -1,3 +1,134 @@ +Airflow 1.10.6, 2019-10-21 +-- +

[jira] [Commented] (AIRFLOW-5684) Docker-compose-kubernetes still used by breeze

2019-10-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16953714#comment-16953714 ] ASF subversion and git services commented on AIRFLOW-5684: -- Commit

[jira] [Commented] (AIRFLOW-5608) Scheduler not shutting down executor(s) gracefully

2019-10-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16953742#comment-16953742 ] ASF GitHub Bot commented on AIRFLOW-5608: - ashb commented on pull request #6357: Revert

[jira] [Resolved] (AIRFLOW-5608) Scheduler not shutting down executor(s) gracefully

2019-10-17 Thread Ash Berlin-Taylor (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor resolved AIRFLOW-5608. Resolution: Cannot Reproduce And the proposed (and merged, but now unmerged) PR

[jira] [Reopened] (AIRFLOW-5608) Scheduler not shutting down executor(s) gracefully

2019-10-17 Thread Ash Berlin-Taylor (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor reopened AIRFLOW-5608: > Scheduler not shutting down executor(s) gracefully >

[GitHub] [airflow] ashb opened a new pull request #6356: [AIRFLOW-XXX] Changelog for 1.10.6 (rc1)

2019-10-17 Thread GitBox
ashb opened a new pull request #6356: [AIRFLOW-XXX] Changelog for 1.10.6 (rc1) URL: https://github.com/apache/airflow/pull/6356 I have picked a date that is when I plan to end the vote and release it if the vote passes. If it doesn't then we will need to update the Changelog again with

[GitHub] [airflow] ashb commented on a change in pull request #6356: [AIRFLOW-XXX] Changelog for 1.10.6 (rc1)

2019-10-17 Thread GitBox
ashb commented on a change in pull request #6356: [AIRFLOW-XXX] Changelog for 1.10.6 (rc1) URL: https://github.com/apache/airflow/pull/6356#discussion_r335969885 ## File path: CHANGELOG.txt ## @@ -1,3 +1,134 @@ +Airflow 1.10.6, 2019-10-21 +-- +

[GitHub] [airflow] feluelle commented on a change in pull request #6327: [AIRFLOW-4675] Make airflow/lineage Pylint compatible

2019-10-17 Thread GitBox
feluelle commented on a change in pull request #6327: [AIRFLOW-4675] Make airflow/lineage Pylint compatible URL: https://github.com/apache/airflow/pull/6327#discussion_r335973293 ## File path: airflow/lineage/backend/__init__.py ## @@ -16,13 +16,12 @@ # specific language

[GitHub] [airflow] feluelle commented on a change in pull request #6327: [AIRFLOW-4675] Make airflow/lineage Pylint compatible

2019-10-17 Thread GitBox
feluelle commented on a change in pull request #6327: [AIRFLOW-4675] Make airflow/lineage Pylint compatible URL: https://github.com/apache/airflow/pull/6327#discussion_r335973293 ## File path: airflow/lineage/backend/__init__.py ## @@ -16,13 +16,12 @@ # specific language

[GitHub] [airflow] potiuk closed pull request #6322: [DO NOT MERGE] - Test if py change triggers tests after [AIRFLOW-5649]

2019-10-17 Thread GitBox
potiuk closed pull request #6322: [DO NOT MERGE] - Test if py change triggers tests after [AIRFLOW-5649] URL: https://github.com/apache/airflow/pull/6322 This is an automated message from the Apache Git Service. To respond

[GitHub] [airflow] kaxil commented on a change in pull request #6356: [AIRFLOW-XXX] Changelog for 1.10.6 (rc1)

2019-10-17 Thread GitBox
kaxil commented on a change in pull request #6356: [AIRFLOW-XXX] Changelog for 1.10.6 (rc1) URL: https://github.com/apache/airflow/pull/6356#discussion_r335983177 ## File path: CHANGELOG.txt ## @@ -1,3 +1,134 @@ +Airflow 1.10.6, 2019-10-21 +-- +

[GitHub] [airflow] kaxil commented on a change in pull request #6356: [AIRFLOW-XXX] Changelog for 1.10.6 (rc1)

2019-10-17 Thread GitBox
kaxil commented on a change in pull request #6356: [AIRFLOW-XXX] Changelog for 1.10.6 (rc1) URL: https://github.com/apache/airflow/pull/6356#discussion_r335983532 ## File path: CHANGELOG.txt ## @@ -1,3 +1,134 @@ +Airflow 1.10.6, 2019-10-21 +-- +

[GitHub] [airflow] potiuk merged pull request #6353: [AIRFLOW-5684] docker-compose-kubernetes still used

2019-10-17 Thread GitBox
potiuk merged pull request #6353: [AIRFLOW-5684] docker-compose-kubernetes still used URL: https://github.com/apache/airflow/pull/6353 This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (AIRFLOW-5684) Docker-compose-kubernetes still used by breeze

2019-10-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16953712#comment-16953712 ] ASF GitHub Bot commented on AIRFLOW-5684: - potiuk commented on pull request #6353:

[GitHub] [airflow] ashb commented on issue #6274: AIRFLOW-5608: Fix bug in SchedulerJob when calling executor.end

2019-10-17 Thread GitBox
ashb commented on issue #6274: AIRFLOW-5608: Fix bug in SchedulerJob when calling executor.end URL: https://github.com/apache/airflow/pull/6274#issuecomment-543176050 @kpathak13 This PR breaks the Scheduler stopping with LocalExecutor: ``` Traceback (most recent call last):

[jira] [Assigned] (AIRFLOW-5649) Skipping tests for non relevant changes

2019-10-17 Thread Jarek Potiuk (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Potiuk reassigned AIRFLOW-5649: - Assignee: Jarek Potiuk > Skipping tests for non relevant changes >

[jira] [Updated] (AIRFLOW-5675) [BLOCKED][AIRFLOW-5675] rename MLEngineHook to MlEngineHook

2019-10-17 Thread Jira
[ https://issues.apache.org/jira/browse/AIRFLOW-5675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michał Słowikowski updated AIRFLOW-5675: Summary: [BLOCKED][AIRFLOW-5675] rename MLEngineHook to MlEngineHook (was: [has

[jira] [Updated] (AIRFLOW-5675) [BLOCKED][AIRFLOW-5675] rename MLEngineHook to MlEngineHook

2019-10-17 Thread Jira
[ https://issues.apache.org/jira/browse/AIRFLOW-5675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michał Słowikowski updated AIRFLOW-5675: Description: We need confirmation about this name. > [BLOCKED][AIRFLOW-5675]

[jira] [Updated] (AIRFLOW-5675) [has to confirmed by G][AIRFLOW-5675] rename MLEngineHook to MlEngineHook

2019-10-17 Thread Jira
[ https://issues.apache.org/jira/browse/AIRFLOW-5675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michał Słowikowski updated AIRFLOW-5675: Summary: [has to confirmed by G][AIRFLOW-5675] rename MLEngineHook to

[jira] [Commented] (AIRFLOW-5686) Deleting DAG can leave scheduld/queued tasks consuming pool slots

2019-10-17 Thread Ash Berlin-Taylor (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16953595#comment-16953595 ] Ash Berlin-Taylor commented on AIRFLOW-5686: If anyone else runs in to this the workaround

[GitHub] [airflow] ashb commented on a change in pull request #6321: [AIRFLOW-5649] Skips some tests for non relevant changes

2019-10-17 Thread GitBox
ashb commented on a change in pull request #6321: [AIRFLOW-5649] Skips some tests for non relevant changes URL: https://github.com/apache/airflow/pull/6321#discussion_r335923495 ## File path: scripts/ci/_utils.sh ## @@ -910,15 +927,39 @@ function build_image_on_ci() {

  1   2   >