[GitHub] [airflow] kaxil commented on issue #8164: Monkey-patching may also silently lead to incorrect behaviour on Python 3.7

2020-04-06 Thread GitBox
kaxil commented on issue #8164: Monkey-patching may also silently lead to incorrect behaviour on Python 3.7 URL: https://github.com/apache/airflow/issues/8164#issuecomment-609814001 The description is unreadable. Please fix the description and follow issue template

[GitHub] [airflow] codecov-io edited a comment on issue #8008: Custom Facebook Ads Operator

2020-04-06 Thread GitBox
codecov-io edited a comment on issue #8008: Custom Facebook Ads Operator URL: https://github.com/apache/airflow/pull/8008#issuecomment-606854674 # [Codecov](https://codecov.io/gh/apache/airflow/pull/8008?src=pr=h1) Report > Merging

[GitHub] [airflow] zhongjiajie commented on issue #7683: [AIRFLOW-7033] Change dag and task state meanwhile

2020-04-06 Thread GitBox
zhongjiajie commented on issue #7683: [AIRFLOW-7033] Change dag and task state meanwhile URL: https://github.com/apache/airflow/pull/7683#issuecomment-609890826 I almost forget about this PR  This is an automated message

[GitHub] [airflow] mikeclarke commented on issue #7232: [AIRFLOW-6569] Flush pending Sentry exceptions before exiting forked process

2020-04-06 Thread GitBox
mikeclarke commented on issue #7232: [AIRFLOW-6569] Flush pending Sentry exceptions before exiting forked process URL: https://github.com/apache/airflow/pull/7232#issuecomment-609912792 Rebased again, thanks for the heads up.

[GitHub] [airflow] kaxil commented on issue #8156: Security Views broken

2020-04-06 Thread GitBox
kaxil commented on issue #8156: Security Views broken URL: https://github.com/apache/airflow/issues/8156#issuecomment-609814782 Verified this error occurred because of a bug in f8f0bec38 This is an automated message from the

[GitHub] [airflow] dlamblin commented on issue #7549: Add OpenAPI spec

2020-04-06 Thread GitBox
dlamblin commented on issue #7549: Add OpenAPI spec URL: https://github.com/apache/airflow/pull/7549#issuecomment-609834546 I ended up dropping a comment on the wrong PR about this… https://github.com/PolideaInternal/airflow/pull/653#issuecomment-608987368 You did fix most every typo,

[GitHub] [airflow] mik-laj commented on issue #7549: Add OpenAPI spec

2020-04-06 Thread GitBox
mik-laj commented on issue #7549: Add OpenAPI spec URL: https://github.com/apache/airflow/pull/7549#issuecomment-609850635 > You did fix most every typo, but there's still "Encryption and encryption" one case of "aa", another of "a variables" and "an import errors". Can you create

[GitHub] [airflow] mik-laj commented on issue #8120: Guide "How to use REST API"

2020-04-06 Thread GitBox
mik-laj commented on issue #8120: Guide "How to use REST API" URL: https://github.com/apache/airflow/issues/8120#issuecomment-609850229 We should answer the question "How to trigger DAG?" This is an automated message from

[GitHub] [airflow] ashb opened a new pull request #8165: Fix 500 error in Security screens

2020-04-06 Thread GitBox
ashb opened a new pull request #8165: Fix 500 error in Security screens URL: https://github.com/apache/airflow/pull/8165 PR #8046 used our CustomSQLAInterface more widely, and we weren't correctly implementing the interface right in the constructor, which was only a problem for models

[GitHub] [airflow] lucafuji commented on issue #6870: [AIRFLOW-0578] Check return code

2020-04-06 Thread GitBox
lucafuji commented on issue #6870: [AIRFLOW-0578] Check return code URL: https://github.com/apache/airflow/pull/6870#issuecomment-609906756 @ashb Please take a look at this issue https://github.com/apache/airflow/issues/7962 This is exactly why we cannot ignore the exit code of a JOB

[GitHub] [airflow] boring-cyborg[bot] commented on issue #8164: Monkey-patching may also silently lead to incorrect behaviour on Python 3.7

2020-04-06 Thread GitBox
boring-cyborg[bot] commented on issue #8164: Monkey-patching may also silently lead to incorrect behaviour on Python 3.7 URL: https://github.com/apache/airflow/issues/8164#issuecomment-609809840 Thanks for opening your first issue here! Be sure to follow the issue template!

[GitHub] [airflow] tooptoop4 opened a new issue #8164: Monkey-patching may also silently lead to incorrect behaviour on Python 3.7

2020-04-06 Thread GitBox
tooptoop4 opened a new issue #8164: Monkey-patching may also silently lead to incorrect behaviour on Python 3.7 URL: https://github.com/apache/airflow/issues/8164 [2020-04-06 08:58:58 +] [4986] [INFO] Booting worker with pid: 4986

[GitHub] [airflow] codecov-io edited a comment on issue #8008: Custom Facebook Ads Operator

2020-04-06 Thread GitBox
codecov-io edited a comment on issue #8008: Custom Facebook Ads Operator URL: https://github.com/apache/airflow/pull/8008#issuecomment-606854674 # [Codecov](https://codecov.io/gh/apache/airflow/pull/8008?src=pr=h1) Report > Merging

[GitHub] [airflow] zhongjiajie commented on issue #8016: [AIRFLOW-7115] Display the dag owner in the dag view

2020-04-06 Thread GitBox
zhongjiajie commented on issue #8016: [AIRFLOW-7115] Display the dag owner in the dag view URL: https://github.com/apache/airflow/pull/8016#issuecomment-609887862 FYI, I think we should add KEYWORD text `description` before `{{ dag.description }}`, otherwise will be `Owner: ` if

[GitHub] [airflow] codecov-io edited a comment on issue #8008: Custom Facebook Ads Operator

2020-04-06 Thread GitBox
codecov-io edited a comment on issue #8008: Custom Facebook Ads Operator URL: https://github.com/apache/airflow/pull/8008#issuecomment-606854674 # [Codecov](https://codecov.io/gh/apache/airflow/pull/8008?src=pr=h1) Report > Merging

[GitHub] [airflow] kaxil edited a comment on issue #8016: [AIRFLOW-7115] Display the dag owner in the dag view

2020-04-06 Thread GitBox
kaxil edited a comment on issue #8016: [AIRFLOW-7115] Display the dag owner in the dag view URL: https://github.com/apache/airflow/pull/8016#issuecomment-609866268 Can you please create this PR against Master? This PR also just updated to Flask-admin based UI. Also, I don't feel we

[GitHub] [airflow] ashb commented on issue #6870: [AIRFLOW-0578] Check return code

2020-04-06 Thread GitBox
ashb commented on issue #6870: [AIRFLOW-0578] Check return code URL: https://github.com/apache/airflow/pull/6870#issuecomment-609911766 @lucafuji that is the same Jira we've been talking about, just migrated to GitHub issue.

[GitHub] [airflow] mik-laj commented on issue #8163: Google `Credentials` object has not attribute `with_subject`

2020-04-06 Thread GitBox
mik-laj commented on issue #8163: Google `Credentials` object has not attribute `with_subject` URL: https://github.com/apache/airflow/issues/8163#issuecomment-609843452 I'm afraid this problem may be a little more complex. ``google.auth.default()`` supports 4 methods of authentication

[GitHub] [airflow] mik-laj edited a comment on issue #8163: Google `Credentials` object has not attribute `with_subject`

2020-04-06 Thread GitBox
mik-laj edited a comment on issue #8163: Google `Credentials` object has not attribute `with_subject` URL: https://github.com/apache/airflow/issues/8163#issuecomment-609843452 I'm afraid this problem may be a little more complex. ``google.auth.default()`` supports 4 methods of

[GitHub] [airflow] codecov-io edited a comment on issue #7133: [AIRFLOW-6535] add exception to fail without retry

2020-04-06 Thread GitBox
codecov-io edited a comment on issue #7133: [AIRFLOW-6535] add exception to fail without retry URL: https://github.com/apache/airflow/pull/7133#issuecomment-573236471 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7133?src=pr=h1) Report > Merging

[GitHub] [airflow] kaxil commented on issue #8016: [AIRFLOW-7115] Display the dag owner in the dag view

2020-04-06 Thread GitBox
kaxil commented on issue #8016: [AIRFLOW-7115] Display the dag owner in the dag view URL: https://github.com/apache/airflow/pull/8016#issuecomment-609866268 Can you please create this PR against Master? This PR also just updated to Flask-admin based UI. Also, I don't feel we should

[GitHub] [airflow] kaxil closed issue #8156: Security Views broken

2020-04-06 Thread GitBox
kaxil closed issue #8156: Security Views broken URL: https://github.com/apache/airflow/issues/8156 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] kaxil merged pull request #8165: Fix 500 error in Security screens

2020-04-06 Thread GitBox
kaxil merged pull request #8165: Fix 500 error in Security screens URL: https://github.com/apache/airflow/pull/8165 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [airflow] zhongjiajie commented on issue #8016: [AIRFLOW-7115] Display the dag owner in the dag view

2020-04-06 Thread GitBox
zhongjiajie commented on issue #8016: [AIRFLOW-7115] Display the dag owner in the dag view URL: https://github.com/apache/airflow/pull/8016#issuecomment-609888638 And I agree with kaxil point about that. > Also, I don't feel we should add "Owner" info too. It is on the HomePage, that

[GitHub] [airflow] ashb commented on issue #8166: Task Duration Bug: Doesn't respect number of runs

2020-04-06 Thread GitBox
ashb commented on issue #8166: Task Duration Bug: Doesn't respect number of runs URL: https://github.com/apache/airflow/issues/8166#issuecomment-609933107 I've confirmed that this is caused by manually triggered runs, and the same behaviour has existed since 1.10.3 (the earliest version I

[GitHub] [airflow] ashb commented on issue #8166: Task Duration Bug: Doesn't respect number of runs

2020-04-06 Thread GitBox
ashb commented on issue #8166: Task Duration Bug: Doesn't respect number of runs URL: https://github.com/apache/airflow/issues/8166#issuecomment-609948129 If you are able to provide me with a dump of your `dag` and `task_instance` tables (or the whole DB apart from connections and

[GitHub] [airflow] kaxil opened a new issue #8166: Task Duration Bug: Doesn't respect number of runs

2020-04-06 Thread GitBox
kaxil opened a new issue #8166: Task Duration Bug: Doesn't respect number of runs URL: https://github.com/apache/airflow/issues/8166 The "number of runs" is set to 5, however, there's a month worth of taskinstances on this plot. It used to be exactly 5 dots in the previous versions. I

[GitHub] [airflow] kaxil commented on issue #8166: Task Duration Bug: Doesn't respect number of runs

2020-04-06 Thread GitBox
kaxil commented on issue #8166: Task Duration Bug: Doesn't respect number of runs URL: https://github.com/apache/airflow/issues/8166#issuecomment-609978249 > Although this is not a regression in 1.10.10, the issue is still here, so shouldn't the bug be kept open? Oops yes, I will

[GitHub] [airflow] KostyaEsmukov commented on issue #8166: Task Duration Bug: Doesn't respect number of runs

2020-04-06 Thread GitBox
KostyaEsmukov commented on issue #8166: Task Duration Bug: Doesn't respect number of runs URL: https://github.com/apache/airflow/issues/8166#issuecomment-609977479 Although this is not a regression in 1.10.10, the issue is still here, so shouldn't the bug be kept open?

[jira] [Closed] (AIRFLOW-5776) Migrate AWS Cloudwatch logs to /providers/aws [AIP-21]

2020-04-06 Thread Kamil Bregula (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamil Bregula closed AIRFLOW-5776. -- Resolution: Fixed > Migrate AWS Cloudwatch logs to /providers/aws [AIP-21] >

[jira] [Closed] (AIRFLOW-5779) Migrate AWS EMR to /providers/aws [AIP-21]

2020-04-06 Thread Kamil Bregula (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamil Bregula closed AIRFLOW-5779. -- Resolution: Fixed > Migrate AWS EMR to /providers/aws [AIP-21] >

[jira] [Closed] (AIRFLOW-5778) Migrate AWS ECS to /providers/aws [AIP-21]

2020-04-06 Thread Kamil Bregula (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamil Bregula closed AIRFLOW-5778. -- Resolution: Fixed > Migrate AWS ECS to /providers/aws [AIP-21] >

[jira] [Closed] (AIRFLOW-5790) Migrate AwsHook to /providers/aws

2020-04-06 Thread Kamil Bregula (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamil Bregula closed AIRFLOW-5790. -- Resolution: Fixed > Migrate AwsHook to /providers/aws > - >

[jira] [Closed] (AIRFLOW-3920) Moving everything out of contrib

2020-04-06 Thread Kamil Bregula (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-3920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamil Bregula closed AIRFLOW-3920. -- Resolution: Fixed > Moving everything out of contrib > > >

[jira] [Closed] (AIRFLOW-5784) Migrate AWS S3 to /providers/aws [AIP-21]

2020-04-06 Thread Kamil Bregula (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-5784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamil Bregula closed AIRFLOW-5784. -- Resolution: Fixed > Migrate AWS S3 to /providers/aws [AIP-21] >

[GitHub] [airflow] jmcarp commented on issue #8145: Drop redundant project id null checks.

2020-04-06 Thread GitBox
jmcarp commented on issue #8145: Drop redundant project id null checks. URL: https://github.com/apache/airflow/pull/8145#issuecomment-609978516 I don't know if we can programmatically audit use of the plugin, but the number of decorators is small and shouldn't change often, and it's simple

[GitHub] [airflow] codecov-io edited a comment on issue #7232: [AIRFLOW-6569] Flush pending Sentry exceptions before exiting forked process

2020-04-06 Thread GitBox
codecov-io edited a comment on issue #7232: [AIRFLOW-6569] Flush pending Sentry exceptions before exiting forked process URL: https://github.com/apache/airflow/pull/7232#issuecomment-581760360 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7232?src=pr=h1) Report > Merging

svn commit: r38826 - /dev/airflow/1.10.10rc4/

2020-04-06 Thread kaxilnaik
Author: kaxilnaik Date: Mon Apr 6 19:18:33 2020 New Revision: 38826 Log: Add artifacts for Airflow 1.10.10rc4 Added: dev/airflow/1.10.10rc4/ dev/airflow/1.10.10rc4/apache-airflow-1.10.10rc4-bin.tar.gz (with props) dev/airflow/1.10.10rc4/apache-airflow-1.10.10rc4-bin.tar.gz.asc

[GitHub] [airflow] kaxil opened a new issue #8166: Task Duration Bug: Doesn't respect number of runs

2020-04-06 Thread GitBox
kaxil opened a new issue #8166: Task Duration Bug: Doesn't respect number of runs URL: https://github.com/apache/airflow/issues/8166 The "number of runs" is set to 5, however, there's a month worth of taskinstances on this plot. It used to be exactly 5 dots in the previous versions. I

[GitHub] [airflow] ashb commented on issue #8166: Task Duration Bug: Doesn't respect number of runs

2020-04-06 Thread GitBox
ashb commented on issue #8166: Task Duration Bug: Doesn't respect number of runs URL: https://github.com/apache/airflow/issues/8166#issuecomment-609928211 I can't reproduce this on 1.10.10rc3 - it does change the number of runs shown @KostyaEsmukov. Do you have a large number of

[GitHub] [airflow] KostyaEsmukov commented on issue #8166: Task Duration Bug: Doesn't respect number of runs

2020-04-06 Thread GitBox
KostyaEsmukov commented on issue #8166: Task Duration Bug: Doesn't respect number of runs URL: https://github.com/apache/airflow/issues/8166#issuecomment-609945484 > I've confirmed that this is caused by manually triggered runs, Could you please elaborate on what exactly do you mean

[GitHub] [airflow] KostyaEsmukov commented on issue #8166: Task Duration Bug: Doesn't respect number of runs

2020-04-06 Thread GitBox
KostyaEsmukov commented on issue #8166: Task Duration Bug: Doesn't respect number of runs URL: https://github.com/apache/airflow/issues/8166#issuecomment-609966613 I took a dag with 5 minutes interval (not the one on the pictures). And the reason for it generating way more points

[GitHub] [airflow] KostyaEsmukov commented on issue #8166: Task Duration Bug: Doesn't respect number of runs

2020-04-06 Thread GitBox
KostyaEsmukov commented on issue #8166: Task Duration Bug: Doesn't respect number of runs URL: https://github.com/apache/airflow/issues/8166#issuecomment-609970430 Looks like it is related to dag serialization: ``` >>> dagbag = models.DagBag(settings.DAGS_FOLDER,

[GitHub] [airflow] kaxil closed issue #8166: Task Duration Bug: Doesn't respect number of runs

2020-04-06 Thread GitBox
kaxil closed issue #8166: Task Duration Bug: Doesn't respect number of runs URL: https://github.com/apache/airflow/issues/8166 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [airflow] KostyaEsmukov commented on issue #8166: Task Duration Bug: Doesn't respect number of runs

2020-04-06 Thread GitBox
KostyaEsmukov commented on issue #8166: Task Duration Bug: Doesn't respect number of runs URL: https://github.com/apache/airflow/issues/8166#issuecomment-609948724 I'm sorry but I cannot do that. I'll try myself This is an

[GitHub] [airflow] KostyaEsmukov commented on issue #8166: Task Duration Bug: Doesn't respect number of runs

2020-04-06 Thread GitBox
KostyaEsmukov commented on issue #8166: Task Duration Bug: Doesn't respect number of runs URL: https://github.com/apache/airflow/issues/8166#issuecomment-609974284 Okay, I guess I found out why they desynchronize: - serialized dag calls DAG's inititalizer with default daily timedelta:

[GitHub] [airflow] kaxil commented on issue #8166: Task Duration Bug: Doesn't respect number of runs

2020-04-06 Thread GitBox
kaxil commented on issue #8166: Task Duration Bug: Doesn't respect number of runs URL: https://github.com/apache/airflow/issues/8166#issuecomment-609975804 Thanks for confirming and digging into it. This is an automated

[GitHub] [airflow] codecov-io commented on issue #8155: Fix tests and documentation for CLI 'connections add'

2020-04-06 Thread GitBox
codecov-io commented on issue #8155: Fix tests and documentation for CLI 'connections add' URL: https://github.com/apache/airflow/pull/8155#issuecomment-609996696 # [Codecov](https://codecov.io/gh/apache/airflow/pull/8155?src=pr=h1) Report > Merging

[GitHub] [airflow] eladkal opened a new pull request #8167: add PrestoOperator

2020-04-06 Thread GitBox
eladkal opened a new pull request #8167: add PrestoOperator URL: https://github.com/apache/airflow/pull/8167 --- Make sure to mark the boxes below before creating PR: [x] - [x] Description above provides context of the change - [x] Unit tests coverage for changes (not needed

[GitHub] [airflow] mik-laj commented on a change in pull request #8008: Custom Facebook Ads Operator

2020-04-06 Thread GitBox
mik-laj commented on a change in pull request #8008: Custom Facebook Ads Operator URL: https://github.com/apache/airflow/pull/8008#discussion_r404420761 ## File path: airflow/providers/facebook/ads/operators/ads.py ## @@ -0,0 +1,119 @@ +# +# Licensed to the Apache

[GitHub] [airflow] mik-laj commented on a change in pull request #8008: Custom Facebook Ads Operator

2020-04-06 Thread GitBox
mik-laj commented on a change in pull request #8008: Custom Facebook Ads Operator URL: https://github.com/apache/airflow/pull/8008#discussion_r404426263 ## File path: docs/operators-and-hooks-ref.rst ## @@ -1014,6 +1014,12 @@ These integrations allow you to perform

[GitHub] [airflow] mik-laj commented on a change in pull request #8167: add PrestoOperator

2020-04-06 Thread GitBox
mik-laj commented on a change in pull request #8167: add PrestoOperator URL: https://github.com/apache/airflow/pull/8167#discussion_r404347048 ## File path: airflow/providers/presto/operators/presto.py ## @@ -0,0 +1,71 @@ +# +# Licensed to the Apache Software Foundation

[GitHub] [airflow] KostyaEsmukov commented on issue #8166: Task Duration Bug: Doesn't respect number of runs

2020-04-06 Thread GitBox
KostyaEsmukov commented on issue #8166: Task Duration Bug: Doesn't respect number of runs URL: https://github.com/apache/airflow/issues/8166#issuecomment-610005896 The following little (but dirty) patch fixes the issue for me: ``` diff --git

[GitHub] [airflow] mik-laj commented on a change in pull request #8008: Custom Facebook Ads Operator

2020-04-06 Thread GitBox
mik-laj commented on a change in pull request #8008: Custom Facebook Ads Operator URL: https://github.com/apache/airflow/pull/8008#discussion_r404424465 ## File path: airflow/providers/facebook/ads/operators/ads.py ## @@ -0,0 +1,119 @@ +# Review comment: The file

[GitHub] [airflow] mik-laj commented on issue #8163: Google `Credentials` object has not attribute `with_subject`

2020-04-06 Thread GitBox
mik-laj commented on issue #8163: Google `Credentials` object has not attribute `with_subject` URL: https://github.com/apache/airflow/issues/8163#issuecomment-610011525 Cloud Composer uses credentials from the metadata server in the client project and credentials from App Engine in the

[GitHub] [airflow] austynh opened a new issue #8168: Database table `dag_run` record is inserted with incorrect data for nested SubDags.

2020-04-06 Thread GitBox
austynh opened a new issue #8168: Database table `dag_run` record is inserted with incorrect data for nested SubDags. URL: https://github.com/apache/airflow/issues/8168 **Apache Airflow version**: `>=1.10.3` **Environment**: - **Cloud provider or hardware configuration**:

[GitHub] [airflow] boring-cyborg[bot] commented on issue #8168: Database table `dag_run` record is inserted with incorrect data for nested SubDags.

2020-04-06 Thread GitBox
boring-cyborg[bot] commented on issue #8168: Database table `dag_run` record is inserted with incorrect data for nested SubDags. URL: https://github.com/apache/airflow/issues/8168#issuecomment-610033731 Thanks for opening your first issue here! Be sure to follow the issue template!

[GitHub] [airflow] mik-laj commented on a change in pull request #8008: Custom Facebook Ads Operator

2020-04-06 Thread GitBox
mik-laj commented on a change in pull request #8008: Custom Facebook Ads Operator URL: https://github.com/apache/airflow/pull/8008#discussion_r404421633 ## File path: airflow/providers/facebook/ads/operators/ads.py ## @@ -0,0 +1,119 @@ +# +# Licensed to the Apache

[GitHub] [airflow] mik-laj commented on a change in pull request #8008: Custom Facebook Ads Operator

2020-04-06 Thread GitBox
mik-laj commented on a change in pull request #8008: Custom Facebook Ads Operator URL: https://github.com/apache/airflow/pull/8008#discussion_r404426868 ## File path: airflow/providers/facebook/ads/example_dags/example_ads.py ## @@ -0,0 +1,110 @@ +# +# Licensed to the

[GitHub] [airflow] mik-laj commented on issue #8167: add PrestoOperator

2020-04-06 Thread GitBox
mik-laj commented on issue #8167: add PrestoOperator URL: https://github.com/apache/airflow/pull/8167#issuecomment-60193 Are these operators really working? I had a problem with the run method. Please look at:

[GitHub] [airflow] iamshwin commented on issue #8163: Google `Credentials` object has not attribute `with_subject`

2020-04-06 Thread GitBox
iamshwin commented on issue #8163: Google `Credentials` object has not attribute `with_subject` URL: https://github.com/apache/airflow/issues/8163#issuecomment-610004592 We are running Airflow on Cloud Composer (GCP's managed service). It looks like it is using the credentials from the

[GitHub] [airflow] mik-laj edited a comment on issue #8163: Google `Credentials` object has not attribute `with_subject`

2020-04-06 Thread GitBox
mik-laj edited a comment on issue #8163: Google `Credentials` object has not attribute `with_subject` URL: https://github.com/apache/airflow/issues/8163#issuecomment-610011525 Cloud Composer uses credentials from the metadata server in the client project and credentials from App Engine in

[GitHub] [airflow] mik-laj edited a comment on issue #8163: Google `Credentials` object has not attribute `with_subject`

2020-04-06 Thread GitBox
mik-laj edited a comment on issue #8163: Google `Credentials` object has not attribute `with_subject` URL: https://github.com/apache/airflow/issues/8163#issuecomment-610011525 Cloud Composer uses credentials from the metadata server in the client project and credentials from App Engine in

[GitHub] [airflow] mik-laj commented on a change in pull request #8008: Custom Facebook Ads Operator

2020-04-06 Thread GitBox
mik-laj commented on a change in pull request #8008: Custom Facebook Ads Operator URL: https://github.com/apache/airflow/pull/8008#discussion_r404420227 ## File path: airflow/providers/facebook/ads/hooks/ads.py ## @@ -0,0 +1,146 @@ +# +# Licensed to the Apache Software

[GitHub] [airflow] mik-laj commented on a change in pull request #8008: Custom Facebook Ads Operator

2020-04-06 Thread GitBox
mik-laj commented on a change in pull request #8008: Custom Facebook Ads Operator URL: https://github.com/apache/airflow/pull/8008#discussion_r404423523 ## File path: airflow/providers/facebook/ads/operators/ads.py ## @@ -0,0 +1,108 @@ +# +# Licensed to the Apache

[GitHub] [airflow] mik-laj commented on a change in pull request #8008: Custom Facebook Ads Operator

2020-04-06 Thread GitBox
mik-laj commented on a change in pull request #8008: Custom Facebook Ads Operator URL: https://github.com/apache/airflow/pull/8008#discussion_r404424465 ## File path: airflow/providers/facebook/ads/operators/ads.py ## @@ -0,0 +1,119 @@ +# Review comment: The file

[GitHub] [airflow] cdmikechen commented on issue #5344: [WIP][AIRFLOW-4592]Add the translation

2020-04-06 Thread GitBox
cdmikechen commented on issue #5344: [WIP][AIRFLOW-4592]Add the translation URL: https://github.com/apache/airflow/pull/5344#issuecomment-610128399 @XuanmoFeng Hi~ I want to know that you are still doing follow-up translation on this PR? I've translated some airflow version html myself,

[GitHub] [airflow] cdmikechen edited a comment on issue #5344: [WIP][AIRFLOW-4592]Add the translation

2020-04-06 Thread GitBox
cdmikechen edited a comment on issue #5344: [WIP][AIRFLOW-4592]Add the translation URL: https://github.com/apache/airflow/pull/5344#issuecomment-610128399 @XuanmoFeng Hi~ I want to know that you are still doing follow-up translation on this PR, please? I've translated htmls in some

[GitHub] [airflow] xinbinhuang commented on issue #8078: Execute SubDAG tasks as part of parent DAG

2020-04-06 Thread GitBox
xinbinhuang commented on issue #8078: Execute SubDAG tasks as part of parent DAG URL: https://github.com/apache/airflow/issues/8078#issuecomment-610189799 @kaxil @turbaszek @dimberman I found this PR https://github.com/apache/airflow/pull/5498 when I was working on the AIP draft. It

[GitHub] [airflow] xinbinhuang edited a comment on issue #8078: Execute SubDAG tasks as part of parent DAG

2020-04-06 Thread GitBox
xinbinhuang edited a comment on issue #8078: Execute SubDAG tasks as part of parent DAG URL: https://github.com/apache/airflow/issues/8078#issuecomment-610189799 @kaxil @turbaszek @dimberman I found this PR https://github.com/apache/airflow/pull/5498 when I was working on the AIP draft.

[GitHub] [airflow] xinbinhuang edited a comment on issue #8078: Execute SubDAG tasks as part of parent DAG

2020-04-06 Thread GitBox
xinbinhuang edited a comment on issue #8078: Execute SubDAG tasks as part of parent DAG URL: https://github.com/apache/airflow/issues/8078#issuecomment-610189799 @kaxil @turbaszek @dimberman I found this PR https://github.com/apache/airflow/pull/5498 when I was working on the AIP draft.

[GitHub] [airflow] codecov-io commented on issue #7653: [AIRFLOW-6914] Add a default robots.txt

2020-04-06 Thread GitBox
codecov-io commented on issue #7653: [AIRFLOW-6914] Add a default robots.txt URL: https://github.com/apache/airflow/pull/7653#issuecomment-610136821 # [Codecov](https://codecov.io/gh/apache/airflow/pull/7653?src=pr=h1) Report > Merging

[GitHub] [airflow] ouchl opened a new pull request #8169: [AIRFLOW-XXXX] Minor improvement in Dockerfile

2020-04-06 Thread GitBox
ouchl opened a new pull request #8169: [AIRFLOW-] Minor improvement in Dockerfile URL: https://github.com/apache/airflow/pull/8169 --- Make sure to mark the boxes below before creating PR: [x] - [ ] Description above provides context of the change - [ ] Unit tests coverage

[GitHub] [airflow] feluelle commented on issue #7683: [AIRFLOW-7033] Change dag and task state meanwhile

2020-04-06 Thread GitBox
feluelle commented on issue #7683: [AIRFLOW-7033] Change dag and task state meanwhile URL: https://github.com/apache/airflow/pull/7683#issuecomment-610155710 This does not look right to me - to put this button on task-level actions window. Wouldn’t it be better to put it on the DagRun

[GitHub] [airflow] stale[bot] commented on issue #7153: [AIRFLOW-6585] Fixed Timestamp bug in RefreshKubeConfigLoader

2020-04-06 Thread GitBox
stale[bot] commented on issue #7153: [AIRFLOW-6585] Fixed Timestamp bug in RefreshKubeConfigLoader URL: https://github.com/apache/airflow/pull/7153#issuecomment-610164786 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no

[GitHub] [airflow] zhongjiajie commented on issue #7683: [AIRFLOW-7033] Change dag and task state meanwhile

2020-04-06 Thread GitBox
zhongjiajie commented on issue #7683: [AIRFLOW-7033] Change dag and task state meanwhile URL: https://github.com/apache/airflow/pull/7683#issuecomment-610174787 > This does not look right to me - to put this button on task-level actions window. Wouldn’t it be better to put it on the

[GitHub] [airflow] zhongjiajie edited a comment on issue #7683: [AIRFLOW-7033] Change dag and task state meanwhile

2020-04-06 Thread GitBox
zhongjiajie edited a comment on issue #7683: [AIRFLOW-7033] Change dag and task state meanwhile URL: https://github.com/apache/airflow/pull/7683#issuecomment-610174787 > This does not look right to me - to put this button on task-level actions window. Wouldn’t it be better to put it on

[GitHub] [airflow] zhongjiajie edited a comment on issue #7683: [AIRFLOW-7033] Change dag and task state meanwhile

2020-04-06 Thread GitBox
zhongjiajie edited a comment on issue #7683: [AIRFLOW-7033] Change dag and task state meanwhile URL: https://github.com/apache/airflow/pull/7683#issuecomment-610174787 > This does not look right to me - to put this button on task-level actions window. Wouldn’t it be better to put it on

[GitHub] [airflow] wkhudgins92 opened a new pull request #8170: Airflow 6515

2020-04-06 Thread GitBox
wkhudgins92 opened a new pull request #8170: Airflow 6515 URL: https://github.com/apache/airflow/pull/8170 Per [AIRFLOW-6515](https://issues.apache.org/jira/browse/AIRFLOW-6515), I executed the following to get a list of potential errors logged with the info or warn level: ```

[jira] [Commented] (AIRFLOW-6515) log level of INFO/WARN when ERROR happened

2020-04-06 Thread Will Hudgins (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076840#comment-17076840 ] Will Hudgins commented on AIRFLOW-6515: --- [~toopt4] I raised a PR for this: 

[GitHub] [airflow] boring-cyborg[bot] commented on issue #8170: Airflow 6515

2020-04-06 Thread GitBox
boring-cyborg[bot] commented on issue #8170: Airflow 6515 URL: https://github.com/apache/airflow/pull/8170#issuecomment-610142793 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check

[GitHub] [airflow] ashb commented on issue #8156: Security Views broken

2020-04-06 Thread GitBox
ashb commented on issue #8156: Security Views broken URL: https://github.com/apache/airflow/issues/8156#issuecomment-609683214 Wonder if this is related to my DT changes where I had to hack around FABs SQLA models This is an

[GitHub] [airflow] kaxil commented on issue #8156: Security Views broken

2020-04-06 Thread GitBox
kaxil commented on issue #8156: Security Views broken URL: https://github.com/apache/airflow/issues/8156#issuecomment-609695490 > Wonder if this is related to my DT changes where I had to hack around FABs SQLA models Yeah, very likely

[GitHub] [airflow] mik-laj commented on issue #6961: [AIRFLOW-XXX] Add task execution process on Celery Execution diagram

2020-04-06 Thread GitBox
mik-laj commented on issue #6961: [AIRFLOW-XXX] Add task execution process on Celery Execution diagram URL: https://github.com/apache/airflow/pull/6961#issuecomment-609700981 @turbaszek I was busy, but I have performance tests to do this quarter and I will definitely come back to that.

[GitHub] [airflow] zhongjiajie commented on a change in pull request #8089: In BREEZE.rst the command to create a user is outdated. #8086

2020-04-06 Thread GitBox
zhongjiajie commented on a change in pull request #8089: In BREEZE.rst the command to create a user is outdated. #8086 URL: https://github.com/apache/airflow/pull/8089#discussion_r403975841 ## File path: BREEZE.rst ## @@ -482,7 +482,8 @@ running the webserver in order to

[GitHub] [airflow] zhongjiajie commented on a change in pull request #8089: In BREEZE.rst the command to create a user is outdated. #8086

2020-04-06 Thread GitBox
zhongjiajie commented on a change in pull request #8089: In BREEZE.rst the command to create a user is outdated. #8086 URL: https://github.com/apache/airflow/pull/8089#discussion_r403976293 ## File path: BREEZE.rst ## @@ -482,7 +482,8 @@ running the webserver in order to

[GitHub] [airflow] zhongjiajie commented on a change in pull request #8089: In BREEZE.rst the command to create a user is outdated. #8086

2020-04-06 Thread GitBox
zhongjiajie commented on a change in pull request #8089: In BREEZE.rst the command to create a user is outdated. #8086 URL: https://github.com/apache/airflow/pull/8089#discussion_r403976293 ## File path: BREEZE.rst ## @@ -482,7 +482,8 @@ running the webserver in order to

[GitHub] [airflow] HaloKo4 commented on issue #7735: [AIRFLOW-4549] Allow skipped tasks to satisfy wait_for_downstream

2020-04-06 Thread GitBox
HaloKo4 commented on issue #7735: [AIRFLOW-4549] Allow skipped tasks to satisfy wait_for_downstream URL: https://github.com/apache/airflow/pull/7735#issuecomment-609638482 I think there is an issue with the test ``` def get_dag(subdir: Optional[str], dag_id: str) -> DAG:

[GitHub] [airflow] malagoli commented on issue #7849: [AIRFLOW-7106] Cloud data fusion integration - Allow to pass args to start pipeline

2020-04-06 Thread GitBox
malagoli commented on issue #7849: [AIRFLOW-7106] Cloud data fusion integration - Allow to pass args to start pipeline URL: https://github.com/apache/airflow/pull/7849#issuecomment-609597156 @turbaszek all travis checks passed, any change to merge? thanks

[GitHub] [airflow] nirousseau commented on issue #8019: Custom SSL CA CERTIFICATE by Configuration for Kubernetes Executor

2020-04-06 Thread GitBox
nirousseau commented on issue #8019: Custom SSL CA CERTIFICATE by Configuration for Kubernetes Executor URL: https://github.com/apache/airflow/issues/8019#issuecomment-609634079 bump  This is an automated message from the

[jira] [Commented] (AIRFLOW-7106) Cloud data fusion integration - Allow to pass args to start pipeline

2020-04-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-7106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076117#comment-17076117 ] ASF GitHub Bot commented on AIRFLOW-7106: - turbaszek commented on pull request #7849:

[jira] [Commented] (AIRFLOW-7106) Cloud data fusion integration - Allow to pass args to start pipeline

2020-04-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-7106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076121#comment-17076121 ] ASF subversion and git services commented on AIRFLOW-7106: -- Commit

[jira] [Commented] (AIRFLOW-7106) Cloud data fusion integration - Allow to pass args to start pipeline

2020-04-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-7106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076120#comment-17076120 ] ASF subversion and git services commented on AIRFLOW-7106: -- Commit

[GitHub] [airflow] turbaszek merged pull request #7849: [AIRFLOW-7106] Cloud data fusion integration - Allow to pass args to start pipeline

2020-04-06 Thread GitBox
turbaszek merged pull request #7849: [AIRFLOW-7106] Cloud data fusion integration - Allow to pass args to start pipeline URL: https://github.com/apache/airflow/pull/7849 This is an automated message from the Apache Git

[GitHub] [airflow] boring-cyborg[bot] commented on issue #7849: [AIRFLOW-7106] Cloud data fusion integration - Allow to pass args to start pipeline

2020-04-06 Thread GitBox
boring-cyborg[bot] commented on issue #7849: [AIRFLOW-7106] Cloud data fusion integration - Allow to pass args to start pipeline URL: https://github.com/apache/airflow/pull/7849#issuecomment-609642424 Awesome work, congrats on your first merged pull request!

[GitHub] [airflow] turbaszek commented on issue #6961: [AIRFLOW-XXX] Add task execution process on Celery Execution diagram

2020-04-06 Thread GitBox
turbaszek commented on issue #6961: [AIRFLOW-XXX] Add task execution process on Celery Execution diagram URL: https://github.com/apache/airflow/pull/6961#issuecomment-609646090 @mik-laj do you want to add something to this?

[GitHub] [airflow-site] zhongjiajie closed issue #236: Update Links for Social Media Buttons

2020-04-06 Thread GitBox
zhongjiajie closed issue #236: Update Links for Social Media Buttons URL: https://github.com/apache/airflow-site/issues/236 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [airflow-site] zhongjiajie commented on issue #236: Update Links for Social Media Buttons

2020-04-06 Thread GitBox
zhongjiajie commented on issue #236: Update Links for Social Media Buttons URL: https://github.com/apache/airflow-site/issues/236#issuecomment-609664264 Close this, but we should remove JIRA after we migrate all ticket to issue?

[airflow-site] branch master updated: Add link to apache.org (#255)

2020-04-06 Thread turbaszek
This is an automated email from the ASF dual-hosted git repository. turbaszek pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow-site.git The following commit(s) were added to refs/heads/master by this push: new 8e7c3f6 Add link to apache.org (#255)

[GitHub] [airflow-site] turbaszek merged pull request #255: Add link to apache.org

2020-04-06 Thread GitBox
turbaszek merged pull request #255: Add link to apache.org URL: https://github.com/apache/airflow-site/pull/255 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

  1   2   >