mik-laj edited a comment on pull request #10256:
URL: https://github.com/apache/airflow/pull/10256#issuecomment-671086076
@kubatyszko Can you give the value you have in the Secret backet? Do you
realize that in the backend secret you should store the connection
representation as a URI,
mik-laj commented on pull request #10256:
URL: https://github.com/apache/airflow/pull/10256#issuecomment-671086076
@kubatyszko Can you give the value you have in the Secret backet?
Have you tried to create a connection using the Web UI and then view the URI
representations of the
mik-laj edited a comment on pull request #9907:
URL: https://github.com/apache/airflow/pull/9907#issuecomment-671062255
We already have the `airflow connections import` command. Your command will
be a great complement to it.
mik-laj commented on issue #8715:
URL: https://github.com/apache/airflow/issues/8715#issuecomment-671087782
It's related to:
https://github.com/apache/airflow/issues/9498
https://github.com/apache/airflow/issues/9507
So I added this to the Airflow 2.0 milestone
mik-laj edited a comment on issue #10007:
URL: https://github.com/apache/airflow/issues/10007#issuecomment-671088094
@shlomiken Is there any progress here? This is a ticket that got a lot of
thumbs up so would like to know if this ticket is lockable or needs to be
processed.
mik-laj commented on issue #10007:
URL: https://github.com/apache/airflow/issues/10007#issuecomment-671088094
@shlomiken Is there any progress here?
This is an automated message from the Apache Git Service.
To respond to the
mik-laj commented on issue #8495:
URL: https://github.com/apache/airflow/issues/8495#issuecomment-671088585
@dmayle @matthieu-foucault @humbledude Would you like to contribute this
change to the project? This looks like a much needed change so I'd love to help
with the review.
CC:
This is an automated email from the ASF dual-hosted git repository.
dimberman pushed a commit to branch v1-10-test
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/v1-10-test by this push:
new 90fe915 add documentation for k8s
mik-laj commented on issue #8715:
URL: https://github.com/apache/airflow/issues/8715#issuecomment-671088716
@rootcss Could you please leave a comment so I can assign you to this ticket?
This is an automated message from the
mik-laj commented on issue #9181:
URL: https://github.com/apache/airflow/issues/9181#issuecomment-671089535
Can the expected result be achieved with this configuration option?
https://airflow.readthedocs.io/en/latest/configurations-ref.html#pod-template-file
potiuk commented on pull request #279:
URL: https://github.com/apache/airflow-site/pull/279#issuecomment-671090633
Fantastic ! Thanks!
This is an automated message from the Apache Git Service.
To respond to the message,
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/airflow-site.git
The following commit(s) were added to refs/heads/master by this push:
new 6d47dfe Move announcements page from
potiuk merged pull request #279:
URL: https://github.com/apache/airflow-site/pull/279
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
potiuk closed issue #10196:
URL: https://github.com/apache/airflow/issues/10196
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dimberman opened a new pull request #10266:
URL: https://github.com/apache/airflow/pull/10266
metadata objects require a more complex merge strategy
then a simple "merge pods" for merging labels and other
features
---
**^ Add meaningful description above**
mik-laj commented on pull request #10192:
URL: https://github.com/apache/airflow/pull/10192#issuecomment-671097020
I added `airflow connection get` command:
https://github.com/apache/airflow/pull/10214
This is an automated
potiuk closed issue #10155:
URL: https://github.com/apache/airflow/issues/10155
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
potiuk merged pull request #10246:
URL: https://github.com/apache/airflow/pull/10246
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
potiuk commented on pull request #10246:
URL: https://github.com/apache/airflow/pull/10246#issuecomment-671099018
Thanks @michalslowikowski00 !
This is an automated message from the Apache Git Service.
To respond to the
potiuk commented on issue #10264:
URL: https://github.com/apache/airflow/issues/10264#issuecomment-671098812
BTW. I got a lot better at it with recent changes in IntelliJ where
spell-checking and grammar is built in :)
This
potiuk commented on issue #10264:
URL: https://github.com/apache/airflow/issues/10264#issuecomment-671098732
Love it. I make a lot of spelling mistakes (usually because I want to go
fast). So having an automated check would be awesome!
shlomiken commented on issue #10007:
URL: https://github.com/apache/airflow/issues/10007#issuecomment-671099821
Hi @mik-laj , unfortunately we don't have the capacity now to refactor this.
we decided to install sagemaker as it worked till now.
this means that the use case of working
mik-laj commented on issue #8657:
URL: https://github.com/apache/airflow/issues/8657#issuecomment-671089031
Such a feature is not planned. It is recommended to set up a separate
process (e.g. sidecar) that will be responsible for file synchronization.
However, I would be happy if there
mik-laj edited a comment on issue #9181:
URL: https://github.com/apache/airflow/issues/9181#issuecomment-671089535
Can the expected result be achieved with pod_template_file option?
https://airflow.readthedocs.io/en/latest/configurations-ref.html#pod-template-file
mik-laj commented on issue #10038:
URL: https://github.com/apache/airflow/issues/10038#issuecomment-671089649
Is there anything left to do in this ticket? We have docs about it:
https://airflow.readthedocs.io/en/latest/installation.html
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/airflow-site.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 3a1233d Update asf-site to
potiuk closed issue #10038:
URL: https://github.com/apache/airflow/issues/10038
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
potiuk commented on issue #8657:
URL: https://github.com/apache/airflow/issues/8657#issuecomment-671098446
Yep. There was an extensive discussion about it at the devlist
potiuk closed issue #8657:
URL: https://github.com/apache/airflow/issues/8657
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
potiuk commented on pull request #279:
URL: https://github.com/apache/airflow-site/pull/279#issuecomment-671098545
The page is live. Thanks Again :)
This is an automated message from the Apache Git Service.
To respond to the
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from 06a1836 Add Missing Apache Providers to docs/installation.rst (#10265)
add ef08831 Added
mik-laj commented on issue #10007:
URL: https://github.com/apache/airflow/issues/10007#issuecomment-671100253
I close the ticket because the problem is no longer with Airflow, but with
the Sagemaker SDK.
@shlomiken Thank you for sharing your experience about this operator.
LeonY1 edited a comment on issue #275:
URL: https://github.com/apache/airflow-site/issues/275#issuecomment-671061272
When we look at the use cases page we can see that there are a lot of
different use cases ordered from left to right. So the example I will be
talking about will be between
LeonY1 commented on issue #275:
URL: https://github.com/apache/airflow-site/issues/275#issuecomment-671061272
When we look at the use cases page we can see that there are a lot of
different use cases ordered from left to right. So the example I will be
talking about will be between Adobe
mik-laj commented on pull request #9907:
URL: https://github.com/apache/airflow/pull/9907#issuecomment-671062255
We already have the `airflow connections import` command. This command will
be a great improvement for the CLI. We already have the command `airflow
connections import`. Your
kaxil merged pull request #10263:
URL: https://github.com/apache/airflow/pull/10263
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
kaxil opened a new pull request #10265:
URL: https://github.com/apache/airflow/pull/10265
The following were missing:
- kylin
- livy
- sqoop
- pig
---
**^ Add meaningful description above**
Read the **[Pull Request
mik-laj commented on issue #8091:
URL: https://github.com/apache/airflow/issues/8091#issuecomment-671069863
@kaxil @potiuk What else are we planning to do with this ticket?
This is an automated message from the Apache Git
kaxil closed issue #8091:
URL: https://github.com/apache/airflow/issues/8091
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
kaxil commented on issue #8091:
URL: https://github.com/apache/airflow/issues/8091#issuecomment-671069981
This can be closed, I will create a new ticket on the following steps
This is an automated message from the Apache Git
kaxil merged pull request #10265:
URL: https://github.com/apache/airflow/pull/10265
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dimberman commented on a change in pull request #10230:
URL: https://github.com/apache/airflow/pull/10230#discussion_r467603846
##
File path: airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py
##
@@ -304,14 +297,40 @@ def execute(self, context) -> Optional[str]:
dimberman commented on pull request #10230:
URL: https://github.com/apache/airflow/pull/10230#issuecomment-671073461
> LGTM, logic is much clearer, thank you.
>
> One thing to consider is the comment by @dakov here: [#6377
This is an automated email from the ASF dual-hosted git repository.
kaxilnaik pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/master by this push:
new 5503a6a Fix Warning when using a different
kaxil opened a new pull request #10263:
URL: https://github.com/apache/airflow/pull/10263
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)**
for more
kaxil opened a new issue #10264:
URL: https://github.com/apache/airflow/issues/10264
We have been fixing various typos in the project but it would be good if we
can enable a Spell Checker for our Docsite. So our docs are typo-free.
We can use
VijayantSoni commented on pull request #8701:
URL: https://github.com/apache/airflow/pull/8701#issuecomment-671067874
Hi @mik-laj , rebased with master and tests ran fine this time. Thanks.
Will it be possible for you to review in absence of @ashb ?
Thanks !
mik-laj commented on pull request #8701:
URL: https://github.com/apache/airflow/pull/8701#issuecomment-671068349
I am not an AWS expert. @feluelle can you take a look?
This is an automated message from the Apache Git
This is an automated email from the ASF dual-hosted git repository.
kaxilnaik pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from 5503a6a Fix Warning when using a different Sphinx Builder (#10262)
add b43f90a Fix various typos in the
This is an automated email from the ASF dual-hosted git repository.
kaxilnaik pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/master by this push:
new 06a1836 Add Missing Apache Providers to
yesemsanthoshkumar edited a comment on pull request #279:
URL: https://github.com/apache/airflow-site/pull/279#issuecomment-671075081
> > 1. Oct 18, 2019
> >Same update as Nov 22, 2019. Should I remove one of them?
>
> Yep. mistake. Remove the Nov 22nd one.
Done
> >
yesemsanthoshkumar commented on pull request #279:
URL: https://github.com/apache/airflow-site/pull/279#issuecomment-671075081
> > 1. Oct 18, 2019
> >Same update as Nov 22, 2019. Should I remove one of them?
>
> Yep. mistake. Remove the Nov 22nd one.
Done
> > 1.
rootcss commented on issue #8715:
URL: https://github.com/apache/airflow/issues/8715#issuecomment-671142928
@mik-laj yes, can you assign this issue to me?
This is an automated message from the Apache Git Service.
To respond
roitvt commented on pull request #10023:
URL: https://github.com/apache/airflow/pull/10023#issuecomment-671017812
LGTM works well with spark-pi.
Great addition thanks :)
@bbenzikry @mik-laj
This is an automated
roitvt removed a comment on pull request #10023:
URL: https://github.com/apache/airflow/pull/10023#issuecomment-671018435
> > > @roitvt, sorry to bother you - do you think you'll have time to take a
look this week?
> >
> >
> > Hi Beni, I'm really sorry I'll do it this week.
roitvt commented on pull request #10023:
URL: https://github.com/apache/airflow/pull/10023#issuecomment-671018435
> > > @roitvt, sorry to bother you - do you think you'll have time to take a
look this week?
> >
> >
> > Hi Beni, I'm really sorry I'll do it this week. thank you
roitvt commented on pull request #10023:
URL: https://github.com/apache/airflow/pull/10023#issuecomment-671018479
> > > @roitvt, sorry to bother you - do you think you'll have time to take a
look this week?
> >
> >
> > Hi Beni, I'm really sorry I'll do it this week. thank you
JeffryMAC commented on a change in pull request #10241:
URL: https://github.com/apache/airflow/pull/10241#discussion_r467544808
##
File path: docs/howto/variable.rst
##
@@ -0,0 +1,72 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+or more contributor
mik-laj commented on a change in pull request #10241:
URL: https://github.com/apache/airflow/pull/10241#discussion_r467550086
##
File path: docs/howto/variable.rst
##
@@ -0,0 +1,72 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+or more contributor
mik-laj commented on a change in pull request #10241:
URL: https://github.com/apache/airflow/pull/10241#discussion_r467550010
##
File path: docs/howto/variable.rst
##
@@ -0,0 +1,72 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+or more contributor
bbenzikry commented on pull request #10023:
URL: https://github.com/apache/airflow/pull/10023#issuecomment-671020059
> > > > @roitvt, sorry to bother you - do you think you'll have time to take
a look this week?
> > >
> > >
> > > Hi Beni, I'm really sorry I'll do it this week.
potiuk commented on pull request #10220:
URL: https://github.com/apache/airflow/pull/10220#issuecomment-671020470
:D Shall we :)
This is an automated message from the Apache Git Service.
To respond to the message, please log
This is an automated email from the ASF dual-hosted git repository.
dimberman pushed a commit to branch v1-10-test
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/v1-10-test by this push:
new 9e2557a Fix init containers
potiuk merged pull request #10236:
URL: https://github.com/apache/airflow/pull/10236
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
potiuk merged pull request #10257:
URL: https://github.com/apache/airflow/pull/10257
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/master by this push:
new 55021b7 Improve guide about Google Cloud
michalslowikowski00 commented on a change in pull request #10246:
URL: https://github.com/apache/airflow/pull/10246#discussion_r467566854
##
File path: tests/providers/google/cloud/hooks/test_dataprep.py
##
@@ -0,0 +1,97 @@
+#
+# Licensed to the Apache Software Foundation
kaxil commented on a change in pull request #10227:
URL: https://github.com/apache/airflow/pull/10227#discussion_r467569173
##
File path: airflow/models/serialized_dag.py
##
@@ -76,6 +82,7 @@ def __init__(self, dag: DAG):
self.fileloc_hash =
potiuk commented on pull request #10256:
URL: https://github.com/apache/airflow/pull/10256#issuecomment-671040183
Happy to help with the System Tests as well if needed -> just ping us in
"#system-tests" channel in Airflow's slack. The plans are that we fully
automate system tests
Minyus edited a comment on issue #10037:
URL: https://github.com/apache/airflow/issues/10037#issuecomment-671041151
I'm trying to use `pod_template_file` with `in_cluster=True` using Airflow
1.10.11 (Docker image at
Minyus commented on issue #10037:
URL: https://github.com/apache/airflow/issues/10037#issuecomment-671041151
I'm trying to use `pod_template_file` with `in_cluster=True` using Airflow
1.10.11 (Docker image from
Minyus edited a comment on issue #10037:
URL: https://github.com/apache/airflow/issues/10037#issuecomment-671041151
I'm trying to use `pod_template_file` with `in_cluster=True` using Airflow
1.10.11 (Docker image at
ljb7977 edited a comment on pull request #9022:
URL: https://github.com/apache/airflow/pull/9022#issuecomment-669986197
> @ljb7977 how is this going? Could you please also do a rebase together
with the changes? :)
@feluelle Sorry for late replying. I made changes that you suggested
kubatyszko commented on pull request #10256:
URL: https://github.com/apache/airflow/pull/10256#issuecomment-671083935
I'm reconsider my solution to the issue.
I think the conn_type always needs to be "http" - meaning protocol, while
the scheme is supposed to reflect http or https.
kaxil merged pull request #10247:
URL: https://github.com/apache/airflow/pull/10247
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
This is an automated email from the ASF dual-hosted git repository.
kaxilnaik pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/master by this push:
new 637a2c1 Create separate section for Cron
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch constraints-master
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/constraints-master by this
push:
new 64e06a3 Updating
mik-laj commented on a change in pull request #10257:
URL: https://github.com/apache/airflow/pull/10257#discussion_r467563553
##
File path: docs/howto/secrets-backend/google-cloud-secret-manager-backend.rst
##
@@ -26,7 +26,15 @@ a secret backend and how to manage secrets.
mik-laj commented on a change in pull request #10257:
URL: https://github.com/apache/airflow/pull/10257#discussion_r467563372
##
File path: docs/howto/secrets-backend/google-cloud-secret-manager-backend.rst
##
@@ -26,7 +26,15 @@ a secret backend and how to manage secrets.
michalslowikowski00 commented on a change in pull request #10246:
URL: https://github.com/apache/airflow/pull/10246#discussion_r467565793
##
File path: airflow/providers/google/cloud/hooks/dataprep.py
##
@@ -0,0 +1,74 @@
+#
+# Licensed to the Apache Software Foundation (ASF)
michalslowikowski00 commented on a change in pull request #10246:
URL: https://github.com/apache/airflow/pull/10246#discussion_r467565824
##
File path: tests/providers/google/cloud/hooks/test_dataprep.py
##
@@ -0,0 +1,97 @@
+#
+# Licensed to the Apache Software Foundation
kaxil opened a new pull request #10258:
URL: https://github.com/apache/airflow/pull/10258
**Before**:
![image](https://user-images.githubusercontent.com/8811558/89730390-037f8780-da36-11ea-9006-f1c505dbc657.png)
**After**:
kaxil commented on a change in pull request #10227:
URL: https://github.com/apache/airflow/pull/10227#discussion_r467569001
##
File path: airflow/models/serialized_dag.py
##
@@ -65,6 +66,11 @@ class SerializedDagModel(Base):
fileloc_hash = Column(BigInteger,
potiuk commented on a change in pull request #10227:
URL: https://github.com/apache/airflow/pull/10227#discussion_r467570749
##
File path: airflow/models/serialized_dag.py
##
@@ -76,6 +82,7 @@ def __init__(self, dag: DAG):
self.fileloc_hash =
tooptoop4 opened a new pull request #7637:
URL: https://github.com/apache/airflow/pull/7637
---
Issue link:
[AIRFLOW-6994](https://issues.apache.org/jira/browse/AIRFLOW-6994)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context
[
https://issues.apache.org/jira/browse/AIRFLOW-6994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17173812#comment-17173812
]
ASF GitHub Bot commented on AIRFLOW-6994:
-
tooptoop4 opened a new pull request #7637:
URL:
yesemsanthoshkumar opened a new pull request #279:
URL: https://github.com/apache/airflow-site/pull/279
Resolves https://github.com/apache/airflow/issues/10196
This is an automated message from the Apache Git Service.
To
kaxil commented on a change in pull request #5499:
URL: https://github.com/apache/airflow/pull/5499#discussion_r467573812
##
File path: airflow/utils/log/file_task_handler.py
##
@@ -71,15 +71,25 @@ def close(self):
def _render_filename(self, ti, try_number):
if
mik-laj opened a new pull request #10259:
URL: https://github.com/apache/airflow/pull/10259
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)**
for more
kaxil commented on issue #10155:
URL: https://github.com/apache/airflow/issues/10155#issuecomment-671041668
This has been fixed in 1.10.11 - https://github.com/apache/airflow/pull/8775
This is an automated message from the
mik-laj opened a new issue #10260:
URL: https://github.com/apache/airflow/issues/10260
Hello,
I would like it to be possible to easily refer to the reference list with
configuration options. Currently, most of the guides that require a
description of configuration options are
mik-laj commented on issue #9414:
URL: https://github.com/apache/airflow/issues/9414#issuecomment-671044613
@ghost Do you have any problem? Do you have any questions? I will be very
happy to help you if I can
This is an
mik-laj commented on a change in pull request #10259:
URL: https://github.com/apache/airflow/pull/10259#discussion_r467577727
##
File path: docs/redirects.txt
##
@@ -68,5 +68,5 @@ howto/operator/google/firebase/index.rst
howto/operator/google/index.rst
# Other redirects
aranjanthakur commented on issue #10166:
URL: https://github.com/apache/airflow/issues/10166#issuecomment-671048749
Hi @mik-laj , I have made the required changes. Could you please guide how I
can test it?
I have run integration tests in breeze env. I want to build it locally and
test
potiuk commented on pull request #279:
URL: https://github.com/apache/airflow-site/pull/279#issuecomment-671048559
Looks great!
> Resolves
[apache/airflow#10196](https://github.com/apache/airflow/issues/10196)
>
> @potiuk I have the following questions.
>
> 1. Nov 21,
mik-laj commented on issue #275:
URL: https://github.com/apache/airflow-site/issues/275#issuecomment-671050715
@LeonY1 Can you take a screenshot and highlight which page item you are
talking about? I can't find the problem either.
This is an automated email from the ASF dual-hosted git repository.
kamilbregula pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/master by this push:
new 183cb8d Create "Managing variable" in
mik-laj merged pull request #10241:
URL: https://github.com/apache/airflow/pull/10241
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
kaxil commented on pull request #10227:
URL: https://github.com/apache/airflow/pull/10227#issuecomment-671029234
Ping @potiuk
This is an automated message from the Apache Git Service.
To respond to the message, please log
potiuk commented on a change in pull request #10227:
URL: https://github.com/apache/airflow/pull/10227#discussion_r467566683
##
File path: airflow/models/serialized_dag.py
##
@@ -76,6 +82,7 @@ def __init__(self, dag: DAG):
self.fileloc_hash =
1 - 100 of 153 matches
Mail list logo