[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #28619: Fix code readability, add docstrings to json_client

2022-12-28 Thread GitBox
ephraimbuddy commented on code in PR #28619: URL: https://github.com/apache/airflow/pull/28619#discussion_r1058372127 ## airflow/api/client/json_client.py: ## @@ -24,9 +24,25 @@ class Client(api_client.Client): -"""Json API client implementation.""" +"""Json API

[GitHub] [airflow] rkarish opened a new pull request, #28625: Add note for pymssql requirement

2022-12-28 Thread GitBox
rkarish opened a new pull request, #28625: URL: https://github.com/apache/airflow/pull/28625 A user reported an issue on Slack with `MsSqlHook` resulting in a segmentation fault. This issue was resolved by following the instructions on the `pymssql` PyPI. I added this note to the

[GitHub] [airflow] kaxil merged pull request #28594: Fix Connection.get_extra type

2022-12-28 Thread GitBox
kaxil merged PR #28594: URL: https://github.com/apache/airflow/pull/28594 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #28594: Fix Connection.get_extra type

2022-12-28 Thread GitBox
boring-cyborg[bot] commented on PR #28594: URL: https://github.com/apache/airflow/pull/28594#issuecomment-1366743808 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[airflow] branch main updated (4f006e8c71 -> 5dcbbd6f17)

2022-12-28 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 4f006e8c71 Add .bash and other extensions to SSHOperator template_ext (#28617) add 5dcbbd6f17 Fix

[airflow] branch main updated (76186bb588 -> 4f006e8c71)

2022-12-28 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 76186bb588 Fix code docstrings (#28622) add 4f006e8c71 Add .bash and other extensions to SSHOperator template_ext

[GitHub] [airflow] potiuk merged pull request #28617: Add .bash extension to SSHOperator

2022-12-28 Thread GitBox
potiuk merged PR #28617: URL: https://github.com/apache/airflow/pull/28617 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] Taragolis commented on a diff in pull request #28625: Add note for pymssql requirement

2022-12-28 Thread GitBox
Taragolis commented on code in PR #28625: URL: https://github.com/apache/airflow/pull/28625#discussion_r1058446218 ## docs/apache-airflow-providers-microsoft-mssql/index.rst: ## @@ -91,6 +91,8 @@ PIP package Version required ``pymssql``

[GitHub] [airflow] potiuk commented on a diff in pull request #28625: Add note for pymssql requirement

2022-12-28 Thread GitBox
potiuk commented on code in PR #28625: URL: https://github.com/apache/airflow/pull/28625#discussion_r1058456144 ## docs/apache-airflow-providers-microsoft-mssql/index.rst: ## @@ -91,6 +91,8 @@ PIP package Version required ``pymssql``

[GitHub] [airflow] potiuk commented on pull request #28627: Change Architecture class into Enum

2022-12-28 Thread GitBox
potiuk commented on PR #28627: URL: https://github.com/apache/airflow/pull/28627#issuecomment-1366802671 Does not seem to have any bad side effect (let's see what tests say too) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [airflow] potiuk opened a new pull request, #28627: Change Architecture class into Enum

2022-12-28 Thread GitBox
potiuk opened a new pull request, #28627: URL: https://github.com/apache/airflow/pull/28627 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more

[GitHub] [airflow] potiuk commented on a diff in pull request #28569: Add general-purpose "notifier" concept to DAGs

2022-12-28 Thread GitBox
potiuk commented on code in PR #28569: URL: https://github.com/apache/airflow/pull/28569#discussion_r1058359807 ## airflow/providers/slack/provider.yaml: ## @@ -39,7 +39,7 @@ versions: - 1.0.0 dependencies: - - apache-airflow>=2.3.0 + - apache-airflow>=2.6.0.dev0

[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #28569: Add general-purpose "notifier" concept to DAGs

2022-12-28 Thread GitBox
ephraimbuddy commented on code in PR #28569: URL: https://github.com/apache/airflow/pull/28569#discussion_r1058365263 ## airflow/providers/slack/provider.yaml: ## @@ -39,7 +39,7 @@ versions: - 1.0.0 dependencies: - - apache-airflow>=2.3.0 + - apache-airflow>=2.6.0.dev0

[GitHub] [airflow] vchiapaikeo commented on pull request #28624: Fix UI caret direction

2022-12-28 Thread GitBox
vchiapaikeo commented on PR #28624: URL: https://github.com/apache/airflow/pull/28624#issuecomment-1366756074 Yup - this latest commit should hopefully fix. Changed the ids as well to better reflect the action that is taking place. -- This is an automated message from the Apache Git

[GitHub] [airflow] potiuk commented on pull request #28020: Feature/#28015 default args

2022-12-28 Thread GitBox
potiuk commented on PR #28020: URL: https://github.com/apache/airflow/pull/28020#issuecomment-1366782782 Could you please update the description and title of the PR (and commit) if you want to get it reviewed? As it is now, I had no idea what should be reviewed because neither title nor

[GitHub] [airflow] potiuk commented on issue #28603: SFTPOperator does not finish downloading

2022-12-28 Thread GitBox
potiuk commented on issue #28603: URL: https://github.com/apache/airflow/issues/28603#issuecomment-1366733676 One of the reasons for paramico change was that pysftp did not allow for the kind of configuration that direct paramiko would. You should likely look at `keepalive_interval` and

[GitHub] [airflow] potiuk commented on issue #28603: SFTPOperator does not finish downloading

2022-12-28 Thread GitBox
potiuk commented on issue #28603: URL: https://github.com/apache/airflow/issues/28603#issuecomment-1366737096 I am closing it provisionally - because I believe keepalive is the solution. I believe you might also not need to upgrade the provider - because keepalive seems to be also

[GitHub] [airflow] potiuk closed issue #28603: SFTPOperator does not finish downloading

2022-12-28 Thread GitBox
potiuk closed issue #28603: SFTPOperator does not finish downloading URL: https://github.com/apache/airflow/issues/28603 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[airflow] branch main updated (48a051acc4 -> d4dbb0077a)

2022-12-28 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 48a051acc4 Minor update to Scheduler documentation (#28620) add d4dbb0077a Guard not-yet-expanded ti in trigger

[GitHub] [airflow] potiuk commented on pull request #28592: Guard not-yet-expanded ti in trigger rule dep

2022-12-28 Thread GitBox
potiuk commented on PR #28592: URL: https://github.com/apache/airflow/pull/28592#issuecomment-1366746841 Nice catch! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] potiuk commented on pull request #28624: Fix UI caret direction

2022-12-28 Thread GitBox
potiuk commented on PR #28624: URL: https://github.com/apache/airflow/pull/28624#issuecomment-1366754570 Failing tests :( -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [airflow] potiuk commented on a diff in pull request #28619: Fix code readability, add docstrings to json_client

2022-12-28 Thread GitBox
potiuk commented on code in PR #28619: URL: https://github.com/apache/airflow/pull/28619#discussion_r1058455261 ## airflow/api/client/json_client.py: ## @@ -24,9 +24,25 @@ class Client(api_client.Client): -"""Json API client implementation.""" +"""Json API client

[GitHub] [airflow] Taragolis commented on issue #28603: SFTPOperator does not finish downloading

2022-12-28 Thread GitBox
Taragolis commented on issue #28603: URL: https://github.com/apache/airflow/issues/28603#issuecomment-1366540261 @ReneTC Could you provide a bit more information about which version of providers are you use? Did you tried latest version of SFTP provider? Because I see in [provider

[GitHub] [airflow] potiuk merged pull request #28622: Fix code docstrings

2022-12-28 Thread GitBox
potiuk merged PR #28622: URL: https://github.com/apache/airflow/pull/28622 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #28622: Fix code docstrings

2022-12-28 Thread GitBox
boring-cyborg[bot] commented on PR #28622: URL: https://github.com/apache/airflow/pull/28622#issuecomment-1366599533 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[airflow] branch main updated (2169b39d7b -> 76186bb588)

2022-12-28 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 2169b39d7b Migrate Google Cloud hooks test to `pytest` (#28301) add 76186bb588 Fix code docstrings (#28622) No

[GitHub] [airflow] aydinemre commented on issue #24669: setting `resources` in `KubernetesPodOperator` breaks when used with `Operator.partial`

2022-12-28 Thread GitBox
aydinemre commented on issue #24669: URL: https://github.com/apache/airflow/issues/24669#issuecomment-1366600132 I am trying to use the KubernetesPodOperator in Apache Airflow to specify resource requirements for my pods, but I am unable to pass the resources parameter to the operator. I

[GitHub] [airflow] kaxil commented on a diff in pull request #28439: CustomTTYColoredFormatter should inherit TimezoneAware formatter

2022-12-28 Thread GitBox
kaxil commented on code in PR #28439: URL: https://github.com/apache/airflow/pull/28439#discussion_r1058395532 ## airflow/utils/log/colored_log.py: ## @@ -38,7 +40,7 @@ BOLD_OFF = esc("22") -class CustomTTYColoredFormatter(TTYColoredFormatter): +class

[GitHub] [airflow] kaxil commented on a diff in pull request #28625: Add note for pymssql requirement

2022-12-28 Thread GitBox
kaxil commented on code in PR #28625: URL: https://github.com/apache/airflow/pull/28625#discussion_r1058434982 ## docs/apache-airflow-providers-microsoft-mssql/index.rst: ## @@ -91,6 +91,8 @@ PIP package Version required ``pymssql``

[GitHub] [airflow] potiuk merged pull request #28592: Guard not-yet-expanded ti in trigger rule dep

2022-12-28 Thread GitBox
potiuk merged PR #28592: URL: https://github.com/apache/airflow/pull/28592 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on issue #22132: Show average dag run duration

2022-12-28 Thread GitBox
potiuk commented on issue #22132: URL: https://github.com/apache/airflow/issues/22132#issuecomment-1366758456 > Is anyone aware that it's being developed? or is likely to be picked up for development? Marked it as good first issue. That's what I can do as maintainer. Just to

[GitHub] [airflow] potiuk commented on pull request #28337: Fix conflicting Oracle and SSH providers tests

2022-12-28 Thread GitBox
potiuk commented on PR #28337: URL: https://github.com/apache/airflow/pull/28337#issuecomment-1366781416 > I thought this is possible to achieve by autouse fixture in providers conftests.py and module/package scope level Yes. That's exactly what I thought. Would you like to give it a

[GitHub] [airflow] Taragolis commented on pull request #28337: Fix conflicting Oracle and SSH providers tests

2022-12-28 Thread GitBox
Taragolis commented on PR #28337: URL: https://github.com/apache/airflow/pull/28337#issuecomment-1366787812 I tried to do it locally. It required some additional logic in fixture because for some unknown reason it not working well on "package" scope. Need to find this branch,

[GitHub] [airflow] Taragolis opened a new pull request, #28631: Clear DB between each separate providers tests

2022-12-28 Thread GitBox
Taragolis opened a new pull request, #28631: URL: https://github.com/apache/airflow/pull/28631 Follow-up: https://github.com/apache/airflow/pull/28337#issuecomment-1348771336 Some hacks which uses in PR 1. `module` scope with parsing "provider name" instead of `package` scope.

[GitHub] [airflow] ephraimbuddy commented on issue #28499: "Dependency already registered for DAG" warnings with tasks with multiple outputs

2022-12-28 Thread GitBox
ephraimbuddy commented on issue #28499: URL: https://github.com/apache/airflow/issues/28499#issuecomment-1366545805 I think we should do away with this warning -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #28481: dagwarning, add error handling to purge_inactive_dag_warnings

2022-12-28 Thread GitBox
ephraimbuddy commented on code in PR #28481: URL: https://github.com/apache/airflow/pull/28481#discussion_r1058266047 ## airflow/models/dagwarning.py: ## @@ -72,6 +73,11 @@ def purge_inactive_dag_warnings(cls, session: Session = NEW_SESSION) -> None: :return: None

[GitHub] [airflow] potiuk commented on a diff in pull request #28617: Add .bash extension to SSHOperator

2022-12-28 Thread GitBox
potiuk commented on code in PR #28617: URL: https://github.com/apache/airflow/pull/28617#discussion_r1058300269 ## airflow/providers/ssh/operators/ssh.py: ## @@ -63,7 +63,10 @@ class SSHOperator(BaseOperator): """ template_fields: Sequence[str] = ("command",

[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #28256: Include full path to Python files under zip path while clearing import errors.

2022-12-28 Thread GitBox
ephraimbuddy commented on code in PR #28256: URL: https://github.com/apache/airflow/pull/28256#discussion_r1058346122 ## airflow/dag_processing/manager.py: ## @@ -777,8 +777,9 @@ def clear_nonexistent_import_errors(self, session): :param session: session for ORM

[GitHub] [airflow] vchiapaikeo commented on issue #27166: Carets in Grid view are the wrong way around

2022-12-28 Thread GitBox
vchiapaikeo commented on issue #27166: URL: https://github.com/apache/airflow/issues/27166#issuecomment-1366700457 Wanted to get started with some light UI work here so gave this simple issue a shot. Hope that's okay @shashwata27 - I see your PR was a bit stale. PR:

[GitHub] [airflow] potiuk commented on issue #28603: SFTPOperator does not finish downloading

2022-12-28 Thread GitBox
potiuk commented on issue #28603: URL: https://github.com/apache/airflow/issues/28603#issuecomment-1366737663 Of course, we can re-open it if you test both keepalive and migration to newer version and the issue is still there (though I think some more debugging info would be needed for

[airflow] branch main updated (5dcbbd6f17 -> 4f7ac623c8)

2022-12-28 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 5dcbbd6f17 Fix ``Connection.get_extra`` type (#28594) add 4f7ac623c8 Fix typo (#28623) No new revisions were

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #28620: Minor update to Scheduler documentation

2022-12-28 Thread GitBox
boring-cyborg[bot] commented on PR #28620: URL: https://github.com/apache/airflow/pull/28620#issuecomment-1366745647 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] potiuk merged pull request #28623: Fix typo

2022-12-28 Thread GitBox
potiuk merged PR #28623: URL: https://github.com/apache/airflow/pull/28623 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated (4f7ac623c8 -> 48a051acc4)

2022-12-28 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 4f7ac623c8 Fix typo (#28623) add 48a051acc4 Minor update to Scheduler documentation (#28620) No new revisions

[GitHub] [airflow] kaxil merged pull request #28620: Minor update to Scheduler documentation

2022-12-28 Thread GitBox
kaxil merged PR #28620: URL: https://github.com/apache/airflow/pull/28620 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] stamixthereal commented on a diff in pull request #28619: Fix code readability, add docstrings to json_client

2022-12-28 Thread GitBox
stamixthereal commented on code in PR #28619: URL: https://github.com/apache/airflow/pull/28619#discussion_r1058438631 ## airflow/api/client/json_client.py: ## @@ -24,9 +24,25 @@ class Client(api_client.Client): -"""Json API client implementation.""" +"""Json API

[GitHub] [airflow] potiuk commented on a diff in pull request #28569: Add general-purpose "notifier" concept to DAGs

2022-12-28 Thread GitBox
potiuk commented on code in PR #28569: URL: https://github.com/apache/airflow/pull/28569#discussion_r1058441026 ## airflow/providers/slack/notifications/slack_notifier.py: ## @@ -0,0 +1,87 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [airflow] potiuk commented on a diff in pull request #28619: Fix code readability, add docstrings to json_client

2022-12-28 Thread GitBox
potiuk commented on code in PR #28619: URL: https://github.com/apache/airflow/pull/28619#discussion_r1058449396 ## airflow/api/client/json_client.py: ## @@ -24,9 +24,25 @@ class Client(api_client.Client): -"""Json API client implementation.""" +"""Json API client

[GitHub] [airflow] MaicoTimmerman opened a new pull request, #28626: Introduce logging integration for Apache WebHDFS

2022-12-28 Thread GitBox
MaicoTimmerman opened a new pull request, #28626: URL: https://github.com/apache/airflow/pull/28626 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #28626: Introduce logging integration for Apache WebHDFS

2022-12-28 Thread GitBox
boring-cyborg[bot] commented on PR #28626: URL: https://github.com/apache/airflow/pull/28626#issuecomment-1366767160 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution

[GitHub] [airflow] Taragolis commented on a diff in pull request #28625: Add note for pymssql requirement

2022-12-28 Thread GitBox
Taragolis commented on code in PR #28625: URL: https://github.com/apache/airflow/pull/28625#discussion_r1058459895 ## docs/apache-airflow-providers-microsoft-mssql/index.rst: ## @@ -91,6 +91,8 @@ PIP package Version required ``pymssql``

[GitHub] [airflow] potiuk commented on pull request #28097: logging poke info when external dag is not none and task_id and task_ids are none

2022-12-28 Thread GitBox
potiuk commented on PR #28097: URL: https://github.com/apache/airflow/pull/28097#issuecomment-1366779235 Tests are failing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[airflow] branch constraints-main updated: Updating constraints. Build id:

2022-12-28 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new ae05c23304 Updating

[GitHub] [airflow] Taragolis commented on pull request #28590: collect sawarning as error in pytest

2022-12-28 Thread GitBox
Taragolis commented on PR #28590: URL: https://github.com/apache/airflow/pull/28590#issuecomment-1366560903 @BobDu I think this changes conflicts with [pytest-capture-warnings](https://github.com/athinkingape/pytest-capture-warnings) plugin. I check locally and with our current settings

[GitHub] [airflow] Taragolis commented on pull request #28353: Fix the sql syntax in merge_data

2022-12-28 Thread GitBox
Taragolis commented on PR #28353: URL: https://github.com/apache/airflow/pull/28353#issuecomment-1366568491 @avicol doc spellcheck  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] jbampton opened a new pull request, #28623: Fix typo

2022-12-28 Thread GitBox
jbampton opened a new pull request, #28623: URL: https://github.com/apache/airflow/pull/28623 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more

[GitHub] [airflow] raj-wadhwa commented on issue #22132: Show average dag run duration

2022-12-28 Thread GitBox
raj-wadhwa commented on issue #22132: URL: https://github.com/apache/airflow/issues/22132#issuecomment-1366736464 Is there any progress in this area? I was looking for this info to be returned in the API for DAG Run info: `ETA` or `Estimated_Time_To_Completion` Something like

[GitHub] [airflow] potiuk commented on issue #24669: setting `resources` in `KubernetesPodOperator` breaks when used with `Operator.partial`

2022-12-28 Thread GitBox
potiuk commented on issue #24669: URL: https://github.com/apache/airflow/issues/24669#issuecomment-1366743181 I think you should then open a new discussion and explain what you tried and show how it did not work. Commenting on closed issue especially one that relates to different problem -

[GitHub] [airflow] potiuk commented on pull request #28541: Speed up provider validation pre-commit

2022-12-28 Thread GitBox
potiuk commented on PR #28541: URL: https://github.com/apache/airflow/pull/28541#issuecomment-1366770329 Anyone needs some speed-ups :) ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] potiuk opened a new pull request, #28630: Improve "other" test category selection

2022-12-28 Thread GitBox
potiuk opened a new pull request, #28630: URL: https://github.com/apache/airflow/pull/28630 The "Other" test category automatically selects all tests that are not included in any of the regular categories. That is to make sure that we do not forget to add any directory that has been added.

[GitHub] [airflow] potiuk commented on pull request #28630: Improve "other" test category selection

2022-12-28 Thread GitBox
potiuk commented on PR #28630: URL: https://github.com/apache/airflow/pull/28630#issuecomment-1366832706 The list of "other" folders now is far shorter: ![image](https://user-images.githubusercontent.com/595491/209854635-3efcf2f6-2bee-4028-82b1-8ecfa0256015.png) Comparing

[GitHub] [airflow] Taragolis commented on a diff in pull request #28569: Add general-purpose "notifier" concept to DAGs

2022-12-28 Thread GitBox
Taragolis commented on code in PR #28569: URL: https://github.com/apache/airflow/pull/28569#discussion_r1058237022 ## airflow/providers/slack/provider.yaml: ## @@ -39,7 +39,7 @@ versions: - 1.0.0 dependencies: - - apache-airflow>=2.3.0 + - apache-airflow>=2.6.0.dev0

[GitHub] [airflow] ReneTC commented on issue #28603: SFTPOperator does not finish downloading

2022-12-28 Thread GitBox
ReneTC commented on issue #28603: URL: https://github.com/apache/airflow/issues/28603#issuecomment-1366555038 I see. I am using Composer version: 2.0.28 Airflow version: 2.3.3 My providers settings are set to: ` apache-airflow-providers-sftp = "~=2.5.0"`

[GitHub] [airflow] Taragolis commented on pull request #28502: Migrate DagFileProcessor.manage_slas to Internal API

2022-12-28 Thread GitBox
Taragolis commented on PR #28502: URL: https://github.com/apache/airflow/pull/28502#issuecomment-1366570974 @vincbeck need resolve conflicts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] vchiapaikeo opened a new pull request, #28624: Fix UI caret direction

2022-12-28 Thread GitBox
vchiapaikeo opened a new pull request, #28624: URL: https://github.com/apache/airflow/pull/28624 closes: [#ISSUE](https://github.com/apache/airflow/issues/27166) Saw that https://github.com/apache/airflow/pull/27195/files might be stale and it was simple enough so I went

[GitHub] [airflow] potiuk commented on issue #25032: Dynamic Task Mapping - Depth-first execution

2022-12-28 Thread GitBox
potiuk commented on issue #25032: URL: https://github.com/apache/airflow/issues/25032#issuecomment-1366749247 @wangyaopw As @uranusjr mentioned - it's better not to attempt it yet. There are bugs like just fixed https://github.com/apache/airflow/pull/28592 (which is likely the fix to your

[GitHub] [airflow] kaxil merged pull request #28609: Fix Docs Incorrect Example in How To Create Custom Decorator

2022-12-28 Thread GitBox
kaxil merged PR #28609: URL: https://github.com/apache/airflow/pull/28609 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #28609: Fix Docs Incorrect Example in How To Create Custom Decorator

2022-12-28 Thread GitBox
boring-cyborg[bot] commented on PR #28609: URL: https://github.com/apache/airflow/pull/28609#issuecomment-1366755472 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[airflow] branch main updated (d4dbb0077a -> 761aa59f92)

2022-12-28 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from d4dbb0077a Guard not-yet-expanded ti in trigger rule dep (#28592) add 761aa59f92 Fix Incorrect Example

[GitHub] [airflow] rkarish commented on a diff in pull request #28625: Add note for pymssql requirement

2022-12-28 Thread GitBox
rkarish commented on code in PR #28625: URL: https://github.com/apache/airflow/pull/28625#discussion_r1058450927 ## docs/apache-airflow-providers-microsoft-mssql/index.rst: ## @@ -91,6 +91,8 @@ PIP package Version required ``pymssql``

[GitHub] [airflow] rkarish commented on a diff in pull request #28625: Add note for pymssql requirement

2022-12-28 Thread GitBox
rkarish commented on code in PR #28625: URL: https://github.com/apache/airflow/pull/28625#discussion_r1058460835 ## docs/apache-airflow-providers-microsoft-mssql/index.rst: ## @@ -91,6 +91,8 @@ PIP package Version required ``pymssql``

[GitHub] [airflow] kaxil commented on a diff in pull request #28625: Add note for pymssql requirement

2022-12-28 Thread GitBox
kaxil commented on code in PR #28625: URL: https://github.com/apache/airflow/pull/28625#discussion_r1058492281 ## docs/apache-airflow-providers-microsoft-mssql/index.rst: ## @@ -91,6 +91,8 @@ PIP package Version required ``pymssql``

[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #28625: Add note for pymssql requirement

2022-12-28 Thread GitBox
ephraimbuddy commented on code in PR #28625: URL: https://github.com/apache/airflow/pull/28625#discussion_r1058500304 ## docs/apache-airflow-providers-microsoft-mssql/index.rst: ## @@ -91,6 +91,8 @@ PIP package Version required ``pymssql``

[airflow] branch main updated (467a5e3ab2 -> 0fae6a0c9e)

2022-12-28 Thread taragolis
This is an automated email from the ASF dual-hosted git repository. taragolis pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 467a5e3ab2 Fix calendar view for CronTriggerTimeTable dags (#28411) add 0fae6a0c9e Add table_resource to

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #28235: Add table_resource to template fields for BigQueryCreateEmptyTableOperator

2022-12-28 Thread GitBox
boring-cyborg[bot] commented on PR #28235: URL: https://github.com/apache/airflow/pull/28235#issuecomment-1366455750 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] Taragolis merged pull request #28235: Add table_resource to template fields for BigQueryCreateEmptyTableOperator

2022-12-28 Thread GitBox
Taragolis merged PR #28235: URL: https://github.com/apache/airflow/pull/28235 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] stamixthereal opened a new pull request, #28619: Fix code readability, add docstrings to json_client

2022-12-28 Thread GitBox
stamixthereal opened a new pull request, #28619: URL: https://github.com/apache/airflow/pull/28619 Code readability improvements in Client class and methods in json_client -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [airflow] bdsoha closed pull request #28621: Extracted workspace cleanup to a CI action

2022-12-28 Thread GitBox
bdsoha closed pull request #28621: Extracted workspace cleanup to a CI action URL: https://github.com/apache/airflow/pull/28621 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [airflow] potiuk commented on issue #28280: Inconsistent handling of newlines in tasks

2022-12-28 Thread GitBox
potiuk commented on issue #28280: URL: https://github.com/apache/airflow/issues/28280#issuecomment-1366520133 > Unfortunately we would technically break backward compatibility if we do this, but I don’t think there’s a good way around it. Maybe alternatively we should introduce a config to

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #28620: Minor update to Scheduler documentation

2022-12-28 Thread GitBox
boring-cyborg[bot] commented on PR #28620: URL: https://github.com/apache/airflow/pull/28620#issuecomment-1366479223 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution

[GitHub] [airflow] maxnathaniel opened a new pull request, #28620: Minor update to Scheduler documentation

2022-12-28 Thread GitBox
maxnathaniel opened a new pull request, #28620: URL: https://github.com/apache/airflow/pull/28620 Made some minor changes to the Scheduler documentation. One is a typo, and others are changes to make the sentences less awkward. --- **^ Add meaningful description above**

[GitHub] [airflow] bdsoha opened a new pull request, #28621: Extracted workspace cleanup to a CI action

2022-12-28 Thread GitBox
bdsoha opened a new pull request, #28621: URL: https://github.com/apache/airflow/pull/28621 Extracted the workspace cleanup step to a dedicated CI action. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [airflow] stamixthereal opened a new pull request, #28622: Fix code docstrings

2022-12-28 Thread GitBox
stamixthereal opened a new pull request, #28622: URL: https://github.com/apache/airflow/pull/28622 Fix docstrings grammar -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [airflow] bkossakowska opened a new pull request, #28618: Add deferrable mode to DataprocInstantiateWorkflowTemplateOperator

2022-12-28 Thread GitBox
bkossakowska opened a new pull request, #28618: URL: https://github.com/apache/airflow/pull/28618 Add deferrable mode to DataprocInstantiateWorkflowTemplateOperator --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] stamixthereal closed pull request #28607: Minor typos and doc-strings added

2022-12-28 Thread GitBox
stamixthereal closed pull request #28607: Minor typos and doc-strings added URL: https://github.com/apache/airflow/pull/28607 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #28569: Add general-purpose "notifier" concept to DAGs

2022-12-28 Thread GitBox
ephraimbuddy commented on code in PR #28569: URL: https://github.com/apache/airflow/pull/28569#discussion_r1058190702 ## airflow/providers/slack/provider.yaml: ## @@ -39,7 +39,7 @@ versions: - 1.0.0 dependencies: - - apache-airflow>=2.3.0 + - apache-airflow>=2.6.0.dev0

[airflow] branch main updated (0fae6a0c9e -> 0e349d80bb)

2022-12-28 Thread taragolis
This is an automated email from the ASF dual-hosted git repository. taragolis pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 0fae6a0c9e Add table_resource to template fields for BigQueryCreateEmptyTableOperator (#28235) add 0e349d80bb

[GitHub] [airflow] Taragolis merged pull request #28318: Add FTPSFileTransmitOperator

2022-12-28 Thread GitBox
Taragolis merged PR #28318: URL: https://github.com/apache/airflow/pull/28318 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] dstandish commented on pull request #28616: Reduce logging level of `gunicorn.access` to warning

2022-12-28 Thread GitBox
dstandish commented on PR #28616: URL: https://github.com/apache/airflow/pull/28616#issuecomment-1366477472 Ah interesting ... thanks for that. Now the behavior makes a lot more sense. Setting to empty string works for me. -- This is an automated message from the Apache Git Service.

[GitHub] [airflow] dstandish closed pull request #28616: Reduce logging level of `gunicorn.access` to warning

2022-12-28 Thread GitBox
dstandish closed pull request #28616: Reduce logging level of `gunicorn.access` to warning URL: https://github.com/apache/airflow/pull/28616 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[airflow] branch main updated (0e349d80bb -> 2169b39d7b)

2022-12-28 Thread taragolis
This is an automated email from the ASF dual-hosted git repository. taragolis pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 0e349d80bb Add FTPSFileTransmitOperator (#28318) add 2169b39d7b Migrate Google Cloud hooks test to `pytest`

[GitHub] [airflow] Taragolis merged pull request #28301: Migrate Google Cloud hooks test to `pytest`

2022-12-28 Thread GitBox
Taragolis merged PR #28301: URL: https://github.com/apache/airflow/pull/28301 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] uranusjr commented on pull request #28616: Reduce logging level of `gunicorn.access` to warning

2022-12-28 Thread GitBox
uranusjr commented on PR #28616: URL: https://github.com/apache/airflow/pull/28616#issuecomment-1366454296 I took a look at the surrounding code and it seems that access logs are currently explicitly enabled by whoever implemented it in the first place. Gunicorn does not emit access logs

[GitHub] [airflow] potiuk commented on issue #27952: can not use output of task decorator as input for external_task_ids of ExternalTaskSensor

2022-12-28 Thread GitBox
potiuk commented on issue #27952: URL: https://github.com/apache/airflow/issues/27952#issuecomment-1366522100 Just wondering if we can somehow add a precommit to prevent such cases (and scan all our code to search for similar cases) 樂 -- This is an automated message from the Apache Git

[GitHub] [airflow] potiuk commented on a diff in pull request #28631: Clear DB between each separate providers tests

2022-12-28 Thread GitBox
potiuk commented on code in PR #28631: URL: https://github.com/apache/airflow/pull/28631#discussion_r1058531880 ## tests/providers/conftest.py: ## @@ -0,0 +1,75 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the

[GitHub] [airflow] Taragolis commented on a diff in pull request #28631: Clear DB between each separate providers tests

2022-12-28 Thread GitBox
Taragolis commented on code in PR #28631: URL: https://github.com/apache/airflow/pull/28631#discussion_r1058532316 ## tests/providers/conftest.py: ## @@ -0,0 +1,75 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See

[GitHub] [airflow] Taragolis commented on a diff in pull request #28631: Clear DB between each separate providers tests

2022-12-28 Thread GitBox
Taragolis commented on code in PR #28631: URL: https://github.com/apache/airflow/pull/28631#discussion_r1058532316 ## tests/providers/conftest.py: ## @@ -0,0 +1,75 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See

[GitHub] [airflow] potiuk opened a new pull request, #28633: Variables set in variables.env are automatically exported

2022-12-28 Thread GitBox
potiuk opened a new pull request, #28633: URL: https://github.com/apache/airflow/pull/28633 The variables set in variables.env were not automatically exported. --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] potiuk commented on a diff in pull request #28631: Clear DB between each separate providers tests

2022-12-28 Thread GitBox
potiuk commented on code in PR #28631: URL: https://github.com/apache/airflow/pull/28631#discussion_r1058576111 ## tests/providers/conftest.py: ## @@ -0,0 +1,75 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the

[GitHub] [airflow] potiuk commented on a diff in pull request #28631: Clear DB between each separate providers tests

2022-12-28 Thread GitBox
potiuk commented on code in PR #28631: URL: https://github.com/apache/airflow/pull/28631#discussion_r1058576453 ## tests/providers/conftest.py: ## @@ -0,0 +1,75 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the

  1   2   3   >