[jira] [Commented] (AIRFLOW-4574) Add SSHHook private key parameter pkey
[ https://issues.apache.org/jira/browse/AIRFLOW-4574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16954586#comment-16954586 ] ASF subversion and git services commented on AIRFLOW-4574: -- Commit 7e9075f365bf9c8f287db5a6304b83dfaa5458f0 in airflow's branch refs/heads/v1-10-stable from dstandish [ https://gitbox.apache.org/repos/asf?p=airflow.git;h=7e9075f ] [AIRFLOW-4574] SSHHook private_key may only be supplied in extras (#6163) * discussion on original PR suggested removing private_key option as init param * with this PR, can still provide through extras, but not as init param * also add support for private_key in tunnel -- missing in original PR for this issue * remove test related to private_key init param * use context manager to auto-close socket listener so tests can be re-run (cherry picked from commit 0790ede70270ceb8b92f8c8df530361749221053) > Add SSHHook private key parameter pkey > -- > > Key: AIRFLOW-4574 > URL: https://issues.apache.org/jira/browse/AIRFLOW-4574 > Project: Apache Airflow > Issue Type: Improvement > Components: hooks >Reporter: Freddy Fostvedt >Assignee: Freddy Fostvedt >Priority: Minor > Fix For: 1.10.6 > > > The SSHHook only supports key_file parameter for specifying the path to a > private key on disk. This means that private keys for connections that use > ssh hooks must be stored on the disk of the worker instead of in the > connection database. Maintaining the relationship between the worker's disk > state and the connection makes deploying connection changes unnecessarily > complicated. > Paramiko, which SSHHook is built on, has support for accepting private keys > as an input parameter (pkey) > [https://github.com/paramiko/paramiko/blob/53095107625a1303bd9fcfcc7c2c20b9819ee79f/paramiko/client.py#L224] > The work involved in doing this should only be to add pkey as a parameter to > the SSHHook constructor, and test that SSHConnection passes pkey to SSHHook > which then passes it to Paramiko. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-4574) Add SSHHook private key parameter pkey
[ https://issues.apache.org/jira/browse/AIRFLOW-4574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16954484#comment-16954484 ] ASF subversion and git services commented on AIRFLOW-4574: -- Commit c56138cd1863899fe8ef2588ef20029e962cea58 in airflow's branch refs/heads/v1-10-test from dstandish [ https://gitbox.apache.org/repos/asf?p=airflow.git;h=c56138c ] [AIRFLOW-4574] SSHHook private_key may only be supplied in extras (#6163) * discussion on original PR suggested removing private_key option as init param * with this PR, can still provide through extras, but not as init param * also add support for private_key in tunnel -- missing in original PR for this issue * remove test related to private_key init param * use context manager to auto-close socket listener so tests can be re-run (cherry picked from commit 0790ede70270ceb8b92f8c8df530361749221053) > Add SSHHook private key parameter pkey > -- > > Key: AIRFLOW-4574 > URL: https://issues.apache.org/jira/browse/AIRFLOW-4574 > Project: Apache Airflow > Issue Type: Improvement > Components: hooks >Reporter: Freddy Fostvedt >Assignee: Freddy Fostvedt >Priority: Minor > Fix For: 1.10.6 > > > The SSHHook only supports key_file parameter for specifying the path to a > private key on disk. This means that private keys for connections that use > ssh hooks must be stored on the disk of the worker instead of in the > connection database. Maintaining the relationship between the worker's disk > state and the connection makes deploying connection changes unnecessarily > complicated. > Paramiko, which SSHHook is built on, has support for accepting private keys > as an input parameter (pkey) > [https://github.com/paramiko/paramiko/blob/53095107625a1303bd9fcfcc7c2c20b9819ee79f/paramiko/client.py#L224] > The work involved in doing this should only be to add pkey as a parameter to > the SSHHook constructor, and test that SSHConnection passes pkey to SSHHook > which then passes it to Paramiko. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-4574) Add SSHHook private key parameter pkey
[ https://issues.apache.org/jira/browse/AIRFLOW-4574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16954435#comment-16954435 ] ASF subversion and git services commented on AIRFLOW-4574: -- Commit 0790ede70270ceb8b92f8c8df530361749221053 in airflow's branch refs/heads/master from dstandish [ https://gitbox.apache.org/repos/asf?p=airflow.git;h=0790ede ] [AIRFLOW-4574] SSHHook private_key may only be supplied in extras (#6163) * discussion on original PR suggested removing private_key option as init param * with this PR, can still provide through extras, but not as init param * also add support for private_key in tunnel -- missing in original PR for this issue * remove test related to private_key init param * use context manager to auto-close socket listener so tests can be re-run > Add SSHHook private key parameter pkey > -- > > Key: AIRFLOW-4574 > URL: https://issues.apache.org/jira/browse/AIRFLOW-4574 > Project: Apache Airflow > Issue Type: Improvement > Components: hooks >Reporter: Freddy Fostvedt >Assignee: Freddy Fostvedt >Priority: Minor > Fix For: 1.10.6 > > > The SSHHook only supports key_file parameter for specifying the path to a > private key on disk. This means that private keys for connections that use > ssh hooks must be stored on the disk of the worker instead of in the > connection database. Maintaining the relationship between the worker's disk > state and the connection makes deploying connection changes unnecessarily > complicated. > Paramiko, which SSHHook is built on, has support for accepting private keys > as an input parameter (pkey) > [https://github.com/paramiko/paramiko/blob/53095107625a1303bd9fcfcc7c2c20b9819ee79f/paramiko/client.py#L224] > The work involved in doing this should only be to add pkey as a parameter to > the SSHHook constructor, and test that SSHConnection passes pkey to SSHHook > which then passes it to Paramiko. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-4574) Add SSHHook private key parameter pkey
[ https://issues.apache.org/jira/browse/AIRFLOW-4574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16954434#comment-16954434 ] ASF GitHub Bot commented on AIRFLOW-4574: - ashb commented on pull request #6163: [AIRFLOW-4574] SSHHook private_key may only be supplied in extras URL: https://github.com/apache/airflow/pull/6163 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add SSHHook private key parameter pkey > -- > > Key: AIRFLOW-4574 > URL: https://issues.apache.org/jira/browse/AIRFLOW-4574 > Project: Apache Airflow > Issue Type: Improvement > Components: hooks >Reporter: Freddy Fostvedt >Assignee: Freddy Fostvedt >Priority: Minor > Fix For: 1.10.6 > > > The SSHHook only supports key_file parameter for specifying the path to a > private key on disk. This means that private keys for connections that use > ssh hooks must be stored on the disk of the worker instead of in the > connection database. Maintaining the relationship between the worker's disk > state and the connection makes deploying connection changes unnecessarily > complicated. > Paramiko, which SSHHook is built on, has support for accepting private keys > as an input parameter (pkey) > [https://github.com/paramiko/paramiko/blob/53095107625a1303bd9fcfcc7c2c20b9819ee79f/paramiko/client.py#L224] > The work involved in doing this should only be to add pkey as a parameter to > the SSHHook constructor, and test that SSHConnection passes pkey to SSHHook > which then passes it to Paramiko. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (AIRFLOW-4574) Add SSHHook private key parameter pkey
[
https://issues.apache.org/jira/browse/AIRFLOW-4574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16935143#comment-16935143
]
ASF GitHub Bot commented on AIRFLOW-4574:
-
dstandish commented on pull request #6163: [AIRFLOW-4574] SSHHook private_key
may only be supplied in extras
URL: https://github.com/apache/airflow/pull/6163
* discussion on original PR suggested removing private_key option as init
param
* with this PR, can still provide through extras, but not as init param
* also add support for private_key in tunnel -- missing in original PR for
this issue
* remove test related to private_key init param
* use context manager to auto-close socket listener so tests can be re-run
@mik-laj @pgagnon @kaxil in spirit of collaboration I set out to address
issue in original PR for this issue (#6104 ). Namely, I set out to remove
private_key as an init param to SSHHook. Lo and behold I noticed that original
PR did not extend support for `private_key` to the get_tunnel hook method,
because it doesn't use `get_conn` but connects independently. This PR
rectifies this oversight by adding this capability.
I did not create new jira because this feels like continuation of same issue
-- just more fully realizing it, and in a way that everyone can be happy with.
There were some minor tweaks that I made to testing.
* In test, The `HELLO_SERVER_CMD` was not executed in context manager, so it
left the socket listener running, which meant you could not rerun the tests
without manually killing the listener process. I use context manager. I think
this makes sense in same PR because it actively interfered with my ability to
test my change.
* In test, I also moved connection creation / destruction to setUpClass /
tearDownClass so they are created and destroyed only once for the ssh hook test
suite. Made sense to do this because in adding tunnel test I had to use the
connection in more than one place.
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add SSHHook private key parameter pkey
> --
>
> Key: AIRFLOW-4574
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4574
> Project: Apache Airflow
> Issue Type: Improvement
> Components: hooks
>Reporter: Freddy Fostvedt
>Assignee: Freddy Fostvedt
>Priority: Minor
> Fix For: 1.10.6
>
>
> The SSHHook only supports
[jira] [Commented] (AIRFLOW-4574) Add SSHHook private key parameter pkey
[ https://issues.apache.org/jira/browse/AIRFLOW-4574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931513#comment-16931513 ] ASF GitHub Bot commented on AIRFLOW-4574: - mik-laj commented on pull request #6104: [AIRFLOW-4574] allow providing private_key in SSHHook URL: https://github.com/apache/airflow/pull/6104 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add SSHHook private key parameter pkey > -- > > Key: AIRFLOW-4574 > URL: https://issues.apache.org/jira/browse/AIRFLOW-4574 > Project: Apache Airflow > Issue Type: Improvement > Components: hooks >Reporter: Freddy Fostvedt >Assignee: Freddy Fostvedt >Priority: Minor > > The SSHHook only supports key_file parameter for specifying the path to a > private key on disk. This means that private keys for connections that use > ssh hooks must be stored on the disk of the worker instead of in the > connection database. Maintaining the relationship between the worker's disk > state and the connection makes deploying connection changes unnecessarily > complicated. > Paramiko, which SSHHook is built on, has support for accepting private keys > as an input parameter (pkey) > [https://github.com/paramiko/paramiko/blob/53095107625a1303bd9fcfcc7c2c20b9819ee79f/paramiko/client.py#L224] > The work involved in doing this should only be to add pkey as a parameter to > the SSHHook constructor, and test that SSHConnection passes pkey to SSHHook > which then passes it to Paramiko. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (AIRFLOW-4574) Add SSHHook private key parameter pkey
[ https://issues.apache.org/jira/browse/AIRFLOW-4574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931514#comment-16931514 ] ASF subversion and git services commented on AIRFLOW-4574: -- Commit fa8e18a2a833a2774f48c413a72df052e8c8f4f0 in airflow's branch refs/heads/master from dstandish [ https://gitbox.apache.org/repos/asf?p=airflow.git;h=fa8e18a ] [AIRFLOW-4574] add option to provide private_key in SSHHook (#6104) > Add SSHHook private key parameter pkey > -- > > Key: AIRFLOW-4574 > URL: https://issues.apache.org/jira/browse/AIRFLOW-4574 > Project: Apache Airflow > Issue Type: Improvement > Components: hooks >Reporter: Freddy Fostvedt >Assignee: Freddy Fostvedt >Priority: Minor > > The SSHHook only supports key_file parameter for specifying the path to a > private key on disk. This means that private keys for connections that use > ssh hooks must be stored on the disk of the worker instead of in the > connection database. Maintaining the relationship between the worker's disk > state and the connection makes deploying connection changes unnecessarily > complicated. > Paramiko, which SSHHook is built on, has support for accepting private keys > as an input parameter (pkey) > [https://github.com/paramiko/paramiko/blob/53095107625a1303bd9fcfcc7c2c20b9819ee79f/paramiko/client.py#L224] > The work involved in doing this should only be to add pkey as a parameter to > the SSHHook constructor, and test that SSHConnection passes pkey to SSHHook > which then passes it to Paramiko. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (AIRFLOW-4574) Add SSHHook private key parameter pkey
[
https://issues.apache.org/jira/browse/AIRFLOW-4574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929842#comment-16929842
]
ASF GitHub Bot commented on AIRFLOW-4574:
-
dstandish commented on pull request #6104: [AIRFLOW-4574] add option to provide
private_key in SSHHook
URL: https://github.com/apache/airflow/pull/6104
* can provide in extras with key "private_key"
* can provide as parameter in SSHHook init
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add SSHHook private key parameter pkey
> --
>
> Key: AIRFLOW-4574
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4574
> Project: Apache Airflow
> Issue Type: Improvement
> Components: hooks
>Reporter: Freddy Fostvedt
>Assignee: Freddy Fostvedt
>Priority: Minor
>
> The SSHHook only supports key_file parameter for specifying the path to a
> private key on disk. This means that private keys for connections that use
> ssh hooks must be stored on the disk of the worker instead of in the
> connection database. Maintaining the relationship between the worker's disk
> state and the connection makes deploying connection changes unnecessarily
> complicated.
> Paramiko, which SSHHook is built on, has support for accepting private keys
> as an input parameter (pkey)
> [https://github.com/paramiko/paramiko/blob/53095107625a1303bd9fcfcc7c2c20b9819ee79f/paramiko/client.py#L224]
> The work involved in doing this should only be to add pkey as a parameter to
> the SSHHook constructor, and test that SSHConnection passes pkey to SSHHook
> which then passes it to Paramiko.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
