[GitHub] ashb commented on issue #3678: [AIRFLOW-2839] Refine Doc Concepts->Connections

2018-08-04 Thread GitBox
ashb commented on issue #3678: [AIRFLOW-2839] Refine Doc Concepts->Connections URL: https://github.com/apache/incubator-airflow/pull/3678#issuecomment-410444282 Last time I checked it wasn't possible to set extra via env vars -- am I wrong about that?

[GitHub] XD-DENG edited a comment on issue #3678: [AIRFLOW-2839] Refine Doc Concepts->Connections

2018-08-04 Thread GitBox
XD-DENG edited a comment on issue #3678: [AIRFLOW-2839] Refine Doc Concepts->Connections URL: https://github.com/apache/incubator-airflow/pull/3678#issuecomment-410444530 Hi @kaxil , I think @ashb is right. I checked

[GitHub] XD-DENG commented on issue #3678: [AIRFLOW-2839] Refine Doc Concepts->Connections

2018-08-04 Thread GitBox
XD-DENG commented on issue #3678: [AIRFLOW-2839] Refine Doc Concepts->Connections URL: https://github.com/apache/incubator-airflow/pull/3678#issuecomment-410446906 Hi @kaxil , I have added a short note to highlight this limitation to users. I didn't add anything into

[jira] [Work started] (AIRFLOW-1746) Add a Nomad operator to trigger job from Airflow

2018-08-04 Thread Eyal Trabelsi (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-1746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on AIRFLOW-1746 started by Eyal Trabelsi. -- > Add a Nomad operator to trigger job from Airflow >

[jira] [Commented] (AIRFLOW-2849) devel requirement is not sufficient to check code quality locally

2018-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569221#comment-16569221 ] ASF GitHub Bot commented on AIRFLOW-2849: - ashb closed pull request #3694: [AIRFLOW-2849] Add

[jira] [Commented] (AIRFLOW-2849) devel requirement is not sufficient to check code quality locally

2018-08-04 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569218#comment-16569218 ] ASF subversion and git services commented on AIRFLOW-2849: -- Commit

[jira] [Resolved] (AIRFLOW-2849) devel requirement is not sufficient to check code quality locally

2018-08-04 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor resolved AIRFLOW-2849. Resolution: Fixed Fix Version/s: 2.0.0 Issue resolved by pull request

[jira] [Commented] (AIRFLOW-2849) devel requirement is not sufficient to check code quality locally

2018-08-04 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569219#comment-16569219 ] ASF subversion and git services commented on AIRFLOW-2849: -- Commit

[GitHub] ashb commented on issue #3646: [WIP][AIRFLOW-2806] test_mark_success_no_kill test breaks intermittently on CI

2018-08-04 Thread GitBox
ashb commented on issue #3646: [WIP][AIRFLOW-2806] test_mark_success_no_kill test breaks intermittently on CI URL: https://github.com/apache/incubator-airflow/pull/3646#issuecomment-410460557 It's relatively easy to set up Travis on your personal fork of Airflow - IIRC it's as simple as

[jira] [Resolved] (AIRFLOW-1749) AirflowConfigParser fails to override has_option from ConfigParser, causing broken LDAP config

2018-08-04 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-1749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor resolved AIRFLOW-1749. Resolution: Fixed Fix Version/s: 2.0.0 Fixed by the larger re-work as

[GitHub] ashb commented on issue #3691: [AIRFLOW-2846] Add missing python test dependency to setup.py

2018-08-04 Thread GitBox
ashb commented on issue #3691: [AIRFLOW-2846] Add missing python test dependency to setup.py URL: https://github.com/apache/incubator-airflow/pull/3691#issuecomment-410463868 Could you rebase please? This is an automated

[GitHub] ashb commented on issue #3495: Small fix for BranchPythonOperator Operator

2018-08-04 Thread GitBox
ashb commented on issue #3495: Small fix for BranchPythonOperator Operator URL: https://github.com/apache/incubator-airflow/pull/3495#issuecomment-410464695 Closing in favour of your other PR This is an automated message

[GitHub] ashb closed pull request #3495: Small fix for BranchPythonOperator Operator

2018-08-04 Thread GitBox
ashb closed pull request #3495: Small fix for BranchPythonOperator Operator URL: https://github.com/apache/incubator-airflow/pull/3495 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] codecov-io edited a comment on issue #3664: [AIRFLOW-2821] Refine Doc "Plugins"

2018-08-04 Thread GitBox
codecov-io edited a comment on issue #3664: [AIRFLOW-2821] Refine Doc "Plugins" URL: https://github.com/apache/incubator-airflow/pull/3664#issuecomment-408755463 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3664?src=pr=h1) Report > Merging

[GitHub] tedmiston opened a new pull request #3696: [AIRFLOW-2851] Canonicalize "as _..." etc imports

2018-08-04 Thread GitBox
tedmiston opened a new pull request #3696: [AIRFLOW-2851] Canonicalize "as _..." etc imports URL: https://github.com/apache/incubator-airflow/pull/3696 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Airflow

[jira] [Commented] (AIRFLOW-2851) Canonicalize "as _..." etc imports

2018-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569284#comment-16569284 ] ASF GitHub Bot commented on AIRFLOW-2851: - tedmiston opened a new pull request #3696:

[GitHub] caddac commented on issue #3684: [AIRFLOW-2840] - add update connections cli option

2018-08-04 Thread GitBox
caddac commented on issue #3684: [AIRFLOW-2840] - add update connections cli option URL: https://github.com/apache/incubator-airflow/pull/3684#issuecomment-410483663 I've also noticed the cli option for adding connections doesn't support adding connections with duplicate `conn_id`,

[GitHub] SandroLuck commented on issue #3530: [AIRFLOW-2609] Fixed behavior of BranchPythonOperator

2018-08-04 Thread GitBox
SandroLuck commented on issue #3530: [AIRFLOW-2609] Fixed behavior of BranchPythonOperator URL: https://github.com/apache/incubator-airflow/pull/3530#issuecomment-410485374 I'll have a look at it This is an automated

[jira] [Created] (AIRFLOW-2852) Can't start GUI program in regular run

2018-08-04 Thread Jianyang Zhao (JIRA)
Jianyang Zhao created AIRFLOW-2852: -- Summary: Can't start GUI program in regular run Key: AIRFLOW-2852 URL: https://issues.apache.org/jira/browse/AIRFLOW-2852 Project: Apache Airflow Issue

[GitHub] feng-tao commented on issue #3696: [AIRFLOW-2851] Canonicalize "as _..." etc imports

2018-08-04 Thread GitBox
feng-tao commented on issue #3696: [AIRFLOW-2851] Canonicalize "as _..." etc imports URL: https://github.com/apache/incubator-airflow/pull/3696#issuecomment-410487166 Thanks @tedmiston for fixing that. I wonder if @mistercrunch knows the initial reason behind using the original import

[GitHub] XD-DENG commented on a change in pull request #3664: [AIRFLOW-2821] Refine Doc "Plugins"

2018-08-04 Thread GitBox
XD-DENG commented on a change in pull request #3664: [AIRFLOW-2821] Refine Doc "Plugins" URL: https://github.com/apache/incubator-airflow/pull/3664#discussion_r207714857 ## File path: docs/plugins.rst ## @@ -78,6 +78,21 @@ looks like: menu_links = [] +You can

[jira] [Commented] (AIRFLOW-2850) Remove deprecated airflow.utils.apply_defaults

2018-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569280#comment-16569280 ] ASF GitHub Bot commented on AIRFLOW-2850: - tedmiston opened a new pull request #3695:

[GitHub] codecov-io commented on issue #3696: [AIRFLOW-2851] Canonicalize "as _..." etc imports

2018-08-04 Thread GitBox
codecov-io commented on issue #3696: [AIRFLOW-2851] Canonicalize "as _..." etc imports URL: https://github.com/apache/incubator-airflow/pull/3696#issuecomment-410476973 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3696?src=pr=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #3696: [AIRFLOW-2851] Canonicalize "as _..." etc imports

2018-08-04 Thread GitBox
codecov-io edited a comment on issue #3696: [AIRFLOW-2851] Canonicalize "as _..." etc imports URL: https://github.com/apache/incubator-airflow/pull/3696#issuecomment-410476973 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3696?src=pr=h1) Report > Merging

[GitHub] tedmiston commented on issue #3646: [WIP][AIRFLOW-2806] test_mark_success_no_kill test breaks intermittently on CI

2018-08-04 Thread GitBox
tedmiston commented on issue #3646: [WIP][AIRFLOW-2806] test_mark_success_no_kill test breaks intermittently on CI URL: https://github.com/apache/incubator-airflow/pull/3646#issuecomment-410482645 Thanks @ashb! Looks like you're right. On my personal account it "just worked" after I

[GitHub] tedmiston closed pull request #3646: [WIP][AIRFLOW-2806] test_mark_success_no_kill test breaks intermittently on CI

2018-08-04 Thread GitBox
tedmiston closed pull request #3646: [WIP][AIRFLOW-2806] test_mark_success_no_kill test breaks intermittently on CI URL: https://github.com/apache/incubator-airflow/pull/3646 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below

[GitHub] tedmiston commented on issue #3646: [WIP][AIRFLOW-2806] test_mark_success_no_kill test breaks intermittently on CI

2018-08-04 Thread GitBox
tedmiston commented on issue #3646: [WIP][AIRFLOW-2806] test_mark_success_no_kill test breaks intermittently on CI URL: https://github.com/apache/incubator-airflow/pull/3646#issuecomment-410482688 Closing this PR for now as I have more work to do here first.

[GitHub] tedmiston edited a comment on issue #3646: [WIP][AIRFLOW-2806] test_mark_success_no_kill test breaks intermittently on CI

2018-08-04 Thread GitBox
tedmiston edited a comment on issue #3646: [WIP][AIRFLOW-2806] test_mark_success_no_kill test breaks intermittently on CI URL: https://github.com/apache/incubator-airflow/pull/3646#issuecomment-410482688 Closing this PR for now as I have more work to do here before it can be merged.

[jira] [Commented] (AIRFLOW-2806) test_mark_success_no_kill test breaks intermittently on CI

2018-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569314#comment-16569314 ] ASF GitHub Bot commented on AIRFLOW-2806: - tedmiston closed pull request #3646:

[GitHub] ashb commented on a change in pull request #3664: [AIRFLOW-2821] Refine Doc "Plugins"

2018-08-04 Thread GitBox
ashb commented on a change in pull request #3664: [AIRFLOW-2821] Refine Doc "Plugins" URL: https://github.com/apache/incubator-airflow/pull/3664#discussion_r207714602 ## File path: docs/plugins.rst ## @@ -78,6 +78,21 @@ looks like: menu_links = [] +You can

[GitHub] tedmiston commented on issue #3691: [AIRFLOW-2846] Add missing python test dependency to setup.py

2018-08-04 Thread GitBox
tedmiston commented on issue #3691: [AIRFLOW-2846] Add missing python test dependency to setup.py URL: https://github.com/apache/incubator-airflow/pull/3691#issuecomment-410466590 Good catch. I'm not sure how we made it this long without `tox` in there. I happen to install it

[GitHub] codecov-io commented on issue #3693: [AIRFLOW-2848] Ensure dag_id in metadata "job" for LocalTaskJob

2018-08-04 Thread GitBox
codecov-io commented on issue #3693: [AIRFLOW-2848] Ensure dag_id in metadata "job" for LocalTaskJob URL: https://github.com/apache/incubator-airflow/pull/3693#issuecomment-410465847 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3693?src=pr=h1) Report > Merging

[jira] [Created] (AIRFLOW-2850) Remove deprecated airflow.utils.apply_defaults

2018-08-04 Thread Taylor Edmiston (JIRA)
Taylor Edmiston created AIRFLOW-2850: Summary: Remove deprecated airflow.utils.apply_defaults Key: AIRFLOW-2850 URL: https://issues.apache.org/jira/browse/AIRFLOW-2850 Project: Apache Airflow

[GitHub] caddac commented on issue #3684: [AIRFLOW-2840] - add update connections cli option

2018-08-04 Thread GitBox
caddac commented on issue #3684: [AIRFLOW-2840] - add update connections cli option URL: https://github.com/apache/incubator-airflow/pull/3684#issuecomment-410482953 Would updating all of the connections be acceptable? Maybe with a flag to indicate this behavior? Or is refusing to update

[GitHub] feng-tao commented on issue #3637: [AIRFLOW-2796] Improve utils helpers code coverage

2018-08-04 Thread GitBox
feng-tao commented on issue #3637: [AIRFLOW-2796] Improve utils helpers code coverage URL: https://github.com/apache/incubator-airflow/pull/3637#issuecomment-410487278 lgtm. Thanks for adding the test @andscoop . This is an

[GitHub] feng-tao commented on issue #3691: [AIRFLOW-2846] Add missing python test dependency to setup.py

2018-08-04 Thread GitBox
feng-tao commented on issue #3691: [AIRFLOW-2846] Add missing python test dependency to setup.py URL: https://github.com/apache/incubator-airflow/pull/3691#issuecomment-410487193 need to rebase. This is an automated message

[GitHub] ashb commented on issue #3691: [AIRFLOW-2846] Add missing python test dependency to setup.py

2018-08-04 Thread GitBox
ashb commented on issue #3691: [AIRFLOW-2846] Add missing python test dependency to setup.py URL: https://github.com/apache/incubator-airflow/pull/3691#issuecomment-410466900 I both have it installed globally, and don’t run with tox locally because the full test suite non-parallel takes

[GitHub] tedmiston opened a new pull request #3695: [AIRFLOW-2850] Remove deprecated airflow.utils.apply_defaults

2018-08-04 Thread GitBox
tedmiston opened a new pull request #3695: [AIRFLOW-2850] Remove deprecated airflow.utils.apply_defaults URL: https://github.com/apache/incubator-airflow/pull/3695 Make sure you have checked _all_ steps below. ### Jira - [x] My PR addresses the following [Airflow

[jira] [Created] (AIRFLOW-2851) Canonicalize "as _..." etc imports

2018-08-04 Thread Taylor Edmiston (JIRA)
Taylor Edmiston created AIRFLOW-2851: Summary: Canonicalize "as _..." etc imports Key: AIRFLOW-2851 URL: https://issues.apache.org/jira/browse/AIRFLOW-2851 Project: Apache Airflow Issue

[GitHub] codecov-io commented on issue #3695: [AIRFLOW-2850] Remove deprecated airflow.utils.apply_defaults

2018-08-04 Thread GitBox
codecov-io commented on issue #3695: [AIRFLOW-2850] Remove deprecated airflow.utils.apply_defaults URL: https://github.com/apache/incubator-airflow/pull/3695#issuecomment-410476727 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3695?src=pr=h1) Report > Merging

[GitHub] feng-tao closed pull request #3637: [AIRFLOW-2796] Improve utils helpers code coverage

2018-08-04 Thread GitBox
feng-tao closed pull request #3637: [AIRFLOW-2796] Improve utils helpers code coverage URL: https://github.com/apache/incubator-airflow/pull/3637 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[jira] [Commented] (AIRFLOW-2796) Improve code coverage for utils/helpers.py

2018-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569327#comment-16569327 ] ASF GitHub Bot commented on AIRFLOW-2796: - feng-tao closed pull request #3637: [AIRFLOW-2796]

[jira] [Commented] (AIRFLOW-2796) Improve code coverage for utils/helpers.py

2018-08-04 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569328#comment-16569328 ] ASF subversion and git services commented on AIRFLOW-2796: -- Commit

[GitHub] kaxil commented on issue #3690: [AIRFLOW-2845] Remove asserts from the contrib package

2018-08-04 Thread GitBox
kaxil commented on issue #3690: [AIRFLOW-2845] Remove asserts from the contrib package URL: https://github.com/apache/incubator-airflow/pull/3690#issuecomment-410443782 @Fokko That looks fine. I wasn't entirely sure about `assert` just being a debug tool. But looks like it is from the

[GitHub] ashb closed pull request #3694: [AIRFLOW-2849] Add missing dependency flake8 to setup to allow running code quality checks locally

2018-08-04 Thread GitBox
ashb closed pull request #3694: [AIRFLOW-2849] Add missing dependency flake8 to setup to allow running code quality checks locally URL: https://github.com/apache/incubator-airflow/pull/3694 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is

[GitHub] ashb closed pull request #2722: [AIRFLOW-1749] Fix has_option to consider environment and cmd overrides

2018-08-04 Thread GitBox
ashb closed pull request #2722: [AIRFLOW-1749] Fix has_option to consider environment and cmd overrides URL: https://github.com/apache/incubator-airflow/pull/2722 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] ashb commented on issue #2722: [AIRFLOW-1749] Fix has_option to consider environment and cmd overrides

2018-08-04 Thread GitBox
ashb commented on issue #2722: [AIRFLOW-1749] Fix has_option to consider environment and cmd overrides URL: https://github.com/apache/incubator-airflow/pull/2722#issuecomment-410461814 Fixed as part of #3029. This is an

[GitHub] codecov-io edited a comment on issue #3678: [AIRFLOW-2839] Refine Doc Concepts->Connections

2018-08-04 Thread GitBox
codecov-io edited a comment on issue #3678: [AIRFLOW-2839] Refine Doc Concepts->Connections URL: https://github.com/apache/incubator-airflow/pull/3678#issuecomment-409789720 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3678?src=pr=h1) Report > Merging

[jira] [Commented] (AIRFLOW-1749) AirflowConfigParser fails to override has_option from ConfigParser, causing broken LDAP config

2018-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-1749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569229#comment-16569229 ] ASF GitHub Bot commented on AIRFLOW-1749: - ashb closed pull request #2722: [AIRFLOW-1749] Fix

[GitHub] codecov-io edited a comment on issue #3690: [AIRFLOW-2845] Remove asserts from the contrib package

2018-08-04 Thread GitBox
codecov-io edited a comment on issue #3690: [AIRFLOW-2845] Remove asserts from the contrib package URL: https://github.com/apache/incubator-airflow/pull/3690#issuecomment-410424110 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3690?src=pr=h1) Report > Merging

[GitHub] codecov-io edited a comment on issue #3690: [AIRFLOW-2845] Remove asserts from the contrib package

2018-08-04 Thread GitBox
codecov-io edited a comment on issue #3690: [AIRFLOW-2845] Remove asserts from the contrib package URL: https://github.com/apache/incubator-airflow/pull/3690#issuecomment-410424110 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3690?src=pr=h1) Report > Merging

[jira] [Issue Comment Deleted] (AIRFLOW-1102) 'airflow webserver' doesn't work with gunicorn 19.4+

2018-08-04 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-1102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-1102: --- Comment: was deleted (was: ashb closed pull request #2237: [AIRFLOW-1102] Add

[jira] [Created] (AIRFLOW-2849) devel requirement is not sufficient to create pull request

2018-08-04 Thread Eyal Trabelsi (JIRA)
Eyal Trabelsi created AIRFLOW-2849: -- Summary: devel requirement is not sufficient to create pull request Key: AIRFLOW-2849 URL: https://issues.apache.org/jira/browse/AIRFLOW-2849 Project: Apache

[GitHub] ashb closed pull request #1998: [AIRFLOW-763] Add contrib check operator for Vertica

2018-08-04 Thread GitBox
ashb closed pull request #1998: [AIRFLOW-763] Add contrib check operator for Vertica URL: https://github.com/apache/incubator-airflow/pull/1998 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[jira] [Commented] (AIRFLOW-763) Vertica Check Operator

2018-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569240#comment-16569240 ] ASF GitHub Bot commented on AIRFLOW-763: ashb closed pull request #1998: [AIRFLOW-763] Add

[GitHub] kaxil commented on issue #3678: [AIRFLOW-2839] Refine Doc Concepts->Connections

2018-08-04 Thread GitBox
kaxil commented on issue #3678: [AIRFLOW-2839] Refine Doc Concepts->Connections URL: https://github.com/apache/incubator-airflow/pull/3678#issuecomment-410443943 @XD-DENG Yes, but it doesn't say how you can put the values in `Extra` params. This is easy in UI but it would be good to have

[GitHub] kaxil commented on issue #3678: [AIRFLOW-2839] Refine Doc Concepts->Connections

2018-08-04 Thread GitBox
kaxil commented on issue #3678: [AIRFLOW-2839] Refine Doc Concepts->Connections URL: https://github.com/apache/incubator-airflow/pull/3678#issuecomment-410445618 @ashb Yes, you are right. @XD-DENG Can you please add a note which tells the users about this limitation.

[GitHub] ashb commented on issue #3684: [AIRFLOW-2840] - add update connections cli option

2018-08-04 Thread GitBox
ashb commented on issue #3684: [AIRFLOW-2840] - add update connections cli option URL: https://github.com/apache/incubator-airflow/pull/3684#issuecomment-410460193 connection ID is (by design) non-unique - its a mechanism of load balancing across multiple DBs for instance - you can have

[GitHub] ashb removed a comment on issue #3684: [AIRFLOW-2840] - add update connections cli option

2018-08-04 Thread GitBox
ashb removed a comment on issue #3684: [AIRFLOW-2840] - add update connections cli option URL: https://github.com/apache/incubator-airflow/pull/3684#issuecomment-410460193 connection ID is (by design) non-unique - its a mechanism of load balancing across multiple DBs for instance - you

[jira] [Issue Comment Deleted] (AIRFLOW-528) airflow-webserver.service does not fork

2018-08-04 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-528: -- Comment: was deleted (was: ashb closed pull request #2804: [AIRFLOW-528] Add missing

[jira] [Closed] (AIRFLOW-528) airflow-webserver.service does not fork

2018-08-04 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor closed AIRFLOW-528. - Resolution: Cannot Reproduce Not sure when this changed, but the type of the service is

[GitHub] ashb closed pull request #2237: [AIRFLOW-1102] Add `python:` prefix for gunicorn config to make it working with gunicorn 19.4+

2018-08-04 Thread GitBox
ashb closed pull request #2237: [AIRFLOW-1102] Add `python:` prefix for gunicorn config to make it working with gunicorn 19.4+ URL: https://github.com/apache/incubator-airflow/pull/2237 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is

[jira] [Commented] (AIRFLOW-661) Celery Task Result Expiry

2018-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569238#comment-16569238 ] ASF GitHub Bot commented on AIRFLOW-661: ashb closed pull request #2143: [AIRFLOW-661] Add

[GitHub] ashb commented on issue #3693: [AIRFLOW-2848] Ensure dag_id in metadata "job" for LocalTaskJob

2018-08-04 Thread GitBox
ashb commented on issue #3693: [AIRFLOW-2848] Ensure dag_id in metadata "job" for LocalTaskJob URL: https://github.com/apache/incubator-airflow/pull/3693#issuecomment-410463737 Good spot. Could you add a simple test please? Probably to somewhere in tests/core.py or tests/jobs.py

[jira] [Updated] (AIRFLOW-966) Celery Broker Transport Options

2018-08-04 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-966: -- Fix Version/s: (was: 1.9.1) 1.10.0 > Celery Broker Transport

[GitHub] ashb commented on issue #3678: [AIRFLOW-2839] Refine Doc Concepts->Connections

2018-08-04 Thread GitBox
ashb commented on issue #3678: [AIRFLOW-2839] Refine Doc Concepts->Connections URL: https://github.com/apache/incubator-airflow/pull/3678#issuecomment-410444795 We should probably add that at some point - perhaps by looking at multiple env vars for one connection. We have the issue that

[GitHub] xnuinside commented on a change in pull request #3690: [AIRFLOW-2845] Remove asserts from the contrib package

2018-08-04 Thread GitBox
xnuinside commented on a change in pull request #3690: [AIRFLOW-2845] Remove asserts from the contrib package URL: https://github.com/apache/incubator-airflow/pull/3690#discussion_r207708750 ## File path: airflow/contrib/hooks/bigquery_hook.py ## @@ -1518,14 +1517,17 @@

[jira] [Updated] (AIRFLOW-2849) devel requirement is not sufficient to check it passes code quality requirements locally

2018-08-04 Thread Eyal Trabelsi (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eyal Trabelsi updated AIRFLOW-2849: --- Summary: devel requirement is not sufficient to check it passes code quality requirements

[jira] [Updated] (AIRFLOW-2849) devel requirement is not sufficient to check code quality locally

2018-08-04 Thread Eyal Trabelsi (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eyal Trabelsi updated AIRFLOW-2849: --- Summary: devel requirement is not sufficient to check code quality locally (was: devel

[jira] [Updated] (AIRFLOW-2849) devel requirement is not sufficient to check it passes code quality requirements locally

2018-08-04 Thread Eyal Trabelsi (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eyal Trabelsi updated AIRFLOW-2849: --- Description: The devel requirement doesn't list flake8, but it's need to validate code

[jira] [Work started] (AIRFLOW-2849) devel requirement is not sufficient to check code quality locally

2018-08-04 Thread Eyal Trabelsi (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on AIRFLOW-2849 started by Eyal Trabelsi. -- > devel requirement is not sufficient to check code quality locally >

[jira] [Assigned] (AIRFLOW-1746) Add a Nomad operator to trigger job from Airflow

2018-08-04 Thread Eyal Trabelsi (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-1746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eyal Trabelsi reassigned AIRFLOW-1746: -- Assignee: Eyal Trabelsi > Add a Nomad operator to trigger job from Airflow >

[GitHub] ashb commented on issue #3650: [AIRFLOW-2703] exceptions from scheduler's heartbeat is handled so that scheduler does not crash

2018-08-04 Thread GitBox
ashb commented on issue #3650: [AIRFLOW-2703] exceptions from scheduler's heartbeat is handled so that scheduler does not crash URL: https://github.com/apache/incubator-airflow/pull/3650#issuecomment-410460440 What sort of exceptions happen here? Do we need to worry about the same error

[GitHub] ashb closed pull request #2143: [AIRFLOW-661] Add Celery broker_transport_options config

2018-08-04 Thread GitBox
ashb closed pull request #2143: [AIRFLOW-661] Add Celery broker_transport_options config URL: https://github.com/apache/incubator-airflow/pull/2143 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] ashb commented on issue #2143: [AIRFLOW-661] Add Celery broker_transport_options config

2018-08-04 Thread GitBox
ashb commented on issue #2143: [AIRFLOW-661] Add Celery broker_transport_options config URL: https://github.com/apache/incubator-airflow/pull/2143#issuecomment-410462856 Fixed in #2842. Sorry we didn't merge this one when it was first opened. (I'm doing a bit of a tidy up of old

[jira] [Updated] (AIRFLOW-2845) Remove asserts from the contrib code (change to legal exceptions)

2018-08-04 Thread Ash Berlin-Taylor (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ash Berlin-Taylor updated AIRFLOW-2845: --- Affects Version/s: (was: 1.10.1) 1.9.0 Fix

[GitHub] ashb commented on a change in pull request #3605: [AIRFLOW-1238] Decode URL-encoded characters.

2018-08-04 Thread GitBox
ashb commented on a change in pull request #3605: [AIRFLOW-1238] Decode URL-encoded characters. URL: https://github.com/apache/incubator-airflow/pull/3605#discussion_r207714364 ## File path: airflow/models.py ## @@ -686,8 +686,8 @@ def parse_from_uri(self, uri):

[GitHub] ashb commented on issue #3690: [AIRFLOW-2845] Remove asserts from the contrib package

2018-08-04 Thread GitBox
ashb commented on issue #3690: [AIRFLOW-2845] Remove asserts from the contrib package URL: https://github.com/apache/incubator-airflow/pull/3690#issuecomment-410444352 Most of the time `assert` is enabled in Python, but it _can_ be disabled so shouldn't be relied on for critical checks.

[GitHub] ashb commented on issue #2804: [AIRFLOW-528] Add missing parameter in webserver systemd file

2018-08-04 Thread GitBox
ashb commented on issue #2804: [AIRFLOW-528] Add missing parameter in webserver systemd file URL: https://github.com/apache/incubator-airflow/pull/2804#issuecomment-410461589 I also don't have any issues on Ubuntu 16.04.

[jira] [Commented] (AIRFLOW-528) airflow-webserver.service does not fork

2018-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569227#comment-16569227 ] ASF GitHub Bot commented on AIRFLOW-528: ashb closed pull request #2804: [AIRFLOW-528] Add

[GitHub] ashb closed pull request #2804: [AIRFLOW-528] Add missing parameter in webserver systemd file

2018-08-04 Thread GitBox
ashb closed pull request #2804: [AIRFLOW-528] Add missing parameter in webserver systemd file URL: https://github.com/apache/incubator-airflow/pull/2804 This is an automated message from the Apache Git Service. To respond

[GitHub] ashb commented on a change in pull request #3653: [AIRFLOW-2811] Fix scheduler_ops_metrics.py to work

2018-08-04 Thread GitBox
ashb commented on a change in pull request #3653: [AIRFLOW-2811] Fix scheduler_ops_metrics.py to work URL: https://github.com/apache/incubator-airflow/pull/3653#discussion_r207714253 ## File path: scripts/perf/scheduler_ops_metrics.py ## @@ -178,6 +181,17 @@ def

[GitHub] XD-DENG commented on issue #3678: [AIRFLOW-2839] Refine Doc Concepts->Connections

2018-08-04 Thread GitBox
XD-DENG commented on issue #3678: [AIRFLOW-2839] Refine Doc Concepts->Connections URL: https://github.com/apache/incubator-airflow/pull/3678#issuecomment-410444530 hi @kaxil , I think @ashb is right. I checked

[GitHub] XD-DENG edited a comment on issue #3678: [AIRFLOW-2839] Refine Doc Concepts->Connections

2018-08-04 Thread GitBox
XD-DENG edited a comment on issue #3678: [AIRFLOW-2839] Refine Doc Concepts->Connections URL: https://github.com/apache/incubator-airflow/pull/3678#issuecomment-410444530 hi @kaxil , I think @ashb is right. I checked

[jira] [Updated] (AIRFLOW-2849) devel requirement is not sufficient to check code quality locally

2018-08-04 Thread Eyal Trabelsi (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eyal Trabelsi updated AIRFLOW-2849: --- Description: The devel requirement doesn't list flake8, but in order to check code quality

[jira] [Commented] (AIRFLOW-2849) devel requirement is not sufficient to check code quality locally

2018-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569192#comment-16569192 ] ASF GitHub Bot commented on AIRFLOW-2849: - eyaltrabelsi opened a new pull request #3694:

[GitHub] eyaltrabelsi opened a new pull request #3694: [AIRFLOW-2849] Add missing dependency flake8 to setup to allow running code quality checks locally

2018-08-04 Thread GitBox
eyaltrabelsi opened a new pull request #3694: [AIRFLOW-2849] Add missing dependency flake8 to setup to allow running code quality checks locally URL: https://github.com/apache/incubator-airflow/pull/3694 Make sure you have checked _all_ steps below. ### Jira - [X] My PR

[GitHub] ashb commented on issue #3489: [AIRFLOW-2594][WIP] Remove implicit commits

2018-08-04 Thread GitBox
ashb commented on issue #3489: [AIRFLOW-2594][WIP] Remove implicit commits URL: https://github.com/apache/incubator-airflow/pull/3489#issuecomment-410461203 Interesting. What effect does this have on performance/load times? Would using a per-thread session available in SQLAlchemy

[jira] [Commented] (AIRFLOW-1102) 'airflow webserver' doesn't work with gunicorn 19.4+

2018-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-1102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569231#comment-16569231 ] ASF GitHub Bot commented on AIRFLOW-1102: - ashb closed pull request #2237: [AIRFLOW-1102] Add

[GitHub] ashb commented on issue #2237: [AIRFLOW-1102] Add `python:` prefix for gunicorn config to make it working with gunicorn 19.4+

2018-08-04 Thread GitBox
ashb commented on issue #2237: [AIRFLOW-1102] Add `python:` prefix for gunicorn config to make it working with gunicorn 19.4+ URL: https://github.com/apache/incubator-airflow/pull/2237#issuecomment-410462263 Closing in favour of the (merged) other PR. Now that we can close PRs \o/

[GitHub] ashb commented on issue #1998: [AIRFLOW-763] Add contrib check operator for Vertica

2018-08-04 Thread GitBox
ashb commented on issue #1998: [AIRFLOW-763] Add contrib check operator for Vertica URL: https://github.com/apache/incubator-airflow/pull/1998#issuecomment-410463216 Closing - sounds like it's not needed. This is an

[jira] [Commented] (AIRFLOW-2848) dag_id is missing in metadata table "job" for LocalTaskJob

2018-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/AIRFLOW-2848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569350#comment-16569350 ] ASF GitHub Bot commented on AIRFLOW-2848: - feng-tao closed pull request #3693: [AIRFLOW-2848]

[GitHub] feng-tao closed pull request #3693: [AIRFLOW-2848] Ensure dag_id in metadata "job" for LocalTaskJob

2018-08-04 Thread GitBox
feng-tao closed pull request #3693: [AIRFLOW-2848] Ensure dag_id in metadata "job" for LocalTaskJob URL: https://github.com/apache/incubator-airflow/pull/3693 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] feng-tao commented on issue #3693: [AIRFLOW-2848] Ensure dag_id in metadata "job" for LocalTaskJob

2018-08-04 Thread GitBox
feng-tao commented on issue #3693: [AIRFLOW-2848] Ensure dag_id in metadata "job" for LocalTaskJob URL: https://github.com/apache/incubator-airflow/pull/3693#issuecomment-410493784 lgtm, thanks for the fix. This is an

[GitHub] XD-DENG commented on issue #3693: [AIRFLOW-2848] Ensure dag_id in metadata "job" for LocalTaskJob

2018-08-04 Thread GitBox
XD-DENG commented on issue #3693: [AIRFLOW-2848] Ensure dag_id in metadata "job" for LocalTaskJob URL: https://github.com/apache/incubator-airflow/pull/3693#issuecomment-410494299 Thanks @feng-tao This is an automated

[jira] [Created] (AIRFLOW-2853) Create a CODEOWNERS file for repo

2018-08-04 Thread Andy Cooper (JIRA)
Andy Cooper created AIRFLOW-2853: Summary: Create a CODEOWNERS file for repo Key: AIRFLOW-2853 URL: https://issues.apache.org/jira/browse/AIRFLOW-2853 Project: Apache Airflow Issue Type:

[GitHub] feng-tao commented on issue #3629: AIRFLOW-2787 Allow is_backfill to handle NULL DagRun.run_id

2018-08-04 Thread GitBox
feng-tao commented on issue #3629: AIRFLOW-2787 Allow is_backfill to handle NULL DagRun.run_id URL: https://github.com/apache/incubator-airflow/pull/3629#issuecomment-410490463 Do you have a pass travis CI link for your pr in your local repo?

[GitHub] feng-tao commented on issue #3629: AIRFLOW-2787 Allow is_backfill to handle NULL DagRun.run_id

2018-08-04 Thread GitBox
feng-tao commented on issue #3629: AIRFLOW-2787 Allow is_backfill to handle NULL DagRun.run_id URL: https://github.com/apache/incubator-airflow/pull/3629#issuecomment-410490436 LGTM This is an automated message from the

[GitHub] codecov-io edited a comment on issue #3693: [AIRFLOW-2848] Ensure dag_id in metadata "job" for LocalTaskJob

2018-08-04 Thread GitBox
codecov-io edited a comment on issue #3693: [AIRFLOW-2848] Ensure dag_id in metadata "job" for LocalTaskJob URL: https://github.com/apache/incubator-airflow/pull/3693#issuecomment-410465847 # [Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/3693?src=pr=h1) Report >

[GitHub] XD-DENG commented on issue #3693: [AIRFLOW-2848] Ensure dag_id in metadata "job" for LocalTaskJob

2018-08-04 Thread GitBox
XD-DENG commented on issue #3693: [AIRFLOW-2848] Ensure dag_id in metadata "job" for LocalTaskJob URL: https://github.com/apache/incubator-airflow/pull/3693#issuecomment-410492163 Hi @ashb , as suggested, a test has been added into `tests/jobs.py` to check whether a few essential

  1   2   >