codecov-io edited a comment on issue #4304: [AIRFLOW-3500] Make task duration
display user friendly
URL:
https://github.com/apache/incubator-airflow/pull/4304#issuecomment-446217473
#
[Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4304?src=pr=h1)
Report
> Merging
ashb commented on a change in pull request #2450: [Airflow-1413] Fix FTPSensor
failing on error message with unexpected text.
URL: https://github.com/apache/incubator-airflow/pull/2450#discussion_r240663138
##
File path: airflow/contrib/sensors/ftp_sensor.py
##
@@ -26,33
jmcarp commented on issue #4225: [AIRFLOW-3383] Rotate fernet keys.
URL:
https://github.com/apache/incubator-airflow/pull/4225#issuecomment-446288858
@ashb thanks! Can you take a look and let me know if this approach makes
sense? I'll write up docs if so.
codecov-io edited a comment on issue #4305: [AIRFLOW-3397] Fix integrety error
in rbac AirflowSecurityManager
URL:
https://github.com/apache/incubator-airflow/pull/4305#issuecomment-446227203
#
[Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4305?src=pr=h1)
Report
>
ashb commented on issue #2450: [Airflow-1413] Fix FTPSensor failing on error
message with unexpected text.
URL:
https://github.com/apache/incubator-airflow/pull/2450#issuecomment-446248755
(Better late than never with a review right? Sorry it took so long!)
codecov-io commented on issue #4305: [AIRFLOW-3397] Fix integrety error in rbac
AirflowSecurityManager
URL:
https://github.com/apache/incubator-airflow/pull/4305#issuecomment-446227203
#
[Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4305?src=pr=h1)
Report
> Merging
oferze commented on issue #4304: [AIRFLOW-3500] Make task duration display user
friendly
URL:
https://github.com/apache/incubator-airflow/pull/4304#issuecomment-446230972
@ron819
> Can you update it also for the www_rbac UI?
The rbac code is very different than the current
oferze commented on issue #4304: [AIRFLOW-3500] Make task duration display user
friendly
URL:
https://github.com/apache/incubator-airflow/pull/4304#issuecomment-446282670
The Travis errors seem unrelated to this PR (false positives).
jmcarp commented on issue #4279: [AIRFLOW-3444] Explicitly set transfer
operator description.
URL:
https://github.com/apache/incubator-airflow/pull/4279#issuecomment-446288088
Ping @kaxil when you have time
This is an
ron819 commented on issue #4304: [AIRFLOW-3500] Make task duration display user
friendly
URL:
https://github.com/apache/incubator-airflow/pull/4304#issuecomment-446232380
@oferze The regular UI will be deprecated with Airflow 2.0 (as soon as
TBusen opened a new pull request #4306: added role, schema and warehouse
URL: https://github.com/apache/incubator-airflow/pull/4306
added addition connection params - current hook does not allow for
connecting with correct role ie security. current hook requires full
qualification of
ashb commented on a change in pull request #2450: [Airflow-1413] Fix FTPSensor
failing on error message with unexpected text.
URL: https://github.com/apache/incubator-airflow/pull/2450#discussion_r240663995
##
File path: airflow/contrib/sensors/ftp_sensor.py
##
@@ -26,33
ashb commented on a change in pull request #2450: [Airflow-1413] Fix FTPSensor
failing on error message with unexpected text.
URL: https://github.com/apache/incubator-airflow/pull/2450#discussion_r240662801
##
File path: airflow/contrib/sensors/ftp_sensor.py
##
@@ -26,33
odracci edited a comment on issue #3770: [AIRFLOW-3281] Fix Kubernetes operator
with git-sync
URL:
https://github.com/apache/incubator-airflow/pull/3770#issuecomment-446401293
@dimberman I was able to run minikube on mac, I think the permission problem
you faced is the mess with pip
kppullin opened a new pull request #4307: [AIRFLOW-3501] k8s executor - Support
loading dags from image.
URL: https://github.com/apache/incubator-airflow/pull/4307
### Jira
- [X] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and
Kevin Pullin created AIRFLOW-3501:
-
Summary: Add config option to load dags in an image with the
kubernetes executor.
Key: AIRFLOW-3501
URL: https://issues.apache.org/jira/browse/AIRFLOW-3501
odracci edited a comment on issue #3770: [AIRFLOW-3281] Fix Kubernetes operator
with git-sync
URL:
https://github.com/apache/incubator-airflow/pull/3770#issuecomment-446401293
@dimberman I was able to run minikube on mac, I think the permission problem
you faced is the mess with pip
mik-laj commented on a change in pull request #4298: [AIRFLOW-3478] Make sure
that the session is closed
URL: https://github.com/apache/incubator-airflow/pull/4298#discussion_r240831704
##
File path: airflow/bin/cli.py
##
@@ -456,14 +448,12 @@ def _run(args, dag, ti):
dimberman commented on issue #3683: [AIRFLOW-2770] kubernetes: add support for
dag folder in the docker i…
URL:
https://github.com/apache/incubator-airflow/pull/3683#issuecomment-446398981
@yeluolei @Fokko @odracci can we merge this first since #3770 seems to be
having some issues?
mik-laj commented on a change in pull request #4286: [AIRFLOW-3310] Google
Cloud Spanner deploy / delete operators
URL: https://github.com/apache/incubator-airflow/pull/4286#discussion_r240833136
##
File path: airflow/contrib/hooks/gcp_spanner_hook.py
##
@@ -0,0 +1,183 @@
[
https://issues.apache.org/jira/browse/AIRFLOW-3397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16717700#comment-16717700
]
ASF GitHub Bot commented on AIRFLOW-3397:
-
feng-tao closed pull request #4305: [AIRFLOW-3397]
feng-tao closed pull request #4305: [AIRFLOW-3397] Fix integrety error in rbac
AirflowSecurityManager
URL: https://github.com/apache/incubator-airflow/pull/4305
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of
codecov-io edited a comment on issue #4307: [AIRFLOW-3501] k8s executor -
Support loading dags from image.
URL:
https://github.com/apache/incubator-airflow/pull/4307#issuecomment-446426559
#
[Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4307?src=pr=h1)
Report
>
dimberman commented on issue #3683: [AIRFLOW-2770] kubernetes: add support for
dag folder in the docker i…
URL:
https://github.com/apache/incubator-airflow/pull/3683#issuecomment-446399355
also @kaxil with there being an open issue on the git mode, this would be
pretty
odracci commented on issue #3770: [AIRFLOW-3281] Fix Kubernetes operator with
git-sync
URL:
https://github.com/apache/incubator-airflow/pull/3770#issuecomment-446401293
@dimberman I was able to run minikube on mac, I think the permission problem
you faced is the mess with pip install in
[
https://issues.apache.org/jira/browse/AIRFLOW-3501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16718294#comment-16718294
]
ASF GitHub Bot commented on AIRFLOW-3501:
-
kppullin opened a new pull request #4307:
codecov-io commented on issue #4307: [AIRFLOW-3501] k8s executor - Support
loading dags from image.
URL:
https://github.com/apache/incubator-airflow/pull/4307#issuecomment-446426559
#
[Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4307?src=pr=h1)
Report
> Merging
odracci commented on issue #3770: [AIRFLOW-3281] Fix Kubernetes operator with
git-sync
URL:
https://github.com/apache/incubator-airflow/pull/3770#issuecomment-446402481
@dimberman I realised now that your problem is different, I ran airflow with
minikube locally using kubernetes provided
sprzedwojski commented on a change in pull request #4286: [AIRFLOW-3310] Google
Cloud Spanner deploy / delete operators
URL: https://github.com/apache/incubator-airflow/pull/4286#discussion_r240738144
##
File path: airflow/contrib/hooks/gcp_spanner_hook.py
##
@@ -0,0
sprzedwojski commented on a change in pull request #4286: [AIRFLOW-3310] Google
Cloud Spanner deploy / delete operators
URL: https://github.com/apache/incubator-airflow/pull/4286#discussion_r240738070
##
File path: airflow/contrib/hooks/gcp_spanner_hook.py
##
@@ -0,0
sprzedwojski commented on a change in pull request #4286: [AIRFLOW-3310] Google
Cloud Spanner deploy / delete operators
URL: https://github.com/apache/incubator-airflow/pull/4286#discussion_r240738257
##
File path: airflow/contrib/hooks/gcp_spanner_hook.py
##
@@ -0,0
sprzedwojski commented on a change in pull request #4286: [AIRFLOW-3310] Google
Cloud Spanner deploy / delete operators
URL: https://github.com/apache/incubator-airflow/pull/4286#discussion_r240738196
##
File path: airflow/contrib/hooks/gcp_spanner_hook.py
##
@@ -0,0
forsberg commented on issue #2319: [AIRFLOW-1236] SlackPostOperator using Slack
Incoming WebHook
URL:
https://github.com/apache/incubator-airflow/pull/2319#issuecomment-446326867
@SamWildmo Well. I have since changed job, so I'm not working neither with
Airflow (although that might
forsberg closed pull request #2319: [AIRFLOW-1236] SlackPostOperator using
Slack Incoming WebHook
URL: https://github.com/apache/incubator-airflow/pull/2319
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of
forsberg commented on issue #2319: [AIRFLOW-1236] SlackPostOperator using Slack
Incoming WebHook
URL:
https://github.com/apache/incubator-airflow/pull/2319#issuecomment-446343460
However, I think it has been superseded by
https://github.com/apache/incubator-airflow/pull/3129 which is
sprzedwojski commented on issue #4286: [AIRFLOW-3310] Google Cloud Spanner
deploy / delete operators
URL:
https://github.com/apache/incubator-airflow/pull/4286#issuecomment-446316033
Hi @kaxil, thanks for the review! I've applied all of your comments and
added some other small fixes
[
https://issues.apache.org/jira/browse/AIRFLOW-1236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16717900#comment-16717900
]
ASF GitHub Bot commented on AIRFLOW-1236:
-
forsberg closed pull request #2319: [AIRFLOW-1236]
Gabriel Silk created AIRFLOW-3502:
-
Summary: Add config option to control celery pool used
Key: AIRFLOW-3502
URL: https://issues.apache.org/jira/browse/AIRFLOW-3502
Project: Apache Airflow
[
https://issues.apache.org/jira/browse/AIRFLOW-3501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16718492#comment-16718492
]
ASF GitHub Bot commented on AIRFLOW-3501:
-
gsilk opened a new pull request #4308:
gsilk opened a new pull request #4308: [AIRFLOW-3501] Add celery config option
for setting "pool"
URL: https://github.com/apache/incubator-airflow/pull/4308
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
XD-DENG commented on issue #4306: added role, schema and warehouse
URL:
https://github.com/apache/incubator-airflow/pull/4306#issuecomment-446449797
@TBusen Please follow the instructions in the PR msg template (create JIRA
ticket, fill in the PR msg template, and prepend the JIRA ticket
Fokko commented on a change in pull request #2306: [AIRFLOW-1214] Fix
conversion of int type in BigQueryHook
URL: https://github.com/apache/incubator-airflow/pull/2306#discussion_r240505319
##
File path: airflow/contrib/hooks/bigquery_hook.py
##
@@ -915,7 +915,7 @@ def
jongyoul commented on issue #4057: [AIRFLOW-3216] HiveServer2Hook need a
password with LDAP authentication
URL:
https://github.com/apache/incubator-airflow/pull/4057#issuecomment-446133119
CI become green. Please check this PR.
[
https://issues.apache.org/jira/browse/AIRFLOW-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ash Berlin-Taylor resolved AIRFLOW-1158.
Resolution: Fixed
Fixed by a different change that switched over to boto3
>
[
https://issues.apache.org/jira/browse/AIRFLOW-2965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ash Berlin-Taylor resolved AIRFLOW-2965.
Resolution: Fixed
Fix Version/s: 1.10.2
> Add CLI command to find the
[
https://issues.apache.org/jira/browse/AIRFLOW-2965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ash Berlin-Taylor reopened AIRFLOW-2965:
Re-opening to set fix-version
> Add CLI command to find the next dag run.
>
[
https://issues.apache.org/jira/browse/AIRFLOW-532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ash Berlin-Taylor resolved AIRFLOW-532.
---
Resolution: Duplicate
> DB API hook's insert rows sets autocommit non-generically
>
gsakkis commented on issue #2052: [AIRFLOW-833] Add an `airflow default_config`
sub-command
URL:
https://github.com/apache/incubator-airflow/pull/2052#issuecomment-446162282
Bump
This is an automated message from the Apache
gsakkis commented on issue #2014: [AIRFLOW-796] Config options for num_runs,
processor_poll_interval, log_level
URL:
https://github.com/apache/incubator-airflow/pull/2014#issuecomment-446162206
Bump
This is an automated
[
https://issues.apache.org/jira/browse/AIRFLOW-2805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ash Berlin-Taylor resolved AIRFLOW-2805.
Resolution: Fixed
Fix Version/s: 2.0.0
> Display user's local timezone
codecov-io edited a comment on issue #4057: [AIRFLOW-3216] HiveServer2Hook need
a password with LDAP authentication
URL:
https://github.com/apache/incubator-airflow/pull/4057#issuecomment-430262980
#
[Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4057?src=pr=h1)
Report
[
https://issues.apache.org/jira/browse/AIRFLOW-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16716489#comment-16716489
]
jack commented on AIRFLOW-532:
--
[~ashb] can you close this?
> DB API hook's insert rows sets autocommit
jongyoul commented on issue #4057: [AIRFLOW-3216] HiveServer2Hook need a
password with LDAP authentication
URL:
https://github.com/apache/incubator-airflow/pull/4057#issuecomment-446118676
@Fokko Rebased.
This is an
codecov-io edited a comment on issue #4057: [AIRFLOW-3216] HiveServer2Hook need
a password with LDAP authentication
URL:
https://github.com/apache/incubator-airflow/pull/4057#issuecomment-430262980
#
[Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4057?src=pr=h1)
Report
Fokko commented on issue #4057: [AIRFLOW-3216] HiveServer2Hook need a password
with LDAP authentication
URL:
https://github.com/apache/incubator-airflow/pull/4057#issuecomment-446109562
@jongyoul Could you rebase onto latest master? That one looks to be okay:
[
https://issues.apache.org/jira/browse/AIRFLOW-2265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16716497#comment-16716497
]
jack commented on AIRFLOW-2265:
---
Hi [~yampelo] you can use the mailing list for some input. Also note
Fokko commented on issue #4298: [AIRFLOW-3478] Make sure that the session is
closed
URL:
https://github.com/apache/incubator-airflow/pull/4298#issuecomment-446114815
Ah, now I see what we're doing. We're keeping the objects, but the session
can already be closed. The error:
```
shizidushu commented on issue #3834: [AIRFLOW-2965] CLI tool to show the next
execution datetime
URL:
https://github.com/apache/incubator-airflow/pull/3834#issuecomment-446118022
Please release 1.10.2 with this PR. Thanks!
[
https://issues.apache.org/jira/browse/AIRFLOW-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16716518#comment-16716518
]
jack commented on AIRFLOW-1158:
---
According to the pull request this is no longer needed because Airflow
codecov-io edited a comment on issue #2420: [AIRFLOW-1383] Add no_dag_reset
option to airflow clear command
URL:
https://github.com/apache/incubator-airflow/pull/2420#issuecomment-313447404
#
[Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/2420?src=pr=h1)
Report
>
feng-tao commented on issue #4305: [AIRFLOW-3397] Fix integrety error in rbac
AirflowSecurityManager
URL:
https://github.com/apache/incubator-airflow/pull/4305#issuecomment-446301765
thanks @BrechtDeVlieger for the fix. It makes sense. With your change I
assume the integrety error is
ashb commented on issue #2014: [AIRFLOW-796] Config options for num_runs,
processor_poll_interval, log_level
URL:
https://github.com/apache/incubator-airflow/pull/2014#issuecomment-446169278
Log_level iss now a config setting.
Remove that, rebase, and test that setting the
ProtossChris created AIRFLOW-3498:
-
Summary: airflow cli subcommand - trigger_dag not working
Key: AIRFLOW-3498
URL: https://issues.apache.org/jira/browse/AIRFLOW-3498
Project: Apache Airflow
[
https://issues.apache.org/jira/browse/AIRFLOW-3499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
jack updated AIRFLOW-3499:
--
Description:
*Motivation:*
I have few operators who uses Variable. The variable is updated consistently
ashb commented on issue #2014: [AIRFLOW-796] Config options for num_runs,
processor_poll_interval, log_level
URL:
https://github.com/apache/incubator-airflow/pull/2014#issuecomment-446169612
(And sorry for leaving the PR for so long. I realise you've already rebased
once and nothing
[
https://issues.apache.org/jira/browse/AIRFLOW-3498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ProtossChris updated AIRFLOW-3498:
--
Summary: airflow cli subcommand - trigger_dag not working when start_date =
[
https://issues.apache.org/jira/browse/AIRFLOW-3498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ProtossChris updated AIRFLOW-3498:
--
Description:
Using
{code:bash}
airflow trigger_dag
{code}
to trigger specific dag with
jack created AIRFLOW-3499:
-
Summary: Add flag to Opeators to write the Render to the log.
Key: AIRFLOW-3499
URL: https://issues.apache.org/jira/browse/AIRFLOW-3499
Project: Apache Airflow
Issue
stale[bot] commented on issue #3748: [AIRFLOW-2899] Hide sensitive data when
Exporting Variables
URL:
https://github.com/apache/incubator-airflow/pull/3748#issuecomment-446183458
This issue has been automatically marked as stale because it has not had
recent activity. It will be closed
[
https://issues.apache.org/jira/browse/AIRFLOW-3498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ProtossChris updated AIRFLOW-3498:
--
Description:
1. problem : with these default args
{code:python}
default_args = {
oferze opened a new pull request #4304: [AIRFLOW-3500] Make task duration
display user friendly
URL: https://github.com/apache/incubator-airflow/pull/4304
Make sure you have checked _all_ steps below.
### Jira
- [X] My PR addresses the following [Airflow
[
https://issues.apache.org/jira/browse/AIRFLOW-3500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16717162#comment-16717162
]
ASF GitHub Bot commented on AIRFLOW-3500:
-
oferze opened a new pull request #4304:
BrechtDeVlieger opened a new pull request #4305: [AIRFLOW-3397] Fix integrety
error in rbac AirflowSecurityManager
URL: https://github.com/apache/incubator-airflow/pull/4305
This was caused by the variable `role` being shadowed in a loop statement.
Make sure you have checked _all_
[
https://issues.apache.org/jira/browse/AIRFLOW-3500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Work on AIRFLOW-3500 started by Ofer Zelig.
---
> Make task duration display user friendly
>
Ofer Zelig created AIRFLOW-3500:
---
Summary: Make task duration display user friendly
Key: AIRFLOW-3500
URL: https://issues.apache.org/jira/browse/AIRFLOW-3500
Project: Apache Airflow
Issue
[
https://issues.apache.org/jira/browse/AIRFLOW-3397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16717206#comment-16717206
]
ASF GitHub Bot commented on AIRFLOW-3397:
-
BrechtDeVlieger opened a new pull request #4305:
[
https://issues.apache.org/jira/browse/AIRFLOW-3494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin Campbell updated AIRFLOW-3494:
Affects Version/s: (was: 1.10.2)
1.10.1
> Dask executor has
codecov-io commented on issue #4304: [AIRFLOW-3500] Make task duration display
user friendly
URL:
https://github.com/apache/incubator-airflow/pull/4304#issuecomment-446217473
#
[Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4304?src=pr=h1)
Report
> Merging
codecov-io edited a comment on issue #4304: [AIRFLOW-3500] Make task duration
display user friendly
URL:
https://github.com/apache/incubator-airflow/pull/4304#issuecomment-446217473
#
[Codecov](https://codecov.io/gh/apache/incubator-airflow/pull/4304?src=pr=h1)
Report
> Merging
ashb commented on issue #4305: [AIRFLOW-3397] Fix integrety error in rbac
AirflowSecurityManager
URL:
https://github.com/apache/incubator-airflow/pull/4305#issuecomment-446217278
If this was a bug then this needs a unit test to prevent regressions please.
My understanding though
XD-DENG commented on a change in pull request #4304: [AIRFLOW-3500] Make task
duration display user friendly
URL: https://github.com/apache/incubator-airflow/pull/4304#discussion_r240627014
##
File path: airflow/www/templates/airflow/graph.html
##
@@ -282,13 +282,21 @@
oferze commented on a change in pull request #4304: [AIRFLOW-3500] Make task
duration display user friendly
URL: https://github.com/apache/incubator-airflow/pull/4304#discussion_r240627558
##
File path: airflow/www/templates/airflow/graph.html
##
@@ -282,13 +282,21 @@
ashb commented on issue #4305: [AIRFLOW-3397] Fix integrety error in rbac
AirflowSecurityManager
URL:
https://github.com/apache/incubator-airflow/pull/4305#issuecomment-446218198
Ah, I'm too used to python3:
```
>>> x = 'foo'
>>> x
'foo'
>>> [x for x in ('bar','baz')]
XD-DENG commented on a change in pull request #4304: [AIRFLOW-3500] Make task
duration display user friendly
URL: https://github.com/apache/incubator-airflow/pull/4304#discussion_r240627965
##
File path: airflow/www/templates/airflow/graph.html
##
@@ -282,13 +282,21 @@
oferze commented on a change in pull request #4304: [AIRFLOW-3500] Make task
duration display user friendly
URL: https://github.com/apache/incubator-airflow/pull/4304#discussion_r240628326
##
File path: airflow/www/templates/airflow/graph.html
##
@@ -282,13 +282,21 @@
ron819 commented on issue #4304: [AIRFLOW-3500] Make task duration display user
friendly
URL:
https://github.com/apache/incubator-airflow/pull/4304#issuecomment-446220860
Can you update it also for the www_rbac UI?
This is
86 matches
Mail list logo
