[GitHub] incubator-ariatosca pull request #189: ARIA-174 Refactor instantiation phase

2017-08-09 Thread AviaE
Github user AviaE commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/189#discussion_r132137988 --- Diff: aria/orchestrator/topology/topology.py --- @@ -50,28 +49,33 @@ class Topology(issue.Reporter): models.Type: models.Type

[GitHub] incubator-ariatosca pull request #189: ARIA-174 Refactor instantiation phase

2017-08-09 Thread AviaE
Github user AviaE commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/189#discussion_r132140607 --- Diff: aria/utils/console.py --- @@ -31,51 +31,51 @@ class TopologyStylizer(object): -def __init__(self, indentation=2)

[GitHub] incubator-ariatosca pull request #189: ARIA-174 Refactor instantiation phase

2017-08-09 Thread AviaE
Github user AviaE commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/189#discussion_r132137184 --- Diff: aria/orchestrator/topology/topology.py --- @@ -50,28 +49,33 @@ class Topology(issue.Reporter): models.Type: models.Type

[GitHub] incubator-ariatosca pull request #189: ARIA-174 Refactor instantiation phase

2017-08-09 Thread AviaE
Github user AviaE commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/189#discussion_r132137742 --- Diff: aria/orchestrator/topology/topology.py --- @@ -50,28 +49,33 @@ class Topology(issue.Reporter): models.Type: models.Type

[GitHub] incubator-ariatosca pull request #189: ARIA-174 Refactor instantiation phase

2017-08-09 Thread AviaE
Github user AviaE commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/189#discussion_r132137574 --- Diff: aria/orchestrator/topology/topology.py --- @@ -50,28 +49,33 @@ class Topology(issue.Reporter): models.Type: models.Type

[GitHub] incubator-ariatosca pull request #189: ARIA-174 Refactor instantiation phase

2017-08-09 Thread AviaE
Github user AviaE commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/189#discussion_r132127229 --- Diff: aria/orchestrator/topology/instance_handler.py --- @@ -527,78 +539,82 @@ def satisfy_requirements(self): for node

[GitHub] incubator-ariatosca pull request #189: ARIA-174 Refactor instantiation phase

2017-08-09 Thread AviaE
Github user AviaE commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/189#discussion_r132129612 --- Diff: aria/orchestrator/topology/template_handler.py --- @@ -61,9 +64,9 @@ def instantiate(self, instance_cls, inputs=None): )

[GitHub] incubator-ariatosca pull request #189: ARIA-174 Refactor instantiation phase

2017-08-09 Thread AviaE
Github user AviaE commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/189#discussion_r132125166 --- Diff: aria/orchestrator/topology/common.py --- @@ -14,39 +14,53 @@ # limitations under the License. -class _Handler(object

[GitHub] incubator-ariatosca pull request #189: ARIA-174 Refactor instantiation phase

2017-08-09 Thread AviaE
Github user AviaE commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/189#discussion_r132122306 --- Diff: aria/core.py --- @@ -74,18 +74,19 @@ def create_service(self, service_template_id, inputs, service_name=None): # setting no

[GitHub] incubator-ariatosca pull request #189: ARIA-174 Refactor instantiation phase

2017-08-09 Thread AviaE
Github user AviaE commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/189#discussion_r132122736 --- Diff: aria/core.py --- @@ -117,8 +118,8 @@ def delete_service(self, service_id, force=False): def _parse_service_template(service_temp

[GitHub] incubator-ariatosca pull request #189: ARIA-174 Refactor instantiation phase

2017-08-09 Thread AviaE
Github user AviaE commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/189#discussion_r132136296 --- Diff: aria/orchestrator/topology/template_handler.py --- @@ -584,13 +588,20 @@ def instantiate(self, instance_cls): return o

[GitHub] incubator-ariatosca pull request #189: ARIA-174 Refactor instantiation phase

2017-08-09 Thread AviaE
Github user AviaE commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/189#discussion_r131950842 --- Diff: aria/core.py --- @@ -117,8 +118,8 @@ def delete_service(self, service_id, force=False): def _parse_service_template(service_temp

[GitHub] incubator-ariatosca pull request #189: ARIA-174 Refactor instantiation phase

2017-08-09 Thread AviaE
Github user AviaE commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/189#discussion_r132127179 --- Diff: aria/orchestrator/topology/instance_handler.py --- @@ -527,78 +539,82 @@ def satisfy_requirements(self): for node

[GitHub] incubator-ariatosca pull request #189: ARIA-174 Refactor instantiation phase

2017-08-09 Thread AviaE
Github user AviaE commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/189#discussion_r132123698 --- Diff: aria/modeling/utils.py --- @@ -175,7 +175,7 @@ def init(*args, **kwargs): return cls -def get_class_from_relatio

[GitHub] incubator-ariatosca pull request #189: ARIA-174 Refactor instantiation phase

2017-08-09 Thread AviaE
Github user AviaE commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/189#discussion_r132123290 --- Diff: aria/modeling/service_template.py --- @@ -530,6 +530,43 @@ def _next_name(self): return '{name}_{index}'.format(name=s

[GitHub] incubator-ariatosca pull request #189: ARIA-174 Refactor instantiation phase

2017-08-09 Thread AviaE
Github user AviaE commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/189#discussion_r132127992 --- Diff: aria/orchestrator/topology/instance_handler.py --- @@ -527,78 +539,82 @@ def satisfy_requirements(self): for node

[GitHub] incubator-ariatosca pull request #189: ARIA-174 Refactor instantiation phase

2017-08-09 Thread AviaE
Github user AviaE commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/189#discussion_r132127314 --- Diff: aria/orchestrator/topology/instance_handler.py --- @@ -527,78 +539,82 @@ def satisfy_requirements(self): for node

incubator-ariatosca git commit: review fix 2

2017-08-09 Thread mxmrlv
Repository: incubator-ariatosca Updated Branches: refs/heads/ARIA-174-Refactor-instantiation-phase 0cdec5298 -> 679bc81c5 review fix 2 Project: http://git-wip-us.apache.org/repos/asf/incubator-ariatosca/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-ariatosca/commit/679bc81c T

[2/8] incubator-ariatosca git commit: wip

2017-08-09 Thread mxmrlv
http://git-wip-us.apache.org/repos/asf/incubator-ariatosca/blob/56841a4d/aria/parser/consumption/consumer.py -- diff --git a/aria/parser/consumption/consumer.py b/aria/parser/consumption/consumer.py index 4f4c614..fb60d66 100644 -

[4/8] incubator-ariatosca git commit: wip

2017-08-09 Thread mxmrlv
wip Project: http://git-wip-us.apache.org/repos/asf/incubator-ariatosca/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-ariatosca/commit/56841a4d Tree: http://git-wip-us.apache.org/repos/asf/incubator-ariatosca/tree/56841a4d Diff: http://git-wip-us.apache.org/repos/asf/incubator-ar

[8/8] incubator-ariatosca git commit: review fix 2

2017-08-09 Thread mxmrlv
review fix 2 Project: http://git-wip-us.apache.org/repos/asf/incubator-ariatosca/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-ariatosca/commit/2a4527c7 Tree: http://git-wip-us.apache.org/repos/asf/incubator-ariatosca/tree/2a4527c7 Diff: http://git-wip-us.apache.org/repos/asf/inc

[3/8] incubator-ariatosca git commit: wip

2017-08-09 Thread mxmrlv
http://git-wip-us.apache.org/repos/asf/incubator-ariatosca/blob/56841a4d/aria/modeling/utils.py -- diff --git a/aria/modeling/utils.py b/aria/modeling/utils.py index 274eb88..5218b81 100644 --- a/aria/modeling/utils.py +++ b/aria/m

[1/8] incubator-ariatosca git commit: ARIA-324 Refactor ctx proxy access [Forced Update!]

2017-08-09 Thread mxmrlv
Repository: incubator-ariatosca Updated Branches: refs/heads/ARIA-174-Refactor-instantiation-phase 679bc81c5 -> 2a4527c75 (forced update) ARIA-324 Refactor ctx proxy access Our previous use of "." to delimit nested dict keys was wrong (keys could have a ".") and inflexible. The new implementa

[5/8] incubator-ariatosca git commit: self fixes

2017-08-09 Thread mxmrlv
self fixes Project: http://git-wip-us.apache.org/repos/asf/incubator-ariatosca/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-ariatosca/commit/6c5c4a67 Tree: http://git-wip-us.apache.org/repos/asf/incubator-ariatosca/tree/6c5c4a67 Diff: http://git-wip-us.apache.org/repos/asf/incub

[7/8] incubator-ariatosca git commit: review 1

2017-08-09 Thread mxmrlv
review 1 Project: http://git-wip-us.apache.org/repos/asf/incubator-ariatosca/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-ariatosca/commit/1f937296 Tree: http://git-wip-us.apache.org/repos/asf/incubator-ariatosca/tree/1f937296 Diff: http://git-wip-us.apache.org/repos/asf/incubat

[6/8] incubator-ariatosca git commit: review 1

2017-08-09 Thread mxmrlv
http://git-wip-us.apache.org/repos/asf/incubator-ariatosca/blob/1f937296/aria/parser/presentation/fields.py -- diff --git a/aria/parser/presentation/fields.py b/aria/parser/presentation/fields.py index 9de2f7b..5c08d4a 100644 ---

incubator-ariatosca git commit: review fix 2 [Forced Update!]

2017-08-09 Thread mxmrlv
Repository: incubator-ariatosca Updated Branches: refs/heads/ARIA-174-Refactor-instantiation-phase 2a4527c75 -> b7f7ff7a8 (forced update) review fix 2 Project: http://git-wip-us.apache.org/repos/asf/incubator-ariatosca/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-ariatosca/

[GitHub] incubator-ariatosca pull request #189: ARIA-174 Refactor instantiation phase

2017-08-09 Thread AviaE
Github user AviaE commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/189#discussion_r132168007 --- Diff: aria/orchestrator/topology/template_handler.py --- @@ -431,15 +430,14 @@ def dump(self, out_stream): out_stream.write('Subst

[GitHub] incubator-ariatosca pull request #189: ARIA-174 Refactor instantiation phase

2017-08-09 Thread AviaE
Github user AviaE commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/189#discussion_r132167801 --- Diff: aria/orchestrator/topology/instance_handler.py --- @@ -550,7 +550,7 @@ def dump(self, out_stream): out_stream.write('Substit

[GitHub] incubator-ariatosca pull request #189: ARIA-174 Refactor instantiation phase

2017-08-09 Thread AviaE
Github user AviaE commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/189#discussion_r132167856 --- Diff: aria/core.py --- @@ -118,8 +118,8 @@ def delete_service(self, service_id, force=False): def _parse_service_template(service_temp

[GitHub] incubator-ariatosca pull request #189: ARIA-174 Refactor instantiation phase

2017-08-09 Thread AviaE
Github user AviaE commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/189#discussion_r132168198 --- Diff: aria/orchestrator/topology/topology.py --- @@ -51,17 +51,17 @@ class Topology(issue.ReporterMixin): def __init__(self, *ar

[GitHub] incubator-ariatosca pull request #189: ARIA-174 Refactor instantiation phase

2017-08-09 Thread AviaE
Github user AviaE commented on a diff in the pull request: https://github.com/apache/incubator-ariatosca/pull/189#discussion_r132167947 --- Diff: aria/orchestrator/topology/template_handler.py --- @@ -47,7 +47,7 @@ def coerce(self, **kwargs): self._model.wo

[3/3] incubator-ariatosca git commit: ARIA-174 Refactor instantiation phase

2017-08-09 Thread mxmrlv
ARIA-174 Refactor instantiation phase The main issue this PR addressed was the consolidation of instantiation mechanism into a single package - `topology`. The code itself got additional refactory: 1. `dump` no longer prints onto the console but rather return a string representation to be printe

[1/3] incubator-ariatosca git commit: ARIA-174 Refactor instantiation phase [Forced Update!]

2017-08-09 Thread mxmrlv
Repository: incubator-ariatosca Updated Branches: refs/heads/ARIA-174-Refactor-instantiation-phase b7f7ff7a8 -> 4ad587422 (forced update) http://git-wip-us.apache.org/repos/asf/incubator-ariatosca/blob/4ad58742/aria/orchestrator/topology/topology.py

[2/3] incubator-ariatosca git commit: ARIA-174 Refactor instantiation phase

2017-08-09 Thread mxmrlv
http://git-wip-us.apache.org/repos/asf/incubator-ariatosca/blob/4ad58742/aria/modeling/utils.py -- diff --git a/aria/modeling/utils.py b/aria/modeling/utils.py index 274eb88..305020b 100644 --- a/aria/modeling/utils.py +++ b/aria/m

[1/3] incubator-ariatosca git commit: ARIA-174 Refactor instantiation phase [Forced Update!]

2017-08-09 Thread mxmrlv
Repository: incubator-ariatosca Updated Branches: refs/heads/ARIA-174-Refactor-instantiation-phase 4ad587422 -> df2b916e6 (forced update) http://git-wip-us.apache.org/repos/asf/incubator-ariatosca/blob/df2b916e/aria/orchestrator/topology/topology.py

[2/3] incubator-ariatosca git commit: ARIA-174 Refactor instantiation phase

2017-08-09 Thread mxmrlv
http://git-wip-us.apache.org/repos/asf/incubator-ariatosca/blob/df2b916e/aria/modeling/utils.py -- diff --git a/aria/modeling/utils.py b/aria/modeling/utils.py index 274eb88..305020b 100644 --- a/aria/modeling/utils.py +++ b/aria/m

[3/3] incubator-ariatosca git commit: ARIA-174 Refactor instantiation phase

2017-08-09 Thread mxmrlv
ARIA-174 Refactor instantiation phase The main issue this PR addressed was the consolidation of instantiation mechanism into a single package - `topology`. The code itself got additional refactoring: 1. `dump` no longer prints onto the console but rather returns a string representation to be pri

[3/3] incubator-ariatosca git commit: ARIA-174 Refactor instantiation phase

2017-08-09 Thread mxmrlv
ARIA-174 Refactor instantiation phase The main issue this PR addressed was the consolidation of instantiation mechanism into a single package - `topology`. The code itself got additional refactoring: 1. `dump` no longer prints onto the console but rather returns a string representation to be pri

[2/3] incubator-ariatosca git commit: ARIA-174 Refactor instantiation phase

2017-08-09 Thread mxmrlv
http://git-wip-us.apache.org/repos/asf/incubator-ariatosca/blob/df2b916e/aria/modeling/utils.py -- diff --git a/aria/modeling/utils.py b/aria/modeling/utils.py index 274eb88..305020b 100644 --- a/aria/modeling/utils.py +++ b/aria/m

[incubator-ariatosca] Git Push Summary

2017-08-09 Thread mxmrlv
Repository: incubator-ariatosca Updated Branches: refs/heads/ARIA-174-Refactor-instantiation-phase [deleted] df2b916e6

[1/3] incubator-ariatosca git commit: ARIA-174 Refactor instantiation phase

2017-08-09 Thread mxmrlv
Repository: incubator-ariatosca Updated Branches: refs/heads/master a43bc6b17 -> df2b916e6 http://git-wip-us.apache.org/repos/asf/incubator-ariatosca/blob/df2b916e/aria/orchestrator/topology/topology.py -- diff --git a/aria/orc

[GitHub] incubator-ariatosca pull request #189: ARIA-174 Refactor instantiation phase

2017-08-09 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-ariatosca/pull/189 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[2/5] incubator-ariatosca git commit: ARIA-174 Refactor instantiation phase

2017-08-09 Thread emblemparade
http://git-wip-us.apache.org/repos/asf/incubator-ariatosca/blob/df2b916e/aria/modeling/utils.py -- diff --git a/aria/modeling/utils.py b/aria/modeling/utils.py index 274eb88..305020b 100644 --- a/aria/modeling/utils.py +++ b/aria/m

[5/5] incubator-ariatosca git commit: ARIA-321 Provide Clearwater IMS example

2017-08-09 Thread emblemparade
ARIA-321 Provide Clearwater IMS example * Allows capabilities, interfaces, and properties to override parent definition types only if the new type is a descendant of the overridden type * Fix bugs in model instrumentation (to allow ctx access to capability properties and complex values) * Fix to g

[1/5] incubator-ariatosca git commit: ARIA-174 Refactor instantiation phase [Forced Update!]

2017-08-09 Thread emblemparade
Repository: incubator-ariatosca Updated Branches: refs/heads/ARIA-321-clearwater 531b6006d -> 40be30864 (forced update) http://git-wip-us.apache.org/repos/asf/incubator-ariatosca/blob/df2b916e/aria/orchestrator/topology/topology.py ---

[4/5] incubator-ariatosca git commit: ARIA-321 Provide Clearwater IMS example

2017-08-09 Thread emblemparade
http://git-wip-us.apache.org/repos/asf/incubator-ariatosca/blob/40be3086/extensions/aria_extension_tosca/profiles/tosca-simple-1.0/data.yaml -- diff --git a/extensions/aria_extension_tosca/profiles/tosca-simple-1.0/data.yaml b/ex

[3/5] incubator-ariatosca git commit: ARIA-174 Refactor instantiation phase

2017-08-09 Thread emblemparade
ARIA-174 Refactor instantiation phase The main issue this PR addressed was the consolidation of instantiation mechanism into a single package - `topology`. The code itself got additional refactoring: 1. `dump` no longer prints onto the console but rather returns a string representation to be pri

[1/2] incubator-ariatosca git commit: ARIA-321 Provide Clearwater IMS example [Forced Update!]

2017-08-09 Thread emblemparade
Repository: incubator-ariatosca Updated Branches: refs/heads/ARIA-321-clearwater 40be30864 -> 328914285 (forced update) http://git-wip-us.apache.org/repos/asf/incubator-ariatosca/blob/32891428/extensions/aria_extension_tosca/profiles/tosca-simple-1.0/artifacts.yaml -

[2/2] incubator-ariatosca git commit: ARIA-321 Provide Clearwater IMS example

2017-08-09 Thread emblemparade
ARIA-321 Provide Clearwater IMS example * Allows capabilities, interfaces, and properties to override parent definition types only if the new type is a descendant of the overridden type * Fix bugs in model instrumentation (to allow ctx access to capability properties and complex values) * Fix to g