Github user mxmrlv commented on a diff in the pull request:
https://github.com/apache/incubator-ariatosca/pull/207#discussion_r149669453
--- Diff: extensions/aria_extension_tosca/simple_v1_0/assignments.py ---
@@ -144,6 +144,17 @@ def _get_type(self, context):
# In
Github user mxmrlv commented on a diff in the pull request:
https://github.com/apache/incubator-ariatosca/pull/207#discussion_r149664387
--- Diff: aria/modeling/service_common.py ---
@@ -587,12 +588,11 @@ class MetadataBase(TemplateModelMixin):
:ivar name: name
Github user mxmrlv commented on a diff in the pull request:
https://github.com/apache/incubator-ariatosca/pull/207#discussion_r149667052
--- Diff: aria/parser/consumption/presentation.py ---
@@ -13,65 +13,52 @@
# See the License for the specific language governing permissions
Github user mxmrlv commented on a diff in the pull request:
https://github.com/apache/incubator-ariatosca/pull/207#discussion_r149671678
--- Diff:
tests/extensions/aria_extension_tosca/simple_nfv_v1_0/test_profile.py ---
@@ -0,0 +1,20 @@
+# Licensed to the Apache Software
Github user tliron commented on the issue:
https://github.com/apache/incubator-ariatosca/pull/199
@mxmrlv You didn't address these:
1. Let's move this to `from aria.utils.yaml import yaml`. I don't think the
aria `__init__.py` is the right place for this.
2. Let's go over
Github user tliron commented on a diff in the pull request:
https://github.com/apache/incubator-ariatosca/pull/207#discussion_r149718206
--- Diff:
tests/extensions/aria_extension_tosca/simple_nfv_v1_0/test_profile.py ---
@@ -0,0 +1,20 @@
+# Licensed to the Apache Software
Github user mxmrlv commented on the issue:
https://github.com/apache/incubator-ariatosca/pull/199
@tliron any additional comments? or should i merge?
---
Repository: incubator-ariatosca
Updated Branches:
refs/heads/ARIA-392-Failing-to-load-ruamel.yaml d51cf9394 -> df77c8df0
(forced update)
ARIA-392 Failing to load ruamel.yaml
Project: http://git-wip-us.apache.org/repos/asf/incubator-ariatosca/repo
Commit:
Repository: incubator-ariatosca
Updated Branches:
refs/heads/ARIA-392-Failing-to-load-ruamel.yaml df77c8df0 -> 3fe790d6d
(forced update)
ARIA-392 Failing to load ruamel.yaml
Project: http://git-wip-us.apache.org/repos/asf/incubator-ariatosca/repo
Commit:
Repository: incubator-ariatosca
Updated Branches:
refs/heads/ARIA-392-Failing-to-load-ruamel.yaml 3fe790d6d -> 730750f3d
(forced update)
ARIA-392 Failing to load ruamel.yaml
Project: http://git-wip-us.apache.org/repos/asf/incubator-ariatosca/repo
Commit:
Github user mxmrlv commented on the issue:
https://github.com/apache/incubator-ariatosca/pull/199
so, i think we're ready
---
Repository: incubator-ariatosca
Updated Branches:
refs/heads/ARIA-392-Failing-to-load-ruamel.yaml f32c752f1 -> a0e8738d2
review 2 fixups
Project: http://git-wip-us.apache.org/repos/asf/incubator-ariatosca/repo
Commit:
Repository: incubator-ariatosca
Updated Branches:
refs/heads/ARIA-392-Failing-to-load-ruamel.yaml 5ea90c1c5 -> 3d05ac506
(forced update)
ARIA-392 Failing to load ruamel.yaml
Project: http://git-wip-us.apache.org/repos/asf/incubator-ariatosca/repo
Commit:
Github user mxmrlv commented on the issue:
https://github.com/apache/incubator-ariatosca/pull/199
This code only runs once, it doesn't provide with a patched up ruamel, it
patched the loading mechanism...so loading should work everywhere, as long as
the code was run...
---
Repository: incubator-ariatosca
Updated Branches:
refs/heads/ARIA-392-Failing-to-load-ruamel.yaml 3d05ac506 -> d51cf9394
(forced update)
ARIA-392 Failing to load ruamel.yaml
Project: http://git-wip-us.apache.org/repos/asf/incubator-ariatosca/repo
Commit:
Github user mxmrlv commented on the issue:
https://github.com/apache/incubator-ariatosca/pull/199
OK, np just wanted to make sure we're on the same page...
---
Github user tliron commented on the issue:
https://github.com/apache/incubator-ariatosca/pull/199
Still, I don't see why it should be in `aria/__init__.py` and be always
activated. I think it should be in activated only for a module that
specifically is using ruamel. It would
Repository: incubator-ariatosca-website
Updated Branches:
refs/heads/master 07d16f7eb -> 49c29d3b8
fixing menu link
Project: http://git-wip-us.apache.org/repos/asf/incubator-ariatosca-website/repo
Commit:
http://git-wip-us.apache.org/repos/asf/incubator-ariatosca-website/commit/49c29d3b
Repository: incubator-ariatosca-website
Updated Branches:
refs/heads/asf-site 03047b7e5 -> 72b8d1e80
Automatic Site Publish by Buildbot
Project: http://git-wip-us.apache.org/repos/asf/incubator-ariatosca-website/repo
Commit:
19 matches
Mail list logo