[jira] [Work logged] (BEAM-3900) Introduce Euphoria Java 8 DSL
[ https://issues.apache.org/jira/browse/BEAM-3900?focusedWorklogId=153055&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-153055 ] ASF GitHub Bot logged work on BEAM-3900: Author: ASF GitHub Bot Created on: 10/Oct/18 07:29 Start Date: 10/Oct/18 07:29 Worklog Time Spent: 10m Work Description: VaclavPlajt commented on issue #5783: [BEAM-3900] Improvements in Metrics translation, composite transforms, tests and win. API URL: https://github.com/apache/beam/pull/5783#issuecomment-428467374 Hi, this PR definitely stall. Thanks for your comment. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 153055) Time Spent: 2.5h (was: 2h 20m) > Introduce Euphoria Java 8 DSL > - > > Key: BEAM-3900 > URL: https://issues.apache.org/jira/browse/BEAM-3900 > Project: Beam > Issue Type: New Feature > Components: dsl-euphoria >Reporter: David Moravek >Assignee: David Moravek >Priority: Major > Time Spent: 2.5h > Remaining Estimate: 0h > > This is the umbrella issue for integrating [Euphoria > API|http://github.com/seznam/euphoria] into Beam. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-3900) Introduce Euphoria Java 8 DSL
[ https://issues.apache.org/jira/browse/BEAM-3900?focusedWorklogId=152880&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-152880 ] ASF GitHub Bot logged work on BEAM-3900: Author: ASF GitHub Bot Created on: 09/Oct/18 19:32 Start Date: 09/Oct/18 19:32 Worklog Time Spent: 10m Work Description: akedin commented on issue #5783: [BEAM-3900] Improvements in Metrics translation, composite transforms, tests and win. API URL: https://github.com/apache/beam/pull/5783#issuecomment-428321456 Is this PR in progress or should we close it as stale? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 152880) Time Spent: 2h 20m (was: 2h 10m) > Introduce Euphoria Java 8 DSL > - > > Key: BEAM-3900 > URL: https://issues.apache.org/jira/browse/BEAM-3900 > Project: Beam > Issue Type: New Feature > Components: dsl-euphoria >Reporter: David Moravek >Assignee: David Moravek >Priority: Major > Time Spent: 2h 20m > Remaining Estimate: 0h > > This is the umbrella issue for integrating [Euphoria > API|http://github.com/seznam/euphoria] into Beam. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-3900) Introduce Euphoria Java 8 DSL
[ https://issues.apache.org/jira/browse/BEAM-3900?focusedWorklogId=152248&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-152248 ] ASF GitHub Bot logged work on BEAM-3900: Author: ASF GitHub Bot Created on: 08/Oct/18 13:57 Start Date: 08/Oct/18 13:57 Worklog Time Spent: 10m Work Description: VaclavPlajt opened a new pull request #6601: [BEAM-3900] Euphoria API URL: https://github.com/apache/beam/pull/6601 Euphoria API. Please see (documentation)[website/src/documentation/sdks/euphoria.md]. Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). It will help us expedite review of your Pull Request if you tag someone (e.g. `@username`) to look at it. Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/) | --- | --- | --- | --- | --- | --- Java | [](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/) Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/) [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/) | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 152248) Time Spent: 2h 10m (was: 2h) > Introduce Euphoria Java 8 DSL > - > > Key: BEAM-3900 > URL: https://issues.apache.org/jira/browse/BEAM-3900 > Project: Beam > Issue Type: New Feature > Components: dsl-euphoria >Reporter: David Moravek >Assignee: David Moravek >
[jira] [Work logged] (BEAM-3900) Introduce Euphoria Java 8 DSL
[ https://issues.apache.org/jira/browse/BEAM-3900?focusedWorklogId=122312&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-122312 ] ASF GitHub Bot logged work on BEAM-3900: Author: ASF GitHub Bot Created on: 12/Jul/18 11:39 Start Date: 12/Jul/18 11:39 Worklog Time Spent: 10m Work Description: mareksimunek commented on issue #5783: [BEAM-3900] Improvements in Metrics translation, composite transforms, tests and win. API URL: https://github.com/apache/beam/pull/5783#issuecomment-404483111 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 122312) Time Spent: 2h (was: 1h 50m) > Introduce Euphoria Java 8 DSL > - > > Key: BEAM-3900 > URL: https://issues.apache.org/jira/browse/BEAM-3900 > Project: Beam > Issue Type: New Feature > Components: dsl-euphoria >Reporter: David Moravek >Assignee: David Moravek >Priority: Major > Time Spent: 2h > Remaining Estimate: 0h > > This is the umbrella issue for integrating [Euphoria > API|http://github.com/seznam/euphoria] into Beam. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-3900) Introduce Euphoria Java 8 DSL
[ https://issues.apache.org/jira/browse/BEAM-3900?focusedWorklogId=121860&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-121860 ] ASF GitHub Bot logged work on BEAM-3900: Author: ASF GitHub Bot Created on: 11/Jul/18 11:06 Start Date: 11/Jul/18 11:06 Worklog Time Spent: 10m Work Description: VaclavPlajt commented on issue #5783: [BEAM-3900] Improvements in Metrics translation, composite transforms, tests and win. API URL: https://github.com/apache/beam/pull/5783#issuecomment-404131603 please retest this This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 121860) Time Spent: 1h 50m (was: 1h 40m) > Introduce Euphoria Java 8 DSL > - > > Key: BEAM-3900 > URL: https://issues.apache.org/jira/browse/BEAM-3900 > Project: Beam > Issue Type: New Feature > Components: dsl-euphoria >Reporter: David Moravek >Assignee: David Moravek >Priority: Major > Time Spent: 1h 50m > Remaining Estimate: 0h > > This is the umbrella issue for integrating [Euphoria > API|http://github.com/seznam/euphoria] into Beam. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-3900) Introduce Euphoria Java 8 DSL
[ https://issues.apache.org/jira/browse/BEAM-3900?focusedWorklogId=121281&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-121281 ] ASF GitHub Bot logged work on BEAM-3900: Author: ASF GitHub Bot Created on: 10/Jul/18 08:20 Start Date: 10/Jul/18 08:20 Worklog Time Spent: 10m Work Description: VaclavPlajt commented on issue #5735: [BEAM-3900] Improvements in Metrics translation, composite transforms, tests and windowing API. URL: https://github.com/apache/beam/pull/5735#issuecomment-403740287 See: https://github.com/apache/beam/pull/5783 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 121281) Time Spent: 1h 40m (was: 1.5h) > Introduce Euphoria Java 8 DSL > - > > Key: BEAM-3900 > URL: https://issues.apache.org/jira/browse/BEAM-3900 > Project: Beam > Issue Type: New Feature > Components: dsl-euphoria >Reporter: David Moravek >Assignee: David Moravek >Priority: Major > Time Spent: 1h 40m > Remaining Estimate: 0h > > This is the umbrella issue for integrating [Euphoria > API|http://github.com/seznam/euphoria] into Beam. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-3900) Introduce Euphoria Java 8 DSL
[
https://issues.apache.org/jira/browse/BEAM-3900?focusedWorklogId=121279&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-121279
]
ASF GitHub Bot logged work on BEAM-3900:
Author: ASF GitHub Bot
Created on: 10/Jul/18 08:19
Start Date: 10/Jul/18 08:19
Worklog Time Spent: 10m
Work Description: VaclavPlajt commented on a change in pull request
#5735: [BEAM-3900] Improvements in Metrics translation, composite transforms,
tests and windowing API.
URL: https://github.com/apache/beam/pull/5735#discussion_r201253791
##
File path: sdks/java/extensions/euphoria/euphoria-core/build.gradle
##
@@ -21,10 +21,31 @@ applyJavaNature(enableFindbugs: false)
description = "Apache Beam :: SDKs :: Java :: Extensions :: Euphoria Java 8
DSL :: Core"
+ext {
+kryoVersion = '2.24.0'
+}
+
dependencies {
+shadow project(path: ":beam-sdks-java-core", configuration: "shadow")
+compile "com.esotericsoftware.kryo:kryo:${kryoVersion}"
shadow library.java.guava
-shadow library.java.slf4j_api
compileOnly library.java.findbugs_jsr305
testCompile library.java.mockito_core
testCompile project(path: ':beam-sdks-java-extensions-euphoria-testing')
-}
\ No newline at end of file
+shadow 'com.google.code.findbugs:annotations:3.0.+'
+testCompile library.java.slf4j_api
+testCompile library.java.hamcrest_core
+testCompile library.java.slf4j_simple
+testCompile library.java.mockito_core
+testCompile project(path: ":beam-sdks-java-core", configuration:
"testArtifact")
Review comment:
The suggested change was made in
68fa362. See https://github.com/apache/beam/pull/5783 for more context.
Thanks.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 121279)
Time Spent: 1h 20m (was: 1h 10m)
> Introduce Euphoria Java 8 DSL
> -
>
> Key: BEAM-3900
> URL: https://issues.apache.org/jira/browse/BEAM-3900
> Project: Beam
> Issue Type: New Feature
> Components: dsl-euphoria
>Reporter: David Moravek
>Assignee: David Moravek
>Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> This is the umbrella issue for integrating [Euphoria
> API|http://github.com/seznam/euphoria] into Beam.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-3900) Introduce Euphoria Java 8 DSL
[ https://issues.apache.org/jira/browse/BEAM-3900?focusedWorklogId=116864&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-116864 ] ASF GitHub Bot logged work on BEAM-3900: Author: ASF GitHub Bot Created on: 28/Jun/18 16:20 Start Date: 28/Jun/18 16:20 Worklog Time Spent: 10m Work Description: kennknowles commented on issue #5783: [BEAM-3900] Rebased dsl euphoria URL: https://github.com/apache/beam/pull/5783#issuecomment-401092029 We have turned on autoformatting of the codebase, which causes small conflicts across the board. You can probably safely rebase and just keep your changes. Like this: ``` $ git rebase ... see some conflicts $ git diff ... confirmed that the conflicts are just autoformatting ... so we can just keep our changes are do our own autoformat $ git checkout --theirs -- $ git add -u $ git rebase --continue $ ./gradlew spotlessJavaApply ``` Please ping me if you run into any difficulty. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 116864) Time Spent: 1h 10m (was: 1h) > Introduce Euphoria Java 8 DSL > - > > Key: BEAM-3900 > URL: https://issues.apache.org/jira/browse/BEAM-3900 > Project: Beam > Issue Type: New Feature > Components: dsl-euphoria >Reporter: David Moravek >Assignee: David Moravek >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > This is the umbrella issue for integrating [Euphoria > API|http://github.com/seznam/euphoria] into Beam. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-3900) Introduce Euphoria Java 8 DSL
[ https://issues.apache.org/jira/browse/BEAM-3900?focusedWorklogId=116434&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-116434 ] ASF GitHub Bot logged work on BEAM-3900: Author: ASF GitHub Bot Created on: 27/Jun/18 14:23 Start Date: 27/Jun/18 14:23 Worklog Time Spent: 10m Work Description: VaclavPlajt opened a new pull request #5783: [BEAM-3900] Rebased dsl euphoria URL: https://github.com/apache/beam/pull/5783 Description will follow. This serves as way to run jenkins CI. Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). It will help us expedite review of your Pull Request if you tag someone (e.g. `@username`) to look at it. Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataflow | Flink | Gearpump | Spark --- | --- | --- | --- | --- | --- | --- Go | [](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/) | --- | --- | --- | --- | --- Java | [](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/) Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/) [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | --- | --- | --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 116434) Time Spent: 1h (was: 50m) > Introduce Euphoria Java 8 DSL > - > > Key: BEAM-3900 > URL: https://issues.apache.org/jira/browse/BEAM-3900 > Project: Beam > Issue Type: New Feature > Components: dsl-euphoria >Reporter: David Moravek >Assignee: David Moravek >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > This is the umbrella issue for integrating [Euphoria > API|http://github.com/seznam/euphoria] into Beam. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-3900) Introduce Euphoria Java 8 DSL
[
https://issues.apache.org/jira/browse/BEAM-3900?focusedWorklogId=116041&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-116041
]
ASF GitHub Bot logged work on BEAM-3900:
Author: ASF GitHub Bot
Created on: 26/Jun/18 17:15
Start Date: 26/Jun/18 17:15
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #5735:
[BEAM-3900] Improvements in Metrics translation, composite transforms, tests
and windowing API.
URL: https://github.com/apache/beam/pull/5735#discussion_r198227995
##
File path: sdks/java/extensions/euphoria/euphoria-core/build.gradle
##
@@ -21,10 +21,31 @@ applyJavaNature(enableFindbugs: false)
description = "Apache Beam :: SDKs :: Java :: Extensions :: Euphoria Java 8
DSL :: Core"
+ext {
+kryoVersion = '2.24.0'
+}
+
dependencies {
+shadow project(path: ":beam-sdks-java-core", configuration: "shadow")
+compile "com.esotericsoftware.kryo:kryo:${kryoVersion}"
shadow library.java.guava
-shadow library.java.slf4j_api
compileOnly library.java.findbugs_jsr305
testCompile library.java.mockito_core
testCompile project(path: ':beam-sdks-java-extensions-euphoria-testing')
-}
\ No newline at end of file
+shadow 'com.google.code.findbugs:annotations:3.0.+'
+testCompile library.java.slf4j_api
+testCompile library.java.hamcrest_core
+testCompile library.java.slf4j_simple
+testCompile library.java.mockito_core
+testCompile project(path: ":beam-sdks-java-core", configuration:
"testArtifact")
Review comment:
You should be relying on the `shadowTest` configuration and not
`testArtifact`.
This will remove the need for you to define the `testArtifact` in
`sdks/java/core`
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 116041)
Time Spent: 50m (was: 40m)
> Introduce Euphoria Java 8 DSL
> -
>
> Key: BEAM-3900
> URL: https://issues.apache.org/jira/browse/BEAM-3900
> Project: Beam
> Issue Type: New Feature
> Components: dsl-euphoria
>Reporter: David Moravek
>Assignee: David Moravek
>Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> This is the umbrella issue for integrating [Euphoria
> API|http://github.com/seznam/euphoria] into Beam.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Work logged] (BEAM-3900) Introduce Euphoria Java 8 DSL
[ https://issues.apache.org/jira/browse/BEAM-3900?focusedWorklogId=114789&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-114789 ] ASF GitHub Bot logged work on BEAM-3900: Author: ASF GitHub Bot Created on: 22/Jun/18 14:50 Start Date: 22/Jun/18 14:50 Worklog Time Spent: 10m Work Description: VaclavPlajt commented on issue #5735: [BEAM-3900] Improvements in Metrics translation, composite transforms, tests and windowing API. URL: https://github.com/apache/beam/pull/5735#issuecomment-399468879 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 114789) Time Spent: 40m (was: 0.5h) > Introduce Euphoria Java 8 DSL > - > > Key: BEAM-3900 > URL: https://issues.apache.org/jira/browse/BEAM-3900 > Project: Beam > Issue Type: New Feature > Components: dsl-euphoria >Reporter: David Moravek >Assignee: David Moravek >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > This is the umbrella issue for integrating [Euphoria > API|http://github.com/seznam/euphoria] into Beam. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-3900) Introduce Euphoria Java 8 DSL
[ https://issues.apache.org/jira/browse/BEAM-3900?focusedWorklogId=114730&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-114730 ] ASF GitHub Bot logged work on BEAM-3900: Author: ASF GitHub Bot Created on: 22/Jun/18 11:38 Start Date: 22/Jun/18 11:38 Worklog Time Spent: 10m Work Description: VaclavPlajt opened a new pull request #5735: [BEAM-3900] Improvements in Metrics translation, composite transforms, tests and windowing API. URL: https://github.com/apache/beam/pull/5735 List of improvements: * Larger portfolio of Euphoria test suite was enabled. * Translation of Euphoria Accumulators to Beam Metrics was added. * Euphoria windowing API adapted to Beam windowing. * Operator's API now consumes type hints to allow set coders automatically. * Composite transforms can be defined through Euphoria API. * Cleanup: Flipping tests fixed, Euphoria executor concept removed, two project modules where merged R: @jbonofre Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). It will help us expedite review of your Pull Request if you tag someone (e.g. `@username`) to look at it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 114730) Time Spent: 0.5h (was: 20m) > Introduce Euphoria Java 8 DSL > - > > Key: BEAM-3900 > URL: https://issues.apache.org/jira/browse/BEAM-3900 > Project: Beam > Issue Type: New Feature > Components: dsl-euphoria >Reporter: David Moravek >Assignee: David Moravek >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > This is the umbrella issue for integrating [Euphoria > API|http://github.com/seznam/euphoria] into Beam. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (BEAM-3900) Introduce Euphoria Java 8 DSL
[
https://issues.apache.org/jira/browse/BEAM-3900?focusedWorklogId=108519&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-108519
]
ASF GitHub Bot logged work on BEAM-3900:
Author: ASF GitHub Bot
Created on: 04/Jun/18 11:50
Start Date: 04/Jun/18 11:50
Worklog Time Spent: 10m
Work Description: jbonofre closed pull request #5447: [BEAM-3900] Join
operator translation, Beam windowing, new tests from operator testsuite enabled
.
URL: https://github.com/apache/beam/pull/5447
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/.test-infra/jenkins/job_beam_PreCommit_Java_GradleBuild.groovy
b/.test-infra/jenkins/job_beam_PreCommit_Java_GradleBuild.groovy
index 56af6da64a4..ce67d399ea6 100644
--- a/.test-infra/jenkins/job_beam_PreCommit_Java_GradleBuild.groovy
+++ b/.test-infra/jenkins/job_beam_PreCommit_Java_GradleBuild.groovy
@@ -44,8 +44,6 @@ job('beam_PreCommit_Java_GradleBuild') {
rootBuildScriptDir(common_job_properties.checkoutDir)
tasks(':javaPreCommit')
common_job_properties.setGradleSwitches(delegate)
- // Specify maven home on Jenkins, needed by Maven archetype integration
tests.
- switches('-Pmaven_home=/home/jenkins/tools/maven/apache-maven-3.5.2')
}
}
}
diff --git a/build.gradle b/build.gradle
index b00cfa27f54..840ce611e04 100644
--- a/build.gradle
+++ b/build.gradle
@@ -137,8 +137,6 @@ task javaPreCommit() {
dependsOn ":rat"
dependsOn ":beam-sdks-java-core:buildNeeded"
dependsOn ":beam-sdks-java-core:buildDependents"
- dependsOn
":beam-sdks-java-maven-archetypes-examples:generateAndBuildArchetypeTest"
- dependsOn
":beam-sdks-java-maven-archetypes-starter:generateAndBuildArchetypeTest"
dependsOn ":beam-examples-java:preCommit"
}
diff --git a/sdks/java/extensions/euphoria/euphoria-beam/build.gradle
b/sdks/java/extensions/euphoria/euphoria-beam/build.gradle
index 2d5cb36e453..60d35bdc101 100644
--- a/sdks/java/extensions/euphoria/euphoria-beam/build.gradle
+++ b/sdks/java/extensions/euphoria/euphoria-beam/build.gradle
@@ -29,12 +29,10 @@ dependencies {
compile "com.esotericsoftware.kryo:kryo:${kryoVersion}"
shadow project(path: ":beam-sdks-java-core", configuration: "shadow")
shadow 'com.google.code.findbugs:annotations:3.0.1'
-testCompile project(':beam-sdks-java-extensions-euphoria-operator-testkit')
testCompile project(':beam-sdks-java-extensions-euphoria-testing')
testCompile project(':beam-runners-direct-java')
testCompile library.java.slf4j_api
testCompile library.java.hamcrest_core
-
}
test.testLogging.showStandardStreams = true
diff --git
a/sdks/java/extensions/euphoria/euphoria-beam/src/main/java/org/apache/beam/sdk/extensions/euphoria/beam/FlowTranslator.java
b/sdks/java/extensions/euphoria/euphoria-beam/src/main/java/org/apache/beam/sdk/extensions/euphoria/beam/FlowTranslator.java
index e03a65e424a..581abec9f46 100644
---
a/sdks/java/extensions/euphoria/euphoria-beam/src/main/java/org/apache/beam/sdk/extensions/euphoria/beam/FlowTranslator.java
+++
b/sdks/java/extensions/euphoria/euphoria-beam/src/main/java/org/apache/beam/sdk/extensions/euphoria/beam/FlowTranslator.java
@@ -17,14 +17,17 @@
*/
package org.apache.beam.sdk.extensions.euphoria.beam;
-import java.util.IdentityHashMap;
-import java.util.Map;
+import com.google.common.collect.ArrayListMultimap;
+import com.google.common.collect.Multimap;
+import java.util.Collection;
+import javax.annotation.Nullable;
import org.apache.beam.sdk.Pipeline;
import org.apache.beam.sdk.extensions.euphoria.beam.io.BeamWriteSink;
import
org.apache.beam.sdk.extensions.euphoria.core.client.accumulators.AccumulatorProvider;
import org.apache.beam.sdk.extensions.euphoria.core.client.flow.Flow;
import org.apache.beam.sdk.extensions.euphoria.core.client.io.DataSink;
import org.apache.beam.sdk.extensions.euphoria.core.client.operator.FlatMap;
+import org.apache.beam.sdk.extensions.euphoria.core.client.operator.Join;
import org.apache.beam.sdk.extensions.euphoria.core.client.operator.Operator;
import
org.apache.beam.sdk.extensions.euphoria.core.client.operator.ReduceByKey;
import
org.apache.beam.sdk.extensions.euphoria.core.client.operator.ReduceStateByKey;
@@ -43,8 +46,10 @@
*/
class FlowTranslator {
- private static final Map translators = new
IdentityHashMap<>();
+ private static final Multimap translators =
ArrayListMultimap.create();
+ //Note that when there are more than one translator ordering defines
priority.
+ //First added to `translators` is first asked whenever it can translate the
operator.
static {
translators.put(FlowUnfolder.InputOp
[jira] [Work logged] (BEAM-3900) Introduce Euphoria Java 8 DSL
[ https://issues.apache.org/jira/browse/BEAM-3900?focusedWorklogId=104524&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-104524 ] ASF GitHub Bot logged work on BEAM-3900: Author: ASF GitHub Bot Created on: 22/May/18 07:35 Start Date: 22/May/18 07:35 Worklog Time Spent: 10m Work Description: VaclavPlajt opened a new pull request #5447: [BEAM-3900] Join operator translation, Beam windowing, new tests from operator testsuite enabled . URL: https://github.com/apache/beam/pull/5447 New Euphoria Join operator translation into Beam Pipeline transformations and ability to set Beam windowing through Euphoria API is introduced in this pull request. Also most of preexisting tests from operator test suite where migrated to beam windowing where applicable. Follow this checklist to help us incorporate your contribution quickly and easily: - [X] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). It will help us expedite review of your Pull Request if you tag someone (e.g. `@username`) to look at it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 104524) Time Spent: 10m Remaining Estimate: 0h > Introduce Euphoria Java 8 DSL > - > > Key: BEAM-3900 > URL: https://issues.apache.org/jira/browse/BEAM-3900 > Project: Beam > Issue Type: New Feature > Components: dsl-euphoria >Reporter: David Moravek >Assignee: David Moravek >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > This is the umbrella issue for integrating [Euphoria > API|http://github.com/seznam/euphoria] into Beam. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
