[jira] [Commented] (BEAM-755) beam-runners-core-java RunnableOnService tests not executing
[ https://issues.apache.org/jira/browse/BEAM-755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15583165#comment-15583165 ] ASF GitHub Bot commented on BEAM-755: - GitHub user kennknowles opened a pull request: https://github.com/apache/incubator-beam/pull/1116 [BEAM-755] Fix typo in DirectRunner dependenciesToScan Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [x] Make sure the PR title is formatted like: `[BEAM-] Description of pull request` - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable Travis-CI on your fork and ensure the whole test matrix passes). - [x] Replace `` in the title with the actual Jira issue number, if there is one. - [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt). --- R: @tgroh AND @lukecwik You can merge this pull request into a Git repository by running: $ git pull https://github.com/kennknowles/incubator-beam runners-core-DirectRunner Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-beam/pull/1116.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1116 commit 115e929dddca1006f7054e2a5b88e8f8272fc20d Author: Kenneth Knowles Date: 2016-10-17T19:10:31Z Fix typo in DirectRunner dependenciesToScan > beam-runners-core-java RunnableOnService tests not executing > > > Key: BEAM-755 > URL: https://issues.apache.org/jira/browse/BEAM-755 > Project: Beam > Issue Type: Bug > Components: runner-core >Reporter: Luke Cwik >Assignee: Kenneth Knowles > > org.apache.beam:beam-runners-core-java is not specified as an integration > test dependency to scan within runners/pom.xml > There is also in runners/direct-java/pom.xml where its > org.apache.beam:beam-runners-java-core and should be > org.apache.beam:beam-runners-core-java > Finally, even if these dependencies are added and the typo fixed. When > running the runnable on service integration tests, SplittableParDoTest which > contains @RunnableOnService tests (part of runners/core-java) doesn't execute. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (BEAM-755) beam-runners-core-java RunnableOnService tests not executing
[
https://issues.apache.org/jira/browse/BEAM-755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15583158#comment-15583158
]
Kenneth Knowles commented on BEAM-755:
--
I have reconsidered this.
I assert that runners-core can have {{NeedsRunner}} tests but not
{{RunnableOnService}} tests. Tests labeled {{NeedsRunner}} are tests of the
support code, not the runner, and we need to execute it via _some_ runner, in
practice the {{DirectRunner}}.
But {{RunnableOnService}} is shorthand for "tests a capability in the public
model" thus they must be in the SDK.
The only test affected by the issue here is {{SplittableParDoTest}}. The test
methods there are actually suitable to be in {{ParDoTest}} with a capability
tag {{SplittableDoFn}}.
> beam-runners-core-java RunnableOnService tests not executing
>
>
> Key: BEAM-755
> URL: https://issues.apache.org/jira/browse/BEAM-755
> Project: Beam
> Issue Type: Bug
> Components: runner-core
>Reporter: Luke Cwik
>Assignee: Kenneth Knowles
>
> org.apache.beam:beam-runners-core-java is not specified as an integration
> test dependency to scan within runners/pom.xml
> There is also in runners/direct-java/pom.xml where its
> org.apache.beam:beam-runners-java-core and should be
> org.apache.beam:beam-runners-core-java
> Finally, even if these dependencies are added and the typo fixed. When
> running the runnable on service integration tests, SplittableParDoTest which
> contains @RunnableOnService tests (part of runners/core-java) doesn't execute.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (BEAM-755) beam-runners-core-java RunnableOnService tests not executing
[ https://issues.apache.org/jira/browse/BEAM-755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15583078#comment-15583078 ] Kenneth Knowles commented on BEAM-755: -- I'll take a peek. This is a crufty corner of the poms. > beam-runners-core-java RunnableOnService tests not executing > > > Key: BEAM-755 > URL: https://issues.apache.org/jira/browse/BEAM-755 > Project: Beam > Issue Type: Bug > Components: runner-core >Reporter: Luke Cwik >Assignee: Kenneth Knowles > > org.apache.beam:beam-runners-core-java is not specified as an integration > test dependency to scan within runners/pom.xml > There is also in runners/direct-java/pom.xml where its > org.apache.beam:beam-runners-java-core and should be > org.apache.beam:beam-runners-core-java > Finally, even if these dependencies are added and the typo fixed. When > running the runnable on service integration tests, SplittableParDoTest which > contains @RunnableOnService tests (part of runners/core-java) doesn't execute. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
