[GitHub] [calcite] Technay closed pull request #1446: Rav 995

2019-09-10 Thread GitBox
Technay closed pull request #1446: Rav 995 URL: https://github.com/apache/calcite/pull/1446 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [calcite] jinxing64 commented on a change in pull request #1448: [CALCITE-3332] Query failed with AssertionError: cannot cast null as class java.math.BigDecima

2019-09-10 Thread GitBox
jinxing64 commented on a change in pull request #1448: [CALCITE-3332] Query failed with AssertionError: cannot cast null as class java.math.BigDecima URL: https://github.com/apache/calcite/pull/1448#discussion_r322631131 ## File path:

[GitHub] [calcite] jinxing64 commented on a change in pull request #1448: [CALCITE-3332] Query failed with AssertionError: cannot cast null as class java.math.BigDecima

2019-09-10 Thread GitBox
jinxing64 commented on a change in pull request #1448: [CALCITE-3332] Query failed with AssertionError: cannot cast null as class java.math.BigDecima URL: https://github.com/apache/calcite/pull/1448#discussion_r322630270 ## File path:

[GitHub] [calcite] jinxing64 commented on issue #1448: [CALCITE-3332] Query failed with AssertionError: cannot cast null as class java.math.BigDecima

2019-09-10 Thread GitBox
jinxing64 commented on issue #1448: [CALCITE-3332] Query failed with AssertionError: cannot cast null as class java.math.BigDecima URL: https://github.com/apache/calcite/pull/1448#issuecomment-529846512 In current code of `SqlOperatorBinding#isOperandNull`, the doc for param of allowCast

[GitHub] [calcite] jinxing64 commented on issue #1448: [CALCITE-3332] Query failed with AssertionError: cannot cast null as class java.math.BigDecima

2019-09-10 Thread GitBox
jinxing64 commented on issue #1448: [CALCITE-3332] Query failed with AssertionError: cannot cast null as class java.math.BigDecima URL: https://github.com/apache/calcite/pull/1448#issuecomment-529847100 Thanks for your fix @DonnyZone and it's good for me overall ~ I left minor comments

[GitHub] [calcite] DonnyZone commented on a change in pull request #1448: [CALCITE-3332] Query failed with AssertionError: cannot cast null as class java.math.BigDecima

2019-09-10 Thread GitBox
DonnyZone commented on a change in pull request #1448: [CALCITE-3332] Query failed with AssertionError: cannot cast null as class java.math.BigDecima URL: https://github.com/apache/calcite/pull/1448#discussion_r322639276 ## File path:

[GitHub] [calcite] DonnyZone commented on a change in pull request #1448: [CALCITE-3332] Query failed with AssertionError: cannot cast null as class java.math.BigDecima

2019-09-10 Thread GitBox
DonnyZone commented on a change in pull request #1448: [CALCITE-3332] Query failed with AssertionError: cannot cast null as class java.math.BigDecima URL: https://github.com/apache/calcite/pull/1448#discussion_r322643119 ## File path:

[GitHub] [calcite] danny0405 opened a new pull request #1450: [CALCITE-3331] Support implicit type cast for operators that use sing…

2019-09-10 Thread GitBox
danny0405 opened a new pull request #1450: [CALCITE-3331] Support implicit type cast for operators that use sing… URL: https://github.com/apache/calcite/pull/1450 …le operand family checker * Add doc to SqlSingleOperandTypeChecker#checkSingleOperandType to note that we should not

[GitHub] [calcite] asereda-gs commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host…

2019-09-10 Thread GitBox
asereda-gs commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host… URL: https://github.com/apache/calcite/pull/1447#discussion_r322920295 ## File path:

[GitHub] [calcite] shikhasomani commented on issue #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host…

2019-09-10 Thread GitBox
shikhasomani commented on issue #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host… URL: https://github.com/apache/calcite/pull/1447#issuecomment-530091587 > Pls squash commits into one and add your name to commit message as `(FirstName LastName)` Squashed

[GitHub] [calcite] asereda-gs commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host…

2019-09-10 Thread GitBox
asereda-gs commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host… URL: https://github.com/apache/calcite/pull/1447#discussion_r322903291 ## File path:

[GitHub] [calcite] shikhasomani commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host…

2019-09-10 Thread GitBox
shikhasomani commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host… URL: https://github.com/apache/calcite/pull/1447#discussion_r322928195 ## File path:

[GitHub] [calcite] JulianFeinauer opened a new pull request #1449: [CALCITE-3302] Implement CLASSIFIER and LAST function for MATCH_RECOG…

2019-09-10 Thread GitBox
JulianFeinauer opened a new pull request #1449: [CALCITE-3302] Implement CLASSIFIER and LAST function for MATCH_RECOG… URL: https://github.com/apache/calcite/pull/1449 …NIZE. I added several tests to match.iq which show - CLASSIFIER function - LAST without CLASSIFIER (*.xxx)

[GitHub] [calcite] DonnyZone commented on issue #1448: [CALCITE-3332] Query failed with AssertionError: cannot cast null as class java.math.BigDecima

2019-09-10 Thread GitBox
DonnyZone commented on issue #1448: [CALCITE-3332] Query failed with AssertionError: cannot cast null as class java.math.BigDecima URL: https://github.com/apache/calcite/pull/1448#issuecomment-529866488 According to the current semantics in `SqlUtil#isNullLiteral`, we can replace the word

svn commit: r35738 - in /release/calcite/apache-calcite-1.21.0: ./ apache-calcite-1.21.0-src.tar.gz apache-calcite-1.21.0-src.tar.gz.asc apache-calcite-1.21.0-src.tar.gz.sha256

2019-09-10 Thread zabetak
Author: zabetak Date: Tue Sep 10 21:45:27 2019 New Revision: 35738 Log: Release apache-calcite-1.21.0 Added: release/calcite/apache-calcite-1.21.0/ release/calcite/apache-calcite-1.21.0/apache-calcite-1.21.0-src.tar.gz (with props)

[GitHub] [calcite] asereda-gs edited a comment on issue #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host…

2019-09-10 Thread GitBox
asereda-gs edited a comment on issue #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host… URL: https://github.com/apache/calcite/pull/1447#issuecomment-530133618 Pls read [contributing doc](https://calcite.apache.org/develop/#contributing). JIRA id should be in

[GitHub] [calcite] shikhasomani commented on issue #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host…

2019-09-10 Thread GitBox
shikhasomani commented on issue #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host… URL: https://github.com/apache/calcite/pull/1447#issuecomment-530143301 Done This is an automated message from

[GitHub] [calcite] danny0405 commented on a change in pull request #1444: [CALCITE-3329] Implement osquery for OS adapter

2019-09-10 Thread GitBox
danny0405 commented on a change in pull request #1444: [CALCITE-3329] Implement osquery for OS adapter URL: https://github.com/apache/calcite/pull/1444#discussion_r323029232 ## File path: site/_docs/os_adapter.md ## @@ -258,6 +258,209 @@ $ ./sqlsh select distinct

[GitHub] [calcite] danny0405 commented on a change in pull request #1444: [CALCITE-3329] Implement osquery for OS adapter

2019-09-10 Thread GitBox
danny0405 commented on a change in pull request #1444: [CALCITE-3329] Implement osquery for OS adapter URL: https://github.com/apache/calcite/pull/1444#discussion_r323028739 ## File path: plus/src/main/java/org/apache/calcite/adapter/os/OsQueryTableUtils.java ## @@ -0,0

[GitHub] [calcite] danny0405 commented on a change in pull request #1444: [CALCITE-3329] Implement osquery for OS adapter

2019-09-10 Thread GitBox
danny0405 commented on a change in pull request #1444: [CALCITE-3329] Implement osquery for OS adapter URL: https://github.com/apache/calcite/pull/1444#discussion_r323029167 ## File path: site/_docs/os_adapter.md ## @@ -258,6 +258,209 @@ $ ./sqlsh select distinct

[GitHub] [calcite] danny0405 commented on a change in pull request #1444: [CALCITE-3329] Implement osquery for OS adapter

2019-09-10 Thread GitBox
danny0405 commented on a change in pull request #1444: [CALCITE-3329] Implement osquery for OS adapter URL: https://github.com/apache/calcite/pull/1444#discussion_r323028140 ## File path: plus/src/main/java/org/apache/calcite/adapter/os/CpuInfoTableFunction.java ## @@

[GitHub] [calcite] danny0405 commented on a change in pull request #1444: [CALCITE-3329] Implement osquery for OS adapter

2019-09-10 Thread GitBox
danny0405 commented on a change in pull request #1444: [CALCITE-3329] Implement osquery for OS adapter URL: https://github.com/apache/calcite/pull/1444#discussion_r323028439 ## File path: plus/src/main/java/org/apache/calcite/adapter/os/MountsTableFunction.java ## @@

[GitHub] [calcite] JulianFeinauer commented on issue #1449: [CALCITE-3302] Implement CLASSIFIER and LAST function for MATCH_RECOG…

2019-09-10 Thread GitBox
JulianFeinauer commented on issue #1449: [CALCITE-3302] Implement CLASSIFIER and LAST function for MATCH_RECOG… URL: https://github.com/apache/calcite/pull/1449#issuecomment-530132461 > I didn't have time to follow the logic on first review, but it looks good. I only have quibbles about

[GitHub] [calcite] asereda-gs commented on issue #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host…

2019-09-10 Thread GitBox
asereda-gs commented on issue #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host… URL: https://github.com/apache/calcite/pull/1447#issuecomment-530133618 Pls read [contributing doc](https://calcite.apache.org/develop/#contributing). JIRA id should be in square

svn commit: r35739 - /release/calcite/apache-calcite-1.19.0/

2019-09-10 Thread zabetak
Author: zabetak Date: Tue Sep 10 21:47:07 2019 New Revision: 35739 Log: Remove appache-calcite-1.19.0 Removed: release/calcite/apache-calcite-1.19.0/

[GitHub] [calcite] shikhasomani commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host…

2019-09-10 Thread GitBox
shikhasomani commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host… URL: https://github.com/apache/calcite/pull/1447#discussion_r322841341 ## File path:

[GitHub] [calcite] shikhasomani commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host…

2019-09-10 Thread GitBox
shikhasomani commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host… URL: https://github.com/apache/calcite/pull/1447#discussion_r322841283 ## File path:

[GitHub] [calcite] shikhasomani commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host…

2019-09-10 Thread GitBox
shikhasomani commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host… URL: https://github.com/apache/calcite/pull/1447#discussion_r322841200 ## File path:

[GitHub] [calcite] asereda-gs commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host…

2019-09-10 Thread GitBox
asereda-gs commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host… URL: https://github.com/apache/calcite/pull/1447#discussion_r322850146 ## File path:

[GitHub] [calcite] asereda-gs commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host…

2019-09-10 Thread GitBox
asereda-gs commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host… URL: https://github.com/apache/calcite/pull/1447#discussion_r322849908 ## File path:

[GitHub] [calcite] asereda-gs commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host…

2019-09-10 Thread GitBox
asereda-gs commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host… URL: https://github.com/apache/calcite/pull/1447#discussion_r322850804 ## File path:

[GitHub] [calcite] asereda-gs commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host…

2019-09-10 Thread GitBox
asereda-gs commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host… URL: https://github.com/apache/calcite/pull/1447#discussion_r322848470 ## File path:

[GitHub] [calcite] asereda-gs commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host…

2019-09-10 Thread GitBox
asereda-gs commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host… URL: https://github.com/apache/calcite/pull/1447#discussion_r322849668 ## File path:

[GitHub] [calcite] asereda-gs commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host…

2019-09-10 Thread GitBox
asereda-gs commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host… URL: https://github.com/apache/calcite/pull/1447#discussion_r322849023 ## File path:

[GitHub] [calcite] shikhasomani commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host…

2019-09-10 Thread GitBox
shikhasomani commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host… URL: https://github.com/apache/calcite/pull/1447#discussion_r322897960 ## File path:

[GitHub] [calcite] asereda-gs commented on issue #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host…

2019-09-10 Thread GitBox
asereda-gs commented on issue #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host… URL: https://github.com/apache/calcite/pull/1447#issuecomment-530065297 Pls squash your commit into one. Message should say > [CALCITE-1234] Description (FirstName LastName)

[GitHub] [calcite] asereda-gs commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host…

2019-09-10 Thread GitBox
asereda-gs commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host… URL: https://github.com/apache/calcite/pull/1447#discussion_r322850804 ## File path:

[GitHub] [calcite] asereda-gs commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host…

2019-09-10 Thread GitBox
asereda-gs commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host… URL: https://github.com/apache/calcite/pull/1447#discussion_r322850146 ## File path:

[GitHub] [calcite] asereda-gs commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host…

2019-09-10 Thread GitBox
asereda-gs commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host… URL: https://github.com/apache/calcite/pull/1447#discussion_r322855788 ## File path:

[GitHub] [calcite] shikhasomani commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host…

2019-09-10 Thread GitBox
shikhasomani commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host… URL: https://github.com/apache/calcite/pull/1447#discussion_r322894749 ## File path:

[GitHub] [calcite] shikhasomani commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host…

2019-09-10 Thread GitBox
shikhasomani commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host… URL: https://github.com/apache/calcite/pull/1447#discussion_r322894605 ## File path:

[GitHub] [calcite] shikhasomani commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host…

2019-09-10 Thread GitBox
shikhasomani commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host… URL: https://github.com/apache/calcite/pull/1447#discussion_r322894699 ## File path:

[GitHub] [calcite] shikhasomani commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host…

2019-09-10 Thread GitBox
shikhasomani commented on a change in pull request #1447: Calcite-3335: Getting new parameter from model to set it in HTTP host… URL: https://github.com/apache/calcite/pull/1447#discussion_r322894655 ## File path:

[GitHub] [calcite] jinxing64 commented on a change in pull request #1443: [CALCITE-3282] HiveSqlDialect unparse Interger type as Int in order to be compatible for Hive1.x

2019-09-10 Thread GitBox
jinxing64 commented on a change in pull request #1443: [CALCITE-3282] HiveSqlDialect unparse Interger type as Int in order to be compatible for Hive1.x URL: https://github.com/apache/calcite/pull/1443#discussion_r322613572 ## File path:

[GitHub] [calcite] jinxing64 commented on a change in pull request #1443: [CALCITE-3282] HiveSqlDialect unparse Interger type as Int in order to be compatible for Hive1.x

2019-09-10 Thread GitBox
jinxing64 commented on a change in pull request #1443: [CALCITE-3282] HiveSqlDialect unparse Interger type as Int in order to be compatible for Hive1.x URL: https://github.com/apache/calcite/pull/1443#discussion_r322614745 ## File path:

[GitHub] [calcite] jinxing64 commented on a change in pull request #1443: [CALCITE-3282] HiveSqlDialect unparse Interger type as Int in order to be compatible for Hive1.x

2019-09-10 Thread GitBox
jinxing64 commented on a change in pull request #1443: [CALCITE-3282] HiveSqlDialect unparse Interger type as Int in order to be compatible for Hive1.x URL: https://github.com/apache/calcite/pull/1443#discussion_r322612947 ## File path:

[GitHub] [calcite] jinxing64 commented on a change in pull request #1443: [CALCITE-3282] HiveSqlDialect unparse Interger type as Int in order to be compatible for Hive1.x

2019-09-10 Thread GitBox
jinxing64 commented on a change in pull request #1443: [CALCITE-3282] HiveSqlDialect unparse Interger type as Int in order to be compatible for Hive1.x URL: https://github.com/apache/calcite/pull/1443#discussion_r322614547 ## File path: