[GitHub] [calcite] amaliujia commented on a change in pull request #1588: [CALCITE-3577] Unparse to correct BigQuery interval syntax: "INTERVAL…

2019-12-11 Thread GitBox
amaliujia commented on a change in pull request #1588: [CALCITE-3577] Unparse to correct BigQuery interval syntax: "INTERVAL… URL: https://github.com/apache/calcite/pull/1588#discussion_r356454274 ## File path:

[GitHub] [calcite] chunweilei commented on a change in pull request #1642: [CALCITE-3583] Support serialized to json and deserialized from json for Exchange relation operator

2019-12-11 Thread GitBox
chunweilei commented on a change in pull request #1642: [CALCITE-3583] Support serialized to json and deserialized from json for Exchange relation operator URL: https://github.com/apache/calcite/pull/1642#discussion_r356460499 ## File path:

[calcite] branch master updated (db36758 -> 50cfaec)

2019-12-11 Thread chunwei
This is an automated email from the ASF dual-hosted git repository. chunwei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from db36758 Revert "[CALCITE-3576] Remove enumerable convention check in FilterIntoJoinRule" add 50cfaec

[GitHub] [calcite] chunweilei merged pull request #1565: [CALCITE-3481] Support convert TableFunctionScan to SqlNode

2019-12-11 Thread GitBox
chunweilei merged pull request #1565: [CALCITE-3481] Support convert TableFunctionScan to SqlNode URL: https://github.com/apache/calcite/pull/1565 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [calcite] ritesh-kapoor commented on a change in pull request #1645: [CALCITE-3552] Support MySQL ExtractValue function

2019-12-11 Thread GitBox
ritesh-kapoor commented on a change in pull request #1645: [CALCITE-3552] Support MySQL ExtractValue function URL: https://github.com/apache/calcite/pull/1645#discussion_r356471593 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlExtractValueFunction.java ##

[GitHub] [calcite] chunweilei commented on issue #1491: [CALCITE-3368] Some problems simplifying ‘expression IS NULL’

2019-12-11 Thread GitBox
chunweilei commented on issue #1491: [CALCITE-3368] Some problems simplifying ‘expression IS NULL’ URL: https://github.com/apache/calcite/pull/1491#issuecomment-564443941 Please change the commit message to describe the real issue.

[GitHub] [calcite] chunweilei commented on a change in pull request #1645: [CALCITE-3552] Support MySQL ExtractValue function

2019-12-11 Thread GitBox
chunweilei commented on a change in pull request #1645: [CALCITE-3552] Support MySQL ExtractValue function URL: https://github.com/apache/calcite/pull/1645#discussion_r356457067 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlExtractValueFunction.java ##

[GitHub] [calcite] chunweilei opened a new pull request #1646: [CALCITE-3575] IndexOutOfBoundsException when converting sql to rel

2019-12-11 Thread GitBox
chunweilei opened a new pull request #1646: [CALCITE-3575] IndexOutOfBoundsException when converting sql to rel URL: https://github.com/apache/calcite/pull/1646 JIRA: https://issues.apache.org/jira/browse/CALCITE-3575. This

[GitHub] [calcite] chunweilei commented on a change in pull request #1560: [CALCITE-3478] Restructure tests for materialized views

2019-12-11 Thread GitBox
chunweilei commented on a change in pull request #1560: [CALCITE-3478] Restructure tests for materialized views URL: https://github.com/apache/calcite/pull/1560#discussion_r356469016 ## File path: core/src/main/java/org/apache/calcite/rel/mutable/MutableScan.java ## @@

[GitHub] [calcite] dongAxis opened a new pull request #1648: adjust the format, it will let the other developers confused

2019-12-11 Thread GitBox
dongAxis opened a new pull request #1648: adjust the format, it will let the other developers confused URL: https://github.com/apache/calcite/pull/1648 This is an automated message from the Apache Git Service. To respond to

[GitHub] [calcite] jinxing64 opened a new pull request #1647: [CALCITE-3588] Support more operators in Join condition when convert …

2019-12-11 Thread GitBox
jinxing64 opened a new pull request #1647: [CALCITE-3588] Support more operators in Join condition when convert … URL: https://github.com/apache/calcite/pull/1647 …RelNode to SqlNode (Jin Xing) This is an automated message

[GitHub] [calcite] danny0405 commented on a change in pull request #1588: [CALCITE-3577] Unparse to correct BigQuery interval syntax: "INTERVAL…

2019-12-11 Thread GitBox
danny0405 commented on a change in pull request #1588: [CALCITE-3577] Unparse to correct BigQuery interval syntax: "INTERVAL… URL: https://github.com/apache/calcite/pull/1588#discussion_r356448765 ## File path:

[GitHub] [calcite] dongAxis opened a new pull request #1649: adjust the format, it will let the other developers confused

2019-12-11 Thread GitBox
dongAxis opened a new pull request #1649: adjust the format, it will let the other developers confused URL: https://github.com/apache/calcite/pull/1649 This is an automated message from the Apache Git Service. To respond to

[GitHub] [calcite] dongAxis closed pull request #1648: adjust the format, it will let the other developers confused

2019-12-11 Thread GitBox
dongAxis closed pull request #1648: adjust the format, it will let the other developers confused URL: https://github.com/apache/calcite/pull/1648 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [calcite] cshuo commented on a change in pull request #1643: [CALCITE-3584] Support SQL hints propagation for decorrelation

2019-12-11 Thread GitBox
cshuo commented on a change in pull request #1643: [CALCITE-3584] Support SQL hints propagation for decorrelation URL: https://github.com/apache/calcite/pull/1643#discussion_r356545537 ## File path: core/src/test/resources/org/apache/calcite/test/SqlHintsConverterTest.xml

[GitHub] [calcite] danny0405 commented on a change in pull request #1643: [CALCITE-3584] Support SQL hints propagation for decorrelation

2019-12-11 Thread GitBox
danny0405 commented on a change in pull request #1643: [CALCITE-3584] Support SQL hints propagation for decorrelation URL: https://github.com/apache/calcite/pull/1643#discussion_r356548450 ## File path: core/src/test/resources/org/apache/calcite/test/SqlHintsConverterTest.xml

[GitHub] [calcite] cshuo commented on issue #1643: [CALCITE-3584] Support SQL hints propagation for decorrelation

2019-12-11 Thread GitBox
cshuo commented on issue #1643: [CALCITE-3584] Support SQL hints propagation for decorrelation URL: https://github.com/apache/calcite/pull/1643#issuecomment-564516843 LGTM  This is an automated message from the Apache Git

[GitHub] [calcite] cshuo commented on a change in pull request #1643: [CALCITE-3584] Support SQL hints propagation for decorrelation

2019-12-11 Thread GitBox
cshuo commented on a change in pull request #1643: [CALCITE-3584] Support SQL hints propagation for decorrelation URL: https://github.com/apache/calcite/pull/1643#discussion_r356551221 ## File path: core/src/test/resources/org/apache/calcite/test/SqlHintsConverterTest.xml

[GitHub] [calcite] leonardBang commented on issue #1491: [CALCITE-3368] Some problems simplifying ‘expression IS NULL’

2019-12-11 Thread GitBox
leonardBang commented on issue #1491: [CALCITE-3368] Some problems simplifying ‘expression IS NULL’ URL: https://github.com/apache/calcite/pull/1491#issuecomment-564881844 @chunweilei I’ll close this PR because this's should be an improvement rather a bug after long discussion, and the

[GitHub] [calcite] leonardBang closed pull request #1491: [CALCITE-3368] Some problems simplifying ‘expression IS NULL’

2019-12-11 Thread GitBox
leonardBang closed pull request #1491: [CALCITE-3368] Some problems simplifying ‘expression IS NULL’ URL: https://github.com/apache/calcite/pull/1491 This is an automated message from the Apache Git Service. To respond to

[GitHub] [calcite] docete opened a new pull request #1650: [CALCITE-3597] The conversion between java.sql.Timestamp and long is …

2019-12-11 Thread GitBox
docete opened a new pull request #1650: [CALCITE-3597] The conversion between java.sql.Timestamp and long is … URL: https://github.com/apache/calcite/pull/1650 …not asymmetric In Calcite, we use SqlFunctions.toLong(Timestamp) and SqlFunctions.internalToTimestamp(long) to convert

[GitHub] [calcite] zabetak commented on a change in pull request #1610: [CALCITE-3525] RexSimplify: eliminate redundant rex calls in OR

2019-12-11 Thread GitBox
zabetak commented on a change in pull request #1610: [CALCITE-3525] RexSimplify: eliminate redundant rex calls in OR URL: https://github.com/apache/calcite/pull/1610#discussion_r356989965 ## File path: core/src/main/java/org/apache/calcite/rel/rules/FilterProjectTransposeRule.java

[GitHub] [calcite] ihuzenko commented on a change in pull request #1610: [CALCITE-3525] RexSimplify: eliminate redundant rex calls in OR

2019-12-11 Thread GitBox
ihuzenko commented on a change in pull request #1610: [CALCITE-3525] RexSimplify: eliminate redundant rex calls in OR URL: https://github.com/apache/calcite/pull/1610#discussion_r356756002 ## File path:

[GitHub] [calcite] amaliujia commented on a change in pull request #1647: [CALCITE-3588] Support more operators in Join condition when convert …

2019-12-11 Thread GitBox
amaliujia commented on a change in pull request #1647: [CALCITE-3588] Support more operators in Join condition when convert … URL: https://github.com/apache/calcite/pull/1647#discussion_r356833180 ## File path: core/src/main/java/org/apache/calcite/rel/rel2sql/SqlImplementor.java

[calcite-avatica] annotated tag avatica-1.16.0-rc1 created (now ba0503c)

2019-12-11 Thread francischuang
This is an automated email from the ASF dual-hosted git repository. francischuang pushed a change to annotated tag avatica-1.16.0-rc1 in repository https://gitbox.apache.org/repos/asf/calcite-avatica.git. at ba0503c (tag) tagging 512bbee4aa24ef9fb8106d0286d1243679dce2d0 (commit)

svn commit: r37181 - in /dev/calcite/apache-calcite-avatica-1.16.0-rc1: ./ apache-calcite-avatica-1.16.0-src.tar.gz apache-calcite-avatica-1.16.0-src.tar.gz.asc apache-calcite-avatica-1.16.0-src.tar.g

2019-12-11 Thread francischuang
Author: francischuang Date: Wed Dec 11 22:12:04 2019 New Revision: 37181 Log: Uploading release candidate Apache Calcite Avatica avatica-1.16.0-rc1 to dev area Added: dev/calcite/apache-calcite-avatica-1.16.0-rc1/

[calcite-avatica] 01/02: Stop building zip archives when building using gradle

2019-12-11 Thread francischuang
This is an automated email from the ASF dual-hosted git repository. francischuang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite-avatica.git commit 34bbcb63f9216d3a5bc29dae1981a55e335d30df Author: Francis Chuang AuthorDate: Thu Dec 12 08:54:21 2019

[calcite-avatica] 02/02: Update documentation and history for 1.16.0

2019-12-11 Thread francischuang
This is an automated email from the ASF dual-hosted git repository. francischuang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite-avatica.git commit 512bbee4aa24ef9fb8106d0286d1243679dce2d0 Author: Francis Chuang AuthorDate: Thu Dec 12 08:57:41 2019

[calcite-avatica] branch master updated (204d588 -> 512bbee)

2019-12-11 Thread francischuang
This is an automated email from the ASF dual-hosted git repository. francischuang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite-avatica.git. omit 204d588 Update documentation and history for 1.16.0 new 34bbcb6 Stop building zip archives

[GitHub] [calcite] asfgit closed pull request #1649: adjust the format, it will let the other developers confused

2019-12-11 Thread GitBox
asfgit closed pull request #1649: adjust the format, it will let the other developers confused URL: https://github.com/apache/calcite/pull/1649 This is an automated message from the Apache Git Service. To respond to the

[calcite] branch master updated: Adjust code indentation (Axis)

2019-12-11 Thread jhyde
This is an automated email from the ASF dual-hosted git repository. jhyde pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git The following commit(s) were added to refs/heads/master by this push: new 25a2e5a Adjust code indentation (Axis) 25a2e5a

[GitHub] [calcite] amaliujia commented on a change in pull request #1647: [CALCITE-3588] Support more operators in Join condition when convert …

2019-12-11 Thread GitBox
amaliujia commented on a change in pull request #1647: [CALCITE-3588] Support more operators in Join condition when convert … URL: https://github.com/apache/calcite/pull/1647#discussion_r356833180 ## File path: core/src/main/java/org/apache/calcite/rel/rel2sql/SqlImplementor.java

[GitHub] [calcite] hsyuan commented on issue #1591: [CALCITE-3510] Implement Redis adapter

2019-12-11 Thread GitBox
hsyuan commented on issue #1591: [CALCITE-3510] Implement Redis adapter URL: https://github.com/apache/calcite/pull/1591#issuecomment-564837914 Looks like the tests failed. Can you have a look? @XuQianJin-Stars This is an

[GitHub] [calcite] danny0405 commented on a change in pull request #1609: [CALCITE-3520] Type cast from primitive to box is not correct

2019-12-11 Thread GitBox
danny0405 commented on a change in pull request #1609: [CALCITE-3520] Type cast from primitive to box is not correct URL: https://github.com/apache/calcite/pull/1609#discussion_r356952611 ## File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumUtils.java

[GitHub] [calcite] amaliujia commented on a change in pull request #1647: [CALCITE-3588] Support more operators in Join condition when convert …

2019-12-11 Thread GitBox
amaliujia commented on a change in pull request #1647: [CALCITE-3588] Support more operators in Join condition when convert … URL: https://github.com/apache/calcite/pull/1647#discussion_r356953236 ## File path: core/src/main/java/org/apache/calcite/rel/rel2sql/SqlImplementor.java

[GitHub] [calcite] chunweilei commented on a change in pull request #1647: [CALCITE-3588] Support more operators in Join condition when convert …

2019-12-11 Thread GitBox
chunweilei commented on a change in pull request #1647: [CALCITE-3588] Support more operators in Join condition when convert … URL: https://github.com/apache/calcite/pull/1647#discussion_r356935306 ## File path:

[GitHub] [calcite] chunweilei commented on a change in pull request #1645: [CALCITE-3552] Support MySQL ExtractValue function

2019-12-11 Thread GitBox
chunweilei commented on a change in pull request #1645: [CALCITE-3552] Support MySQL ExtractValue function URL: https://github.com/apache/calcite/pull/1645#discussion_r356936592 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java ## @@

[GitHub] [calcite] ritesh-kapoor commented on a change in pull request #1645: [CALCITE-3552] Support MySQL ExtractValue function

2019-12-11 Thread GitBox
ritesh-kapoor commented on a change in pull request #1645: [CALCITE-3552] Support MySQL ExtractValue function URL: https://github.com/apache/calcite/pull/1645#discussion_r356940685 ## File path: core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java ## @@

[GitHub] [calcite] jinxing64 commented on a change in pull request #1560: [CALCITE-3478] Restructure tests for materialized views

2019-12-11 Thread GitBox
jinxing64 commented on a change in pull request #1560: [CALCITE-3478] Restructure tests for materialized views URL: https://github.com/apache/calcite/pull/1560#discussion_r356942349 ## File path: core/src/main/java/org/apache/calcite/rel/mutable/MutableScan.java ## @@

[calcite] branch master updated (25a2e5a -> 74d0275)

2019-12-11 Thread danny0405
This is an automated email from the ASF dual-hosted git repository. danny0405 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from 25a2e5a Adjust code indentation (Axis) add 74d0275 [CALCITE-3584] Propagate hints when decorrelating a

[GitHub] [calcite] danny0405 merged pull request #1643: [CALCITE-3584] Support SQL hints propagation for decorrelation

2019-12-11 Thread GitBox
danny0405 merged pull request #1643: [CALCITE-3584] Support SQL hints propagation for decorrelation URL: https://github.com/apache/calcite/pull/1643 This is an automated message from the Apache Git Service. To respond to

[GitHub] [calcite] jinxing64 commented on a change in pull request #1647: [CALCITE-3588] Support more operators in Join condition when convert …

2019-12-11 Thread GitBox
jinxing64 commented on a change in pull request #1647: [CALCITE-3588] Support more operators in Join condition when convert … URL: https://github.com/apache/calcite/pull/1647#discussion_r356925076 ## File path: core/src/main/java/org/apache/calcite/rel/rel2sql/SqlImplementor.java

[GitHub] [calcite] XuQianJin-Stars commented on issue #1591: [CALCITE-3510] Implement Redis adapter

2019-12-11 Thread GitBox
XuQianJin-Stars commented on issue #1591: [CALCITE-3510] Implement Redis adapter URL: https://github.com/apache/calcite/pull/1591#issuecomment-564853321 > Looks like the tests failed. Can you have a look? @XuQianJin-Stars well, I've been a bit busy recently and I will update this

[GitHub] [calcite] jinxing64 commented on a change in pull request #1647: [CALCITE-3588] Support more operators in Join condition when convert …

2019-12-11 Thread GitBox
jinxing64 commented on a change in pull request #1647: [CALCITE-3588] Support more operators in Join condition when convert … URL: https://github.com/apache/calcite/pull/1647#discussion_r356966497 ## File path: core/src/main/java/org/apache/calcite/rel/rel2sql/SqlImplementor.java

[GitHub] [calcite] jinxing64 commented on a change in pull request #1647: [CALCITE-3588] Support more operators in Join condition when convert …

2019-12-11 Thread GitBox
jinxing64 commented on a change in pull request #1647: [CALCITE-3588] Support more operators in Join condition when convert … URL: https://github.com/apache/calcite/pull/1647#discussion_r356967208 ## File path:

[GitHub] [calcite] jinxing64 commented on issue #1647: [CALCITE-3588] Support more operators in Join condition when convert …

2019-12-11 Thread GitBox
jinxing64 commented on issue #1647: [CALCITE-3588] Support more operators in Join condition when convert … URL: https://github.com/apache/calcite/pull/1647#issuecomment-564859502 Hi, Chunwei ~ Regarding negative test cases, what are you expecting for ? It's great if you can give a

[calcite] branch master updated (74d0275 -> fd92642)

2019-12-11 Thread danny0405
This is an automated email from the ASF dual-hosted git repository. danny0405 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from 74d0275 [CALCITE-3584] Propagate hints when decorrelating a query add fd92642 [CALCITE-3381] Unparse to

[GitHub] [calcite] danny0405 closed pull request #1588: [CALCITE-3577] Unparse to correct BigQuery interval syntax: "INTERVAL…

2019-12-11 Thread GitBox
danny0405 closed pull request #1588: [CALCITE-3577] Unparse to correct BigQuery interval syntax: "INTERVAL… URL: https://github.com/apache/calcite/pull/1588 This is an automated message from the Apache Git Service. To

[calcite] branch master updated (fd92642 -> d951844)

2019-12-11 Thread danny0405
This is an automated email from the ASF dual-hosted git repository. danny0405 pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/calcite.git. from fd92642 [CALCITE-3381] Unparse to correct BigQuery ingterval syngax: INTERVAL int64 time_unit. Range time unit

[GitHub] [calcite] danny0405 closed pull request #1609: [CALCITE-3520] Type cast from primitive to box is not correct

2019-12-11 Thread GitBox
danny0405 closed pull request #1609: [CALCITE-3520] Type cast from primitive to box is not correct URL: https://github.com/apache/calcite/pull/1609 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [calcite] amaliujia commented on a change in pull request #1647: [CALCITE-3588] Support more operators in Join condition when convert …

2019-12-11 Thread GitBox
amaliujia commented on a change in pull request #1647: [CALCITE-3588] Support more operators in Join condition when convert … URL: https://github.com/apache/calcite/pull/1647#discussion_r356970239 ## File path: core/src/main/java/org/apache/calcite/rel/rel2sql/SqlImplementor.java

[GitHub] [calcite] amaliujia commented on a change in pull request #1647: [CALCITE-3588] Support more operators in Join condition when convert …

2019-12-11 Thread GitBox
amaliujia commented on a change in pull request #1647: [CALCITE-3588] Support more operators in Join condition when convert … URL: https://github.com/apache/calcite/pull/1647#discussion_r356970239 ## File path: core/src/main/java/org/apache/calcite/rel/rel2sql/SqlImplementor.java

[GitHub] [calcite] jinxing64 commented on a change in pull request #1647: [CALCITE-3588] Support more operators in Join condition when convert …

2019-12-11 Thread GitBox
jinxing64 commented on a change in pull request #1647: [CALCITE-3588] Support more operators in Join condition when convert … URL: https://github.com/apache/calcite/pull/1647#discussion_r356974481 ## File path: core/src/main/java/org/apache/calcite/rel/rel2sql/SqlImplementor.java