[GitHub] [calcite] xy2953396112 opened a new pull request #2148: [CALCITE-4250] Failed to get original column of aggregate operator

xy2953396112 opened a new pull request #2148: URL: https://github.com/apache/calcite/pull/2148 https://issues.apache.org/jira/browse/CALCITE-4250 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [calcite] xy2953396112 commented on a change in pull request #2148: [CALCITE-4250] Failed to get original column of aggregate operator

xy2953396112 commented on a change in pull request #2148: URL: https://github.com/apache/calcite/pull/2148#discussion_r487388133 ## File path: core/src/test/java/org/apache/calcite/materialize/NormalizationTrimFieldTest.java ## @@ -105,4 +107,25 @@ final String

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2143: [CALCITE-4224] Add an method for RelNode to output its tree digest like RelOptUtil.toString (Jiatao Tao)

Aaron commented on a change in pull request #2143: URL: https://github.com/apache/calcite/pull/2143#discussion_r487388009 ## File path: core/src/main/java/org/apache/calcite/rel/RelNode.java ## @@ -232,6 +233,21 @@ */ RelNode onRegister(RelOptPlanner planner); +

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2143: [CALCITE-4224] Add an method for RelNode to output its tree digest like RelOptUtil.toString (Jiatao Tao)

Aaron commented on a change in pull request #2143: URL: https://github.com/apache/calcite/pull/2143#discussion_r487387680 ## File path: core/src/main/java/org/apache/calcite/rel/RelNode.java ## @@ -232,6 +233,21 @@ */ RelNode onRegister(RelOptPlanner planner); +

[GitHub] [calcite] xy2953396112 opened a new pull request #2149: [MINOR] Visit Calc operator in RelShuttle

xy2953396112 opened a new pull request #2149: URL: https://github.com/apache/calcite/pull/2149 This pr can visit calc operator directly, I'm not sure if I should open another JIRA.Here's a previous implementation[1], which has some problems.It can not visit calc operator directly.Specific

[GitHub] [calcite] vlsi commented on a change in pull request #2148: [CALCITE-4250] Failed to get original column of aggregate operator

vlsi commented on a change in pull request #2148: URL: https://github.com/apache/calcite/pull/2148#discussion_r487386711 ## File path: core/src/test/java/org/apache/calcite/materialize/NormalizationTrimFieldTest.java ## @@ -105,4 +107,25 @@ final String relOptimizedStr =

[GitHub] [calcite] xy2953396112 closed pull request #2149: [MINOR] Visit Calc operator in RelShuttle

xy2953396112 closed pull request #2149: URL: https://github.com/apache/calcite/pull/2149 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [calcite] chunweilei commented on a change in pull request #2146: [CALCITE-4241] Some improvements to metadata query

chunweilei commented on a change in pull request #2146: URL: https://github.com/apache/calcite/pull/2146#discussion_r486827094 ## File path: core/src/main/java/org/apache/calcite/rel/rules/LoptOptimizeJoinRule.java ## @@ -2064,7 +2064,7 @@ private static boolean

[GitHub] [calcite] cuglifangzheng commented on a change in pull request #2121: [CALCITE-4192] RelMdColumnOrigins should obtain the true column index of the group by column of the aggregation operator

cuglifangzheng commented on a change in pull request #2121: URL: https://github.com/apache/calcite/pull/2121#discussion_r487359768 ## File path: core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java ## @@ -6764,4 +6769,25 @@ protected MyProjectRule(Config config) {

[GitHub] [calcite] rubenada commented on a change in pull request #2143: [CALCITE-4224] Add an method for RelNode to output its tree digest like RelOptUtil.toString (Jiatao Tao)

rubenada commented on a change in pull request #2143: URL: https://github.com/apache/calcite/pull/2143#discussion_r486848210 ## File path: core/src/main/java/org/apache/calcite/rel/RelNode.java ## @@ -232,6 +233,21 @@ */ RelNode onRegister(RelOptPlanner planner); +

[GitHub] [calcite] vlsi commented on a change in pull request #2148: [CALCITE-4250] Failed to get original column of aggregate operator

vlsi commented on a change in pull request #2148: URL: https://github.com/apache/calcite/pull/2148#discussion_r487386711 ## File path: core/src/test/java/org/apache/calcite/materialize/NormalizationTrimFieldTest.java ## @@ -105,4 +107,25 @@ final String relOptimizedStr =

[GitHub] [calcite] xy2953396112 commented on a change in pull request #2148: [CALCITE-4250] Failed to get original column of aggregate operator

xy2953396112 commented on a change in pull request #2148: URL: https://github.com/apache/calcite/pull/2148#discussion_r487388133 ## File path: core/src/test/java/org/apache/calcite/materialize/NormalizationTrimFieldTest.java ## @@ -105,4 +107,25 @@ final String

[GitHub] [calcite] xy2953396112 closed pull request #2149: [MINOR] Visit Calc operator in RelShuttle

xy2953396112 closed pull request #2149: URL: https://github.com/apache/calcite/pull/2149 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [calcite] chunweilei commented on a change in pull request #2145: [CALCITE-4239] RelMdUniqueKeys returns wrong unique keys for Aggregate with grouping sets

chunweilei commented on a change in pull request #2145: URL: https://github.com/apache/calcite/pull/2145#discussion_r486822423 ## File path: core/src/main/java/org/apache/calcite/rel/metadata/RelMdUniqueKeys.java ## @@ -246,8 +246,14 @@ private RelMdUniqueKeys() {}

[GitHub] [calcite] liyafan82 commented on pull request #2128: [CALCITE-4197] Provide utility to visualize RelNode plans

liyafan82 commented on pull request #2128: URL: https://github.com/apache/calcite/pull/2128#issuecomment-690941436 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [calcite] chunweilei commented on pull request #2128: [CALCITE-4197] Provide utility to visualize RelNode plans

chunweilei commented on pull request #2128: URL: https://github.com/apache/calcite/pull/2128#issuecomment-690930458 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2143: [CALCITE-4224] Add an method for RelNode to output its tree digest like RelOptUtil.toString (Jiatao Tao)

Aaron commented on a change in pull request #2143: URL: https://github.com/apache/calcite/pull/2143#discussion_r487387680 ## File path: core/src/main/java/org/apache/calcite/rel/RelNode.java ## @@ -232,6 +233,21 @@ */ RelNode onRegister(RelOptPlanner planner); +

[GitHub] [calcite] cuglifangzheng commented on a change in pull request #2121: [CALCITE-4192] RelMdColumnOrigins should obtain the true column index of the group by column of the aggregation operator

cuglifangzheng commented on a change in pull request #2121: URL: https://github.com/apache/calcite/pull/2121#discussion_r487359768 ## File path: core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java ## @@ -6764,4 +6769,25 @@ protected MyProjectRule(Config config) {

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2143: [CALCITE-4224] Add an method for RelNode to output its tree digest like RelOptUtil.toString (Jiatao Tao)

Aaron commented on a change in pull request #2143: URL: https://github.com/apache/calcite/pull/2143#discussion_r487387680 ## File path: core/src/main/java/org/apache/calcite/rel/RelNode.java ## @@ -232,6 +233,21 @@ */ RelNode onRegister(RelOptPlanner planner); +

[GitHub] [calcite] chunweilei commented on pull request #2128: [CALCITE-4197] Provide utility to visualize RelNode plans

chunweilei commented on pull request #2128: URL: https://github.com/apache/calcite/pull/2128#issuecomment-690930458 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [calcite] michaelmior commented on a change in pull request #2133: [CALCITE-2040] Arrow adapter

michaelmior commented on a change in pull request #2133: URL: https://github.com/apache/calcite/pull/2133#discussion_r487008505 ## File path: arrow/src/test/java/org/apache/calcite/adapter/arrow/ArrowTest.java ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software

[GitHub] [calcite] liyafan82 commented on a change in pull request #2145: [CALCITE-4239] RelMdUniqueKeys returns wrong unique keys for Aggregate with grouping sets

liyafan82 commented on a change in pull request #2145: URL: https://github.com/apache/calcite/pull/2145#discussion_r486839323 ## File path: core/src/main/java/org/apache/calcite/rel/metadata/RelMdUniqueKeys.java ## @@ -246,8 +246,14 @@ private RelMdUniqueKeys() {} public

[GitHub] [calcite] liyafan82 commented on a change in pull request #2121: [CALCITE-4192] RelMdColumnOrigins should obtain the true column index of the group by column of the aggregation operator inste

liyafan82 commented on a change in pull request #2121: URL: https://github.com/apache/calcite/pull/2121#discussion_r486795640 ## File path: core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java ## @@ -6764,4 +6769,25 @@ protected MyProjectRule(Config config) {

[GitHub] [calcite] liyafan82 commented on a change in pull request #2146: [CALCITE-4241] Some improvements to metadata query

liyafan82 commented on a change in pull request #2146: URL: https://github.com/apache/calcite/pull/2146#discussion_r486854367 ## File path: core/src/main/java/org/apache/calcite/rel/rules/LoptOptimizeJoinRule.java ## @@ -2064,7 +2064,7 @@ private static boolean

[GitHub] [calcite] xy2953396112 commented on a change in pull request #2148: [CALCITE-4250] Failed to get original column of aggregate operator

xy2953396112 commented on a change in pull request #2148: URL: https://github.com/apache/calcite/pull/2148#discussion_r487388133 ## File path: core/src/test/java/org/apache/calcite/materialize/NormalizationTrimFieldTest.java ## @@ -105,4 +107,25 @@ final String

[GitHub] [calcite] xy2953396112 commented on a change in pull request #2148: [CALCITE-4250] Failed to get original column of aggregate operator

xy2953396112 commented on a change in pull request #2148: URL: https://github.com/apache/calcite/pull/2148#discussion_r487388133 ## File path: core/src/test/java/org/apache/calcite/materialize/NormalizationTrimFieldTest.java ## @@ -105,4 +107,25 @@ final String

[GitHub] [calcite] rubenada commented on a change in pull request #2143: [CALCITE-4224] Add an method for RelNode to output its tree digest like RelOptUtil.toString (Jiatao Tao)

rubenada commented on a change in pull request #2143: URL: https://github.com/apache/calcite/pull/2143#discussion_r486848210 ## File path: core/src/main/java/org/apache/calcite/rel/RelNode.java ## @@ -232,6 +233,21 @@ */ RelNode onRegister(RelOptPlanner planner); +

[GitHub] [calcite] liyafan82 commented on a change in pull request #2121: [CALCITE-4192] RelMdColumnOrigins should obtain the true column index of the group by column of the aggregation operator inste

liyafan82 commented on a change in pull request #2121: URL: https://github.com/apache/calcite/pull/2121#discussion_r486795640 ## File path: core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java ## @@ -6764,4 +6769,25 @@ protected MyProjectRule(Config config) {

[GitHub] [calcite] xy2953396112 closed pull request #2149: [MINOR] Visit Calc operator in RelShuttle

xy2953396112 closed pull request #2149: URL: https://github.com/apache/calcite/pull/2149 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [calcite] cuglifangzheng commented on a change in pull request #2121: [CALCITE-4192] RelMdColumnOrigins should obtain the true column index of the group by column of the aggregation operator

cuglifangzheng commented on a change in pull request #2121: URL: https://github.com/apache/calcite/pull/2121#discussion_r487359768 ## File path: core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java ## @@ -6764,4 +6769,25 @@ protected MyProjectRule(Config config) {

[GitHub] [calcite] liyafan82 commented on a change in pull request #2146: [CALCITE-4241] Some improvements to metadata query

liyafan82 commented on a change in pull request #2146: URL: https://github.com/apache/calcite/pull/2146#discussion_r486854367 ## File path: core/src/main/java/org/apache/calcite/rel/rules/LoptOptimizeJoinRule.java ## @@ -2064,7 +2064,7 @@ private static boolean

[GitHub] [calcite] vlsi commented on a change in pull request #2148: [CALCITE-4250] Failed to get original column of aggregate operator

vlsi commented on a change in pull request #2148: URL: https://github.com/apache/calcite/pull/2148#discussion_r487386711 ## File path: core/src/test/java/org/apache/calcite/materialize/NormalizationTrimFieldTest.java ## @@ -105,4 +107,25 @@ final String relOptimizedStr =

[GitHub] [calcite] chunweilei commented on pull request #2128: [CALCITE-4197] Provide utility to visualize RelNode plans

chunweilei commented on pull request #2128: URL: https://github.com/apache/calcite/pull/2128#issuecomment-690930458 Could you please squash commits? This is an automated message from the Apache Git Service. To respond to the

[GitHub] [calcite] Aaaaaaron commented on a change in pull request #2143: [CALCITE-4224] Add an method for RelNode to output its tree digest like RelOptUtil.toString (Jiatao Tao)

Aaron commented on a change in pull request #2143: URL: https://github.com/apache/calcite/pull/2143#discussion_r487387680 ## File path: core/src/main/java/org/apache/calcite/rel/RelNode.java ## @@ -232,6 +233,21 @@ */ RelNode onRegister(RelOptPlanner planner); +

[GitHub] [calcite] chunweilei commented on a change in pull request #2146: [CALCITE-4241] Some improvements to metadata query

chunweilei commented on a change in pull request #2146: URL: https://github.com/apache/calcite/pull/2146#discussion_r486827094 ## File path: core/src/main/java/org/apache/calcite/rel/rules/LoptOptimizeJoinRule.java ## @@ -2064,7 +2064,7 @@ private static boolean

[GitHub] [calcite] michaelmior commented on a change in pull request #2133: [CALCITE-2040] Arrow adapter

michaelmior commented on a change in pull request #2133: URL: https://github.com/apache/calcite/pull/2133#discussion_r487008505 ## File path: arrow/src/test/java/org/apache/calcite/adapter/arrow/ArrowTest.java ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software

[GitHub] [calcite] amaliujia commented on a change in pull request #2143: [CALCITE-4224] Add an method for RelNode to output its tree digest like RelOptUtil.toString (Jiatao Tao)

amaliujia commented on a change in pull request #2143: URL: https://github.com/apache/calcite/pull/2143#discussion_r487468101 ## File path: core/src/main/java/org/apache/calcite/rel/RelNode.java ## @@ -222,6 +223,22 @@ */ void explain(RelWriter pw); + /** + *