Anthrino commented on code in PR #3761:
URL: https://github.com/apache/calcite/pull/3761#discussion_r1571079145
##
core/src/main/java/org/apache/calcite/util/format/FormatElementEnum.java:
##
@@ -217,6 +291,34 @@ public enum FormatElementEnum implements FormatElement {
mihaibudiu commented on PR #3761:
URL: https://github.com/apache/calcite/pull/3761#issuecomment-2064785139
This PR seems to implement a few flags which don't even work in BigQuery,
but other than that seems fine.
--
This is an automated message from the Apache Git Service.
To respond to
jduo commented on code in PR #3757:
URL: https://github.com/apache/calcite/pull/3757#discussion_r1571211748
##
core/src/main/java/org/apache/calcite/tools/RelBuilder.java:
##
@@ -2502,9 +2502,10 @@ private RelBuilder
pruneAggregateInputFieldsAndDeduplicateAggCalls(
rubenada commented on PR #3763:
URL: https://github.com/apache/calcite/pull/3763#issuecomment-2064052951
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Anthrino commented on code in PR #3761:
URL: https://github.com/apache/calcite/pull/3761#discussion_r1571070432
##
core/src/test/resources/sql/cast-with-format.iq:
##
@@ -979,7 +939,7 @@ EXPR$0
select cast(date'2019-01-07' as varchar
FORMAT 'WW');
EXPR$0
-01
+02
Review
jduo commented on code in PR #3757:
URL: https://github.com/apache/calcite/pull/3757#discussion_r1571176366
##
core/src/test/java/org/apache/calcite/test/RelBuilderTest.java:
##
@@ -547,6 +547,31 @@ private void
checkSimplify(UnaryOperator transform,
assertThat(root,
This is an automated email from the ASF dual-hosted git repository.
mbudiu pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/calcite.git
The following commit(s) were added to refs/heads/main by this push:
new 0551b89033 [CALCITE-5289] Assertion failure in
mihaibudiu merged PR #3763:
URL: https://github.com/apache/calcite/pull/3763
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sonarcloud[bot] commented on PR #3733:
URL: https://github.com/apache/calcite/pull/3733#issuecomment-2064940568
## [ {
*
Anthrino commented on code in PR #3761:
URL: https://github.com/apache/calcite/pull/3761#discussion_r1571090898
##
core/src/test/resources/sql/cast-with-format.iq:
##
@@ -32,8 +32,15 @@ EXPR$0
2017-05-01 01:23:45
!ok
+# Input that contains shuffled date without time
+select
asolimando commented on code in PR #3757:
URL: https://github.com/apache/calcite/pull/3757#discussion_r1571121711
##
core/src/main/java/org/apache/calcite/tools/RelBuilder.java:
##
@@ -2502,9 +2502,10 @@ private RelBuilder
pruneAggregateInputFieldsAndDeduplicateAggCalls(
mihaibudiu commented on code in PR #3762:
URL: https://github.com/apache/calcite/pull/3762#discussion_r1571322599
##
core/src/test/java/org/apache/calcite/test/SqlValidatorTest.java:
##
@@ -559,15 +558,6 @@ static SqlOperatorTable operatorTableFor(SqlLibrary
library) {
}
normanj-bitquill commented on code in PR #3762:
URL: https://github.com/apache/calcite/pull/3762#discussion_r1571319246
##
core/src/test/java/org/apache/calcite/test/SqlValidatorTest.java:
##
@@ -559,15 +558,6 @@ static SqlOperatorTable operatorTableFor(SqlLibrary
library) {
sonarcloud[bot] commented on PR #3663:
URL: https://github.com/apache/calcite/pull/3663#issuecomment-2065453164
## [ {
public
normanj-bitquill commented on code in PR #3762:
URL: https://github.com/apache/calcite/pull/3762#discussion_r1571317238
##
core/src/main/java/org/apache/calcite/sql/type/ReturnTypes.java:
##
@@ -773,6 +791,28 @@ public static SqlCall stripSeparator(SqlCall call) {
return
mihaibudiu commented on PR #3589:
URL: https://github.com/apache/calcite/pull/3589#issuecomment-2065329884
I have submitted https://github.com/apache/calcite/pull/3764, which provides
just a fix for [CALCITE-6169].
Once that is merged, I will resubmit a much smaller PR here to fix
normanj-bitquill commented on code in PR #3762:
URL: https://github.com/apache/calcite/pull/3762#discussion_r1571315674
##
core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java:
##
@@ -2216,7 +2216,39 @@ private static RelDataType
25 matches
Mail list logo
