mihaibudiu merged PR #238:
URL: https://github.com/apache/calcite-avatica/pull/238
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mihaibudiu commented on PR #238:
URL: https://github.com/apache/calcite-avatica/pull/238#issuecomment-2030123366
If CI passes I will merge this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
mihaibudiu merged PR #3708:
URL: https://github.com/apache/calcite/pull/3708
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mihaibudiu commented on PR #3708:
URL: https://github.com/apache/calcite/pull/3708#issuecomment-2028832938
I am thinking to merge this PR, since there isn't much to review, so we can
proceed with Avatica.
--
This is an automated message from the Apache Git Service.
To respond to the
mihaibudiu commented on PR #3708:
URL: https://github.com/apache/calcite/pull/3708#issuecomment-2027859740
This is ready for review, to enable migration to Avatica 1.25.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
mihaibudiu commented on code in PR #238:
URL: https://github.com/apache/calcite-avatica/pull/238#discussion_r1531438930
##
core/src/main/java/org/apache/calcite/avatica/util/DateTimeUtils.java:
##
@@ -739,6 +744,25 @@ private static int parseFraction(String v, int multiplier)
mihaibudiu commented on code in PR #238:
URL: https://github.com/apache/calcite-avatica/pull/238#discussion_r1530647044
##
core/src/main/java/org/apache/calcite/avatica/util/DateTimeUtils.java:
##
@@ -739,6 +744,25 @@ private static int parseFraction(String v, int multiplier)
YiwenWu commented on code in PR #238:
URL: https://github.com/apache/calcite-avatica/pull/238#discussion_r1529579227
##
core/src/main/java/org/apache/calcite/avatica/util/DateTimeUtils.java:
##
@@ -739,6 +744,25 @@ private static int parseFraction(String v, int multiplier)
{
mihaibudiu commented on PR #3708:
URL: https://github.com/apache/calcite/pull/3708#issuecomment-1975074074
I sent a message on the dev list about this. I still have to figure out how
to do this. We need simultaneous changes to avatica and calcite to make this
pass.
--
This is an
JiajunBernoulli commented on PR #3708:
URL: https://github.com/apache/calcite/pull/3708#issuecomment-1975071486
@mihaibudiu
Maybe you can public test version in calcite-avatica.
Then update calcite-avatica in calcite to test.
--
This is an automated message from the Apache Git
mihaibudiu commented on code in PR #3708:
URL: https://github.com/apache/calcite/pull/3708#discussion_r1509921263
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -1320,7 +1320,7 @@ void testCastStringToDateTime(CastType castType,
SqlOperatorFixture
mihaibudiu commented on code in PR #3708:
URL: https://github.com/apache/calcite/pull/3708#discussion_r1509921238
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -1329,8 +1329,14 @@ void testCastStringToDateTime(CastType castType,
YiwenWu commented on code in PR #3708:
URL: https://github.com/apache/calcite/pull/3708#discussion_r1509906302
##
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##
@@ -1329,8 +1329,14 @@ void testCastStringToDateTime(CastType castType,
SqlOperatorFixture
mihaibudiu commented on PR #3708:
URL: https://github.com/apache/calcite/pull/3708#issuecomment-1972180981
It looks like this CI failure is to be expected, since it fails with Avatica
main. That should pass once Avatica main contains the corresponding fix.
--
This is an automated message
sonarcloud[bot] commented on PR #3708:
URL: https://github.com/apache/calcite/pull/3708#issuecomment-1972170232
## [