mihaibudiu commented on PR #3773:
URL: https://github.com/apache/calcite/pull/3773#issuecomment-2113141295
Anything that works correctly is fine for me. Please note that I am on
vacation so I won't have time to review this soon.
--
This is an automated message from the Apache Git
sonarcloud[bot] commented on PR #3773:
URL: https://github.com/apache/calcite/pull/3773#issuecomment-2113069331
## [. If
normanj-bitquill commented on code in PR #3773:
URL: https://github.com/apache/calcite/pull/3773#discussion_r1583854856
##
core/src/test/java/org/apache/calcite/util/format/PostgresqlDateTimeFormatterTest.java:
##
@@ -0,0 +1,1238 @@
+/*
+ * Licensed to the Apache Software
normanj-bitquill commented on code in PR #3773:
URL: https://github.com/apache/calcite/pull/3773#discussion_r1583854741
##
core/src/main/java/org/apache/calcite/util/format/PostgresqlDateTimeFormatter.java:
##
@@ -0,0 +1,660 @@
+/*
+ * Licensed to the Apache Software Foundation
normanj-bitquill commented on code in PR #3773:
URL: https://github.com/apache/calcite/pull/3773#discussion_r1583854483
##
core/src/main/java/org/apache/calcite/util/format/PostgresqlDateTimeFormatter.java:
##
@@ -0,0 +1,660 @@
+/*
+ * Licensed to the Apache Software Foundation
normanj-bitquill commented on PR #3773:
URL: https://github.com/apache/calcite/pull/3773#issuecomment-2083797456
@caicancai
> I remember that calcite currently has support for the postgres to_char
function. Should we remove the previous support?
The existing TO_CHAR function
sonarcloud[bot] commented on PR #3773:
URL: https://github.com/apache/calcite/pull/3773#issuecomment-2083758777
## [
mihaibudiu commented on PR #3773:
URL: https://github.com/apache/calcite/pull/3773#issuecomment-2080050465
The statement that they were run against Postgres helps a lot. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
normanj-bitquill commented on PR #3773:
URL: https://github.com/apache/calcite/pull/3773#issuecomment-2080047785
@mihaibudiu
> The amount of testing is very impressive. These won't be easy to review. I
assume they were checked against postgres. You should address the failures
reported
sonarcloud[bot] commented on PR #3773:
URL: https://github.com/apache/calcite/pull/3773#issuecomment-2079841077
## [