[jira] [Comment Edited] (CASSANDRA-15852) Handle errors in StreamSession#prepare

2020-08-17 Thread Marcus Eriksson (Jira) 


[ 
https://issues.apache.org/jira/browse/CASSANDRA-15852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17178913#comment-17178913
 ] 

Marcus Eriksson edited comment on CASSANDRA-15852 at 8/17/20, 11:42 AM:


pushed an update

Can't change the exception type since this is thrown on replica side and we 
don't re-throw the same exception on the stream coordinator, we only know that 
it failed, not why. Added a boolean in the bytebuddy redefine to make sure we 
have thrown the correct exception on the replica.


was (Author: krummas):
pushed an update

Can't change the exception type since this is thrown on replica side and we 
don't re-throw the same exception on the stream coordinator, we only know that 
it failed, now why. Added a boolean in the bytebuddy redefine to make sure we 
have thrown the correct exception on the replica.

> Handle errors in StreamSession#prepare
> --
>
> Key: CASSANDRA-15852
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15852
> Project: Cassandra
>  Issue Type: Bug
>  Components: Consistency/Streaming
>Reporter: Marcus Eriksson
>Assignee: Marcus Eriksson
>Priority: Normal
> Fix For: 4.0-beta
>
>
> Since CASSANDRA-12229 we don't handle errors in {{StreamSession#prepare}} - 
> this makes a stream initiator hang forever if an error is thrown.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Comment Edited] (CASSANDRA-15852) Handle errors in StreamSession#prepare

2020-06-23 Thread Caleb Rackliffe (Jira) 


[ 
https://issues.apache.org/jira/browse/CASSANDRA-15852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143272#comment-17143272
 ] 

Caleb Rackliffe edited comment on CASSANDRA-15852 at 6/23/20, 8:28 PM:
---

Other than agreeing w/ [~dcapwell] about the intelligibility of the exception 
(I might go so far as to make an error message field in the {{SessionInfo}} or 
{{StreamSession}}), the only other thing is that the {{throw e}} on 
{{StreamSession:700}} seems unnecessary.

Assuming those are resolved, LGTM


was (Author: maedhroz):
Other than agreeing w/ [~dcapwell] about the intelligibility of the exception 
(I might go so far as to make an error message part of the {{SessionInfo}}, 
although that class is currently immutable), the only other thing is that the 
{{throw e}} on {{StreamSession:700}} seems unnecessary.

Assuming those are resolved, LGTM

> Handle errors in StreamSession#prepare
> --
>
> Key: CASSANDRA-15852
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15852
> Project: Cassandra
>  Issue Type: Bug
>  Components: Consistency/Streaming
>Reporter: Marcus Eriksson
>Assignee: Marcus Eriksson
>Priority: Normal
> Fix For: 4.0-beta
>
>
> Since CASSANDRA-12229 we don't handle errors in {{StreamSession#prepare}} - 
> this makes a stream initiator hang forever if an error is thrown.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Comment Edited] (CASSANDRA-15852) Handle errors in StreamSession#prepare

2020-06-23 Thread Caleb Rackliffe (Jira) 


[ 
https://issues.apache.org/jira/browse/CASSANDRA-15852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143272#comment-17143272
 ] 

Caleb Rackliffe edited comment on CASSANDRA-15852 at 6/23/20, 8:23 PM:
---

Other than agreeing w/ [~dcapwell] about the intelligibility of the exception 
(I might go so far as to make an error message part of the {{SessionInfo}}, 
although that class is currently immutable), the only other thing is that the 
{{throw e}} on {{StreamSession:700}} seems unnecessary.

Assuming those are resolved, LGTM


was (Author: maedhroz):
Other than agreeing w/ [~dcapwell] about the intelligibility of the exception 
(I might go so far as to make an error message part of the {{StreamState}} in 
general), the only other thing is that the {{throw e}} on {{StreamSession:700}} 
seems unnecessary.

Assuming those are resolved, LGTM

> Handle errors in StreamSession#prepare
> --
>
> Key: CASSANDRA-15852
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15852
> Project: Cassandra
>  Issue Type: Bug
>  Components: Consistency/Streaming
>Reporter: Marcus Eriksson
>Assignee: Marcus Eriksson
>Priority: Normal
> Fix For: 4.0-beta
>
>
> Since CASSANDRA-12229 we don't handle errors in {{StreamSession#prepare}} - 
> this makes a stream initiator hang forever if an error is thrown.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

[jira] [Comment Edited] (CASSANDRA-15852) Handle errors in StreamSession#prepare

2020-06-10 Thread Marcus Eriksson (Jira) 


[ 
https://issues.apache.org/jira/browse/CASSANDRA-15852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17130633#comment-17130633
 ] 

Marcus Eriksson edited comment on CASSANDRA-15852 at 6/10/20, 1:35 PM:
---

https://github.com/krummas/cassandra/commits/marcuse/15852 - on top of 
CASSANDRA-15851 to be able to test

[unit tests|https://circleci.com/gh/krummas/cassandra/3389]
[jvm dtests|https://circleci.com/gh/krummas/cassandra/3388]
dtests [vnodes|https://circleci.com/gh/krummas/cassandra/3390], 
[novnodes|https://circleci.com/gh/krummas/cassandra/3391]


was (Author: krummas):
https://github.com/krummas/cassandra/commits/marcuse/15852 - on top of 
CASSANDRA-15851 to be able to test

I'll post cci run links once they are done

> Handle errors in StreamSession#prepare
> --
>
> Key: CASSANDRA-15852
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15852
> Project: Cassandra
>  Issue Type: Bug
>  Components: Consistency/Streaming
>Reporter: Marcus Eriksson
>Assignee: Marcus Eriksson
>Priority: Normal
> Fix For: 4.0-beta
>
>
> Since CASSANDRA-12229 we don't handle errors in {{StreamSession#prepare}} - 
> this makes a stream initiator hang forever if an error is thrown.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org