[jira] [Commented] (CASSANDRA-12461) Add hooks to StorageService shutdown

2016-10-04 Thread Alex Petrov (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-12461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15547819#comment-15547819 ] Alex Petrov commented on CASSANDRA-12461: - Thank you [~Stefania] & [~acoz]!

[jira] [Commented] (CASSANDRA-12461) Add hooks to StorageService shutdown

2016-10-04 Thread Stefania (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-12461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15547340#comment-15547340 ] Stefania commented on CASSANDRA-12461: -- Thanks for rebasing. Committed to 3.X as

[jira] [Commented] (CASSANDRA-12461) Add hooks to StorageService shutdown

2016-10-04 Thread Alex Petrov (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-12461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15545146#comment-15545146 ] Alex Petrov commented on CASSANDRA-12461: - Rebased on top of latest {{3.X}} a

[jira] [Commented] (CASSANDRA-12461) Add hooks to StorageService shutdown

2016-10-03 Thread Stefania (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-12461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15544086#comment-15544086 ] Stefania commented on CASSANDRA-12461: -- CASSANDRA-12509 has been committed, we c

[jira] [Commented] (CASSANDRA-12461) Add hooks to StorageService shutdown

2016-09-29 Thread Alex Petrov (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-12461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15532870#comment-15532870 ] Alex Petrov commented on CASSANDRA-12461: - Right, [CASSANDRA-12011] is contai

[jira] [Commented] (CASSANDRA-12461) Add hooks to StorageService shutdown

2016-09-29 Thread Jeremiah Jordan (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-12461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15532856#comment-15532856 ] Jeremiah Jordan commented on CASSANDRA-12461: - If we put the hooks in 3.0

[jira] [Commented] (CASSANDRA-12461) Add hooks to StorageService shutdown

2016-09-29 Thread Alex Petrov (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-12461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15532753#comment-15532753 ] Alex Petrov commented on CASSANDRA-12461: - Moved the bugfix to [CASSANDRA-125

[jira] [Commented] (CASSANDRA-12461) Add hooks to StorageService shutdown

2016-09-29 Thread Aleksey Yeschenko (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-12461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15532397#comment-15532397 ] Aleksey Yeschenko commented on CASSANDRA-12461: --- I'd only leave the bug

[jira] [Commented] (CASSANDRA-12461) Add hooks to StorageService shutdown

2016-09-29 Thread Stefania (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-12461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15531998#comment-15531998 ] Stefania commented on CASSANDRA-12461: -- +1 for committing the full patch to 3.0

[jira] [Commented] (CASSANDRA-12461) Add hooks to StorageService shutdown

2016-09-28 Thread Alex Petrov (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-12461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15531974#comment-15531974 ] Alex Petrov commented on CASSANDRA-12461: - +1 on changes. The initial patch

[jira] [Commented] (CASSANDRA-12461) Add hooks to StorageService shutdown

2016-09-28 Thread Stefania (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-12461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15531686#comment-15531686 ] Stefania commented on CASSANDRA-12461: -- It LGTM, with these two changes: * I il

[jira] [Commented] (CASSANDRA-12461) Add hooks to StorageService shutdown

2016-09-28 Thread Alex Petrov (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-12461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15529017#comment-15529017 ] Alex Petrov commented on CASSANDRA-12461: - Thank you for the detailed review.

[jira] [Commented] (CASSANDRA-12461) Add hooks to StorageService shutdown

2016-09-27 Thread Stefania (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-12461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15528282#comment-15528282 ] Stefania commented on CASSANDRA-12461: -- I'm definitely very much in favor of wha

[jira] [Commented] (CASSANDRA-12461) Add hooks to StorageService shutdown

2016-09-22 Thread Alex Petrov (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-12461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15513021#comment-15513021 ] Alex Petrov commented on CASSANDRA-12461: - I've discovered several more probl

[jira] [Commented] (CASSANDRA-12461) Add hooks to StorageService shutdown

2016-09-21 Thread Alex Petrov (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-12461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15511331#comment-15511331 ] Alex Petrov commented on CASSANDRA-12461: - [~JoshuaMcKenzie] I've created [CA

[jira] [Commented] (CASSANDRA-12461) Add hooks to StorageService shutdown

2016-09-21 Thread Joshua McKenzie (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-12461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15511255#comment-15511255 ] Joshua McKenzie commented on CASSANDRA-12461: - ping [~ifesdjeen] > Add h

[jira] [Commented] (CASSANDRA-12461) Add hooks to StorageService shutdown

2016-09-13 Thread Anthony Cozzie (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-12461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15487544#comment-15487544 ] Anthony Cozzie commented on CASSANDRA-12461: Pushed a new patch with the

[jira] [Commented] (CASSANDRA-12461) Add hooks to StorageService shutdown

2016-08-30 Thread Anthony Cozzie (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-12461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15449879#comment-15449879 ] Anthony Cozzie commented on CASSANDRA-12461: Nod, that did occur to me as

[jira] [Commented] (CASSANDRA-12461) Add hooks to StorageService shutdown

2016-08-30 Thread Sergio Bossa (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-12461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15449097#comment-15449097 ] Sergio Bossa commented on CASSANDRA-12461: -- FWIW, I find the naming a bit co

[jira] [Commented] (CASSANDRA-12461) Add hooks to StorageService shutdown

2016-08-29 Thread Anthony Cozzie (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-12461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446337#comment-15446337 ] Anthony Cozzie commented on CASSANDRA-12461: Ah, good catch. I think thi

[jira] [Commented] (CASSANDRA-12461) Add hooks to StorageService shutdown

2016-08-26 Thread Alex Petrov (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-12461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15438651#comment-15438651 ] Alex Petrov commented on CASSANDRA-12461: - bq. I was unable to reproduce the

[jira] [Commented] (CASSANDRA-12461) Add hooks to StorageService shutdown

2016-08-23 Thread Anthony Cozzie (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-12461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15433003#comment-15433003 ] Anthony Cozzie commented on CASSANDRA-12461: I pushed a new version of th

[jira] [Commented] (CASSANDRA-12461) Add hooks to StorageService shutdown

2016-08-19 Thread Alex Petrov (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-12461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428541#comment-15428541 ] Alex Petrov commented on CASSANDRA-12461: - bq. It is a great way to introduce

[jira] [Commented] (CASSANDRA-12461) Add hooks to StorageService shutdown

2016-08-19 Thread Anthony Cozzie (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-12461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428470#comment-15428470 ] Anthony Cozzie commented on CASSANDRA-12461: Thanks for your review Alex!

[jira] [Commented] (CASSANDRA-12461) Add hooks to StorageService shutdown

2016-08-19 Thread Alex Petrov (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-12461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428040#comment-15428040 ] Alex Petrov commented on CASSANDRA-12461: - Hi [~acoz]. I have several minor s

[jira] [Commented] (CASSANDRA-12461) Add hooks to StorageService shutdown

2016-08-17 Thread Alex Petrov (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-12461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15424480#comment-15424480 ] Alex Petrov commented on CASSANDRA-12461: - Hi Anthony, thank you for the patc

[jira] [Commented] (CASSANDRA-12461) Add hooks to StorageService shutdown

2016-08-16 Thread Anthony Cozzie (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-12461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15423525#comment-15423525 ] Anthony Cozzie commented on CASSANDRA-12461: OK, back ported the patch to

[jira] [Commented] (CASSANDRA-12461) Add hooks to StorageService shutdown

2016-08-15 Thread Anthony Cozzie (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-12461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15421633#comment-15421633 ] Anthony Cozzie commented on CASSANDRA-12461: I'm going to go ahead and fi

[jira] [Commented] (CASSANDRA-12461) Add hooks to StorageService shutdown

2016-08-15 Thread Anthony Cozzie (JIRA)
[ https://issues.apache.org/jira/browse/CASSANDRA-12461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15421170#comment-15421170 ] Anthony Cozzie commented on CASSANDRA-12461: Notes: * Wrapping the hook