[jira] [Commented] (CASSANDRA-14872) Update to version of python driver and update cqlsh to use driver metadata for virtual tables
[
https://issues.apache.org/jira/browse/CASSANDRA-14872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17041282#comment-17041282
]
Jon Haddad commented on CASSANDRA-14872:
LGTM, +1.
> Update to version of python driver and update cqlsh to use driver metadata
> for virtual tables
> -
>
> Key: CASSANDRA-14872
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14872
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/cqlsh
>Reporter: Andy Tolbert
>Assignee: Dinesh Joshi
>Priority: Normal
> Fix For: 4.0, 4.0-alpha
>
>
> When virtual tables were implemented ([CASSANDRA-7622]), cqlsh.py was updated
> to parse virtual keyspace metadata by making queries to the
> {{system_virtual_schema}} table and included a TODO:
> {code:python}
> # TODO remove after virtual tables are added to connection metadata
> {code}
> Since python driver 3.15.0 (released in August), the driver now parses
> virtual keyspace metadata. It would be good to update the bundled python
> driver and simplify cqlsh code to utilize its capability to parse virtual
> tables.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14872) Update to version of python driver and update cqlsh to use driver metadata for virtual tables
[
https://issues.apache.org/jira/browse/CASSANDRA-14872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17040727#comment-17040727
]
Andy Tolbert commented on CASSANDRA-14872:
--
{quote}
It will need some driver changes and I am reluctant to check in a custom build
of the driver. So this is an ok compromise for the time being
{quote}
+1 agree we should proceed with it included as it seems like a small
self-contained dependency, and it is really nice to not use a custom build.
> Update to version of python driver and update cqlsh to use driver metadata
> for virtual tables
> -
>
> Key: CASSANDRA-14872
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14872
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/cqlsh
>Reporter: Andy Tolbert
>Assignee: Dinesh Joshi
>Priority: Normal
> Fix For: 4.0, 4.0-alpha
>
>
> When virtual tables were implemented ([CASSANDRA-7622]), cqlsh.py was updated
> to parse virtual keyspace metadata by making queries to the
> {{system_virtual_schema}} table and included a TODO:
> {code:python}
> # TODO remove after virtual tables are added to connection metadata
> {code}
> Since python driver 3.15.0 (released in August), the driver now parses
> virtual keyspace metadata. It would be good to update the bundled python
> driver and simplify cqlsh code to utilize its capability to parse virtual
> tables.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14872) Update to version of python driver and update cqlsh to use driver metadata for virtual tables
[
https://issues.apache.org/jira/browse/CASSANDRA-14872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17040725#comment-17040725
]
Dinesh Joshi commented on CASSANDRA-14872:
--
Thanks for checking it out Andy. I considered making geomet optional. It will
need some driver changes and I am reluctant to check in a custom build of the
driver. So this is an ok compromise for the time being. As an added benefit of
leaving it in, users can use this cqlsh to connect to DSE and all features that
the driver support will continue functioning including the geospatial types.
> Update to version of python driver and update cqlsh to use driver metadata
> for virtual tables
> -
>
> Key: CASSANDRA-14872
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14872
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/cqlsh
>Reporter: Andy Tolbert
>Assignee: Dinesh Joshi
>Priority: Normal
> Fix For: 4.0, 4.0-alpha
>
>
> When virtual tables were implemented ([CASSANDRA-7622]), cqlsh.py was updated
> to parse virtual keyspace metadata by making queries to the
> {{system_virtual_schema}} table and included a TODO:
> {code:python}
> # TODO remove after virtual tables are added to connection metadata
> {code}
> Since python driver 3.15.0 (released in August), the driver now parses
> virtual keyspace metadata. It would be good to update the bundled python
> driver and simplify cqlsh code to utilize its capability to parse virtual
> tables.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14872) Update to version of python driver and update cqlsh to use driver metadata for virtual tables
[
https://issues.apache.org/jira/browse/CASSANDRA-14872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17040697#comment-17040697
]
Andy Tolbert commented on CASSANDRA-14872:
--
Changes look great! Played around with it a little bit and it's working well.
I like that autocompletion works flawlessly for vtables :)
One thing that is interesting is that geomet is a required dependency. Since
it's apache licensed and seems pretty small that doesn't seem like much of a
deal. I think it could be made optional in the python driver (it's used for
parsing DSE-specific geospatial types) so might be something worth pursuing on
that end.
> Update to version of python driver and update cqlsh to use driver metadata
> for virtual tables
> -
>
> Key: CASSANDRA-14872
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14872
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/cqlsh
>Reporter: Andy Tolbert
>Assignee: Dinesh Joshi
>Priority: Normal
> Fix For: 4.0, 4.0-alpha
>
>
> When virtual tables were implemented ([CASSANDRA-7622]), cqlsh.py was updated
> to parse virtual keyspace metadata by making queries to the
> {{system_virtual_schema}} table and included a TODO:
> {code:python}
> # TODO remove after virtual tables are added to connection metadata
> {code}
> Since python driver 3.15.0 (released in August), the driver now parses
> virtual keyspace metadata. It would be good to update the bundled python
> driver and simplify cqlsh code to utilize its capability to parse virtual
> tables.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14872) Update to version of python driver and update cqlsh to use driver metadata for virtual tables
[
https://issues.apache.org/jira/browse/CASSANDRA-14872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17040686#comment-17040686
]
Andy Tolbert commented on CASSANDRA-14872:
--
I remember trying transient replication with the java driver and it not working
([JAVA-2105|https://datastax-oss.atlassian.net/browse/JAVA-2105]), I suspect
most/all client libraries that read schema need updates to parse it.
> Update to version of python driver and update cqlsh to use driver metadata
> for virtual tables
> -
>
> Key: CASSANDRA-14872
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14872
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/cqlsh
>Reporter: Andy Tolbert
>Assignee: Dinesh Joshi
>Priority: Normal
> Fix For: 4.0, 4.0-alpha
>
>
> When virtual tables were implemented ([CASSANDRA-7622]), cqlsh.py was updated
> to parse virtual keyspace metadata by making queries to the
> {{system_virtual_schema}} table and included a TODO:
> {code:python}
> # TODO remove after virtual tables are added to connection metadata
> {code}
> Since python driver 3.15.0 (released in August), the driver now parses
> virtual keyspace metadata. It would be good to update the bundled python
> driver and simplify cqlsh code to utilize its capability to parse virtual
> tables.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14872) Update to version of python driver and update cqlsh to use driver metadata for virtual tables
[
https://issues.apache.org/jira/browse/CASSANDRA-14872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17040597#comment-17040597
]
Dinesh Joshi commented on CASSANDRA-14872:
--
[~dcapwell] thanks for testing. The latest `python-driver` doesn't seem to
support DESCRIBE for transient replication enabled schemas. Originally I
thought that the latest driver will fix the issue but it doesn't look like it.
Lets not block on this. I'll reopen 15578 and work on when TR is added to the
driver.
For the curious, the issue the way we describe TR enabled RF which breaks the
parsing here:
https://github.com/datastax/python-driver/blob/9297c74c9075b9eb732190f7f0bdf1b06493b808/cassandra/metadata.py#L503-L504
> Update to version of python driver and update cqlsh to use driver metadata
> for virtual tables
> -
>
> Key: CASSANDRA-14872
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14872
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/cqlsh
>Reporter: Andy Tolbert
>Assignee: Dinesh Joshi
>Priority: Normal
> Fix For: 4.0, 4.0-alpha
>
>
> When virtual tables were implemented ([CASSANDRA-7622]), cqlsh.py was updated
> to parse virtual keyspace metadata by making queries to the
> {{system_virtual_schema}} table and included a TODO:
> {code:python}
> # TODO remove after virtual tables are added to connection metadata
> {code}
> Since python driver 3.15.0 (released in August), the driver now parses
> virtual keyspace metadata. It would be good to update the bundled python
> driver and simplify cqlsh code to utilize its capability to parse virtual
> tables.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14872) Update to version of python driver and update cqlsh to use driver metadata for virtual tables
[
https://issues.apache.org/jira/browse/CASSANDRA-14872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17040588#comment-17040588
]
David Capwell commented on CASSANDRA-14872:
---
vtables work
{code}
cqlsh> desc keyspaces;
system_virtual_schema system_schema system_views system_distributed
barsystem_authsystemsystem_traces
cqlsh> describe system_views;
/*
Warning: Keyspace system_views is a virtual keyspace and cannot be recreated
with CQL.
Structure, for reference:*/
// VIRTUAL KEYSPACE system_views;
/*
Warning: Table system_views.sstable_tasks is a virtual table and cannot be
recreated with CQL.
Structure, for reference:
VIRTUAL TABLE system_views.sstable_tasks (
keyspace_name text,
table_name text,
task_id uuid,
kind text,
progress bigint,
total bigint,
unit text,
PRIMARY KEY (keyspace_name, table_name, task_id)
) WITH CLUSTERING ORDER BY (table_name ASC, task_id ASC)
AND comment = 'current sstable tasks';
*/
...
cqlsh> use system_views;
cqlsh:system_views> desc tables;
sstable_tasks clients coordinator_write_latency
disk_usage local_write_latency tombstones_per_read
thread_poolsinternode_outboundsettings
local_scan_latency coordinator_scan_latency max_partition_size
internode_inbound coordinator_read_latency caches
local_read_latency rows_per_read
cqlsh:system_views> desc rows_per_read;
/*
Warning: Table system_views.rows_per_read is a virtual table and cannot be
recreated with CQL.
Structure, for reference:
VIRTUAL TABLE system_views.rows_per_read (
keyspace_name text,
table_name text,
"50th" double,
"99th" double,
count bigint,
max double,
PRIMARY KEY ((keyspace_name, table_name))
) WITH comment = '';
*/
{code}
> Update to version of python driver and update cqlsh to use driver metadata
> for virtual tables
> -
>
> Key: CASSANDRA-14872
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14872
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/cqlsh
>Reporter: Andy Tolbert
>Assignee: Dinesh Joshi
>Priority: Normal
> Fix For: 4.0, 4.0-alpha
>
>
> When virtual tables were implemented ([CASSANDRA-7622]), cqlsh.py was updated
> to parse virtual keyspace metadata by making queries to the
> {{system_virtual_schema}} table and included a TODO:
> {code:python}
> # TODO remove after virtual tables are added to connection metadata
> {code}
> Since python driver 3.15.0 (released in August), the driver now parses
> virtual keyspace metadata. It would be good to update the bundled python
> driver and simplify cqlsh code to utilize its capability to parse virtual
> tables.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14872) Update to version of python driver and update cqlsh to use driver metadata for virtual tables
[
https://issues.apache.org/jira/browse/CASSANDRA-14872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17040586#comment-17040586
]
David Capwell commented on CASSANDRA-14872:
---
TR doesn't work
{code}
cqlsh> CREATE KEYSPACE bar WITH replication = {'class':
'NetworkTopologyStrategy', 'datacenter1': '3/1'};
cqlsh> DESCRIBE KEYSPACE bar;
'NoneType' object has no attribute 'export_for_schema'
{code}
> Update to version of python driver and update cqlsh to use driver metadata
> for virtual tables
> -
>
> Key: CASSANDRA-14872
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14872
> Project: Cassandra
> Issue Type: Bug
> Components: Tool/cqlsh
>Reporter: Andy Tolbert
>Assignee: Dinesh Joshi
>Priority: Normal
> Fix For: 4.0, 4.0-alpha
>
>
> When virtual tables were implemented ([CASSANDRA-7622]), cqlsh.py was updated
> to parse virtual keyspace metadata by making queries to the
> {{system_virtual_schema}} table and included a TODO:
> {code:python}
> # TODO remove after virtual tables are added to connection metadata
> {code}
> Since python driver 3.15.0 (released in August), the driver now parses
> virtual keyspace metadata. It would be good to update the bundled python
> driver and simplify cqlsh code to utilize its capability to parse virtual
> tables.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14872) Update to version of python driver and update cqlsh to use driver metadata for virtual tables
[
https://issues.apache.org/jira/browse/CASSANDRA-14872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16947742#comment-16947742
]
Chris Lohfink commented on CASSANDRA-14872:
---
We need a new build of the driver for
https://datastax-oss.atlassian.net/browse/PYTHON-1158 and also need at least
3.19 for https://datastax-oss.atlassian.net/browse/PYTHON-1118 or the virtual
table stuff wont work even with new builds.
> Update to version of python driver and update cqlsh to use driver metadata
> for virtual tables
> -
>
> Key: CASSANDRA-14872
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14872
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/CQL, Legacy/Tools
>Reporter: Andy Tolbert
>Priority: Normal
>
> When virtual tables were implemented ([CASSANDRA-7622]), cqlsh.py was updated
> to parse virtual keyspace metadata by making queries to the
> {{system_virtual_schema}} table and included a TODO:
> {code:python}
> # TODO remove after virtual tables are added to connection metadata
> {code}
> Since python driver 3.15.0 (released in August), the driver now parses
> virtual keyspace metadata. It would be good to update the bundled python
> driver and simplify cqlsh code to utilize its capability to parse virtual
> tables.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
[jira] [Commented] (CASSANDRA-14872) Update to version of python driver and update cqlsh to use driver metadata for virtual tables
[
https://issues.apache.org/jira/browse/CASSANDRA-14872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16945588#comment-16945588
]
Andy Tolbert commented on CASSANDRA-14872:
--
Newer versions of the python driver also fix some issues around python3, so
upgrading would also benefit [CASSANDRA-10190].
> Update to version of python driver and update cqlsh to use driver metadata
> for virtual tables
> -
>
> Key: CASSANDRA-14872
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14872
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/CQL, Legacy/Tools
>Reporter: Andy Tolbert
>Priority: Normal
>
> When virtual tables were implemented ([CASSANDRA-7622]), cqlsh.py was updated
> to parse virtual keyspace metadata by making queries to the
> {{system_virtual_schema}} table and included a TODO:
> {code:python}
> # TODO remove after virtual tables are added to connection metadata
> {code}
> Since python driver 3.15.0 (released in August), the driver now parses
> virtual keyspace metadata. It would be good to update the bundled python
> driver and simplify cqlsh code to utilize its capability to parse virtual
> tables.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
