[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14285916#comment-14285916
]
Ariel Weisberg commented on CASSANDRA-7438:
---
If you turn the OOME throwing
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14284416#comment-14284416
]
Robert Stupp commented on CASSANDRA-7438:
-
bq. I am +1 conditional on the
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14284230#comment-14284230
]
Ariel Weisberg commented on CASSANDRA-7438:
---
I am +1 conditional on the
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14282467#comment-14282467
]
Robert Stupp commented on CASSANDRA-7438:
-
I think the possibly best
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14280945#comment-14280945
]
Ariel Weisberg commented on CASSANDRA-7438:
---
I ran the benchmark on the
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14275809#comment-14275809
]
Ariel Weisberg commented on CASSANDRA-7438:
---
bq. Making freeCapacity a
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14275047#comment-14275047
]
Robert Stupp commented on CASSANDRA-7438:
-
Thanks for the review. Many useful
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14274005#comment-14274005
]
Ariel Weisberg commented on CASSANDRA-7438:
---
If you go all the way down the
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14274409#comment-14274409
]
Ariel Weisberg commented on CASSANDRA-7438:
---
I did another review. The
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14271745#comment-14271745
]
Robert Stupp commented on CASSANDRA-7438:
-
Note: OHC how has cache-loader
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14267558#comment-14267558
]
Robert Stupp commented on CASSANDRA-7438:
-
BTW: Is there any
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14265947#comment-14265947
]
Robert Stupp commented on CASSANDRA-7438:
-
The latest (just checked in)
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14266809#comment-14266809
]
Robert Stupp commented on CASSANDRA-7438:
-
OHC works in Cassandra:
* unit
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14263083#comment-14263083
]
Ariel Weisberg commented on CASSANDRA-7438:
---
I went to run the benchmark
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14262472#comment-14262472
]
Ariel Weisberg commented on CASSANDRA-7438:
---
I have an in progress response
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14262487#comment-14262487
]
Ariel Weisberg commented on CASSANDRA-7438:
---
bq. Whether to migrate whole
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14257721#comment-14257721
]
Robert Stupp commented on CASSANDRA-7438:
-
I had the opportunity to test OHC
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14251537#comment-14251537
]
Robert Stupp commented on CASSANDRA-7438:
-
I’ve nearly finished the OHC
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14251756#comment-14251756
]
Robert Stupp commented on CASSANDRA-7438:
-
Ah - a burn test is still missing.
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14239729#comment-14239729
]
Ariel Weisberg commented on CASSANDRA-7438:
---
Lot's of cool stuff here
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14240193#comment-14240193
]
Robert Stupp commented on CASSANDRA-7438:
-
bq. Lot's of cool stuff
Thx :)
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14240235#comment-14240235
]
Ariel Weisberg commented on CASSANDRA-7438:
---
bq. That's fair. I just saw
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14240305#comment-14240305
]
Robert Stupp commented on CASSANDRA-7438:
-
Yep - persisting the values would
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237162#comment-14237162
]
Robert Stupp commented on CASSANDRA-7438:
-
Also pushed persistence of cache
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237170#comment-14237170
]
Robert Stupp commented on CASSANDRA-7438:
-
Rehashing: hm - at
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14234696#comment-14234696
]
Robert Stupp commented on CASSANDRA-7438:
-
Just pushed some OHC additions to
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14232833#comment-14232833
]
Benedict commented on CASSANDRA-7438:
-
re: hash bits:
there's not really a
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14231327#comment-14231327
]
Vijay commented on CASSANDRA-7438:
--
[~snazy] I was trying to compare the OHC and
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14231627#comment-14231627
]
Ariel Weisberg commented on CASSANDRA-7438:
---
Robert I don't seem to be
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14231817#comment-14231817
]
Robert Stupp commented on CASSANDRA-7438:
-
[~vijay2...@yahoo.com] can you
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14231878#comment-14231878
]
Vijay commented on CASSANDRA-7438:
--
Never mind, my bad it was related the below
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14230675#comment-14230675
]
Ariel Weisberg commented on CASSANDRA-7438:
---
Look pretty nice.
Suggestions:
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14231132#comment-14231132
]
Robert Stupp commented on CASSANDRA-7438:
-
[~aweisberg], thanks for the review
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14229284#comment-14229284
]
Robert Stupp commented on CASSANDRA-7438:
-
Have pushed the latest changes of
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14228693#comment-14228693
]
Benedict commented on CASSANDRA-7438:
-
Invert those two statements and the
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14228871#comment-14228871
]
Vijay commented on CASSANDRA-7438:
--
Should be taken care of too, it should become a
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14228306#comment-14228306
]
Ariel Weisberg commented on CASSANDRA-7438:
---
Pauseless resizing is a worthy
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14228397#comment-14228397
]
Benedict commented on CASSANDRA-7438:
-
I suspect segmenting the table at a finer
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14228515#comment-14228515
]
Ariel Weisberg commented on CASSANDRA-7438:
---
+1 To what Benedict suggests.
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14228523#comment-14228523
]
Vijay commented on CASSANDRA-7438:
--
{quote}I would break out the performance
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14228524#comment-14228524
]
Vijay commented on CASSANDRA-7438:
--
PS: all the latency spikes are in 100' of micros.
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14228563#comment-14228563
]
Benedict commented on CASSANDRA-7438:
-
[~aweisberg]: In my experience segments
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14228569#comment-14228569
]
Vijay commented on CASSANDRA-7438:
--
{quote}The queue is maintained by a separate
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14228575#comment-14228575
]
Benedict commented on CASSANDRA-7438:
-
bq. I am 100% sure
Never be 100% sure with
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14228577#comment-14228577
]
Vijay commented on CASSANDRA-7438:
--
May be you know better than me, but map.remove
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14226474#comment-14226474
]
Tupshin Harper commented on CASSANDRA-7438:
---
[~xedin] I'm lost in too many
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14226516#comment-14226516
]
Robert Stupp commented on CASSANDRA-7438:
-
Some short notes about the last
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14226531#comment-14226531
]
Ariel Weisberg commented on CASSANDRA-7438:
---
When are large regions being
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14226552#comment-14226552
]
Vijay commented on CASSANDRA-7438:
--
{quote}One thing I noticed during benchmarking is
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14226795#comment-14226795
]
Ariel Weisberg commented on CASSANDRA-7438:
---
Caching entire rows of very
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14226776#comment-14226776
]
Robert Stupp commented on CASSANDRA-7438:
-
The row cache can contain very
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14226861#comment-14226861
]
Pavel Yaskevich commented on CASSANDRA-7438:
[~tupshin] Original idea of
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14227248#comment-14227248
]
Jonathan Ellis commented on CASSANDRA-7438:
---
bq. The row cache can contain
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14227250#comment-14227250
]
Jonathan Ellis commented on CASSANDRA-7438:
---
Looking at the discussion, I
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14224611#comment-14224611
]
Robert Stupp commented on CASSANDRA-7438:
-
[~aweisberg] thanks for that write
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14224904#comment-14224904
]
Vijay commented on CASSANDRA-7438:
--
{quote}
sun.misc.Hashing doesn't seem to exist
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14225371#comment-14225371
]
Ariel Weisberg commented on CASSANDRA-7438:
---
bq. Are you suggesting a
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14225453#comment-14225453
]
Vijay commented on CASSANDRA-7438:
--
{quote}
Segments are hash buckets correct?
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14225478#comment-14225478
]
Ariel Weisberg commented on CASSANDRA-7438:
---
bq. if we don't like the
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14225531#comment-14225531
]
Robert Stupp commented on CASSANDRA-7438:
-
bq. alignment requirements for 4 or
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14225532#comment-14225532
]
Vijay commented on CASSANDRA-7438:
--
{quote}
so each segment would be a 4-byte lock
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14225592#comment-14225592
]
Ariel Weisberg commented on CASSANDRA-7438:
---
bq. I thought we discussed this
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14225616#comment-14225616
]
Pavel Yaskevich commented on CASSANDRA-7438:
I guess the only thing that
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14222799#comment-14222799
]
Robert Stupp commented on CASSANDRA-7438:
-
rehashing: growing (x2) is already
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14222802#comment-14222802
]
Pavel Yaskevich commented on CASSANDRA-7438:
bq. per-partition locks:
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14223479#comment-14223479
]
Ariel Weisberg commented on CASSANDRA-7438:
---
I think that for caches the
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14222365#comment-14222365
]
Robert Stupp commented on CASSANDRA-7438:
-
I've spent some evenings on an
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14222660#comment-14222660
]
Pavel Yaskevich commented on CASSANDRA-7438:
Personally I like what Vijay
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1495#comment-1495
]
Vijay commented on CASSANDRA-7438:
--
Alright the first version of pure Java version of
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14199976#comment-14199976
]
Robert Stupp commented on CASSANDRA-7438:
-
Debugging C code via JNI and
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14198368#comment-14198368
]
Jonathan Ellis commented on CASSANDRA-7438:
---
Here's me in July:
bq. I'm not
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14198523#comment-14198523
]
Vijay commented on CASSANDRA-7438:
--
Alright looks like the objection is not on the
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14196296#comment-14196296
]
Ariel Weisberg commented on CASSANDRA-7438:
---
.bq No we don't. We have locks
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14196492#comment-14196492
]
Vijay commented on CASSANDRA-7438:
--
{quote}
well I think you run into another issue
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14196885#comment-14196885
]
Jonathan Ellis commented on CASSANDRA-7438:
---
bq. There is some comments
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14197029#comment-14197029
]
Vijay commented on CASSANDRA-7438:
--
{quote}
Aren't all those objections to the
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14195418#comment-14195418
]
Ariel Weisberg commented on CASSANDRA-7438:
---
RE refcount:
I think hazard
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14195679#comment-14195679
]
Vijay commented on CASSANDRA-7438:
--
Thanks for reviewing!
{quote}
I am also not
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14193760#comment-14193760
]
Vijay commented on CASSANDRA-7438:
--
Pushed, Thanks!
{quote}
We should ensure that
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14193785#comment-14193785
]
Robert Stupp commented on CASSANDRA-7438:
-
bq. I don't think we changed the
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14193074#comment-14193074
]
Robert Stupp commented on CASSANDRA-7438:
-
bq. total 1 byte profit
bikeshed :
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14192874#comment-14192874
]
Jonathan Ellis commented on CASSANDRA-7438:
---
[~aweisberg], would be useful
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14192922#comment-14192922
]
Pavel Yaskevich commented on CASSANDRA-7438:
I looked trough the patch and
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14190711#comment-14190711
]
Robert Stupp commented on CASSANDRA-7438:
-
Did a walkthrough to lruc 0.7,
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14189224#comment-14189224
]
Robert Stupp commented on CASSANDRA-7438:
-
LGTM - but some comments:
* the
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14189364#comment-14189364
]
Vijay commented on CASSANDRA-7438:
--
rebased, pushed with latest binaries.
{quote}
the
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14172078#comment-14172078
]
Robert Stupp commented on CASSANDRA-7438:
-
Will take a look at this this week.
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14160044#comment-14160044
]
Vijay commented on CASSANDRA-7438:
--
Pushed most of the changes to
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14157989#comment-14157989
]
Jonathan Ellis commented on CASSANDRA-7438:
---
Are you still working on this,
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14158005#comment-14158005
]
Vijay commented on CASSANDRA-7438:
--
Hi Jonathan, yes, i am adding more tests and
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14145338#comment-14145338
]
Robert Stupp commented on CASSANDRA-7438:
-
(note: [~vijay2...@gmail.com],
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14144260#comment-14144260
]
Vijay commented on CASSANDRA-7438:
--
Hi [~rst...@pironet-ndh.com], I dont see a
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14080708#comment-14080708
]
Robert Stupp commented on CASSANDRA-7438:
-
bq. Yeah it works in unix, but the
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14075611#comment-14075611
]
Robert Stupp commented on CASSANDRA-7438:
-
[~vijay2...@gmail.com] do you have
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14075630#comment-14075630
]
Robert Stupp commented on CASSANDRA-7438:
-
Surely not a complete list, but a
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14075676#comment-14075676
]
Vijay commented on CASSANDRA-7438:
--
Pushed the branch to
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14075516#comment-14075516
]
Vijay commented on CASSANDRA-7438:
--
{quote}
unsafe.memoryAllocate instead and
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14074452#comment-14074452
]
Robert Stupp commented on CASSANDRA-7438:
-
[~jbellis] Yes, I can review.
I
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14072935#comment-14072935
]
Robert Stupp commented on CASSANDRA-7438:
-
my username on github is snazy
Do
[
https://issues.apache.org/jira/browse/CASSANDRA-7438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14072950#comment-14072950
]
Benedict commented on CASSANDRA-7438:
-
bq. Not sure what we are talking about,
1 - 100 of 117 matches
Mail list logo
