frankgh merged PR #45:
URL: https://github.com/apache/cassandra-analytics/pull/45
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
frankgh commented on code in PR #45:
URL:
https://github.com/apache/cassandra-analytics/pull/45#discussion_r1546825765
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CassandraBulkWriterContext.java:
##
@@ -92,11 +92,17 @@ protected
frankgh commented on code in PR #45:
URL:
https://github.com/apache/cassandra-analytics/pull/45#discussion_r1541520438
##
cassandra-analytics-core/src/test/java/org/apache/cassandra/spark/bulkwriter/MockBulkWriterContext.java:
##
@@ -77,6 +79,7 @@ public class
JeetKunDoug commented on PR #45:
URL:
https://github.com/apache/cassandra-analytics/pull/45#issuecomment-2030455448
Rebased/squashed/fixed CHANGES.txt conflict (no other changes/conflicts)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
JeetKunDoug commented on PR #45:
URL:
https://github.com/apache/cassandra-analytics/pull/45#issuecomment-2025470916
Rebased, addressed comments, green CircleCI:
https://app.circleci.com/pipelines/github/JeetKunDoug/cassandra-analytics/141/workflows/9d8c886c-81c9-4d43-9e78-43a52fab14f9
--
JeetKunDoug commented on code in PR #45:
URL:
https://github.com/apache/cassandra-analytics/pull/45#discussion_r1541488419
##
cassandra-four-zero/src/main/java/org/apache/cassandra/bridge/SSTableWriterImplementation.java:
##
@@ -81,17 +85,23 @@ static CQLSSTableWriter.Builder
JeetKunDoug commented on code in PR #45:
URL:
https://github.com/apache/cassandra-analytics/pull/45#discussion_r1541482050
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/SqlToCqlTypeConverter.java:
##
@@ -788,11 +797,54 @@ else if (object
JeetKunDoug commented on code in PR #45:
URL:
https://github.com/apache/cassandra-analytics/pull/45#discussion_r1541478857
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/SqlToCqlTypeConverter.java:
##
@@ -763,6 +766,12 @@ else if (object
yifan-c commented on code in PR #45:
URL:
https://github.com/apache/cassandra-analytics/pull/45#discussion_r1540148669
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CassandraSchemaInfo.java:
##
@@ -19,19 +19,33 @@
package
yifan-c commented on code in PR #45:
URL:
https://github.com/apache/cassandra-analytics/pull/45#discussion_r1540147665
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CassandraBulkWriterContext.java:
##
@@ -87,11 +87,21 @@ private
yifan-c commented on code in PR #45:
URL:
https://github.com/apache/cassandra-analytics/pull/45#discussion_r1540144916
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CassandraBulkWriterContext.java:
##
@@ -64,7 +65,6 @@ private
frankgh commented on code in PR #45:
URL:
https://github.com/apache/cassandra-analytics/pull/45#discussion_r1540121145
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CassandraBulkWriterContext.java:
##
@@ -87,11 +87,21 @@ private
JeetKunDoug commented on code in PR #45:
URL:
https://github.com/apache/cassandra-analytics/pull/45#discussion_r1539956682
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CqlTableInfoProvider.java:
##
@@ -98,9 +98,20 @@ public CqlField.CqlType
JeetKunDoug commented on code in PR #45:
URL:
https://github.com/apache/cassandra-analytics/pull/45#discussion_r1539951034
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CassandraBulkWriterContext.java:
##
@@ -87,11 +87,21 @@ private
JeetKunDoug commented on code in PR #45:
URL:
https://github.com/apache/cassandra-analytics/pull/45#discussion_r1539949686
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CassandraBulkWriterContext.java:
##
@@ -64,7 +65,6 @@ private
frankgh commented on code in PR #45:
URL:
https://github.com/apache/cassandra-analytics/pull/45#discussion_r1535498626
##
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CassandraBulkWriterContext.java:
##
@@ -87,11 +87,21 @@ private
16 matches
Mail list logo