[GitHub] [cloudstack] DaanHoogland commented on issue #3204: server: Fix exception while update domain resource count

2019-04-29 Thread GitBox
DaanHoogland commented on issue #3204: server: Fix exception while update domain resource count URL: https://github.com/apache/cloudstack/pull/3204#issuecomment-487468039 reviewed the test error, it is a failing ssh connection, nothing to do with this

[GitHub] [cloudstack] DaanHoogland commented on issue #3304: server: Fix exception while update domain resource count (#3204)

2019-04-29 Thread GitBox
DaanHoogland commented on issue #3304: server: Fix exception while update domain resource count (#3204) URL: https://github.com/apache/cloudstack/pull/3304#issuecomment-487505822 @ustcweizhou same conflict, this was quicker

[GitHub] [cloudstack] webermaximilian92 edited a comment on issue #3301: Add scss to css compiler

2019-04-29 Thread GitBox
webermaximilian92 edited a comment on issue #3301: Add scss to css compiler URL: https://github.com/apache/cloudstack/pull/3301#issuecomment-487510844 Hey @rafaelweingartner , - sass and scss are preprocessors of css. Similar to ES6 or TypeScript for JavaScript. - SCSS provides

[GitHub] [cloudstack] rhtyd commented on issue #3278: systemvm: new qemu-guest-agent based patching for KVM

2019-04-29 Thread GitBox
rhtyd commented on issue #3278: systemvm: new qemu-guest-agent based patching for KVM URL: https://github.com/apache/cloudstack/pull/3278#issuecomment-487539566 @PaulAngus - please review. After merging this, we may explore merging any further changes to the systemvmtemplate @PaulAngus

[cloudstack] branch 4.11 updated: server: Fix exception while update domain resource count (#3204)

2019-04-29 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch 4.11 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.11 by this push: new b60daf7 server: Fix exception while update

[GitHub] [cloudstack] DaanHoogland commented on issue #3302: server: sync templates on adding new secondary storage

2019-04-29 Thread GitBox
DaanHoogland commented on issue #3302: server: sync templates on adding new secondary storage URL: https://github.com/apache/cloudstack/pull/3302#issuecomment-487470292 @blueorangutan test This is an automated message from

[GitHub] [cloudstack] DaanHoogland merged pull request #3204: server: Fix exception while update domain resource count

2019-04-29 Thread GitBox
DaanHoogland merged pull request #3204: server: Fix exception while update domain resource count URL: https://github.com/apache/cloudstack/pull/3204 This is an automated message from the Apache Git Service. To respond to

[cloudstack] branch reimplement3303on4.12 created (now 9488c6d)

2019-04-29 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch reimplement3303on4.12 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. at 9488c6d Merge remote-tracking branch 'origin/4.11' into 4.12 No new revisions were added by this

[cloudstack] branch reimplement3303on4.12 updated: server: Fix exception while update domain resource count (#3204) reimplement 3303 on moved file in 4.12

2019-04-29 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch reimplement3303on4.12 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/reimplement3303on4.12 by this push: new 1bb64e5

[GitHub] [cloudstack] pbankonier commented on a change in pull request #3294: Set default service offering over api and ui

2019-04-29 Thread GitBox
pbankonier commented on a change in pull request #3294: Set default service offering over api and ui URL: https://github.com/apache/cloudstack/pull/3294#discussion_r279278663 ## File path: engine/schema/src/main/java/com/cloud/service/dao/ServiceOfferingDaoImpl.java ##

[GitHub] [cloudstack] DaanHoogland opened a new pull request #3303: server: Fix exception while update domain resource count (#3204)

2019-04-29 Thread GitBox
DaanHoogland opened a new pull request #3303: server: Fix exception while update domain resource count (#3204) URL: https://github.com/apache/cloudstack/pull/3303 ## Description ## Types of changes - [ ] Breaking change (fix or feature that

[GitHub] [cloudstack] blueorangutan commented on issue #3302: server: sync templates on adding new secondary storage

2019-04-29 Thread GitBox
blueorangutan commented on issue #3302: server: sync templates on adding new secondary storage URL: https://github.com/apache/cloudstack/pull/3302#issuecomment-487470062 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2722

[GitHub] [cloudstack] pbankonier commented on a change in pull request #3294: Set default service offering over api and ui

2019-04-29 Thread GitBox
pbankonier commented on a change in pull request #3294: Set default service offering over api and ui URL: https://github.com/apache/cloudstack/pull/3294#discussion_r279278663 ## File path: engine/schema/src/main/java/com/cloud/service/dao/ServiceOfferingDaoImpl.java ##

[GitHub] [cloudstack] webermaximilian92 edited a comment on issue #3301: Add scss to css compiler

2019-04-29 Thread GitBox
webermaximilian92 edited a comment on issue #3301: Add scss to css compiler URL: https://github.com/apache/cloudstack/pull/3301#issuecomment-487510844 Hey @rafaelweingartner , - Using CSS is no longer the common standard for complex pages like cloudstack - SASS

[GitHub] [cloudstack] blueorangutan commented on issue #3302: server: sync templates on adding new secondary storage

2019-04-29 Thread GitBox
blueorangutan commented on issue #3302: server: sync templates on adding new secondary storage URL: https://github.com/apache/cloudstack/pull/3302#issuecomment-487470474 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] [cloudstack] DaanHoogland opened a new pull request #3304: server: Fix exception while update domain resource count (#3204)

2019-04-29 Thread GitBox
DaanHoogland opened a new pull request #3304: server: Fix exception while update domain resource count (#3204) URL: https://github.com/apache/cloudstack/pull/3304 reimplement 3303 on moved file in 4.12 ## Description ## Types of changes

[GitHub] [cloudstack] ustcweizhou commented on issue #3304: server: Fix exception while update domain resource count (#3204)

2019-04-29 Thread GitBox
ustcweizhou commented on issue #3304: server: Fix exception while update domain resource count (#3204) URL: https://github.com/apache/cloudstack/pull/3304#issuecomment-487504504 @DaanHoogland ok. what about cherry-pick ?

[GitHub] [cloudstack] pbankonier commented on issue #3294: Set default service offering over api and ui

2019-04-29 Thread GitBox
pbankonier commented on issue #3294: Set default service offering over api and ui URL: https://github.com/apache/cloudstack/pull/3294#issuecomment-487507146 > @svenvogel code looks alright but please explain how uniquename and defaultuse are connected. @DaanHoogland The unique name

[GitHub] [cloudstack] webermaximilian92 edited a comment on issue #3301: Add scss to css compiler

2019-04-29 Thread GitBox
webermaximilian92 edited a comment on issue #3301: Add scss to css compiler URL: https://github.com/apache/cloudstack/pull/3301#issuecomment-487510844 Hey @rafaelweingartner , - SASS or SCSS are preprocessors of css. Similar to ES6 or TypeScript for JavaScript. - SCSS provides us

[GitHub] [cloudstack] webermaximilian92 edited a comment on issue #3301: Add scss to css compiler

2019-04-29 Thread GitBox
webermaximilian92 edited a comment on issue #3301: Add scss to css compiler URL: https://github.com/apache/cloudstack/pull/3301#issuecomment-487510844 Hey @rafaelweingartner , - Using CSS is no longer the common standard for complex pages like cloudstack - SASS

[GitHub] [cloudstack] DaanHoogland closed pull request #3303: server: Fix exception while update domain resource count (#3204)

2019-04-29 Thread GitBox
DaanHoogland closed pull request #3303: server: Fix exception while update domain resource count (#3204) URL: https://github.com/apache/cloudstack/pull/3303 This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] DaanHoogland commented on issue #3289: Update to latest InfluxDB (2.15), adding support to Batch Mode

2019-04-29 Thread GitBox
DaanHoogland commented on issue #3289: Update to latest InfluxDB (2.15), adding support to Batch Mode URL: https://github.com/apache/cloudstack/pull/3289#issuecomment-487468445 @blueorangutan test This is an automated

[GitHub] [cloudstack] blueorangutan commented on issue #3289: Update to latest InfluxDB (2.15), adding support to Batch Mode

2019-04-29 Thread GitBox
blueorangutan commented on issue #3289: Update to latest InfluxDB (2.15), adding support to Batch Mode URL: https://github.com/apache/cloudstack/pull/3289#issuecomment-487468580 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] [cloudstack] DaanHoogland commented on issue #3304: server: Fix exception while update domain resource count (#3204)

2019-04-29 Thread GitBox
DaanHoogland commented on issue #3304: server: Fix exception while update domain resource count (#3204) URL: https://github.com/apache/cloudstack/pull/3304#issuecomment-487491405 @ustcweizhou , i redid your PR because it wouldn't fwd-merge.

[cloudstack] branch reimplement3303on4.12 updated (1bb64e5 -> 044429c)

2019-04-29 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch reimplement3303on4.12 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. discard 1bb64e5 server: Fix exception while update domain resource count (#3204) reimplement 3303 on

[GitHub] [cloudstack] webermaximilian92 commented on issue #3301: Add scss to css compiler

2019-04-29 Thread GitBox
webermaximilian92 commented on issue #3301: Add scss to css compiler URL: https://github.com/apache/cloudstack/pull/3301#issuecomment-487510844 Hey Rafael, - sass and scss are preprocessors of css. Similar to ES6 or TypeScript for JavaScript. - SCSS provides us many logical

[GitHub] [cloudstack] svenvogel commented on issue #3282: [WIP DO NOT MERGE] Fix slow vm creation when large sf snapshot count

2019-04-29 Thread GitBox
svenvogel commented on issue #3282: [WIP DO NOT MERGE] Fix slow vm creation when large sf snapshot count URL: https://github.com/apache/cloudstack/pull/3282#issuecomment-487510952 @syed @skattoju3 we test it! its seems faster but now 1 minute. we dont know why but thats long too.

[GitHub] [cloudstack] webermaximilian92 edited a comment on issue #3301: Add scss to css compiler

2019-04-29 Thread GitBox
webermaximilian92 edited a comment on issue #3301: Add scss to css compiler URL: https://github.com/apache/cloudstack/pull/3301#issuecomment-487510844 Hey @rafaelweingartner , - sass and scss are preprocessors of css. Similar to ES6 or TypeScript for JavaScript. - SCSS provides

[GitHub] [cloudstack] blueorangutan commented on issue #3302: server: sync templates on adding new secondary storage

2019-04-29 Thread GitBox
blueorangutan commented on issue #3302: server: sync templates on adding new secondary storage URL: https://github.com/apache/cloudstack/pull/3302#issuecomment-487465724 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] DaanHoogland commented on issue #3302: server: sync templates on adding new secondary storage

2019-04-29 Thread GitBox
DaanHoogland commented on issue #3302: server: sync templates on adding new secondary storage URL: https://github.com/apache/cloudstack/pull/3302#issuecomment-487465558 @blueorangutan package This is an automated message

[GitHub] [cloudstack] fpaillot opened a new issue #3305: SSL SSVM not working when configured to use a URL instead of a domain

2019-04-29 Thread GitBox
fpaillot opened a new issue #3305: SSL SSVM not working when configured to use a URL instead of a domain URL: https://github.com/apache/cloudstack/issues/3305 # ISSUE TYPE * Bug Report # COMPONENT NAME SSVM # CLOUDSTACK VERSION

[GitHub] [cloudstack] onitake commented on issue #3056: Niche feature configuration is always prominent in UI (SSL Offload)

2019-04-29 Thread GitBox
onitake commented on issue #3056: Niche feature configuration is always prominent in UI (SSL Offload) URL: https://github.com/apache/cloudstack/issues/3056#issuecomment-487564233 Wouldn't it be better to support SSL offloading for the built-in load balancer instead? HAProxy can do SSL

[GitHub] [cloudstack] anuragaw commented on issue #3293: Limit selecting of secondary storage with 90% utilization

2019-04-29 Thread GitBox
anuragaw commented on issue #3293: Limit selecting of secondary storage with 90% utilization URL: https://github.com/apache/cloudstack/pull/3293#issuecomment-487614179 Simply returning ```null``` could possibly result in newer bugs? ( On a quick inspection it seems that the method

[GitHub] [cloudstack] anuragaw edited a comment on issue #3293: Limit selecting of secondary storage with 90% utilization

2019-04-29 Thread GitBox
anuragaw edited a comment on issue #3293: Limit selecting of secondary storage with 90% utilization URL: https://github.com/apache/cloudstack/pull/3293#issuecomment-487614179 Simply returning ```null``` could possibly result in newer bugs. ( On a quick inspection it seems that the method

[GitHub] [cloudstack] GabrielBrascher commented on issue #3289: Update to latest InfluxDB (2.15), adding support to Batch Mode

2019-04-29 Thread GitBox
GabrielBrascher commented on issue #3289: Update to latest InfluxDB (2.15), adding support to Batch Mode URL: https://github.com/apache/cloudstack/pull/3289#issuecomment-487668808 This one looks ready for merge. Thanks for the review @rhtyd @wido @rafaelweingartner.

[GitHub] [cloudstack] rhtyd commented on issue #3304: server: Fix exception while update domain resource count (#3204)

2019-04-29 Thread GitBox
rhtyd commented on issue #3304: server: Fix exception while update domain resource count (#3204) URL: https://github.com/apache/cloudstack/pull/3304#issuecomment-487694032 @DaanHoogland @ustcweizhou the build fails due to: ```

[GitHub] [cloudstack] blueorangutan commented on issue #3289: Update to latest InfluxDB (2.15), adding support to Batch Mode

2019-04-29 Thread GitBox
blueorangutan commented on issue #3289: Update to latest InfluxDB (2.15), adding support to Batch Mode URL: https://github.com/apache/cloudstack/pull/3289#issuecomment-487655348 Trillian test result (tid-3540) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7

[cloudstack] branch master updated: server: sync templates on adding new secondary storage (#3302)

2019-04-29 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new 6dad46b server: sync templates on adding

[GitHub] [cloudstack] rhtyd merged pull request #3302: server: sync templates on adding new secondary storage

2019-04-29 Thread GitBox
rhtyd merged pull request #3302: server: sync templates on adding new secondary storage URL: https://github.com/apache/cloudstack/pull/3302 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack] rhtyd closed issue #2689: Existing templates not downloaded when adding new secondary storage

2019-04-29 Thread GitBox
rhtyd closed issue #2689: Existing templates not downloaded when adding new secondary storage URL: https://github.com/apache/cloudstack/issues/2689 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack] rhtyd commented on issue #3304: server: Fix exception while update domain resource count (#3204)

2019-04-29 Thread GitBox
rhtyd commented on issue #3304: server: Fix exception while update domain resource count (#3204) URL: https://github.com/apache/cloudstack/pull/3304#issuecomment-487684434 @DaanHoogland you could have forward merged with this change?

[GitHub] [cloudstack] rhtyd merged pull request #3289: Update to latest InfluxDB (2.15), adding support to Batch Mode

2019-04-29 Thread GitBox
rhtyd merged pull request #3289: Update to latest InfluxDB (2.15), adding support to Batch Mode URL: https://github.com/apache/cloudstack/pull/3289 This is an automated message from the Apache Git Service. To respond to the

[cloudstack] branch master updated: server: use latest InfluxDB (2.15), add support to Batch Mode (#3289)

2019-04-29 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new d6437d5 server: use latest InfluxDB (2.15),

[GitHub] [cloudstack] rhtyd commented on issue #3304: server: Fix exception while update domain resource count (#3204)

2019-04-29 Thread GitBox
rhtyd commented on issue #3304: server: Fix exception while update domain resource count (#3204) URL: https://github.com/apache/cloudstack/pull/3304#issuecomment-487684632 @DaanHoogland can you also check the Travis failure, is this breaking anything?

[GitHub] [cloudstack] blueorangutan commented on issue #3302: server: sync templates on adding new secondary storage

2019-04-29 Thread GitBox
blueorangutan commented on issue #3302: server: sync templates on adding new secondary storage URL: https://github.com/apache/cloudstack/pull/3302#issuecomment-487655932 Trillian test result (tid-3541) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time

[GitHub] [cloudstack] bd2019us commented on a change in pull request #3275: [CLOUDSTACK-10408] Fix String.replaceAll() to replace() for better performance

2019-04-29 Thread GitBox
bd2019us commented on a change in pull request #3275: [CLOUDSTACK-10408] Fix String.replaceAll() to replace() for better performance URL: https://github.com/apache/cloudstack/pull/3275#discussion_r279612124 ## File path:

[GitHub] [cloudstack] anuragaw commented on issue #3297: [WIP DO NOT MERGE] Support copy tags from template/iso image to VM from deploy vm command

2019-04-29 Thread GitBox
anuragaw commented on issue #3297: [WIP DO NOT MERGE] Support copy tags from template/iso image to VM from deploy vm command URL: https://github.com/apache/cloudstack/pull/3297#issuecomment-487824401 @blueorangutan package

[GitHub] [cloudstack] blueorangutan commented on issue #3297: [WIP DO NOT MERGE] Support copy tags from template/iso image to VM from deploy vm command

2019-04-29 Thread GitBox
blueorangutan commented on issue #3297: [WIP DO NOT MERGE] Support copy tags from template/iso image to VM from deploy vm command URL: https://github.com/apache/cloudstack/pull/3297#issuecomment-487827339 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2723

[GitHub] [cloudstack] blueorangutan commented on issue #3297: [WIP DO NOT MERGE] Support copy tags from template/iso image to VM from deploy vm command

2019-04-29 Thread GitBox
blueorangutan commented on issue #3297: [WIP DO NOT MERGE] Support copy tags from template/iso image to VM from deploy vm command URL: https://github.com/apache/cloudstack/pull/3297#issuecomment-487824544 @anuragaw a Jenkins job has been kicked to build packages. I'll keep you posted as I