[GitHub] [cloudstack] jcsdatera commented on issue #3324: [WIP] Add Datera storage plugin

2019-07-08 Thread GitBox
jcsdatera commented on issue #3324: [WIP] Add Datera storage plugin URL: https://github.com/apache/cloudstack/pull/3324#issuecomment-509472040 Ping @rhtyd, @swill Could we reopen this PR as we are still waiting for CloudOps to add functionality on top of this? Thank you

[GitHub] [cloudstack] manojkverma commented on issue #3470: Datera storage plugin

2019-07-08 Thread GitBox
manojkverma commented on issue #3470: Datera storage plugin URL: https://github.com/apache/cloudstack/pull/3470#issuecomment-50939 > Tests LGTM, we don't have datera infra to test the plugin. @swill @manojkverma can you share your code review and test details if any. As @borisstoyanov

[GitHub] [cloudstack] blueorangutan commented on issue #3152: Refactoring to remove duplicate code.

2019-07-08 Thread GitBox
blueorangutan commented on issue #3152: Refactoring to remove duplicate code. URL: https://github.com/apache/cloudstack/pull/3152#issuecomment-509446630 Trillian test result (tid-121) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 28651 seconds

[GitHub] [cloudstack] kioie removed a comment on issue #3292: Allow updatePod API requests to update startIP and endIP

2019-07-08 Thread GitBox
kioie removed a comment on issue #3292: Allow updatePod API requests to update startIP and endIP URL: https://github.com/apache/cloudstack/pull/3292#issuecomment-509296534 @blueorangutan test This is an automated message

[GitHub] [cloudstack] blueorangutan commented on issue #3473: vmware: fix volume stats logic

2019-07-08 Thread GitBox
blueorangutan commented on issue #3473: vmware: fix volume stats logic URL: https://github.com/apache/cloudstack/pull/3473#issuecomment-509288766 Trillian test result (tid-113) Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7 Total time taken: 33304 seconds

[GitHub] [cloudstack] kioie commented on issue #3292: Allow updatePod API requests to update startIP and endIP

2019-07-08 Thread GitBox
kioie commented on issue #3292: Allow updatePod API requests to update startIP and endIP URL: https://github.com/apache/cloudstack/pull/3292#issuecomment-509296534 @blueorangutan test This is an automated message from the

[GitHub] [cloudstack] blueorangutan commented on issue #3152: Refactoring to remove duplicate code.

2019-07-08 Thread GitBox
blueorangutan commented on issue #3152: Refactoring to remove duplicate code. URL: https://github.com/apache/cloudstack/pull/3152#issuecomment-509299535 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] [cloudstack] kioie commented on issue #3292: Allow updatePod API requests to update startIP and endIP

2019-07-08 Thread GitBox
kioie commented on issue #3292: Allow updatePod API requests to update startIP and endIP URL: https://github.com/apache/cloudstack/pull/3292#issuecomment-509283698 @blueorangutan package This is an automated message from the

[GitHub] [cloudstack] blueorangutan commented on issue #3292: Allow updatePod API requests to update startIP and endIP

2019-07-08 Thread GitBox
blueorangutan commented on issue #3292: Allow updatePod API requests to update startIP and endIP URL: https://github.com/apache/cloudstack/pull/3292#issuecomment-509283925 @kioie a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] kiwiflyer commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV

2019-07-08 Thread GitBox
kiwiflyer commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV URL: https://github.com/apache/cloudstack/pull/3319#issuecomment-509286913 Just catching up on this issue. Just so I

[GitHub] [cloudstack] blueorangutan commented on issue #3292: Allow updatePod API requests to update startIP and endIP

2019-07-08 Thread GitBox
blueorangutan commented on issue #3292: Allow updatePod API requests to update startIP and endIP URL: https://github.com/apache/cloudstack/pull/3292#issuecomment-509292723 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-101

[GitHub] [cloudstack] blueorangutan commented on issue #3430: Compare VLAN names instead of expanding to range

2019-07-08 Thread GitBox
blueorangutan commented on issue #3430: Compare VLAN names instead of expanding to range URL: https://github.com/apache/cloudstack/pull/3430#issuecomment-509303316 Trillian test result (tid-114) Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7 Total time taken:

[GitHub] [cloudstack] anuragaw edited a comment on issue #3430: Compare VLAN names instead of expanding to range

2019-07-08 Thread GitBox
anuragaw edited a comment on issue #3430: Compare VLAN names instead of expanding to range URL: https://github.com/apache/cloudstack/pull/3430#issuecomment-509088588 I've tried replicating to run tests locally but they succeed. Looks like runtime issue. @rhtyd , @shwstppr - can one of

[GitHub] [cloudstack] rhtyd commented on issue #3430: Compare VLAN names instead of expanding to range

2019-07-08 Thread GitBox
rhtyd commented on issue #3430: Compare VLAN names instead of expanding to range URL: https://github.com/apache/cloudstack/pull/3430#issuecomment-509099361 @blueorangutan test centos7 vmware-65u2 This is an automated

[GitHub] [cloudstack] anuragaw edited a comment on issue #3457: Fix bug in counting items for search query

2019-07-08 Thread GitBox
anuragaw edited a comment on issue #3457: Fix bug in counting items for search query URL: https://github.com/apache/cloudstack/pull/3457#issuecomment-509099323 I cannot see tests with errors, where do we get those @shwstppr , @rhtyd ? Logs don't mention any tests name but just this -

[GitHub] [cloudstack] blueorangutan commented on issue #3430: Compare VLAN names instead of expanding to range

2019-07-08 Thread GitBox
blueorangutan commented on issue #3430: Compare VLAN names instead of expanding to range URL: https://github.com/apache/cloudstack/pull/3430#issuecomment-509099458 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests

[GitHub] [cloudstack] blueorangutan commented on issue #3374: KVM: Enhancements for direct download feature

2019-07-08 Thread GitBox
blueorangutan commented on issue #3374: KVM: Enhancements for direct download feature URL: https://github.com/apache/cloudstack/pull/3374#issuecomment-509099737 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] [cloudstack] rhtyd commented on issue #3374: KVM: Enhancements for direct download feature

2019-07-08 Thread GitBox
rhtyd commented on issue #3374: KVM: Enhancements for direct download feature URL: https://github.com/apache/cloudstack/pull/3374#issuecomment-509099577 @blueorangutan test This is an automated message from the Apache Git

[GitHub] [cloudstack] rhtyd commented on issue #3457: Fix bug in counting items for search query

2019-07-08 Thread GitBox
rhtyd commented on issue #3457: Fix bug in counting items for search query URL: https://github.com/apache/cloudstack/pull/3457#issuecomment-509101258 This can be merged after some manual testing. @borisstoyanov can you advise? @blueorangutan test centos7 vmware-65u2

[GitHub] [cloudstack] DennisKonrad commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV

2019-07-08 Thread GitBox
DennisKonrad commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV URL: https://github.com/apache/cloudstack/pull/3319#issuecomment-509118961 I tested this PR manually some time ago

[GitHub] [cloudstack] blueorangutan commented on issue #3473: vmware: fix volume stats logic

2019-07-08 Thread GitBox
blueorangutan commented on issue #3473: vmware: fix volume stats logic URL: https://github.com/apache/cloudstack/pull/3473#issuecomment-509094341 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-97 This is an automated

[GitHub] [cloudstack] rhtyd edited a comment on issue #3457: Fix bug in counting items for search query

2019-07-08 Thread GitBox
rhtyd edited a comment on issue #3457: Fix bug in counting items for search query URL: https://github.com/apache/cloudstack/pull/3457#issuecomment-509100624 I get: > python tools/travis/xunit-reader.py ~/Downloads/pr3457-t106-kvm-centos7/MarvinLogs

[GitHub] [cloudstack] rhtyd commented on issue #3457: Fix bug in counting items for search query

2019-07-08 Thread GitBox
rhtyd commented on issue #3457: Fix bug in counting items for search query URL: https://github.com/apache/cloudstack/pull/3457#issuecomment-509100182 @anuragaw I'll need to check why the errors are not being printed in the comment. You can download the marvin logs, then use `python

[GitHub] [cloudstack] blueorangutan commented on issue #3473: vmware: fix volume stats logic

2019-07-08 Thread GitBox
blueorangutan commented on issue #3473: vmware: fix volume stats logic URL: https://github.com/apache/cloudstack/pull/3473#issuecomment-509095355 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests

[GitHub] [cloudstack] rhtyd commented on issue #3473: vmware: fix volume stats logic

2019-07-08 Thread GitBox
rhtyd commented on issue #3473: vmware: fix volume stats logic URL: https://github.com/apache/cloudstack/pull/3473#issuecomment-509095274 @blueorangutan test centos7 vmware-65u2 This is an automated message from the

[GitHub] [cloudstack] rhtyd commented on issue #3393: Fix removing SRX port forwarding rules, improve add/remove logic

2019-07-08 Thread GitBox
rhtyd commented on issue #3393: Fix removing SRX port forwarding rules, improve add/remove logic URL: https://github.com/apache/cloudstack/pull/3393#issuecomment-509095413 @borisstoyanov @anuragaw @shwstppr can you review based on regression test results?

[GitHub] [cloudstack] rhtyd opened a new pull request #3476: [WIP] Smoketests fixes and master stabilisation

2019-07-08 Thread GitBox
rhtyd opened a new pull request #3476: [WIP] Smoketests fixes and master stabilisation URL: https://github.com/apache/cloudstack/pull/3476 The aim of the PR is to stabilise master and fix failing smoketests both on Travis and Trillian. ## Types of changes - [ ] Breaking

[GitHub] [cloudstack] anuragaw commented on issue #3430: Compare VLAN names instead of expanding to range

2019-07-08 Thread GitBox
anuragaw commented on issue #3430: Compare VLAN names instead of expanding to range URL: https://github.com/apache/cloudstack/pull/3430#issuecomment-509097979 @blueorangutan test This is an automated message from the Apache

[GitHub] [cloudstack] anuragaw commented on issue #3457: Fix bug in counting items for search query

2019-07-08 Thread GitBox
anuragaw commented on issue #3457: Fix bug in counting items for search query URL: https://github.com/apache/cloudstack/pull/3457#issuecomment-509099323 I cannot see tests with errors, where do we get those @rhtyd ? Logs don't mention any tests name but just this - ``` Smoke tests

[GitHub] [cloudstack] rhtyd edited a comment on issue #3457: Fix bug in counting items for search query

2019-07-08 Thread GitBox
rhtyd edited a comment on issue #3457: Fix bug in counting items for search query URL: https://github.com/apache/cloudstack/pull/3457#issuecomment-509100624 I get: > python tools/travis/xunit-reader.py ~/Downloads/pr3457-t106-kvm-centos7/MarvinLogs ```

[GitHub] [cloudstack] rhtyd commented on issue #3457: Fix bug in counting items for search query

2019-07-08 Thread GitBox
rhtyd commented on issue #3457: Fix bug in counting items for search query URL: https://github.com/apache/cloudstack/pull/3457#issuecomment-509100624 I get: > python tools/travis/xunit-reader.py ~/Downloads/pr3457-t106-kvm-centos7/MarvinLogs

[GitHub] [cloudstack] rhtyd edited a comment on issue #3457: Fix bug in counting items for search query

2019-07-08 Thread GitBox
rhtyd edited a comment on issue #3457: Fix bug in counting items for search query URL: https://github.com/apache/cloudstack/pull/3457#issuecomment-509100624 I get: > python tools/travis/xunit-reader.py ~/Downloads/pr3457-t106-kvm-centos7/MarvinLogs ```

[GitHub] [cloudstack] anuragaw commented on issue #3457: Fix bug in counting items for search query

2019-07-08 Thread GitBox
anuragaw commented on issue #3457: Fix bug in counting items for search query URL: https://github.com/apache/cloudstack/pull/3457#issuecomment-509101192 Copy @rhtyd , Thanks!! This is an automated message from the Apache Git

[GitHub] [cloudstack] blueorangutan commented on issue #3457: Fix bug in counting items for search query

2019-07-08 Thread GitBox
blueorangutan commented on issue #3457: Fix bug in counting items for search query URL: https://github.com/apache/cloudstack/pull/3457#issuecomment-509101507 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests

[GitHub] [cloudstack] anuragaw commented on issue #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure

2019-07-08 Thread GitBox
anuragaw commented on issue #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure URL: https://github.com/apache/cloudstack/pull/3425#issuecomment-509103687 Refactoring and addressing reviews today. Apologies but I got occupied on other PRs.

[GitHub] [cloudstack] rhtyd commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV

2019-07-08 Thread GitBox
rhtyd commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV URL: https://github.com/apache/cloudstack/pull/3319#issuecomment-509120810 @ustcweizhou you initial shared -1 on this, are

[GitHub] [cloudstack] rhtyd commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV

2019-07-08 Thread GitBox
rhtyd commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV URL: https://github.com/apache/cloudstack/pull/3319#issuecomment-509120407 Thanks for sharing @DennisKonrad Smoketests

[GitHub] [cloudstack] blueorangutan commented on issue #3374: KVM: Enhancements for direct download feature

2019-07-08 Thread GitBox
blueorangutan commented on issue #3374: KVM: Enhancements for direct download feature URL: https://github.com/apache/cloudstack/pull/3374#issuecomment-509264630 Trillian test result (tid-115) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken:

[GitHub] [cloudstack] rhtyd commented on issue #3476: [WIP] Smoketests fixes and master stabilisation

2019-07-08 Thread GitBox
rhtyd commented on issue #3476: [WIP] Smoketests fixes and master stabilisation URL: https://github.com/apache/cloudstack/pull/3476#issuecomment-509156623 List of consistenly failing tests: ``` test_15_project_tag | Failure | 1.160 | test_tags

[cloudstack-documentation] branch 4.11 updated: 4.11: updates to 4.11 for 4.11.3.0 (#49)

2019-07-08 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch 4.11 in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git The following commit(s) were added to refs/heads/4.11 by this push: new e209a3e 4.11: updates to 4.11 for

[cloudstack-documentation] branch master updated: DPDK live migrations (#45)

2019-07-08 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git The following commit(s) were added to refs/heads/master by this push: new 0ff6cf2 DPDK live migrations

[cloudstack-documentation] branch 4.11 updated: add note on firewall for integration.api.port 8096

2019-07-08 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch 4.11 in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git The following commit(s) were added to refs/heads/4.11 by this push: new 7c5c9b4 add note on firewall for

[cloudstack-documentation] tag 4.11.3.0 created (now 7c5c9b4)

2019-07-08 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to tag 4.11.3.0 in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git. at 7c5c9b4 (commit) No new revisions were added by this update.

[cloudstack] branch master updated: plugins: fix removing SRX port forwarding rules, improve add/remove logic (#3393)

2019-07-08 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new d70f574 plugins: fix removing SRX port

[GitHub] [cloudstack] rhtyd commented on issue #3465: vr: Fix vpc router in UNKNOWN state

2019-07-08 Thread GitBox
rhtyd commented on issue #3465: vr: Fix vpc router in UNKNOWN state URL: https://github.com/apache/cloudstack/pull/3465#issuecomment-509167742 @blueorangutan test This is an automated message from the Apache Git

[GitHub] [cloudstack] rhtyd merged pull request #3393: Fix removing SRX port forwarding rules, improve add/remove logic

2019-07-08 Thread GitBox
rhtyd merged pull request #3393: Fix removing SRX port forwarding rules, improve add/remove logic URL: https://github.com/apache/cloudstack/pull/3393 This is an automated message from the Apache Git Service. To respond to

[GitHub] [cloudstack] rhtyd closed issue #3379: SRX Plugin Cannot add Port Forwarding Rule

2019-07-08 Thread GitBox
rhtyd closed issue #3379: SRX Plugin Cannot add Port Forwarding Rule URL: https://github.com/apache/cloudstack/issues/3379 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [cloudstack] blueorangutan commented on issue #3465: vr: Fix vpc router in UNKNOWN state

2019-07-08 Thread GitBox
blueorangutan commented on issue #3465: vr: Fix vpc router in UNKNOWN state URL: https://github.com/apache/cloudstack/pull/3465#issuecomment-509167878 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #3475: Allowing template owner to download template

2019-07-08 Thread GitBox
Spaceman1984 commented on a change in pull request #3475: Allowing template owner to download template URL: https://github.com/apache/cloudstack/pull/3475#discussion_r301022540 ## File path: ui/scripts/templates.js ## @@ -1378,12 +1378,7 @@

[GitHub] [cloudstack] blueorangutan commented on issue #3454: [WIP DO NOT MERGE] Add support for new heuristics based VM Deployement

2019-07-08 Thread GitBox
blueorangutan commented on issue #3454: [WIP DO NOT MERGE] Add support for new heuristics based VM Deployement URL: https://github.com/apache/cloudstack/pull/3454#issuecomment-509169219 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-98

[GitHub] [cloudstack] shwstppr commented on issue #3473: vmware: fix volume stats logic

2019-07-08 Thread GitBox
shwstppr commented on issue #3473: vmware: fix volume stats logic URL: https://github.com/apache/cloudstack/pull/3473#issuecomment-509152256 @rhtyd Still not seeing correct results. With VMware 65u2, I don't think code is taking care of -delta.vmdk. Please see screenshots, From NFS

[GitHub] [cloudstack] rhtyd closed pull request #3378: project id added in test

2019-07-08 Thread GitBox
rhtyd closed pull request #3378: project id added in test URL: https://github.com/apache/cloudstack/pull/3378 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [cloudstack] rhtyd commented on issue #3378: project id added in test

2019-07-08 Thread GitBox
rhtyd commented on issue #3378: project id added in test URL: https://github.com/apache/cloudstack/pull/3378#issuecomment-509155767 I'm taking over the failing smoketests/Travis issues here: https://github.com/apache/cloudstack/pull/3476 Closing on this remark.

[GitHub] [cloudstack] rhtyd edited a comment on issue #3476: [WIP] Smoketests fixes and master stabilisation

2019-07-08 Thread GitBox
rhtyd edited a comment on issue #3476: [WIP] Smoketests fixes and master stabilisation URL: https://github.com/apache/cloudstack/pull/3476#issuecomment-509156623 List of consistenly failing tests: ``` test_15_project_tag | Failure | 1.160 | test_tags

[cloudstack-documentation] branch master updated (3e9a2a5 -> 978db24)

2019-07-08 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git. from 3e9a2a5 Improve Debian repo creation steps (#30) add 978db24 Update kvm.rst (#48) No new

[cloudstack-documentation] branch master updated: Improve Debian repo creation steps (#30)

2019-07-08 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git The following commit(s) were added to refs/heads/master by this push: new 3e9a2a5 Improve Debian repo

[GitHub] [cloudstack] anuragaw commented on issue #3454: [WIP DO NOT MERGE] Add support for new heuristics based VM Deployement

2019-07-08 Thread GitBox
anuragaw commented on issue #3454: [WIP DO NOT MERGE] Add support for new heuristics based VM Deployement URL: https://github.com/apache/cloudstack/pull/3454#issuecomment-509162079 @blueorangutan package This is an automated

[GitHub] [cloudstack] blueorangutan commented on issue #3454: [WIP DO NOT MERGE] Add support for new heuristics based VM Deployement

2019-07-08 Thread GitBox
blueorangutan commented on issue #3454: [WIP DO NOT MERGE] Add support for new heuristics based VM Deployement URL: https://github.com/apache/cloudstack/pull/3454#issuecomment-509162214 @anuragaw a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[cloudstack-documentation] branch master updated (a72075b -> b63dd13)

2019-07-08 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git. from a72075b Suggest using chrony as NTP daemon (#44) add b9f5abd sync QiG with mater branch

[cloudstack-documentation] 01/01: Merge remote-tracking branch 'origin/4.11'

2019-07-08 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git commit b63dd1373a95d69963f65d15fdfca7dc9917ac59 Merge: a72075b 7c5c9b4 Author: Rohit Yadav AuthorDate: Mon

[cloudstack-documentation] branch master updated: Suggest using chrony as NTP daemon (#44)

2019-07-08 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git The following commit(s) were added to refs/heads/master by this push: new a72075b Suggest using chrony

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure

2019-07-08 Thread GitBox
anuragaw commented on a change in pull request #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure URL: https://github.com/apache/cloudstack/pull/3425#discussion_r301014984 ## File path: server/src/main/java/com/cloud/resource/ResourceManagerImpl.java

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure

2019-07-08 Thread GitBox
anuragaw commented on a change in pull request #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure URL: https://github.com/apache/cloudstack/pull/3425#discussion_r301014894 ## File path: server/src/main/java/com/cloud/resource/ResourceManagerImpl.java

[GitHub] [cloudstack] rhtyd commented on issue #3475: Allowing template owner to download template

2019-07-08 Thread GitBox
rhtyd commented on issue #3475: Allowing template owner to download template URL: https://github.com/apache/cloudstack/pull/3475#issuecomment-509169725 @borisstoyanov @shwstppr @anuragaw can you review and test. I've not tested it. Few cases; what happens to template wrt edit, download

[GitHub] [cloudstack] rhtyd commented on issue #3475: Allowing template owner to download template

2019-07-08 Thread GitBox
rhtyd commented on issue #3475: Allowing template owner to download template URL: https://github.com/apache/cloudstack/pull/3475#issuecomment-509169859 Smoketests LGTM. This is an automated message from the Apache Git

[GitHub] [cloudstack] ustcweizhou commented on a change in pull request #3476: [WIP] Smoketests fixes and master stabilisation

2019-07-08 Thread GitBox
ustcweizhou commented on a change in pull request #3476: [WIP] Smoketests fixes and master stabilisation URL: https://github.com/apache/cloudstack/pull/3476#discussion_r301236682 ## File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java ## @@ -640,10

[GitHub] [cloudstack] blueorangutan commented on issue #3457: Fix bug in counting items for search query

2019-07-08 Thread GitBox
blueorangutan commented on issue #3457: Fix bug in counting items for search query URL: https://github.com/apache/cloudstack/pull/3457#issuecomment-509340462 Trillian test result (tid-116) Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7 Total time taken: 40667

[GitHub] [cloudstack] ustcweizhou commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV

2019-07-08 Thread GitBox
ustcweizhou commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV URL: https://github.com/apache/cloudstack/pull/3319#issuecomment-509353969 @rhtyd I am still -1 on this PR.

[GitHub] [cloudstack] ustcweizhou commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV

2019-07-08 Thread GitBox
ustcweizhou commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV URL: https://github.com/apache/cloudstack/pull/3319#issuecomment-509357782 I tested on NFS and Ceph, both are working

[GitHub] [cloudstack] svenvogel commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV

2019-07-08 Thread GitBox
svenvogel commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV URL: https://github.com/apache/cloudstack/pull/3319#issuecomment-509368310 wow many answers. okay lets bring some light

[GitHub] [cloudstack] ustcweizhou commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV

2019-07-08 Thread GitBox
ustcweizhou commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV URL: https://github.com/apache/cloudstack/pull/3319#issuecomment-509371457 Agree with you. Furthermore, I think it

[GitHub] [cloudstack] ustcweizhou edited a comment on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV

2019-07-08 Thread GitBox
ustcweizhou edited a comment on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV URL: https://github.com/apache/cloudstack/pull/3319#issuecomment-509371457 @svenvogel Agree with you.

[GitHub] [cloudstack] skattoju4 commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV

2019-07-08 Thread GitBox
skattoju4 commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV URL: https://github.com/apache/cloudstack/pull/3319#issuecomment-509371574 @kiwiflyer we need ide for the root disk in

[GitHub] [cloudstack] svenvogel commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV

2019-07-08 Thread GitBox
svenvogel commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV URL: https://github.com/apache/cloudstack/pull/3319#issuecomment-509372158 @ustcweizhou > @svenvogel Agree with

[GitHub] [cloudstack] skattoju4 commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV

2019-07-08 Thread GitBox
skattoju4 commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV URL: https://github.com/apache/cloudstack/pull/3319#issuecomment-509373239 @svenvogel yeah @ustcweizhou suggestion is

[GitHub] [cloudstack] svenvogel commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV

2019-07-08 Thread GitBox
svenvogel commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV URL: https://github.com/apache/cloudstack/pull/3319#issuecomment-509374595 @skattoju4 should we change it like the

[GitHub] [cloudstack] ustcweizhou commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV

2019-07-08 Thread GitBox
ustcweizhou commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV URL: https://github.com/apache/cloudstack/pull/3319#issuecomment-509377553 @skattoju4 good, looking forward to your

[GitHub] [cloudstack] svenvogel edited a comment on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV

2019-07-08 Thread GitBox
svenvogel edited a comment on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV URL: https://github.com/apache/cloudstack/pull/3319#issuecomment-509368310 wow many answers. okay lets bring

[GitHub] [cloudstack] svenvogel edited a comment on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV

2019-07-08 Thread GitBox
svenvogel edited a comment on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV URL: https://github.com/apache/cloudstack/pull/3319#issuecomment-509368310 wow many answers. okay lets bring

[GitHub] [cloudstack] svenvogel edited a comment on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV

2019-07-08 Thread GitBox
svenvogel edited a comment on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV URL: https://github.com/apache/cloudstack/pull/3319#issuecomment-509368310 wow many answers. okay lets bring

[GitHub] [cloudstack] svenvogel edited a comment on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV

2019-07-08 Thread GitBox
svenvogel edited a comment on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV URL: https://github.com/apache/cloudstack/pull/3319#issuecomment-509368310 wow many answers. okay lets bring

[GitHub] [cloudstack] ustcweizhou commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV

2019-07-08 Thread GitBox
ustcweizhou commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV URL: https://github.com/apache/cloudstack/pull/3319#issuecomment-509370271 @svenvogel thanks for your reply.

[GitHub] [cloudstack] ustcweizhou commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV

2019-07-08 Thread GitBox
ustcweizhou commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV URL: https://github.com/apache/cloudstack/pull/3319#issuecomment-509372265 > @kiwiflyer we need ide for the root disk

[GitHub] [cloudstack] skattoju4 edited a comment on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV

2019-07-08 Thread GitBox
skattoju4 edited a comment on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV URL: https://github.com/apache/cloudstack/pull/3319#issuecomment-509373239 @svenvogel yeah @ustcweizhou

[GitHub] [cloudstack] skattoju4 commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV

2019-07-08 Thread GitBox
skattoju4 commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV URL: https://github.com/apache/cloudstack/pull/3319#issuecomment-509375040 @svenvogel it sounds logical will test and

[GitHub] [cloudstack] svenvogel commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV

2019-07-08 Thread GitBox
svenvogel commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV URL: https://github.com/apache/cloudstack/pull/3319#issuecomment-509376477 @skattoju4 sound good. thx!

[GitHub] [cloudstack] skattoju4 commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV

2019-07-08 Thread GitBox
skattoju4 commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV URL: https://github.com/apache/cloudstack/pull/3319#issuecomment-509378998 > @svenvogel Agree with you. >

[GitHub] [cloudstack] ustcweizhou commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV

2019-07-08 Thread GitBox
ustcweizhou commented on issue #3319: Use IDE as the bus type for root disks and VIRTIO for data disks when platform emulator strings start with Windows* except Windows PV URL: https://github.com/apache/cloudstack/pull/3319#issuecomment-509395592 > > @svenvogel Agree with you. > >

[GitHub] [cloudstack] rafaelweingartner edited a comment on issue #3294: Set default service offering over api and ui

2019-07-08 Thread GitBox
rafaelweingartner edited a comment on issue #3294: Set default service offering over api and ui URL: https://github.com/apache/cloudstack/pull/3294#issuecomment-509405001 @pbankonier what happens if I changed the value of `ConsoleProxyServiceOffering` configuration? How will the new

[GitHub] [cloudstack] rafaelweingartner commented on issue #3294: Set default service offering over api and ui

2019-07-08 Thread GitBox
rafaelweingartner commented on issue #3294: Set default service offering over api and ui URL: https://github.com/apache/cloudstack/pull/3294#issuecomment-509405001 @pbankonier what happens if I changed the value of `ConsoleProxyServiceOffering` configuration? How will the new service

[GitHub] [cloudstack] rhtyd commented on issue #3377: project tags test fails in all travis runs

2019-07-08 Thread GitBox
rhtyd commented on issue #3377: project tags test fails in all travis runs URL: https://github.com/apache/cloudstack/issues/3377#issuecomment-509178172 Fixed in https://github.com/apache/cloudstack/pull/3476: ``` Marvin Init Successful === TestName: test_15_project_tag |

[GitHub] [cloudstack] rhtyd commented on issue #3402: VPC RVR: Delete first tier with Private GW - Both VRs become MASTER

2019-07-08 Thread GitBox
rhtyd commented on issue #3402: VPC RVR: Delete first tier with Private GW - Both VRs become MASTER URL: https://github.com/apache/cloudstack/issues/3402#issuecomment-509177943 This exists since 4.9, moving to next minor milestone.

[GitHub] [cloudstack] rhtyd closed issue #3377: project tags test fails in all travis runs

2019-07-08 Thread GitBox
rhtyd closed issue #3377: project tags test fails in all travis runs URL: https://github.com/apache/cloudstack/issues/3377 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [cloudstack] anuragaw commented on issue #3332: Switch instance to another compute/service offering

2019-07-08 Thread GitBox
anuragaw commented on issue #3332: Switch instance to another compute/service offering URL: https://github.com/apache/cloudstack/issues/3332#issuecomment-509180781 Starting work on this ticket. This is an automated message

[GitHub] [cloudstack] anuragaw edited a comment on issue #3332: Switch instance to another compute/service offering

2019-07-08 Thread GitBox
anuragaw edited a comment on issue #3332: Switch instance to another compute/service offering URL: https://github.com/apache/cloudstack/issues/3332#issuecomment-509180781 started work on this ticket. This is an automated

[GitHub] [cloudstack] borisstoyanov commented on issue #3440: extract/download marvin tests failing in Trillian

2019-07-08 Thread GitBox
borisstoyanov commented on issue #3440: extract/download marvin tests failing in Trillian URL: https://github.com/apache/cloudstack/issues/3440#issuecomment-509180687 @rhtyd I'll be picking this up today This is an automated

[GitHub] [cloudstack] rhtyd commented on issue #3152: Refactoring to remove duplicate code.

2019-07-08 Thread GitBox
rhtyd commented on issue #3152: Refactoring to remove duplicate code. URL: https://github.com/apache/cloudstack/pull/3152#issuecomment-509188875 @blueorangutan package This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] blueorangutan commented on issue #3152: Refactoring to remove duplicate code.

2019-07-08 Thread GitBox
blueorangutan commented on issue #3152: Refactoring to remove duplicate code. URL: https://github.com/apache/cloudstack/pull/3152#issuecomment-509188905 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[cloudstack] branch master updated: framework/db: Fix bug in counting items for search query (#3457)

2019-07-08 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new c88540d framework/db: Fix bug in counting

[GitHub] [cloudstack] rhtyd commented on issue #3041: Decision making logic of which Secondary storage to be used

2019-07-08 Thread GitBox
rhtyd commented on issue #3041: Decision making logic of which Secondary storage to be used URL: https://github.com/apache/cloudstack/issues/3041#issuecomment-509190083 The selection of secondary storage should be refactored (the method) based on usage and throw exception when no

  1   2   >