DaanHoogland opened a new pull request #4087:
URL: https://github.com/apache/cloudstack/pull/4087
## Description
pass pip8 testsa in travis
## Types of changes
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] New feature
This is an automated email from the ASF dual-hosted git repository.
dahn pushed a commit to branch DaanHoogland-patch-4
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
commit eab0876755edaa81e0b4a16ecfb38b06b83f5682
Author: dahn
AuthorDate: Mon May 18 07:19:07 2020 +
This is an automated email from the ASF dual-hosted git repository.
dahn pushed a change to branch DaanHoogland-patch-4
in repository https://gitbox.apache.org/repos/asf/cloudstack.git.
at eab0876 python format
This branch includes the following new commits:
new eab0876 python
borisstoyanov commented on pull request #3991:
URL: https://github.com/apache/cloudstack/pull/3991#issuecomment-630053960
@DaanHoogland are you happy with latest changes wrt your requested.
This is an automated message from
Jerem28 commented on pull request #3580:
URL: https://github.com/apache/cloudstack/pull/3580#issuecomment-630054845
@demarey Thanks for rebasing ! Great news if it can be included in 4.15 :)
This is an automated message from
borisstoyanov commented on pull request #3991:
URL: https://github.com/apache/cloudstack/pull/3991#issuecomment-630053385
LGTM, I've managed to confirm the fix. I've started 2 api calls to scale a
vm almost at the same time and it scheduled them one after. The usage records
did not ended
ravening commented on a change in pull request #4078:
URL: https://github.com/apache/cloudstack/pull/4078#discussion_r426501969
##
File path: server/src/main/java/com/cloud/server/ManagementServerImpl.java
##
@@ -3237,13 +3245,29 @@ protected void runInContext() {
}
ravening commented on pull request #4077:
URL: https://github.com/apache/cloudstack/pull/4077#issuecomment-630074178
@DaanHoogland @andrijapanicsb yes I will add a global setting so that users
can enable/disable it
This is
ravening commented on pull request #4078:
URL: https://github.com/apache/cloudstack/pull/4078#issuecomment-630071057
> @ravening, I have seen problems with re-downloads of templates and the
main issue was not the URL but the checksum stored. Did you encounter this? I
don't see how the URL
ravening commented on pull request #4076:
URL: https://github.com/apache/cloudstack/pull/4076#issuecomment-630073008
> @ravening the 4.4 sound like a search blocker only for a specific version
or what do you think?
@svenvogel "since=4.4" indicates that its only supported from
rhtyd commented on pull request #4069:
URL: https://github.com/apache/cloudstack/pull/4069#issuecomment-630097966
Hi @weizhouapache - yes the addHost ssh issue is fixed with the changes to
sshd_config
- Thanks I've verified the -F option with qemu-img on Ubuntu 16.04 - you're
right.
wido commented on pull request #4069:
URL: https://github.com/apache/cloudstack/pull/4069#issuecomment-630100013
@rhtyd The snapshot issue also exists under 18.04. Qemu now locks a QCOW2
file and thus can't be snapshotted while the VM is running in order to protect
the QCOW2 file.
DaanHoogland commented on pull request #4087:
URL: https://github.com/apache/cloudstack/pull/4087#issuecomment-630103637
@DennisKonrad it was just one char which was removed for the fix in #4064.
we just didn't pay attention to the travis output enough! (/me part of we for
sure)
rhtyd commented on a change in pull request #4071:
URL: https://github.com/apache/cloudstack/pull/4071#discussion_r426535314
##
File path:
api/src/main/java/org/apache/cloudstack/api/command/admin/acl/ImportRoleCmd.java
##
@@ -0,0 +1,139 @@
+// Licensed to the Apache Software
DaanHoogland commented on pull request #3580:
URL: https://github.com/apache/cloudstack/pull/3580#issuecomment-630106593
@Jerem28 @demarey it is in the milestone, please stand by as several big
jobs might require more rebasing/refacoring for this before release.
DaanHoogland commented on pull request #4078:
URL: https://github.com/apache/cloudstack/pull/4078#issuecomment-630109012
> So when we destroy the SSVM, we clean up the download_url link so that it
will generate a new download_url link when template/volume is downloaded again.
right,
rhtyd commented on pull request #4069:
URL: https://github.com/apache/cloudstack/pull/4069#issuecomment-630110604
@shwstppr ping - can you check and confirm Wido's comment?
This is an automated message from the Apache Git
shwstppr commented on pull request #4069:
URL: https://github.com/apache/cloudstack/pull/4069#issuecomment-630116024
> @rhtyd The snapshot issue also exists under 18.04. Qemu now locks a QCOW2
file and thus can't be snapshotted while the VM is running in order to protect
the QCOW2 file.
DaanHoogland opened a new issue #4088:
URL: https://github.com/apache/cloudstack/issues/4088
When deplying a Virtual Box OVA to vmware and choosing Boot Type `Uefi` and
Boot Mode `LEGACY`, the connection between cloudstack and VSphere is broken and
won't recuperate untill a reboot of
DaanHoogland opened a new pull request #4089:
URL: https://github.com/apache/cloudstack/pull/4089
## Description
guard against UEFI/LEGACY
Do not allow legacy boot mode in UEFI boot type to prevent vsphere corruption
Fixes: #4088
## Types of
blueorangutan commented on pull request #4089:
URL: https://github.com/apache/cloudstack/pull/4089#issuecomment-630168584
Packaging result: ✔centos7 ✔debian. JID-1231
This is an automated message from the Apache Git Service.
DaanHoogland commented on a change in pull request #4053:
URL: https://github.com/apache/cloudstack/pull/4053#discussion_r426669651
##
File path:
server/src/main/java/com/cloud/storage/secondary/SecondaryStorageVmManager.java
##
@@ -31,6 +32,7 @@
public static final int
nvazquez opened a new issue #4090:
URL: https://github.com/apache/cloudstack/issues/4090
Migration of VMs with removed snapshots fail when the DB record of deleted
snapshot is marked as 'removed' (after garbage collection)
# ISSUE TYPE
* Bug Report
# COMPONENT
Pearl1594 commented on a change in pull request #4053:
URL: https://github.com/apache/cloudstack/pull/4053#discussion_r426727506
##
File path:
server/src/main/java/com/cloud/storage/secondary/SecondaryStorageVmManager.java
##
@@ -31,6 +32,7 @@
public static final int
Pearl1594 commented on a change in pull request #4053:
URL: https://github.com/apache/cloudstack/pull/4053#discussion_r426744052
##
File path:
engine/storage/src/main/java/org/apache/cloudstack/storage/datastore/ObjectInDataStoreManagerImpl.java
##
@@ -104,6 +104,14 @@ public
DaanHoogland commented on pull request #3985:
URL: https://github.com/apache/cloudstack/pull/3985#issuecomment-630156390
@pavanaravapalli please review #4088/#4089
This is an automated message from the Apache Git Service.
To
DaanHoogland commented on pull request #4076:
URL: https://github.com/apache/cloudstack/pull/4076#issuecomment-630195800
@ravening are you running a pre-4.4 version?
This is an automated message from the Apache Git Service.
blueorangutan removed a comment on pull request #4053:
URL: https://github.com/apache/cloudstack/pull/4053#issuecomment-623262952
Packaging result: ✔centos7 ✔debian. JID-1207
This is an automated message from the Apache Git
sureshanaparti commented on pull request #3638:
URL: https://github.com/apache/cloudstack/pull/3638#issuecomment-630170300
@pavanaravapalli Can you update the actual UEFI functionality (with boot
mode & type) supported for VMware and KVM, in CloudStack, with this PR changes.
GabrielBrascher commented on pull request #4083:
URL: https://github.com/apache/cloudstack/pull/4083#issuecomment-630170389
@rhtyd just linking the Draft PR
[#343](https://github.com/apache/cloudstack-primate/pull/343) created at the
CloudStack Primate project.
DaanHoogland merged pull request #4087:
URL: https://github.com/apache/cloudstack/pull/4087
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
This is an automated email from the ASF dual-hosted git repository.
dahn pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cloudstack.git
The following commit(s) were added to refs/heads/master by this push:
new 8f3ad0f python format (#4087)
8f3ad0f is
pavanaravapalli commented on a change in pull request #4089:
URL: https://github.com/apache/cloudstack/pull/4089#discussion_r426720512
##
File path:
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
##
@@ -2286,12 +2286,22 @@
ravening commented on pull request #4076:
URL: https://github.com/apache/cloudstack/pull/4076#issuecomment-630258472
> @ravening are you running a pre-4.4 version?
Not anymore. There were few vm's which were created on 4.2 version and when
upgraded to 4.7, listing vm's with multiple
DaanHoogland commented on pull request #3638:
URL: https://github.com/apache/cloudstack/pull/3638#issuecomment-630137286
@pavanaravapalli please review #4088 we need to fix this to be able to
release.
This is an automated
dimsijul commented on a change in pull request #4070:
URL: https://github.com/apache/cloudstack/pull/4070#discussion_r426643349
##
File path: setup/bindir/cloud-set-guest-password.in
##
@@ -26,25 +26,58 @@
# Modify this line to specify the user (default is root)
user=root
pavanaravapalli commented on pull request #3638:
URL: https://github.com/apache/cloudstack/pull/3638#issuecomment-630266133
> @pavanaravapalli Can you update the actual UEFI functionality (with boot
mode & type) supported for VMware and KVM, in CloudStack, with this PR changes.
pavanaravapalli edited a comment on pull request #3638:
URL: https://github.com/apache/cloudstack/pull/3638#issuecomment-630268390
> @pavanaravapalli please review #4088 we need to fix this to be able to
release.
Verified code for #4089 , looks good to me. I have not encountered
pavanaravapalli commented on pull request #3638:
URL: https://github.com/apache/cloudstack/pull/3638#issuecomment-630268390
> @pavanaravapalli please review #4088 we need to fix this to be able to
release.
Verified code, looks good to me.
pavanaravapalli edited a comment on pull request #3638:
URL: https://github.com/apache/cloudstack/pull/3638#issuecomment-630268390
> @pavanaravapalli please review #4088 we need to fix this to be able to
release.
Verified code for #4089 , looks good to me.
40 matches
Mail list logo