[GitHub] DaanHoogland commented on a change in pull request #2848: Vmware offline migration

2018-12-18 Thread GitBox
DaanHoogland commented on a change in pull request #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#discussion_r242493752 ## File path: engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java ## @@ -4720,8

[GitHub] DaanHoogland commented on a change in pull request #2848: Vmware offline migration

2018-11-15 Thread GitBox
DaanHoogland commented on a change in pull request #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#discussion_r233750458 ## File path: api/src/main/java/org/apache/cloudstack/api/command/admin/vm/MigrateVMCmd.java ## @@ -192,4 +187,25

[GitHub] DaanHoogland commented on a change in pull request #2848: Vmware offline migration

2018-11-15 Thread GitBox
DaanHoogland commented on a change in pull request #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#discussion_r233753757 ## File path: engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java ## @@ -1976,92

[GitHub] DaanHoogland commented on a change in pull request #2848: Vmware offline migration

2018-11-15 Thread GitBox
DaanHoogland commented on a change in pull request #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#discussion_r233753180 ## File path: engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java ## @@ -1976,92

[GitHub] DaanHoogland commented on a change in pull request #2848: Vmware offline migration

2018-11-15 Thread GitBox
DaanHoogland commented on a change in pull request #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#discussion_r233752741 ## File path: engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java ## @@ -1976,92

[GitHub] DaanHoogland commented on a change in pull request #2848: Vmware offline migration

2018-11-15 Thread GitBox
DaanHoogland commented on a change in pull request #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#discussion_r233752431 ## File path: engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java ## @@ -1976,92

[GitHub] DaanHoogland commented on a change in pull request #2848: Vmware offline migration

2018-11-15 Thread GitBox
DaanHoogland commented on a change in pull request #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#discussion_r233752197 ## File path: engine/components-api/src/main/java/com/cloud/storage/StorageManager.java ## @@ -106,7 +106,14 @@

[GitHub] DaanHoogland commented on a change in pull request #2848: Vmware offline migration

2018-11-15 Thread GitBox
DaanHoogland commented on a change in pull request #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#discussion_r233751746 ## File path: engine/api/src/main/java/org/apache/cloudstack/engine/subsystem/api/storage/DataMotionStrategy.java

[GitHub] DaanHoogland commented on a change in pull request #2848: Vmware offline migration

2018-11-15 Thread GitBox
DaanHoogland commented on a change in pull request #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#discussion_r233751540 ## File path: engine/api/src/main/java/org/apache/cloudstack/engine/subsystem/api/storage/DataMotionStrategy.java

[GitHub] DaanHoogland commented on a change in pull request #2848: Vmware offline migration

2018-11-15 Thread GitBox
DaanHoogland commented on a change in pull request #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#discussion_r233751137 ## File path: core/src/main/java/com/cloud/agent/api/MigrateVmToPoolCommand.java ## @@ -0,0 +1,70 @@ +// +//

[GitHub] DaanHoogland commented on a change in pull request #2848: Vmware offline migration

2018-11-15 Thread GitBox
DaanHoogland commented on a change in pull request #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#discussion_r233750916 ## File path: api/src/main/java/org/apache/cloudstack/api/command/user/volume/MigrateVolumeCmd.java ## @@ -120,4

[GitHub] DaanHoogland commented on a change in pull request #2848: Vmware offline migration

2018-11-15 Thread GitBox
DaanHoogland commented on a change in pull request #2848: Vmware offline migration URL: https://github.com/apache/cloudstack/pull/2848#discussion_r233750458 ## File path: api/src/main/java/org/apache/cloudstack/api/command/admin/vm/MigrateVMCmd.java ## @@ -192,4 +187,25