[GitHub] [cordova-android] chemerisuk commented on issue #893: feat: add google services support

2020-01-16 Thread GitBox
chemerisuk commented on issue #893: feat: add google services support URL: https://github.com/apache/cordova-android/pull/893#issuecomment-575037190 @erisu IMO current names a bit confusing. There are different google services that do not require this plugin (Maps, Ads etc.). So I suggest

[GitHub] [cordova-android] acpnayak opened a new issue #897: Dark Mode Android

2020-01-16 Thread GitBox
acpnayak opened a new issue #897: Dark Mode Android URL: https://github.com/apache/cordova-android/issues/897 # Bug Report prefers-color-scheme media query seems to exist but it always matches as no-preference no matter what the OS is set. ## Problem prefers-color-scheme

[GitHub] [cordova-android] acpnayak commented on issue #747: Dark Mode Support Android Q

2020-01-16 Thread GitBox
acpnayak commented on issue #747: Dark Mode Support Android Q URL: https://github.com/apache/cordova-android/issues/747#issuecomment-575078970 Is this issue still open? I just tried and experiencing the same behavior. prefers-color-scheme media query always matches as no-preference no

[GitHub] [cordova-windows] buchion commented on issue #374: Cordova Build Android shows error

2020-01-16 Thread GitBox
buchion commented on issue #374: Cordova Build Android shows error URL: https://github.com/apache/cordova-windows/issues/374#issuecomment-575083794 normal windows command prompt This is an automated message from the Apache

[GitHub] [cordova-plugin-camera] NeckbreakerPascal commented on issue #546: iOS13 - Select Video / getPicture

2020-01-16 Thread GitBox
NeckbreakerPascal commented on issue #546: iOS13 - Select Video / getPicture URL: https://github.com/apache/cordova-plugin-camera/issues/546#issuecomment-575086965 There is a solution for both! The slow and the problem with the Select Video. First, select Video can be fixed with

[GitHub] [cordova-plugin-camera] NeckbreakerPascal closed issue #546: iOS13 - Select Video / getPicture

2020-01-16 Thread GitBox
NeckbreakerPascal closed issue #546: iOS13 - Select Video / getPicture URL: https://github.com/apache/cordova-plugin-camera/issues/546 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cordova-plugin-inappbrowser] jtibbles edited a comment on issue #583: iOS - build fails if using "WKWebViewOnly" preference

2020-01-16 Thread GitBox
jtibbles edited a comment on issue #583: iOS - build fails if using "WKWebViewOnly" preference URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/583#issuecomment-575172068 > To conclude this issue, I tested the upload of my app to Apple > > **before** using v3.2.0

[GitHub] [cordova-plugin-inappbrowser] ath0mas commented on issue #583: iOS - build fails if using "WKWebViewOnly" preference

2020-01-16 Thread GitBox
ath0mas commented on issue #583: iOS - build fails if using "WKWebViewOnly" preference URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/583#issuecomment-575157148 To conclude this issue, I tested the upload of my app to Apple **before** using v3.2.0 * I received

[GitHub] [cordova-plugin-file] marensas commented on issue #351: iOS 13 file input does not upload video from library

2020-01-16 Thread GitBox
marensas commented on issue #351: iOS 13 file input does not upload video from library URL: https://github.com/apache/cordova-plugin-file/issues/351#issuecomment-575175903 I granted permissions with `cordova.plugins.diagnostic` plugin:

[GitHub] [cordova-plugin-inappbrowser] breautek commented on issue #583: iOS - build fails if using "WKWebViewOnly" preference

2020-01-16 Thread GitBox
breautek commented on issue #583: iOS - build fails if using "WKWebViewOnly" preference URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/583#issuecomment-575175901 > is this using the official cordova-plugin-inappbrowser, or another branch of it? Did you have to edit any

[GitHub] [cordova-plugin-file] marensas closed issue #351: iOS 13 file input does not upload video from library

2020-01-16 Thread GitBox
marensas closed issue #351: iOS 13 file input does not upload video from library URL: https://github.com/apache/cordova-plugin-file/issues/351 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cordova-plugin-inappbrowser] jtibbles edited a comment on issue #583: iOS - build fails if using "WKWebViewOnly" preference

2020-01-16 Thread GitBox
jtibbles edited a comment on issue #583: iOS - build fails if using "WKWebViewOnly" preference URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/583#issuecomment-575172068 > To conclude this issue, I tested the upload of my app to Apple > > **before** using v3.2.0

[GitHub] [cordova-plugin-inappbrowser] jtibbles commented on issue #584: feat: Add compile-time decision for disabling UIWebView

2020-01-16 Thread GitBox
jtibbles commented on issue #584: feat: Add compile-time decision for disabling UIWebView URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/584#issuecomment-575223637 Thanks @NiklasMerz . Quick question - does the plugin need the platform ios5.1.1 to work or is 5.1.0

[GitHub] [cordova-plugin-inappbrowser] jtibbles commented on issue #583: iOS - build fails if using "WKWebViewOnly" preference

2020-01-16 Thread GitBox
jtibbles commented on issue #583: iOS - build fails if using "WKWebViewOnly" preference URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/583#issuecomment-575172068 > To conclude this issue, I tested the upload of my app to Apple > > **before** using v3.2.0 >

[GitHub] [cordova-plugin-inappbrowser] ath0mas commented on issue #583: iOS - build fails if using "WKWebViewOnly" preference

2020-01-16 Thread GitBox
ath0mas commented on issue #583: iOS - build fails if using "WKWebViewOnly" preference URL: https://github.com/apache/cordova-plugin-inappbrowser/issues/583#issuecomment-575237255 > @ath0mas is this using the official cordova-plugin-inappbrowser, or another branch of it? Did you have to

[GitHub] [cordova-plugin-inappbrowser] NiklasMerz commented on issue #584: feat: Add compile-time decision for disabling UIWebView

2020-01-16 Thread GitBox
NiklasMerz commented on issue #584: feat: Add compile-time decision for disabling UIWebView URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/584#issuecomment-575228744 This should work with 5.1.0 where `WKWebViewOnly` was introduced. But version 5.1.1 is just a patch

[GitHub] [cordova-android] joshchandler commented on issue #441: CB-14089: (android) Add Kotlin support

2020-01-16 Thread GitBox
joshchandler commented on issue #441: CB-14089: (android) Add Kotlin support URL: https://github.com/apache/cordova-android/pull/441#issuecomment-575237898 @erisu No problem! Yea, I had seen the feedback and was planning on addressing them soon. Thanks for picking this up!

[GitHub] [cordova-android] buchion opened a new issue #899: Cordova Build Android shows error

2020-01-16 Thread GitBox
buchion opened a new issue #899: Cordova Build Android shows error URL: https://github.com/apache/cordova-android/issues/899 cordova run android Discovered saved plugin "cordova-plugin-splashscreen". Adding it to the project Failed to restore plugin "cordova-plugin-splashscreen" from

[cordova-docs] 01/01: Fix typerror in plugin search

2020-01-16 Thread niklasmerz
This is an automated email from the ASF dual-hosted git repository. niklasmerz pushed a commit to branch plugin-search in repository https://gitbox.apache.org/repos/asf/cordova-docs.git commit 2e2622fdf70b65bc71020f6103f4723f552ec42b Author: Niklas Merz AuthorDate: Thu Jan 16 19:21:26 2020

[cordova-docs] branch plugin-search created (now 2e2622f)

2020-01-16 Thread niklasmerz
This is an automated email from the ASF dual-hosted git repository. niklasmerz pushed a change to branch plugin-search in repository https://gitbox.apache.org/repos/asf/cordova-docs.git. at 2e2622f Fix typerror in plugin search This branch includes the following new commits: new

[GitHub] [cordova-ios] leogoesger commented on issue #765: Fix error parsing plist_file_entry when adding extension in xcode

2020-01-16 Thread GitBox
leogoesger commented on issue #765: Fix error parsing plist_file_entry when adding extension in xcode URL: https://github.com/apache/cordova-ios/pull/765#issuecomment-575320260 @nikhilkh I corrected the linter error and unit test. Thanks

[GitHub] [cordova-ios] leogoesger commented on issue #764: could not find -Info.plist file, or config.xml file after adding extension, cordova build, with FIX

2020-01-16 Thread GitBox
leogoesger commented on issue #764: could not find -Info.plist file, or config.xml file after adding extension, cordova build, with FIX URL: https://github.com/apache/cordova-ios/issues/764#issuecomment-575320598 https://github.com/apache/cordova-ios/pull/765

[GitHub] [cordova-ios] codecov-io edited a comment on issue #765: Fix error parsing plist_file_entry when adding extension in xcode

2020-01-16 Thread GitBox
codecov-io edited a comment on issue #765: Fix error parsing plist_file_entry when adding extension in xcode URL: https://github.com/apache/cordova-ios/pull/765#issuecomment-575327540 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/765?src=pr=h1) Report > Merging

[GitHub] [cordova-android] raphinesse opened a new pull request #900: refactor: simplify doFindLatestInstalledBuildTools

2020-01-16 Thread GitBox
raphinesse opened a new pull request #900: refactor: simplify doFindLatestInstalledBuildTools URL: https://github.com/apache/cordova-android/pull/900 ### Motivation and Context Just minor code cleanup ### Description - simplify doFindLatestInstalledBuildTools

[GitHub] [cordova-docs] NiklasMerz opened a new pull request #1052: Fix typerror in plugin search

2020-01-16 Thread GitBox
NiklasMerz opened a new pull request #1052: Fix typerror in plugin search URL: https://github.com/apache/cordova-docs/pull/1052 "setClipboardText" was renamed to "copyText" in #1032. This fixes two method calls for a new issue #1047.

[GitHub] [cordova-docs] NiklasMerz commented on issue #1047: Plugin search doesn’t work

2020-01-16 Thread GitBox
NiklasMerz commented on issue #1047: Plugin search doesn’t work URL: https://github.com/apache/cordova-docs/issues/1047#issuecomment-575286956 I fixed the `ZeroClipBoard` errors now. But there is still another problem: I will look into this soon, but it works for me:

[GitHub] [cordova-ios] codecov-io commented on issue #765: Fix error parsing plist_file_entry when adding extension in xcode

2020-01-16 Thread GitBox
codecov-io commented on issue #765: Fix error parsing plist_file_entry when adding extension in xcode URL: https://github.com/apache/cordova-ios/pull/765#issuecomment-575327540 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/765?src=pr=h1) Report > Merging

[GitHub] [cordova-ios] codecov-io edited a comment on issue #765: Fix error parsing plist_file_entry when adding extension in xcode

2020-01-16 Thread GitBox
codecov-io edited a comment on issue #765: Fix error parsing plist_file_entry when adding extension in xcode URL: https://github.com/apache/cordova-ios/pull/765#issuecomment-575327540 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/765?src=pr=h1) Report > Merging

[GitHub] [cordova-ios] erisu commented on a change in pull request #765: Fix error parsing plist_file_entry when adding extension in xcode

2020-01-16 Thread GitBox
erisu commented on a change in pull request #765: Fix error parsing plist_file_entry when adding extension in xcode URL: https://github.com/apache/cordova-ios/pull/765#discussion_r367774806 ## File path: bin/templates/scripts/cordova/lib/projectFile.js ## @@ -40,8 +40,18

[GitHub] [cordova-ios] erisu commented on a change in pull request #765: Fix error parsing plist_file_entry when adding extension in xcode

2020-01-16 Thread GitBox
erisu commented on a change in pull request #765: Fix error parsing plist_file_entry when adding extension in xcode URL: https://github.com/apache/cordova-ios/pull/765#discussion_r367781085 ## File path: bin/templates/scripts/cordova/lib/projectFile.js ## @@ -40,8 +40,18

[GitHub] [cordova-ios] leogoesger commented on a change in pull request #765: Fix error parsing plist_file_entry when adding extension in xcode

2020-01-16 Thread GitBox
leogoesger commented on a change in pull request #765: Fix error parsing plist_file_entry when adding extension in xcode URL: https://github.com/apache/cordova-ios/pull/765#discussion_r367759258 ## File path: bin/templates/scripts/cordova/lib/projectFile.js ## @@ -40,8

[GitHub] [cordova-ios] leogoesger commented on a change in pull request #765: Fix error parsing plist_file_entry when adding extension in xcode

2020-01-16 Thread GitBox
leogoesger commented on a change in pull request #765: Fix error parsing plist_file_entry when adding extension in xcode URL: https://github.com/apache/cordova-ios/pull/765#discussion_r367759258 ## File path: bin/templates/scripts/cordova/lib/projectFile.js ## @@ -40,8

[GitHub] [cordova-plugin-statusbar] Manidos commented on issue #154: Status bar visible after focus into input / StatusBar.hide() not working

2020-01-16 Thread GitBox
Manidos commented on issue #154: Status bar visible after focus into input / StatusBar.hide() not working URL: https://github.com/apache/cordova-plugin-statusbar/issues/154#issuecomment-575459733 **package.json** ``` "dependencies": { "cordova-android": "^8.1.0",

[GitHub] [cordova-ios] erisu commented on a change in pull request #765: Fix error parsing plist_file_entry when adding extension in xcode

2020-01-16 Thread GitBox
erisu commented on a change in pull request #765: Fix error parsing plist_file_entry when adding extension in xcode URL: https://github.com/apache/cordova-ios/pull/765#discussion_r367781085 ## File path: bin/templates/scripts/cordova/lib/projectFile.js ## @@ -40,8 +40,18

[GitHub] [cordova-ios] erisu commented on a change in pull request #765: Fix error parsing plist_file_entry when adding extension in xcode

2020-01-16 Thread GitBox
erisu commented on a change in pull request #765: Fix error parsing plist_file_entry when adding extension in xcode URL: https://github.com/apache/cordova-ios/pull/765#discussion_r36612 ## File path: bin/templates/scripts/cordova/lib/projectFile.js ## @@ -40,8 +40,18

[GitHub] [cordova-ios] erisu commented on a change in pull request #765: Fix error parsing plist_file_entry when adding extension in xcode

2020-01-16 Thread GitBox
erisu commented on a change in pull request #765: Fix error parsing plist_file_entry when adding extension in xcode URL: https://github.com/apache/cordova-ios/pull/765#discussion_r36612 ## File path: bin/templates/scripts/cordova/lib/projectFile.js ## @@ -40,8 +40,18

[GitHub] [cordova-ios] leogoesger commented on a change in pull request #765: Fix error parsing plist_file_entry when adding extension in xcode

2020-01-16 Thread GitBox
leogoesger commented on a change in pull request #765: Fix error parsing plist_file_entry when adding extension in xcode URL: https://github.com/apache/cordova-ios/pull/765#discussion_r367759258 ## File path: bin/templates/scripts/cordova/lib/projectFile.js ## @@ -40,8

[GitHub] [cordova-ios] leogoesger commented on a change in pull request #765: Fix error parsing plist_file_entry when adding extension in xcode

2020-01-16 Thread GitBox
leogoesger commented on a change in pull request #765: Fix error parsing plist_file_entry when adding extension in xcode URL: https://github.com/apache/cordova-ios/pull/765#discussion_r367759258 ## File path: bin/templates/scripts/cordova/lib/projectFile.js ## @@ -40,8

[GitHub] [cordova-android] erisu commented on a change in pull request #900: refactor: simplify doFindLatestInstalledBuildTools

2020-01-16 Thread GitBox
erisu commented on a change in pull request #900: refactor: simplify doFindLatestInstalledBuildTools URL: https://github.com/apache/cordova-android/pull/900#discussion_r367699210 ## File path: framework/cordova.gradle ## @@ -40,40 +40,40 @@ String doGetProjectTarget() {

[GitHub] [cordova-android] erisu commented on a change in pull request #900: refactor: simplify doFindLatestInstalledBuildTools

2020-01-16 Thread GitBox
erisu commented on a change in pull request #900: refactor: simplify doFindLatestInstalledBuildTools URL: https://github.com/apache/cordova-android/pull/900#discussion_r367699413 ## File path: framework/cordova.gradle ## @@ -40,40 +40,40 @@ String doGetProjectTarget() {

[GitHub] [cordova-android] erisu commented on issue #893: feat: add google services support

2020-01-16 Thread GitBox
erisu commented on issue #893: feat: add google services support URL: https://github.com/apache/cordova-android/pull/893#issuecomment-575393111 @chemerisuk https://github.com/apache/cordova-android/pull/898 This is an

[GitHub] [cordova-plugin-inappbrowser] erisu edited a comment on issue #584: feat: Add compile-time decision for disabling UIWebView

2020-01-16 Thread GitBox
erisu edited a comment on issue #584: feat: Add compile-time decision for disabling UIWebView URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/584#issuecomment-575403215 @jtibbles @NiklasMerz I would recommend using Cordova-iOS 5.1.1. In 5.1.0, yes the

[GitHub] [cordova-plugin-inappbrowser] erisu edited a comment on issue #584: feat: Add compile-time decision for disabling UIWebView

2020-01-16 Thread GitBox
erisu edited a comment on issue #584: feat: Add compile-time decision for disabling UIWebView URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/584#issuecomment-575403215 @jtibbles @NiklasMerz I would recommend using Cordova-iOS 5.1.1. In 5.1.0, yes the

[GitHub] [cordova-plugin-inappbrowser] erisu commented on issue #584: feat: Add compile-time decision for disabling UIWebView

2020-01-16 Thread GitBox
erisu commented on issue #584: feat: Add compile-time decision for disabling UIWebView URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/584#issuecomment-575403215 @jtibbles @NiklasMerz I would recommend using Cordova-iOS 5.1.1. In 5.1.0, yes the `WKWebViewOnly` flag

[GitHub] [cordova-plugin-file] fragatak commented on issue #239: Not seeing files that are stored on the Android device

2020-01-16 Thread GitBox
fragatak commented on issue #239: Not seeing files that are stored on the Android device URL: https://github.com/apache/cordova-plugin-file/issues/239#issuecomment-575367825 It looks like the cordova-pluging-android-permissions is doing something the Manifest.xml is not checking for. I

[cordova-android] branch master updated (a951793 -> 09256b7)

2020-01-16 Thread erisu
This is an automated email from the ASF dual-hosted git repository. erisu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cordova-android.git. from a951793 feat: add google services support (#893) add 09256b7 chore: rename gradle plugin google

[GitHub] [cordova-android] erisu merged pull request #898: chore: rename gradle plugin google services preference options

2020-01-16 Thread GitBox
erisu merged pull request #898: chore: rename gradle plugin google services preference options URL: https://github.com/apache/cordova-android/pull/898 This is an automated message from the Apache Git Service. To respond to

[GitHub] [cordova-ios] erisu commented on a change in pull request #765: Fix error parsing plist_file_entry when adding extension in xcode

2020-01-16 Thread GitBox
erisu commented on a change in pull request #765: Fix error parsing plist_file_entry when adding extension in xcode URL: https://github.com/apache/cordova-ios/pull/765#discussion_r367726717 ## File path: bin/templates/scripts/cordova/lib/projectFile.js ## @@ -40,8 +40,18

[GitHub] [cordova-ios] erisu commented on a change in pull request #765: Fix error parsing plist_file_entry when adding extension in xcode

2020-01-16 Thread GitBox
erisu commented on a change in pull request #765: Fix error parsing plist_file_entry when adding extension in xcode URL: https://github.com/apache/cordova-ios/pull/765#discussion_r367712853 ## File path: bin/templates/scripts/cordova/lib/projectFile.js ## @@ -40,8 +40,18

[GitHub] [cordova-ios] erisu commented on a change in pull request #765: Fix error parsing plist_file_entry when adding extension in xcode

2020-01-16 Thread GitBox
erisu commented on a change in pull request #765: Fix error parsing plist_file_entry when adding extension in xcode URL: https://github.com/apache/cordova-ios/pull/765#discussion_r367712122 ## File path: bin/templates/scripts/cordova/lib/projectFile.js ## @@ -40,8 +40,18

[GitHub] [cordova-ios] erisu commented on a change in pull request #765: Fix error parsing plist_file_entry when adding extension in xcode

2020-01-16 Thread GitBox
erisu commented on a change in pull request #765: Fix error parsing plist_file_entry when adding extension in xcode URL: https://github.com/apache/cordova-ios/pull/765#discussion_r367712919 ## File path: bin/templates/scripts/cordova/lib/projectFile.js ## @@ -40,8 +40,18

[GitHub] [cordova-plugin-camera] albertleao commented on issue #546: iOS13 - Select Video / getPicture

2020-01-16 Thread GitBox
albertleao commented on issue #546: iOS13 - Select Video / getPicture URL: https://github.com/apache/cordova-plugin-camera/issues/546#issuecomment-575378977 > There is a solution for both! The slow and the problem with the Select Video. > > First, select Video can be fixed with

[GitHub] [cordova-android] codecov-io edited a comment on issue #896: feat: add kotlin support

2020-01-16 Thread GitBox
codecov-io edited a comment on issue #896: feat: add kotlin support URL: https://github.com/apache/cordova-android/pull/896#issuecomment-574991658 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/896?src=pr=h1) Report > Merging

[GitHub] [cordova-plugin-camera] jfoclpf opened a new issue #548: Plugin crashes when using PHOTOLIBRARY on Android

2020-01-16 Thread GitBox
jfoclpf opened a new issue #548: Plugin crashes when using PHOTOLIBRARY on Android URL: https://github.com/apache/cordova-plugin-camera/issues/548 # Bug Report ## Problem When obtaining some pictures on the phone file system using `PHOTOLIBRARY`, particularly image files

[GitHub] [cordova-android] erisu commented on a change in pull request #900: refactor: simplify doFindLatestInstalledBuildTools

2020-01-16 Thread GitBox
erisu commented on a change in pull request #900: refactor: simplify doFindLatestInstalledBuildTools URL: https://github.com/apache/cordova-android/pull/900#discussion_r367699413 ## File path: framework/cordova.gradle ## @@ -40,40 +40,40 @@ String doGetProjectTarget() {

[GitHub] [cordova-android] erisu commented on a change in pull request #900: refactor: simplify doFindLatestInstalledBuildTools

2020-01-16 Thread GitBox
erisu commented on a change in pull request #900: refactor: simplify doFindLatestInstalledBuildTools URL: https://github.com/apache/cordova-android/pull/900#discussion_r367699413 ## File path: framework/cordova.gradle ## @@ -40,40 +40,40 @@ String doGetProjectTarget() {

[GitHub] [cordova-android] erisu commented on a change in pull request #900: refactor: simplify doFindLatestInstalledBuildTools

2020-01-16 Thread GitBox
erisu commented on a change in pull request #900: refactor: simplify doFindLatestInstalledBuildTools URL: https://github.com/apache/cordova-android/pull/900#discussion_r367699413 ## File path: framework/cordova.gradle ## @@ -40,40 +40,40 @@ String doGetProjectTarget() {

[GitHub] [cordova-android] erisu opened a new pull request #898: chore: rename gradle plugin google services preference options

2020-01-16 Thread GitBox
erisu opened a new pull request #898: chore: rename gradle plugin google services preference options URL: https://github.com/apache/cordova-android/pull/898 ### Motivation and Context Change preference option names for better clarity by including more details. ### Description

[GitHub] [cordova-plugin-camera] guillem-sopra opened a new pull request #547: FIX: [iOS - iPad] App crashes if video transcoding is interrupted

2020-01-16 Thread GitBox
guillem-sopra opened a new pull request #547: FIX: [iOS - iPad] App crashes if video transcoding is interrupted URL: https://github.com/apache/cordova-plugin-camera/pull/547 Closes https://github.com/apache/cordova-plugin-camera/issues/545