[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1946: Refactor Architecture Basic modification #1658

codecov-io edited a comment on issue #1946: Refactor Architecture Basic modification #1658 URL: https://github.com/apache/incubator-dolphinscheduler/pull/1946#issuecomment-585172652 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr=h1) Report >

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue #1946: Refactor Architecture Basic modification #1658

sonarcloud[bot] commented on issue #1946: Refactor Architecture Basic modification #1658 URL: https://github.com/apache/incubator-dolphinscheduler/pull/1946#issuecomment-585664419 SonarCloud Quality Gate failed.

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on issue #1946: Refactor Architecture Basic modification #1658

sonarcloud[bot] removed a comment on issue #1946: Refactor Architecture Basic modification #1658 URL: https://github.com/apache/incubator-dolphinscheduler/pull/1946#issuecomment-585174053 SonarCloud Quality Gate failed.

[GitHub] [incubator-dolphinscheduler] Yeleights closed issue #1812: [QUESTION] init datasource error

Yeleights closed issue #1812: [QUESTION] init datasource error URL: https://github.com/apache/incubator-dolphinscheduler/issues/1812 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-dolphinscheduler] Technoboy- opened a new pull request #1951: add finally block to close channel

Technoboy- opened a new pull request #1951: add finally block to close channel URL: https://github.com/apache/incubator-dolphinscheduler/pull/1951 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-dolphinscheduler] liwenhe1993 closed pull request #1952: Add unit test

liwenhe1993 closed pull request #1952: Add unit test URL: https://github.com/apache/incubator-dolphinscheduler/pull/1952 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1952: Add unit test

codecov-io commented on issue #1952: Add unit test URL: https://github.com/apache/incubator-dolphinscheduler/pull/1952#issuecomment-585767386 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1952?src=pr=h1) Report > Merging

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue #1952: Add unit test

sonarcloud[bot] commented on issue #1952: Add unit test URL: https://github.com/apache/incubator-dolphinscheduler/pull/1952#issuecomment-585769055 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1952=false=BUG)

[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1946: Refactor Architecture Basic modification #1658

codecov-io edited a comment on issue #1946: Refactor Architecture Basic modification #1658 URL: https://github.com/apache/incubator-dolphinscheduler/pull/1946#issuecomment-585172652 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr=h1) Report >

[GitHub] [incubator-dolphinscheduler] qiaozhanwei commented on issue #1946: Refactor Architecture Basic modification #1658

qiaozhanwei commented on issue #1946: Refactor Architecture Basic modification #1658 URL: https://github.com/apache/incubator-dolphinscheduler/pull/1946#issuecomment-585674561 @dailidong @lgcareer @lenboo This is an

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue #1950: Support windows environment/1949

sonarcloud[bot] commented on issue #1950: Support windows environment/1949 URL: https://github.com/apache/incubator-dolphinscheduler/pull/1950#issuecomment-585725453 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1950=false=BUG)

[GitHub] [incubator-dolphinscheduler] dailidong commented on issue #1949: [Feature] Support DS to create user and group in windows environment

dailidong commented on issue #1949: [Feature] Support DS to create user and group in windows environment URL: https://github.com/apache/incubator-dolphinscheduler/issues/1949#issuecomment-585740233 good idea +1

[GitHub] [incubator-dolphinscheduler] liwenhe1993 opened a new pull request #1952: Add unit test

liwenhe1993 opened a new pull request #1952: Add unit test URL: https://github.com/apache/incubator-dolphinscheduler/pull/1952 Add unit test This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1946: Refactor Architecture Basic modification #1658

codecov-io edited a comment on issue #1946: Refactor Architecture Basic modification #1658 URL: https://github.com/apache/incubator-dolphinscheduler/pull/1946#issuecomment-585172652 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr=h1) Report >

[GitHub] [incubator-dolphinscheduler] liwenhe1993 opened a new pull request #1950: Support windows environment/1949

liwenhe1993 opened a new pull request #1950: Support windows environment/1949 URL: https://github.com/apache/incubator-dolphinscheduler/pull/1950 DS can not create user and group when runing DS in windows environment. implement user using `net user` implement group using `net

[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #1951: add finally block to close channel

qiaozhanwei merged pull request #1951: add finally block to close channel URL: https://github.com/apache/incubator-dolphinscheduler/pull/1951 This is an automated message from the Apache Git Service. To respond to the

[incubator-dolphinscheduler] branch refactor-architecture updated: add finally block to close channel (#1951)

This is an automated email from the ASF dual-hosted git repository. journey pushed a commit to branch refactor-architecture in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git The following commit(s) were added to refs/heads/refactor-architecture by this push:

[GitHub] [incubator-dolphinscheduler] liwenhe1993 closed pull request #1950: Support windows environment/1949

liwenhe1993 closed pull request #1950: Support windows environment/1949 URL: https://github.com/apache/incubator-dolphinscheduler/pull/1950 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-dolphinscheduler] liwenhe1993 opened a new pull request #1953: Support DS to create user and group in windows environment

liwenhe1993 opened a new pull request #1953: Support DS to create user and group in windows environment URL: https://github.com/apache/incubator-dolphinscheduler/pull/1953 DS can not create user and group when runing DS in windows environment. 1. implement user using `net user`

[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1946: Refactor Architecture Basic modification #1658

codecov-io edited a comment on issue #1946: Refactor Architecture Basic modification #1658 URL: https://github.com/apache/incubator-dolphinscheduler/pull/1946#issuecomment-585172652 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr=h1) Report >

[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1946: Refactor Architecture Basic modification #1658

codecov-io edited a comment on issue #1946: Refactor Architecture Basic modification #1658 URL: https://github.com/apache/incubator-dolphinscheduler/pull/1946#issuecomment-585172652 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr=h1) Report >

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on issue #1946: Refactor Architecture Basic modification #1658

sonarcloud[bot] removed a comment on issue #1946: Refactor Architecture Basic modification #1658 URL: https://github.com/apache/incubator-dolphinscheduler/pull/1946#issuecomment-585664419 SonarCloud Quality Gate failed.

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue #1951: add finally block to close channel

sonarcloud[bot] commented on issue #1951: add finally block to close channel URL: https://github.com/apache/incubator-dolphinscheduler/pull/1951#issuecomment-585760371 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=1951=false=BUG)

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue #1946: Refactor Architecture Basic modification #1658

sonarcloud[bot] commented on issue #1946: Refactor Architecture Basic modification #1658 URL: https://github.com/apache/incubator-dolphinscheduler/pull/1946#issuecomment-585760456 SonarCloud Quality Gate failed.

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue #1953: Support DS to create user and group in windows environment

sonarcloud[bot] commented on issue #1953: Support DS to create user and group in windows environment URL: https://github.com/apache/incubator-dolphinscheduler/pull/1953#issuecomment-585770346 SonarCloud Quality Gate failed.

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue #1954: Fix socket bug: read before sock connect. Add UT for FourLetterWordMain.

sonarcloud[bot] commented on issue #1954: Fix socket bug: read before sock connect. Add UT for FourLetterWordMain. URL: https://github.com/apache/incubator-dolphinscheduler/pull/1954#issuecomment-586053016 SonarCloud Quality Gate failed.

[GitHub] [incubator-dolphinscheduler] Jave-Chen opened a new pull request #1954: Fix socket bug: read before sock connect. Add UT for FourLetterWordMain.

Jave-Chen opened a new pull request #1954: Fix socket bug: read before sock connect. Add UT for FourLetterWordMain. URL: https://github.com/apache/incubator-dolphinscheduler/pull/1954 ## What is the purpose of the pull request #1889 Fix get wrong zk status with 4 letter command.

[GitHub] [incubator-dolphinscheduler] Jave-Chen commented on issue #1954: Fix socket bug: read before sock connect. Add UT for FourLetterWordMain.

Jave-Chen commented on issue #1954: Fix socket bug: read before sock connect. Add UT for FourLetterWordMain. URL: https://github.com/apache/incubator-dolphinscheduler/pull/1954#issuecomment-586054352 Seems like using `@PrepareForTest({FourLetterWordMain.class, Socket.class})` cause UT

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue #1954: Fix socket bug: read before sock connect. Add UT for FourLetterWordMain.

sonarcloud[bot] commented on issue #1954: Fix socket bug: read before sock connect. Add UT for FourLetterWordMain. URL: https://github.com/apache/incubator-dolphinscheduler/pull/1954#issuecomment-586063330 SonarCloud Quality Gate failed.

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on issue #1954: Fix socket bug: read before sock connect. Add UT for FourLetterWordMain.

sonarcloud[bot] removed a comment on issue #1954: Fix socket bug: read before sock connect. Add UT for FourLetterWordMain. URL: https://github.com/apache/incubator-dolphinscheduler/pull/1954#issuecomment-586062464 SonarCloud Quality Gate failed.

[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1946: Refactor Architecture Basic modification #1658

codecov-io edited a comment on issue #1946: Refactor Architecture Basic modification #1658 URL: https://github.com/apache/incubator-dolphinscheduler/pull/1946#issuecomment-585172652 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1946?src=pr=h1) Report >

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on issue #1910: Adapting partial code(file name start with A) to the sonar cloud rules

sonarcloud[bot] removed a comment on issue #1910: Adapting partial code(file name start with A) to the sonar cloud rules URL: https://github.com/apache/incubator-dolphinscheduler/pull/1910#issuecomment-583745537 SonarCloud Quality Gate failed.

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue #1910: Adapting partial code(file name start with A) to the sonar cloud rules

sonarcloud[bot] commented on issue #1910: Adapting partial code(file name start with A) to the sonar cloud rules URL: https://github.com/apache/incubator-dolphinscheduler/pull/1910#issuecomment-586081751 SonarCloud Quality Gate failed.

[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1954: Fix socket bug: read before sock connect. Add UT for FourLetterWordMain.

codecov-io edited a comment on issue #1954: Fix socket bug: read before sock connect. Add UT for FourLetterWordMain. URL: https://github.com/apache/incubator-dolphinscheduler/pull/1954#issuecomment-586061859 #

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on issue #1954: Fix socket bug: read before sock connect. Add UT for FourLetterWordMain.

sonarcloud[bot] removed a comment on issue #1954: Fix socket bug: read before sock connect. Add UT for FourLetterWordMain. URL: https://github.com/apache/incubator-dolphinscheduler/pull/1954#issuecomment-586053016 SonarCloud Quality Gate failed.

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue #1954: Fix socket bug: read before sock connect. Add UT for FourLetterWordMain.

sonarcloud[bot] commented on issue #1954: Fix socket bug: read before sock connect. Add UT for FourLetterWordMain. URL: https://github.com/apache/incubator-dolphinscheduler/pull/1954#issuecomment-586062464 SonarCloud Quality Gate failed.

[GitHub] [incubator-dolphinscheduler] gabrywu opened a new pull request #1955: [BUG] ProcessUtils.kill blocked #1947

gabrywu opened a new pull request #1955: [BUG] ProcessUtils.kill blocked #1947 URL: https://github.com/apache/incubator-dolphinscheduler/pull/1955 check yarn task when killYarnJob This is an automated message from the Apache

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue #1955: [BUG] ProcessUtils.kill blocked #1947

sonarcloud[bot] commented on issue #1955: [BUG] ProcessUtils.kill blocked #1947 URL: https://github.com/apache/incubator-dolphinscheduler/pull/1955#issuecomment-58602 SonarCloud Quality Gate failed.

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on issue #1955: [BUG] ProcessUtils.kill blocked #1947

sonarcloud[bot] removed a comment on issue #1955: [BUG] ProcessUtils.kill blocked #1947 URL: https://github.com/apache/incubator-dolphinscheduler/pull/1955#issuecomment-586066176 SonarCloud Quality Gate failed.

[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1910: Adapting partial code(file name start with A) to the sonar cloud rules

codecov-io commented on issue #1910: Adapting partial code(file name start with A) to the sonar cloud rules URL: https://github.com/apache/incubator-dolphinscheduler/pull/1910#issuecomment-58608 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1910?src=pr=h1)

[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1954: Fix socket bug: read before sock connect. Add UT for FourLetterWordMain.

codecov-io commented on issue #1954: Fix socket bug: read before sock connect. Add UT for FourLetterWordMain. URL: https://github.com/apache/incubator-dolphinscheduler/pull/1954#issuecomment-586061859 #

[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1955: [BUG] ProcessUtils.kill blocked #1947

codecov-io commented on issue #1955: [BUG] ProcessUtils.kill blocked #1947 URL: https://github.com/apache/incubator-dolphinscheduler/pull/1955#issuecomment-586065294 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1955?src=pr=h1) Report > Merging

[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1955: [BUG] ProcessUtils.kill blocked #1947

codecov-io edited a comment on issue #1955: [BUG] ProcessUtils.kill blocked #1947 URL: https://github.com/apache/incubator-dolphinscheduler/pull/1955#issuecomment-586065294 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1955?src=pr=h1) Report > Merging

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue #1955: [BUG] ProcessUtils.kill blocked #1947

sonarcloud[bot] commented on issue #1955: [BUG] ProcessUtils.kill blocked #1947 URL: https://github.com/apache/incubator-dolphinscheduler/pull/1955#issuecomment-586066176 SonarCloud Quality Gate failed.

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue #156: Dev 20190415

sonarcloud[bot] commented on issue #156: Dev 20190415 URL: https://github.com/apache/incubator-dolphinscheduler/pull/156#issuecomment-586073866 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler=156=false=BUG)

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue #1946: Refactor Architecture Basic modification #1658

sonarcloud[bot] commented on issue #1946: Refactor Architecture Basic modification #1658 URL: https://github.com/apache/incubator-dolphinscheduler/pull/1946#issuecomment-586082122 SonarCloud Quality Gate failed.

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on issue #1946: Refactor Architecture Basic modification #1658

sonarcloud[bot] removed a comment on issue #1946: Refactor Architecture Basic modification #1658 URL: https://github.com/apache/incubator-dolphinscheduler/pull/1946#issuecomment-585760456 SonarCloud Quality Gate failed.

[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue #1955: [BUG] ProcessUtils.kill blocked #1947

codecov-io edited a comment on issue #1955: [BUG] ProcessUtils.kill blocked #1947 URL: https://github.com/apache/incubator-dolphinscheduler/pull/1955#issuecomment-586065294 # [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1955?src=pr=h1) Report > Merging

[GitHub] [incubator-dolphinscheduler] dailidong merged pull request #1954: Fix socket bug: read before sock connect. Add UT for FourLetterWordMain.

dailidong merged pull request #1954: Fix socket bug: read before sock connect. Add UT for FourLetterWordMain. URL: https://github.com/apache/incubator-dolphinscheduler/pull/1954 This is an automated message from the Apache

[incubator-dolphinscheduler] branch dev updated (44b7646 -> cdd53a7)

This is an automated email from the ASF dual-hosted git repository. lidongdai pushed a change to branch dev in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git. from 44b7646 Adapting partial code(file name start with C) to the sonar cloud rules (#1918)

[GitHub] [incubator-dolphinscheduler] kylozw edited a comment on issue #1943: [Feature] Generating locations automatically by task definition and dependency(通过任务定义和依赖自动生成位置信息绘制DAG)

kylozw edited a comment on issue #1943: [Feature] Generating locations automatically by task definition and dependency(通过任务定义和依赖自动生成位置信息绘制DAG) URL: https://github.com/apache/incubator-dolphinscheduler/issues/1943#issuecomment-585518995 I used the version 1.2.1, and it didn't work. BTW, I

[GitHub] [incubator-dolphinscheduler] kylozw edited a comment on issue #1943: [Feature] Generating locations automatically by task definition and dependency(通过任务定义和依赖自动生成位置信息绘制DAG)

kylozw edited a comment on issue #1943: [Feature] Generating locations automatically by task definition and dependency(通过任务定义和依赖自动生成位置信息绘制DAG) URL: https://github.com/apache/incubator-dolphinscheduler/issues/1943#issuecomment-585518995 I used the version 1.2.1, and it didn't work. BTW, I

[GitHub] [incubator-dolphinscheduler] liwenhe1993 opened a new issue #1949: [Feature] Support DS to create user and group in windows environment

liwenhe1993 opened a new issue #1949: [Feature] Support DS to create user and group in windows environment URL: https://github.com/apache/incubator-dolphinscheduler/issues/1949 DS can not create user and group when runing DS in windows environment. I will implement this operation.

[GitHub] [incubator-dolphinscheduler] qiaozhanwei commented on issue #1946: Refactor Architecture Basic modification #1658

qiaozhanwei commented on issue #1946: Refactor Architecture Basic modification #1658 URL: https://github.com/apache/incubator-dolphinscheduler/pull/1946#issuecomment-585618004 remote module already add comment , please review

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue #1948: process null check UT duplicate code

sonarcloud[bot] commented on issue #1948: process null check UT duplicate code URL: https://github.com/apache/incubator-dolphinscheduler/pull/1948#issuecomment-585602370 SonarCloud Quality Gate failed.

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue #1948: process null check UT duplicate code

sonarcloud[bot] commented on issue #1948: process null check UT duplicate code URL: https://github.com/apache/incubator-dolphinscheduler/pull/1948#issuecomment-585609732 Kudos, SonarCloud Quality Gate passed!

[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] removed a comment on issue #1948: process null check UT duplicate code

sonarcloud[bot] removed a comment on issue #1948: process null check UT duplicate code URL: https://github.com/apache/incubator-dolphinscheduler/pull/1948#issuecomment-585602370 SonarCloud Quality Gate failed.