Re: [I] [DSIP-26][Audit log] Audit log improvement design [dolphinscheduler]

2024-04-01 Thread via GitHub
qingwli commented on issue #15423: URL: https://github.com/apache/dolphinscheduler/issues/15423#issuecomment-2030950130 > > Compatibility, Deprecation, and Migration Plan > > > Compatible with current system, aspect all api method, but just create, delete, method will into record

Re: [PR] [DSIP-26][Audit log] Audit log improvement design [dolphinscheduler]

2024-04-01 Thread via GitHub
qingwli commented on code in PR #15554: URL: https://github.com/apache/dolphinscheduler/pull/15554#discussion_r1547058643 ## dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/AuditObjectType.java: ## @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache

Re: [PR] Directly use Quartz replase api to bootstrap a schedule [dolphinscheduler]

2024-04-01 Thread via GitHub
sonarcloud[bot] commented on PR #15781: URL: https://github.com/apache/dolphinscheduler/pull/15781#issuecomment-2031126210 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate

Re: [PR] Directly use Quartz replase api to bootstrap a schedule [dolphinscheduler]

2024-04-01 Thread via GitHub
sonarcloud[bot] commented on PR #15781: URL: https://github.com/apache/dolphinscheduler/pull/15781#issuecomment-2031127148 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate

Re: [PR] [Improvement-15744][parameter] project parameter add update time and update user id [dolphinscheduler]

2024-04-01 Thread via GitHub
sonarcloud[bot] commented on PR #15745: URL: https://github.com/apache/dolphinscheduler/pull/15745#issuecomment-2030922287 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [Improvement-15744][parameter] project parameter add update time and update user id [dolphinscheduler]

2024-04-01 Thread via GitHub
sonarcloud[bot] commented on PR #15745: URL: https://github.com/apache/dolphinscheduler/pull/15745#issuecomment-2030922132 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [I] [Improvement][parameter] When modifying project parameters, it is not possible to identify who modified the relevant person and time [dolphinscheduler]

2024-04-01 Thread via GitHub
SbloodyS closed issue #15744: [Improvement][parameter] When modifying project parameters, it is not possible to identify who modified the relevant person and time URL: https://github.com/apache/dolphinscheduler/issues/15744 -- This is an automated message from the Apache Git Service. To

Re: [PR] [Improvement-15744][parameter] project parameter add update time and update user id [dolphinscheduler]

2024-04-01 Thread via GitHub
SbloodyS merged PR #15745: URL: https://github.com/apache/dolphinscheduler/pull/15745 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [DSIP-26][Audit log] Audit log improvement design [dolphinscheduler]

2024-04-01 Thread via GitHub
qingwli commented on code in PR #15554: URL: https://github.com/apache/dolphinscheduler/pull/15554#discussion_r1547060184 ## dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/audit/operator/Operator.java: ## @@ -15,14 +15,13 @@ * limitations under the

Re: [PR] [DSIP-26][Audit log] Audit log improvement design [dolphinscheduler]

2024-04-01 Thread via GitHub
qingwli commented on code in PR #15554: URL: https://github.com/apache/dolphinscheduler/pull/15554#discussion_r1547068414 ## dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ExecutorServiceImpl.java: ## @@ -293,7 +293,7 @@ private void

Re: [PR] [DSIP-26][Audit log] Audit log improvement design [dolphinscheduler]

2024-04-01 Thread via GitHub
sonarcloud[bot] commented on PR #15554: URL: https://github.com/apache/dolphinscheduler/pull/15554#issuecomment-2031016120 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [DSIP-26][Audit log] Audit log improvement design [dolphinscheduler]

2024-04-01 Thread via GitHub
sonarcloud[bot] commented on PR #15554: URL: https://github.com/apache/dolphinscheduler/pull/15554#issuecomment-2031017326 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [DSIP-26][Audit log] Audit log improvement design [dolphinscheduler]

2024-04-01 Thread via GitHub
qingwli commented on code in PR #15554: URL: https://github.com/apache/dolphinscheduler/pull/15554#discussion_r1547057095 ## dolphinscheduler-dao/src/main/resources/sql/dolphinscheduler_mysql.sql: ## @@ -2008,10 +2008,14 @@ DROP TABLE IF EXISTS `t_ds_audit_log`; CREATE TABLE

Re: [PR] [DSIP-26][Audit log] Audit log improvement design [dolphinscheduler]

2024-04-01 Thread via GitHub
github-advanced-security[bot] commented on code in PR #15554: URL: https://github.com/apache/dolphinscheduler/pull/15554#discussion_r1547095110 ## dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/audit/operator/BaseAuditOperator.java: ## @@ -0,0 +1,225 @@ +/*

(dolphinscheduler-website) branch asf-site updated: Automated deployment: 0980f3b270a1b9fed9d4efe5053c8d1c6c4ad553

2024-04-01 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/dolphinscheduler-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 8ea05e220a Automated

(dolphinscheduler) branch dev updated: [Improvement-15744][parameter] project parameter add update time and update user id (#15745)

2024-04-01 Thread zihaoxiang
This is an automated email from the ASF dual-hosted git repository. zihaoxiang pushed a commit to branch dev in repository https://gitbox.apache.org/repos/asf/dolphinscheduler.git The following commit(s) were added to refs/heads/dev by this push: new 920ac154cb

Re: [I] The spark submitted task runs successfully, but the UI interface icon shows failure, ds version 1.3.4 [dolphinscheduler]

2024-04-01 Thread via GitHub
github-actions[bot] commented on issue #4981: URL: https://github.com/apache/dolphinscheduler/issues/4981#issuecomment-2030838995 This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future. --

Re: [I] [Bug] [API] queryAllProjectList response userName is null [dolphinscheduler]

2024-04-01 Thread via GitHub
github-actions[bot] commented on issue #6766: URL: https://github.com/apache/dolphinscheduler/issues/6766#issuecomment-2030838952 This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity

Re: [I] The spark submitted task runs successfully, but the UI interface icon shows failure, ds version 1.3.4 [dolphinscheduler]

2024-04-01 Thread via GitHub
github-actions[bot] closed issue #4981: The spark submitted task runs successfully, but the UI interface icon shows failure, ds version 1.3.4 URL: https://github.com/apache/dolphinscheduler/issues/4981 -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [DSIP-26][Audit log] Audit log improvement design [dolphinscheduler]

2024-04-01 Thread via GitHub
qingwli commented on code in PR #15554: URL: https://github.com/apache/dolphinscheduler/pull/15554#discussion_r1547059530 ## dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/audit/OperatorLogAspect.java: ## @@ -0,0 +1,65 @@ +/* + * Licensed to the Apache

Re: [PR] [DSIP-26][Audit log] Audit log improvement design [dolphinscheduler]

2024-04-01 Thread via GitHub
sonarcloud[bot] commented on PR #15554: URL: https://github.com/apache/dolphinscheduler/pull/15554#issuecomment-2030969234 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [DSIP-26][Audit log] Audit log improvement design [dolphinscheduler]

2024-04-01 Thread via GitHub
qingwli commented on code in PR #15554: URL: https://github.com/apache/dolphinscheduler/pull/15554#discussion_r1547065411 ## dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/audit/operator/BaseOperator.java: ## @@ -0,0 +1,223 @@ +/* + * Licensed to the Apache

[I] [Improvement][Audit log] Record Api request and response when occur error [dolphinscheduler]

2024-04-01 Thread via GitHub
qingwli opened a new issue, #15788: URL: https://github.com/apache/dolphinscheduler/issues/15788 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement. ###

Re: [PR] [DSIP-26][Audit log] Audit log improvement design [dolphinscheduler]

2024-04-01 Thread via GitHub
sonarcloud[bot] commented on PR #15554: URL: https://github.com/apache/dolphinscheduler/pull/15554#issuecomment-2030970991 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

[I] sql任务报错,sql解析的不对 [dolphinscheduler]

2024-04-01 Thread via GitHub
xiamud opened a new issue, #15787: URL: https://github.com/apache/dolphinscheduler/issues/15787 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues. ### What happened

Re: [I] The sql task reports an error, and the sql parsing is incorrect. [dolphinscheduler]

2024-04-01 Thread via GitHub
github-actions[bot] commented on issue #15787: URL: https://github.com/apache/dolphinscheduler/issues/15787#issuecomment-2029427466 ### Search before asking - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar

Re: [PR] [Improvement] add resource full name check [dolphinscheduler]

2024-04-01 Thread via GitHub
sonarcloud[bot] commented on PR #15786: URL: https://github.com/apache/dolphinscheduler/pull/15786#issuecomment-2029518839 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [Improvement] add resource full name check [dolphinscheduler]

2024-04-01 Thread via GitHub
caishunfeng merged PR #15786: URL: https://github.com/apache/dolphinscheduler/pull/15786 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(dolphinscheduler) branch dev updated: [Improvement] add resource full name check (#15786)

2024-04-01 Thread caishunfeng
This is an automated email from the ASF dual-hosted git repository. caishunfeng pushed a commit to branch dev in repository https://gitbox.apache.org/repos/asf/dolphinscheduler.git The following commit(s) were added to refs/heads/dev by this push: new 8acc697942 [Improvement] add resource

Re: [PR] [Improvement] add resource full name check [dolphinscheduler]

2024-04-01 Thread via GitHub
sonarcloud[bot] commented on PR #15786: URL: https://github.com/apache/dolphinscheduler/pull/15786#issuecomment-2029455718 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [I] [Bug] [workflow] SQL type run as description [dolphinscheduler]

2024-04-01 Thread via GitHub
songwenyong commented on issue #15760: URL: https://github.com/apache/dolphinscheduler/issues/15760#issuecomment-2029497435 The bug occurs in the `DataSourceProcessor.splitAndRemoveComment` method, which calls the Alibaba Druid's `SQLParserUtils.splitAndRemoveComment` method. When

Re: [PR] [Improvement] add resource full name check [dolphinscheduler]

2024-04-01 Thread via GitHub
sonarcloud[bot] commented on PR #15786: URL: https://github.com/apache/dolphinscheduler/pull/15786#issuecomment-2029457394 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] [Improvement] add resource full name check [dolphinscheduler]

2024-04-01 Thread via GitHub
sonarcloud[bot] commented on PR #15786: URL: https://github.com/apache/dolphinscheduler/pull/15786#issuecomment-2029520080 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate