[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #2847: Doris support in memory olap table

2020-02-11 Thread GitBox
kangpinghuang commented on a change in pull request #2847: Doris support in memory olap table URL: https://github.com/apache/incubator-doris/pull/2847#discussion_r377985339 ## File path: gensrc/thrift/AgentService.thrift ## @@ -233,10 +234,17 @@ struct TRecoverTabletReq {

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #2847: Doris support in memory olap table

2020-02-11 Thread GitBox
kangpinghuang commented on a change in pull request #2847: Doris support in memory olap table URL: https://github.com/apache/incubator-doris/pull/2847#discussion_r377983847 ## File path: fe/src/main/java/org/apache/doris/master/ReportHandler.java ## @@ -884,13 +885,14 @@

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #2847: Doris support in memory olap table

2020-02-11 Thread GitBox
kangpinghuang commented on a change in pull request #2847: Doris support in memory olap table URL: https://github.com/apache/incubator-doris/pull/2847#discussion_r377977089 ## File path: be/src/olap/page_cache.h ## @@ -74,7 +74,7 @@ class StoragePageCache { // Given

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #2847: Doris support in memory olap table

2020-02-11 Thread GitBox
kangpinghuang commented on a change in pull request #2847: Doris support in memory olap table URL: https://github.com/apache/incubator-doris/pull/2847#discussion_r377976915 ## File path: be/src/olap/page_cache.cpp ## @@ -42,11 +42,18 @@ bool StoragePageCache::lookup(const

[GitHub] [incubator-doris] morningman closed issue #2878: Download (bzip, boost) libraries is too slow when build

2020-02-11 Thread GitBox
morningman closed issue #2878: Download (bzip, boost) libraries is too slow when build URL: https://github.com/apache/incubator-doris/issues/2878 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-doris] liutang123 commented on issue #2885: [Proposal] Restructure storage type to support complex types expending

2020-02-11 Thread GitBox
liutang123 commented on issue #2885: [Proposal] Restructure storage type to support complex types expending URL: https://github.com/apache/incubator-doris/issues/2885#issuecomment-584996542 cc @Seaven @kangpinghuang @imay @gaodayue

[GitHub] [incubator-doris] lingbin commented on a change in pull request #2884: Add `sync_dir` interface to Env

2020-02-11 Thread GitBox
lingbin commented on a change in pull request #2884: Add `sync_dir` interface to Env URL: https://github.com/apache/incubator-doris/pull/2884#discussion_r378052044 ## File path: be/src/env/env.h ## @@ -139,9 +138,21 @@ class Env { // Delete the named file.

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #2847: Doris support in memory olap table

2020-02-11 Thread GitBox
kangkaisen commented on a change in pull request #2847: Doris support in memory olap table URL: https://github.com/apache/incubator-doris/pull/2847#discussion_r378017399 ## File path: be/src/olap/page_cache.h ## @@ -74,7 +74,7 @@ class StoragePageCache { // Given

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #2847: Doris support in memory olap table

2020-02-11 Thread GitBox
kangkaisen commented on a change in pull request #2847: Doris support in memory olap table URL: https://github.com/apache/incubator-doris/pull/2847#discussion_r378017446 ## File path: fe/src/main/java/org/apache/doris/master/ReportHandler.java ## @@ -884,13 +885,14 @@

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #2847: Doris support in memory olap table

2020-02-11 Thread GitBox
kangkaisen commented on a change in pull request #2847: Doris support in memory olap table URL: https://github.com/apache/incubator-doris/pull/2847#discussion_r378017282 ## File path: be/src/olap/page_cache.cpp ## @@ -42,11 +42,18 @@ bool StoragePageCache::lookup(const

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #2883: add column type check when create bitmap index using create index clause

2020-02-11 Thread GitBox
kangkaisen commented on a change in pull request #2883: add column type check when create bitmap index using create index clause URL: https://github.com/apache/incubator-doris/pull/2883#discussion_r378019553 ## File path: fe/src/main/java/org/apache/doris/analysis/IndexDef.java

[GitHub] [incubator-doris] lingbin merged pull request #2884: Add `sync_dir` interface to Env

2020-02-11 Thread GitBox
lingbin merged pull request #2884: Add `sync_dir` interface to Env URL: https://github.com/apache/incubator-doris/pull/2884 This is an automated message from the Apache Git Service. To respond to the message, please log on

[incubator-doris] branch master updated (5440e19 -> e9ff40f)

2020-02-11 Thread lingbin
This is an automated email from the ASF dual-hosted git repository. lingbin pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 5440e19 Improve the triggering strategy of BE report (#2881) add e9ff40f Add `sync_dir` interface

[GitHub] [incubator-doris] liutang123 opened a new issue #2885: [Proposal] Restructure storage type to support complex types expending

2020-02-11 Thread GitBox
liutang123 opened a new issue #2885: [Proposal] Restructure storage type to support complex types expending URL: https://github.com/apache/incubator-doris/issues/2885 **需求** #2871 的实现需要存储部分支持array,当前数据格式不能很好地拓展为复杂类型,因此需要对存储格式进行重构,方便复杂类型的实现。 **目标**

[GitHub] [incubator-doris] lingbin opened a new pull request #2884: Add `sync_dir` interface to Env

2020-02-11 Thread GitBox
lingbin opened a new pull request #2884: Add `sync_dir` interface to Env URL: https://github.com/apache/incubator-doris/pull/2884 when we need to ensure that **a newly-created file** is fully synchronized back to disk, we should call `fsync()` on the parent directory—that is, the

[GitHub] [incubator-doris] kangpinghuang opened a new issue #2886: add rle v2 encoding for segment v2

2020-02-11 Thread GitBox
kangpinghuang opened a new issue #2886: add rle v2 encoding for segment v2 URL: https://github.com/apache/incubator-doris/issues/2886 Now the default encoding for integer type of segment v2 is bitshuffle, performance test shows that it has some drawbacks, like every time decode the page,

[GitHub] [incubator-doris] wangbo opened a new issue #2887: [Proposal] Support Spark Convert Doris Segment

2020-02-11 Thread GitBox
wangbo opened a new issue #2887: [Proposal] Support Spark Convert Doris Segment URL: https://github.com/apache/incubator-doris/issues/2887 # 目标 将预计算的结果(由上一步Spark预计算的作业完成)转换成Doris Be File的过程由Spark完成,预期降低Doris Be的压力,提升导入性能。 ## 主要流程 * 通过spark作业完成数据的分区与排序 *

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #2847: Doris support in memory olap table

2020-02-11 Thread GitBox
kangkaisen commented on a change in pull request #2847: Doris support in memory olap table URL: https://github.com/apache/incubator-doris/pull/2847#discussion_r378018109 ## File path: gensrc/thrift/AgentService.thrift ## @@ -233,10 +234,17 @@ struct TRecoverTabletReq {

[GitHub] [incubator-doris] yangzhg commented on a change in pull request #2883: add column type check when create bitmap index using create index clause

2020-02-11 Thread GitBox
yangzhg commented on a change in pull request #2883: add column type check when create bitmap index using create index clause URL: https://github.com/apache/incubator-doris/pull/2883#discussion_r378023023 ## File path: fe/src/main/java/org/apache/doris/analysis/IndexDef.java

[GitHub] [incubator-doris] chaoyli commented on a change in pull request #2884: Add `sync_dir` interface to Env

2020-02-11 Thread GitBox
chaoyli commented on a change in pull request #2884: Add `sync_dir` interface to Env URL: https://github.com/apache/incubator-doris/pull/2884#discussion_r378039268 ## File path: be/src/env/env.h ## @@ -139,9 +138,21 @@ class Env { // Delete the named file.

[GitHub] [incubator-doris] wuyunfeng commented on a change in pull request #2865: support escape characte

2020-02-11 Thread GitBox
wuyunfeng commented on a change in pull request #2865: support escape characte URL: https://github.com/apache/incubator-doris/pull/2865#discussion_r378071540 ## File path: be/src/exec/es/es_query_builder.cpp ## @@ -110,8 +110,19 @@ void

[GitHub] [incubator-doris] yangzhg opened a new pull request #2882: Convert UnionStmt class into to SetOperationStmt, add Syntax support to sql_parser

2020-02-11 Thread GitBox
yangzhg opened a new pull request #2882: Convert UnionStmt class into to SetOperationStmt, add Syntax support to sql_parser URL: https://github.com/apache/incubator-doris/pull/2882 #2843 1 add intersect/except syntax support to sql_parser 2 rename UnionStmt to SetOperationStmt

[GitHub] [incubator-doris] kangkaisen merged pull request #2879: fix some typo in bitmap index docs.

2020-02-11 Thread GitBox
kangkaisen merged pull request #2879: fix some typo in bitmap index docs. URL: https://github.com/apache/incubator-doris/pull/2879 This is an automated message from the Apache Git Service. To respond to the message, please

[incubator-doris] branch master updated (1f00148 -> 59dd2a0)

2020-02-11 Thread kangkaisen
This is an automated email from the ASF dual-hosted git repository. kangkaisen pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-doris.git. from 1f00148 Support batch add and drop rollup indexes #2671 (#2781) add 59dd2a0 Fix some typo in

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #2847: Doris support in memory olap table

2020-02-11 Thread GitBox
kangkaisen commented on a change in pull request #2847: Doris support in memory olap table URL: https://github.com/apache/incubator-doris/pull/2847#discussion_r377514349 ## File path: fe/src/main/java/org/apache/doris/alter/SchemaChangeHandler.java ## @@ -1405,6 +1420,88

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #2879: fix some typo in bitmap index docs.

2020-02-11 Thread GitBox
kangkaisen commented on a change in pull request #2879: fix some typo in bitmap index docs. URL: https://github.com/apache/incubator-doris/pull/2879#discussion_r377521067 ## File path: fe/src/main/cup/sql_parser.cup ## @@ -967,6 +967,10 @@ create_stmt ::= {:

[GitHub] [incubator-doris] kangkaisen commented on issue #2879: fix some typo in bitmap index docs.

2020-02-11 Thread GitBox
kangkaisen commented on issue #2879: fix some typo in bitmap index docs. URL: https://github.com/apache/incubator-doris/pull/2879#issuecomment-584583539 > 你好,可以在文档中给出一些使用案例吗?比如在某个场景下,使用bitmap会大幅提高doris的性能。作为一个使用方,目前感觉不知如何介入这个优秀的功能。 倒排索引主要用在多维过滤场景。 这一点 可以加到

[GitHub] [incubator-doris] wutiangan commented on a change in pull request #2883: add column type check when create bitmap index using create index clause

2020-02-11 Thread GitBox
wutiangan commented on a change in pull request #2883: add column type check when create bitmap index using create index clause URL: https://github.com/apache/incubator-doris/pull/2883#discussion_r377629893 ## File path:

[GitHub] [incubator-doris] lingbin merged pull request #2881: Improve the triggering strategy of BE report

2020-02-11 Thread GitBox
lingbin merged pull request #2881: Improve the triggering strategy of BE report URL: https://github.com/apache/incubator-doris/pull/2881 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-doris] morningman commented on a change in pull request #2877: [FIX] fix a bug when using grouping set without all column in a grouping set item

2020-02-11 Thread GitBox
morningman commented on a change in pull request #2877: [FIX] fix a bug when using grouping set without all column in a grouping set item URL: https://github.com/apache/incubator-doris/pull/2877#discussion_r377632292 ## File path:

[GitHub] [incubator-doris] morningman commented on a change in pull request #2877: [FIX] fix a bug when using grouping set without all column in a grouping set item

2020-02-11 Thread GitBox
morningman commented on a change in pull request #2877: [FIX] fix a bug when using grouping set without all column in a grouping set item URL: https://github.com/apache/incubator-doris/pull/2877#discussion_r377634636 ## File path:

[GitHub] [incubator-doris] morningman commented on a change in pull request #2877: [FIX] fix a bug when using grouping set without all column in a grouping set item

2020-02-11 Thread GitBox
morningman commented on a change in pull request #2877: [FIX] fix a bug when using grouping set without all column in a grouping set item URL: https://github.com/apache/incubator-doris/pull/2877#discussion_r377633873 ## File path:

[GitHub] [incubator-doris] morningman commented on a change in pull request #2877: [FIX] fix a bug when using grouping set without all column in a grouping set item

2020-02-11 Thread GitBox
morningman commented on a change in pull request #2877: [FIX] fix a bug when using grouping set without all column in a grouping set item URL: https://github.com/apache/incubator-doris/pull/2877#discussion_r377635413 ## File path: gensrc/thrift/PlanNodes.thrift ## @@

[GitHub] [incubator-doris] morningman commented on a change in pull request #2877: [FIX] fix a bug when using grouping set without all column in a grouping set item

2020-02-11 Thread GitBox
morningman commented on a change in pull request #2877: [FIX] fix a bug when using grouping set without all column in a grouping set item URL: https://github.com/apache/incubator-doris/pull/2877#discussion_r377636196 ## File path: be/src/exec/repeat_node.cpp ## @@ -30,6

[GitHub] [incubator-doris] yangzhg opened a new pull request #2883: add column type check when create bitmap index using create index clause

2020-02-11 Thread GitBox
yangzhg opened a new pull request #2883: add column type check when create bitmap index using create index clause URL: https://github.com/apache/incubator-doris/pull/2883 1. add column AggregateType check when create bitmap index using create index clause 2. support more data type in

[GitHub] [incubator-doris] wutiangan commented on a change in pull request #2883: add column type check when create bitmap index using create index clause

2020-02-11 Thread GitBox
wutiangan commented on a change in pull request #2883: add column type check when create bitmap index using create index clause URL: https://github.com/apache/incubator-doris/pull/2883#discussion_r377632933 ## File path:

[GitHub] [incubator-doris] morningman commented on a change in pull request #2883: add column type check when create bitmap index using create index clause

2020-02-11 Thread GitBox
morningman commented on a change in pull request #2883: add column type check when create bitmap index using create index clause URL: https://github.com/apache/incubator-doris/pull/2883#discussion_r377640999 ## File path: fe/src/main/java/org/apache/doris/alter/Alter.java

[GitHub] [incubator-doris] morningman commented on a change in pull request #2883: add column type check when create bitmap index using create index clause

2020-02-11 Thread GitBox
morningman commented on a change in pull request #2883: add column type check when create bitmap index using create index clause URL: https://github.com/apache/incubator-doris/pull/2883#discussion_r377642101 ## File path: fe/src/main/java/org/apache/doris/alter/Alter.java

[GitHub] [incubator-doris] yangzhg commented on a change in pull request #2883: add column type check when create bitmap index using create index clause

2020-02-11 Thread GitBox
yangzhg commented on a change in pull request #2883: add column type check when create bitmap index using create index clause URL: https://github.com/apache/incubator-doris/pull/2883#discussion_r377679923 ## File path: fe/src/main/java/org/apache/doris/alter/Alter.java ##