[GitHub] [incubator-druid] denever opened a new pull request #8656: Message rejection absolute date

2019-10-16 Thread GitBox
denever opened a new pull request #8656: Message rejection absolute date URL: https://github.com/apache/incubator-druid/pull/8656 ### Description Add an option to druid kafka indexing to select an absolute date time for message rejection. Use case: Migrating from a kafka pull

[GitHub] [incubator-druid] denever closed pull request #8656: Message rejection absolute date

2019-10-16 Thread GitBox
denever closed pull request #8656: Message rejection absolute date URL: https://github.com/apache/incubator-druid/pull/8656 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-druid] denever opened a new pull request #8656: Message rejection absolute date

2019-10-16 Thread GitBox
denever opened a new pull request #8656: Message rejection absolute date URL: https://github.com/apache/incubator-druid/pull/8656 ### Description Add an option to druid kafka indexing to select an absolute date time for message rejection. Use case: Migrating from a kafka pull

[GitHub] [incubator-druid] denever closed pull request #8656: Message rejection absolute date

2019-10-16 Thread GitBox
denever closed pull request #8656: Message rejection absolute date URL: https://github.com/apache/incubator-druid/pull/8656 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-druid] denever commented on issue #8656: Message rejection absolute date

2019-10-16 Thread GitBox
denever commented on issue #8656: Message rejection absolute date URL: https://github.com/apache/incubator-druid/pull/8656#issuecomment-542760791 Travis is blocked, has passed, but here is still pending This is an automated

[GitHub] [incubator-druid] jihoonson commented on issue #8573: Stateful auto compaction

2019-10-16 Thread GitBox
jihoonson commented on issue #8573: Stateful auto compaction URL: https://github.com/apache/incubator-druid/pull/8573#issuecomment-542776910 Thanks for the review @ccaominh and @himanshug! This is an automated message from

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs

2019-10-16 Thread GitBox
jon-wei commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs URL: https://github.com/apache/incubator-druid/pull/8487#discussion_r335718002 ## File path:

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs

2019-10-16 Thread GitBox
jon-wei commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs URL: https://github.com/apache/incubator-druid/pull/8487#discussion_r335718056 ## File path:

[GitHub] [incubator-druid] jihoonson commented on a change in pull request #8656: Message rejection absolute date

2019-10-16 Thread GitBox
jihoonson commented on a change in pull request #8656: Message rejection absolute date URL: https://github.com/apache/incubator-druid/pull/8656#discussion_r335616355 ## File path: docs/development/extensions-core/kafka-ingestion.md ## @@ -206,6 +206,7 @@ For Roaring

[GitHub] [incubator-druid] gianm commented on issue #8685: Allow bootstrap.servers to be provided via a PasswordProvider for Kafka Ingestion

2019-10-16 Thread GitBox
gianm commented on issue #8685: Allow bootstrap.servers to be provided via a PasswordProvider for Kafka Ingestion URL: https://github.com/apache/incubator-druid/issues/8685#issuecomment-542863946 Maybe it'd make sense to allow this for _any_ property?

[GitHub] [incubator-druid] gianm commented on issue #8686: Router management Proxy routing should have a way to route to any node in the cluster

2019-10-16 Thread GitBox
gianm commented on issue #8686: Router management Proxy routing should have a way to route to any node in the cluster URL: https://github.com/apache/incubator-druid/issues/8686#issuecomment-542903041 This sounds like an open proxy and therefore I am scared of it. In the context of

[GitHub] [incubator-druid] gianm edited a comment on issue #8686: Router management Proxy routing should have a way to route to any node in the cluster

2019-10-16 Thread GitBox
gianm edited a comment on issue #8686: Router management Proxy routing should have a way to route to any node in the cluster URL: https://github.com/apache/incubator-druid/issues/8686#issuecomment-542903549 > It might be better for the servers to all self-check themselves, and report the

[GitHub] [incubator-druid] gianm commented on issue #8686: Router management Proxy routing should have a way to route to any node in the cluster

2019-10-16 Thread GitBox
gianm commented on issue #8686: Router management Proxy routing should have a way to route to any node in the cluster URL: https://github.com/apache/incubator-druid/issues/8686#issuecomment-542903549 > It might be better for the servers to all self-check themselves, and report the

[GitHub] [incubator-druid] aditya-r-m commented on issue #8682: implement FiniteFirehoseFactory in InlineFirehose

2019-10-16 Thread GitBox
aditya-r-m commented on issue #8682: implement FiniteFirehoseFactory in InlineFirehose URL: https://github.com/apache/incubator-druid/pull/8682#issuecomment-542927214 @jihoonson implemented the suggested updates. This is an

[GitHub] [incubator-druid] clintropolis commented on issue #7066: Support assign tasks to run on different categories of MiddleManagers

2019-10-16 Thread GitBox
clintropolis commented on issue #7066: Support assign tasks to run on different categories of MiddleManagers URL: https://github.com/apache/incubator-druid/pull/7066#issuecomment-542879965 >@clintropolis It seems didn't work. Oops, I guess you added it to the wrong part of the file

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs

2019-10-16 Thread GitBox
jon-wei commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs URL: https://github.com/apache/incubator-druid/pull/8487#discussion_r335717239 ## File path: docs/querying/sql.md ## @@ -363,6 +366,44 @@ All 'array' references

[GitHub] [incubator-druid] xvrl commented on a change in pull request #6702: Add SelfDiscoveryResource; rename org.apache.druid.discovery.NodeType to NodeRole

2019-10-16 Thread GitBox
xvrl commented on a change in pull request #6702: Add SelfDiscoveryResource; rename org.apache.druid.discovery.NodeType to NodeRole URL: https://github.com/apache/incubator-druid/pull/6702#discussion_r335746585 ## File path: integration-tests/docker/docker-entrypoint.sh ##

[GitHub] [incubator-druid] vogievetsky opened a new issue #8686: Router management Proxy routing should have a way to route to any node in the cluster

2019-10-16 Thread GitBox
vogievetsky opened a new issue #8686: Router management Proxy routing should have a way to route to any node in the cluster URL: https://github.com/apache/incubator-druid/issues/8686 ### Description It would be amazing if the router's management proxy could proxy to any node in the

[GitHub] [incubator-druid] jihoonson commented on issue #8663: Kafka indexing service duplicate entry exception in druid_pendingSegments

2019-10-16 Thread GitBox
jihoonson commented on issue #8663: Kafka indexing service duplicate entry exception in druid_pendingSegments URL: https://github.com/apache/incubator-druid/issues/8663#issuecomment-542881773 Hmm, the entries in `druid_pendingSegments` table are never updated but should be reused if

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs

2019-10-16 Thread GitBox
jon-wei commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs URL: https://github.com/apache/incubator-druid/pull/8487#discussion_r335716107 ## File path: docs/querying/sql.md ## @@ -363,6 +366,44 @@ All 'array' references

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs

2019-10-16 Thread GitBox
jon-wei commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs URL: https://github.com/apache/incubator-druid/pull/8487#discussion_r335718521 ## File path:

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs

2019-10-16 Thread GitBox
jon-wei commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs URL: https://github.com/apache/incubator-druid/pull/8487#discussion_r335718425 ## File path:

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs

2019-10-16 Thread GitBox
jon-wei commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs URL: https://github.com/apache/incubator-druid/pull/8487#discussion_r335718720 ## File path:

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs

2019-10-16 Thread GitBox
jon-wei commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs URL: https://github.com/apache/incubator-druid/pull/8487#discussion_r335718831 ## File path:

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs

2019-10-16 Thread GitBox
jon-wei commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs URL: https://github.com/apache/incubator-druid/pull/8487#discussion_r335718915 ## File path:

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs

2019-10-16 Thread GitBox
jon-wei commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs URL: https://github.com/apache/incubator-druid/pull/8487#discussion_r335718988 ## File path:

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs

2019-10-16 Thread GitBox
jon-wei commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs URL: https://github.com/apache/incubator-druid/pull/8487#discussion_r335718581 ## File path:

[GitHub] [incubator-druid] JulianJaffePinterest opened a new issue #8685: Allow bootstrap.servers to be provided via a PasswordProvider for Kafka Ingestion

2019-10-16 Thread GitBox
JulianJaffePinterest opened a new issue #8685: Allow bootstrap.servers to be provided via a PasswordProvider for Kafka Ingestion URL: https://github.com/apache/incubator-druid/issues/8685 ### Description Currently, the `consumerProperties` map in a KafkaSupervisorIOConfig can use

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs

2019-10-16 Thread GitBox
jon-wei commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs URL: https://github.com/apache/incubator-druid/pull/8487#discussion_r335716427 ## File path: docs/querying/sql.md ## @@ -363,6 +366,44 @@ All 'array' references

[GitHub] [incubator-druid] jon-wei commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs

2019-10-16 Thread GitBox
jon-wei commented on a change in pull request #8487: Add initial SQL support for non-expression sketch postaggs URL: https://github.com/apache/incubator-druid/pull/8487#discussion_r335716800 ## File path: docs/querying/sql.md ## @@ -363,6 +366,44 @@ All 'array' references

[GitHub] [incubator-druid] jon-wei merged pull request #8671: More Kinesis resharding adjustments

2019-10-16 Thread GitBox
jon-wei merged pull request #8671: More Kinesis resharding adjustments URL: https://github.com/apache/incubator-druid/pull/8671 This is an automated message from the Apache Git Service. To respond to the message, please log

[incubator-druid] branch master updated (4046c86 -> 89ce638)

2019-10-16 Thread jonwei
This is an automated email from the ASF dual-hosted git repository. jonwei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git. from 4046c86 Stateful auto compaction (#8573) add 89ce638 More Kinesis resharding adjustments (#8671) No

[GitHub] [incubator-druid] leventov commented on issue #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on issue #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#issuecomment-542562851 @SandishKumarHN can you see these errors yourself

[GitHub] [incubator-druid] leventov commented on issue #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on issue #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#issuecomment-542562434 There are 7 related errors:

[GitHub] [incubator-druid] denever commented on issue #8656: Message rejection absolute date

2019-10-16 Thread GitBox
denever commented on issue #8656: Message rejection absolute date URL: https://github.com/apache/incubator-druid/pull/8656#issuecomment-542636264 > thanks, can you also update the necessary documentation and mention the precedence of `lateMessageRejectionStartDateTime` vs

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8578: parallel broker merges on fork join pool

2019-10-16 Thread GitBox
clintropolis commented on a change in pull request #8578: parallel broker merges on fork join pool URL: https://github.com/apache/incubator-druid/pull/8578#discussion_r335410227 ## File path:

[GitHub] [incubator-druid] clintropolis commented on a change in pull request #8578: parallel broker merges on fork join pool

2019-10-16 Thread GitBox
clintropolis commented on a change in pull request #8578: parallel broker merges on fork join pool URL: https://github.com/apache/incubator-druid/pull/8578#discussion_r335410227 ## File path:

[GitHub] [incubator-druid] wengwh opened a new issue #8684: i develop a lookup extension,read hbase into lookup

2019-10-16 Thread GitBox
wengwh opened a new issue #8684: i develop a lookup extension,read hbase into lookup URL: https://github.com/apache/incubator-druid/issues/8684 i develop a lookup extension,read hbase into lookup, i deploy success,data load success, but i load datasource are fail druid

[GitHub] [incubator-druid] gianm commented on issue #8686: Router management Proxy routing should have a way to route to any node in the cluster

2019-10-16 Thread GitBox
gianm commented on issue #8686: Router management Proxy routing should have a way to route to any node in the cluster URL: https://github.com/apache/incubator-druid/issues/8686#issuecomment-542964407 > Also there is already an open proxy in the sampler (http firehose). I think it's

[GitHub] [incubator-druid] gianm merged pull request #8687: Update tutorial-rollup.md

2019-10-16 Thread GitBox
gianm merged pull request #8687: Update tutorial-rollup.md URL: https://github.com/apache/incubator-druid/pull/8687 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-druid] JulianJaffePinterest commented on issue #8685: Allow bootstrap.servers to be provided via a PasswordProvider for Kafka Ingestion

2019-10-16 Thread GitBox
JulianJaffePinterest commented on issue #8685: Allow bootstrap.servers to be provided via a PasswordProvider for Kafka Ingestion URL: https://github.com/apache/incubator-druid/issues/8685#issuecomment-542942083 I agree that allowing most properties to be specified via a Provider makes

[GitHub] [incubator-druid] jnaous opened a new pull request #8689: Update tutorial-kerberos-hadoop.md

2019-10-16 Thread GitBox
jnaous opened a new pull request #8689: Update tutorial-kerberos-hadoop.md URL: https://github.com/apache/incubator-druid/pull/8689 Fix up what looks like a bad merge. This is an automated message from the Apache Git

[GitHub] [incubator-druid] vogievetsky commented on issue #8686: Router management Proxy routing should have a way to route to any node in the cluster

2019-10-16 Thread GitBox
vogievetsky commented on issue #8686: Router management Proxy routing should have a way to route to any node in the cluster URL: https://github.com/apache/incubator-druid/issues/8686#issuecomment-542959319 The proxy could only forward to Druid nodes themselves so it is not open to

[GitHub] [incubator-druid] jnaous commented on issue #8686: Router management Proxy routing should have a way to route to any node in the cluster

2019-10-16 Thread GitBox
jnaous commented on issue #8686: Router management Proxy routing should have a way to route to any node in the cluster URL: https://github.com/apache/incubator-druid/issues/8686#issuecomment-542970766 Something like that could be implemented by making the request async: when a check

[GitHub] [incubator-druid] fjy closed issue #8673: InlineFirehose does not work with index_parallel ingestion

2019-10-16 Thread GitBox
fjy closed issue #8673: InlineFirehose does not work with index_parallel ingestion URL: https://github.com/apache/incubator-druid/issues/8673 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-druid] fjy merged pull request #8682: implement FiniteFirehoseFactory in InlineFirehose

2019-10-16 Thread GitBox
fjy merged pull request #8682: implement FiniteFirehoseFactory in InlineFirehose URL: https://github.com/apache/incubator-druid/pull/8682 This is an automated message from the Apache Git Service. To respond to the message,

[incubator-druid] branch master updated (9f4e11d -> 75527f0)

2019-10-16 Thread fjy
This is an automated email from the ASF dual-hosted git repository. fjy pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git. from 9f4e11d Update tutorial-rollup.md (#8687) add 75527f0 implement FiniteFirehoseFactory in InlineFirehose

[GitHub] [incubator-druid] jnaous opened a new pull request #8687: Update tutorial-rollup.md

2019-10-16 Thread GitBox
jnaous opened a new pull request #8687: Update tutorial-rollup.md URL: https://github.com/apache/incubator-druid/pull/8687 At this point there hasn't yet been an explanation in the tutorial of what "segments" are This is

[GitHub] [incubator-druid] jihoonson opened a new pull request #8688: Remove commit() method Firehose

2019-10-16 Thread GitBox
jihoonson opened a new pull request #8688: Remove commit() method Firehose URL: https://github.com/apache/incubator-druid/pull/8688 ### Description `commit()` method was used only by the ancient kafka firehose which was removed in https://github.com/apache/incubator-druid/pull/8020.

[incubator-druid] branch master updated (89ce638 -> 9f4e11d)

2019-10-16 Thread gian
This is an automated email from the ASF dual-hosted git repository. gian pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-druid.git. from 89ce638 More Kinesis resharding adjustments (#8671) add 9f4e11d Update tutorial-rollup.md (#8687) No

[GitHub] [incubator-druid] lgtm-com[bot] commented on issue #8688: Remove commit() method Firehose

2019-10-16 Thread GitBox
lgtm-com[bot] commented on issue #8688: Remove commit() method Firehose URL: https://github.com/apache/incubator-druid/pull/8688#issuecomment-542968321 This pull request **fixes 2 alerts** when merging 6038515d62b8271de839f8c5f9c59d8a002382c2 into 89ce6384f57cb13c776cfcc9fc7b97126b834fac

[GitHub] [incubator-druid] vogievetsky commented on issue #8686: Router management Proxy routing should have a way to route to any node in the cluster

2019-10-16 Thread GitBox
vogievetsky commented on issue #8686: Router management Proxy routing should have a way to route to any node in the cluster URL: https://github.com/apache/incubator-druid/issues/8686#issuecomment-542968137 Yeah just to be clear I never pictured it to be a proxy to an arbitrary

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335591115 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335582594 ## File path: core/src/main/java/org/apache/druid/common/config/NullHandling.java ## @@ -50,6 +50,7

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335601766 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335599463 ## File path: processing/src/main/java/org/apache/druid/segment/data/CompressionFactory.java ## @@

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335598648 ## File path: processing/src/main/java/org/apache/druid/query/topn/PooledTopNAlgorithm.java ## @@

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335591855 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335581582 ## File path: benchmarks/src/main/java/org/apache/druid/benchmark/query/ScanBenchmark.java ## @@

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335596027 ## File path: processing/src/main/java/org/apache/druid/query/aggregation/hyperloglog/HyperUniquesSerde.java

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335595130 ## File path: indexing-service/src/test/java/org/apache/druid/indexing/overlord/TaskLifecycleTest.java

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335600321 ## File path: processing/src/test/java/org/apache/druid/query/filter/IntervalDimFilterTest.java ##

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335583876 ## File path: core/src/main/java/org/apache/druid/utils/JvmUtils.java ## @@ -50,11 +50,12 @@ public

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335585792 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335590256 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335583652 ## File path: core/src/main/java/org/apache/druid/java/util/emitter/EmittingLogger.java ## @@ -40,6

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r33559 ## File path: processing/src/test/java/org/apache/druid/query/extraction/MapLookupExtractionFnSerDeTest.java

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335585321 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335600158 ## File path: processing/src/test/java/org/apache/druid/query/filter/InDimFilterSerDesrTest.java ##

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335587140 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335595612 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335590033 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335582995 ## File path: core/src/main/java/org/apache/druid/java/util/common/io/NativeIO.java ## @@ -35,9

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335604366 ## File path: processing/src/test/java/org/apache/druid/segment/SchemalessIndexTest.java ## @@