[GitHub] [druid] mgill25 edited a comment on issue #9343: [Proposal] Pubsub Indexing Service

2020-02-14 Thread GitBox
mgill25 edited a comment on issue #9343: [Proposal] Pubsub Indexing Service URL: https://github.com/apache/druid/issues/9343#issuecomment-586257689 Hi @jihoonson * What semantics is guaranteed by the proposed indexing service? I don't think the exactly-once ingestion is possible.

[GitHub] [druid] mgill25 edited a comment on issue #9343: [Proposal] Pubsub Indexing Service

2020-02-14 Thread GitBox
mgill25 edited a comment on issue #9343: [Proposal] Pubsub Indexing Service URL: https://github.com/apache/druid/issues/9343#issuecomment-586257689 Hi @jihoonson * What semantics is guaranteed by the proposed indexing service? I don't think the exactly-once ingestion is possible.

[GitHub] [druid] mgill25 edited a comment on issue #9343: [Proposal] Pubsub Indexing Service

2020-02-14 Thread GitBox
mgill25 edited a comment on issue #9343: [Proposal] Pubsub Indexing Service URL: https://github.com/apache/druid/issues/9343#issuecomment-586257689 Hi @jihoonson * What semantics is guaranteed by the proposed indexing service? I don't think the exactly-once ingestion is possible.

[GitHub] [druid] himanshug commented on issue #8728: Initial join support

2020-02-14 Thread GitBox
himanshug commented on issue #8728: Initial join support URL: https://github.com/apache/druid/issues/8728#issuecomment-586353610 @gianm This sounds great and thanks for writing https://gist.github.com/gianm/39548daef74f0373b3c87056e3db4627 . While I am reading through everything trying

[GitHub] [druid] mgill25 commented on issue #9343: [Proposal] Pubsub Indexing Service

2020-02-14 Thread GitBox
mgill25 commented on issue #9343: [Proposal] Pubsub Indexing Service URL: https://github.com/apache/druid/issues/9343#issuecomment-586257689 Hi @jihoonson * What semantics is guaranteed by the proposed indexing service? I don't think the exactly-once ingestion is possible. And how

[GitHub] [druid] himanshug commented on issue #9351: Adding CredentialsProvider, deprecating PasswordProvider

2020-02-14 Thread GitBox
himanshug commented on issue #9351: Adding CredentialsProvider, deprecating PasswordProvider URL: https://github.com/apache/druid/issues/9351#issuecomment-58634 > Hmm, should one CredentialsProvider be able to handle multiple secrets? Would you tell me some examples? For

[GitHub] [druid] a2l007 opened a new pull request #9365: Fix compatibility issues with SqlFirehose

2020-02-14 Thread GitBox
a2l007 opened a new pull request #9365: Fix compatibility issues with SqlFirehose URL: https://github.com/apache/druid/pull/9365 Fixes #9359. ### Description `SqlFirehoseFactory` is now fixed to be compatible with the deprecated

[GitHub] [druid] himanshug commented on issue #8989: Overlord can support many autoscalers of different categories

2020-02-14 Thread GitBox
himanshug commented on issue #8989: Overlord can support many autoscalers of different categories URL: https://github.com/apache/druid/pull/8989#issuecomment-586381063 I will try and review #9350 over the weekend or next week.

[GitHub] [druid] himanshug commented on issue #6493: Support for request logging in kafka emitter.

2020-02-14 Thread GitBox
himanshug commented on issue #6493: Support for request logging in kafka emitter. URL: https://github.com/apache/druid/pull/6493#issuecomment-586370967 this looks like very close indeed, @mkuthan there is at least one more person ( @Raboo ) needing this , if you wanna revive this PR , I

[GitHub] [druid] sthetland opened a new pull request #9366: Remove references to Docker Machine

2020-02-14 Thread GitBox
sthetland opened a new pull request #9366: Remove references to Docker Machine URL: https://github.com/apache/druid/pull/9366 Removing a broken link to an obsolete repo. While at it, removing references to Docker Machine, which was obsolete as of Docker v1.12 (avail. 2016). This

[GitHub] [druid] himanshug commented on issue #8992: druid extension for OpenID Connect auth using pac4j lib

2020-02-14 Thread GitBox
himanshug commented on issue #8992: druid extension for OpenID Connect auth using pac4j lib URL: https://github.com/apache/druid/pull/8992#issuecomment-586509109 this has been successfully running in our prod for a while now.

[GitHub] [druid] jihoonson commented on issue #9365: Fix compatibility issues with SqlFirehose

2020-02-14 Thread GitBox
jihoonson commented on issue #9365: Fix compatibility issues with SqlFirehose URL: https://github.com/apache/druid/pull/9365#issuecomment-586484839 Would you fix the TC failure? ![Screen Shot 2020-02-14 at 1 44 13

[GitHub] [druid] ccaominh commented on a change in pull request #6974: sql support for dynamic parameters

2020-02-14 Thread GitBox
ccaominh commented on a change in pull request #6974: sql support for dynamic parameters URL: https://github.com/apache/druid/pull/6974#discussion_r379706535 ## File path: sql/src/main/java/org/apache/druid/sql/calcite/planner/Calcites.java ## @@ -397,4 +402,44 @@ public

[GitHub] [druid] ccaominh commented on a change in pull request #6974: sql support for dynamic parameters

2020-02-14 Thread GitBox
ccaominh commented on a change in pull request #6974: sql support for dynamic parameters URL: https://github.com/apache/druid/pull/6974#discussion_r379704623 ## File path: docs/querying/sql.md ## @@ -607,7 +641,7 @@ Properties connectionProperties = new Properties(); try

[GitHub] [druid] ccaominh commented on a change in pull request #6974: sql support for dynamic parameters

2020-02-14 Thread GitBox
ccaominh commented on a change in pull request #6974: sql support for dynamic parameters URL: https://github.com/apache/druid/pull/6974#discussion_r379705718 ## File path: sql/src/main/java/org/apache/druid/sql/avatica/DruidStatement.java ## @@ -152,27 +162,36 @@ public

[GitHub] [druid] ccaominh commented on a change in pull request #6974: sql support for dynamic parameters

2020-02-14 Thread GitBox
ccaominh commented on a change in pull request #6974: sql support for dynamic parameters URL: https://github.com/apache/druid/pull/6974#discussion_r379704878 ## File path: extensions-core/druid-bloom-filter/src/test/java/org/apache/druid/query/filter/sql/BloomDimFilterSqlTest.java

[GitHub] [druid] ccaominh commented on a change in pull request #6974: sql support for dynamic parameters

2020-02-14 Thread GitBox
ccaominh commented on a change in pull request #6974: sql support for dynamic parameters URL: https://github.com/apache/druid/pull/6974#discussion_r379706863 ## File path: sql/src/main/java/org/apache/druid/sql/http/SqlQuery.java ## @@ -85,13 +110,14 @@ public boolean

[GitHub] [druid] ccaominh commented on a change in pull request #6974: sql support for dynamic parameters

2020-02-14 Thread GitBox
ccaominh commented on a change in pull request #6974: sql support for dynamic parameters URL: https://github.com/apache/druid/pull/6974#discussion_r379706847 ## File path: sql/src/main/java/org/apache/druid/sql/http/SqlParameter.java ## @@ -0,0 +1,126 @@ +/* + * Licensed

[druid-website] branch download-footer-fix created (now b433ace)

2020-02-14 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a change to branch download-footer-fix in repository https://gitbox.apache.org/repos/asf/druid-website.git. at b433ace remove direct download link from footer, cleanup stray incubating references This

[GitHub] [druid] ccaominh commented on a change in pull request #6974: sql support for dynamic parameters

2020-02-14 Thread GitBox
ccaominh commented on a change in pull request #6974: sql support for dynamic parameters URL: https://github.com/apache/druid/pull/6974#discussion_r379707606 ## File path: sql/src/test/java/org/apache/druid/sql/calcite/CalciteParameterQueryTest.java ## @@ -0,0 +1,616 @@

[druid-website-src] 01/01: remove direct download from footer, incubating cleanup

2020-02-14 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a commit to branch download-footer-fix in repository https://gitbox.apache.org/repos/asf/druid-website-src.git commit ccca5bcb3819b94be35f54b0bdfbeb7dbfa37d41 Author: Clint Wylie AuthorDate: Fri Feb 14 17:34:09

[druid-website-src] branch download-footer-fix created (now ccca5bc)

2020-02-14 Thread cwylie
This is an automated email from the ASF dual-hosted git repository. cwylie pushed a change to branch download-footer-fix in repository https://gitbox.apache.org/repos/asf/druid-website-src.git. at ccca5bc remove direct download from footer, incubating cleanup This branch includes the

[GitHub] [druid-website] clintropolis opened a new pull request #71: remove direct download link from footer, cleanup stray incubating references

2020-02-14 Thread GitBox
clintropolis opened a new pull request #71: remove direct download link from footer, cleanup stray incubating references URL: https://github.com/apache/druid-website/pull/71 https://github.com/apache/druid-website-src/pull/108

[GitHub] [druid-website-src] clintropolis opened a new pull request #108: remove direct download from footer, incubating cleanup

2020-02-14 Thread GitBox
clintropolis opened a new pull request #108: remove direct download from footer, incubating cleanup URL: https://github.com/apache/druid-website-src/pull/108 Fixes https://github.com/apache/druid/issues/9264 by removing the link from the footer

[GitHub] [druid] jihoonson closed issue #9359: SQL firehose error

2020-02-14 Thread GitBox
jihoonson closed issue #9359: SQL firehose error URL: https://github.com/apache/druid/issues/9359 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [druid] jihoonson merged pull request #9365: Fix compatibility issues with SqlFirehose

2020-02-14 Thread GitBox
jihoonson merged pull request #9365: Fix compatibility issues with SqlFirehose URL: https://github.com/apache/druid/pull/9365 This is an automated message from the Apache Git Service. To respond to the message, please log on

[druid] branch master updated (2e54755 -> 043abd5)

2020-02-14 Thread jihoonson
This is an automated email from the ASF dual-hosted git repository. jihoonson pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/druid.git. from 2e54755 add docker tutorial, friendlier docker-compose.yml, experimental java 11 dockerfile (#9262) add

[GitHub] [druid] ccaominh commented on a change in pull request #9353: Inject things instead of subclassing everything for parallel task testing

2020-02-14 Thread GitBox
ccaominh commented on a change in pull request #9353: Inject things instead of subclassing everything for parallel task testing URL: https://github.com/apache/druid/pull/9353#discussion_r379695817 ## File path:

[GitHub] [druid] ccaominh commented on a change in pull request #9353: Inject things instead of subclassing everything for parallel task testing

2020-02-14 Thread GitBox
ccaominh commented on a change in pull request #9353: Inject things instead of subclassing everything for parallel task testing URL: https://github.com/apache/druid/pull/9353#discussion_r379695930 ## File path:

[GitHub] [druid] ccaominh commented on a change in pull request #9353: Inject things instead of subclassing everything for parallel task testing

2020-02-14 Thread GitBox
ccaominh commented on a change in pull request #9353: Inject things instead of subclassing everything for parallel task testing URL: https://github.com/apache/druid/pull/9353#discussion_r379703293 ## File path:

[GitHub] [druid] ccaominh commented on a change in pull request #9353: Inject things instead of subclassing everything for parallel task testing

2020-02-14 Thread GitBox
ccaominh commented on a change in pull request #9353: Inject things instead of subclassing everything for parallel task testing URL: https://github.com/apache/druid/pull/9353#discussion_r379702277 ## File path:

[GitHub] [druid] ccaominh commented on a change in pull request #9353: Inject things instead of subclassing everything for parallel task testing

2020-02-14 Thread GitBox
ccaominh commented on a change in pull request #9353: Inject things instead of subclassing everything for parallel task testing URL: https://github.com/apache/druid/pull/9353#discussion_r379702969 ## File path:

[GitHub] [druid] mrsrinivas commented on issue #9163: Improved the readability and fixed few java warnings

2020-02-14 Thread GitBox
mrsrinivas commented on issue #9163: Improved the readability and fixed few java warnings URL: https://github.com/apache/druid/pull/9163#issuecomment-586563485 @gianm thank you for the review. I fixed it. This is an

[GitHub] [druid] clintropolis opened a new pull request #9363: fix druid-sql Expressions.toQueryGranularity to be more correct

2020-02-14 Thread GitBox
clintropolis opened a new pull request #9363: fix druid-sql Expressions.toQueryGranularity to be more correct URL: https://github.com/apache/druid/pull/9363 Also improves javadocs of `Expr.getIdentifierIfIdentifier` and `Expr.getBindingIfIdentifier`. This isn't an actual bug because the

[GitHub] [druid] BigRantLing opened a new issue #9364: DirectDruidClient openConnections may be samller than the real connctions between the servers

2020-02-14 Thread GitBox
BigRantLing opened a new issue #9364: DirectDruidClient openConnections may be samller than the real connctions between the servers URL: https://github.com/apache/druid/issues/9364 Hi guys, Our Druid version is 0.9.2. When I was going to make some changs to code of DirectDruidClient

[GitHub] [druid] Raboo commented on issue #6493: Support for request logging in kafka emitter.

2020-02-14 Thread GitBox
Raboo commented on issue #6493: Support for request logging in kafka emitter. URL: https://github.com/apache/druid/pull/6493#issuecomment-586205200 This is sad that this pr never was merged. It would be awesome if someone would pick this up. I can contribute with lots of emojis if that

[GitHub] [druid] stale[bot] closed pull request #8893: Break up docker environment config file

2020-02-14 Thread GitBox
stale[bot] closed pull request #8893: Break up docker environment config file URL: https://github.com/apache/druid/pull/8893 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [druid] stale[bot] commented on issue #8893: Break up docker environment config file

2020-02-14 Thread GitBox
stale[bot] commented on issue #8893: Break up docker environment config file URL: https://github.com/apache/druid/pull/8893#issuecomment-586206540 This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can