[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335598648 ## File path: processing/src/main/java/org/apache/druid/query/topn/PooledTopNAlgorithm.java ## @@

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335591855 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335581582 ## File path: benchmarks/src/main/java/org/apache/druid/benchmark/query/ScanBenchmark.java ## @@

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335596027 ## File path: processing/src/main/java/org/apache/druid/query/aggregation/hyperloglog/HyperUniquesSerde.java

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335583876 ## File path: core/src/main/java/org/apache/druid/utils/JvmUtils.java ## @@ -50,11 +50,12 @@ public

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335585792 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335590256 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r33559 ## File path: processing/src/test/java/org/apache/druid/query/extraction/MapLookupExtractionFnSerDeTest.java

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335585321 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335587140 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335595612 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335591115 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335582594 ## File path: core/src/main/java/org/apache/druid/common/config/NullHandling.java ## @@ -50,6 +50,7

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335601766 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335599463 ## File path: processing/src/main/java/org/apache/druid/segment/data/CompressionFactory.java ## @@

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335595130 ## File path: indexing-service/src/test/java/org/apache/druid/indexing/overlord/TaskLifecycleTest.java

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335600321 ## File path: processing/src/test/java/org/apache/druid/query/filter/IntervalDimFilterTest.java ##

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335583652 ## File path: core/src/main/java/org/apache/druid/java/util/emitter/EmittingLogger.java ## @@ -40,6

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335600158 ## File path: processing/src/test/java/org/apache/druid/query/filter/InDimFilterSerDesrTest.java ##

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335590033 ## File path:

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335582995 ## File path: core/src/main/java/org/apache/druid/java/util/common/io/NativeIO.java ## @@ -35,9

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-10-16 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r335604366 ## File path: processing/src/test/java/org/apache/druid/segment/SchemalessIndexTest.java ## @@

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-09-26 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r328694201 ## File path: benchmarks/src/main/java/org/apache/druid/benchmark/FloatCompressionBenchmarkFileGenerator.java

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-09-26 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r328694779 ## File path: benchmarks/src/main/java/org/apache/druid/benchmark/LongCompressionBenchmarkFileGenerator.java

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-09-26 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r328696122 ## File path: core/src/main/java/org/apache/druid/common/config/NullHandling.java ## @@ -29,6 +29,7

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-09-26 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r328694407 ## File path: benchmarks/src/main/java/org/apache/druid/benchmark/IncrementalIndexRowTypeBenchmark.java

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-09-26 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r328695611 ## File path: benchmarks/src/main/java/org/apache/druid/benchmark/query/ScanBenchmark.java ## @@

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-09-22 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r326897473 ## File path: benchmarks/src/main/java/org/apache/druid/benchmark/FloatCompressionBenchmarkFileGenerator.java

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-09-21 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r326856015 ## File path: benchmarks/src/main/java/org/apache/druid/benchmark/FilterPartitionBenchmark.java ##

[GitHub] [incubator-druid] leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field

2019-09-21 Thread GitBox
leventov commented on a change in pull request #8558: 7227 : Prohibit Non Final Static Field URL: https://github.com/apache/incubator-druid/pull/8558#discussion_r326855992 ## File path: benchmarks/src/main/java/org/apache/druid/benchmark/FloatCompressionBenchmark.java ##