jawidMuhammadi opened a new pull request #104:
URL: https://github.com/apache/fineract-cn-mobile/pull/104
Please Add Summary of what changes you have made and if possible provide
links.(Optional)
Please make sure these boxes are checked before submitting your pull request
-
vorburger commented on pull request #951:
URL: https://github.com/apache/fineract/pull/951#issuecomment-636724139
/rebase
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
fynmanoj commented on a change in pull request #948:
URL: https://github.com/apache/fineract/pull/948#discussion_r433055427
##
File path:
fineract-provider/src/main/java/org/apache/fineract/infrastructure/documentmanagement/api/ImagesApiResource.java
##
@@ -140,7 +140,8 @@
andreasrosdal commented on pull request #948:
URL: https://github.com/apache/fineract/pull/948#issuecomment-636698738
It's awesome that you want to use OpenPDF. Let me know if you need any
changes in OpenPDF. I am one of the OpenPDF maintainers.
vorburger commented on pull request #951:
URL: https://github.com/apache/fineract/pull/951#issuecomment-636730262
The build failure here was "just" due to the (very interesting!) finding of
@ptuomola in FINERACT-885.
FINERACT-1014 explains how this PR isn't only "nice", but actually
This is an automated email from the ASF dual-hosted git repository.
vorburger pushed a change to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git.
from 1a397c5 FINERACT-1005: Fixing staff validations and tests
add e295bef FINERACT-918: Changes to running
vorburger merged pull request #945:
URL: https://github.com/apache/fineract/pull/945
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
vorburger commented on pull request #945:
URL: https://github.com/apache/fineract/pull/945#issuecomment-636745057
This is SO COOL. I've just tested this by pulling down this PR and following
the doc - works great!! Merging ASAP.
vorburger commented on pull request #801:
URL: https://github.com/apache/fineract/pull/801#issuecomment-636702529
What I'm suggesting here is actually contradictory to what we discussed in
FINERACT-805 and what @xurror wants to do... so I'll probably close this PR
when we have a proposal
vorburger commented on pull request #863:
URL: https://github.com/apache/fineract/pull/863#issuecomment-636702191
What I'm suggesting here is actually contradictory to what we discussed in
FINERACT-805 and what @xurror wants to do... so I'll probably close this PR
when we have a proposal
vorburger removed a comment on pull request #863:
URL: https://github.com/apache/fineract/pull/863#issuecomment-636702191
What I'm suggesting here is actually contradictory to what we discussed in
FINERACT-805 and what @xurror wants to do... so I'll probably close this PR
when we have a
This is an automated email from the ASF dual-hosted git repository.
vorburger pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git
The following commit(s) were added to refs/heads/develop by this push:
new 1a397c5 FINERACT-1005: Fixing staff
vorburger commented on pull request #813:
URL: https://github.com/apache/fineract/pull/813#issuecomment-636692368
> add this to a property file so you can then comment the property in / out
when testing - but without needing to recompile:
`org.quartz.plugin.triggHistory.class =
vorburger closed pull request #813:
URL: https://github.com/apache/fineract/pull/813
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
vorburger merged pull request #952:
URL: https://github.com/apache/fineract/pull/952
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
vorburger commented on a change in pull request #951:
URL: https://github.com/apache/fineract/pull/951#discussion_r433130044
##
File path:
fineract-provider/src/main/java/org/apache/fineract/portfolio/interestratechart/data/InterestRateChartSlabDataValidator.java
##
@@ -239,7
vorburger commented on pull request #825:
URL: https://github.com/apache/fineract/pull/825#issuecomment-636717383
@nazeer1100126 respectfully pinging you if you are still interested to do a
rebase to get this in?
This is an
nnatarajan opened a new pull request #964:
URL: https://github.com/apache/fineract/pull/964
…lientAddress()
## Description
Describe the changes made and why they were made. Ignore if these details
are present on the associated Jira ticket
## Checklist
Please make sure
ptuomola opened a new pull request #965:
URL: https://github.com/apache/fineract/pull/965
## Description
Makes the OpenJPA Enhance builder to be a manually triggered external tool
in Eclipse, rather than an automatically triggered builder
## Checklist
Please make sure these
jawidMuhammadi opened a new pull request #105:
URL: https://github.com/apache/fineract-cn-mobile/pull/105
Please Add Screenshots If any UI changes.
Please Add Summary of what changes you have made and if possible provide
links.(Optional)
Please make sure these boxes are
vorburger merged pull request #960:
URL: https://github.com/apache/fineract/pull/960
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
This is an automated email from the ASF dual-hosted git repository.
vorburger pushed a change to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git.
from aed3e41 FINERACT-822 Enable CompareToZero check
add b6e6eba fix possible NPE in
vorburger commented on pull request #959:
URL: https://github.com/apache/fineract/pull/959#issuecomment-637069070
/rebase
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
vorburger commented on pull request #962:
URL: https://github.com/apache/fineract/pull/962#issuecomment-637075478
> Would you like to change the way Renovate is upgrading your dependencies?
Simply edit the renovate.json in this branch with your custom config and the
list of Pull Requests
ptuomola commented on pull request #958:
URL: https://github.com/apache/fineract/pull/958#issuecomment-637031568
Looks great to me. Even if there are still other reasons why this test
fails, I'm sure this is a step in the right direction...
vorburger commented on pull request #961:
URL: https://github.com/apache/fineract/pull/961#issuecomment-637065696
@awasum will you review this one?
This is an automated message from the Apache Git Service.
To respond to the
percyashu opened a new pull request #961:
URL: https://github.com/apache/fineract/pull/961
FINERACT-822
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
vorburger edited a comment on pull request #962:
URL: https://github.com/apache/fineract/pull/962#issuecomment-637071323
Build failure here is treated in FINERACT-855 and has absolutely nothing to
do with this PR for FINERACT-962.
renovate-bot opened a new pull request #962:
URL: https://github.com/apache/fineract/pull/962
Welcome to [Renovate](https://togithub.com/renovatebot/renovate)! This is an
onboarding PR to help you understand and configure settings before regular Pull
Requests begin.
vorburger commented on pull request #926:
URL: https://github.com/apache/fineract/pull/926#issuecomment-637068084
#960 @maektwain FYI you don't actually have to open a new PR, you can just
"force push" (next time)
This is
ptuomola commented on pull request #955:
URL: https://github.com/apache/fineract/pull/955#issuecomment-637033293
Looks great to me
This is an automated message from the Apache Git Service.
To respond to the message, please
ptuomola commented on pull request #956:
URL: https://github.com/apache/fineract/pull/956#issuecomment-637032593
Looks good to me!
This is an automated message from the Apache Git Service.
To respond to the message, please
vorburger commented on pull request #962:
URL: https://github.com/apache/fineract/pull/962#issuecomment-637064584
Wait a sec, before we merge this, let's figure out how to exclude the JS
stuff, from the docs.. I should already have that config, somewhere on my
fork.
>
vorburger commented on pull request #959:
URL: https://github.com/apache/fineract/pull/959#issuecomment-637077912
Build failure here is FINERACT-855 (has nothing to do with this PR for
FINERACT-950).
This is an automated
thesmallstar commented on a change in pull request #951:
URL: https://github.com/apache/fineract/pull/951#discussion_r43346
##
File path:
fineract-provider/src/main/java/org/apache/fineract/portfolio/interestratechart/data/InterestRateChartSlabDataValidator.java
##
@@
thesmallstar commented on pull request #943:
URL: https://github.com/apache/fineract/pull/943#issuecomment-637084564
@vorburger LGTY?
This is an automated message from the Apache Git Service.
To respond to the message,
maektwain commented on pull request #960:
URL: https://github.com/apache/fineract/pull/960#issuecomment-636926403
This could be merged if no errors in case @vorburger
This is an automated message from the Apache Git
thesmallstar commented on pull request #943:
URL: https://github.com/apache/fineract/pull/943#issuecomment-636907089
Yes, I will update this.
From what I have understood until now, Spotless and Checkstyles have
different approaches. Spotless(Based on the configuration) is more about
maektwain opened a new pull request #960:
URL: https://github.com/apache/fineract/pull/960
## Description
Describe the changes made and why they were made. Ignore if these details
are present on the associated Jira ticket
## Checklist
Please make sure these boxes are checked
maektwain commented on pull request #926:
URL: https://github.com/apache/fineract/pull/926#issuecomment-636923938
Let me reopen a new PR
This is an automated message from the Apache Git Service.
To respond to the message,
maektwain closed pull request #926:
URL: https://github.com/apache/fineract/pull/926
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
vorburger opened a new pull request #956:
URL: https://github.com/apache/fineract/pull/956
re. FINERACT-885 and FINERACT-922
This is an automated message from the Apache Git Service.
To respond to the message, please log on
vorburger commented on pull request #943:
URL: https://github.com/apache/fineract/pull/943#issuecomment-636932907
Yes, please proceed in this direction! (And do remove the changes to the
.java, to make this PR much easier to review.)
>
vorburger commented on a change in pull request #951:
URL: https://github.com/apache/fineract/pull/951#discussion_r433177786
##
File path:
fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/common/CenterDomain.java
##
@@ -231,7 +231,7 @@ public
vorburger commented on pull request #954:
URL: https://github.com/apache/fineract/pull/954#issuecomment-636797670
@percyashu I've noticed the change you made (for Error Prone) this while
code reviewing your #951 and that `hashCode()` method seemed a bit weird to
me... simplifying it like
vorburger commented on pull request #948:
URL: https://github.com/apache/fineract/pull/948#issuecomment-636811574
Oh, it's because of `java.util.Base64`'s _default_ VS _URL_ VS _MIME_
variants... I'll fix it. -- BTW: The (failing) `StaffImageApiTest` **really**
should cover
vorburger commented on pull request #955:
URL: https://github.com/apache/fineract/pull/955#issuecomment-636825636
@xurror @awasum @ptuomola this is a follow-up to #708 for FINERACT-840 - OK
for you?
This is an automated
vorburger commented on pull request #926:
URL: https://github.com/apache/fineract/pull/926#issuecomment-636826609
@maektwain LGTM but as previously requested, all commits must be squashed
into 1 please.
This is an automated
vorburger opened a new pull request #959:
URL: https://github.com/apache/fineract/pull/959
FINERACT-950
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
vorburger edited a comment on pull request #943:
URL: https://github.com/apache/fineract/pull/943#issuecomment-636757443
@thesmallstar So this idea look very interesting, to me; thanks for having
investigated this! But I'd like to fully understand exactly what we are doing
here a little
maektwain commented on pull request #796:
URL: https://github.com/apache/fineract/pull/796#issuecomment-636816408
Yeah , @vorburger I am planning to finish this, I need to write tests which
are really crazy will be able to finish this tomorrow
vorburger commented on pull request #956:
URL: https://github.com/apache/fineract/pull/956#issuecomment-636862684
@ptuomola how about this - LGTY? I'm not 100% sure this isn't still flaky,
but it's worth to try...
This is
vorburger commented on pull request #958:
URL: https://github.com/apache/fineract/pull/958#issuecomment-636867998
@ptuomola how about this - LGTY? I'm not 100% sure this isn't still flaky,
but it's worth to try...
This is
vorburger commented on pull request #948:
URL: https://github.com/apache/fineract/pull/948#issuecomment-636778244
This is now failing an integration test because of the changes I made here
(not flaky), still something with that Base64 change... I haven't been able to
entirely understand
This is an automated email from the ASF dual-hosted git repository.
vorburger pushed a change to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git.
from e295bef FINERACT-918: Changes to running and debugging in Eclipse
add aed3e41 FINERACT-822 Enable
vorburger merged pull request #951:
URL: https://github.com/apache/fineract/pull/951
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
vorburger opened a new pull request #957:
URL: https://github.com/apache/fineract/pull/957
for FINERACT-922
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
vorburger opened a new pull request #953:
URL: https://github.com/apache/fineract/pull/953
This fixes one of too many ;) warnings Eclipse shows.
It is correct that the condition this checked is useless,
because that is already checked for in the method it calls.
(BTW it's
maektwain commented on pull request #926:
URL: https://github.com/apache/fineract/pull/926#issuecomment-636815411
Does it makes sense to you ?
This is an automated message from the Apache Git Service.
To respond to the
maektwain edited a comment on pull request #926:
URL: https://github.com/apache/fineract/pull/926#issuecomment-636815411
Does it makes sense to you ? oh didn't realise I had this merge on top?
This is an automated message
vorburger closed pull request #762:
URL: https://github.com/apache/fineract/pull/762
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
vorburger commented on pull request #762:
URL: https://github.com/apache/fineract/pull/762#issuecomment-636853882
I want to leave this for anyone else interested to work on, and am
"abandoning" this PR (and have un-assigned FINERACT-891; feel free to pick it
up).
thesmallstar opened a new pull request #963:
URL: https://github.com/apache/fineract/pull/963
Making an exception to the stopped checkstyle work as this won't cause any
merge conflicts due to spotless.
This is an automated
vorburger commented on pull request #964:
URL: https://github.com/apache/fineract/pull/964#issuecomment-637266797
Build failure here is FINERACT-855 - please help us fix it.
This is an automated message from the Apache Git
vorburger commented on pull request #963:
URL: https://github.com/apache/fineract/pull/963#issuecomment-637266813
Build failure here is FINERACT-855 - please help us fix it.
This is an automated message from the Apache Git
vorburger commented on pull request #965:
URL: https://github.com/apache/fineract/pull/965#issuecomment-637267592
Build will likely fail here as in other recent PRs due to FINERACT-855 -
please help us fix it.
This is an
vorburger opened a new pull request #968:
URL: https://github.com/apache/fineract/pull/968
testPrematureClosureAmountWithPenalInterestTillPrematureWithdrawal_With_360_Days()
This is an automated message from the Apache Git
vorburger commented on a change in pull request #961:
URL: https://github.com/apache/fineract/pull/961#discussion_r433615067
##
File path: fineract-provider/build.gradle
##
@@ -324,7 +324,6 @@ tasks.withType(JavaCompile) {
"BadImport",
vorburger commented on a change in pull request #960:
URL: https://github.com/apache/fineract/pull/960#discussion_r433621124
##
File path:
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/AbstractLoanScheduleGenerator.java
##
@@
vorburger commented on pull request #967:
URL: https://github.com/apache/fineract/pull/967#issuecomment-637274762
@maektwain see new inline review comment on (already merged) #960 re. this -
do you agree this was wrong?
I'm not sure if it's causing FINERACT-855 or if that's an
vorburger commented on pull request #968:
URL: https://github.com/apache/fineract/pull/968#issuecomment-637291357
@ptuomola until we (you?) figure out what's going in FINERACT-1016, would
you object to (yet another..) `@Ignore` here, for now, just to unblock other
PRs?
vorburger commented on pull request #965:
URL: https://github.com/apache/fineract/pull/965#issuecomment-637294040
This will have to be re-based after #968 for FINERACT-1016 for the build to
pass.
This is an automated
vorburger commented on pull request #963:
URL: https://github.com/apache/fineract/pull/963#issuecomment-637294122
This will have to be re-based after #968 for FINERACT-1016 for the build to
pass.
This is an automated
vorburger commented on pull request #962:
URL: https://github.com/apache/fineract/pull/962#issuecomment-637294157
This will have to be re-based after #968 for FINERACT-1016 for the build to
pass.
This is an automated
vorburger commented on pull request #964:
URL: https://github.com/apache/fineract/pull/964#issuecomment-637294082
This will have to be re-based after #968 for FINERACT-1016 for the build to
pass.
This is an automated
vorburger opened a new pull request #966:
URL: https://github.com/apache/fineract/pull/966
FINERACT-922
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
vorburger commented on pull request #967:
URL: https://github.com/apache/fineract/pull/967#issuecomment-637293514
@maektwain this actually has absolutely nothing to do with FINERACT-855 (now
FINERACT-1016), but it still seems to me that line in your PR #960 was clearly
wrong and should
vorburger commented on pull request #959:
URL: https://github.com/apache/fineract/pull/959#issuecomment-637293812
This will have to be re-based after #968 for FINERACT-1016 for the build to
pass.
This is an automated
vorburger commented on pull request #966:
URL: https://github.com/apache/fineract/pull/966#issuecomment-637293852
This will have to be re-based after #968 for FINERACT-1016 for the build to
pass.
This is an automated
79 matches
Mail list logo
