[GitHub] viswaramamoorthy commented on issue #3: Docker infrastructure for Eureka and ActiveMQ

2018-04-14 Thread GitBox
viswaramamoorthy commented on issue #3: Docker infrastructure for Eureka and 
ActiveMQ
URL: 
https://github.com/apache/fineract-cn-demo-server/pull/3#issuecomment-381354598
 
 
   @myrle-krantz I have adopted ClassRule changes to start Embedded Eureka and 
ActiveMQ. Please note that I was able to verify demo server start up after 
starting Docker based Eureka, ActiveMQ, MariaDB and Cassandra. It works 
consistently.
   
   I could not verify embedded Eureka and ActiveMQ as it always fails. I am not 
sure that errors I see are related to processor or memory - because the error 
is at very early stage 
   
   Below is the error
   Time: 57.92
   There was 1 failure:
   1) io.mifos.dev.ServiceRunner
   
org.springframework.boot.context.embedded.tomcat.ConnectorStartFailedException: 
Connector configured to listen on port 8761 failed to start
   
   Anyway, if you could verify embedded infrastructure with my PR, please merge


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] viswaramamoorthy commented on issue #3: Docker infrastructure for Eureka and ActiveMQ

2018-04-14 Thread GitBox
viswaramamoorthy commented on issue #3: Docker infrastructure for Eureka and 
ActiveMQ
URL: 
https://github.com/apache/fineract-cn-demo-server/pull/3#issuecomment-381354598
 
 
   @myrle-krantz I have adopted ClassRule changes to start Embedded Eureka and 
ActiveMQ. Please note that I was able to verify demo server start up after 
starting Docker based Eureka, ActiveMQ, MariaDB and Cassandra. It works 
consistently.
   
   I could not verify embedded as it always fails. Below is the error. If you 
could verify embedded infrastructure with my PR, please merge


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] viswaramamoorthy commented on issue #3: Docker infrastructure for Eureka and ActiveMQ

2018-04-10 Thread GitBox
viswaramamoorthy commented on issue #3: Docker infrastructure for Eureka and 
ActiveMQ
URL: 
https://github.com/apache/fineract-cn-demo-server/pull/3#issuecomment-380044778
 
 
   Hi Myrtle,
   
   Regarding your DiscoveryClient comment, I have seen it. The reason, I have 
introduced application.yml in demo-server with EurekaRegistration turned off, 
to really address exceptions seen in demo-server that I noted in my above 
comment. It is to address that and DiscoveryClient checks were retained in my 
PR as is. From I have tested, EurekaRegistration need not be done in 
demo-server but still you could Autowire/use DiscoveryClient to check if other 
services are up. Someone can verify if the exceptions that I noted above are 
seen or not. Also, when this is deployed in a VM, it gives a common deployed 
environment to check on these. For now, my Eureka exception related comments 
can be parked and monitored.
   
   On the ClassRule suggestions and changes, I am not sure if utilizing Junit 
to launch services is really a good practice. Junit is largely for testing 
purposes. Although demo-server is not for production deployment (my hope is 
this :-) ), it still looks awkward to utilize it for demo-server. I was really 
questioning defining standard practice surrounding a technology which probably 
does not fit in this case. 
   
   In any case, if you have already done change in fineract-cn-test, I assume 
that I need to pull that and make minor changes in demo-server to adopt it, 
test and update this PR for merge. Is my understanding correct?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] viswaramamoorthy commented on issue #3: Docker infrastructure for Eureka and ActiveMQ

2018-04-07 Thread GitBox
viswaramamoorthy commented on issue #3: Docker infrastructure for Eureka and 
ActiveMQ
URL: 
https://github.com/apache/fineract-cn-demo-server/pull/3#issuecomment-379464885
 
 
   @myrle-krantz Hello, regarding PR review comment "@ Before can be run 
multiple times for a class", I agree when there are many tests in a 
SpringBootTest class. With a single "@ Test" in ServiceRunner, will Junit @ 
Before annotated method can run multiple times? May be I am missing something 
here. I want understand it and change.
   
   Regarding application.yml file introduced in demo server, it is required 
because without that demo server attempts to register with Eureka and below 
error seen from demo server. Also, is demo server discoverable? My assumption 
is that it is not and hence turn off Eureka registration from demo server. But 
services will continue to register because they are discoverable.
   
   **Error from demo-server** 
   07:48:20.737 [DiscoveryClient-HeartbeatExecutor-0] ERROR 
c.netflix.discovery.DiscoveryClient - DiscoveryClient_UNKNOWN/localhost:-1 - 
was unable to send heartbeat!
   com.netflix.discovery.shared.transport.TransportException: Cannot execute 
request on any known server
at 
com.netflix.discovery.shared.transport.decorator.RetryableEurekaHttpClient.execute(RetryableEurekaHttpClient.java:111)
at 
com.netflix.discovery.shared.transport.decorator.EurekaHttpClientDecorator.sendHeartBeat(EurekaHttpClientDecorator.java:89)
at 
com.netflix.discovery.shared.transport.decorator.EurekaHttpClientDecorator$3.execute(EurekaHttpClientDecorator.java:92)
at 
com.netflix.discovery.shared.transport.decorator.SessionedEurekaHttpClient.execute(SessionedEurekaHttpClient.java:77)
at 
com.netflix.discovery.shared.transport.decorator.EurekaHttpClientDecorator.sendHeartBeat(EurekaHttpClientDecorator.java:89)
at com.netflix.discovery.DiscoveryClient.renew(DiscoveryClient.java:832)
at 
com.netflix.discovery.DiscoveryClient$HeartbeatThread.run(DiscoveryClient.java:1396)
at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
at java.util.concurrent.FutureTask.run(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
at java.lang.Thread.run(Unknown Source)
   
   My earlier comments about Eureka issues are really about heart beat errors 
in provisioner, identity etc. Below is a sample error from identify.log. I am 
not sure how you or @awasum not seeing this error. Is it because of embedded 
server that masks this issue? Below error will ultimately lead to wrong service 
status and affect service discoverability...
   
   **Eureka heart beat error from Identity**
   07:50:52.172 [DiscoveryClient-HeartbeatExecutor-0] ERROR 
c.netflix.discovery.DiscoveryClient - 
DiscoveryClient_IDENTITY-V1/localhost:identity-v1:2021 - was unable to send 
heartbeat!
   com.netflix.discovery.shared.transport.TransportException: Cannot execute 
request on any known server
at 
com.netflix.discovery.shared.transport.decorator.RetryableEurekaHttpClient.execute(RetryableEurekaHttpClient.java:111)
at 
com.netflix.discovery.shared.transport.decorator.EurekaHttpClientDecorator.sendHeartBeat(EurekaHttpClientDecorator.java:89)
at 
com.netflix.discovery.shared.transport.decorator.EurekaHttpClientDecorator$3.execute(EurekaHttpClientDecorator.java:92)
at 
com.netflix.discovery.shared.transport.decorator.SessionedEurekaHttpClient.execute(SessionedEurekaHttpClient.java:77)
at 
com.netflix.discovery.shared.transport.decorator.EurekaHttpClientDecorator.sendHeartBeat(EurekaHttpClientDecorator.java:89)
at com.netflix.discovery.DiscoveryClient.renew(DiscoveryClient.java:832)
at 
com.netflix.discovery.DiscoveryClient$HeartbeatThread.run(DiscoveryClient.java:1396)
at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
at java.util.concurrent.FutureTask.run(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
at java.lang.Thread.run(Unknown Source)
   07:50:53.191 [DiscoveryClient-HeartbeatExecutor-0] ERROR 
c.n.d.s.t.d.RedirectingEurekaHttpClient - Request execution error
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] viswaramamoorthy commented on issue #3: Docker infrastructure for Eureka and ActiveMQ

2018-04-07 Thread GitBox
viswaramamoorthy commented on issue #3: Docker infrastructure for Eureka and 
ActiveMQ
URL: 
https://github.com/apache/fineract-cn-demo-server/pull/3#issuecomment-379464885
 
 
   @myrle-krantz Hello, regarding PR review comment "@ Before can be run 
multiple times for a class", I agree when there many tests in a SpringBootTest 
class. With a single "@ Test" in ServiceRunner, will Junit Before annotated 
method can run multiple times? May be I am missing something here. I want 
understand it and change.
   
   Regarding application.yml file introduced in demo server, it is required 
because without that demo server attempts to register with Eureka and below 
error seen from demo server. Also, is demo server discoverable? My assumption 
is that it is not and hence turn off Eureka registration from demo server. But 
services will continue to register because they are discoverable.
   **Error from demo-server** 
   07:48:20.737 [DiscoveryClient-HeartbeatExecutor-0] ERROR 
c.netflix.discovery.DiscoveryClient - DiscoveryClient_UNKNOWN/localhost:-1 - 
was unable to send heartbeat!
   com.netflix.discovery.shared.transport.TransportException: Cannot execute 
request on any known server
at 
com.netflix.discovery.shared.transport.decorator.RetryableEurekaHttpClient.execute(RetryableEurekaHttpClient.java:111)
at 
com.netflix.discovery.shared.transport.decorator.EurekaHttpClientDecorator.sendHeartBeat(EurekaHttpClientDecorator.java:89)
at 
com.netflix.discovery.shared.transport.decorator.EurekaHttpClientDecorator$3.execute(EurekaHttpClientDecorator.java:92)
at 
com.netflix.discovery.shared.transport.decorator.SessionedEurekaHttpClient.execute(SessionedEurekaHttpClient.java:77)
at 
com.netflix.discovery.shared.transport.decorator.EurekaHttpClientDecorator.sendHeartBeat(EurekaHttpClientDecorator.java:89)
at com.netflix.discovery.DiscoveryClient.renew(DiscoveryClient.java:832)
at 
com.netflix.discovery.DiscoveryClient$HeartbeatThread.run(DiscoveryClient.java:1396)
at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
at java.util.concurrent.FutureTask.run(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
at java.lang.Thread.run(Unknown Source)
   
   My earlier comments about Eureka issues are really about heart beat errors 
in provisioner, identity etc. Below is a sample error from identify. I am not 
how you or @awasum not seeing this. Is it because of embedded server that masks 
this issue. Note that below error will ultimately lead to wrong service status 
and affect service discoverability
   **Eureka heart beat error from Identity**
   07:50:52.172 [DiscoveryClient-HeartbeatExecutor-0] ERROR 
c.netflix.discovery.DiscoveryClient - 
DiscoveryClient_IDENTITY-V1/localhost:identity-v1:2021 - was unable to send 
heartbeat!
   com.netflix.discovery.shared.transport.TransportException: Cannot execute 
request on any known server
at 
com.netflix.discovery.shared.transport.decorator.RetryableEurekaHttpClient.execute(RetryableEurekaHttpClient.java:111)
at 
com.netflix.discovery.shared.transport.decorator.EurekaHttpClientDecorator.sendHeartBeat(EurekaHttpClientDecorator.java:89)
at 
com.netflix.discovery.shared.transport.decorator.EurekaHttpClientDecorator$3.execute(EurekaHttpClientDecorator.java:92)
at 
com.netflix.discovery.shared.transport.decorator.SessionedEurekaHttpClient.execute(SessionedEurekaHttpClient.java:77)
at 
com.netflix.discovery.shared.transport.decorator.EurekaHttpClientDecorator.sendHeartBeat(EurekaHttpClientDecorator.java:89)
at com.netflix.discovery.DiscoveryClient.renew(DiscoveryClient.java:832)
at 
com.netflix.discovery.DiscoveryClient$HeartbeatThread.run(DiscoveryClient.java:1396)
at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
at java.util.concurrent.FutureTask.run(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
at java.lang.Thread.run(Unknown Source)
   07:50:53.191 [DiscoveryClient-HeartbeatExecutor-0] ERROR 
c.n.d.s.t.d.RedirectingEurekaHttpClient - Request execution error
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] viswaramamoorthy commented on issue #3: Docker infrastructure for Eureka and ActiveMQ

2018-04-05 Thread GitBox
viswaramamoorthy commented on issue #3: Docker infrastructure for Eureka and 
ActiveMQ
URL: 
https://github.com/apache/fineract-cn-demo-server/pull/3#issuecomment-378875872
 
 
   @awasum Assuming you are able launch demo server with embedded Eureka etc,. 
are not seeing exception indicating Eureka heart beat failure? when this 
exception happens, Junit shuts down after attempting to launch couple of 
services. 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] viswaramamoorthy commented on issue #3: Docker infrastructure for Eureka and ActiveMQ

2018-04-04 Thread GitBox
viswaramamoorthy commented on issue #3: Docker infrastructure for Eureka and 
ActiveMQ
URL: 
https://github.com/apache/fineract-cn-demo-server/pull/3#issuecomment-378770947
 
 
   I have no idea. 
   
   Other bigger question I had was whether anyone can successfully run 
demo-server and all services. I have not heard anything on that. I could not 
run demo-server and all of the services it launches. With external 
infrastructure it helps significantly and that is this PR. Needs more fixes 
overall.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services