[GitHub] [incubator-mxnet] TaoLv commented on a change in pull request #17884: [MKL-DNN] Integrate Conv3d and Pool3d/1d

2020-03-25 Thread GitBox
TaoLv commented on a change in pull request #17884: [MKL-DNN] Integrate Conv3d and Pool3d/1d URL: https://github.com/apache/incubator-mxnet/pull/17884#discussion_r397866258 ## File path: src/operator/nn/mkldnn/mkldnn_pooling-inl.h ## @@ -114,15 +115,21 @@ inline bool Suppo

[GitHub] [incubator-mxnet] TaoLv commented on a change in pull request #17884: [MKL-DNN] Integrate Conv3d and Pool3d/1d

2020-03-25 Thread GitBox
TaoLv commented on a change in pull request #17884: [MKL-DNN] Integrate Conv3d and Pool3d/1d URL: https://github.com/apache/incubator-mxnet/pull/17884#discussion_r397869347 ## File path: src/operator/nn/pooling.cc ## @@ -274,12 +274,12 @@ void PoolingComputeExCPU(const nnv

[GitHub] [incubator-mxnet] TaoLv commented on a change in pull request #17884: [MKL-DNN] Integrate Conv3d and Pool3d/1d

2020-03-23 Thread GitBox
TaoLv commented on a change in pull request #17884: [MKL-DNN] Integrate Conv3d and Pool3d/1d URL: https://github.com/apache/incubator-mxnet/pull/17884#discussion_r396524720 ## File path: src/operator/nn/mkldnn/mkldnn_pooling.cc ## @@ -127,61 +116,139 @@ mkldnn::algorithm G

[GitHub] [incubator-mxnet] TaoLv commented on a change in pull request #17884: [MKL-DNN] Integrate Conv3d and Pool3d/1d

2020-03-23 Thread GitBox
TaoLv commented on a change in pull request #17884: [MKL-DNN] Integrate Conv3d and Pool3d/1d URL: https://github.com/apache/incubator-mxnet/pull/17884#discussion_r396523088 ## File path: src/operator/nn/mkldnn/mkldnn_pooling-inl.h ## @@ -114,15 +115,21 @@ inline bool Suppo

[GitHub] [incubator-mxnet] TaoLv commented on a change in pull request #17884: [MKL-DNN] Integrate Conv3d and Pool3d/1d

2020-03-23 Thread GitBox
TaoLv commented on a change in pull request #17884: [MKL-DNN] Integrate Conv3d and Pool3d/1d URL: https://github.com/apache/incubator-mxnet/pull/17884#discussion_r396512804 ## File path: src/operator/nn/mkldnn/mkldnn_base-inl.h ## @@ -153,9 +153,8 @@ static inline bool Sup

[GitHub] [incubator-mxnet] TaoLv commented on a change in pull request #17884: [MKL-DNN] Integrate Conv3d and Pool3d/1d

2020-03-23 Thread GitBox
TaoLv commented on a change in pull request #17884: [MKL-DNN] Integrate Conv3d and Pool3d/1d URL: https://github.com/apache/incubator-mxnet/pull/17884#discussion_r396517882 ## File path: src/operator/nn/mkldnn/mkldnn_base-inl.h ## @@ -324,20 +323,27 @@ inline static mkldnn